Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(schema/mysql): migrate GetDatabaseMetadata to omni catalog (#19905)
rebelice792f5e69918b
diff --git a/backend/plugin/schema/mysql/get_database_metadata.go b/backend/plugin/schema/mysql/get_database_metadata.goindex b7c53c0099..a6b68d9d1b 100644--- a/backend/plugin/schema/mysql/get_database_metadata.go+++ b/backend/plugin/schema/mysql/get_database_metadata.go@@ -12,13 +12,10 @@ import (storepb "github.com/bytebase/bytebase/backend/generated-go/store"mysqlparser "github.com/bytebase/bytebase/backend/plugin/parser/mysql"- "github.com/bytebase/bytebase/backend/plugin/schema")-func init() {- schema.RegisterGetDatabaseMetadata(storepb.Engine_MYSQL, GetDatabaseMetadata)- schema.RegisterGetDatabaseMetadata(storepb.Engine_OCEANBASE, GetDatabaseMetadata)-}+// Old ANTLR-based GetDatabaseMetadata registrations removed.+// GetDatabaseMetadataOmni is now registered in get_database_metadata_omni.go.// GetDatabaseMetadata parses the MySQL schema text and returns the database metadata.func GetDatabaseMetadata(schemaText string) (*storepb.DatabaseSchemaMetadata, error) {diff --git a/backend/plugin/schema/mysql/get_database_metadata_omni.go b/backend/plugin/schema/mysql/get_database_metadata_omni.gonew file mode 100644index 0000000000..ffd39e8e96--- /dev/null+++ b/backend/plugin/schema/mysql/get_database_metadata_omni.go@@ -0,0 +1,46 @@+package mysql++import (+ "fmt"++ "github.com/bytebase/omni/mysql/catalog"+ "github.com/pkg/errors"++ storepb "github.com/bytebase/bytebase/backend/generated-go/store"+ "github.com/bytebase/bytebase/backend/plugin/schema"+)++func init() {+ schema.RegisterGetDatabaseMetadata(storepb.Engine_MYSQL, GetDatabaseMetadataOmni)+ schema.RegisterGetDatabaseMetadata(storepb.Engine_OCEANBASE, GetDatabaseMetadataOmni)+}++// GetDatabaseMetadataOmni parses MySQL schema DDL text and returns database metadata+// using the omni catalog. This replaces the ANTLR-based GetDatabaseMetadata.+func GetDatabaseMetadataOmni(schemaText string) (*storepb.DatabaseSchemaMetadata, error) {+ if schemaText == "" {+ return &storepb.DatabaseSchemaMetadata{}, nil+ }++ const dbName = "tmp"+ c := catalog.New()+ initSQL := fmt.Sprintf("SET foreign_key_checks = 0;\nCREATE DATABASE IF NOT EXISTS `%s`;\nUSE `%s`;", dbName, dbName)+ if _, err := c.Exec(initSQL, nil); err != nil {+ return nil, errors.Wrap(err, "failed to initialize catalog")+ }++ results, err := c.Exec(schemaText, &catalog.ExecOptions{ContinueOnError: true})+ if err != nil {+ return nil, errors.Wrap(err, "failed to parse schema DDL")+ }++ // Check for hard errors (not per-statement errors).+ for _, r := range results {+ if r.Error != nil {+ return nil, errors.Wrapf(r.Error, "failed to execute schema DDL")+ }+ }++ proto := catalogToProto(c, dbName)+ return proto, nil+}