Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(starrocks): new database creation from UI (#18394)

Diego Caspi7c076d621a04
diff --git a/backend/api/v1/rollout_service_task.go b/backend/api/v1/rollout_service_task.go
index e24430448d..b88ffe17d1 100644
--- a/backend/api/v1/rollout_service_task.go
+++ b/backend/api/v1/rollout_service_task.go
@@ -532,7 +532,7 @@ func checkCharacterSetCollationOwner(dbType storepb.Engine, characterSet, collat
if owner == "" {
return errors.Errorf("database owner is required for CockroachDB")
}
- case storepb.Engine_SQLITE, storepb.Engine_MONGODB, storepb.Engine_MSSQL, storepb.Engine_DORIS:
+ case storepb.Engine_SQLITE, storepb.Engine_MONGODB, storepb.Engine_MSSQL, storepb.Engine_DORIS, storepb.Engine_STARROCKS:
// no-op.
default:
if characterSet == "" {
@@ -606,6 +606,8 @@ func getCreateDatabaseStatement(dbType storepb.Engine, c *storepb.PlanConfig_Cre
return fmt.Sprintf("CREATE DATABASE %s;", databaseName), nil
case storepb.Engine_DORIS:
return fmt.Sprintf("CREATE DATABASE %s;", databaseName), nil
+ case storepb.Engine_STARROCKS:
+ return fmt.Sprintf("CREATE DATABASE `%s`;", databaseName), nil
default:
return "", errors.Errorf("unsupported database type %s", dbType)
}
diff --git a/backend/plugin/db/starrocks/starrocks.go b/backend/plugin/db/starrocks/starrocks.go
index c76b69cff0..f055eb9875 100644
--- a/backend/plugin/db/starrocks/starrocks.go
+++ b/backend/plugin/db/starrocks/starrocks.go
@@ -173,7 +173,7 @@ func (d *Driver) Execute(ctx context.Context, statement string, opts db.ExecuteO
// Note: StarRocks is an OLAP database with limited transaction support.
// For DDL operations, transactions are not supported. For DML operations,
// StarRocks supports transactions within certain limitations.
- if transactionMode == common.TransactionModeOff {
+ if transactionMode == common.TransactionModeOff || opts.CreateDatabase {
return d.executeInAutoCommitMode(ctx, statement)
}
return d.executeInTransactionMode(ctx, statement, opts)