Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(frontend): adapt to main's tooltip provider, semantic colors and MCP tables

zchpeter80341df8627c
diff --git a/frontend/biome-plugins/time-reading-through-hook.grit b/frontend/biome-plugins/time-reading-through-hook.grit
index ce79d60b1e..71f67c35b4 100644
--- a/frontend/biome-plugins/time-reading-through-hook.grit
+++ b/frontend/biome-plugins/time-reading-through-hook.grit
@@ -6,8 +6,10 @@
// The rule is about the member, not the name it is reached through, so this
// matches `read` and `nextChangeAt` wherever they are named: under an alias,
// through a local or a table, via `.call`, passed as a callback, or optionally
-// chained. It also rejects an object that defines those members, which is what
-// keeps readings in the modules below rather than assembled at a display.
+// chained. It also rejects an object that defines `nextChangeAt`, which is what
+// keeps readings in the modules below rather than assembled at a display. An
+// object is judged by that member alone because a reading carries both and
+// `read` alone names plenty of things that have nothing to do with time.
//
// Where it stops, measured rather than assumed, is a key that is not a plain
// identifier or quoted string -- `x[key]` and ``x[`read`]`` both get past it --
@@ -25,14 +27,16 @@
// reading and reads it directly, since that is how it checks one at all.
//
// Matching the member rather than the receiver reserves these two names across
-// src/, and more widely than it first looks. A stream reader's `.read()` is
-// reported, and because the object-literal alternative uses `contains`, so is
-// any object literal with an identifier `read` anywhere beneath it: `{ onRead:
-// read }`, or a nested `{ handlers: { read } }`, which reports twice -- once
-// for each literal. None of this has anything to do with time, and none of it
-// exists in src/ today. If one arrives, rename it or exclude the file in
-// biome.json: the rule cannot tell them apart, and that is the price of
-// catching the spellings a name-based rule missed.
+// src/. A stream reader's `.read()` is reported, and so is any object literal
+// with an identifier `nextChangeAt` anywhere beneath it, however nested, which
+// reports once per literal. Neither has anything to do with time. When one
+// arrives, rename it or exclude the file in biome.json: the rule cannot tell
+// them apart, and that is the price of catching the spellings a name-based
+// rule missed. A literal keyed `read` without `nextChangeAt` is left alone --
+// the MCP capability tables in `src/components/mcp/` are keyed that way -- so
+// a half-assembled reading passes here and is caught where its `read` is
+// reached instead. Shorthand `{ read }` keeps its own alternative, since that
+// spelling is a reading being unpacked or passed on, not a table of flags.
language js
pattern reached_past_the_hook() {
@@ -43,7 +47,8 @@ pattern reached_past_the_hook() {
js"{ $member: $binding }" where {
or { $member <: `read`, $member <: `nextChangeAt` }
},
- js"{ $properties }" where { $properties <: contains or { `read`, `nextChangeAt` } },
+ js"{ read }",
+ js"{ $properties }" where { $properties <: contains `nextChangeAt` },
js"$object[$key]" where { or { $key <: `"read"`, $key <: `"nextChangeAt"` } }
}
}
diff --git a/frontend/src/components/AuditLogTable.test.tsx b/frontend/src/components/AuditLogTable.test.tsx
index f28adb1702..65bcccbb73 100644
--- a/frontend/src/components/AuditLogTable.test.tsx
+++ b/frontend/src/components/AuditLogTable.test.tsx
@@ -1,16 +1,16 @@
import { create } from "@bufbuild/protobuf";
+import { timestampFromMs, anyPack } from "@bufbuild/protobuf/wkt";
import type { ReactElement } from "react";
import { act } from "react";
import { createRoot } from "react-dom/client";
import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
+import { TIMESTAMP_COLUMN_WIDTH } from "@/components/timestampColumn";
import { StatusSchema } from "@/types/proto-es/google/rpc/status_pb";
import {
AuditLog_Severity,
AuditLogSchema,
} from "@/types/proto-es/v1/audit_log_service_pb";
import { PermissionDeniedDetailSchema } from "@/types/proto-es/v1/common_pb";
-import { timestampFromMs, anyPack } from "@bufbuild/protobuf/wkt";
-import { TIMESTAMP_COLUMN_WIDTH } from "@/components/timestampColumn";
(
globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
@@ -173,27 +173,6 @@ afterEach(() => {
});
describe("AuditLogTable", () => {
- );
- );
- await render();
-
- const handle = container.querySelector("th [class*=cursor-col-resize]");
- expect(handle).not.toBeNull();
- const [created] = Array.from(container.querySelectorAll("col"));
- act(() => {
- handle?.dispatchEvent(
- new MouseEvent("mousedown", { bubbles: true, clientX: 400 })
- );
- document.dispatchEvent(new MouseEvent("mousemove", { clientX: 300 }));
- document.dispatchEvent(new MouseEvent("mouseup"));
- });
- expect(created.style.width).toBe(
- `${TIMESTAMP_COLUMN.datetime.width - 100}px`
- );
-
- unmount();
- });
-
test("opens the date whole, and lets a reader narrow it to the day", async () => {
mocks.searchAuditLogs.mockResolvedValue({
auditLogs: [
@@ -228,30 +207,9 @@ describe("AuditLogTable", () => {
const date = container.querySelector("tbody tr td:first-child");
expect(date?.querySelector(".shrink-0")).not.toBeNull();
expect(date?.querySelector(".truncate")).not.toBeNull();
-
unmount();
});
- test("keeps the full date-time on one line at any width", async () => {
- // The evidence tier's tooltip is the age, which cannot give the value
- // back, so its column never narrows past the form: sized to it, and the
- // floor a drag stops at.
- mocks.searchAuditLogs.mockResolvedValue({
- auditLogs: [create(AuditLogSchema, { name: "auditLogs/1" })],
- nextPageToken: "",
- });
- const { container, render, unmount } = renderIntoContainer(
- <AuditLogTable parent="projects/-" canExport={false} />
- );
- await render();
-
- const [created] = Array.from(container.querySelectorAll("col"));
- expect(created.style.width).toBe(`${TIMESTAMP_COLUMN.datetime.width}px`);
-
- unmount();
- });
-
-
test("searches only the matching special-account kind for a prefixed actor", async () => {
mocks.searchAuditLogs.mockResolvedValue({ auditLogs: [], nextPageToken: "" });
mocks.listServiceAccounts.mockResolvedValue({
diff --git a/frontend/src/routes/project/ProjectMaskingExemptionPage.tsx b/frontend/src/routes/project/ProjectMaskingExemptionPage.tsx
index 0c51a9ef0e..b7f657b3f5 100644
--- a/frontend/src/routes/project/ProjectMaskingExemptionPage.tsx
+++ b/frontend/src/routes/project/ProjectMaskingExemptionPage.tsx
@@ -1110,7 +1110,7 @@ function ExemptionGrantSection({
<span className="font-medium text-sm">{title}</span>
{/* No reading means no expiry: zero is this API's "never". */}
{!daysLeft ? (
- <span className="text-xs font-medium text-amber-600">
+ <span className="text-xs font-medium text-warning">
{t("settings.sensitive-data.never-expires")}
</span>
) : daysLeft.kind === "passed" ? (
diff --git a/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx b/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx
index 1027bb522d..69bd62de45 100644
--- a/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx
+++ b/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx
@@ -243,7 +243,7 @@ describe("CommentThreadCard", () => {
});
const [thread] = groupThreads([comment("root", "Root question"), reply]);
render(
- <CommentThreadCard issueName={ISSUE} project={project} thread={thread} />
+ <CommentThreadCard issue={issue} project={project} thread={thread} />
);
const shown = shownTimestampInstants(container);