Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(frontend): open every timestamp column whole, and measure what whole is

zchpeter805a2b8e6963
diff --git a/docs/design/timestamp-display.md b/docs/design/timestamp-display.md
index 13d5ed8194..6005adbbd0 100644
--- a/docs/design/timestamp-display.md
+++ b/docs/design/timestamp-display.md
@@ -135,16 +135,17 @@ Objective divider: **exportable-as-evidence or a detail view → full; scannable
compact.**
**Column width follows the form.** Moving a surface off relative wording lengthens its value — "3
-months ago" is about 125px in a table cell, the compact form 190, the operational 260, the full
-date-time 280 — so a column sized for the old wording breaks the new one across two lines or
-truncates it. Each form has a measured width (`TIMESTAMP_COLUMN`, the widest rendering across
-every shipped locale), and a column holding it opens at that width, so nothing is cut unless the
-reader chooses it. In a fixed-layout table the open-ended column — a title, a statement — is the
-one left unsized: the browser spreads spare width across every sized column, so sizing them all
-lets the timestamp swell on a wide screen. The minimum is one floor for every form, room for the
-date, and a column narrower than its form ellipsizes rather than wraps. A reader who drags past
-the seconds or the zone has traded them for another column's room, and one drag undoes it; a floor
-at the widest case would take that trade away from everyone to serve a half-hour zone.
+months ago" is about 125px in a table cell, the compact form 192, the operational 270, the full
+date-time 292 — so a column sized for the old wording breaks the new one across two lines or cuts
+it off. Each form has a width (`TIMESTAMP_COLUMN_WIDTH`) measured over every time zone and shipped
+locale, and a column holding it never opens narrower, so nothing is cut unless the reader chooses
+it. How it is kept there depends on the table. Where the browser spreads spare width across every
+sized column, the open-ended column — a title, a statement — is left unsized to take it, so the
+date neither wraps nor swells; the audit log does not do this yet, and its date grows with the
+rest. Where a table fits its columns to the container itself, the date column does not grow, so
+its minimum floors a drag without also flooring the width it opens at. That minimum is one value
+for every form, room for the date; narrower than its form a cell ellipsizes, and one drag gives
+the rest back.
## Surface classification
diff --git a/frontend/src/components/AuditLogTable.test.tsx b/frontend/src/components/AuditLogTable.test.tsx
index 229460dff5..326f69e8f7 100644
--- a/frontend/src/components/AuditLogTable.test.tsx
+++ b/frontend/src/components/AuditLogTable.test.tsx
@@ -1,16 +1,16 @@
import { create } from "@bufbuild/protobuf";
-import { anyPack } from "@bufbuild/protobuf/wkt";
import type { ReactElement } from "react";
import { act } from "react";
import { createRoot } from "react-dom/client";
import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
import { StatusSchema } from "@/types/proto-es/google/rpc/status_pb";
import {
AuditLog_Severity,
AuditLogSchema,
} from "@/types/proto-es/v1/audit_log_service_pb";
import { PermissionDeniedDetailSchema } from "@/types/proto-es/v1/common_pb";
+import { timestampFromMs, anyPack } from "@bufbuild/protobuf/wkt";
+import { TIMESTAMP_COLUMN_WIDTH } from "@/components/timestampColumn";
(
globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
@@ -173,15 +173,7 @@ afterEach(() => {
});
describe("AuditLogTable", () => {
- test("lets the reader narrow the date column for room elsewhere", async () => {
- // The default shows the whole value; how much of it to keep is the
- // reader's trade against four other columns, and one drag undoes it.
- mocks.searchAuditLogs.mockResolvedValue({
- auditLogs: [create(AuditLogSchema, { name: "auditLogs/1" })],
- nextPageToken: "",
- });
- const { container, render, unmount } = renderIntoContainer(
- <AuditLogTable parent="projects/-" canExport={false} />
+ );
);
await render();
diff --git a/frontend/src/components/AuditLogTable.tsx b/frontend/src/components/AuditLogTable.tsx
index 7fda063aed..0ff468016f 100644
--- a/frontend/src/components/AuditLogTable.tsx
+++ b/frontend/src/components/AuditLogTable.tsx
@@ -16,7 +16,10 @@ import {
import { HumanizeTs } from "@/components/HumanizeTs";
import { RouterLink } from "@/components/RouterLink";
import { TimeRangePicker } from "@/components/TimeRangePicker";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import {
+ TIMESTAMP_COLUMN_MIN_WIDTH,
+ TIMESTAMP_COLUMN_WIDTH,
+} from "@/components/timestampColumn";
import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import { Dialog, DialogContent, DialogTitle } from "@/components/ui/dialog";
@@ -438,8 +441,8 @@ function useColumnDefs(): ColumnDef[] {
{
key: "create_time",
title: t("audit-log.table.created-ts"),
- defaultWidth: TIMESTAMP_COLUMN.datetime.width,
- minWidth: TIMESTAMP_COLUMN.datetime.minWidth,
+ defaultWidth: TIMESTAMP_COLUMN_WIDTH.datetime,
+ minWidth: TIMESTAMP_COLUMN_MIN_WIDTH,
resizable: true,
sortable: true,
render: (log: AuditLog) =>
diff --git a/frontend/src/components/timestampColumn.test.ts b/frontend/src/components/timestampColumn.test.ts
new file mode 100644
index 0000000000..00eb9a0f79
--- /dev/null
+++ b/frontend/src/components/timestampColumn.test.ts
@@ -0,0 +1,35 @@
+// @vitest-environment node
+import { describe, expect, test } from "vitest";
+import {
+ TIMESTAMP_COLUMN_MIN_WIDTH,
+ TIMESTAMP_COLUMN_WIDTH,
+} from "./timestampColumn";
+
+// jsdom has no font metrics, so these were measured in a browser: every IANA
+// zone, the five shipped locales, and every month and local hour of a year,
+// at 14px in the macOS system font, plus 32px of cell padding.
+const MEASURED_FORM = { compact: 191, operational: 269, datetime: 291 };
+const MEASURED_DATE = 140;
+
+const forms = Object.keys(MEASURED_FORM) as (keyof typeof MEASURED_FORM)[];
+
+describe("timestamp column widths", () => {
+ test.each(forms)(
+ "open a %s column wide enough for its widest rendering",
+ (form) => {
+ expect(TIMESTAMP_COLUMN_WIDTH[form]).toBeGreaterThanOrEqual(
+ MEASURED_FORM[form]
+ );
+ }
+ );
+
+ test("never narrow a column past the date", () => {
+ expect(TIMESTAMP_COLUMN_MIN_WIDTH).toBeGreaterThanOrEqual(MEASURED_DATE);
+ });
+
+ test.each(forms)("let a reader narrow a %s column at all", (form) => {
+ expect(TIMESTAMP_COLUMN_MIN_WIDTH).toBeLessThan(
+ TIMESTAMP_COLUMN_WIDTH[form]
+ );
+ });
+});
diff --git a/frontend/src/components/timestampColumn.ts b/frontend/src/components/timestampColumn.ts
index c96c0078cb..6b44d399be 100644
--- a/frontend/src/components/timestampColumn.ts
+++ b/frontend/src/components/timestampColumn.ts
@@ -2,22 +2,20 @@
// test that stubs the component still has the real widths to lay out with.
/**
- * The default width of a table column that holds a form on one line: the
- * widest rendering (a two-digit hour, a zone as long as GMT-3:30) at a
- * table's 14px, plus a cell's 32px of padding. Measured in every locale the
- * app ships; en-US is the widest in all three forms. The default shows the
- * whole value, so nothing is cut unless the reader chooses it.
- *
- * The minimum is one floor for every form -- room for the date -- rather than
- * the form's width. A reader who narrows a column past the seconds or the
- * zone has traded them for another column's room, and one drag undoes it;
- * a floor at the widest case would take that choice away from everyone to
- * serve a half-hour zone.
+ * The width a table column opens at to hold a form on one line: the widest
+ * rendering across every time zone and shipped locale at a table's 14px, plus
+ * a cell's 32px of padding. en-US in Chatham, GMT+12:45, is the widest in all
+ * three forms. Measured with the macOS system font; Segoe UI is not.
*/
-const MIN_WIDTH = 120;
-
-export const TIMESTAMP_COLUMN = {
- compact: { width: 190, minWidth: MIN_WIDTH },
- operational: { width: 260, minWidth: MIN_WIDTH },
- datetime: { width: 280, minWidth: MIN_WIDTH },
+export const TIMESTAMP_COLUMN_WIDTH = {
+ compact: 192,
+ operational: 270,
+ datetime: 292,
} as const;
+
+/**
+ * How far a reader may narrow any timestamp column: room for the date,
+ * measured the same way; ja-JP writes it widest. Past the date the cell
+ * ellipsizes, and one drag gives the rest back.
+ */
+export const TIMESTAMP_COLUMN_MIN_WIDTH = 140;
diff --git a/frontend/src/hooks/useColumnWidths.test.tsx b/frontend/src/hooks/useColumnWidths.test.tsx
index 7307ea52de..1f22c47976 100644
--- a/frontend/src/hooks/useColumnWidths.test.tsx
+++ b/frontend/src/hooks/useColumnWidths.test.tsx
@@ -1,7 +1,7 @@
import { act } from "react";
import { createRoot, type Root } from "react-dom/client";
import { afterEach, describe, expect, test, vi } from "vitest";
-import { useColumnWidths } from "./useColumnWidths";
+import { distributeColumnWidths, useColumnWidths } from "./useColumnWidths";
(
globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
@@ -365,3 +365,33 @@ describe("useColumnWidths", () => {
expect(handle.current!.onResizeStart).toBe(originalOnResizeStart);
});
});
+
+describe("distributeColumnWidths", () => {
+ test("a column that does not grow keeps its width at any container width", () => {
+ const columns = [
+ { key: "date", defaultWidth: 260, minWidth: 140, grow: false },
+ { key: "title", defaultWidth: 400, minWidth: 180 },
+ { key: "actions", defaultWidth: 100, resizable: false },
+ ];
+ for (const containerWidth of [700, 1100, 1800]) {
+ const [date, title, actions] = distributeColumnWidths(
+ columns,
+ containerWidth
+ );
+ expect(date).toBe(260);
+ expect(actions).toBe(100);
+ expect(title).toBe(Math.max(180, containerWidth - 360));
+ }
+ });
+
+ test("its minimum floors a drag, not the width it opens at", () => {
+ const [date] = distributeColumnWidths(
+ [
+ { key: "date", defaultWidth: 260, minWidth: 140, grow: false },
+ { key: "title", defaultWidth: 400 },
+ ],
+ 500
+ );
+ expect(date).toBe(260);
+ });
+});
diff --git a/frontend/src/hooks/useColumnWidths.ts b/frontend/src/hooks/useColumnWidths.ts
index 5445aa2f87..d50e7e8935 100644
--- a/frontend/src/hooks/useColumnWidths.ts
+++ b/frontend/src/hooks/useColumnWidths.ts
@@ -9,28 +9,35 @@ import {
export interface ColumnWithWidth {
defaultWidth: number;
minWidth?: number;
+ /**
+ * False for a column whose content has a width of its own, such as a date:
+ * it opens at `defaultWidth` however wide the table is, and `minWidth` only
+ * floors a drag. Otherwise `minWidth` floors both.
+ */
+ grow?: boolean;
}
/**
* Distributes `containerWidth` across columns so the table fills its container
* on first render instead of overflowing at the sum of `defaultWidth`s.
- * Columns with `resizable === false` keep their `defaultWidth`; the rest share
- * the remaining space proportionally to their `defaultWidth` (each clamped to
- * `minWidth`). Falls back to the raw default widths when the container is too
- * narrow to honor the minimums (the table then scrolls).
+ * Columns that are not resizable, or do not grow, keep their `defaultWidth`;
+ * the rest share the remaining space proportionally to their `defaultWidth`
+ * (each clamped to `minWidth`). Falls back to the raw default widths when the
+ * container is too narrow to honor the minimums (the table then scrolls).
*/
export function distributeColumnWidths<
T extends ColumnWithWidth & { resizable?: boolean },
>(columns: T[], containerWidth: number): number[] {
+ const keepsWidth = (c: T) => c.resizable === false || c.grow === false;
const fixedTotal = columns
- .filter((c) => c.resizable === false)
+ .filter(keepsWidth)
.reduce((sum, c) => sum + c.defaultWidth, 0);
const flexBaseTotal = columns
- .filter((c) => c.resizable !== false)
+ .filter((c) => !keepsWidth(c))
.reduce((sum, c) => sum + c.defaultWidth, 0);
const available = Math.max(0, containerWidth - fixedTotal);
return columns.map((c) => {
- if (c.resizable === false) return c.defaultWidth;
+ if (keepsWidth(c)) return c.defaultWidth;
const proportional =
flexBaseTotal > 0
? Math.round(available * (c.defaultWidth / flexBaseTotal))
diff --git a/frontend/src/routes/project/ProjectAccessGrantsPage.test.tsx b/frontend/src/routes/project/ProjectAccessGrantsPage.test.tsx
index 36e22b0849..5b6b05554d 100644
--- a/frontend/src/routes/project/ProjectAccessGrantsPage.test.tsx
+++ b/frontend/src/routes/project/ProjectAccessGrantsPage.test.tsx
@@ -1,5 +1,9 @@
import { describe, expect, test, vi } from "vitest";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import {
+ TIMESTAMP_COLUMN_MIN_WIDTH,
+ TIMESTAMP_COLUMN_WIDTH,
+} from "@/components/timestampColumn";
+import { distributeColumnWidths } from "@/hooks/useColumnWidths";
vi.mock("react-i18next", () => ({
useTranslation: () => ({ t: (key: string) => key }),
@@ -9,17 +13,19 @@ vi.mock("react-i18next", () => ({
import { grantColumns } from "./ProjectAccessGrantsPage";
describe("grantColumns", () => {
- test("shows the expiry's zone by default, and lets the reader trade it", () => {
- // An operational time carries its zone so a reader elsewhere knows when
- // access really ends, and the zone is the end of the string -- the first
- // thing a narrow column cuts. So the column opens wide enough for all of
- // it; narrower is the reader's call, not a floor set by the widest zone.
- const expiration = grantColumns((key) => key).find(
- (column) => column.key === "expiration"
- );
- expect(expiration?.defaultWidth).toBe(TIMESTAMP_COLUMN.operational.width);
- expect(expiration?.minWidth).toBeLessThan(
- TIMESTAMP_COLUMN.operational.width
- );
+ const columns = grantColumns((key) => key);
+ const expiry = columns.findIndex((column) => column.key === "expiration");
+
+ test.each([1100, 1300, 1500, 1800])(
+ "opens the expiry whole, zone included, in a %ipx table",
+ (containerWidth) => {
+ expect(distributeColumnWidths(columns, containerWidth)[expiry]).toBe(
+ TIMESTAMP_COLUMN_WIDTH.operational
+ );
+ }
+ );
+
+ test("lets a reader narrow the expiry to the date", () => {
+ expect(columns[expiry].minWidth).toBe(TIMESTAMP_COLUMN_MIN_WIDTH);
});
});
diff --git a/frontend/src/routes/project/ProjectAccessGrantsPage.tsx b/frontend/src/routes/project/ProjectAccessGrantsPage.tsx
index a4240d221b..dec099aff7 100644
--- a/frontend/src/routes/project/ProjectAccessGrantsPage.tsx
+++ b/frontend/src/routes/project/ProjectAccessGrantsPage.tsx
@@ -19,7 +19,10 @@ import {
} from "@/components/ProjectPageLayout";
import { RouterLink } from "@/components/RouterLink";
import { TimeRangePicker } from "@/components/TimeRangePicker";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import {
+ TIMESTAMP_COLUMN_MIN_WIDTH,
+ TIMESTAMP_COLUMN_WIDTH,
+} from "@/components/timestampColumn";
import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import { Dialog, DialogContent, DialogTitle } from "@/components/ui/dialog";
@@ -68,17 +71,14 @@ import { extractDatabaseResourceName } from "@/utils/v1/database";
type SortKey = "creator" | "create_time" | "expire_time";
type SortDir = "asc" | "desc";
-// Column descriptor for the access-grants table. The column array is
-// built inside the component (so titles resolve via `t()` and react
-// to language switches); only the shape lives at module scope.
-//
-// Position in the array is the `<colgroup>` order — keep this in sync
-// with the cell order inside `<AccessGrantRow>` (`useColumnWidths`
-// indexes positionally).
+// Column descriptor for the access-grants table. Position in the array is
+// the `<colgroup>` order — keep this in sync with the cell order inside
+// `<AccessGrantRow>` (`useColumnWidths` indexes positionally).
//
// - `title` — header label; omit for a blank header (actions col).
-// - `defaultWidth` — initial render width; user-resizable from there.
-// - `minWidth` — drag floor so a column can't collapse to a sliver.
+// - `defaultWidth` — the width it opens at, before fitting to the container.
+// - `minWidth` — drag floor, and the fitting floor unless `grow` is false.
+// - `grow` — false to open at `defaultWidth` however wide the table.
// - `sortKey` — present iff the column participates in server sort.
// - `resizable` — defaults true; set false for purely action columns
// where a too-narrow width clips the button row.
@@ -87,6 +87,7 @@ type GrantColumn = {
title?: string;
defaultWidth: number;
minWidth: number;
+ grow?: boolean;
sortKey?: SortKey;
resizable?: boolean;
};
@@ -116,8 +117,9 @@ export const grantColumns = (t: (key: string) => string): GrantColumn[] => [
{
key: "expiration",
title: t("common.expiration"),
- defaultWidth: TIMESTAMP_COLUMN.operational.width,
- minWidth: TIMESTAMP_COLUMN.operational.minWidth,
+ defaultWidth: TIMESTAMP_COLUMN_WIDTH.operational,
+ minWidth: TIMESTAMP_COLUMN_MIN_WIDTH,
+ grow: false,
sortKey: "expire_time",
},
{
diff --git a/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.test.tsx b/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.test.tsx
index 4443c1c1ee..ccb54db487 100644
--- a/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.test.tsx
+++ b/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.test.tsx
@@ -36,7 +36,7 @@ vi.mock("@/components/HumanizeTs", async () => ({
...(await import("@/test-utils/humanizeTs")).humanizeTsStub(),
}));
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import { TIMESTAMP_COLUMN_WIDTH } from "@/components/timestampColumn";
import { DatabaseChangelogTable } from "./DatabaseChangelogTable";
const renderIntoContainer = (element: ReactElement) => {
@@ -78,17 +78,18 @@ describe("DatabaseChangelogTable", () => {
render();
- // A fixed-layout table spreads spare width across every sized column, so
- // the title is left unsized to take it: the date keeps exactly its form's
- // width at any viewport, which is what keeps it on one line without
- // letting it grow. Only the date is draggable -- widening it is how the
- // reader trades room with the title.
const [, created, rollout] = Array.from(container.querySelectorAll("col"));
- expect(created.style.width).toBe(`${TIMESTAMP_COLUMN.compact.width}px`);
+ expect(created.style.width).toBe(`${TIMESTAMP_COLUMN_WIDTH.compact}px`);
expect(rollout.style.width).toBe("");
expect(
container.querySelectorAll("[class*=cursor-col-resize]")
).toHaveLength(1);
+ expect(
+ container.querySelector("tbody tr td:nth-child(2)")?.className
+ ).toContain("truncate");
+ // A widened date pushes the table past its box, and the title -- and the
+ // handle that would undo it -- have to stay reachable.
+ expect(container.firstElementChild?.className).toContain("overflow-x-auto");
unmount();
});
diff --git a/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.tsx b/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.tsx
index 3a377f0c80..e459dc1616 100644
--- a/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.tsx
+++ b/frontend/src/routes/project/database-detail/changelog/DatabaseChangelogTable.tsx
@@ -3,7 +3,10 @@ import { useCallback, useMemo } from "react";
import { useTranslation } from "react-i18next";
import { router } from "@/app/router";
import { HumanizeTs } from "@/components/HumanizeTs";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import {
+ TIMESTAMP_COLUMN_MIN_WIDTH,
+ TIMESTAMP_COLUMN_WIDTH,
+} from "@/components/timestampColumn";
import {
Table,
TableBody,
@@ -69,8 +72,8 @@ export function DatabaseChangelogTable({
{
key: "created",
title: t("common.created-at"),
- defaultWidth: TIMESTAMP_COLUMN.compact.width,
- minWidth: TIMESTAMP_COLUMN.compact.minWidth,
+ defaultWidth: TIMESTAMP_COLUMN_WIDTH.compact,
+ minWidth: TIMESTAMP_COLUMN_MIN_WIDTH,
resizable: true,
},
{
@@ -104,15 +107,13 @@ export function DatabaseChangelogTable({
}
return (
- <div className="overflow-hidden rounded-sm border border-block-border">
+ <div className="overflow-x-auto rounded-sm border border-block-border">
<Table className="table-fixed" style={{ minWidth: `${totalWidth}px` }}>
<colgroup>
- {widths.map((w, index) => (
+ {columns.map((column, index) => (
<col
- key={columns[index].key}
- style={{
- width: "fills" in columns[index] ? undefined : `${w}px`,
- }}
+ key={column.key}
+ style={column.fills ? undefined : { width: `${widths[index]}px` }}
/>
))}
</colgroup>
diff --git a/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.test.tsx b/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.test.tsx
index 99deae62ac..2d2509248b 100644
--- a/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.test.tsx
+++ b/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.test.tsx
@@ -3,7 +3,7 @@ import { timestampFromMs } from "@bufbuild/protobuf/wkt";
import { act } from "react";
import { createRoot } from "react-dom/client";
import { afterEach, describe, expect, test, vi } from "vitest";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import { TIMESTAMP_COLUMN_WIDTH } from "@/components/timestampColumn";
import { shownTimestampModes } from "@/test-utils/humanizeTs";
import {
TaskRun_Status,
@@ -76,13 +76,14 @@ describe("IssueDetailTaskRunTable", () => {
)
);
- // The detail column is the one left unsized, so it takes the spare width
- // and the dates keep theirs: narrower, a compact date breaks in two.
const headers = Array.from(container.querySelectorAll("th"));
const widthOf = (label: string) =>
headers.find((th) => th.textContent === label)?.style.width;
- expect(widthOf("task.created")).toBe(`${TIMESTAMP_COLUMN.compact.width}px`);
- expect(widthOf("task.started")).toBe(`${TIMESTAMP_COLUMN.compact.width}px`);
+ expect(widthOf("task.created")).toBe(`${TIMESTAMP_COLUMN_WIDTH.compact}px`);
+ expect(widthOf("task.started")).toBe(`${TIMESTAMP_COLUMN_WIDTH.compact}px`);
expect(shownTimestampModes(container)).toEqual(["compact", "compact"]);
+ for (const date of container.querySelectorAll("[data-testid=humanize-ts]")) {
+ expect(date.className).toContain("truncate");
+ }
});
});
diff --git a/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.tsx b/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.tsx
index 94ae412b0d..cf9bac119e 100644
--- a/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.tsx
+++ b/frontend/src/routes/project/issue-detail/components/IssueDetailTaskRunTable.tsx
@@ -4,7 +4,7 @@ import { useTranslation } from "react-i18next";
import { DatabaseTargetDisplay } from "@/components/DatabaseTargetDisplay";
import { HumanizeTs } from "@/components/HumanizeTs";
import { TaskRunStatusIcon } from "@/components/TaskRunStatusIcon";
-import { TIMESTAMP_COLUMN } from "@/components/timestampColumn";
+import { TIMESTAMP_COLUMN_WIDTH } from "@/components/timestampColumn";
import { EllipsisText } from "@/components/ui/ellipsis-text";
import {
Table,
@@ -108,17 +108,17 @@ export function IssueDetailTaskRunTable({
<TableHead className="sticky top-0 z-10 bg-control-bg/50">
{t("common.detail")}
</TableHead>
- {/* Sized to the form, since the detail column is the one
- that fills; a narrower column breaks a date in two. */}
+ {/* Sized to the form; the detail column is the one left to
+ take the rest. */}
<TableHead
className="sticky top-0 z-10 bg-control-bg/50"
- style={{ width: TIMESTAMP_COLUMN.compact.width }}
+ style={{ width: TIMESTAMP_COLUMN_WIDTH.compact }}
>
{t("task.created")}
</TableHead>
<TableHead
className="sticky top-0 z-10 bg-control-bg/50"
- style={{ width: TIMESTAMP_COLUMN.compact.width }}
+ style={{ width: TIMESTAMP_COLUMN_WIDTH.compact }}
>
{t("task.started")}
</TableHead>
diff --git a/frontend/src/test-utils/humanizeTs.tsx b/frontend/src/test-utils/humanizeTs.tsx
index 9bfded2edc..6fbf7b58a5 100644
--- a/frontend/src/test-utils/humanizeTs.tsx
+++ b/frontend/src/test-utils/humanizeTs.tsx
@@ -8,14 +8,18 @@ export const humanizeTsStub = () => ({
HumanizeTs: ({
tsMs,
mode = "queue",
+ className,
}: {
tsMs: number | undefined;
mode?: string;
+ className?: string;
}) =>
// Nothing at all without an instant, as the component does: a stub that
- // left an empty box behind would hide a row that kept its separator.
+ // left an empty box behind would hide a row that kept its separator. The
+ // class lands on the same span it does in the component, since that is
+ // where a caller asks a narrowed date to ellipsize rather than wrap.
tsMs === undefined ? null : (
- <span data-testid="humanize-ts" data-mode={mode}>
+ <span data-testid="humanize-ts" data-mode={mode} className={className}>
{tsMs}
</span>
),