Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: bump omni for Oracle PIVOT/UNPIVOT table_reference parsing

rebelice80d9fdfdd562
diff --git a/backend/plugin/db/oracle/query.go b/backend/plugin/db/oracle/query.go
index 2b6c34a12c..718d9b8d1f 100644
--- a/backend/plugin/db/oracle/query.go
+++ b/backend/plugin/db/oracle/query.go
@@ -391,8 +391,6 @@ func isSimpleOracleSelect(selectStmt *oracleast.SelectStmt) bool {
selectStmt.OrderBy == nil &&
selectStmt.ForUpdate == nil &&
selectStmt.FetchFirst == nil &&
- selectStmt.Pivot == nil &&
- selectStmt.Unpivot == nil &&
selectStmt.Op == oracleast.SETOP_NONE
}
diff --git a/backend/plugin/parser/plsql/query_span_extractor_omni.go b/backend/plugin/parser/plsql/query_span_extractor_omni.go
index eb0386a3c8..aff880152d 100644
--- a/backend/plugin/parser/plsql/query_span_extractor_omni.go
+++ b/backend/plugin/parser/plsql/query_span_extractor_omni.go
@@ -277,20 +277,6 @@ func (q *omniQuerySpanExtractor) extractOmniSelect(stmt *oracleast.SelectStmt) (
if stmt.Op != 0 {
return q.extractOmniSetSelect(stmt)
}
- if stmt.Pivot != nil {
- source, err := q.extractOmniPivot(stmt.Pivot)
- if err != nil {
- return nil, err
- }
- return q.projectOmniTransformedSelect(stmt, source)
- }
- if stmt.Unpivot != nil {
- source, err := q.extractOmniUnpivot(stmt.Unpivot)
- if err != nil {
- return nil, err
- }
- return q.projectOmniTransformedSelect(stmt, source)
- }
if stmt.ModelClause != nil {
source, err := q.extractOmniModelSelect(stmt)
if err != nil {
diff --git a/backend/plugin/parser/plsql/query_span_omni_parity_test.go b/backend/plugin/parser/plsql/query_span_omni_parity_test.go
index 70d97be3c5..9c3fe1898a 100644
--- a/backend/plugin/parser/plsql/query_span_omni_parity_test.go
+++ b/backend/plugin/parser/plsql/query_span_omni_parity_test.go
@@ -466,6 +466,24 @@ func TestOracleOmniTypedLongTailTableSources(t *testing.T) {
{Name: "TWO_CNT", SourceColumns: sourceColumnSetFromList([]base.ColumnResource{{Database: "PUBLIC", Table: "T", Column: "B"}})},
},
},
+ {
+ // (subquery) PIVOT (...) alias — the alias qualifies projected
+ // and ORDER BY references (the shape stmt-level parsing broke).
+ name: "pivot trailing alias qualifies references",
+ statement: "SELECT P.A, P.ONE_CNT FROM (SELECT A, B FROM T) PIVOT (COUNT(*) AS CNT FOR B IN (1 AS ONE, 2 AS TWO)) P ORDER BY P.A",
+ want: []base.QuerySpanResult{
+ {Name: "A", SourceColumns: sourceColumnSetFromList([]base.ColumnResource{{Database: "PUBLIC", Table: "T", Column: "A"}})},
+ {Name: "ONE_CNT", SourceColumns: sourceColumnSetFromList([]base.ColumnResource{{Database: "PUBLIC", Table: "T", Column: "B"}})},
+ },
+ },
+ {
+ name: "pivot alias joins another table",
+ statement: "SELECT P.ONE_CNT, T2.C FROM (SELECT A, B FROM T) PIVOT (COUNT(*) AS CNT FOR B IN (1 AS ONE)) P JOIN T2 ON P.A = T2.C",
+ want: []base.QuerySpanResult{
+ {Name: "ONE_CNT", SourceColumns: sourceColumnSetFromList([]base.ColumnResource{{Database: "PUBLIC", Table: "T", Column: "B"}})},
+ {Name: "C", SourceColumns: sourceColumnSetFromList([]base.ColumnResource{{Database: "PUBLIC", Table: "T2", Column: "C"}})},
+ },
+ },
{
name: "pivot explicit projection",
statement: "SELECT A FROM (SELECT A, B FROM T) PIVOT (COUNT(*) AS CNT FOR B IN (1 AS ONE, 2 AS TWO))",
diff --git a/go.mod b/go.mod
index caaab7fb5a..ceee643d49 100644
--- a/go.mod
+++ b/go.mod
@@ -33,7 +33,7 @@ require (
github.com/bmatcuk/doublestar/v4 v4.10.0
github.com/bytebase/gomongo v0.0.0-20260510192859-8526a440b352
github.com/bytebase/lsp-protocol v0.0.0-20250324071136-1586d0c10ff0
- github.com/bytebase/omni v0.0.0-20260708021240-171d8abc36d7
+ github.com/bytebase/omni v0.0.0-20260709103218-72e9a03222dc
github.com/caarlos0/env/v11 v11.4.1
github.com/cenkalti/backoff/v5 v5.0.3
github.com/cockroachdb/cockroachdb-parser v0.25.2
diff --git a/go.sum b/go.sum
index 3483c7051b..3e85166cc7 100644
--- a/go.sum
+++ b/go.sum
@@ -250,8 +250,8 @@ github.com/bytebase/gomongo v0.0.0-20260510192859-8526a440b352 h1:3sC5pdvJ7bNAhR
github.com/bytebase/gomongo v0.0.0-20260510192859-8526a440b352/go.mod h1:eyWrxE51HCbjGIChvty/mYaNcAroXshnIiR6SIqlxfY=
github.com/bytebase/lsp-protocol v0.0.0-20250324071136-1586d0c10ff0 h1:bJ8NSf2K+pccl5m/wuu97fiYjDwpJH6IzURAq/3XA2U=
github.com/bytebase/lsp-protocol v0.0.0-20250324071136-1586d0c10ff0/go.mod h1:BEWMfiZtqshdmulKJcIsWb45MUaEvDO4CROcgi8dfFg=
-github.com/bytebase/omni v0.0.0-20260708021240-171d8abc36d7 h1:VcZGq9HvaVTo0rBTdr1CMjjuARYHSkv2TnlE5Y06Ikk=
-github.com/bytebase/omni v0.0.0-20260708021240-171d8abc36d7/go.mod h1:Gp5RN3FM07f9/FFOTZCeu8duTAIMeuinkjjBCrs2Dw4=
+github.com/bytebase/omni v0.0.0-20260709103218-72e9a03222dc h1:3RCryLK16wzMjYpnmpgYtXPSDgcjKPVdLXQNbgdFbxc=
+github.com/bytebase/omni v0.0.0-20260709103218-72e9a03222dc/go.mod h1:Gp5RN3FM07f9/FFOTZCeu8duTAIMeuinkjjBCrs2Dw4=
github.com/bytebase/pgx/v5 v5.0.0-20250212161523-96ff8aed8767 h1:YuR5G3LcxpO5ScSTA+Kdirxg9RW4TRc/v1t7N2Hfmbw=
github.com/bytebase/pgx/v5 v5.0.0-20250212161523-96ff8aed8767/go.mod h1:ncY89UGWxg82EykZUwSpUKEfccBGGYq1xjrOpsbsfGQ=
github.com/bytebase/pkcs8 v0.0.0-20240612095628-fcd0a7484c94 h1:6PNsuNmSqCuR8Z616uQLzDIvujWCFsKzeVc3ECmVubk=