Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat(frontend): improve plan status handling and actions (#18738)
boojack81462deddfe8
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vueindex b79bc24a98..22effe5d7e 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue@@ -75,9 +75,16 @@ import CommonDrawer from "@/components/IssueV1/components/Panel/CommonDrawer.vueimport { ApprovalFlowSection } from "@/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection";import PlanCheckStatusCount from "@/components/Plan/components/PlanCheckStatusCount.vue";import { usePlanContext } from "@/components/Plan/logic";-import { rolloutServiceClientConnect } from "@/grpcweb";+import {+ issueServiceClientConnect,+ rolloutServiceClientConnect,+} from "@/grpcweb";import { PROJECT_V1_ROUTE_PLAN_ROLLOUT } from "@/router/dashboard/projectV1";import { pushNotification } from "@/store";+import {+ BatchUpdateIssuesStatusRequestSchema,+ IssueStatus,+} from "@/types/proto-es/v1/issue_service_pb";import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";import {extractPlanUIDFromRolloutName,@@ -163,6 +170,17 @@ const handleConfirm = async () => {create(CreateRolloutRequestSchema, { parent: plan.value.name }));+ // Mark issue as done after rollout created.+ if (issue.value) {+ await issueServiceClientConnect.batchUpdateIssuesStatus(+ create(BatchUpdateIssuesStatusRequestSchema, {+ parent: project.value.name,+ issues: [issue.value.name],+ status: IssueStatus.DONE,+ })+ );+ }+pushNotification({module: "bytebase",style: "SUCCESS",diff --git a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/DatabaseChangeSection.vue b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/DatabaseChangeSection.vueindex 121f9d3566..70777d41f1 100644--- a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/DatabaseChangeSection.vue+++ b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/DatabaseChangeSection.vue@@ -42,9 +42,22 @@<!-- SQL Checks --><div class="flex flex-col gap-y-1">- <h3 class="textlabel">- {{ $t("plan.navigator.checks") }}- </h3>+ <div class="flex items-center justify-between">+ <h3 class="textlabel">+ {{ $t("plan.navigator.checks") }}+ </h3>+ <NButton+ v-if="allowRunChecks"+ size="tiny"+ :loading="isRunningChecks"+ @click="runChecks"+ >+ <template #icon>+ <PlayIcon class="w-4 h-4" />+ </template>+ {{ $t("common.run") }}+ </NButton>+ </div><div class="flex items-center gap-2"><PlanCheckStatusCount:plan="plan"@@ -68,32 +81,56 @@</template><script setup lang="ts">-import { NDivider } from "naive-ui";+import { create } from "@bufbuild/protobuf";+import type { ConnectError } from "@connectrpc/connect";+import { PlayIcon } from "lucide-vue-next";+import { NButton, NDivider } from "naive-ui";import { computed, ref } from "vue";import { useRouter } from "vue-router";import TaskStatus from "@/components/Rollout/kits/TaskStatus.vue";import { EnvironmentV1Name } from "@/components/v2";+import { planServiceClientConnect } from "@/grpcweb";import { PROJECT_V1_ROUTE_PLAN_ROLLOUT_STAGE } from "@/router/dashboard/projectV1";-import { useCurrentProjectV1, useEnvironmentV1Store } from "@/store";+import {+ extractUserId,+ pushNotification,+ useCurrentProjectV1,+ useCurrentUserV1,+ useEnvironmentV1Store,+} from "@/store";import { Issue_Type } from "@/types/proto-es/v1/issue_service_pb";+import { RunPlanChecksRequestSchema } from "@/types/proto-es/v1/plan_service_pb";import { Advice_Level } from "@/types/proto-es/v1/sql_service_pb";import {extractPlanUIDFromRolloutName,extractProjectResourceName,getStageStatus,+ hasProjectPermissionV2,} from "@/utils";import { usePlanCheckStatus, usePlanContext } from "../../../logic";+import { useResourcePoller } from "../../../logic/poller";import ChecksDrawer from "../../ChecksView/ChecksDrawer.vue";import PlanCheckStatusCount from "../../PlanCheckStatusCount.vue";+const currentUser = useCurrentUserV1();const { plan, rollout, issue } = usePlanContext();const environmentStore = useEnvironmentV1Store();const router = useRouter();const { project } = useCurrentProjectV1();+const { refreshResources } = useResourcePoller();const { hasAnyStatus: hasAnyChecks } = usePlanCheckStatus(plan);+const isRunningChecks = ref(false);const selectedResultStatus = ref<Advice_Level | undefined>(undefined);+const allowRunChecks = computed(() => {+ const me = currentUser.value;+ if (extractUserId(plan.value.creator) === me.email) {+ return true;+ }+ return hasProjectPermissionV2(project.value, "bb.planCheckRuns.run");+});+const shouldShowSection = computed(() => {return issue.value?.type === Issue_Type.DATABASE_CHANGE || rollout?.value;});@@ -119,4 +156,33 @@ const navigateToStage = (stageName: string) => {},});};++const runChecks = async () => {+ if (!plan.value.name) return;++ isRunningChecks.value = true;+ try {+ const request = create(RunPlanChecksRequestSchema, {+ name: plan.value.name,+ });+ await planServiceClientConnect.runPlanChecks(request);++ refreshResources(["plan", "planCheckRuns"], true);++ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: "Plan checks started",+ });+ } catch (error) {+ pushNotification({+ module: "bytebase",+ style: "CRITICAL",+ title: "Failed to run plan checks",+ description: (error as ConnectError).message,+ });+ } finally {+ isRunningChecks.value = false;+ }+};</script>diff --git a/frontend/src/components/Plan/components/SpecDetailView/SpecListSection.vue b/frontend/src/components/Plan/components/SpecDetailView/SpecListSection.vueindex 03039f2be6..59f5dadc47 100644--- a/frontend/src/components/Plan/components/SpecDetailView/SpecListSection.vue+++ b/frontend/src/components/Plan/components/SpecDetailView/SpecListSection.vue@@ -81,6 +81,7 @@ import {useCurrentProjectV1,useSheetV1Store,} from "@/store";+import { State } from "@/types/proto-es/v1/common_pb";import type { Plan_Spec } from "@/types/proto-es/v1/plan_service_pb";import { UpdatePlanRequestSchema } from "@/types/proto-es/v1/plan_service_pb";import { extractSheetUID } from "@/utils";@@ -105,9 +106,10 @@ const { setEditingState } = useEditorState();const showAddSpecDrawer = ref(false);// Allow adding/removing specs when:-// 1. Plan is being created (isCreating = true), OR-// 2. Plan is created but rollout is empty (!plan.hasRollout)+// 1. Plan is not closed (state !== DELETED), AND+// 2. Plan is being created (isCreating = true), OR plan has no rolloutconst canModifySpecs = computed(() => {+ if (plan.value.state === State.DELETED) return false;return isCreating.value || !plan.value.hasRollout;});