Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: changelog name is not valid (#18123)

ecmadao84fbfd21fb24
diff --git a/frontend/src/components/Project/useRecentProjects.ts b/frontend/src/components/Project/useRecentProjects.ts
index b7a8885587..ff5dcb81c8 100644
--- a/frontend/src/components/Project/useRecentProjects.ts
+++ b/frontend/src/components/Project/useRecentProjects.ts
@@ -35,16 +35,18 @@ export const useRecentProjects = () => {
const recentViewProjects = computedAsync(async () => {
const projects = [];
for (const projectName of recentViewProjectNames.value) {
- const project = await projectV1Store.getOrFetchProjectByName(
- projectName,
- true /* silent */
- );
- if (
- isValidProjectName(project.name) &&
- hasProjectPermissionV2(project, "bb.projects.get")
- ) {
- projects.push(project);
- }
+ try {
+ const project = await projectV1Store.getOrFetchProjectByName(
+ projectName,
+ true /* silent */
+ );
+ if (
+ isValidProjectName(project.name) &&
+ hasProjectPermissionV2(project, "bb.projects.get")
+ ) {
+ projects.push(project);
+ }
+ } catch {}
}
return projects;
}, []);
diff --git a/frontend/src/components/SyncDatabaseSchemaV1/SelectTargetDatabasesView.vue b/frontend/src/components/SyncDatabaseSchemaV1/SelectTargetDatabasesView.vue
index 531e9b7682..7dad1efe44 100644
--- a/frontend/src/components/SyncDatabaseSchemaV1/SelectTargetDatabasesView.vue
+++ b/frontend/src/components/SyncDatabaseSchemaV1/SelectTargetDatabasesView.vue
@@ -169,6 +169,7 @@ import { type ComposedDatabase, isValidDatabaseName } from "@/types";
import { Engine } from "@/types/proto-es/v1/common_pb";
import { DiffSchemaRequestSchema } from "@/types/proto-es/v1/database_service_pb";
import type { Project } from "@/types/proto-es/v1/project_service_pb";
+import { isValidChangelogName } from "@/utils/v1/changelog";
import DiffViewPanel from "./DiffViewPanel.vue";
import SourceSchemaInfo from "./SourceSchemaInfo.vue";
import TargetDatabasesSelectPanel from "./TargetDatabasesSelectPanel.vue";
@@ -321,12 +322,14 @@ watch(
continue;
} else {
// Use changelog name if source is from changelog, otherwise use schema string
- const diffRequest = props.changelogSourceSchema?.changelogName
+ const diffRequest = isValidChangelogName(
+ props.changelogSourceSchema?.changelogName
+ )
? create(DiffSchemaRequestSchema, {
name: db.name,
target: {
case: "changelog",
- value: props.changelogSourceSchema.changelogName,
+ value: props.changelogSourceSchema?.changelogName ?? "",
},
})
: create(DiffSchemaRequestSchema, {
diff --git a/frontend/src/components/v2/Model/cells/UserNameCell.vue b/frontend/src/components/v2/Model/cells/UserNameCell.vue
index d5744ad33a..e4a4e56a2a 100644
--- a/frontend/src/components/v2/Model/cells/UserNameCell.vue
+++ b/frontend/src/components/v2/Model/cells/UserNameCell.vue
@@ -4,33 +4,32 @@
<div class="flex flex-row items-center">
<div class="flex flex-col">
- <div :class="[
- 'flex flex-row items-center gap-x-1',
- user.state === State.DELETED ? 'line-through' : ''
- ]">
- <span
- v-if="onClickUser"
- class="normal-link truncate max-w-40"
- @click="onClickUser(user, $event)"
- >
- {{ user.title }}
- </span>
- <span
- v-else-if="permissionStore.onlyWorkspaceMember"
- class="truncate max-w-[10em]"
- >
- {{ user.title }}
- </span>
- <router-link
- v-else
- :to="`/users/${user.email}`"
- class="normal-link truncate max-w-[10em]"
- >
- {{ user.title }}
- </router-link>
+ <div class="flex flex-row items-center gap-x-1">
+ <div :class="isDeleted ? 'line-through' : ''">
+ <span
+ v-if="onClickUser"
+ class="normal-link truncate max-w-40"
+ @click="onClickUser(user, $event)"
+ >
+ {{ user.title }}
+ </span>
+ <span
+ v-else-if="permissionStore.onlyWorkspaceMember"
+ class="truncate max-w-[10em]"
+ >
+ {{ user.title }}
+ </span>
+ <router-link
+ v-else
+ :to="`/users/${user.email}`"
+ class="normal-link truncate max-w-[10em]"
+ >
+ {{ user.title }}
+ </router-link>
+ </div>
<slot name="suffix">
</slot>
- <NTag v-if="user.state === State.DELETED" :size="tagSize" type="error" round>
+ <NTag v-if="isDeleted" :size="tagSize" type="error" round>
{{$t("common.deleted")}}
</NTag>
<NTag v-if="user.profile?.source" :size="tagSize" round type="primary">
@@ -45,12 +44,6 @@
<NTag v-if="user.mfaEnabled" :size="tagSize" type="success" round>
{{ $t("two-factor.enabled") }}
</NTag>
- <!-- <span
- v-if="user.mfaEnabled"
- class="inline-flex items-center px-2 py-0.5 rounded-lg text-xs bg-green-800 text-green-100"
- >
- {{ $t("two-factor.enabled") }}
- </span> -->
</div>
<slot name="footer">
<span v-if="user.name !== SYSTEM_BOT_USER_NAME" class="textinfolabel">
@@ -59,7 +52,7 @@
</slot>
</div>
<div
- v-if="user.state === State.ACTIVE && user.userType === UserType.SERVICE_ACCOUNT && allowEdit && hasPermission"
+ v-if="!isDeleted && user.userType === UserType.SERVICE_ACCOUNT && allowEdit && hasPermission"
class="ml-3 text-xs"
>
<CopyButton
@@ -124,6 +117,8 @@ const hasPermission = computed(() => {
return hasWorkspacePermissionV2("bb.policies.update");
});
+const isDeleted = computed(() => props.user.state === State.DELETED);
+
const tagSize = computed(() => {
if (props.size === "small") {
return "tiny";