Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat: standardize issue tabs and set waiting approval as default (#18071)
boojack86334df5c0ab
diff --git a/frontend/src/components/Project/ProjectIssuesPanel.vue b/frontend/src/components/Project/ProjectIssuesPanel.vueindex d4c60bdaa1..84be888f1b 100644--- a/frontend/src/components/Project/ProjectIssuesPanel.vue+++ b/frontend/src/components/Project/ProjectIssuesPanel.vue@@ -142,24 +142,23 @@ const readonlyScopes = computed((): SearchScope[] => {});const tabItemList = computed((): TabFilterItem<TabValue>[] => {const items: TabFilterItem<TabValue>[] = [- { value: "ALL", label: t("common.all") },- { value: "CREATED", label: t("common.created") },{value: "WAITING_APPROVAL",label: t("issue.waiting-approval"),},- { value: "WAITING_ROLLOUT", label: t("issue.waiting-rollout") },+ { value: "CREATED", label: t("common.created") },+ { value: "ALL", label: t("common.all") },];return items;});const storedTab = useDynamicLocalStorage<TabValue>(computed(() => `bb.project.issue-list-tab.${me.value.name}`),- tabItemList.value[0].value,+ "WAITING_APPROVAL",window.localStorage,{serializer: {read(raw: TabValue) {- if (!TABS.includes(raw)) return tabItemList.value[0].value;+ if (!TABS.includes(raw)) return "WAITING_APPROVAL";return raw;},write(value) {diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex c396f811c6..7c835e2f6b 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -858,7 +858,6 @@"labels": "Issue Labels","my-issues": "My Issues","waiting-approval": "Waiting for Approval",- "waiting-rollout": "Waiting for Rollout","status-transition": {"modal": {"resolve": "Resolve issue?",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 2f9deeda8a..4761b981b0 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -858,7 +858,6 @@"labels": "Etiquetas de problema","my-issues": "Mis Incidencias","waiting-approval": "A la espera de la aprobación",- "waiting-rollout": "Esperando el lanzamiento","status-transition": {"modal": {"resolve": "¿Resolver incidencia?",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 83cac3de39..5a565f23bb 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -858,7 +858,6 @@"labels": "イシューラベル","my-issues": "マイイシュー","waiting-approval": "承認待ち",- "waiting-rollout": "リリース待ち","status-transition": {"modal": {"resolve": "イシューは完了しましたか?",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex 81da5f9489..79d5b159f9 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -858,7 +858,6 @@"labels": "Nhãn vấn đề","my-issues": "Vấn đề của tôi","waiting-approval": "Đang chờ phê duyệt",- "waiting-rollout": "Đang chờ triển khai","status-transition": {"modal": {"resolve": "Giải quyết vấn đề?",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex 81961993be..c44d24a12e 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -858,7 +858,6 @@"labels": "工单标签","my-issues": "我的工单","waiting-approval": "等待审批",- "waiting-rollout": "等待发布","status-transition": {"modal": {"resolve": "完成工单?",diff --git a/frontend/src/views/MyIssues.vue b/frontend/src/views/MyIssues.vueindex 972301bbf0..73c9c96de7 100644--- a/frontend/src/views/MyIssues.vue+++ b/frontend/src/views/MyIssues.vue@@ -105,13 +105,7 @@ import {} from "@/utils";import { getComponentIdLocalStorageKey } from "@/utils/localStorage";-const TABS = [- "CREATED",- "WAITING_APPROVAL",- "WAITING_ROLLOUT",- "ALL",- "",-] as const;+const TABS = ["WAITING_APPROVAL", "CREATED", "ALL", ""] as const;type TabValue = (typeof TABS)[number];@@ -166,28 +160,24 @@ const defaultScopeIds = computed(() => {return new Set(defaultSearchParams().scopes.map((s) => s.id));});const tabItemList = computed((): TabFilterItem<TabValue>[] => {- const items: (TabFilterItem<TabValue> & { hide?: boolean })[] = [- { value: "ALL", label: t("common.all") },- { value: "CREATED", label: t("common.created") },+ const items: TabFilterItem<TabValue>[] = [{value: "WAITING_APPROVAL",label: t("issue.waiting-approval"),},- {- value: "WAITING_ROLLOUT",- label: t("issue.waiting-rollout"),- },+ { value: "CREATED", label: t("common.created") },+ { value: "ALL", label: t("common.all") },];- return items.filter((item) => !item.hide);+ return items;});const storedTab = useDynamicLocalStorage<TabValue>(computed(() => `bb.home.issue-list-tab.${me.value.name}`),- tabItemList.value[0].value,+ "WAITING_APPROVAL",window.localStorage,{serializer: {read(raw: TabValue) {- if (!TABS.includes(raw)) return tabItemList.value[0].value;+ if (!TABS.includes(raw)) return "WAITING_APPROVAL";return raw;},write(value) {@@ -197,9 +187,8 @@ const storedTab = useDynamicLocalStorage<TabValue>(} as UseStorageOptions<TabValue>);const keyForTab = (tab: TabValue) => {- if (tab === "CREATED") return "my-issues-created";if (tab === "WAITING_APPROVAL") return "my-issues-waiting-approval";- if (tab === "WAITING_ROLLOUT") return "my-issues-waiting-rollout";+ if (tab === "CREATED") return "my-issues-created";if (tab === "ALL") return "my-issues-all";return "my-issues-unknown";@@ -239,25 +228,6 @@ const mergeSearchParamsByTab = (params: SearchParams, tab: TabValue) => {],});}- if (tab === "WAITING_ROLLOUT") {- return upsertScope({- params: common,- scopes: [- {- id: "status",- value: "OPEN",- },- {- id: "approval",- value: "approved",- },- {- id: "releaser",- value: myEmail,- },- ],- });- }console.error("[mergeSearchParamsByTab] should never reach this line", tab);return common;};@@ -285,14 +255,6 @@ const guessTabValueFromSearchParams = (params: SearchParams): TabValue => {) {return "WAITING_APPROVAL";}- if (- verifyScopes(["approval", "releaser"]) &&- getSemanticIssueStatusFromSearchParams(params) === "OPEN" &&- getValueFromSearchParams(params, "approval") === "approved" &&- getValueFromSearchParams(params, "releaser") === myEmail- ) {- return "WAITING_ROLLOUT";- }if (params.scopes.every((s) => defaultScopeIds.value.has(s.id))) {return "ALL";@@ -324,7 +286,7 @@ const tab = computed<TabValue>({const statusTabHidden = computed(() => {if (state.advanced) return true;- return ["WAITING_APPROVAL", "WAITING_ROLLOUT"].includes(tab.value);+ return tab.value === "WAITING_APPROVAL";});const mergedIssueFilter = computed(() => {@@ -379,7 +341,7 @@ const toggleAdvancedSearch = (on: boolean) => {watch([tab],() => {- if (tab.value === "WAITING_APPROVAL" || tab.value === "WAITING_ROLLOUT") {+ if (tab.value === "WAITING_APPROVAL") {if (getSemanticIssueStatusFromSearchParams(state.params) === "CLOSED") {upsertScope({params: state.params,