Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(sql-editor): show correct row data in detail panel when results are sorted (#19252)

Vincent Huang873a83e2da61
diff --git a/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/TableCell.vue b/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/TableCell.vue
index c7837ec9be..2cf64414d6 100644
--- a/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/TableCell.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/TableCell.vue
@@ -79,6 +79,7 @@ const props = defineProps<{
value: RowValue;
setIndex: number;
rowIndex: number;
+ originalRowIndex: number;
colIndex: number;
allowSelect?: boolean;
columnType: string; // Column type from QueryResult
@@ -238,7 +239,7 @@ const handleClick = (e: MouseEvent) => {
const showDetail = () => {
detail.value = {
set: props.setIndex,
- row: props.rowIndex,
+ row: props.originalRowIndex,
col: props.colIndex,
};
};
diff --git a/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/VirtualDataTable.vue b/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/VirtualDataTable.vue
index 2a8e68b974..88881f8170 100644
--- a/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/VirtualDataTable.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/ResultView/DataTable/VirtualDataTable.vue
@@ -115,7 +115,7 @@
minWidth: `${tableResize.effectiveWidth.value}px`,
}"
>
- <template #default="{ item: row, index: rowIndex }: { item: { item: QueryRow; }; index: number; }">
+ <template #default="{ item: row, index: rowIndex }: { item: { key: number; item: QueryRow; }; index: number; }">
<div
:key="`${setIndex}-${rowIndex}`"
class="flex group"
@@ -190,6 +190,7 @@
:scope="search.scopes.find(scope => scope.id === columns[columnIndex]?.id)"
:set-index="setIndex"
:row-index="rowIndex"
+ :original-row-index="row.key"
:col-index="columnIndex"
:allow-select="true"
:column-type="getColumnTypeByIndex(columnIndex)"
diff --git a/frontend/src/views/sql-editor/EditorCommon/ResultView/VirtualDataBlock.vue b/frontend/src/views/sql-editor/EditorCommon/ResultView/VirtualDataBlock.vue
index 89dab4de8a..5ab07debf0 100644
--- a/frontend/src/views/sql-editor/EditorCommon/ResultView/VirtualDataBlock.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/ResultView/VirtualDataBlock.vue
@@ -5,7 +5,7 @@
:items="rows"
:item-size="estimateRowHeight"
>
- <template #default="{ item: row, index: rowIndex }: { item: { item: QueryRow; }; index: number; }">
+ <template #default="{ item: row, index: rowIndex }: { item: { key: number; item: QueryRow; }; index: number; }">
<div
:key="`row-${rowIndex}`"
class="font-mono mb-2 mx-2"
@@ -56,6 +56,7 @@
:scope="search.scopes.find(scope => scope.id === columns[columnIndex]?.id)"
:set-index="setIndex"
:row-index="rowIndex"
+ :original-row-index="row.key"
:col-index="columnIndex"
:column-type="column.columnType"
:allow-select="true"