Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: mcp ui layout (#21346)

ecmadao894927339018
diff --git a/frontend/src/routes/workspace/MCPPage.test.tsx b/frontend/src/routes/workspace/MCPPage.test.tsx
index d5e7b407a1..dac47eb008 100644
--- a/frontend/src/routes/workspace/MCPPage.test.tsx
+++ b/frontend/src/routes/workspace/MCPPage.test.tsx
@@ -58,6 +58,15 @@ const allTabValues = (container: HTMLElement) => {
};
describe("MCPPage connect panel", () => {
+ test("scrolls client tabs horizontally without vertical overflow", () => {
+ const { container, unmount } = render(<MCPPage />);
+ const tabList = container.querySelector('[role="tablist"]');
+
+ expect(tabList?.classList.contains("overflow-x-auto")).toBe(true);
+ expect(tabList?.classList.contains("overflow-y-hidden")).toBe(true);
+ unmount();
+ });
+
// Codex, #21237: three of the six commands were invalid. Each was checked
// against its own source — the codex CLI's own AddArgs (name is positional,
// --url is the flag, there is no --transport), the Copilot CLI docs
diff --git a/frontend/src/routes/workspace/MCPPage.tsx b/frontend/src/routes/workspace/MCPPage.tsx
index 7f0184c6cf..cb0475d386 100644
--- a/frontend/src/routes/workspace/MCPPage.tsx
+++ b/frontend/src/routes/workspace/MCPPage.tsx
@@ -120,7 +120,7 @@ export function MCPPage() {
</p>
</div>
<Tabs defaultValue="claude-code">
- <TabsList className="overflow-x-auto">
+ <TabsList className="overflow-x-auto overflow-y-hidden">
{tabs.map((tab) => (
<TabsTrigger key={tab.id} value={tab.id} className="shrink-0">
{tab.title}
diff --git a/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.test.tsx b/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.test.tsx
index d9ac3cea8c..827ffd38d6 100644
--- a/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.test.tsx
+++ b/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.test.tsx
@@ -326,6 +326,41 @@ describe("MCPAccessPolicySection", () => {
unmount();
});
+ test("keeps policy-card content compact", async () => {
+ const { container, render, unmount } = renderIntoContainer(
+ <MCPAccessPolicySection />
+ );
+ render();
+ await flush();
+ clickText(container, "settings.mcp.policy.edit");
+ await flush();
+
+ const bestForLines = [...container.querySelectorAll("p")].filter((line) =>
+ line.textContent?.includes(".best-for")
+ );
+ expect(bestForLines).toHaveLength(3);
+ expect(bestForLines.every((line) => !line.classList.contains("mt-auto"))).toBe(
+ true
+ );
+ unmount();
+ });
+
+ test("keeps the masking switch intrinsic", async () => {
+ const { container, render, unmount } = renderIntoContainer(
+ <MCPAccessPolicySection />
+ );
+ render();
+ await flush();
+ clickText(container, "settings.mcp.policy.edit");
+ await flush();
+
+ const maskingSwitch = container.querySelector(
+ '[aria-label="settings.mcp.policy.masking.title"]'
+ );
+ expect(maskingSwitch?.classList.contains("shrink-0")).toBe(true);
+ unmount();
+ });
+
// Codex, #21236: setSaving gated only the footer buttons. The request has
// already captured pick and ignoreMasking, so a card clicked after Save went
// out changed the visible draft and nothing else — then the success path
diff --git a/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.tsx b/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.tsx
index 2d46046697..8be739805c 100644
--- a/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.tsx
+++ b/frontend/src/routes/workspace/mcp/MCPAccessPolicySection.tsx
@@ -314,7 +314,7 @@ export function MCPAccessPolicySection() {
nothing else, then vanish when the editor closes. */}
<RadioGroup
aria-label={t("settings.mcp.policy.title")}
- className="grid grid-cols-1 gap-4 md:grid-cols-3"
+ className="grid grid-cols-1 gap-4 lg:grid-cols-3"
disabled={saving}
value={pick === undefined ? "" : String(pick)}
onValueChange={(value) => {
@@ -352,9 +352,7 @@ export function MCPAccessPolicySection() {
<p className="textinfolabel">
{t(`settings.mcp.policy.mode.${mode.key}.description`)}
</p>
- {/* Pinned to the bottom so the three "Best for" lines sit
- on one row, however long each description runs. */}
- <p className="textinfolabel mt-auto pt-2">
+ <p className="textinfolabel pt-2">
{t(`settings.mcp.policy.mode.${mode.key}.best-for`)}
</p>
</RadioGroupItem>
@@ -368,7 +366,7 @@ export function MCPAccessPolicySection() {
onCheckedChange={setIgnoreMasking}
disabled={saving}
aria-label={t("settings.mcp.policy.masking.title")}
- className="mt-0.5"
+ className="mt-0.5 shrink-0"
/>
<div className="flex flex-col gap-1">
<div className="textinfo font-semibold">
@@ -395,7 +393,7 @@ export function MCPAccessPolicySection() {
)}
<Separator />
- <div className="flex flex-wrap items-center justify-between gap-2">
+ <div className="flex flex-wrap items-center justify-between gap-4">
<p className="textinfolabel">
{t("settings.mcp.policy.tightening")}
</p>