Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: cannot select tree node in safari (#20219)

ecmadao8de43a0580aa
diff --git a/frontend/src/react/components/sql-editor/ConnectionPane/ConnectionPane.tsx b/frontend/src/react/components/sql-editor/ConnectionPane/ConnectionPane.tsx
index 0c4092cfba..f7e8d2e4b2 100644
--- a/frontend/src/react/components/sql-editor/ConnectionPane/ConnectionPane.tsx
+++ b/frontend/src/react/components/sql-editor/ConnectionPane/ConnectionPane.tsx
@@ -1069,7 +1069,15 @@ function TreeRow({
selected && "bg-accent/10"
)}
data-node-key={node.key}
- onClick={onClick}
+ // Use `onMouseUp` instead of `onClick` for the row activation. Safari
+ // drops the synthesized `click` event when `mousedown` and `mouseup`
+ // resolve to different inner elements (the chevron / engine icon /
+ // text span). `mouseup` always fires regardless, so we drive the
+ // selection from there, gated to the primary button.
+ onMouseUp={(e) => {
+ if (e.button !== 0) return;
+ onClick(e);
+ }}
onMouseEnter={handleMouseEnter}
onMouseLeave={handleMouseLeave}
onContextMenu={(e) => {
diff --git a/frontend/src/react/components/sql-editor/SchemaPane/SchemaPane.tsx b/frontend/src/react/components/sql-editor/SchemaPane/SchemaPane.tsx
index a91c1d4f80..0bff581309 100644
--- a/frontend/src/react/components/sql-editor/SchemaPane/SchemaPane.tsx
+++ b/frontend/src/react/components/sql-editor/SchemaPane/SchemaPane.tsx
@@ -718,7 +718,12 @@ function SchemaTreeRow({
)}
data-node-key={node.key}
data-node-meta-type={node.meta.type}
- onClick={() => {
+ // Drive the click discriminator off `mouseup` (gated to the primary
+ // button) instead of `onClick`. Safari drops the synthesized `click`
+ // when `mousedown` / `mouseup` resolve to different inner elements
+ // inside the row (chevron, icon, label). `mouseup` always fires.
+ onMouseUp={(e) => {
+ if (e.button !== 0) return;
if (node.disabled) return;
onClickNode(node);
}}
diff --git a/frontend/src/react/components/ui/otp-input.tsx b/frontend/src/react/components/ui/otp-input.tsx
index 572d862b12..17398befaa 100644
--- a/frontend/src/react/components/ui/otp-input.tsx
+++ b/frontend/src/react/components/ui/otp-input.tsx
@@ -92,7 +92,7 @@ export function OtpInput({
onChange={(e) => handleChange(i, e.target.value)}
onKeyDown={(e) => handleKeyDown(i, e)}
onPaste={handlePaste}
- className="w-10 h-12 text-center text-lg font-mono border border-control-border rounded-xs focus:outline-none focus:ring-2 focus:ring-accent focus:border-accent"
+ className="flex-1 min-w-0 h-12 text-center text-lg font-mono border border-control-border rounded-xs focus:outline-none focus:ring-2 focus:ring-accent focus:border-accent"
autoComplete="one-time-code"
/>
))}
diff --git a/frontend/src/react/pages/auth/PasswordResetPage.tsx b/frontend/src/react/pages/auth/PasswordResetPage.tsx
index 0ef635adda..8629049ad4 100644
--- a/frontend/src/react/pages/auth/PasswordResetPage.tsx
+++ b/frontend/src/react/pages/auth/PasswordResetPage.tsx
@@ -260,7 +260,7 @@ export function PasswordResetPage() {
className="accent-link bg-white px-2"
onClick={(e) => {
e.preventDefault();
- router.push({ name: AUTH_SIGNIN_MODULE, query });
+ router.push({ name: AUTH_SIGNIN_MODULE });
}}
>
{t("auth.password-forget.return-to-sign-in")}