Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor: do not hardcode page size (#19934)

ecmadao8e0e27a42fd9
diff --git a/frontend/src/react/components/AccountMultiSelect.tsx b/frontend/src/react/components/AccountMultiSelect.tsx
index 1462e51ecb..8e948c2a54 100644
--- a/frontend/src/react/components/AccountMultiSelect.tsx
+++ b/frontend/src/react/components/AccountMultiSelect.tsx
@@ -10,7 +10,7 @@ import { extractUserEmail, groupNamePrefix } from "@/store/modules/v1/common";
import { ALL_USERS_USER_EMAIL, userBindingPrefix } from "@/types";
import type { Group } from "@/types/proto-es/v1/group_service_pb";
import type { User } from "@/types/proto-es/v1/user_service_pb";
-import { isValidEmail } from "@/utils";
+import { getDefaultPagination, isValidEmail } from "@/utils";
import { getAvatarColor, getInitials } from "./UserAvatar";
@@ -174,10 +174,10 @@ export function AccountMultiSelect({
debounceRef.current = setTimeout(() => {
const query = search.trim();
userStore
- .fetchUserList({ pageSize: 50, filter: { query } })
+ .fetchUserList({ pageSize: getDefaultPagination(), filter: { query } })
.then(({ users: fetched }) => setUsers(fetched));
groupStore
- .fetchGroupList({ pageSize: 50, filter: { query } })
+ .fetchGroupList({ pageSize: getDefaultPagination(), filter: { query } })
.then(({ groups: fetched }) => setGroups(fetched));
}, 300);
return () => {
diff --git a/frontend/src/react/components/DatabaseSelect.tsx b/frontend/src/react/components/DatabaseSelect.tsx
index 4bd6e06ba3..1561773589 100644
--- a/frontend/src/react/components/DatabaseSelect.tsx
+++ b/frontend/src/react/components/DatabaseSelect.tsx
@@ -9,6 +9,7 @@ import type { Database } from "@/types/proto-es/v1/database_service_pb";
import {
extractDatabaseResourceName,
getDatabaseEnvironment,
+ getDefaultPagination,
getInstanceResource,
} from "@/utils";
@@ -64,7 +65,7 @@ export function DatabaseSelect({
engines: stableEngines,
query,
},
- pageSize: 50,
+ pageSize: getDefaultPagination(),
silent: true,
})
.then((result) => setDatabases(result.databases));
diff --git a/frontend/src/react/components/ExprEditor.tsx b/frontend/src/react/components/ExprEditor.tsx
index 77cd2d39e8..f804522e02 100644
--- a/frontend/src/react/components/ExprEditor.tsx
+++ b/frontend/src/react/components/ExprEditor.tsx
@@ -48,6 +48,7 @@ import {
SelectValue,
} from "@/react/components/ui/select";
import { environmentNamePrefix } from "@/store/modules/v1/common";
+import { getDefaultPagination } from "@/utils";
import { CEL_ATTRIBUTE_RESOURCE_ENVIRONMENT_ID } from "@/utils/cel-attributes";
// ============================================================
@@ -294,7 +295,7 @@ function SearchableSelect({
const resp = await optionConfig.search({
search: q,
pageToken: "",
- pageSize: 20,
+ pageSize: getDefaultPagination(),
});
setOptions(resp.options as SearchableSelectOption[]);
} finally {
@@ -484,7 +485,7 @@ function MultiSearchableSelect({
const resp = await optionConfig.search({
search: q,
pageToken: "",
- pageSize: 20,
+ pageSize: getDefaultPagination(),
});
setSearchOptions(resp.options as SearchableSelectOption[]);
} finally {
diff --git a/frontend/src/react/components/InstanceSelect.tsx b/frontend/src/react/components/InstanceSelect.tsx
index a51413b30c..4ca01287a7 100644
--- a/frontend/src/react/components/InstanceSelect.tsx
+++ b/frontend/src/react/components/InstanceSelect.tsx
@@ -6,7 +6,7 @@ import { Combobox } from "@/react/components/ui/combobox";
import { useInstanceV1Store } from "@/store";
import type { Engine } from "@/types/proto-es/v1/common_pb";
import type { Instance } from "@/types/proto-es/v1/instance_service_pb";
-import { extractInstanceResourceName } from "@/utils";
+import { extractInstanceResourceName, getDefaultPagination } from "@/utils";
export interface InstanceSelectProps {
value: string;
@@ -50,7 +50,7 @@ export function InstanceSelect({
(query: string) => {
instanceStore
.fetchInstanceList({
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: { query, engines: stableEngines },
})
.then((result) => setInstances(result.instances));
diff --git a/frontend/src/react/components/IssueTable.tsx b/frontend/src/react/components/IssueTable.tsx
index 76f4fb3b3e..c6d26249ab 100644
--- a/frontend/src/react/components/IssueTable.tsx
+++ b/frontend/src/react/components/IssueTable.tsx
@@ -44,6 +44,7 @@ import {
displayRoleTitle,
extractIssueUID,
extractProjectResourceName,
+ getDefaultPagination,
getHighlightHTMLByRegExp,
getIssueRoute,
getValueFromSearchParams,
@@ -330,7 +331,7 @@ export function useIssueSearchScopeOptions(
const searchPrincipal = useCallback(
async (keyword: string): Promise<ValueOption[]> => {
const resp = await userStore.fetchUserList({
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: { query: keyword },
});
return resp.users.map<ValueOption>((user) => ({
diff --git a/frontend/src/react/components/database/CreateDatabaseDrawer.tsx b/frontend/src/react/components/database/CreateDatabaseDrawer.tsx
index 970079851c..ec9cbcff35 100644
--- a/frontend/src/react/components/database/CreateDatabaseDrawer.tsx
+++ b/frontend/src/react/components/database/CreateDatabaseDrawer.tsx
@@ -37,6 +37,7 @@ import {
} from "@/types/proto-es/v1/plan_service_pb";
import {
enginesSupportCreateDatabase,
+ getDefaultPagination,
getIssueRoute,
instanceV1HasCollationAndCharacterSet,
} from "@/utils";
@@ -254,7 +255,7 @@ export function CreateDatabaseDrawer({
projectStore
.fetchProjectList({
filter: { query, excludeDefault: true },
- pageSize: 50,
+ pageSize: getDefaultPagination(),
})
.then(({ projects: result }) =>
setProjects(result.map((p) => ({ name: p.name, title: p.title })))
diff --git a/frontend/src/react/components/database/TransferProjectDrawer.tsx b/frontend/src/react/components/database/TransferProjectDrawer.tsx
index 7f65b42029..49c899d408 100644
--- a/frontend/src/react/components/database/TransferProjectDrawer.tsx
+++ b/frontend/src/react/components/database/TransferProjectDrawer.tsx
@@ -12,6 +12,7 @@ import type { Database } from "@/types/proto-es/v1/database_service_pb";
import {
extractDatabaseResourceName,
extractProjectResourceName,
+ getDefaultPagination,
getInstanceResource,
} from "@/utils";
@@ -50,7 +51,7 @@ export function TransferProjectDrawer({
try {
const { projects: result } = await projectStore.fetchProjectList({
filter: { query, excludeDefault: true },
- pageSize: 50,
+ pageSize: getDefaultPagination(),
});
setProjects(result.map((p) => ({ name: p.name, title: p.title })));
} finally {
diff --git a/frontend/src/react/pages/project/ProjectAccessGrantsPage.tsx b/frontend/src/react/pages/project/ProjectAccessGrantsPage.tsx
index 68f4535fc7..e63d79425d 100644
--- a/frontend/src/react/pages/project/ProjectAccessGrantsPage.tsx
+++ b/frontend/src/react/pages/project/ProjectAccessGrantsPage.tsx
@@ -47,6 +47,7 @@ import {
getAccessGrantDisplayStatusText,
getAccessGrantExpirationText,
getAccessGrantStatusTagType,
+ getDefaultPagination,
hasProjectPermissionV2,
} from "@/utils";
import { extractDatabaseResourceName } from "@/utils/v1/database";
@@ -151,7 +152,7 @@ export function ProjectAccessGrantsPage({ projectId }: { projectId: string }) {
async (keyword: string): Promise<ValueOption[]> => {
const result = await databaseStore.fetchDatabases({
parent: projectName,
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: keyword ? { query: keyword } : undefined,
});
return result.databases.map((db) => {
@@ -191,7 +192,7 @@ export function ProjectAccessGrantsPage({ projectId }: { projectId: string }) {
const searchUsers = useCallback(
async (keyword: string): Promise<ValueOption[]> => {
const result = await userStore.fetchUserList({
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: keyword ? { query: keyword } : undefined,
});
return result.users.map((u) => ({
diff --git a/frontend/src/react/pages/project/ProjectGitOpsPage.tsx b/frontend/src/react/pages/project/ProjectGitOpsPage.tsx
index 63157f8a1b..30e089f2d9 100644
--- a/frontend/src/react/pages/project/ProjectGitOpsPage.tsx
+++ b/frontend/src/react/pages/project/ProjectGitOpsPage.tsx
@@ -32,6 +32,7 @@ import type { WorkloadIdentity } from "@/types/proto-es/v1/workload_identity_ser
import { WorkloadIdentityConfig_ProviderType } from "@/types/proto-es/v1/workload_identity_service_pb";
import {
extractDatabaseResourceName,
+ getDefaultPagination,
getWorkloadIdentityProviderText,
hasProjectPermissionV2,
hasWorkspacePermissionV2,
@@ -77,7 +78,7 @@ export function ProjectGitOpsPage({ projectId }: { projectId: string }) {
parent: projectName,
filter: { query: search },
pageToken,
- pageSize: 1000,
+ pageSize: getDefaultPagination(),
showDeleted: false,
});
for (const wi of resp.workloadIdentities) {
@@ -125,7 +126,7 @@ export function ProjectGitOpsPage({ projectId }: { projectId: string }) {
const resp = await databaseStore.fetchDatabases({
parent: projectName,
filter: dbSearch ? { query: dbSearch } : {},
- pageSize: 1000,
+ pageSize: getDefaultPagination(),
pageToken,
});
for (const db of resp.databases) {
diff --git a/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx b/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx
index 2936c3dc78..6ddf06f09e 100644
--- a/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx
+++ b/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx
@@ -65,7 +65,7 @@ import {
} from "@/types/proto-es/v1/org_policy_service_pb";
import { Setting_SettingName } from "@/types/proto-es/v1/setting_service_pb";
import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
-import { hasProjectPermissionV2 } from "@/utils";
+import { getDefaultPagination, hasProjectPermissionV2 } from "@/utils";
import {
batchConvertFromCELString,
type ConditionExpression,
@@ -270,7 +270,7 @@ export function ProjectMaskingExemptionPage({
async (keyword: string): Promise<ValueOption[]> => {
const result = await databaseStore.fetchDatabases({
parent: projectName,
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: keyword ? { query: keyword } : undefined,
});
return result.databases.map((db) => {
@@ -293,7 +293,7 @@ export function ProjectMaskingExemptionPage({
const searchUsers = useCallback(
async (keyword: string): Promise<ValueOption[]> => {
const result = await userStore.fetchUserList({
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: keyword ? { query: keyword } : undefined,
});
return result.users.map((u) => ({
diff --git a/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx b/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx
index 715de85898..31478fedcc 100644
--- a/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx
+++ b/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx
@@ -83,6 +83,7 @@ import {
formatAbsoluteDateTime,
generatePlanTitle,
getDatabaseEnvironment,
+ getDefaultPagination,
getInstanceResource,
humanizeTs,
type SearchParams as VueSearchParams,
@@ -170,7 +171,7 @@ export function ProjectPlanDashboardPage({ projectId }: { projectId: string }) {
}) => {
const resp = await userStore.fetchUserList({
pageToken: nextPageToken,
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: { query: keyword },
});
return {
diff --git a/frontend/src/react/pages/project/ProjectSyncSchemaPage.tsx b/frontend/src/react/pages/project/ProjectSyncSchemaPage.tsx
index f8e04befcf..49dccee7da 100644
--- a/frontend/src/react/pages/project/ProjectSyncSchemaPage.tsx
+++ b/frontend/src/react/pages/project/ProjectSyncSchemaPage.tsx
@@ -66,6 +66,7 @@ import {
extractProjectResourceName,
generatePlanTitle,
getDatabaseEnvironment,
+ getDefaultPagination,
getInstanceResource,
humanizeDate,
} from "@/utils";
@@ -788,7 +789,7 @@ function ChangelogSelector({
const { changelogs: fetchedChangelogs, nextPageToken: token } =
await changelogStore.fetchChangelogList({
parent: database,
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: `status == "${Changelog_Status[Changelog_Status.DONE]}"`,
});
@@ -823,7 +824,7 @@ function ChangelogSelector({
await changelogStore.fetchChangelogList({
parent: database,
pageToken: nextPageToken,
- pageSize: 50,
+ pageSize: getDefaultPagination(),
filter: `status == "${Changelog_Status[Changelog_Status.DONE]}"`,
});
setEntries((prev) => [...prev, ...more.map(toEntry)]);
@@ -1946,7 +1947,7 @@ function TargetDatabasesSelectPanel({
const { databases: fetched, nextPageToken: token } =
await databaseStore.fetchDatabases({
parent: project,
- pageSize: 100,
+ pageSize: getDefaultPagination(),
});
setDatabases(fetched);
setDbNextPageToken(token);
@@ -1960,7 +1961,7 @@ function TargetDatabasesSelectPanel({
const { databases: more, nextPageToken: token } =
await databaseStore.fetchDatabases({
parent: project,
- pageSize: 100,
+ pageSize: getDefaultPagination(),
pageToken: dbNextPageToken,
});
setDatabases((prev) => [...prev, ...more]);
diff --git a/frontend/src/react/tsconfig.json b/frontend/src/react/tsconfig.json
new file mode 100644
index 0000000000..fe9f7cabd3
--- /dev/null
+++ b/frontend/src/react/tsconfig.json
@@ -0,0 +1,9 @@
+{
+ "extends": "../../tsconfig.react.json",
+ "compilerOptions": {
+ "paths": {
+ "@/*": ["../../src/*"]
+ }
+ },
+ "include": ["./**/*.ts", "./**/*.tsx", "./react-env.d.ts"]
+}