Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

feat: consolidate database change buttons into unified UI (#18040)

Danny Xu8e427d8242a5
diff --git a/frontend/src/components/v2/Model/DatabaseV1Table/DatabaseOperations.vue b/frontend/src/components/v2/Model/DatabaseV1Table/DatabaseOperations.vue
index 85db092162..d170a9605c 100644
--- a/frontend/src/components/v2/Model/DatabaseV1Table/DatabaseOperations.vue
+++ b/frontend/src/components/v2/Model/DatabaseV1Table/DatabaseOperations.vue
@@ -93,7 +93,7 @@
<AddSpecDrawer
v-model:show="state.showChangeDatabaseDrawer"
- :title="$t('database.edit-database')"
+ :title="$t('database.change-database')"
:pre-selected-databases="databases"
:project-name="selectedProjectName"
:use-legacy-issue-flow="true"
@@ -430,7 +430,7 @@ const actions = computed((): DatabaseAction[] => {
case "CHANGE-DATABASE":
resp.push({
icon: h(PencilIcon),
- text: t("database.edit-database"),
+ text: t("database.change-database"),
disabled:
!allowChangeDatabase.value ||
!selectedProjectName.value ||
@@ -470,7 +470,7 @@ const actions = computed((): DatabaseAction[] => {
case "SYNC-SCHEMA":
resp.push({
icon: h(RefreshCcwIcon),
- text: t("common.sync"),
+ text: t("database.sync-schema-button"),
disabled: !allowSyncDatabases.value || props.databases.length < 1,
click: syncSchema,
tooltip: (action) => getDisabledTooltip(action),
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index 6f584d2405..520fa244b9 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -151,7 +151,6 @@
"disable": "Disable",
"view-doc": "View doc",
"write-only": "write only",
- "sync": "Sync",
"succeed": "Succeed",
"success": "Success",
"failed": "Failed",
@@ -1204,7 +1203,7 @@
"add-instance": "@:common.add @:common.instance",
"new-project": "@:common.new @:common.project",
"create-project": "@:common.create @:common.project",
- "transfer-in-db": "Transfer in DB",
+ "transfer-in-db": "Transfer In",
"from-unassigned-databases": "Unassigned databases",
"from-projects": "From other projects",
"transfer-in-db-title": "Transfer in database",
@@ -1599,6 +1598,7 @@
"no-environment": "This database has not been bound to the environment",
"set-environment": "Set environment",
"sync-database": "Sync Database",
+ "sync-schema-button": "Sync Schema",
"export-schema": "Export Schema",
"export-schema-single-file": "Single File",
"export-schema-multi-file": "Multi-File (ZIP)",
@@ -1612,7 +1612,7 @@
"unassign": "Unassign",
"unassign-alert-title": "Unassign databases",
"unassign-alert-description": "The selected databases will be removed from the project",
- "edit-database": "Edit Database",
+ "change-database": "Change Database",
"edit-schema": "Edit Schema",
"edit-labels": "Edit Labels",
"edit-environment": "Edit Environment",
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index 4cf7f1ce94..3f1fc8de0d 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -152,7 +152,6 @@
"disable": "Inhabilitar",
"view-doc": "Ver doc",
"write-only": "solo escritura",
- "sync": "Sincronizar",
"succeed": "Tener éxito",
"success": "Éxito",
"failed": "Falló",
@@ -1204,7 +1203,7 @@
"add-instance": "@:common.add @:common.instance",
"new-project": "@:common.new @:common.project",
"create-project": "@:common.create @:common.project",
- "transfer-in-db": "Transferir BD",
+ "transfer-in-db": "Transferir",
"from-unassigned-databases": "Bases de datos no asignadas",
"from-projects": "De otro proyecto",
"transfer-in-db-title": "Transferir base de datos",
@@ -1599,6 +1598,7 @@
"no-environment": "Esta base de datos no ha sido vinculada al entorno.",
"set-environment": "Establecer entorno",
"sync-database": "Sincronizar base de datos",
+ "sync-schema-button": "Sincronizar esquema",
"export-schema": "Exportar esquema",
"export-schema-single-file": "Archivo único",
"export-schema-multi-file": "Multi-archivo (ZIP)",
@@ -1612,7 +1612,7 @@
"unassign": "Desasignar",
"unassign-alert-title": "Desasignar bases de datos",
"unassign-alert-description": "Las bases de datos seleccionadas serán eliminadas del proyecto",
- "edit-database": "Editar base de datos",
+ "change-database": "Modificar base de datos",
"edit-schema": "Modificar esquema",
"edit-labels": "Editar etiquetas",
"edit-environment": "Editar entorno",
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index 2a0e2bcd73..af6fa59f61 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -152,7 +152,6 @@
"disable": "無効にする",
"view-doc": "ドキュメントを見る",
"write-only": "書き込み専用",
- "sync": "同期する",
"succeed": "成功する",
"success": "成功",
"failed": "失敗",
@@ -1204,7 +1203,7 @@
"add-instance": "@:common.instance@:common.add",
"new-project": "@:common.new@:common.project",
"create-project": "@:common.create@:common.project",
- "transfer-in-db": "データベースへの転送",
+ "transfer-in-db": "転入",
"from-unassigned-databases": "割り当てられていないデータベース",
"from-projects": "他のプロジェクトから",
"transfer-in-db-title": "データベースへの転送",
@@ -1599,6 +1598,7 @@
"no-environment": "このデータベースは環境にバインドされていません",
"set-environment": "環境を設定する",
"sync-database": "データベースを同期",
+ "sync-schema-button": "スキーマを同期",
"export-schema": "スキーマをエクスポート",
"export-schema-single-file": "単一ファイル",
"export-schema-multi-file": "複数ファイル (ZIP)",
@@ -1612,7 +1612,7 @@
"unassign": "割り当てを解除する",
"unassign-alert-title": "データベースの割り当てを解除する",
"unassign-alert-description": "選択したデータベースがプロジェクトから削除されます",
- "edit-database": "データベースの編集",
+ "change-database": "データベースの変更",
"edit-schema": "スキーマの変更",
"edit-labels": "タグを編集する",
"edit-environment": "環境の編集",
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index cffa2df5f6..86c5cbbf25 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -152,7 +152,6 @@
"disable": "Tắt",
"view-doc": "Xem tài liệu",
"write-only": "chỉ ghi",
- "sync": "Đồng bộ hóa",
"succeed": "Thành công",
"success": "Thành công",
"failed": "Thất bại",
@@ -1204,7 +1203,7 @@
"add-instance": "@:common.add @:common.instance",
"new-project": "@:common.new @:common.project",
"create-project": "@:common.create @:common.project",
- "transfer-in-db": "Chuyển vào Cơ sở dữ liệu",
+ "transfer-in-db": "Chuyển vào",
"from-unassigned-databases": "Cơ sở dữ liệu chưa được gán",
"from-projects": "Từ các dự án khác",
"transfer-in-db-title": "Chuyển vào cơ sở dữ liệu",
@@ -1599,6 +1598,7 @@
"no-environment": "Cơ sở dữ liệu này không bị ràng buộc với môi trường",
"set-environment": "Thiết lập môi trường",
"sync-database": "Đồng bộ cơ sở dữ liệu",
+ "sync-schema-button": "Đồng bộ schema",
"export-schema": "Xuất schema",
"export-schema-single-file": "Tệp đơn",
"export-schema-multi-file": "Nhiều tệp (ZIP)",
@@ -1612,7 +1612,7 @@
"unassign": "Hủy gán",
"unassign-alert-title": "Hủy gán cơ sở dữ liệu",
"unassign-alert-description": "Các cơ sở dữ liệu đã chọn sẽ bị xóa khỏi dự án",
- "edit-database": "Chỉnh sửa cơ sở dữ liệu",
+ "change-database": "Thay đổi cơ sở dữ liệu",
"edit-schema": "Chỉnh sửa lược đồ",
"edit-labels": "Chỉnh sửa nhãn",
"edit-environment": "Chỉnh sửa Môi trường",
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index f2ac4b5ebd..5cdd9a76ff 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -152,7 +152,6 @@
"disable": "禁用",
"view-doc": "查看文档",
"write-only": "仅写入",
- "sync": "同步",
"succeed": "成功",
"success": "成功",
"failed": "失败",
@@ -1204,7 +1203,7 @@
"add-instance": "@:common.add@:common.instance",
"new-project": "@:common.new@:common.project",
"create-project": "@:common.create@:common.project",
- "transfer-in-db": "转进数据库",
+ "transfer-in-db": "转入",
"from-unassigned-databases": "未分配的数据库",
"from-projects": "从其他项目",
"transfer-in-db-title": "转进数据库",
@@ -1599,6 +1598,7 @@
"no-environment": "该数据库尚未绑定到环境",
"set-environment": "设置环境",
"sync-database": "同步数据库",
+ "sync-schema-button": "同步 Schema",
"export-schema": "导出 Schema",
"export-schema-single-file": "单文件",
"export-schema-multi-file": "多文件 (ZIP)",
@@ -1612,7 +1612,7 @@
"unassign": "取消分配",
"unassign-alert-title": "取消分配数据库",
"unassign-alert-description": "选定的数据库将从项目中移除",
- "edit-database": "编辑数据库",
+ "change-database": "变更数据库",
"edit-schema": "变更 Schema",
"edit-labels": "编辑标签",
"edit-environment": "编辑环境",
diff --git a/frontend/src/views/DatabaseDetail/DatabaseDetail.vue b/frontend/src/views/DatabaseDetail/DatabaseDetail.vue
index 27db7aa3a4..5326ee24f8 100644
--- a/frontend/src/views/DatabaseDetail/DatabaseDetail.vue
+++ b/frontend/src/views/DatabaseDetail/DatabaseDetail.vue
@@ -104,16 +104,10 @@
</template>
</NButton>
<NButton
- v-if="allowChangeData"
- @click="createMigration('bb.issue.database.data.update')"
+ v-if="allowChangeDatabase"
+ @click="state.showChangeDatabaseDrawer = true"
>
- <span>{{ $t("database.change-data") }}</span>
- </NButton>
- <NButton
- v-if="allowAlterSchema"
- @click="createMigration('bb.issue.database.schema.update')"
- >
- <span>{{ $t("database.edit-schema") }}</span>
+ <span>{{ $t("database.change-database") }}</span>
</NButton>
</div>
</div>
@@ -181,15 +175,22 @@
@dismiss="state.showTransferDatabaseModal = false"
/>
</Drawer>
+
+ <AddSpecDrawer
+ v-model:show="state.showChangeDatabaseDrawer"
+ :title="$t('database.change-database')"
+ :pre-selected-databases="[database]"
+ :project-name="database.project"
+ :use-legacy-issue-flow="true"
+ />
</template>
<script lang="ts" setup>
import { useTitle } from "@vueuse/core";
-import dayjs from "dayjs";
import { ArrowRightLeftIcon } from "lucide-vue-next";
import { NButton, NTabPane, NTabs } from "naive-ui";
import { computed, reactive, watch, watchEffect } from "vue";
-import { useRouter, useRoute, type LocationQueryRaw } from "vue-router";
+import { useRouter, useRoute } from "vue-router";
import { BBModal } from "@/bbkit";
import { BBAttention } from "@/bbkit";
import DatabaseChangelogPanel from "@/components/Database/DatabaseChangelogPanel.vue";
@@ -205,6 +206,7 @@ import {
import DriftedDatabaseAlert from "@/components/DatabaseDetail/DriftedDatabaseAlert.vue";
import ExportSchemaButton from "@/components/DatabaseDetail/ExportSchemaButton.vue";
import SyncDatabaseButton from "@/components/DatabaseDetail/SyncDatabaseButton.vue";
+import { AddSpecDrawer } from "@/components/Plan";
import TransferOutDatabaseForm from "@/components/TransferOutDatabaseForm";
import { Drawer } from "@/components/v2";
import {
@@ -213,10 +215,7 @@ import {
ProductionEnvironmentV1Icon,
} from "@/components/v2";
import { CopyButton } from "@/components/v2";
-import {
- PROJECT_V1_ROUTE_ISSUE_DETAIL,
- PROJECT_V1_ROUTE_DATABASE_DETAIL,
-} from "@/router/dashboard/projectV1";
+import { PROJECT_V1_ROUTE_DATABASE_DETAIL } from "@/router/dashboard/projectV1";
import { useEnvironmentV1Store, useDatabaseV1ByName } from "@/store";
import {
databaseNamePrefix,
@@ -243,6 +242,7 @@ const isDatabaseHash = (x: any): x is DatabaseHash =>
interface LocalState {
showTransferDatabaseModal: boolean;
showIncorrectProjectModal: boolean;
+ showChangeDatabaseDrawer: boolean;
currentProjectName: string;
selectedIndex: number;
selectedTab: DatabaseHash;
@@ -259,6 +259,7 @@ const router = useRouter();
const state = reactive<LocalState>({
showTransferDatabaseModal: false,
showIncorrectProjectModal: false,
+ showChangeDatabaseDrawer: false,
currentProjectName: UNKNOWN_PROJECT_NAME,
selectedIndex: 0,
selectedTab: "overview",
@@ -273,6 +274,10 @@ const {
allowListChangelogs,
} = useDatabaseDetailContext();
+const allowChangeDatabase = computed(() => {
+ return allowChangeData.value || allowAlterSchema.value;
+});
+
watch(
() => route.hash,
(hash) => {
@@ -336,35 +341,6 @@ const tryTransferProject = () => {
state.showTransferDatabaseModal = true;
};
-const createMigration = async (
- type: "bb.issue.database.schema.update" | "bb.issue.database.data.update"
-) => {
- // Create a user friendly default issue name
- const issueNameParts: string[] = [];
- issueNameParts.push(`[${database.value.databaseName}]`);
- issueNameParts.push(
- type === "bb.issue.database.schema.update" ? `Edit schema` : `Change data`
- );
- const datetime = dayjs().format("@MM-DD HH:mm");
- const tz = "UTC" + dayjs().format("ZZ");
- issueNameParts.push(`${datetime} ${tz}`);
-
- const query: LocationQueryRaw = {
- template: type,
- name: issueNameParts.join(" "),
- databaseList: database.value.name,
- };
-
- router.push({
- name: PROJECT_V1_ROUTE_ISSUE_DETAIL,
- params: {
- projectId: extractProjectResourceName(project.value.name),
- issueSlug: "create",
- },
- query,
- });
-};
-
const handleGotoSQLEditorFailed = () => {
state.currentProjectName = database.value.project;
state.showIncorrectProjectModal = true;
diff --git a/frontend/src/views/project/ProjectDatabaseGroupDetail.vue b/frontend/src/views/project/ProjectDatabaseGroupDetail.vue
index 21371b9658..6af21d191b 100644
--- a/frontend/src/views/project/ProjectDatabaseGroupDetail.vue
+++ b/frontend/src/views/project/ProjectDatabaseGroupDetail.vue
@@ -20,25 +20,9 @@
<template #trigger>
<NButton
:disabled="!hasMatchedDatabases"
- @click="
- previewDatabaseGroupIssue('bb.issue.database.schema.update')
- "
+ @click="state.showChangeDatabaseDrawer = true"
>
- {{ $t("database.edit-schema") }}
- </NButton>
- </template>
- {{ $t("database-group.no-matched-databases") }}
- </NTooltip>
- <NTooltip
- v-if="hasPermissionToCreateIssue"
- :disabled="hasMatchedDatabases"
- >
- <template #trigger>
- <NButton
- :disabled="!hasMatchedDatabases"
- @click="previewDatabaseGroupIssue('bb.issue.database.data.update')"
- >
- {{ $t("database.change-data") }}
+ {{ $t("database.change-database") }}
</NButton>
</template>
{{ $t("database-group.no-matched-databases") }}
@@ -57,6 +41,14 @@
:database-group="databaseGroup"
@dismiss="state.editing = false"
/>
+
+ <AddSpecDrawer
+ v-if="databaseGroup"
+ v-model:show="state.showChangeDatabaseDrawer"
+ :title="$t('database.change-database')"
+ :project-name="project.name"
+ :use-legacy-issue-flow="true"
+ />
</div>
</template>
@@ -64,9 +56,9 @@
import { EditIcon } from "lucide-vue-next";
import { NButton, NTooltip } from "naive-ui";
import { computed, reactive, watchEffect } from "vue";
-import { useRouter } from "vue-router";
import DatabaseGroupForm from "@/components/DatabaseGroup/DatabaseGroupForm.vue";
import FeatureAttention from "@/components/FeatureGuard/FeatureAttention.vue";
+import { AddSpecDrawer } from "@/components/Plan";
import { useDBGroupStore, useProjectByName, featureToRef } from "@/store";
import {
databaseGroupNamePrefix,
@@ -75,10 +67,10 @@ import {
import { DatabaseGroupView } from "@/types/proto-es/v1/database_group_service_pb";
import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
import { hasPermissionToCreateChangeDatabaseIssueInProject } from "@/utils";
-import { generateDatabaseGroupIssueRoute } from "@/utils/databaseGroup/issue";
interface LocalState {
editing: boolean;
+ showChangeDatabaseDrawer: boolean;
}
const props = defineProps<{
@@ -87,13 +79,13 @@ const props = defineProps<{
allowEdit: boolean;
}>();
-const router = useRouter();
const dbGroupStore = useDBGroupStore();
const { project } = useProjectByName(
computed(() => `${projectNamePrefix}${props.projectId}`)
);
const state = reactive<LocalState>({
editing: false,
+ showChangeDatabaseDrawer: false,
});
const databaseGroupResourceName = computed(() => {
@@ -122,14 +114,4 @@ watchEffect(async () => {
view: DatabaseGroupView.FULL,
});
});
-
-const previewDatabaseGroupIssue = (
- type: "bb.issue.database.schema.update" | "bb.issue.database.data.update"
-) => {
- if (!databaseGroup.value) {
- return;
- }
- const issueRoute = generateDatabaseGroupIssueRoute(type, databaseGroup.value);
- router.push(issueRoute);
-};
</script>