Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: update (#19074)

ecmadao8ea26c72a853
diff --git a/backend/api/v1/project_service_converter.go b/backend/api/v1/project_service_converter.go
index e2e714a703..a5db68bc81 100644
--- a/backend/api/v1/project_service_converter.go
+++ b/backend/api/v1/project_service_converter.go
@@ -223,10 +223,6 @@ func convertToStoreIamPolicy(iamPolicy *v1pb.IamPolicy) (*storepb.IamPolicy, err
bindings = append(bindings, storeBinding)
}
- if len(bindings) == 0 {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("policy binding is empty"))
- }
-
return &storepb.IamPolicy{
Bindings: bindings,
}, nil
diff --git a/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue b/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue
index d64b2d188a..938a6795d6 100644
--- a/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue
+++ b/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue
@@ -52,10 +52,14 @@
{{ rule.title || "-" }}
</div>
<div class="px-3 py-2 truncate">
- <code class="text-xs">{{ rule.condition || "true" }}</code>
+ <EllipsisText>
+ <code class="text-xs">{{ rule.condition || "true" }}</code>
+ </EllipsisText>
</div>
<div class="px-3 py-2 truncate">
- {{ formatApprovalFlow(rule.flow) }}
+ <EllipsisText>
+ {{ formatApprovalFlow(rule.flow) }}
+ </EllipsisText>
</div>
<div class="px-3 py-2 w-24 flex items-center gap-x-1">
<MiniActionButton @click="handleEditRule(rule)">
@@ -110,6 +114,7 @@ import { NButton, NPopconfirm } from "naive-ui";
import { computed, ref, watch } from "vue";
import { useI18n } from "vue-i18n";
import Draggable from "vuedraggable";
+import EllipsisText from "@/components/EllipsisText.vue";
import PermissionGuardWrapper from "@/components/Permission/PermissionGuardWrapper.vue";
import { MiniActionButton } from "@/components/v2";
import { pushNotification, useWorkspaceApprovalSettingStore } from "@/store";
diff --git a/frontend/src/components/User/Settings/UserDataTable/index.vue b/frontend/src/components/User/Settings/UserDataTable/index.vue
index f946edd3fa..db2d9e497a 100644
--- a/frontend/src/components/User/Settings/UserDataTable/index.vue
+++ b/frontend/src/components/User/Settings/UserDataTable/index.vue
@@ -58,7 +58,6 @@ const props = defineProps<{
showRoles: boolean;
userList: User[];
loading: boolean;
- onClickUser?: (user: User, event: MouseEvent) => void;
}>();
const emit = defineEmits<{
@@ -98,7 +97,6 @@ const columns = computed(() => {
return h(UserNameCell, {
user,
"onReset-service-key": tryResetServiceKey,
- "on-click-user": props.onClickUser,
});
},
},
@@ -131,11 +129,6 @@ const columns = computed(() => {
render: (user: User) => {
return h(UserOperationsCell, {
user,
- "onClick-user": (user: User, e: MouseEvent) => {
- if (props.onClickUser) {
- props.onClickUser(user, e);
- }
- },
"onUpdate-user": (user: User) => {
emit("update-user", user);
},
diff --git a/frontend/src/components/User/Settings/UserDataTableByGroup/index.vue b/frontend/src/components/User/Settings/UserDataTableByGroup/index.vue
index 56a82a3313..73dea29b0d 100644
--- a/frontend/src/components/User/Settings/UserDataTableByGroup/index.vue
+++ b/frontend/src/components/User/Settings/UserDataTableByGroup/index.vue
@@ -50,7 +50,6 @@ const props = withDefaults(
loading: boolean;
showGroupRole?: boolean;
expandedKeys?: string[];
- onClickUser?: (user: User, event: MouseEvent) => void;
}>(),
{
showGroupRole: true,
@@ -118,7 +117,6 @@ const columns = computed(() => {
<GroupMemberNameCell
user={row.user}
role={props.showGroupRole ? row.role : undefined}
- onClickUser={props.onClickUser}
/>
);
},
diff --git a/frontend/src/store/modules/v1/environment.ts b/frontend/src/store/modules/v1/environment.ts
index b87d4f3966..d23695ad73 100644
--- a/frontend/src/store/modules/v1/environment.ts
+++ b/frontend/src/store/modules/v1/environment.ts
@@ -109,7 +109,7 @@ export const useEnvironmentV1Store = defineStore("environment_v1", {
if (!hasWorkspacePermissionV2("bb.settings.getEnvironment")) {
return;
}
- const setting = await useSettingV1Store().fetchSettingByName(
+ const setting = await useSettingV1Store().getOrFetchSettingByName(
Setting_SettingName.ENVIRONMENT,
silent
);
diff --git a/frontend/src/store/modules/v1/setting.ts b/frontend/src/store/modules/v1/setting.ts
index c44228ecbd..99a9de7fb6 100644
--- a/frontend/src/store/modules/v1/setting.ts
+++ b/frontend/src/store/modules/v1/setting.ts
@@ -68,7 +68,6 @@ export const useSettingV1Store = defineStore("setting_v1", () => {
const response = await settingServiceClientConnect.getSetting(request, {
contextValues: createContextValues().set(silentContextKey, silent),
});
- settingMapByName.set(response.name, response);
return response;
} catch {
return;
@@ -81,15 +80,19 @@ export const useSettingV1Store = defineStore("setting_v1", () => {
);
};
- const getOrFetchSettingByName = (
+ const getOrFetchSettingByName = async (
name: Setting_SettingName,
silent = false
- ): Promise<Setting | undefined> | Setting | undefined => {
+ ): Promise<Setting | undefined> => {
const setting = getSettingByName(name);
if (setting) {
return setting;
}
- return fetchSettingByName(name, silent);
+ const response = await fetchSettingByName(name, silent);
+ if (response) {
+ settingMapByName.set(response.name, response);
+ }
+ return response;
};
const upsertSetting = async ({
@@ -152,7 +155,6 @@ export const useSettingV1Store = defineStore("setting_v1", () => {
workspaceProfile,
classification,
getProjectClassification,
- fetchSettingByName,
getSettingByName,
getOrFetchSettingByName,
upsertSetting,
diff --git a/frontend/src/store/modules/workspaceApprovalSetting.ts b/frontend/src/store/modules/workspaceApprovalSetting.ts
index 2e81c093ee..98ebcfe0c4 100644
--- a/frontend/src/store/modules/workspaceApprovalSetting.ts
+++ b/frontend/src/store/modules/workspaceApprovalSetting.ts
@@ -34,7 +34,7 @@ export const useWorkspaceApprovalSettingStore = defineStore(
const fetchConfig = async () => {
try {
- const response = await settingStore.fetchSettingByName(
+ const response = await settingStore.getOrFetchSettingByName(
Setting_SettingName.WORKSPACE_APPROVAL
);
if (!response) {
diff --git a/frontend/src/views/Setup/Setup.vue b/frontend/src/views/Setup/Setup.vue
index 5cbf3554df..232b3b54f7 100644
--- a/frontend/src/views/Setup/Setup.vue
+++ b/frontend/src/views/Setup/Setup.vue
@@ -26,5 +26,6 @@ onMounted(async () => {
useRoleStore().fetchRoleList(),
useWorkspaceV1Store().fetchIamPolicy(),
]);
+ ready.value = true;
});
</script>