Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(backend): add validation checks to rollout auto-creation (#18794)

boojack929e23d490ef
diff --git a/backend/runner/taskrun/rollout_creator.go b/backend/runner/taskrun/rollout_creator.go
index 8ac5c16416..dd560970db 100644
--- a/backend/runner/taskrun/rollout_creator.go
+++ b/backend/runner/taskrun/rollout_creator.go
@@ -61,6 +61,13 @@ func (rc *RolloutCreator) tryCreateRollout(ctx context.Context, planID int64) {
return
}
+ // Skip deleted (closed) plans
+ if plan.Deleted {
+ slog.Debug("plan is deleted, skipping rollout creation",
+ slog.Int("plan_id", int(planID)))
+ return
+ }
+
// Idempotency: skip if rollout already exists
if plan.Config != nil && plan.Config.HasRollout {
slog.Debug("rollout already exists, skipping creation",
@@ -68,6 +75,13 @@ func (rc *RolloutCreator) tryCreateRollout(ctx context.Context, planID int64) {
return
}
+ // Only auto-create rollout for plans with change database specs
+ if !hasOnlyChangeDatabaseSpecs(plan) {
+ slog.Debug("plan has non-change-database specs, skipping auto-creation",
+ slog.Int("plan_id", int(planID)))
+ return
+ }
+
issue, err := rc.store.GetIssue(ctx, &store.FindIssueMessage{PlanUID: &planID})
if err != nil {
slog.Error("failed to get issue for rollout creation",
@@ -80,6 +94,13 @@ func (rc *RolloutCreator) tryCreateRollout(ctx context.Context, planID int64) {
return
}
+ // Skip canceled issues
+ if issue.Status == storepb.Issue_CANCELED {
+ slog.Debug("issue is canceled, skipping rollout creation",
+ slog.Int("plan_id", int(planID)))
+ return
+ }
+
project, err := rc.store.GetProject(ctx, &store.FindProjectMessage{ResourceID: &plan.ProjectID})
if err != nil {
slog.Error("failed to get project for rollout creation",
@@ -153,3 +174,20 @@ func (rc *RolloutCreator) tryCreateRollout(ctx context.Context, planID int64) {
slog.Info("successfully auto-created rollout", slog.Int("plan_id", int(planID)))
}
+
+// hasOnlyChangeDatabaseSpecs checks if every spec in the plan is a change database spec.
+// Only plans with change database specs support auto-creation of rollouts.
+func hasOnlyChangeDatabaseSpecs(plan *store.PlanMessage) bool {
+ if plan.Config == nil {
+ return false
+ }
+ if len(plan.Config.Specs) == 0 {
+ return false
+ }
+ for _, spec := range plan.Config.Specs {
+ if _, ok := spec.Config.(*storepb.PlanConfig_Spec_ChangeDatabaseConfig); !ok {
+ return false
+ }
+ }
+ return true
+}