Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat(frontend): warn before submitting for review when checks have errors (#19458)
boojack93aff497217f
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vueindex e2ddb64427..13fda841e4 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vue+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vue@@ -1,7 +1,7 @@<template><NPopovertrigger="click"- placement="bottom"+ placement="bottom-end":show="showPopover"@update:show="showPopover = $event">@@ -25,7 +25,10 @@</template><template #default>- <div class="w-72 flex flex-col gap-y-3 p-1">+ <div class="w-80 flex flex-col gap-y-3 p-1">+ <NAlert v-if="showChecksWarning" type="warning">+ {{ $t("issue.checks-warning-hint") }}+ </NAlert><div class="flex flex-col gap-y-1"><div class="font-medium text-control flex items-center gap-x-1">{{ $t("issue.labels") }}@@ -39,7 +42,19 @@@update:selected="selectedLabels = $event"/></div>- <div class="flex justify-end gap-x-2">+ <div class="flex items-center gap-x-2">+ <NCheckbox+ v-if="showChecksWarning"+ v-model:checked="checksWarningAcknowledged"+ size="small"+ >+ {{+ $t("issue.action-anyway", {+ action: $t("common.confirm"),+ })+ }}+ </NCheckbox>+ <div class="grow" /><NButton size="small" quaternary @click="showPopover = false">{{ $t("common.cancel") }}</NButton>@@ -67,7 +82,7 @@<script setup lang="ts">import { create } from "@bufbuild/protobuf";-import { NButton, NPopover, NTooltip } from "naive-ui";+import { NAlert, NButton, NCheckbox, NPopover, NTooltip } from "naive-ui";import { computed, nextTick, ref, watch } from "vue";import { useI18n } from "vue-i18n";import { useRouter } from "vue-router";@@ -119,10 +134,13 @@ const {hasRunning: hasRunningPlanChecks,} = usePlanCheckStatus(plan);-// Reset labels when popover opens+const checksWarningAcknowledged = ref(false);++// Reset state when popover openswatch(showPopover, (show) => {if (show) {selectedLabels.value = [];+ checksWarningAcknowledged.value = false;}});@@ -161,6 +179,20 @@ const errors = computed(() => {return list;});+// Show warning when checks have errors for database change plans.+// Backend always skips auto-rollout creation when checks have errors.+// Only relevant for change-database plans (auto-rollout doesn't apply to exports).+// When enforceSqlReview is on, the button is already disabled so this won't be visible.+const showChecksWarning = computed(() => {+ return (+ planCheckSummaryStatus.value === Advice_Level.ERROR &&+ plan.value.specs.length > 0 &&+ plan.value.specs.every(+ (spec) => spec.config?.case === "changeDatabaseConfig"+ )+ );+});+// Errors that disable the confirm button in popoverconst confirmErrors = computed(() => {const list: string[] = [];@@ -169,6 +201,10 @@ const confirmErrors = computed(() => {list.push(t("plan.labels-required-for-review"));}+ if (showChecksWarning.value && !checksWarningAcknowledged.value) {+ list.push(t("issue.checks-warning-hint"));+ }+return list;});diff --git a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vueindex fda9c0eecc..89d30f35a4 100644--- a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue+++ b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue@@ -56,8 +56,12 @@ const { refreshResources } = useResourcePoller();const { hasErrors: checksHaveErrors, hasRunning: checksRunning } =usePlanCheckStatus(plan);-const isDatabaseChangePlan = computed(() =>- plan.value.specs.some((spec) => spec.config?.case === "changeDatabaseConfig")+const isDatabaseChangePlan = computed(+ () =>+ plan.value.specs.length > 0 &&+ plan.value.specs.every(+ (spec) => spec.config?.case === "changeDatabaseConfig"+ ));const isApproved = computed(() => {diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex 9911f2625e..bd26954e58 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -1081,6 +1081,7 @@},"force-rollout-hint": "Proceed with manual rollout to override failed checks.","checks-block-rollout-hint": "Failed checks are preventing rollout creation. Fix the errors to proceed.",+ "checks-warning-hint": "This plan has failed checks. A manual rollout will be required upon approval.","risk-level": {"self": "Risk level","low": "Low",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex e002ea6430..04a61d619a 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -1081,6 +1081,7 @@},"force-rollout-hint": "Proceda con el despliegue manual para anular las verificaciones fallidas.","checks-block-rollout-hint": "Las verificaciones fallidas impiden la creación del despliegue. Corrija los errores para continuar.",+ "checks-warning-hint": "Este plan tiene verificaciones fallidas. Se requerirá un despliegue manual tras la aprobación.","risk-level": {"self": "Nivel de riesgo","low": "Bajo",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex c2ab341d0b..50122d966f 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -1081,6 +1081,7 @@},"force-rollout-hint": "手動でロールアウトを作成して、失敗したチェックをオーバーライドしてください。","checks-block-rollout-hint": "チェックの失敗によりロールアウトを作成できません。エラーを修正してから続行してください。",+ "checks-warning-hint": "このプランにはチェックエラーがあります。承認後、手動でロールアウトを作成する必要があります。","risk-level": {"self": "リスクレベル","low": "低い",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex b0fdfc4b1c..3a251a3d28 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -1081,6 +1081,7 @@},"force-rollout-hint": "Tiến hành triển khai thủ công để bỏ qua các kiểm tra thất bại.","checks-block-rollout-hint": "Kiểm tra thất bại đang ngăn việc tạo triển khai. Hãy sửa lỗi để tiếp tục.",+ "checks-warning-hint": "Kế hoạch này có kiểm tra thất bại. Sẽ cần triển khai thủ công sau khi phê duyệt.","risk-level": {"self": "Mức độ rủi ro","low": "Thấp",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex 18929dab56..3112fd1f78 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -1081,6 +1081,7 @@},"force-rollout-hint": "手动创建发布以跳过失败的 SQL 检查。","checks-block-rollout-hint": "SQL 检查失败导致无法创建发布。请修复错误后再继续。",+ "checks-warning-hint": "此变更计划存在未通过的检查。审批通过后将需要手动创建发布。","risk-level": {"self": "风险等级","low": "低风险",