Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(query-span): considering use identifier as alias (#18575)

h3n4l968540e64379
diff --git a/backend/plugin/parser/pg/query_span_extractor.go b/backend/plugin/parser/pg/query_span_extractor.go
index 040ad8ff5f..62b9a8c237 100644
--- a/backend/plugin/parser/pg/query_span_extractor.go
+++ b/backend/plugin/parser/pg/query_span_extractor.go
@@ -2610,6 +2610,8 @@ func (q *querySpanExtractor) handleTargetLabel(labelCtx *postgresql.Target_label
targetAlias := labelCtx.Target_alias()
if targetAlias.Collabel() != nil {
columnName = normalizePostgreSQLCollabel(targetAlias.Collabel())
+ } else if targetAlias.Identifier() != nil {
+ columnName = normalizePostgreSQLIdentifier(targetAlias.Identifier())
}
}
diff --git a/backend/plugin/parser/pg/test-data/query_span.yaml b/backend/plugin/parser/pg/test-data/query_span.yaml
index d87886c77e..ca1ba356df 100644
--- a/backend/plugin/parser/pg/test-data/query_span.yaml
+++ b/backend/plugin/parser/pg/test-data/query_span.yaml
@@ -1,3 +1,35 @@
+- description:
+ statement: |-
+ SELECT
+ MIN(bb) AS aa
+ FROM
+ (
+ SELECT
+ 1 bb
+ ) AS r
+ WHERE
+ 1 = 1
+ ;
+ defaultDatabase: db
+ metadata: |-
+ {
+ "name": "db",
+ "schemas": [
+ {
+ "name": "public"
+ }
+ ]
+ }
+ querySpan:
+ type: 1
+ results:
+ - name: aa
+ sourcecolumns: []
+ isplainfield: false
+ sourcefieldpaths: []
+ selectasterisk: false
+ sourcecolumns: []
+ predicatecolumns: []
- description: unnest as table source with alias
statement: SELECT * FROM unnest(ARRAY[1,2,3], ARRAY[0,0,0]) as t(a, b);
defaultDatabase: db