Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: donot show context menu for shared folder (#21306)
ecmadao97530f45b5ae
diff --git a/frontend/src/modules/sql-editor/components/SheetTree.test.tsx b/frontend/src/modules/sql-editor/components/SheetTree.test.tsxindex 7bcb384550..6f6d4f7e21 100644--- a/frontend/src/modules/sql-editor/components/SheetTree.test.tsx+++ b/frontend/src/modules/sql-editor/components/SheetTree.test.tsx@@ -945,6 +945,42 @@ describe("SheetTree", () => {unmount();});+ test("does not open the context menu for shared folders", () => {+ const defaultMocks = setupDefaultMocks();+ const folder = makeFolderNode("/shared/folder");+ defaultMocks.viewContext._sheetTree.value = makeFolderNode("/shared", [+ folder,+ ]);+ defaultMocks.viewContext.folderContext.rootPath = "/shared";++ const handleContextMenu = vi.fn();+ mocks.useDropdown.mockReturnValue({+ currentNode: undefined,+ options: [],+ savedQueryEntity: undefined,+ showSharePanel: false,+ handleContextMenu,+ handleSharePanelShow: vi.fn(),+ handleClickOutside: vi.fn(),+ });++ const { container, render, unmount } = renderIntoContainer(+ <SheetTree view="shared" />+ );+ render();++ const row = container.querySelector(+ '[data-item-key="/shared/folder"]'+ );+ act(() => {+ row?.dispatchEvent(new MouseEvent("contextmenu", { bubbles: true }));+ });++ expect(handleContextMenu).not.toHaveBeenCalled();++ unmount();+ });+test("6. Delete confirm → fires savedQueryV1Store.deleteSavedQueryByName", async () => {const defaultMocks = setupDefaultMocks();const wsNode = makeSavedQueryNode("/my/ws2", "savedQueries/ws2");diff --git a/frontend/src/modules/sql-editor/components/SheetTree.tsx b/frontend/src/modules/sql-editor/components/SheetTree.tsxindex 1b0fc1941b..0208191f84 100644--- a/frontend/src/modules/sql-editor/components/SheetTree.tsx+++ b/frontend/src/modules/sql-editor/components/SheetTree.tsx@@ -1176,7 +1176,13 @@ export function SheetTree({onContextMenu={(e) => {e.preventDefault();e.stopPropagation();- if (view === "draft" || folderNode.loadMore) return;+ if (+ view === "draft" ||+ folderNode.loadMore ||+ (view === "shared" && !folderNode.savedQuery)+ ) {+ return;+ }openMenuAtPoint(e.clientX, e.clientY, folderNode);}}>diff --git a/frontend/src/modules/sql-editor/components/TreeNodeSuffix.test.tsx b/frontend/src/modules/sql-editor/components/TreeNodeSuffix.test.tsxindex 67bd4718c7..9875dc4e3d 100644--- a/frontend/src/modules/sql-editor/components/TreeNodeSuffix.test.tsx+++ b/frontend/src/modules/sql-editor/components/TreeNodeSuffix.test.tsx@@ -200,6 +200,27 @@ describe("TreeNodeSuffix", () => {unmount();});+ test("does not render an action suffix for shared folders", () => {+ const node = makeNode({ key: "/shared/folder" });+ const onContextMenuShow = vi.fn();++ const { container, render, unmount } = renderIntoContainer(+ <TreeNodeSuffix+ node={node}+ view="shared"+ onToggleStar={vi.fn()}+ onSharePanelShow={vi.fn()}+ onContextMenuShow={onContextMenuShow}+ />+ );+ render();++ expect(container.querySelector("svg.lucide-ellipsis")).toBeNull();+ expect(onContextMenuShow).not.toHaveBeenCalled();++ unmount();+ });+test("fetches saved query creator before rendering the raw identifier", () => {mocks.getUserByIdentifier.mockReturnValue(undefined);const node = makeSavedQueryNode();diff --git a/frontend/src/modules/sql-editor/components/TreeNodeSuffix.tsx b/frontend/src/modules/sql-editor/components/TreeNodeSuffix.tsxindex 7ed256fdea..b1635d8ce1 100644--- a/frontend/src/modules/sql-editor/components/TreeNodeSuffix.tsx+++ b/frontend/src/modules/sql-editor/components/TreeNodeSuffix.tsx@@ -115,6 +115,9 @@ export function TreeNodeSuffix({// Folder node: only show "More" buttonif (!node.savedQuery) {+ if (view === "shared") {+ return null;+ }return (<MoreHorizontalclassName="size-4 text-control shrink-0 cursor-pointer"