Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(fe): show engine-specific error messages when prior backup is disabled (#18888)
boojack98c36f6ed5fc
diff --git a/frontend/src/components/Plan/components/Configuration/PreBackupSection/PreBackupSwitch.vue b/frontend/src/components/Plan/components/Configuration/PreBackupSection/PreBackupSwitch.vueindex 99dd886324..3849a424e8 100644--- a/frontend/src/components/Plan/components/Configuration/PreBackupSection/PreBackupSwitch.vue+++ b/frontend/src/components/Plan/components/Configuration/PreBackupSection/PreBackupSwitch.vue@@ -34,6 +34,7 @@ import type { ErrorItem } from "@/components/misc/ErrorList.vue";import ErrorList from "@/components/misc/ErrorList.vue";import { targetsForSpec } from "@/components/Plan/logic";import { pushNotification } from "@/store";+import { Engine } from "@/types/proto-es/v1/common_pb";import { BACKUP_AVAILABLE_ENGINES } from "./common";import { usePreBackupSettingContext } from "./context";@@ -59,6 +60,76 @@ const errors = computed(() => {);}+ // Check for databases with supported engines but missing backup location+ const missingBackupLocationDatabases = databases.value.filter(+ (db) =>+ BACKUP_AVAILABLE_ENGINES.includes(db.instanceResource.engine) &&+ !db.backupAvailable+ );++ if (missingBackupLocationDatabases.length > 0) {+ // Group by engine type for clearer messages+ const postgresDBs = missingBackupLocationDatabases.filter(+ (db) => db.instanceResource.engine === Engine.POSTGRES+ );+ const mysqlLikeDBs = missingBackupLocationDatabases.filter(+ (db) =>+ db.instanceResource.engine === Engine.MYSQL ||+ db.instanceResource.engine === Engine.TIDB ||+ db.instanceResource.engine === Engine.MSSQL+ );+ const oracleDBs = missingBackupLocationDatabases.filter(+ (db) => db.instanceResource.engine === Engine.ORACLE+ );++ // PostgreSQL: requires schema 'bbdataarchive' within the database+ for (const db of postgresDBs) {+ errors.push(+ t("plan.pre-backup.missing-backup-schema-postgres", {+ database: db.databaseName,+ })+ );+ }++ // MySQL/TiDB/MSSQL: requires database 'bbdataarchive' on the instance+ // Group by instance to avoid duplicate messages+ const mysqlInstanceMap = new Map<string, string>();+ for (const db of mysqlLikeDBs) {+ if (!mysqlInstanceMap.has(db.instanceResource.name)) {+ mysqlInstanceMap.set(+ db.instanceResource.name,+ db.instanceResource.title+ );+ }+ }+ for (const [, instanceTitle] of mysqlInstanceMap) {+ errors.push(+ t("plan.pre-backup.missing-backup-database", {+ instance: instanceTitle,+ })+ );+ }++ // Oracle: requires database 'BBDATAARCHIVE' on the instance+ // Group by instance to avoid duplicate messages+ const oracleInstanceMap = new Map<string, string>();+ for (const db of oracleDBs) {+ if (!oracleInstanceMap.has(db.instanceResource.name)) {+ oracleInstanceMap.set(+ db.instanceResource.name,+ db.instanceResource.title+ );+ }+ }+ for (const [, instanceTitle] of oracleInstanceMap) {+ errors.push(+ t("plan.pre-backup.missing-backup-database-oracle", {+ instance: instanceTitle,+ })+ );+ }+ }+return errors;});diff --git a/frontend/src/components/misc/ErrorList.vue b/frontend/src/components/misc/ErrorList.vueindex e4b1ece61c..7ff91f026f 100644--- a/frontend/src/components/misc/ErrorList.vue+++ b/frontend/src/components/misc/ErrorList.vue@@ -1,9 +1,14 @@<template><ul- class="flex flex-col whitespace-nowrap"+ class="flex flex-col":class="[showBullets && 'list-disc pl-4']">- <li v-for="(item, i) in errors" :key="i" :style="itemStyle(item)">+ <li+ v-for="(item, i) in errors"+ :key="i"+ :style="itemStyle(item)"+ class="wrap-break-word"+ ><slot name="prefix" /><component v-if="isJSXElement(itemText(item))" :is="itemText(item)" /><span v-else>{{ itemText(item) }}</span>diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex 7c88329b02..37a19ee466 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -1226,7 +1226,10 @@"only-some-databases-checked": "Only some databases are checked","some-databases-not-meeting-requirements": "Some databases ({databases}) don't meet requirements","some-databases-have-issues": "{count} database has issues | {count} databases have issues",- "configuration-has-issues": "Configuration has {count} issue | Configuration has {count} issues"+ "configuration-has-issues": "Configuration has {count} issue | Configuration has {count} issues",+ "missing-backup-schema-postgres": "Create schema 'bbdataarchive' in database '{database}', then sync the database",+ "missing-backup-database": "Create database 'bbdataarchive' on instance '{instance}', then sync the instance and database",+ "missing-backup-database-oracle": "Create database 'BBDATAARCHIVE' on instance '{instance}', then sync the instance and database"},"ghost": {"only-some-databases-checked": "Only some databases are checked",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 5e236f4149..58714b7fe6 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -1226,7 +1226,10 @@"only-some-databases-checked": "Sólo se comprueban algunas bases de datos","some-databases-not-meeting-requirements": "Algunas bases de datos ({databases}) no cumplen los requisitos","some-databases-have-issues": "{count} la base de datos tiene problemas | {count} las bases de datos tienen problemas",- "configuration-has-issues": "La configuración tiene {count} problemas | La configuración tiene {count} problemas"+ "configuration-has-issues": "La configuración tiene {count} problemas | La configuración tiene {count} problemas",+ "missing-backup-schema-postgres": "Cree el esquema 'bbdataarchive' en la base de datos '{database}', luego sincronice la base de datos",+ "missing-backup-database": "Cree la base de datos 'bbdataarchive' en la instancia '{instance}', luego sincronice la instancia y la base de datos",+ "missing-backup-database-oracle": "Cree la base de datos 'BBDATAARCHIVE' en la instancia '{instance}', luego sincronice la instancia y la base de datos"},"ghost": {"only-some-databases-checked": "Sólo se comprueban algunas bases de datos",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 986d932e8d..0ea557b8e0 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -1226,7 +1226,10 @@"only-some-databases-checked": "一部のデータベースのみがチェックされます","some-databases-not-meeting-requirements": "一部のデータベース ({databases}) は要件を満たしていません","some-databases-have-issues": "{count} データベースに問題があります | {count} データベースに問題があります",- "configuration-has-issues": "構成に {count} 個の問題があります | 構成に {count} 個の問題があります"+ "configuration-has-issues": "構成に {count} 個の問題があります | 構成に {count} 個の問題があります",+ "missing-backup-schema-postgres": "データベース '{database}' にスキーマ 'bbdataarchive' を作成し、データベースを同期してください",+ "missing-backup-database": "インスタンス '{instance}' にデータベース 'bbdataarchive' を作成し、インスタンスとデータベースを同期してください",+ "missing-backup-database-oracle": "インスタンス '{instance}' にデータベース 'BBDATAARCHIVE' を作成し、インスタンスとデータベースを同期してください"},"ghost": {"only-some-databases-checked": "一部のデータベースのみがチェックされます",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex 1a3ffad2fb..a244fddb93 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -1226,7 +1226,10 @@"only-some-databases-checked": "Chỉ một số cơ sở dữ liệu được kiểm tra","some-databases-not-meeting-requirements": "Một số cơ sở dữ liệu ({databases}) không đáp ứng được yêu cầu","some-databases-have-issues": "{count} cơ sở dữ liệu có vấn đề | {count} cơ sở dữ liệu có vấn đề",- "configuration-has-issues": "Cấu hình có vấn đề {count} | Cấu hình có vấn đề {count}"+ "configuration-has-issues": "Cấu hình có vấn đề {count} | Cấu hình có vấn đề {count}",+ "missing-backup-schema-postgres": "Tạo schema 'bbdataarchive' trong cơ sở dữ liệu '{database}', sau đó đồng bộ cơ sở dữ liệu",+ "missing-backup-database": "Tạo cơ sở dữ liệu 'bbdataarchive' trên instance '{instance}', sau đó đồng bộ instance và cơ sở dữ liệu",+ "missing-backup-database-oracle": "Tạo cơ sở dữ liệu 'BBDATAARCHIVE' trên instance '{instance}', sau đó đồng bộ instance và cơ sở dữ liệu"},"ghost": {"only-some-databases-checked": "Chỉ một số cơ sở dữ liệu được kiểm tra",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex ae75261c8e..e66ddf169c 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -1226,7 +1226,10 @@"only-some-databases-checked": "仅检查部分数据库","some-databases-not-meeting-requirements": "部分数据库({databases})不符合要求","some-databases-have-issues": "{count} 个数据库有问题 | {count} 个数据库有问题",- "configuration-has-issues": "配置存在 {count} 个问题 | 配置存在 {count} 个问题"+ "configuration-has-issues": "配置存在 {count} 个问题 | 配置存在 {count} 个问题",+ "missing-backup-schema-postgres": "在数据库 '{database}' 中创建 schema 'bbdataarchive',然后同步数据库",+ "missing-backup-database": "在实例 '{instance}' 上创建数据库 'bbdataarchive',然后同步实例和数据库",+ "missing-backup-database-oracle": "在实例 '{instance}' 上创建数据库 'BBDATAARCHIVE',然后同步实例和数据库"},"ghost": {"only-some-databases-checked": "仅检查部分数据库",