Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: return ALTER_TABLE instead of sub-operation types for PostgreSQL ALTER TABLE statements (#17993)

h3n4l98d51ccf9f4b
diff --git a/backend/plugin/parser/pg/statement_type_antlr.go b/backend/plugin/parser/pg/statement_type_antlr.go
index ccdb4b74d3..5bf1ed3885 100644
--- a/backend/plugin/parser/pg/statement_type_antlr.go
+++ b/backend/plugin/parser/pg/statement_type_antlr.go
@@ -132,16 +132,10 @@ func (c *statementTypeCollectorWithPosition) EnterAltertablestmt(ctx *parser.Alt
return
}
- // Parse ALTER TABLE sub-operations if alter_table_cmds exists
- if cmds := ctx.Alter_table_cmds(); cmds != nil {
- for _, cmd := range cmds.AllAlter_table_cmd() {
- stmtType := getAlterTableCmdType(cmd)
- c.addStatement(stmtType, ctx)
- }
- } else {
- // Fallback to generic ALTER_TABLE if no cmds
- c.addStatement("ALTER_TABLE", ctx)
- }
+ // Always return ALTER_TABLE for ALTER TABLE statements
+ // The sub-operations (ADD COLUMN, DROP COLUMN, etc.) are child nodes in the AST,
+ // not separate statements
+ c.addStatement("ALTER_TABLE", ctx)
}
func (c *statementTypeCollectorWithPosition) EnterAlterseqstmt(ctx *parser.AlterseqstmtContext) {
@@ -287,58 +281,6 @@ func getDropStatementType(ctx *parser.DropstmtContext) string {
return "UNKNOWN"
}
-// getAlterTableCmdType determines the specific ALTER TABLE sub-operation type.
-func getAlterTableCmdType(cmd parser.IAlter_table_cmdContext) string {
- if cmd == nil {
- return "ALTER_TABLE"
- }
-
- // ADD COLUMN
- if cmd.ADD_P() != nil && cmd.ColumnDef() != nil {
- return "ALTER_TABLE_ADD_COLUMN_LIST"
- }
-
- // ADD CONSTRAINT
- if cmd.ADD_P() != nil && cmd.Tableconstraint() != nil {
- return "ALTER_TABLE_ADD_CONSTRAINT"
- }
-
- // ALTER COLUMN operations (check these BEFORE DROP to avoid conflicts)
- if cmd.ALTER() != nil && len(cmd.AllColid()) > 0 {
- // ALTER COLUMN ... TYPE
- if cmd.TYPE_P() != nil {
- return "ALTER_COLUMN_TYPE"
- }
-
- // ALTER COLUMN ... DROP NOT NULL
- if cmd.DROP() != nil && cmd.NOT() != nil && cmd.NULL_P() != nil {
- return "DROP_NOT_NULL"
- }
-
- // ALTER COLUMN ... DROP DEFAULT
- if cmd.Alter_column_default() != nil {
- alterDefault := cmd.Alter_column_default()
- // Check if it's DROP DEFAULT (not SET DEFAULT)
- if alterDefault.DROP() != nil {
- return "DROP_DEFAULT"
- }
- }
- }
-
- // DROP COLUMN (must be after ALTER COLUMN checks)
- if cmd.DROP() != nil && len(cmd.AllColid()) > 0 && cmd.CONSTRAINT() == nil {
- return "DROP_COLUMN"
- }
-
- // DROP CONSTRAINT
- if cmd.DROP() != nil && cmd.CONSTRAINT() != nil {
- return "DROP_CONSTRAINT"
- }
-
- // Default to ALTER_TABLE for other operations
- return "ALTER_TABLE"
-}
-
// getRenameStatementType determines the specific RENAME statement type.
func getRenameStatementType(ctx *parser.RenamestmtContext) string {
if ctx == nil {
diff --git a/backend/plugin/parser/pg/statement_type_antlr_test.go b/backend/plugin/parser/pg/statement_type_antlr_test.go
index 73dbd05d18..3aa91b1709 100644
--- a/backend/plugin/parser/pg/statement_type_antlr_test.go
+++ b/backend/plugin/parser/pg/statement_type_antlr_test.go
@@ -100,37 +100,37 @@ func TestGetStatementTypesANTLR(t *testing.T) {
{
name: "ALTER TABLE ADD COLUMN",
sql: "ALTER TABLE t1 ADD COLUMN name VARCHAR(100);",
- expectedTypes: []string{"ALTER_TABLE_ADD_COLUMN_LIST"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER TABLE ADD CONSTRAINT",
sql: "ALTER TABLE t1 ADD CONSTRAINT pk_id PRIMARY KEY (id);",
- expectedTypes: []string{"ALTER_TABLE_ADD_CONSTRAINT"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER TABLE DROP COLUMN",
sql: "ALTER TABLE t1 DROP COLUMN name;",
- expectedTypes: []string{"DROP_COLUMN"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER TABLE DROP CONSTRAINT",
sql: "ALTER TABLE t1 DROP CONSTRAINT pk_id;",
- expectedTypes: []string{"DROP_CONSTRAINT"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER TABLE ALTER COLUMN TYPE",
sql: "ALTER TABLE t1 ALTER COLUMN name TYPE TEXT;",
- expectedTypes: []string{"ALTER_COLUMN_TYPE"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER TABLE ALTER COLUMN DROP DEFAULT",
sql: "ALTER TABLE t1 ALTER COLUMN name DROP DEFAULT;",
- expectedTypes: []string{"DROP_DEFAULT"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER TABLE ALTER COLUMN DROP NOT NULL",
sql: "ALTER TABLE t1 ALTER COLUMN name DROP NOT NULL;",
- expectedTypes: []string{"DROP_NOT_NULL"},
+ expectedTypes: []string{"ALTER_TABLE"},
},
{
name: "ALTER VIEW",