Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(mysql): prune MariaDB foreign-key and trigger sync queries to one database (#20661)
Vincent Huang9d75ca5486a7
diff --git a/backend/plugin/db/mysql/sync.go b/backend/plugin/db/mysql/sync.goindex 0cc0fc440a..24bf5b3deb 100644--- a/backend/plugin/db/mysql/sync.go+++ b/backend/plugin/db/mysql/sync.go@@ -718,6 +718,9 @@ func (d *Driver) getCreateEventStmt(ctx context.Context, databaseName string, na}func (d *Driver) getTriggerList(ctx context.Context, databaseName string) (map[db.TableKey][]*storepb.TriggerMetadata, error) {+ // Prune to a single database on MariaDB: filter by EVENT_OBJECT_SCHEMA (the+ // trigger's table schema), not TRIGGER_SCHEMA, which scans every database's+ // table metadata. A trigger lives in its table's schema, so they are equivalent.triggersQuery := `SELECTTRIGGER_NAME,@@ -729,7 +732,7 @@ func (d *Driver) getTriggerList(ctx context.Context, databaseName string) (map[dCHARACTER_SET_CLIENT,COLLATION_CONNECTIONFROM INFORMATION_SCHEMA.TRIGGERS- WHERE TRIGGER_SCHEMA = ?+ WHERE EVENT_OBJECT_SCHEMA = ?ORDER BY EVENT_OBJECT_TABLE ASC, EVENT_MANIPULATION ASC, ACTION_TIMING ASC, ACTION_ORDER ASC;`triggerRows, err := d.db.QueryContext(ctx, triggersQuery, databaseName)@@ -1316,6 +1319,11 @@ func convertToStorepbTablePartitionType(tp string) storepb.TablePartitionMetadat}func (d *Driver) getForeignKeyList(ctx context.Context, databaseName string) (map[db.TableKey][]*storepb.ForeignKeyMetadata, error) {+ // Prune to a single database on MariaDB instead of opening every database's+ // table metadata (Error 1969 on large instances). REFERENTIAL_CONSTRAINTS prunes+ // on CONSTRAINT_SCHEMA; KEY_COLUMN_USAGE prunes only on TABLE_SCHEMA. A foreign+ // key lives in its table's schema, so the predicates are equivalent. Never wrap+ // the column in LOWER() -- it defeats the pruning.fkQuery := `SELECTTABLE_NAME,@@ -1325,7 +1333,7 @@ func (d *Driver) getForeignKeyList(ctx context.Context, databaseName string) (maUPDATE_RULE,MATCH_OPTIONFROM INFORMATION_SCHEMA.REFERENTIAL_CONSTRAINTS- WHERE LOWER(CONSTRAINT_SCHEMA) = ?;+ WHERE CONSTRAINT_SCHEMA = ?;`kcuQuery := `@@ -1335,7 +1343,7 @@ func (d *Driver) getForeignKeyList(ctx context.Context, databaseName string) (maCOLUMN_NAME,REFERENCED_COLUMN_NAMEFROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE- WHERE POSITION_IN_UNIQUE_CONSTRAINT IS NOT NULL AND LOWER(CONSTRAINT_SCHEMA) = ?+ WHERE POSITION_IN_UNIQUE_CONSTRAINT IS NOT NULL AND TABLE_SCHEMA = ?ORDER BY TABLE_NAME, CONSTRAINT_NAME, ORDINAL_POSITION;`