Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: update

ecmadaoa28d4aa6cc48
diff --git a/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.test.tsx b/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.test.tsx
index 75941540fe..02c12d4eab 100644
--- a/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.test.tsx
+++ b/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.test.tsx
@@ -45,7 +45,7 @@ const mocks = vi.hoisted(() => ({
guideUserCount: 1,
introState: {} as Record<string, boolean>,
isSaaS: false,
- loading: false,
+ contextReady: true,
preCreateIssue: vi.fn(),
productModelContent: "guide content" as string | undefined,
routerPush: vi.fn(),
@@ -148,7 +148,7 @@ vi.mock("./selection", () => ({
vi.mock("./useGuideContext", () => ({
useGuideContext: () => ({
context: mocks.guideContext,
- loading: mocks.loading,
+ contextReady: mocks.contextReady,
}),
}));
@@ -161,7 +161,7 @@ beforeEach(() => {
mocks.guideUserCount = 1;
mocks.introState = {};
mocks.isSaaS = false;
- mocks.loading = false;
+ mocks.contextReady = true;
mocks.productModelContent = "guide content";
mocks.scenarioId = undefined;
mocks.workspaceUsage = undefined;
@@ -867,4 +867,16 @@ describe("WorkspaceSetupGuide", () => {
expect(mocks.captureMetric).not.toHaveBeenCalled();
});
+
+ test("records initial progress when its marker cannot be saved", () => {
+ mocks.saveIntroStateByKey.mockImplementation(() => {
+ throw new Error("localStorage unavailable");
+ });
+
+ expect(() => render(<WorkspaceSetupGuide />)).not.toThrow();
+ expect(mocks.captureMetric).toHaveBeenCalledWith({
+ event: "workspace setup guide progress observed",
+ properties: expect.objectContaining({ observation: "initial" }),
+ });
+ });
});
diff --git a/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.tsx b/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.tsx
index 3b3eaa3e5b..c7c06b60f3 100644
--- a/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.tsx
+++ b/frontend/src/modules/workspace-setup-guide/WorkspaceSetupGuide.tsx
@@ -64,7 +64,7 @@ export function WorkspaceSetupGuide() {
const productModelAvailable = !!getHowBytebaseWorksGuideContent(
i18n.resolvedLanguage ?? "en-US"
);
- const { context, loading } = useGuideContext({
+ const { context, contextReady } = useGuideContext({
enabled: guideEnabled,
dismissed,
route: currentRoute,
@@ -187,7 +187,7 @@ export function WorkspaceSetupGuide() {
const guideVisible =
!dismissed &&
guideEnabled &&
- !loading &&
+ contextReady &&
!(guide.complete && completionAcknowledged);
useEffect(() => {
@@ -200,10 +200,14 @@ export function WorkspaceSetupGuide() {
}
observedProgressKeyRef.current = progressObservedKey;
- useAppStore.getState().saveIntroStateByKey({
- key: progressObservedKey,
- newState: true,
- });
+ try {
+ useAppStore.getState().saveIntroStateByKey({
+ key: progressObservedKey,
+ newState: true,
+ });
+ } catch {
+ // Analytics markers must not interrupt guide rendering when storage fails.
+ }
captureGuideMetric("workspace setup guide progress observed", {
observation: "initial",
});
diff --git a/frontend/src/modules/workspace-setup-guide/useGuideContext.test.tsx b/frontend/src/modules/workspace-setup-guide/useGuideContext.test.tsx
index f135c147cb..deeef9d734 100644
--- a/frontend/src/modules/workspace-setup-guide/useGuideContext.test.tsx
+++ b/frontend/src/modules/workspace-setup-guide/useGuideContext.test.tsx
@@ -149,7 +149,7 @@ describe("useGuideContext", () => {
});
const { result } = renderGuideContext();
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
expect(result.current.context).toMatchObject({
hasProject: true,
@@ -163,6 +163,31 @@ describe("useGuideContext", () => {
expect(mocks.captureMetric).not.toHaveBeenCalled();
});
+ test("loads fresh guide facts after a dismissed guide is reopened", async () => {
+ const { result, rerender } = renderGuideContext();
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
+
+ rerender({ enabled: true, dismissed: true, route: home });
+ expect(result.current.contextReady).toBe(false);
+
+ let resolveProjectList: (
+ value: { projects: []; nextPageToken: string }
+ ) => void;
+ mocks.fetchProjectList.mockReturnValueOnce(
+ new Promise((resolve) => {
+ resolveProjectList = resolve;
+ })
+ );
+ rerender({ enabled: true, dismissed: false, route: home });
+
+ expect(result.current.contextReady).toBe(false);
+
+ await act(async () => {
+ resolveProjectList!({ projects: [], nextPageToken: "" });
+ });
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
+ });
+
test.each([
@@ -209,7 +234,7 @@ describe("useGuideContext", () => {
workspaceUsage: "team",
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
expect(mocks.listUsers).toHaveBeenCalledWith({
pageSize: 100,
@@ -235,7 +260,7 @@ describe("useGuideContext", () => {
workspaceUsage: input.workspaceUsage,
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
expect(mocks.listUsers).not.toHaveBeenCalled();
});
@@ -255,7 +280,7 @@ describe("useGuideContext", () => {
workspaceUsage: "team",
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
expect(result.current.context.hasOtherWorkspaceMember).toBe(true);
expect(mocks.saveIntroStateByKey).toHaveBeenCalledWith({
key: GUIDE_PROGRESS_KEYS.teammateAdded,
@@ -343,7 +368,7 @@ describe("useGuideContext", () => {
},
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
expect(result.current.context.hasExploredDatabase).toBe(false);
expect(mocks.saveIntroStateByKey).not.toHaveBeenCalledWith({
key: GUIDE_PROGRESS_KEYS.databaseExplored,
@@ -358,7 +383,7 @@ describe("useGuideContext", () => {
route: home,
scenarioId: "query-data",
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
await act(async () => {
await sqlEditorEvents.emit("query-executed", {
@@ -386,7 +411,7 @@ describe("useGuideContext", () => {
route: home,
scenarioId: "create-database-change",
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
await act(async () => {
await planEvents.emit("database-change-issue-created", {
@@ -436,13 +461,13 @@ describe("useGuideContext", () => {
workspaceUsage: "team",
});
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
expect(result.current.context.hasOtherHumanUser).toBe(false);
});
test("ignores statement events without a database", async () => {
const { result } = renderGuideContext();
- await waitFor(() => expect(result.current.loading).toBe(false));
+ await waitFor(() => expect(result.current.contextReady).toBe(true));
await act(async () => {
await sqlEditorEvents.emit("query-executed", {
diff --git a/frontend/src/modules/workspace-setup-guide/useGuideContext.ts b/frontend/src/modules/workspace-setup-guide/useGuideContext.ts
index 0bcd9f3ac9..254527bb1d 100644
--- a/frontend/src/modules/workspace-setup-guide/useGuideContext.ts
+++ b/frontend/src/modules/workspace-setup-guide/useGuideContext.ts
@@ -113,7 +113,7 @@ export const useGuideContext = ({
route: GuideRoute;
scenarioId?: GuideScenarioId;
workspaceUsage?: GuideWorkspaceUsage;
-}): { context: GuideContext; loading: boolean } => {
+}): { context: GuideContext; contextReady: boolean } => {
const databaseExplored = useIntroStateByKey(
GUIDE_PROGRESS_KEYS.databaseExplored
);
@@ -146,7 +146,7 @@ export const useGuideContext = ({
currentUserName
);
const [facts, setFacts] = useState<GuideFacts>(INITIAL_FACTS);
- const [loading, setLoading] = useState(true);
+ const [contextReady, setContextReady] = useState(false);
const eventTargetRef = useRef<
{ projectName: string; databaseName: string } | undefined
>(undefined);
@@ -230,7 +230,7 @@ export const useGuideContext = ({
useEffect(() => {
if (dismissed || !enabled) {
setFacts(INITIAL_FACTS);
- setLoading(false);
+ setContextReady(false);
return;
}
@@ -310,7 +310,7 @@ export const useGuideContext = ({
changeIssueCreated || state.hasCreatedChangeIssue,
}));
}
- setLoading(false);
+ setContextReady(true);
})();
}, [
changeIssueCreated,
@@ -333,5 +333,5 @@ export const useGuideContext = ({
() => ({ ...facts, isSaaS, hasOtherWorkspaceMember, route }),
[facts, hasOtherWorkspaceMember, isSaaS, route]
);
- return { context, loading };
+ return { context, contextReady };
};
diff --git a/frontend/src/routes/auth/WorkspaceSetupPage.test.tsx b/frontend/src/routes/auth/WorkspaceSetupPage.test.tsx
index dd0d451b6b..e1e6173342 100644
--- a/frontend/src/routes/auth/WorkspaceSetupPage.test.tsx
+++ b/frontend/src/routes/auth/WorkspaceSetupPage.test.tsx
@@ -310,6 +310,21 @@ describe("WorkspaceSetupPage", () => {
second.unmount();
});
+ test("records setup page entry when its marker cannot be saved", () => {
+ mocks.saveIntroStateByKey.mockImplementation(() => {
+ throw new Error("localStorage unavailable");
+ });
+ const page = renderIntoContainer(<WorkspaceSetupPage />);
+
+ expect(() => page.render()).not.toThrow();
+ expect(mocks.captureMetric).toHaveBeenCalledWith({
+ event: "workspace setup page entered",
+ properties: { setup_version: "v1" },
+ });
+
+ page.unmount();
+ });
+
test("uses the shared step indicator for both setup steps", async () => {
const page = renderIntoContainer(<WorkspaceSetupPage />);
page.render();
diff --git a/frontend/src/routes/auth/WorkspaceSetupPage.tsx b/frontend/src/routes/auth/WorkspaceSetupPage.tsx
index 59013064fd..a27a5d2e7a 100644
--- a/frontend/src/routes/auth/WorkspaceSetupPage.tsx
+++ b/frontend/src/routes/auth/WorkspaceSetupPage.tsx
@@ -131,10 +131,14 @@ export function WorkspaceSetupPage() {
return;
}
setupPageEnteredRef.current = true;
- useAppStore.getState().saveIntroStateByKey({
- key: WORKSPACE_SETUP_PAGE_ENTERED_KEY,
- newState: true,
- });
+ try {
+ useAppStore.getState().saveIntroStateByKey({
+ key: WORKSPACE_SETUP_PAGE_ENTERED_KEY,
+ newState: true,
+ });
+ } catch {
+ // Analytics markers must not interrupt workspace setup when storage fails.
+ }
behaviorAnalytics.captureMetric(
createBehaviorMetric("workspace setup page entered", {
properties: { setup_version: WORKSPACE_SETUP_VERSION },