Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat(frontend): show prominent approval status in issue detail sidebar (#19438)
boojacka69987c5c767
diff --git a/frontend/src/components/IssueV1/components/IssueApprovalStatus.vue b/frontend/src/components/IssueV1/components/IssueApprovalStatus.vueindex 8440269bbb..ae5773050c 100644--- a/frontend/src/components/IssueV1/components/IssueApprovalStatus.vue+++ b/frontend/src/components/IssueV1/components/IssueApprovalStatus.vue@@ -95,7 +95,7 @@ const statusTag = computed((): StatusTag | undefined => {}if (status === Issue_ApprovalStatus.REJECTED) {return {- label: t("custom-approval.approval-flow.issue-review.sent-back"),+ label: t("common.rejected"),type: "warning",subtitle: progressText.value,};diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/RolloutReadyLink.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/RolloutReadyLink.vueindex ec93163aba..f071200857 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/RolloutReadyLink.vue+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/RolloutReadyLink.vue@@ -1,8 +1,8 @@<template><RouterLink :to="rolloutRoute">- <NButton icon-placement="right" quaternary>- <TaskStatus :status="rolloutStatus" size="tiny" />- <span class="mx-1">{{ $t("common.rollout") }}</span>+ <NButton icon-placement="right" secondary strong>+ <TaskStatus :status="rolloutStatus" size="small" />+ <span class="ml-2 mr-1">{{ $t("common.rollout") }}</span><span>#{{ planID }}</span><template #icon><ArrowUpRightIcon class="opacity-60" />diff --git a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalFlowSection.vue b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalFlowSection.vueindex 987f2d4c67..51ee42dcba 100644--- a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalFlowSection.vue+++ b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalFlowSection.vue@@ -1,12 +1,16 @@<template><div>- <div class="w-full flex flex-row items-center gap-2">+ <div class="w-full flex flex-row items-center gap-2 flex-wrap"><h3 class="textlabel">{{ $t("issue.approval-flow.self") }}</h3><FeatureBadge :feature="PlanFeature.FEATURE_APPROVAL_WORKFLOW" /><RiskLevelIcon:risk-level="issue.riskLevel":title="approvalTemplate?.title?.trim()"/>+ <div class="grow" />+ <NTag class="truncate" v-if="statusTag" size="small" round :type="statusTag.type">+ {{ statusTag.label }}+ </NTag></div><div class="mt-2">@@ -44,8 +48,10 @@</template><script setup lang="ts">-import { NTimeline } from "naive-ui";+import type { TagProps } from "naive-ui";+import { NTag, NTimeline } from "naive-ui";import { computed } from "vue";+import { useI18n } from "vue-i18n";import { BBSpin } from "@/bbkit";import FeatureBadge from "@/components/FeatureGuard/FeatureBadge.vue";import type { Issue } from "@/types/proto-es/v1/issue_service_pb";@@ -54,10 +60,17 @@ import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";import ApprovalStepItem from "./ApprovalStepItem.vue";import RiskLevelIcon from "./RiskLevelIcon.vue";+interface StatusTag {+ label: string;+ type?: TagProps["type"];+}+const props = defineProps<{issue: Issue;}>();+const { t } = useI18n();+const approvalTemplate = computed(() => {return props.issue.approvalTemplate;});@@ -65,4 +78,23 @@ const approvalTemplate = computed(() => {const approvalSteps = computed(() => {return approvalTemplate.value?.flow?.roles || [];});++const statusTag = computed((): StatusTag | undefined => {+ const status = props.issue.approvalStatus;+ if (approvalSteps.value.length === 0) return undefined;++ if (status === Issue_ApprovalStatus.APPROVED) {+ return {+ label: t("issue.table.approved"),+ type: "success",+ };+ }+ if (status === Issue_ApprovalStatus.REJECTED) {+ return {+ label: t("common.rejected"),+ type: "warning",+ };+ }+ return undefined;+});</script>diff --git a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalStepItem.vue b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalStepItem.vueindex 31ddaa8332..d374cb1bdd 100644--- a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalStepItem.vue+++ b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection/ApprovalStepItem.vue@@ -45,6 +45,9 @@<div v-if="canReRequest && !readonly" class="mt-1"><NButtonsize="tiny"+ strong+ secondary+ type="info":loading="reRequesting"@click="handleReRequestReview">diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex d737080d87..9910594e08 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -2629,9 +2629,6 @@"delete": "Delete approval node"},"skip": "No approval required",- "issue-review": {- "sent-back": "Sent back"- },"add-rule": "Add rule","edit-rule": "Edit rule","fallback-rules": "Fallback Rules",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 424c0f0698..801dceb8c3 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -2629,9 +2629,6 @@"delete": "Eliminar nodo de aprobación"},"skip": "No se requiere aprobación",- "issue-review": {- "sent-back": "Devuelto"- },"add-rule": "Agregar regla","edit-rule": "Editar regla","fallback-rules": "Reglas de respaldo",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex d4b208bc43..8084c31276 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -2629,9 +2629,6 @@"delete": "承認ノードの削除"},"skip": "承認不要",- "issue-review": {- "sent-back": "戻ってきた"- },"add-rule": "ルールを追加","edit-rule": "ルールを編集","fallback-rules": "フォールバックルール",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex de495468be..e9ffb62751 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -2629,9 +2629,6 @@"delete": "Xóa nút phê duyệt"},"skip": "Không cần phê duyệt",- "issue-review": {- "sent-back": "Đã gửi lại"- },"add-rule": "Thêm quy tắc","edit-rule": "Chỉnh sửa quy tắc","fallback-rules": "Quy tắc dự phòng",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex c90f247ad7..a7183dc8b9 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -2629,9 +2629,6 @@"delete": "删除审批节点"},"skip": "无需审批",- "issue-review": {- "sent-back": "被退回"- },"add-rule": "添加规则","edit-rule": "编辑规则","fallback-rules": "兜底规则",