Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: show detailed reasons in batch issue close/reopen tooltips (#19584)

boojacka96d0c4507bc
diff --git a/frontend/src/components/IssueV1/components/BatchIssueActionsV1.vue b/frontend/src/components/IssueV1/components/BatchIssueActionsV1.vue
index 554eed5a09..f18ba5d73a 100644
--- a/frontend/src/components/IssueV1/components/BatchIssueActionsV1.vue
+++ b/frontend/src/components/IssueV1/components/BatchIssueActionsV1.vue
@@ -15,6 +15,7 @@
})
}}
</div>
+ <ErrorList :errors="closeErrors" :bullets="'always'" />
</template>
</TooltipButton>
@@ -32,6 +33,7 @@
})
}}
</div>
+ <ErrorList :errors="reopenErrors" :bullets="'always'" />
</template>
</TooltipButton>
@@ -47,9 +49,12 @@
<script lang="ts" setup>
import type { PropType } from "vue";
import { computed, reactive, ref } from "vue";
+import { useI18n } from "vue-i18n";
+import ErrorList from "@/components/misc/ErrorList.vue";
import { TooltipButton } from "@/components/v2";
import { refreshIssueList } from "@/store";
import type { Issue } from "@/types/proto-es/v1/issue_service_pb";
+import { IssueStatus } from "@/types/proto-es/v1/issue_service_pb";
import { BatchIssueStatusActionPanel } from "./Panel";
import type { IssueStatusAction } from "./Panel/issueStatusAction";
import {
@@ -90,6 +95,40 @@ const isActionApplicableForAllIssues = (action: IssueStatusAction): boolean => {
});
};
+const { t } = useI18n();
+
+const issueStatuses = computed(() => {
+ const statuses = new Set<IssueStatus>();
+ for (const issue of props.issueList) {
+ statuses.add(issue.status);
+ }
+ return statuses;
+});
+
+const closeErrors = computed(() => {
+ const errors: string[] = [];
+ const statuses = issueStatuses.value;
+ if (statuses.has(IssueStatus.DONE)) {
+ errors.push(t("issue.batch-transition.done-cannot-close"));
+ }
+ if (statuses.has(IssueStatus.CANCELED)) {
+ errors.push(t("issue.batch-transition.canceled-cannot-close"));
+ }
+ return errors;
+});
+
+const reopenErrors = computed(() => {
+ const errors: string[] = [];
+ const statuses = issueStatuses.value;
+ if (statuses.has(IssueStatus.OPEN)) {
+ errors.push(t("issue.batch-transition.open-cannot-reopen"));
+ }
+ if (statuses.has(IssueStatus.DONE)) {
+ errors.push(t("issue.batch-transition.done-cannot-reopen"));
+ }
+ return errors;
+});
+
const handleUpdated = () => {
state.isRequesting = false;
ongoingIssueStatusAction.value = undefined;
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index c810dc0977..c12e68dde6 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -1089,6 +1089,10 @@
},
"batch-transition": {
"not-allowed-tips": "Some of selected issues cannot be {operation}",
+ "open-cannot-reopen": "Open issues cannot be reopened",
+ "done-cannot-reopen": "Done issues cannot be reopened",
+ "done-cannot-close": "Done issues cannot be closed",
+ "canceled-cannot-close": "Canceled issues cannot be closed",
"reopen": "Reopen",
"reopened": "reopened",
"action-n-issues": "{action} {n} issue | {action} {n} issues",
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index f03fec728e..020a2d0ec3 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -1089,6 +1089,10 @@
},
"batch-transition": {
"not-allowed-tips": "Algunos de las incidencias seleccionadas no se pueden {operation}",
+ "open-cannot-reopen": "Open issues cannot be reopened",
+ "done-cannot-reopen": "Done issues cannot be reopened",
+ "done-cannot-close": "Done issues cannot be closed",
+ "canceled-cannot-close": "Canceled issues cannot be closed",
"reopen": "Reabrir",
"reopened": "reabierto",
"action-n-issues": "{action} {n} incidencia | {action} {n} incidencias",
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index 03ea4a16aa..d114f2e989 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -1089,6 +1089,10 @@
},
"batch-transition": {
"not-allowed-tips": "選択したイシューの一部を {operation} にすることはできません",
+ "open-cannot-reopen": "Open issues cannot be reopened",
+ "done-cannot-reopen": "Done issues cannot be reopened",
+ "done-cannot-close": "Done issues cannot be closed",
+ "canceled-cannot-close": "Canceled issues cannot be closed",
"reopen": "再開",
"reopened": "再開",
"action-n-issues": "{action} {n} 個のイシュー",
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index 48dff051d8..a73b982ebd 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -1089,6 +1089,10 @@
},
"batch-transition": {
"not-allowed-tips": "Một số vấn đề đã chọn không thể {operation}",
+ "open-cannot-reopen": "Open issues cannot be reopened",
+ "done-cannot-reopen": "Done issues cannot be reopened",
+ "done-cannot-close": "Done issues cannot be closed",
+ "canceled-cannot-close": "Canceled issues cannot be closed",
"reopen": "Mở lại",
"reopened": "đã mở lại",
"action-n-issues": "{action} {n} vấn đề | {action} {n} vấn đề",
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index e5532d6608..5653fb13a2 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -1089,6 +1089,10 @@
},
"batch-transition": {
"not-allowed-tips": "部分选中的工单无法被{operation}",
+ "open-cannot-reopen": "打开中的工单无法重开",
+ "done-cannot-reopen": "已完成的工单无法重开",
+ "done-cannot-close": "已完成的工单无法关闭",
+ "canceled-cannot-close": "已取消的工单无法关闭",
"reopen": "重开",
"reopened": "重开",
"action-n-issues": "{action} {n} 个工单",