Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
test(tests): backend/tests tests workflows, not engines (#21356)
Danny Xuaa0a08db0966
diff --git a/backend/component/export/export_test.go b/backend/component/export/export_test.goindex ff1703c315..fe59c002d7 100644--- a/backend/component/export/export_test.go+++ b/backend/component/export/export_test.go@@ -320,6 +320,47 @@ func TestExportJSON(t *testing.T) {}}+func TestExportCSV(t *testing.T) {+ tests := []struct {+ result *v1pb.QueryResult+ want string+ }{+ {+ // Byte values render as quoted hex. This was only ever asserted through a+ // MySQL BIT column in backend/tests; it belongs here, where the rendering+ // lives, and covers every engine that returns bytes.+ result: &v1pb.QueryResult{+ ColumnNames: []string{"gender", "height"},+ Rows: []*v1pb.QueryRow{+ {+ Values: []*v1pb.RowValue{+ {Kind: &v1pb.RowValue_BytesValue{BytesValue: []byte{0x00}}},+ {Kind: &v1pb.RowValue_BytesValue{BytesValue: []byte{0x7f}}},+ },+ },+ },+ },+ want: "gender,height\n\"0x00\",\"0x7f\"",+ },+ {+ result: &v1pb.QueryResult{+ ColumnNames: []string{"a"},+ Rows: []*v1pb.QueryRow{+ {Values: []*v1pb.RowValue{{Kind: &v1pb.RowValue_Int64Value{Int64Value: 1}}}},+ },+ },+ want: "a\n1",+ },+ }+ a := assert.New(t)++ for _, test := range tests {+ got, err := CSV(test.result)+ a.NoError(err)+ a.Equal(test.want, string(got))+ }+}+func TestGetResourcesTiDB(t *testing.T) {a := assert.New(t)ctx := context.Background()diff --git a/backend/plugin/advisor/mysql/mysql_rules_test.go b/backend/plugin/advisor/mysql/mysql_rules_test.goindex 38e06e6d43..0360419ed0 100644--- a/backend/plugin/advisor/mysql/mysql_rules_test.go+++ b/backend/plugin/advisor/mysql/mysql_rules_test.go@@ -4,6 +4,7 @@ import ("context""database/sql""database/sql/driver"+ "errors""io""strings""testing"@@ -23,6 +24,15 @@ var testMySQLAdvisorExplainRows [][]driver.Value// empty, the JSON query returns no rows and the advisor falls back to the tabular rows.var testMySQLAdvisorExplainJSON string+// testMySQLAdvisorExplainErr, when set, fails every query, standing in for a+// statement the server refuses to EXPLAIN.+var testMySQLAdvisorExplainErr error++// testMySQLAdvisorQueries records every statement the fake driver is asked to+// run, so a rule that sent raw DML instead of EXPLAIN is caught rather than+// silently succeeding.+var testMySQLAdvisorQueries []string+func init() {sql.Register("test_mysql_advisor_explain", testMySQLAdvisorExplainDriver{})}@@ -48,6 +58,10 @@ func (testMySQLAdvisorExplainConn) Begin() (driver.Tx, error) {}func (testMySQLAdvisorExplainConn) QueryContext(_ context.Context, query string, _ []driver.NamedValue) (driver.Rows, error) {+ testMySQLAdvisorQueries = append(testMySQLAdvisorQueries, query)+ if testMySQLAdvisorExplainErr != nil {+ return nil, testMySQLAdvisorExplainErr+ }if strings.HasPrefix(query, "EXPLAIN FORMAT=JSON") {var rows [][]driver.Valueif testMySQLAdvisorExplainJSON != "" {@@ -311,3 +325,56 @@ func TestMySQLBuiltinWalkThroughCheckTableExists(t *testing.T) {require.Equal(t, code.TableExists.Int32(), adviceList[0].Code)require.Equal(t, "Table `user` already exists", adviceList[0].Content)}++// TestMySQLDMLDryRunAdvisor covers STATEMENT_DML_DRY_RUN, which the yaml harness+// cannot: RunSQLReviewRuleTest builds its context with Driver: nil and this rule+// does nothing without one, which is why test/statement_dml_dry_run.yaml carries+// statements and no `want:` at all.+func TestMySQLDMLDryRunAdvisor(t *testing.T) {+ const stmt = "UPDATE tech_book SET name = 'xz' WHERE id = 1;"+ rules := []*storepb.SQLReviewRule{{+ Type: storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN,+ Level: storepb.SQLReviewRule_WARNING,+ Engine: storepb.Engine_MYSQL,+ }}+ sm := sheet.NewManager()++ db, err := sql.Open("test_mysql_advisor_explain", "")+ require.NoError(t, err)+ defer db.Close()++ // Sequential: the second case arms a package-level failure hook.+ t.Run("a statement whose EXPLAIN succeeds raises nothing, and the DML never runs", func(t *testing.T) {+ testMySQLAdvisorQueries = nil+ adviceList, err := advisor.SQLReviewCheck(context.Background(), sm, stmt, rules, advisor.Context{+ DBType: storepb.Engine_MYSQL,+ Driver: db,+ NoAppendBuiltin: true,+ })+ require.NoError(t, err)+ require.Empty(t, adviceList)++ // The driver is the only way out of the rule, so assert nothing left it but+ // an EXPLAIN: a dry run that sent the raw UPDATE would pass otherwise.+ require.NotEmpty(t, testMySQLAdvisorQueries, "the rule must actually reach the driver")+ for _, q := range testMySQLAdvisorQueries {+ require.True(t, strings.HasPrefix(q, "EXPLAIN "),+ "the dry run must only ever EXPLAIN, got %q", q)+ }+ })++ t.Run("a statement whose EXPLAIN fails is reported", func(t *testing.T) {+ testMySQLAdvisorExplainErr = errors.New("Table 'test.tech_book' doesn't exist")+ defer func() { testMySQLAdvisorExplainErr = nil }()++ adviceList, err := advisor.SQLReviewCheck(context.Background(), sm, stmt, rules, advisor.Context{+ DBType: storepb.Engine_MYSQL,+ Driver: db,+ NoAppendBuiltin: true,+ })+ require.NoError(t, err)+ require.Len(t, adviceList, 1)+ require.Equal(t, code.StatementDMLDryRunFailed.Int32(), adviceList[0].Code)+ require.Contains(t, adviceList[0].Content, "dry runs failed")+ })+}diff --git a/backend/tests/action_test.go b/backend/tests/action_test.goindex 726742df9a..f09e341497 100644--- a/backend/tests/action_test.go+++ b/backend/tests/action_test.go@@ -384,7 +384,10 @@ func TestActionCheckCommand(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- // Create MySQL test database+ // Keeps MySQL. Porting this to Postgres was tried and reverted: the+ // declarative release check returns three errors against the same schema+ // on Postgres, so the engine changes the result here rather than being+ // incidental, and what those errors are is its own question._, mysqlContainer := ctl.createTestMySQLDatabase(ctx, t)defer mysqlContainer.Close(ctx)diff --git a/backend/tests/ghost_test.go b/backend/tests/ghost_test.goindex 802ad648dd..46a41a47aa 100644--- a/backend/tests/ghost_test.go+++ b/backend/tests/ghost_test.go@@ -37,6 +37,10 @@ var (wantDBSchema2 string)+// TestGhostSchemaUpdate keeps MySQL deliberately. gh-ost is a MySQL-only+// online schema change tool, so the engine is the workflow here rather than a+// substitutable backing store, and no Postgres equivalent can prove it.+// Everything else in this package tests workflows against Postgres.func TestGhostSchemaUpdate(t *testing.T) {const databaseName = "testGhostSchemaUpdate"diff --git a/backend/tests/gitops_test.go b/backend/tests/gitops_test.goindex 97d562b1dd..7d2c282056 100644--- a/backend/tests/gitops_test.go+++ b/backend/tests/gitops_test.go@@ -777,6 +777,10 @@ func TestGitOpsRollout(t *testing.T) {a.Equal(rollout.Name, rolloutResp2.Msg.Name)}+// TestGitOpsRolloutGhostDirective keeps MySQL deliberately. gh-ost is a MySQL-only+// online schema change tool, so the engine is the workflow here rather than a+// substitutable backing store, and no Postgres equivalent can prove it.+// Everything else in this package tests workflows against Postgres.func TestGitOpsRolloutGhostDirective(t *testing.T) {t.Parallel()a := require.New(t)diff --git a/backend/tests/schema_update_test.go b/backend/tests/schema_update_test.goindex 22c3302bb6..769f764b59 100644--- a/backend/tests/schema_update_test.go+++ b/backend/tests/schema_update_test.go@@ -12,7 +12,6 @@ import ("github.com/stretchr/testify/require""google.golang.org/protobuf/testing/protocmp"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")@@ -118,72 +117,14 @@ func TestGetLatestSchema(t *testing.T) {t.Parallel()tests := []struct {name string- dbType storepb.EngineinstanceID stringdatabaseName stringddl stringwantRawSchema stringwantDatabaseMetadata *v1pb.DatabaseMetadata}{- {- name: "MySQL",- dbType: storepb.Engine_MYSQL,- instanceID: "latest-schema-mysql",- databaseName: "latestSchema",- ddl: `CREATE TABLE book(id INT, name TEXT);`,- wantRawSchema: "SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0;\n" +- "SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0;\n" +- "--\n" +- "-- Table structure for `book`\n" +- "--\n" +- "CREATE TABLE `book` (\n" +- " `id` int DEFAULT NULL,\n" +- " `name` text DEFAULT NULL\n" +- ") ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;\n\n" +- "SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS;\n" +- "SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS;\n",- wantDatabaseMetadata: &v1pb.DatabaseMetadata{- Name: "instances/latest-schema-mysql/databases/latestSchema/metadata",- CharacterSet: "utf8mb4",- Collation: "utf8mb4_general_ci",- Schemas: []*v1pb.SchemaMetadata{- {- Tables: []*v1pb.TableMetadata{- {- Name: "book",- Engine: "InnoDB",- Collation: "utf8mb4_general_ci",- Charset: "utf8mb4",- DataSize: 16384,- Columns: []*v1pb.ColumnMetadata{- {- Name: "id",- Position: 1,- Nullable: true,- HasDefault: true,- Default: "NULL",- Type: "int",- },- {- Name: "name",- Position: 2,- Nullable: true,- Type: "text",- HasDefault: true,- Default: "NULL",- CharacterSet: "utf8mb4",- Collation: "utf8mb4_general_ci",- },- },- },- },- },- },- },- },{name: "PostgreSQL",- dbType: storepb.Engine_POSTGRES,instanceID: "latest-schema-postgres",databaseName: "latestSchema",ddl: `CREATE TABLE book(id INT, name TEXT);`,@@ -248,48 +189,23 @@ CREATE TABLE "public"."book" (for _, test := range tests {t.Run(test.name, func(t *testing.T) {a := require.New(t)- var instance *v1pb.Instance- switch test.dbType {- case storepb.Engine_POSTGRES:- pgContainer, err := getPgContainer(ctx)- defer func() {- pgContainer.Close(ctx)- }()- a.NoError(err)- instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: test.instanceID,- Instance: &v1pb.Instance{- Title: test.name,- Engine: v1pb.Engine_POSTGRES,- Environment: new(environment.Name),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: pgContainer.host, Port: pgContainer.port, Username: "postgres", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- instance = instanceResp.Msg- case storepb.Engine_MYSQL:- mysqlContainer, err := getMySQLContainer(ctx)- defer func() {- mysqlContainer.Close(ctx)- }()- a.NoError(err)-- instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: test.instanceID,- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new(environment.Name),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- instance = instanceResp.Msg- default:- a.FailNow("unsupported db type")- }+ pgContainer, err := getPgContainer(ctx)+ defer func() {+ pgContainer.Close(ctx)+ }()+ a.NoError(err)+ instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{+ InstanceId: test.instanceID,+ Instance: &v1pb.Instance{+ Title: test.name,+ Engine: v1pb.Engine_POSTGRES,+ Environment: new(environment.Name),+ Activation: true,+ DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: pgContainer.host, Port: pgContainer.port, Username: "postgres", Password: "root-password", Id: "admin"}},+ },+ }))+ a.NoError(err)+ instance := instanceResp.Msgerr = ctl.createDatabase(ctx, ctl.project, instance, nil, test.databaseName, "postgres")a.NoError(err)diff --git a/backend/tests/sensitive_data_test.go b/backend/tests/sensitive_data_test.goindex a0edc88a77..ce7212546a 100644--- a/backend/tests/sensitive_data_test.go+++ b/backend/tests/sensitive_data_test.go@@ -18,7 +18,7 @@ import (var (maskedData = &v1pb.QueryResult{ColumnNames: []string{"id", "name", "author"},- ColumnTypeNames: []string{"INT", "VARCHAR", "VARCHAR"},+ ColumnTypeNames: []string{"INT4", "VARCHAR", "VARCHAR"},Masked: []*v1pb.MaskingReason{{SemanticTypeId: "default", Algorithm: "Full mask"},nil,@@ -52,7 +52,7 @@ var (}originData = &v1pb.QueryResult{ColumnNames: []string{"id", "name", "author"},- ColumnTypeNames: []string{"INT", "VARCHAR", "VARCHAR"},+ ColumnTypeNames: []string{"INT4", "VARCHAR", "VARCHAR"},Rows: []*v1pb.QueryRow{{Values: []*v1pb.RowValue{@@ -131,38 +131,26 @@ func TestSensitiveData(t *testing.T) {}))a.NoError(err)- mysqlContainer, err := getMySQLContainer(ctx)+ pgContainer, err := getPgContainer(ctx)defer func() {- mysqlContainer.Close(ctx)+ pgContainer.Close(ctx)}()a.NoError(err)- mysqlDB := mysqlContainer.db- _, err = mysqlDB.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS %v", databaseName))- a.NoError(err)-- _, err = mysqlDB.Exec("DROP USER IF EXISTS bytebase")- a.NoError(err)- _, err = mysqlDB.Exec("CREATE USER 'bytebase' IDENTIFIED WITH mysql_native_password BY 'bytebase'")- a.NoError(err)-- _, err = mysqlDB.Exec("GRANT ALTER, ALTER ROUTINE, CREATE, CREATE ROUTINE, CREATE VIEW, DELETE, DROP, EVENT, EXECUTE, INDEX, INSERT, PROCESS, REFERENCES, SELECT, SHOW DATABASES, SHOW VIEW, TRIGGER, UPDATE, USAGE, REPLICATION CLIENT, REPLICATION SLAVE, LOCK TABLES, RELOAD ON *.* to bytebase")- a.NoError(err)-instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,+ Title: "pgInstance",+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "bytebase", Password: "bytebase", Id: "admin"}},+ DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: pgContainer.host, Port: pgContainer.port, Username: "postgres", Password: "root-password", Id: "admin"}},},}))a.NoError(err)instance := instanceResp.Msg- err = ctl.createDatabase(ctx, ctl.project, instance, nil /* environment */, databaseName, "")+ err = ctl.createDatabase(ctx, ctl.project, instance, nil /* environment */, databaseName, "postgres")a.NoError(err)databaseResp, err := ctl.databaseServiceClient.GetDatabase(ctx, connect.NewRequest(&v1pb.GetDatabaseRequest{@@ -179,13 +167,16 @@ func TestSensitiveData(t *testing.T) {a.NoError(err)a.Equal(1, len(syntaxErrorResp.Msg.Results))a.NotEmpty(syntaxErrorResp.Msg.Results[0].Error)- a.Contains(syntaxErrorResp.Msg.Results[0].Error, "Syntax error")+ a.Contains(strings.ToLower(syntaxErrorResp.Msg.Results[0].Error), "syntax error")// Check the detailed_error field for syntax_error with positionsyntaxErr := syntaxErrorResp.Msg.Results[0].GetSyntaxError()a.NotNil(syntaxErr)a.NotNil(syntaxErr.StartPosition)a.Equal(int32(1), syntaxErr.StartPosition.Line)- a.Equal(int32(14), syntaxErr.StartPosition.Column)+ // Column 13 is where the pg parser puts "TO" in "SELECT hello TO world;".+ // The MySQL parser reported 14 for the same statement; the column is a+ // per-parser convention, not behavior this test is about.+ a.Equal(int32(13), syntaxErr.StartPosition.Column)sheetResp, err := ctl.sheetServiceClient.CreateSheet(ctx, connect.NewRequest(&v1pb.CreateSheetRequest{Parent: ctl.project.Name,@@ -206,7 +197,8 @@ func TestSensitiveData(t *testing.T) {Name: fmt.Sprintf("%s/catalog", database.Name),Schemas: []*v1pb.SchemaCatalog{{- Name: "",+ // Postgres has schemas; the MySQL arm of this test left it empty.+ Name: "public",Tables: []*v1pb.TableCatalog{{Name: tableName,@@ -260,19 +252,19 @@ func TestSensitiveData(t *testing.T) {expectedMaskedData := &v1pb.QueryResult{ColumnNames: []string{"id", "name", "author"},- ColumnTypeNames: []string{"INT", "VARCHAR", "VARCHAR"},+ ColumnTypeNames: []string{"INT4", "VARCHAR", "VARCHAR"},Masked: []*v1pb.MaskingReason{{SemanticTypeId: "default",Algorithm: "Full mask",- Context: fmt.Sprintf("Column-level semantic type: %s.%s.%s.%s", instanceID, databaseName, tableName, "id"),+ Context: fmt.Sprintf("Column-level semantic type: %s.%s.public.%s.%s", instanceID, databaseName, tableName, "id"),SemanticTypeTitle: "Default",},nil,{SemanticTypeId: "default",Algorithm: "Full mask",- Context: fmt.Sprintf("Column-level semantic type: %s.%s.%s.%s", instanceID, databaseName, tableName, "author"),+ Context: fmt.Sprintf("Column-level semantic type: %s.%s.public.%s.%s", instanceID, databaseName, tableName, "author"),SemanticTypeTitle: "Default",},},@@ -293,12 +285,12 @@ func TestSensitiveData(t *testing.T) {diff = cmp.Diff(originData, result, protocmp.Transform(), protocmp.IgnoreMessages(&durationpb.Duration{}))a.Empty(diff)- // Query with a type-incompatible function on a masked column.+ // Query with a type-incompatible cast on a masked column.// The database error message would normally contain the actual column value,// but the masking pipeline should redact it.errorLeakResp, err := ctl.sqlServiceClient.Query(ctx, connect.NewRequest(&v1pb.QueryRequest{Name: database.Name,- Statement: "SELECT BIN_TO_UUID(author) FROM tech_book WHERE id = 1",+ Statement: "SELECT author::uuid FROM tech_book WHERE id = 1",}))a.NoError(err)a.Equal(1, len(errorLeakResp.Msg.Results))@@ -310,7 +302,7 @@ func TestSensitiveData(t *testing.T) {// Same query on a non-masked column should preserve the original error.nonMaskedErrorResp, err := ctl.sqlServiceClient.Query(ctx, connect.NewRequest(&v1pb.QueryRequest{Name: database.Name,- Statement: "SELECT BIN_TO_UUID(name) FROM tech_book WHERE id = 1",+ Statement: "SELECT name::uuid FROM tech_book WHERE id = 1",}))a.NoError(err)a.Equal(1, len(nonMaskedErrorResp.Msg.Results))diff --git a/backend/tests/sql_editor_test.go b/backend/tests/sql_editor_test.goindex 900192a423..e093c60cea 100644--- a/backend/tests/sql_editor_test.go+++ b/backend/tests/sql_editor_test.go@@ -11,24 +11,21 @@ import ("google.golang.org/protobuf/testing/protocmp""google.golang.org/protobuf/types/known/durationpb"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")func TestAdminQueryAffectedRows(t *testing.T) {tests := []struct {databaseName string- dbType storepb.EngineprepareStatements stringquery stringwant boolaffectedRows []*v1pb.QueryResult}{{- databaseName: "Test1",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE tbl(id INT PRIMARY KEY);",- query: "INSERT INTO tbl VALUES(1);",+ databaseName: "Test3",+ prepareStatements: "CREATE TABLE public.tbl(id INT PRIMARY KEY);",+ query: "INSERT INTO tbl VALUES(1),(2);",affectedRows: []*v1pb.QueryResult{{ColumnNames: []string{"Affected Rows"},@@ -36,19 +33,21 @@ func TestAdminQueryAffectedRows(t *testing.T) {Rows: []*v1pb.QueryRow{{Values: []*v1pb.RowValue{- {Kind: &v1pb.RowValue_Int64Value{Int64Value: 1}},+ {Kind: &v1pb.RowValue_Int64Value{Int64Value: 2}},},},},- Statement: "INSERT INTO tbl VALUES(1);",+ Statement: "INSERT INTO tbl VALUES(1),(2);",RowsCount: 1,},},},{+ // Ported from the MySQL arm when it was dropped: the only case proving a+ // successful multi-statement AdminExecute streams one affected-row result+ // per statement, each carrying its own statement text.databaseName: "Test2",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE tbl(id INT PRIMARY KEY);",+ prepareStatements: "CREATE TABLE public.tbl(id INT PRIMARY KEY);",query: "INSERT INTO tbl VALUES(1); DELETE FROM tbl WHERE id = 1;",affectedRows: []*v1pb.QueryResult{{@@ -79,30 +78,8 @@ func TestAdminQueryAffectedRows(t *testing.T) {},},},- {- databaseName: "Test3",- dbType: storepb.Engine_POSTGRES,- prepareStatements: "CREATE TABLE public.tbl(id INT PRIMARY KEY);",- query: "INSERT INTO tbl VALUES(1),(2);",- affectedRows: []*v1pb.QueryResult{- {- ColumnNames: []string{"Affected Rows"},- ColumnTypeNames: []string{"INT"},- Rows: []*v1pb.QueryRow{- {- Values: []*v1pb.RowValue{- {Kind: &v1pb.RowValue_Int64Value{Int64Value: 2}},- },- },- },- Statement: "INSERT INTO tbl VALUES(1),(2);",- RowsCount: 1,- },- },- },{databaseName: "Test4",- dbType: storepb.Engine_POSTGRES,prepareStatements: "CREATE TABLE tbl(id INT PRIMARY KEY);",query: "ALTER TABLE tbl ADD COLUMN name VARCHAR(255);",affectedRows: []*v1pb.QueryResult{@@ -131,31 +108,12 @@ func TestAdminQueryAffectedRows(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- mysqlContainer, err := getMySQLContainer(ctx)- defer func() {- mysqlContainer.Close(ctx)- }()- a.NoError(err)-pgContainer, err := getPgContainer(ctx)defer func() {pgContainer.Close(ctx)}()a.NoError(err)- mysqlInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- mysqlInstance := mysqlInstanceResp.Msg-pgInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{@@ -170,17 +128,8 @@ func TestAdminQueryAffectedRows(t *testing.T) {pgInstance := pgInstanceResp.Msgfor _, tt := range tests {- var instance *v1pb.Instance- databaseOwner := ""- switch tt.dbType {- case storepb.Engine_MYSQL:- instance = mysqlInstance- case storepb.Engine_POSTGRES:- instance = pgInstance- databaseOwner = "postgres"- default:- a.FailNow("unsupported db type")- }+ instance := pgInstance+ databaseOwner := "postgres"err = ctl.createDatabase(ctx, ctl.project, instance, nil /* environment */, tt.databaseName, databaseOwner)a.NoError(err)diff --git a/backend/tests/sql_export_data_source_test.go b/backend/tests/sql_export_data_source_test.goindex d0c8b4a1e0..699a63d18c 100644--- a/backend/tests/sql_export_data_source_test.go+++ b/backend/tests/sql_export_data_source_test.go@@ -3,6 +3,7 @@ package testsimport ("bytes""context"+ "database/sql""fmt""io""strings"@@ -29,35 +30,35 @@ func TestSQLExportDataSourceResolution(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- mysqlContainer, err := getMySQLContainer(ctx)+ pgContainer, err := getPgContainer(ctx)defer func() {- mysqlContainer.Close(ctx)+ pgContainer.Close(ctx)}()a.NoError(err)- mysqlDB := mysqlContainer.db- _, err = mysqlDB.Exec("DROP USER IF EXISTS 'export_ro'@'%'")+ // A login role for the read-only data source. Its grants have to wait until+ // the table exists, further down: Postgres grants are per object, where+ // MySQL's GRANT SELECT ON *.* covered tables created later.+ _, err = pgContainer.db.Exec("DROP ROLE IF EXISTS export_ro")a.NoError(err)- _, err = mysqlDB.Exec("CREATE USER 'export_ro'@'%' IDENTIFIED WITH mysql_native_password BY 'export_ro_password'")- a.NoError(err)- _, err = mysqlDB.Exec("GRANT SELECT ON *.* TO 'export_ro'@'%'")+ _, err = pgContainer.db.Exec("CREATE ROLE export_ro LOGIN PASSWORD 'export_ro_password'")a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,+ Title: "pgInstance",+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},+ DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: pgContainer.host, Port: pgContainer.port, Username: "postgres", Password: "root-password", Id: "admin"}},},}))a.NoError(err)instance := instanceResp.Msgconst databaseName = "ExportDataSourceResolution"- err = ctl.createDatabase(ctx, ctl.project, instance, nil, databaseName, "")+ err = ctl.createDatabase(ctx, ctl.project, instance, nil, databaseName, "postgres")a.NoError(err)databaseResp, err := ctl.databaseServiceClient.GetDatabase(ctx, connect.NewRequest(&v1pb.GetDatabaseRequest{@@ -77,6 +78,18 @@ func TestSQLExportDataSourceResolution(t *testing.T) {err = ctl.changeDatabase(ctx, ctl.project, database, setupSheetResp.Msg, false)a.NoError(err)+ grantDB, err := sql.Open("pgx", fmt.Sprintf("postgresql://postgres:root-password@%s:%s/%s?sslmode=disable", pgContainer.host, pgContainer.port, databaseName))+ a.NoError(err)+ defer grantDB.Close()+ for _, stmt := range []string{+ fmt.Sprintf("GRANT CONNECT ON DATABASE %q TO export_ro", databaseName),+ "GRANT USAGE ON SCHEMA public TO export_ro",+ "GRANT SELECT ON ALL TABLES IN SCHEMA public TO export_ro",+ } {+ _, err = grantDB.Exec(stmt)+ a.NoError(err)+ }+assertExportContent := func() {exportResp, err := ctl.sqlServiceClient.Export(ctx, connect.NewRequest(&v1pb.ExportRequest{Name: database.Name,@@ -94,8 +107,8 @@ func TestSQLExportDataSourceResolution(t *testing.T) {DataSource: &v1pb.DataSource{Id: "readonly",Type: v1pb.DataSourceType_READ_ONLY,- Host: mysqlContainer.host,- Port: mysqlContainer.port,+ Host: pgContainer.host,+ Port: pgContainer.port,Username: "export_ro",Password: "export_ro_password",},diff --git a/backend/tests/sql_export_test.go b/backend/tests/sql_export_test.goindex 90df699ecd..2d9ce103ad 100644--- a/backend/tests/sql_export_test.go+++ b/backend/tests/sql_export_test.go@@ -14,14 +14,12 @@ import ("github.com/stretchr/testify/require""github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")func TestSQLExport(t *testing.T) {tests := []struct {databaseName string- dbType storepb.EngineprepareStatement stringexportTests []struct {format v1pb.ExportFormat@@ -33,61 +31,8 @@ func TestSQLExport(t *testing.T) {}}}{- {- databaseName: "Test1",- dbType: storepb.Engine_MYSQL,- prepareStatement: `- CREATE TABLE tbl(id INT PRIMARY KEY, name VARCHAR(64), gender BIT(1), height BIT(8));- INSERT INTO Test1.tbl (id, name, gender, height) VALUES(1, 'Alice', B'0', B'01111111');- `,- exportTests: []struct {- format v1pb.ExportFormat- statement string- password string- results []struct {- statement string- content string- }- }{- {- format: v1pb.ExportFormat_JSON,- password: "123",- statement: "SELECT * FROM Test1.tbl;",- results: []struct {- statement string- content string- }{- {- statement: "SELECT * FROM Test1.tbl;",- content: `[- {- "gender": "AA==",- "height": "fw==",- "id": 1,- "name": "Alice"- }-]`,- },- },- },- {- format: v1pb.ExportFormat_CSV,- statement: "SELECT * FROM Test1.tbl;",- results: []struct {- statement string- content string- }{- {- statement: "SELECT * FROM Test1.tbl;",- content: "id,name,gender,height\n1,\"Alice\",\"0x00\",\"0x7f\"",- },- },- },- },- },{databaseName: "Test2",- dbType: storepb.Engine_POSTGRES,prepareStatement: "CREATE TABLE tbl(id INT PRIMARY KEY);",exportTests: []struct {format v1pb.ExportFormat@@ -100,6 +45,11 @@ func TestSQLExport(t *testing.T) {}{{format: v1pb.ExportFormat_JSON,+ // Kept non-empty so the encrypted-ZIP path stays covered: the+ // entries below are opened with this password, so an export that+ // came back unencrypted or unreadable fails here. The MySQL case+ // that used to carry it was this test's only one.+ password: "123",statement: `SELECT 1;SELECT 2;@@ -151,31 +101,12 @@ func TestSQLExport(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- mysqlContainer, err := getMySQLContainer(ctx)- defer func() {- mysqlContainer.Close(ctx)- }()- a.NoError(err)-pgContainer, err := getPgContainer(ctx)defer func() {pgContainer.Close(ctx)}()a.NoError(err)- mysqlInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- mysqlInstance := mysqlInstanceResp.Msg-pgInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{@@ -190,17 +121,8 @@ func TestSQLExport(t *testing.T) {pgInstance := pgInstanceResp.Msgfor _, tt := range tests {- var instance *v1pb.Instance- databaseOwner := ""- switch tt.dbType {- case storepb.Engine_MYSQL:- instance = mysqlInstance- case storepb.Engine_POSTGRES:- instance = pgInstance- databaseOwner = "postgres"- default:- a.FailNow("unsupported db type")- }+ instance := pgInstance+ databaseOwner := "postgres"err = ctl.createDatabase(ctx, ctl.project, instance, nil /* environment */, tt.databaseName, databaseOwner)a.NoError(err)@@ -249,6 +171,10 @@ func TestSQLExport(t *testing.T) {for i, compressedFile := range zipReader.File {if exportTest.password != "" {+ // SetPassword only supplies a credential; it does not require the+ // entry to be encrypted, so an export that ignored the password and+ // returned plaintext would still open cleanly below.+ a.True(compressedFile.IsEncrypted(), "entry %q must be encrypted when a password was supplied", compressedFile.Name)compressedFile.SetPassword(exportTest.password)}diff --git a/backend/tests/sql_query_data_source_test.go b/backend/tests/sql_query_data_source_test.goindex 58a7958f0c..201076b59c 100644--- a/backend/tests/sql_query_data_source_test.go+++ b/backend/tests/sql_query_data_source_test.go@@ -2,6 +2,7 @@ package testsimport ("context"+ "database/sql""fmt""reflect""testing"@@ -28,35 +29,35 @@ func TestSQLQueryDataSourceResolution(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- mysqlContainer, err := getMySQLContainer(ctx)+ pgContainer, err := getPgContainer(ctx)defer func() {- mysqlContainer.Close(ctx)+ pgContainer.Close(ctx)}()a.NoError(err)- mysqlDB := mysqlContainer.db- _, err = mysqlDB.Exec("DROP USER IF EXISTS 'query_ro'@'%'")+ // A login role for the read-only data source. Its grants have to wait until+ // the table exists, further down: Postgres grants are per object, where+ // MySQL's GRANT SELECT ON *.* covered tables created later.+ _, err = pgContainer.db.Exec("DROP ROLE IF EXISTS query_ro")a.NoError(err)- _, err = mysqlDB.Exec("CREATE USER 'query_ro'@'%' IDENTIFIED WITH mysql_native_password BY 'query_ro_password'")- a.NoError(err)- _, err = mysqlDB.Exec("GRANT SELECT ON *.* TO 'query_ro'@'%'")+ _, err = pgContainer.db.Exec("CREATE ROLE query_ro LOGIN PASSWORD 'query_ro_password'")a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,+ Title: "pgInstance",+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},+ DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: pgContainer.host, Port: pgContainer.port, Username: "postgres", Password: "root-password", Id: "admin"}},},}))a.NoError(err)instance := instanceResp.Msgconst databaseName = "QueryDataSourceResolution"- err = ctl.createDatabase(ctx, ctl.project, instance, nil, databaseName, "")+ err = ctl.createDatabase(ctx, ctl.project, instance, nil, databaseName, "postgres")a.NoError(err)databaseResp, err := ctl.databaseServiceClient.GetDatabase(ctx, connect.NewRequest(&v1pb.GetDatabaseRequest{@@ -73,6 +74,18 @@ func TestSQLQueryDataSourceResolution(t *testing.T) {err = ctl.changeDatabase(ctx, ctl.project, database, setupSheetResp.Msg, false)a.NoError(err)+ grantDB, err := sql.Open("pgx", fmt.Sprintf("postgresql://postgres:root-password@%s:%s/%s?sslmode=disable", pgContainer.host, pgContainer.port, databaseName))+ a.NoError(err)+ defer grantDB.Close()+ for _, stmt := range []string{+ fmt.Sprintf("GRANT CONNECT ON DATABASE %q TO query_ro", databaseName),+ "GRANT USAGE ON SCHEMA public TO query_ro",+ "GRANT SELECT ON ALL TABLES IN SCHEMA public TO query_ro",+ } {+ _, err = grantDB.Exec(stmt)+ a.NoError(err)+ }+queryResp, err := ctl.sqlServiceClient.Query(ctx, connect.NewRequest(&v1pb.QueryRequest{Name: database.Name,Statement: "SELECT name FROM books;",@@ -86,8 +99,8 @@ func TestSQLQueryDataSourceResolution(t *testing.T) {DataSource: &v1pb.DataSource{Id: "readonly",Type: v1pb.DataSourceType_READ_ONLY,- Host: mysqlContainer.host,- Port: mysqlContainer.port,+ Host: pgContainer.host,+ Port: pgContainer.port,Username: "query_ro",Password: "query_ro_password",},diff --git a/backend/tests/sql_query_test.go b/backend/tests/sql_query_test.goindex 12f1b37d45..0789f34561 100644--- a/backend/tests/sql_query_test.go+++ b/backend/tests/sql_query_test.go@@ -11,59 +11,20 @@ import ("google.golang.org/protobuf/testing/protocmp""google.golang.org/protobuf/types/known/durationpb"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")func TestSQLAdminQuery(t *testing.T) {tests := []struct {databaseName string- dbType storepb.EngineprepareStatements stringquery stringreset stringqueryResult []*v1pb.QueryResultresetResult []*v1pb.QueryResult}{- {- databaseName: "Test1",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE tbl(id INT PRIMARY KEY, name VARCHAR(64), gender BIT(1), height BIT(8));",- query: "INSERT INTO Test1.tbl (id, name, gender, height) VALUES(1, 'Alice', B'0', B'01111111');",- reset: "DELETE FROM tbl;",- queryResult: []*v1pb.QueryResult{- {- ColumnNames: []string{"Affected Rows"},- ColumnTypeNames: []string{"INT"},- Rows: []*v1pb.QueryRow{- {- Values: []*v1pb.RowValue{- {Kind: &v1pb.RowValue_Int64Value{Int64Value: 1}},- },- },- },- Statement: "INSERT INTO Test1.tbl (id, name, gender, height) VALUES(1, 'Alice', B'0', B'01111111');",- RowsCount: 1,- },- },- resetResult: []*v1pb.QueryResult{- {- ColumnNames: []string{"Affected Rows"},- ColumnTypeNames: []string{"INT"},- Rows: []*v1pb.QueryRow{- {- Values: []*v1pb.RowValue{- {Kind: &v1pb.RowValue_Int64Value{Int64Value: 1}},- },- },- },- RowsCount: 1,- },- },- },{databaseName: "Test2",- dbType: storepb.Engine_POSTGRES,prepareStatements: "CREATE TABLE tbl(id INT PRIMARY KEY, name VARCHAR(64), gender BIT(1), height BIT(8));",query: "INSERT INTO tbl (id, name, gender, height) VALUES(1, 'Alice', B'0', B'01111111');",reset: "DELETE FROM tbl;",@@ -106,31 +67,12 @@ func TestSQLAdminQuery(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- mysqlContainer, err := getMySQLContainer(ctx)- defer func() {- mysqlContainer.Close(ctx)- }()- a.NoError(err)-pgContainer, err := getPgContainer(ctx)defer func() {pgContainer.Close(ctx)}()a.NoError(err)- mysqlInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- mysqlInstance := mysqlInstanceResp.Msg-pgInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{@@ -145,17 +87,8 @@ func TestSQLAdminQuery(t *testing.T) {pgInstance := pgInstanceResp.Msgfor _, tt := range tests {- var instance *v1pb.Instance- databaseOwner := ""- switch tt.dbType {- case storepb.Engine_MYSQL:- instance = mysqlInstance- case storepb.Engine_POSTGRES:- instance = pgInstance- databaseOwner = "postgres"- default:- a.FailNow("unsupported db type")- }+ instance := pgInstance+ databaseOwner := "postgres"err = ctl.createDatabase(ctx, ctl.project, instance, nil /* environment */, tt.databaseName, databaseOwner)a.NoError(err)diff --git a/backend/tests/sql_review_test.go b/backend/tests/sql_review_test.goindex d2f21e8e9c..5575687c3a 100644--- a/backend/tests/sql_review_test.go+++ b/backend/tests/sql_review_test.go@@ -18,7 +18,6 @@ import ("github.com/stretchr/testify/require""google.golang.org/protobuf/encoding/protojson""google.golang.org/protobuf/testing/protocmp"- "google.golang.org/protobuf/types/known/durationpb""google.golang.org/protobuf/types/known/fieldmaskpb""gopkg.in/yaml.v3"@@ -28,22 +27,18 @@ import ()var (- noSQLReviewPolicy = []*v1pb.PlanCheckRun_Result{- {- Status: v1pb.Advice_SUCCESS,- Title: "OK",- },- }- // builtinOnlyPolicyWithConflict is the expected result when:- // 1. There's no user-configured SQL review policy- // 2. But builtin rules still run (BUILTIN_WALK_THROUGH_CHECK)- // 3. And the statement conflicts with existing schema (e.g., table already exists)+ // builtinOnlyPolicyWithConflict is what review returns with no user policy+ // configured but the builtin walk-through still running, against a statement+ // that conflicts with the schema already in the database.builtinOnlyPolicyWithConflict = []*v1pb.PlanCheckRun_Result{{- Status: v1pb.Advice_WARNING,- Title: "Table `user` already exists",- Content: "Table `user` already exists",- Code: 607, // code.TableExists+ Status: v1pb.Advice_WARNING,+ // Postgres reaches this through DDL simulation where MySQL used a+ // walk-through, but either way it is the builtin rule speaking, which is+ // the point: no user policy is configured at this stage.+ Title: "DDL simulation failed",+ Content: `ERROR: relation "tech_book" already exists (SQLSTATE 42P07)`,+ Code: 607,Report: &v1pb.PlanCheckRun_Result_SqlReviewReport_{SqlReviewReport: &v1pb.PlanCheckRun_Result_SqlReviewReport{StartPosition: &v1pb.Position{Line: 1},@@ -51,6 +46,13 @@ var (},},}++ noSQLReviewPolicy = []*v1pb.PlanCheckRun_Result{+ {+ Status: v1pb.Advice_SUCCESS,+ Title: "OK",+ },+ })type test struct {@@ -196,212 +198,13 @@ func TestSQLReviewForPostgreSQL(t *testing.T) {result = createIssueAndReturnSQLReviewResult(ctx, a, ctl, ctl.project, database.Msg, statements[0], false)equalReviewResultProtos(a, noSQLReviewPolicy, result, database.Msg.Name, "")-}--func TestSQLReviewForMySQL(t *testing.T) {- const (- record = false- )- var (- filepath = filepath.Join("test-data", "sql_review_mysql.yaml")- databaseName = "testsqlreview"- statements = []string{- "CREATE TABLE user(" +- "id INT PRIMARY KEY COMMENT 'comment'," +- "name VARCHAR(255) NOT NULL DEFAULT '' COMMENT 'comment'," +- "room_id INT NOT NULL DEFAULT 0 COMMENT 'comment'," +- "creator_id INT NOT NULL DEFAULT 0 COMMENT 'comment'," +- "created_ts TIMESTAMP NOT NULL DEFAULT NOW() COMMENT 'comment'," +- "updater_id INT NOT NULL DEFAULT 0 COMMENT 'comment'," +- "updated_ts TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment'," +- "INDEX idx_user_name(name)," +- "UNIQUE KEY uk_user_id_name(id, name)" +- ") ENGINE = INNODB COMMENT 'comment'",- "CREATE TABLE userTable(" +- "id INT NOT NULL," +- "name VARCHAR(255) CHARSET ascii," +- "roomId INT," +- "time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment'," +- "time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment'," +- "content BLOB NOT NULL COMMENT 'comment'," +- "json_content JSON NOT NULL COMMENT 'comment'," +- "INDEX idx1(name)," +- "UNIQUE KEY uk1(id, name)," +- "FOREIGN KEY fk1(roomId) REFERENCES room(id)," +- "INDEX idx_userTable_content(content)" +- ") ENGINE = CSV COLLATE latin1_bin",- }- valueTable = `(SELECT 1 AS id, 'a' AS name WHERE 1=1 UNION ALL- SELECT 2 AS id, 'b' AS name WHERE 1=1 UNION ALL- SELECT 3 AS id, 'c' AS name WHERE 1=1 UNION ALL- SELECT 4 AS id, 'd' AS name WHERE 1=1 UNION ALL- SELECT 5 AS id, 'e' AS name WHERE 1=1 UNION ALL- SELECT 6 AS id, 'f' AS name WHERE 1=1 UNION ALL- SELECT 7 AS id, 'g' AS name WHERE 1=1 UNION ALL- SELECT 8 AS id, 'h' AS name WHERE 1=1 UNION ALL- SELECT 9 AS id, 'i' AS name WHERE 1=1 UNION ALL- SELECT 10 AS id, 'j' AS name WHERE 1=1) value_table`- wantQueryResult = &v1pb.QueryResult{- ColumnNames: []string{"count(*)"},- ColumnTypeNames: []string{"BIGINT"},- Masked: []*v1pb.MaskingReason{nil},- Rows: []*v1pb.QueryRow{- {- Values: []*v1pb.RowValue{- {Kind: &v1pb.RowValue_Int64Value{Int64Value: 4}},- },- },- },- Statement: "SELECT count(*) FROM test WHERE 1=1;",- RowsCount: 1,- }- )-- t.Parallel()- a := require.New(t)- ctx := context.Background()- ctl := &controller{}- tests, err := readTestData(filepath)- a.NoError(err)- ctx, err = ctl.StartServerWithExternalPg(ctx)- a.NoError(err)- defer ctl.Close(ctx)-- mysqlContainer, err := getMySQLContainer(ctx)- defer func() {- mysqlContainer.Close(ctx)- }()- a.NoError(err)-- mysqlDB := mysqlContainer.db- _, err = mysqlDB.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS %v", databaseName))- a.NoError(err)-- _, err = mysqlDB.Exec("DROP USER IF EXISTS bytebase")- a.NoError(err)- _, err = mysqlDB.Exec("CREATE USER 'bytebase' IDENTIFIED WITH mysql_native_password BY 'bytebase'")- a.NoError(err)- _, err = mysqlDB.Exec("GRANT ALTER, ALTER ROUTINE, CREATE, CREATE ROUTINE, CREATE VIEW, DELETE, DROP, EVENT, EXECUTE, INDEX, INSERT, PROCESS, REFERENCES, SELECT, SHOW DATABASES, SHOW VIEW, TRIGGER, UPDATE, USAGE, REPLICATION CLIENT, REPLICATION SLAVE, LOCK TABLES, RELOAD ON *.* to bytebase")- a.NoError(err)-- reviewConfig := prodTemplateReviewConfigForMySQL()-- createdConfig, err := ctl.reviewConfigServiceClient.CreateReviewConfig(ctx, connect.NewRequest(&v1pb.CreateReviewConfigRequest{- ReviewConfig: reviewConfig,- }))- a.NoError(err)- a.NotNil(createdConfig.Msg.Name)-- policy, err := ctl.orgPolicyServiceClient.CreatePolicy(ctx, connect.NewRequest(&v1pb.CreatePolicyRequest{- Parent: "environments/prod",- Policy: &v1pb.Policy{- Type: v1pb.PolicyType_TAG,- Policy: &v1pb.Policy_TagPolicy{- TagPolicy: &v1pb.TagPolicy{- Tags: map[string]string{- common.ReservedTagReviewConfig: createdConfig.Msg.Name,- },- },- },- },- }))- a.NoError(err)- a.NotNil(policy.Msg.Name)-- instance, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "bytebase", Password: "bytebase", Id: "admin"}},- },- }))- a.NoError(err)-- err = ctl.createDatabase(ctx, ctl.project, instance.Msg, nil /* environment */, databaseName, "")- a.NoError(err)-- database, err := ctl.databaseServiceClient.GetDatabase(ctx, connect.NewRequest(&v1pb.GetDatabaseRequest{- Name: fmt.Sprintf("%s/databases/%s", instance.Msg.Name, databaseName),- }))- a.NoError(err)-- for i, t := range tests {- result := createIssueAndReturnSQLReviewResult(ctx, a, ctl, ctl.project, database.Msg, t.Statement, t.Run)- if record {- tests[i].Result = result- } else {- equalReviewResultProtos(a, t.Result, result, database.Msg.Name, tests[i].Statement)- }- }-- if record {- err := writeTestData(filepath, tests)- a.NoError(err)- }-- // test for dry-run-dml- initialStmts := []string{- "CREATE TABLE test(" +- "id INT PRIMARY KEY COMMENT 'comment'," +- "name VARCHAR(255) NOT NULL DEFAULT '' COMMENT 'comment'," +- "room_id INT NOT NULL DEFAULT 0 COMMENT 'comment'," +- "creator_id INT NOT NULL DEFAULT 0 COMMENT 'comment'," +- "created_ts TIMESTAMP NOT NULL DEFAULT NOW() COMMENT 'comment'," +- "updater_id INT NOT NULL DEFAULT 0 COMMENT 'comment'," +- "updated_ts TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment'," +- "INDEX idx_test_name(name)," +- "UNIQUE KEY uk_test_id_name(id, name)" +- ") ENGINE = INNODB COMMENT 'comment';",- `INSERT INTO test(id, name) VALUES (1, 'a'), (2, 'b'), (3, 'c'), (4, 'd');`,- }- for _, stmt := range initialStmts {- createIssueAndReturnSQLReviewResult(ctx, a, ctl, ctl.project, database.Msg, stmt, true /* wait */)- }- countSQL := "SELECT count(*) FROM test WHERE 1=1;"- dmlSQL := "INSERT INTO test SELECT * FROM " + valueTable- originQueryResp, err := ctl.sqlServiceClient.Query(ctx, connect.NewRequest(&v1pb.QueryRequest{- Name: database.Msg.Name,- Statement: countSQL,- }))- a.NoError(err)- a.Equal(1, len(originQueryResp.Msg.Results))- diff := cmp.Diff(wantQueryResult, originQueryResp.Msg.Results[0], protocmp.Transform(), protocmp.IgnoreMessages(&durationpb.Duration{}))- a.Empty(diff)-- createIssueAndReturnSQLReviewResult(ctx, a, ctl, ctl.project, database.Msg, dmlSQL, false /* wait */)-- finalQueryResp, err := ctl.sqlServiceClient.Query(ctx, connect.NewRequest(&v1pb.QueryRequest{- Name: database.Msg.Name,- Statement: countSQL,- }))- a.NoError(err)- a.Equal(1, len(finalQueryResp.Msg.Results))- diff = cmp.Diff(wantQueryResult, finalQueryResp.Msg.Results[0], protocmp.Transform(), protocmp.IgnoreMessages(&durationpb.Duration{}))- a.Empty(diff)-- // disable the SQL review policy- policy.Msg.Enforce = false- _, err = ctl.orgPolicyServiceClient.UpdatePolicy(ctx, connect.NewRequest(&v1pb.UpdatePolicyRequest{- Policy: policy.Msg,- UpdateMask: &fieldmaskpb.FieldMask{- Paths: []string{"enforce"},- },- }))- a.NoError(err)-- // delete the SQL review policy- _, err = ctl.orgPolicyServiceClient.DeletePolicy(ctx, connect.NewRequest(&v1pb.DeletePolicyRequest{- Name: policy.Msg.Name,- }))- a.NoError(err)- // Even with no user-configured policy, builtin rules still run.- // BUILTIN_WALK_THROUGH_CHECK will find that the 'user' table already exists- // (created by a previous test case with run=true).- result := createIssueAndReturnSQLReviewResult(ctx, a, ctl, ctl.project, database.Msg, statements[0], false)+ // With no user-configured policy the builtin rules still run, and this is the+ // only place that proves it: statements[0] creates a table that does not+ // exist, so an OK there cannot tell "builtin ran and found nothing" apart+ // from "review was skipped". tech_book was created for real by the run:true+ // case in the fixture, so re-creating it must draw the builtin walk-through.+ result = createIssueAndReturnSQLReviewResult(ctx, a, ctl, ctl.project, database.Msg, "CREATE TABLE tech_book(id INT);", false)equalReviewResultProtos(a, builtinOnlyPolicyWithConflict, result, database.Msg.Name, "")}@@ -547,6 +350,15 @@ func prodTemplateReviewConfigForPostgreSQL() *v1pb.ReviewConfig {Title: "Prod",Enabled: true,Rules: []*v1pb.SQLReviewRule{+ // Driver-dependent: this rule EXPLAINs each DML statement, so it only+ // produces advice when the plan check executor hands the advisor a live+ // connection. It is the one rule here that covers that wiring, which the+ // advisor-level tests cannot: they pass a driver in directly.+ {+ Type: v1pb.SQLReviewRule_STATEMENT_DML_DRY_RUN,+ Level: v1pb.SQLReviewRule_WARNING,+ Engine: v1pb.Engine_POSTGRES,+ },// Naming{Type: v1pb.SQLReviewRule_NAMING_TABLE,@@ -792,383 +604,3 @@ func prodTemplateReviewConfigForPostgreSQL() *v1pb.ReviewConfig {return config}--func prodTemplateReviewConfigForMySQL() *v1pb.ReviewConfig {- config := &v1pb.ReviewConfig{- Name: common.FormatReviewConfig(generateRandomString("review")),- Title: "Prod",- Enabled: true,- Rules: []*v1pb.SQLReviewRule{- // Engine- {- Type: v1pb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- // Naming- {- Type: v1pb.SQLReviewRule_NAMING_TABLE,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "^[a-z]+(_[a-z]+)*$",- MaxLength: 64,- },- },- },- {- Type: v1pb.SQLReviewRule_NAMING_COLUMN,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "^[a-z]+(_[a-z]+)*$",- MaxLength: 64,- },- },- },- {- Type: v1pb.SQLReviewRule_NAMING_INDEX_IDX,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "^$|^idx_{{table}}_{{column_list}}$",- MaxLength: 64,- },- },- },- {- Type: v1pb.SQLReviewRule_NAMING_INDEX_UK,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "^$|^uk_{{table}}_{{column_list}}$",- MaxLength: 64,- },- },- },- {- Type: v1pb.SQLReviewRule_NAMING_INDEX_FK,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$",- MaxLength: 64,- },- },- },- {- Type: v1pb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "^id$",- MaxLength: 64,- },- },- },- // Statement- {- Type: v1pb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NumberPayload{- NumberPayload: &v1pb.SQLReviewRule_NumberRulePayload{- Number: 5,- },- },- },- {- Type: v1pb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NumberPayload{- NumberPayload: &v1pb.SQLReviewRule_NumberRulePayload{- Number: 5,- },- },- },- {- Type: v1pb.SQLReviewRule_STATEMENT_DML_DRY_RUN,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- // TABLE- {- Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NamingPayload{- NamingPayload: &v1pb.SQLReviewRule_NamingRulePayload{- Format: "_delete$",- },- },- },- {- Type: v1pb.SQLReviewRule_TABLE_COMMENT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_CommentConventionPayload{- CommentConventionPayload: &v1pb.SQLReviewRule_CommentConventionRulePayload{- Required: true,- MaxLength: 10,- },- },- },- {- Type: v1pb.SQLReviewRule_TABLE_DISALLOW_PARTITION,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- // COLUMN- {- Type: v1pb.SQLReviewRule_COLUMN_REQUIRED,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_StringArrayPayload{- StringArrayPayload: &v1pb.SQLReviewRule_StringArrayRulePayload{- List: []string{- "id",- "created_ts",- "updated_ts",- "creator_id",- "updater_id",- },- },- },- },- {- Type: v1pb.SQLReviewRule_COLUMN_NO_NULL,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGE,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_COMMENT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_CommentConventionPayload{- CommentConventionPayload: &v1pb.SQLReviewRule_CommentConventionRulePayload{- Required: true,- MaxLength: 10,- },- },- },- {- Type: v1pb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_StringArrayPayload{- StringArrayPayload: &v1pb.SQLReviewRule_StringArrayRulePayload{- List: []string{"JSON", "BINARY_FLOAT"},- },- },- },- {- Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NumberPayload{- NumberPayload: &v1pb.SQLReviewRule_NumberRulePayload{- Number: 20,- },- },- },- {- Type: v1pb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NumberPayload{- NumberPayload: &v1pb.SQLReviewRule_NumberRulePayload{- Number: 20,- },- },- },- {- Type: v1pb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- // SCHEMA- {- Type: v1pb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- // DATABASE- {- Type: v1pb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE,- Level: v1pb.SQLReviewRule_ERROR,- Engine: v1pb.Engine_MYSQL,- },- // INDEX- {- Type: v1pb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NumberPayload{- NumberPayload: &v1pb.SQLReviewRule_NumberRulePayload{- Number: 5,- },- },- },- {- Type: v1pb.SQLReviewRule_INDEX_PK_TYPE_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_INDEX_TYPE_NO_BLOB,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- },- {- Type: v1pb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_NumberPayload{- NumberPayload: &v1pb.SQLReviewRule_NumberRulePayload{- Number: 5,- },- },- },- // SYSTEM- {- Type: v1pb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_StringArrayPayload{- StringArrayPayload: &v1pb.SQLReviewRule_StringArrayRulePayload{- List: []string{"utf8mb4", "UTF8"},- },- },- },- {- Type: v1pb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST,- Level: v1pb.SQLReviewRule_WARNING,- Engine: v1pb.Engine_MYSQL,- Payload: &v1pb.SQLReviewRule_StringArrayPayload{- StringArrayPayload: &v1pb.SQLReviewRule_StringArrayRulePayload{- List: []string{"utf8mb4_0900_ai_ci"},- },- },- },- },- }-- return config-}diff --git a/backend/tests/sql_stop_on_error_test.go b/backend/tests/sql_stop_on_error_test.goindex 7a2b81507d..5317cebcb5 100644--- a/backend/tests/sql_stop_on_error_test.go+++ b/backend/tests/sql_stop_on_error_test.go@@ -8,7 +8,6 @@ import ("connectrpc.com/connect""github.com/stretchr/testify/require"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")@@ -16,8 +15,6 @@ func TestSQLQueryStopOnError(t *testing.T) {tests := []struct {name stringdatabaseName string- dbType storepb.Engine- environment string // Environment to create database in (defaults to prod if empty)prepareStatements stringquery stringwantResults int // Number of successful results before error@@ -26,63 +23,35 @@ func TestSQLQueryStopOnError(t *testing.T) {wantPermissionDenied bool // Whether to expect permission_denied in detailed_error}{{- name: "MySQL - All statements succeed",- databaseName: "TestStopOnError1",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE tbl1(id INT PRIMARY KEY, name VARCHAR(64));",- query: "INSERT INTO tbl1 VALUES(1, 'Alice'); INSERT INTO tbl1 VALUES(2, 'Bob'); SELECT * FROM tbl1;",- wantResults: 3, // 2 inserts + 1 select- wantError: false,- },- {- name: "MySQL - Second statement fails",- databaseName: "TestStopOnError2",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE tbl2(id INT PRIMARY KEY, name VARCHAR(64));",- query: "INSERT INTO tbl2 VALUES(1, 'Alice'); INSERT INTO nonexistent VALUES(2, 'Bob'); INSERT INTO tbl2 VALUES(3, 'Charlie');",- wantResults: 2, // First insert succeeds + error result- wantError: true,- },- {- name: "MySQL - First statement fails",- databaseName: "TestStopOnError3",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE tbl3(id INT PRIMARY KEY, name VARCHAR(64));",- query: "INSERT INTO nonexistent VALUES(1, 'Alice'); INSERT INTO tbl3 VALUES(2, 'Bob');",- wantResults: 1, // Error result only- wantError: true,- },- {- name: "PostgreSQL - All statements succeed",+ name: "All statements succeed",databaseName: "TestStopOnError4",- dbType: storepb.Engine_POSTGRES,prepareStatements: "CREATE TABLE tbl4(id INT PRIMARY KEY, name VARCHAR(64));",query: "INSERT INTO tbl4 VALUES(1, 'Alice'); INSERT INTO tbl4 VALUES(2, 'Bob'); SELECT * FROM tbl4;",- wantResults: 3,+ wantResults: 3, // 2 inserts + 1 selectwantError: false,},{- name: "PostgreSQL - Second statement fails",+ name: "Second statement fails",databaseName: "TestStopOnError5",- dbType: storepb.Engine_POSTGRES,prepareStatements: "CREATE TABLE tbl5(id INT PRIMARY KEY, name VARCHAR(64));",query: "INSERT INTO tbl5 VALUES(1, 'Alice'); INSERT INTO nonexistent VALUES(2, 'Bob'); INSERT INTO tbl5 VALUES(3, 'Charlie');",wantResults: 2, // First insert succeeds + error resultwantError: true,},{- name: "MySQL - Syntax error",- databaseName: "TestStopOnError6",- dbType: storepb.Engine_MYSQL,- query: "SELECT * FORM invalid_table;",- wantResults: 1, // Error result- wantError: true,- wantSyntaxError: true,+ // Ported from the MySQL arm when it was dropped: the Postgres arm had no+ // first-statement-fails case, and stopping before the second statement is+ // the behavior under test.+ name: "First statement fails",+ databaseName: "TestStopOnError3",+ prepareStatements: "CREATE TABLE tbl3(id INT PRIMARY KEY, name VARCHAR(64));",+ query: "INSERT INTO nonexistent VALUES(1, 'Alice'); INSERT INTO tbl3 VALUES(2, 'Bob');",+ wantResults: 1, // Error result only+ wantError: true,},{- name: "PostgreSQL - Syntax error",+ name: "Syntax error",databaseName: "TestStopOnError7",- dbType: storepb.Engine_POSTGRES,query: "SELCT * FROM tbl5;",wantResults: 1, // Error resultwantError: true,@@ -100,31 +69,12 @@ func TestSQLQueryStopOnError(t *testing.T) {ctl.Close(ctx)})- mysqlContainer, err := getMySQLContainer(ctx)- t.Cleanup(func() {- mysqlContainer.Close(ctx)- })- a.NoError(err)-pgContainer, err := getPgContainer(ctx)t.Cleanup(func() {pgContainer.Close(ctx)})a.NoError(err)- mysqlInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- mysqlInstance := mysqlInstanceResp.Msg-pgInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{@@ -138,61 +88,13 @@ func TestSQLQueryStopOnError(t *testing.T) {a.NoError(err)pgInstance := pgInstanceResp.Msg- // Create instances for test environment (with DML policy)- mysqlTestInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlTestInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/test"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- mysqlTestInstance := mysqlTestInstanceResp.Msg-- pgTestInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "pgTestInstance",- Engine: v1pb.Engine_POSTGRES,- Environment: new("environments/test"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: pgContainer.host, Port: pgContainer.port, Username: "postgres", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- pgTestInstance := pgTestInstanceResp.Msg-for _, tt := range tests {t.Run(tt.name, func(t *testing.T) {t.Parallel()a := require.New(t)- var instance *v1pb.Instance- databaseOwner := ""- if tt.environment == "test" {- switch tt.dbType {- case storepb.Engine_MYSQL:- instance = mysqlTestInstance- case storepb.Engine_POSTGRES:- instance = pgTestInstance- databaseOwner = "postgres"- default:- a.FailNow("unsupported db type")- }- } else {- switch tt.dbType {- case storepb.Engine_MYSQL:- instance = mysqlInstance- case storepb.Engine_POSTGRES:- instance = pgInstance- databaseOwner = "postgres"- default:- a.FailNow("unsupported db type")- }- }+ instance := pgInstance+ databaseOwner := "postgres"err = ctl.createDatabase(ctx, ctl.project, instance, nil, tt.databaseName, databaseOwner)a.NoError(err)@@ -268,25 +170,14 @@ func TestSQLAdminExecuteStopOnError(t *testing.T) {tests := []struct {name stringdatabaseName string- dbType storepb.EngineprepareStatements stringquery stringwantResults intwantError bool}{{- name: "MySQL AdminExecute - Second statement fails",- databaseName: "TestAdminStopOnError1",- dbType: storepb.Engine_MYSQL,- prepareStatements: "CREATE TABLE admin_tbl1(id INT PRIMARY KEY, name VARCHAR(64));",- query: "INSERT INTO admin_tbl1 VALUES(1, 'Alice'); INSERT INTO nonexistent VALUES(2, 'Bob'); INSERT INTO admin_tbl1 VALUES(3, 'Charlie');",- wantResults: 1,- wantError: true,- },- {- name: "PostgreSQL AdminExecute - Second statement fails",+ name: "AdminExecute - Second statement fails",databaseName: "TestAdminStopOnError2",- dbType: storepb.Engine_POSTGRES,prepareStatements: "CREATE TABLE admin_tbl2(id INT PRIMARY KEY, name VARCHAR(64));",query: "INSERT INTO admin_tbl2 VALUES(1, 'Alice'); INSERT INTO nonexistent VALUES(2, 'Bob'); INSERT INTO admin_tbl2 VALUES(3, 'Charlie');",wantResults: 1,@@ -304,31 +195,12 @@ func TestSQLAdminExecuteStopOnError(t *testing.T) {ctl.Close(ctx)})- mysqlContainer, err := getMySQLContainer(ctx)- t.Cleanup(func() {- mysqlContainer.Close(ctx)- })- a.NoError(err)-pgContainer, err := getPgContainer(ctx)t.Cleanup(func() {pgContainer.Close(ctx)})a.NoError(err)- mysqlInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: generateRandomString("instance"),- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "root", Password: "root-password", Id: "admin"}},- },- }))- a.NoError(err)- mysqlInstance := mysqlInstanceResp.Msg-pgInstanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{@@ -347,17 +219,8 @@ func TestSQLAdminExecuteStopOnError(t *testing.T) {t.Parallel()a := require.New(t)- var instance *v1pb.Instance- databaseOwner := ""- switch tt.dbType {- case storepb.Engine_MYSQL:- instance = mysqlInstance- case storepb.Engine_POSTGRES:- instance = pgInstance- databaseOwner = "postgres"- default:- a.FailNow("unsupported db type")- }+ instance := pgInstance+ databaseOwner := "postgres"err = ctl.createDatabase(ctx, ctl.project, instance, nil, tt.databaseName, databaseOwner)a.NoError(err)diff --git a/backend/tests/syncer_test.go b/backend/tests/syncer_test.goindex d9e12fbc2f..f1157151c0 100644--- a/backend/tests/syncer_test.go+++ b/backend/tests/syncer_test.go@@ -11,7 +11,6 @@ import ("github.com/stretchr/testify/require""google.golang.org/protobuf/testing/protocmp"- "github.com/bytebase/bytebase/backend/common"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")@@ -248,290 +247,3 @@ func TestSyncerForPostgreSQL(t *testing.T) {diff := cmp.Diff(wantDatabaseMetadata, latestSchemaMetadata, protocmp.Transform())a.Empty(diff)}--func TestSyncerForMySQL(t *testing.T) {- const (- databaseName = "test_sync_mysql_schema_db"- createSchema = `- CREATE TABLE trd (- a int DEFAULT NULL,- b int DEFAULT NULL,- c int DEFAULT NULL,- UNIQUE KEY a (a,b,c)- );- CREATE TABLE t1 (- id int PRIMARY KEY- );- CREATE TABLE tfk (- a int DEFAULT NULL,- b int DEFAULT NULL,- c int DEFAULT NULL,- KEY a (a,b,c),- CONSTRAINT tfk_ibfk_1 FOREIGN KEY (a, b, c) REFERENCES trd (a, b, c),- CONSTRAINT tfk_ibfk_2 FOREIGN KEY (a) REFERENCES t1 (id)- );- `- expectedSchema = `{- "name":"instances/instance-syncer-mysql/databases/test_sync_mysql_schema_db/metadata",- "schemas":[- {- "tables":[- {- "name":"t1",- "columns":[- {- "name":"id",- "position":1,- "type":"int"- }- ],- "indexes":[- {- "name":"PRIMARY",- "expressions":[- "id"- ],- "keyLength": [- "-1"- ],- "descending": [- false- ],- "type":"BTREE",- "unique":true,- "primary":true,- "visible":true- }- ],- "charset": "utf8mb4",- "engine":"InnoDB",- "collation":"utf8mb4_general_ci",- "dataSize":"16384"- },- {- "name":"tfk",- "columns":[- {- "name":"a",- "position":1,- "nullable":true,- "type":"int",- "default": "NULL",- "has_default": true- },- {- "name":"b",- "position":2,- "nullable":true,- "type":"int",- "default": "NULL",- "has_default": true- },- {- "name":"c",- "position":3,- "nullable":true,- "type":"int",- "default": "NULL",- "has_default": true- }- ],- "indexes":[- {- "name":"a",- "expressions":[- "a",- "b",- "c"- ],- "keyLength": [- -1,- -1,- -1- ],- "descending": [- false,- false,- false- ],- "type":"BTREE",- "visible":true- }- ],- "engine":"InnoDB",- "charset": "utf8mb4",- "collation":"utf8mb4_general_ci",- "dataSize":"16384",- "indexSize":"16384",- "foreignKeys":[- {- "name":"tfk_ibfk_1",- "columns":[- "a",- "b",- "c"- ],- "referencedTable":"trd",- "referencedColumns":[- "a",- "b",- "c"- ],- "onDelete":"NO ACTION",- "onUpdate":"NO ACTION",- "matchType":"NONE"- },- {- "name":"tfk_ibfk_2",- "columns":[- "a"- ],- "referencedTable":"t1",- "referencedColumns":[- "id"- ],- "onDelete":"NO ACTION",- "onUpdate":"NO ACTION",- "matchType":"NONE"- }- ]- },- {- "name":"trd",- "columns":[- {- "name":"a",- "position":1,- "nullable":true,- "type":"int",- "default": "NULL",- "has_default": true- },- {- "name":"b",- "position":2,- "nullable":true,- "type":"int",- "default": "NULL",- "has_default": true- },- {- "name":"c",- "position":3,- "nullable":true,- "type":"int",- "default": "NULL",- "has_default": true- }- ],- "indexes":[- {- "name":"a",- "expressions":[- "a",- "b",- "c"- ],- "keyLength": [- -1,- -1,- -1- ],- "descending": [- false,- false,- false- ],- "type":"BTREE",- "unique":true,- "visible":true- }- ],- "engine":"InnoDB",- "charset": "utf8mb4",- "collation":"utf8mb4_general_ci",- "dataSize":"16384",- "indexSize":"16384"- }- ]- }- ],- "characterSet":"utf8mb4",- "collation":"utf8mb4_general_ci"- }`- )-- t.Parallel()- a := require.New(t)- ctx := context.Background()- ctl := &controller{}- ctx, err := ctl.StartServerWithExternalPg(ctx)- a.NoError(err)- defer ctl.Close(ctx)-- mysqlContainer, err := getMySQLContainer(ctx)- defer func() {- mysqlContainer.Close(ctx)- }()- a.NoError(err)-- mysqlDB := mysqlContainer.db- _, err = mysqlDB.Exec(fmt.Sprintf("DROP DATABASE IF EXISTS %v", databaseName))- a.NoError(err)-- _, err = mysqlDB.Exec("DROP USER IF EXISTS bytebase")- a.NoError(err)- _, err = mysqlDB.Exec("CREATE USER 'bytebase' IDENTIFIED WITH mysql_native_password BY 'bytebase'")- a.NoError(err)-- _, err = mysqlDB.Exec("GRANT ALTER, ALTER ROUTINE, CREATE, CREATE ROUTINE, CREATE VIEW, DELETE, DROP, EVENT, EXECUTE, INDEX, INSERT, PROCESS, REFERENCES, SELECT, SHOW DATABASES, SHOW VIEW, TRIGGER, UPDATE, USAGE, REPLICATION CLIENT, REPLICATION SLAVE, LOCK TABLES, RELOAD ON *.* to bytebase")- a.NoError(err)-- instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{- InstanceId: "instance-syncer-mysql",- Instance: &v1pb.Instance{- Title: "mysqlInstance",- Engine: v1pb.Engine_MYSQL,- Environment: new("environments/prod"),- Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: mysqlContainer.host, Port: mysqlContainer.port, Username: "bytebase", Password: "bytebase", Id: "admin"}},- },- }))- a.NoError(err)- instance := instanceResp.Msg-- err = ctl.createDatabase(ctx, ctl.project, instance, nil /* environment */, databaseName, "")- a.NoError(err)-- databaseResp, err := ctl.databaseServiceClient.GetDatabase(ctx, connect.NewRequest(&v1pb.GetDatabaseRequest{- Name: fmt.Sprintf("%s/databases/%s", instance.Name, databaseName),- }))- a.NoError(err)- database := databaseResp.Msg-- sheetResp, err := ctl.sheetServiceClient.CreateSheet(ctx, connect.NewRequest(&v1pb.CreateSheetRequest{- Parent: ctl.project.Name,- Sheet: &v1pb.Sheet{- Content: []byte(createSchema),- },- }))- a.NoError(err)- sheet := sheetResp.Msg-- // Create an issue that updates database schema.- err = ctl.changeDatabase(ctx, ctl.project, database, sheet, false)- a.NoError(err)-- latestSchemaMetadataResp, err := ctl.databaseServiceClient.GetDatabaseMetadata(ctx, connect.NewRequest(&v1pb.GetDatabaseMetadataRequest{- Name: fmt.Sprintf("%s/metadata", database.Name),- }))- a.NoError(err)- latestSchemaMetadata := latestSchemaMetadataResp.Msg-- var expectedSchemaMetadata v1pb.DatabaseMetadata- err = common.ProtojsonUnmarshaler.Unmarshal([]byte(expectedSchema), &expectedSchemaMetadata)- a.NoError(err)-- diff := cmp.Diff(&expectedSchemaMetadata, latestSchemaMetadata, protocmp.Transform())- a.Empty(diff)-}diff --git a/backend/tests/test-data/sql_review_mysql.yaml b/backend/tests/test-data/sql_review_mysql.yamldeleted file mode 100644index 5a87e2f1ef..0000000000--- a/backend/tests/test-data/sql_review_mysql.yaml+++ /dev/null@@ -1,937 +0,0 @@-- statement: CREATE TABLE user(id INT PRIMARY KEY COMMENT 'comment',name VARCHAR(255) NOT NULL DEFAULT '' COMMENT 'comment',room_id INT NOT NULL DEFAULT 0 COMMENT 'comment',creator_id INT NOT NULL DEFAULT 0 COMMENT 'comment',created_ts TIMESTAMP NOT NULL DEFAULT NOW() COMMENT 'comment',updater_id INT NOT NULL DEFAULT 0 COMMENT 'comment',updated_ts TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',INDEX idx_user_name(name),UNIQUE KEY uk_user_id_name(id, name)) ENGINE = INNODB COMMENT 'comment'- result:- - |-- {- "status": "SUCCESS",- "title": "OK",- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE"- }- run: false-- statement: CREATE TABLE user(id);- result:- - |-- {- "status": "ERROR",- "title": "Syntax error",- "content": "Syntax error at line 1:21: expected data type\nrelated text: CREATE TABLE user(id);",- "code": 201,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1,- "column": 21- }- }- }- run: false-- statement: CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content)) ENGINE = CSV COLLATE latin1_bin- result:- - |-- {- "status": "WARNING",- "title": "BLOB/TEXT column used in key specification without a key length",- "content": "BLOB/TEXT column used in key specification without a key length",- "code": 260,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content(10))) ENGINE = MyISAM COLLATE latin1_bin- result:- - |-- {- "status": "ERROR",- "title": "ENGINE_MYSQL_USE_INNODB",- "content": "\"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content(10))) ENGINE = MyISAM COLLATE latin1_bin;\" doesn't use InnoDB engine",- "code": 501,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "ERROR",- "title": "TABLE_REQUIRE_PK",- "content": "Table `userTable` requires PRIMARY KEY",- "code": 601,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "ERROR",- "title": "TABLE_NO_FOREIGN_KEY",- "content": "Foreign key is not allowed in the table `userTable`",- "code": 602,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "ERROR",- "title": "COLUMN_TYPE_DISALLOW_LIST",- "content": "Disallow column type JSON but column `userTable`.`json_content` is",- "code": 411,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "NAMING_TABLE",- "content": "`userTable` mismatches table naming convention, naming format should be \"^[a-z]+(_[a-z]+)*$\"",- "code": 301,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "NAMING_COLUMN",- "content": "`userTable`.`roomId` mismatches column naming convention, naming format should be \"^[a-z]+(_[a-z]+)*$\"",- "code": 302,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "NAMING_INDEX_IDX",- "content": "Index in table `userTable` mismatches the naming convention, expect \"^$|^idx_userTable_name$\" but found `idx1`",- "code": 303,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "NAMING_INDEX_UK",- "content": "Unique key in table `userTable` mismatches the naming convention, expect \"^$|^uk_userTable_id_name$\" but found `uk1`",- "code": 304,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "NAMING_INDEX_FK",- "content": "Foreign key in table `userTable` mismatches the naming convention, expect \"^$|^fk_userTable_roomId_room_id$\" but found `fk1`",- "code": 305,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "TABLE_COMMENT",- "content": "Table `userTable` requires comments",- "code": 1032,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_REQUIRED",- "content": "Table `userTable` requires columns: created_ts, creator_id, updated_ts, updater_id",- "code": 401,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_NO_NULL",- "content": "`userTable`.`name` cannot have NULL value",- "code": 402,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_NO_NULL",- "content": "`userTable`.`roomId` cannot have NULL value",- "code": 402,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_SET_DEFAULT_FOR_NOT_NULL",- "content": "Column `userTable`.`id` is NOT NULL but doesn't have DEFAULT",- "code": 404,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_COMMENT",- "content": "Column `userTable`.`id` requires comments",- "code": 1032,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_COMMENT",- "content": "Column `userTable`.`name` requires comments",- "code": 1032,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_COMMENT",- "content": "Column `userTable`.`roomId` requires comments",- "code": 1032,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_DISALLOW_SET_CHARSET",- "content": "Disallow set column charset but \"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content(10))) ENGINE = MyISAM COLLATE latin1_bin\" does",- "code": 414,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_CURRENT_TIME_COUNT_LIMIT",- "content": "Table `userTable` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.",- "code": 419,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_REQUIRE_DEFAULT",- "content": "Column `userTable`.`id` doesn't have DEFAULT.",- "code": 420,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_REQUIRE_DEFAULT",- "content": "Column `userTable`.`name` doesn't have DEFAULT.",- "code": 420,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_REQUIRE_DEFAULT",- "content": "Column `userTable`.`roomId` doesn't have DEFAULT.",- "code": 420,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "INDEX_TYPE_NO_BLOB",- "content": "Columns in index must not be BLOB but `userTable`.`content` is blob",- "code": 804,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "SYSTEM_CHARSET_ALLOWLIST",- "content": "\"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content(10))) ENGINE = MyISAM COLLATE latin1_bin\" used disabled charset 'ascii'",- "code": 1001,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "SYSTEM_COLLATION_ALLOWLIST",- "content": "\"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content(10))) ENGINE = MyISAM COLLATE latin1_bin\" used disabled collation 'latin1_bin'",- "code": 1201,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: CREATE TABLE t_auto(auto_id varchar(20) AUTO_INCREMENT PRIMARY KEY COMMENT 'COMMENT') auto_increment = 2 COMMENT 'comment'- result:- - |-- {- "status": "ERROR",- "title": "COLUMN_AUTO_INCREMENT_MUST_INTEGER",- "content": "Auto-increment column `t_auto`.`auto_id` requires integer type",- "code": 410,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "NAMING_COLUMN_AUTO_INCREMENT",- "content": "`t_auto`.`auto_id` mismatches auto_increment column naming convention, naming format should be \"^id$\"",- "code": 307,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_REQUIRED",- "content": "Table `t_auto` requires columns: created_ts, creator_id, id, updated_ts, updater_id",- "code": 401,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_AUTO_INCREMENT_INITIAL_VALUE",- "content": "The initial auto-increment value in table `t_auto` is 2, which doesn't equal 20",- "code": 416,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED",- "content": "Auto-increment column `t_auto`.`auto_id` is not UNSIGNED type",- "code": 417,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "INDEX_PK_TYPE_LIMIT",- "content": "Columns in primary key must be INT/BIGINT but `t_auto`.`auto_id` is varchar(20)",- "code": 803,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: ' DELETE FROM tech_book'- result:- - |-- {- "status": "ERROR",- "title": "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE",- "content": "\"DELETE FROM tech_book\" requires WHERE clause",- "code": 202,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "ERROR",- "title": "STATEMENT_DML_DRY_RUN",- "content": "\"DELETE FROM tech_book;\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",- "code": 208,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "STATEMENT_AFFECTED_ROW_LIMIT",- "content": "\"DELETE FROM tech_book;\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",- "code": 209,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: DELETE FROM tech_book WHERE name like "%abc"- result:- - |-- {- "status": "ERROR",- "title": "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE",- "content": "\"DELETE FROM tech_book WHERE name like \"%abc\"\" uses leading wildcard LIKE",- "code": 204,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "ERROR",- "title": "STATEMENT_DML_DRY_RUN",- "content": "\"DELETE FROM tech_book WHERE name like \"%abc\";\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",- "code": 208,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "STATEMENT_AFFECTED_ROW_LIMIT",- "content": "\"DELETE FROM tech_book WHERE name like \"%abc\";\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",- "code": 209,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: ' INSERT INTO t_copy SELECT * FROM t'- result:- - |-- {- "status": "ERROR",- "title": "STATEMENT_SELECT_NO_SELECT_ALL",- "content": "\"INSERT INTO t_copy SELECT * FROM t\" uses SELECT all",- "code": 203,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "ERROR",- "title": "STATEMENT_DML_DRY_RUN",- "content": "\"INSERT INTO t_copy SELECT * FROM t;\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.t_copy' doesn't exist",- "code": 208,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "STATEMENT_INSERT_ROW_LIMIT",- "content": "\"INSERT INTO t_copy SELECT * FROM t;\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.t_copy' doesn't exist",- "code": 1101,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "STATEMENT_INSERT_MUST_SPECIFY_COLUMN",- "content": "The INSERT statement must specify columns but \"INSERT INTO t_copy SELECT * FROM t;\" does not",- "code": 1107,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: ' INSERT INTO t VALUES (1, 1, now(), 1, now())'- result:- - |-- {- "status": "ERROR",- "title": "STATEMENT_DML_DRY_RUN",- "content": "\"INSERT INTO t VALUES (1, 1, now(), 1, now());\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.t' doesn't exist",- "code": 208,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "STATEMENT_INSERT_MUST_SPECIFY_COLUMN",- "content": "The INSERT statement must specify columns but \"INSERT INTO t VALUES (1, 1, now(), 1, now());\" does not",- "code": 1107,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: DELETE FROM tech_book WHERE id = (SELECT max(id) FROM tech_book WHERE name = 'bytebase')- result:- - |-- {- "status": "ERROR",- "title": "STATEMENT_DML_DRY_RUN",- "content": "\"DELETE FROM tech_book WHERE id = (SELECT max(id) FROM tech_book WHERE name = 'bytebase');\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",- "code": 208,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "STATEMENT_AFFECTED_ROW_LIMIT",- "content": "\"DELETE FROM tech_book WHERE id = (SELECT max(id) FROM tech_book WHERE name = 'bytebase');\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",- "code": 209,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: COMMIT;- result:- - |-- {- "status": "ERROR",- "title": "STATEMENT_DISALLOW_COMMIT",- "content": "Commit is not allowed, related statement: \"COMMIT;\"",- "code": 206,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: CREATE TABLE user(id INT PRIMARY KEY COMMENT 'comment',name VARCHAR(255) NOT NULL DEFAULT '' COMMENT 'comment',room_id INT NOT NULL DEFAULT 0 COMMENT 'comment',creator_id INT NOT NULL DEFAULT 0 COMMENT 'comment',created_ts TIMESTAMP NOT NULL DEFAULT NOW() COMMENT 'comment',updater_id INT NOT NULL DEFAULT 0 COMMENT 'comment',updated_ts TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',INDEX idx_user_name(name),UNIQUE KEY uk_user_id_name(id, name)) ENGINE = INNODB COMMENT 'comment'- result:- - |-- {- "status": "SUCCESS",- "title": "OK",- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE"- }- run: true-- statement: INSERT INTO user(id, name) values (1, 'a'), (2, 'b'), (3, 'c'), (4, 'd'), (5, 'e')- result:- - |-- {- "status": "SUCCESS",- "title": "OK",- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE"- }- run: true-- statement: DELETE FROM user WHERE id < 10- result:- - |-- {- "status": "SUCCESS",- "title": "OK",- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE"- }- run: false-- statement: INSERT INTO user(id, name) values (6, 'f'), (7, 'g'), (8, 'h'), (9, 'i'), (10, 'j')- result:- - |-- {- "status": "SUCCESS",- "title": "OK",- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE"- }- run: true-- statement: DELETE FROM user WHERE id <= 10- result:- - |-- {- "status": "WARNING",- "title": "STATEMENT_AFFECTED_ROW_LIMIT",- "content": "\"DELETE FROM user WHERE id <= 10;\" affected 10 rows (estimated). The count exceeds 5.",- "code": 209,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: |-- INSERT INTO user(id, name) SELECT id, name FROM (SELECT 1 AS id, 'a' AS name WHERE 1=1 UNION ALL- SELECT 2 AS id, 'b' AS name WHERE 1=1 UNION ALL- SELECT 3 AS id, 'c' AS name WHERE 1=1 UNION ALL- SELECT 4 AS id, 'd' AS name WHERE 1=1 UNION ALL- SELECT 5 AS id, 'e' AS name WHERE 1=1 UNION ALL- SELECT 6 AS id, 'f' AS name WHERE 1=1 UNION ALL- SELECT 7 AS id, 'g' AS name WHERE 1=1 UNION ALL- SELECT 8 AS id, 'h' AS name WHERE 1=1 UNION ALL- SELECT 9 AS id, 'i' AS name WHERE 1=1 UNION ALL- SELECT 10 AS id, 'j' AS name WHERE 1=1) value_table WHERE 1=1- result:- - |-- {- "status": "WARNING",- "title": "STATEMENT_INSERT_ROW_LIMIT",- "content": "\"INSERT INTO user(id, name) SELECT id, name FROM (SELECT 1 AS id, 'a' AS name WHERE 1=1 UNION ALL\n SELECT 2 AS id, 'b' AS name WHERE 1=1 UNION ALL\n SELECT 3 AS id, 'c' AS name WHERE 1=1 UNION ALL\n SELECT 4 AS id, 'd' AS name WHERE 1=1 UNION ALL\n SELECT 5 AS id, 'e' AS name WHERE 1=1 UNION ALL\n SELECT 6 AS id, 'f' AS name WHERE 1=1 UNION ALL\n SELECT 7 AS id, 'g' AS name WHERE 1=1 UNION ALL\n SELECT 8 AS id, 'h' AS name WHERE 1=1 UNION ALL\n SELECT 9 AS id, 'i' AS name WHERE 1=1 UNION ALL\n SELECT 10 AS id, 'j' AS name WHERE 1=1) value_table WHERE 1=1;\" inserts 10 rows. The count exceeds 5.",- "code": 1101,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: INSERT INTO user(id, name) SELECT id, name FROM user WHERE id=1 LIMIT 1- result:- - |-- {- "status": "WARNING",- "title": "STATEMENT_DISALLOW_LIMIT",- "content": "LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but \"INSERT INTO user(id, name) SELECT id, name FROM user WHERE id=1 LIMIT 1\" uses",- "code": 1103,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: ' ALTER TABLE user PARTITION BY HASH(id) PARTITIONS 8;'- result:- - |-- {- "status": "WARNING",- "title": "TABLE_DISALLOW_PARTITION",- "content": "Table partition is forbidden, but \"ALTER TABLE user PARTITION BY HASH(id) PARTITIONS 8;\" creates",- "code": 608,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: |-- ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;- ALTER TABLE user ADD COLUMN c_column int NOT NULL DEFAULT 0 COMMENT 'comment';- result:- - |-- {- "status": "WARNING",- "title": "STATEMENT_MERGE_ALTER_TABLE",- "content": "There are 2 statements to modify table `user`",- "code": 207,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 2- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_DISALLOW_CHANGE_TYPE",- "content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" changes column type",- "code": 403,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_DISALLOW_CHANGE",- "content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" contains CHANGE COLUMN statement",- "code": 406,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "COLUMN_DISALLOW_CHANGING_ORDER",- "content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" changes column order",- "code": 407,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "SCHEMA_BACKWARD_COMPATIBILITY",- "content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" may cause incompatibility with the existing data and code",- "code": 111,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: false-- statement: ' DROP TABLE user;'- result:- - |-- {- "status": "ERROR",- "title": "TABLE_DROP_NAMING_CONVENTION",- "content": "`user` mismatches drop table naming convention, naming format should be \"_delete$\"",- "code": 603,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- - |-- {- "status": "WARNING",- "title": "SCHEMA_BACKWARD_COMPATIBILITY",- "content": "\"DROP TABLE user;\" may cause incompatibility with the existing data and code",- "code": 103,- "target": "instances/instance-96a5f914-2/databases/testsqlreview",- "type": "STATEMENT_ADVISE",- "sqlReviewReport": {- "startPosition": {- "line": 1- }- }- }- run: falsediff --git a/backend/tests/test-data/sql_review_pg.yaml b/backend/tests/test-data/sql_review_pg.yamlindex f1e36247d1..0e90e31002 100644--- a/backend/tests/test-data/sql_review_pg.yaml+++ b/backend/tests/test-data/sql_review_pg.yaml@@ -71,6 +71,18 @@}}}+ - |-+ {+ "status": "WARNING",+ "title": "STATEMENT_DML_DRY_RUN",+ "content": "\"DELETE FROM t\" dry runs failed: ERROR: relation \"t\" does not exist (SQLSTATE 42P01)",+ "code": 208,+ "sqlReviewReport": {+ "startPosition": {+ "line": 1+ }+ }+ }run: false- statement: DELETE FROM t WHERE a like '%abc'result:@@ -86,21 +98,47 @@}}}+ - |-+ {+ "status": "WARNING",+ "title": "STATEMENT_DML_DRY_RUN",+ "content": "\"DELETE FROM t WHERE a like '%abc'\" dry runs failed: ERROR: relation \"t\" does not exist (SQLSTATE 42P01)",+ "code": 208,+ "sqlReviewReport": {+ "startPosition": {+ "line": 1+ }+ }+ }run: false- statement: DELETE FROM t WHERE a = (SELECT max(id) FROM "user" WHERE name = 'bytebase')result:- |-{- "status": "SUCCESS",- "title": "OK"+ "status": "WARNING",+ "title": "STATEMENT_DML_DRY_RUN",+ "content": "\"DELETE FROM t WHERE a = (SELECT max(id) FROM \"user\" WHERE name = 'bytebase')\" dry runs failed: ERROR: relation \"t\" does not exist (SQLSTATE 42P01)",+ "code": 208,+ "sqlReviewReport": {+ "startPosition": {+ "line": 1+ }+ }}run: false- statement: INSERT INTO t VALUES (1), (2)result:- |-{- "status": "SUCCESS",- "title": "OK"+ "status": "WARNING",+ "title": "STATEMENT_DML_DRY_RUN",+ "content": "\"INSERT INTO t VALUES (1), (2)\" dry runs failed: ERROR: relation \"t\" does not exist (SQLSTATE 42P01)",+ "code": 208,+ "sqlReviewReport": {+ "startPosition": {+ "line": 1+ }+ }}run: false- statement: |-diff --git a/backend/tests/transaction_mode_test.go b/backend/tests/transaction_mode_test.godeleted file mode 100644index 92b943e08c..0000000000--- a/backend/tests/transaction_mode_test.go+++ /dev/null@@ -1,293 +0,0 @@-package tests--import (- "context"- "fmt"- "testing"- "time"-- "github.com/stretchr/testify/require"-- "github.com/bytebase/bytebase/backend/common/testcontainer"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- v1pb "github.com/bytebase/bytebase/backend/generated-go/v1"- "github.com/bytebase/bytebase/backend/plugin/db"-)--// TestTransactionMode tests the configurable transaction mode feature across different database engines.-//-//nolint:tparallel // Each subtest drives one engine container through both transaction modes in order.-func TestTransactionMode(t *testing.T) {- t.Parallel()- ctx := context.Background()-- tests := []struct {- name string- dbType storepb.Engine- containerFunc func(context.Context, *testing.T) *testcontainer.Container- setupScript string- testScriptOn string- testScriptOff string- expectRollbackOn bool // Whether we expect rollback for transaction mode on- skipTransaction bool // Some engines don't support transactions well- }{- {- name: "MySQL",- dbType: storepb.Engine_MYSQL,- containerFunc: func(ctx context.Context, t *testing.T) *testcontainer.Container {- container, err := testcontainer.GetTestMySQLContainer(ctx)- if err != nil {- t.Fatalf("Failed to get MySQL container: %v", err)- }- return container- },- setupScript: `- CREATE TABLE test_table (- id INT PRIMARY KEY,- value VARCHAR(100)- );- `,- testScriptOn: `-- txn-mode = on- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- testScriptOff: `-- txn-mode = off- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- expectRollbackOn: true,- },- {- name: "PostgreSQL",- dbType: storepb.Engine_POSTGRES,- containerFunc: func(ctx context.Context, t *testing.T) *testcontainer.Container {- return testcontainer.GetTestPgContainer(ctx, t)- },- setupScript: `- CREATE TABLE test_table (- id INTEGER PRIMARY KEY,- value VARCHAR(100)- );- `,- testScriptOn: `-- txn-mode = on- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- testScriptOff: `-- txn-mode = off- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- expectRollbackOn: true,- },- {- name: "Oracle",- dbType: storepb.Engine_ORACLE,- containerFunc: func(ctx context.Context, t *testing.T) *testcontainer.Container {- return testcontainer.GetTestOracleContainer(ctx, t)- },- setupScript: `- CREATE TABLE test_table (- id NUMBER PRIMARY KEY,- value VARCHAR2(100)- )- `,- testScriptOn: `-- txn-mode = on- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- testScriptOff: `-- txn-mode = off- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- expectRollbackOn: true,- },- {- name: "SQL Server",- dbType: storepb.Engine_MSSQL,- containerFunc: func(ctx context.Context, t *testing.T) *testcontainer.Container {- return testcontainer.GetTestMSSQLContainer(ctx, t)- },- setupScript: `- CREATE TABLE test_table (- id INT PRIMARY KEY,- value VARCHAR(100)- );- `,- testScriptOn: `-- txn-mode = on- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- testScriptOff: `-- txn-mode = off- INSERT INTO test_table (id, value) VALUES (1, 'test1');- INSERT INTO test_table (id, value) VALUES (2, 'test2');- INSERT INTO test_table (id, value) VALUES (1, 'duplicate'); -- This will fail- `,- expectRollbackOn: true,- },- }-- for _, test := range tests {- t.Run(test.name, func(t *testing.T) {- // Skip transaction tests for engines that don't support them well- if test.skipTransaction {- t.Skip("Skipping transaction test for engine with limited transaction support")- }-- // Create container- container := test.containerFunc(ctx, t)- defer container.Close(ctx)-- // Create test database if needed- testDBName := fmt.Sprintf("txnmode_test_%d", time.Now().UnixNano())- if test.dbType == storepb.Engine_MYSQL {- _, err := container.GetDB().Exec(fmt.Sprintf("CREATE DATABASE IF NOT EXISTS %s", testDBName))- require.NoError(t, err)- }-- // Get database connection- driver, err := getDriver(ctx, test.dbType, container, testDBName)- require.NoError(t, err)- defer driver.Close(ctx)-- // Setup test table- _, err = driver.Execute(ctx, test.setupScript, db.ExecuteOptions{})- require.NoError(t, err)-- // Test transaction mode ON - expect rollback on failure- t.Run("TransactionModeOn", func(t *testing.T) {- // Execute script with transaction mode ON- _, err := driver.Execute(ctx, test.testScriptOn, db.ExecuteOptions{})- require.Error(t, err, "Expected error due to duplicate key")-- // Check if rollback occurred- rowCount := getRowCount(ctx, t, driver, test.dbType)- if test.expectRollbackOn {- require.Equal(t, 0, rowCount, "Expected 0 rows due to rollback")- } else {- require.Greater(t, rowCount, 0, "Expected some rows even with error")- }-- // Cleanup- cleanupTable(ctx, t, driver, test.dbType)- })-- // Test transaction mode OFF - expect partial success- t.Run("TransactionModeOff", func(t *testing.T) {- // Execute script with transaction mode OFF- _, err := driver.Execute(ctx, test.testScriptOff, db.ExecuteOptions{})- require.Error(t, err, "Expected error due to duplicate key")-- // Check if partial success occurred (first 2 inserts should succeed)- rowCount := getRowCount(ctx, t, driver, test.dbType)- require.Equal(t, 2, rowCount, "Expected 2 rows from successful inserts before failure")-- // Cleanup- cleanupTable(ctx, t, driver, test.dbType)- })- })- }-}--// Helper functions-func getDriver(ctx context.Context, engine storepb.Engine, container *testcontainer.Container, testDBName string) (db.Driver, error) {- var dbDatabase string- switch engine {- case storepb.Engine_MYSQL:- dbDatabase = testDBName- case storepb.Engine_POSTGRES:- dbDatabase = "postgres"- case storepb.Engine_ORACLE:- dbDatabase = "FREEPDB1"- case storepb.Engine_MSSQL:- dbDatabase = "master"- default:- dbDatabase = ""- }-- config := db.ConnectionConfig{- DataSource: &storepb.DataSource{- Host: container.GetHost(),- Port: container.GetPort(),- Username: "root",- Database: dbDatabase,- },- ConnectionContext: db.ConnectionContext{- DatabaseName: dbDatabase,- },- Password: "root",- }-- // Special handling for different engines based on testcontainer setup- switch engine {- case storepb.Engine_MYSQL:- config.DataSource.Username = "root"- config.Password = "root-password"- case storepb.Engine_POSTGRES:- config.DataSource.Username = "postgres"- config.Password = "root-password"- case storepb.Engine_ORACLE:- config.DataSource.Username = "testuser"- config.Password = "testpass"- config.DataSource.Database = ""- config.ConnectionContext.DatabaseName = ""- // Set service name for Oracle- config.DataSource.ServiceName = "FREEPDB1"- case storepb.Engine_MSSQL:- config.DataSource.Username = "sa"- config.Password = "Test123!"- default:- // Use default config for other engines- }-- driver, err := db.Open(ctx, engine, config)- if err != nil {- return nil, err- }-- return driver, nil-}--func getRowCount(ctx context.Context, t *testing.T, driver db.Driver, _ storepb.Engine) int {- query := "SELECT COUNT(*) FROM test_table"-- // Use QueryConn to get results- conn, err := driver.GetDB().Conn(ctx)- require.NoError(t, err)- defer conn.Close()-- results, err := driver.QueryConn(ctx, conn, query, db.QueryContext{})- require.NoError(t, err)- require.Len(t, results, 1)- require.Len(t, results[0].Rows, 1)- require.Len(t, results[0].Rows[0].Values, 1)-- // Extract count value- switch v := results[0].Rows[0].Values[0].Kind.(type) {- case *v1pb.RowValue_Int32Value:- return int(v.Int32Value)- case *v1pb.RowValue_Int64Value:- return int(v.Int64Value)- case *v1pb.RowValue_StringValue:- // Some databases return count as string- count := 0- if _, err := fmt.Sscanf(v.StringValue, "%d", &count); err != nil {- t.Fatalf("Failed to parse count from string: %v", err)- }- return count- default:- t.Fatalf("Unexpected count value type: %T", v)- return 0- }-}--func cleanupTable(ctx context.Context, t *testing.T, driver db.Driver, _ storepb.Engine) {- _, err := driver.Execute(ctx, "DELETE FROM test_table", db.ExecuteOptions{})- require.NoError(t, err)-}diff --git a/docs/design/backend-test-execution-time.md b/docs/design/backend-test-execution-time.mdindex 84750d4839..35ac660e28 100644--- a/docs/design/backend-test-execution-time.md+++ b/docs/design/backend-test-execution-time.md@@ -132,11 +132,16 @@ The standing order, by what is left rather than by number:| | Effort | Worth || --- | --- | --- |-| 1 | 5, drop the duplicated MySQL bodies | ~320 s of work, ~2 min of suite wall |-| 2 | `TestWebhookIntegration` | 148 s in one test, now `backend/tests`'s floor |-| 3 | 7, engine conformance to omni | 164 s, behind a large ownership blocker |-| 4 | 6, seams instead of containers | seconds; do it for the tests, not the clock |-| 5 | 4, isolate per project | a memory ceiling, not a speed play |+| 1 | 7, engine conformance to omni | 164 s, behind a large ownership blocker |+| 2 | 6, seams instead of containers | seconds; do it for the tests, not the clock |+| 3 | 4, isolate per project | a memory ceiling, not a speed play |++Two entries have left this list. Effort 5 is done — and was worth less than the+~320 s it was sized at, because a third of that number was+`TestSQLReviewForMySQL`, which was not the duplicate the sizing assumed; see its+section. `TestWebhookIntegration` was second at 148 s until #21355 fixed the+scheduler stall underneath it and took it to 45 s, which is the largest single+saving on this page and came from a production bug rather than a test change.### [✓] 1. Close idle connections before shutting the server down@@ -291,11 +296,11 @@ subtests in order, which is `backend/tests`'s existing`//nolint:tparallel // Subtests share one server lifecycle.` case; each nowcarries that directive with its own reason. Note what this does not cost:the parent stays parallel with the rest of the package either way, and that is-where the entire saving came from. Making `TestTransactionMode`'s four engine-subtests parallel would buy nothing, because the package floor is-`TestWebhookIntegration`, not the sum of everything else.+where the entire saving came from.-**`TestWebhookIntegration` is now the package floor.** At 148 s it is most of the+**`TestWebhookIntegration` was the package floor at 148 s.** #21355 then took it+to 45 s by fixing the task run scheduler stall, so it no longer dominates; the+paragraph below described the state before that landed. At 148 s it was most of the173 s, and the rest of the package finishes around it. It is the one place leftin `backend/tests` where a single test is worth attacking on its own.@@ -342,11 +347,63 @@ each test grants to its own principal.`TestWebhookIntegration` needs separate attention: 144 s, the slowest test inthe repo, 24 subtests behind one boot with several fixed sleeps.-### 5. Postgres only for `backend/store` and `backend/tests`--**Up to 320 s inside `backend/tests`**, of which 115 s is container starts and-the rest is the duplicated test bodies. `TestSQLReviewForMySQL` costs 52.7 s-where `TestSQLReviewForPostgreSQL` costs 17.9 s for the same assertion.+### [✓] 5. Postgres only for `backend/store` and `backend/tests`++**Done, and the headline example in the original sizing was wrong.** This section+said `TestSQLReviewForMySQL` cost 52.7 s where `TestSQLReviewForPostgreSQL` cost+17.9 s "for the same assertion". They were not the same assertion:+`sql_review_mysql.yaml` held 21 cases against `sql_review_pg.yaml`'s 9. Deleting+it as a duplicate would have dropped real rule coverage.++The principle that resolved it is sharper than the one written here.+**`backend/tests` tests workflows; engines belong to the layer that owns them.**+Sorting the expensive tests by that rule gave four outcomes rather than one:++- **Same workflow run twice.** Five tests had literally mirrored cases —+ "MySQL - Second statement fails" beside "PostgreSQL - Second statement fails" —+ for behavior that is ours, not a dialect's. MySQL arm dropped, one unique case+ ported: **127.9 s → 59.9 s**.+- **MySQL-only, engine incidental.** Three tests about data source resolution and+ masking, ported to Postgres. The translation was not mechanical — Postgres+ grants are per object, `BIN_TO_UUID` became a `uuid` cast, and the catalog+ needed a `public` schema.+- **Engine wearing workflow clothing.** `TestSQLReviewForMySQL` was rule coverage+ in the wrong place: of the 41 rules its fixture asserts, 39 have a file under+ `plugin/advisor/mysql/test` carrying real `want:` expectations, and+ `TestMySQLRules` drives ~60 rules through them with no container, in 2.3 s.+ **Two did not, and checking that the file merely exists would have missed it.**+ `RunSQLReviewRuleTest` builds its context with `Driver: nil`, so the two rules+ that need a live `EXPLAIN` — `STATEMENT_AFFECTED_ROW_LIMIT` and+ `STATEMENT_DML_DRY_RUN` — have yaml files holding statements and no+ expectations at all. The first is covered anyway by two driver-backed tests+ against a fake `database/sql` EXPLAIN driver; the second was not, so deleting+ the workflow test would have dropped its only coverage, and+ `TestMySQLDMLDryRunAdvisor` was written against that same fake driver to+ replace it. Deleted, with+ `TestSyncerForMySQL` (its Postgres twin sits in the same file) and+ `TestGetLatestSchema`'s MySQL arm (it asserted a literal dump, including MySQL's+ `SET @OLD_UNIQUE_CHECKS` preamble). `TestTransactionMode` is deleted, 41 s. It had+ four engine cases whose expectations were identical — `expectRollbackOn` was `true`+ in all four and `skipTransaction` was never set, so both fields that existed to+ express engine variation were dead, along with two unreachable branches.++ **This leaves a known gap, recorded here rather than left silent.** Nothing now+ covers the execution half of the `-- txn-mode` directive:+ `executeInTransactionMode` and `executeInAutoCommitMode` appear in no test, so+ `txn-mode = on` could stop wrapping and every test would stay green. Parsing is+ still covered by `plugin/parser/base`. Anyone reintroducing coverage should+ guard the mode switch on one engine, and the case actually worth an engine+ matrix is DDL inside `txn-mode = on`, where MySQL and Oracle implicitly commit+ and defeat it — which is the reason the directive exists, and which no version+ of the deleted test ever covered.++- **Engine is the workflow.** `TestGhostSchemaUpdate` and+ `TestGitOpsRolloutGhostDirective` keep MySQL, and now say why in a comment:+ gh-ost is MySQL-only. `TestActionCheckCommand`'s database-group subtest keeps it+ too — the port was tried and reverted, because the declarative check returns+ three errors against the same schema on Postgres. Worth chasing separately.++MySQL in `backend/tests` is now those three tests and nothing else.Unlike effort 4, this one did not deflate. Deleting a test removes work ratherthan moving it, and the run is now bound by the sum term, so the 320 s converts@@ -362,30 +419,16 @@ packages that keep one, the engine is Postgres: engine dialects and DDL fidelitybelong in omni. The root `AGENTS.md` carries that second half of the rule today,in the words "test API and workflow behavior against Postgres only".-`docker events` recorded 11 MySQL containers from `backend/tests`. The-candidates, one container each:--```-TestSQLReviewForMySQL TestSyncerForMySQL-TestSQLExport TestSQLAdminQuery-TestSensitiveData TestAdminQueryAffectedRows-TestSQLQueryStopOnError TestSQLAdminExecuteStopOnError-TestSQLExportDataSourceResolution TestSQLQueryDataSourceResolution-TestActionCheckCommand TestGetLatestSchema (MySQL arm of an engine switch)-```--Where a Postgres equivalent proves the same workflow, delete the MySQL copy and-save the whole test. Where the MySQL path is the only coverage, port it to-Postgres and save only the container difference — which is why the payoff is a-ceiling, not a promise.--Three keep their engine. Each needs a comment saying why:+`docker events` recorded 11 MySQL containers from `backend/tests` when this was+written. Each of those twelve candidate tests is accounted for above; the one+that is not is `TestActionCheckCommand`, which keeps its container.-- `TestGhostSchemaUpdate` and `TestGitOpsRolloutGhostDirective` — gh-ost is- MySQL-only.-- `TestTransactionMode` — per-engine transaction semantics are the behavior- under test. It covers MySQL, Postgres, Oracle and MSSQL in one table, and- boots no server.+The original plan here said "where a Postgres equivalent proves the same+workflow, delete the MySQL copy". That held for `TestSyncerForMySQL`, whose twin+was already in the same file. It did not hold for `TestSQLReviewForMySQL`: the+copy was not equivalent, and the thing that made it deletable was finding the+coverage a layer down rather than a layer across. **Check the layer below before+calling a test a duplicate.**### 6. Seams instead of containers