Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat(review): head a review result with its priority, rule, and codes (#21896)
rebeliceacf09dcc41b0
diff --git a/backend/api/mcp/gen/openapi.yaml b/backend/api/mcp/gen/openapi.yamlindex 43fbbc78d3..f366f3ea66 100644--- a/backend/api/mcp/gen/openapi.yaml+++ b/backend/api/mcp/gen/openapi.yaml@@ -15280,6 +15280,15 @@ components:description: |-The ReviewRunCompletion.attempt of the run that posted the result. Aresult a later run reports again keeps its thread and its attempt.+ codes:+ type: array+ items:+ type: string+ title: codes+ description: |-+ The conditions a RULE result reports, as finding codes such as+ "WT101", one per reason. A code names the same condition on every+ engine. Empty for other reviewers.title: ReviewMetadataadditionalProperties: falsedescription: What a review result carries beyond its text.diff --git a/backend/api/v1/audit_redact_inventory_test.go b/backend/api/v1/audit_redact_inventory_test.goindex b7e5fa6c8b..3b1d37545e 100644--- a/backend/api/v1/audit_redact_inventory_test.go+++ b/backend/api/v1/audit_redact_inventory_test.go@@ -578,6 +578,7 @@ var auditRecordedFields = []string{"bytebase.v1.IssueComment.IssueUpdate.to_description","bytebase.v1.IssueComment.IssueUpdate.to_labels","bytebase.v1.IssueComment.IssueUpdate.to_title",+ "bytebase.v1.IssueComment.ReviewMetadata.codes","bytebase.v1.IssueComment.ReviewMetadata.targets","bytebase.v1.IssueComment.comment","bytebase.v1.IssueComment.creator",diff --git a/backend/api/v1/issue_service_converter.go b/backend/api/v1/issue_service_converter.goindex 8b767205ad..8d1128b502 100644--- a/backend/api/v1/issue_service_converter.go+++ b/backend/api/v1/issue_service_converter.go@@ -193,6 +193,7 @@ func convertToIssueCommentReviewMetadata(metadata *storepb.IssueCommentPayload_RTargets: metadata.Targets,Superseded: metadata.Superseded,Attempt: metadata.Attempt,+ Codes: metadata.Codes,}}diff --git a/backend/api/v1/org_policy_service_review_rule_test.go b/backend/api/v1/org_policy_service_review_rule_test.goindex ac589b7bb9..08db587221 100644--- a/backend/api/v1/org_policy_service_review_rule_test.go+++ b/backend/api/v1/org_policy_service_review_rule_test.go@@ -48,6 +48,7 @@ func TestConvertToIssueCommentReviewResult(t *testing.T) {Priority: storepb.IssueCommentPayload_ReviewMetadata_P1,Targets: []string{"instances/i/databases/a", "instances/i/databases/b"},Superseded: true,+ Codes: []string{"WH101"},},},})@@ -58,6 +59,7 @@ func TestConvertToIssueCommentReviewResult(t *testing.T) {Priority: v1pb.IssueComment_ReviewMetadata_P1,Targets: []string{"instances/i/databases/a", "instances/i/databases/b"},Superseded: true,+ Codes: []string{"WH101"},}, got.ReviewMetadata)person := convertToIssueComment("projects/p/issues/101", &store.IssueCommentMessage{diff --git a/backend/generated-go/store/issue_comment.pb.go b/backend/generated-go/store/issue_comment.pb.goindex 5ce6fddc0e..9770dbfb41 100644--- a/backend/generated-go/store/issue_comment.pb.go+++ b/backend/generated-go/store/issue_comment.pb.go@@ -595,7 +595,10 @@ type IssueCommentPayload_ReviewMetadata struct {Fingerprint string `protobuf:"bytes,6,opt,name=fingerprint,proto3" json:"fingerprint,omitempty"`// The review_run.attempt of the run that posted the result. A result// a later run reports again keeps its attempt.- Attempt int64 `protobuf:"varint,7,opt,name=attempt,proto3" json:"attempt,omitempty"`+ Attempt int64 `protobuf:"varint,7,opt,name=attempt,proto3" json:"attempt,omitempty"`+ // The conditions a RULE result reports, as omni finding codes such as+ // "WT101", one per reason. Empty for other reviewers.+ Codes []string `protobuf:"bytes,8,rep,name=codes,proto3" json:"codes,omitempty"`unknownFields protoimpl.UnknownFieldssizeCache protoimpl.SizeCache}@@ -679,6 +682,13 @@ func (x *IssueCommentPayload_ReviewMetadata) GetAttempt() int64 {return 0}+func (x *IssueCommentPayload_ReviewMetadata) GetCodes() []string {+ if x != nil {+ return x.Codes+ }+ return nil+}+// StatementAnchor records the anchored statement revision and range.// The SQL excerpt and current/changed/unavailable state are computed on// read against the anchored sheet and the current plan, not stored.@@ -763,7 +773,7 @@ var File_store_issue_comment_proto protoreflect.FileDescriptorconst file_store_issue_comment_proto_rawDesc = "" +"\n" +- "\x19store/issue_comment.proto\x12\x0ebytebase.store\x1a\x14store/approval.proto\x1a\x12store/common.proto\x1a\x11store/issue.proto\x1a\x10store/plan.proto\x1a\x17store/review_rule.proto\x1a\x16store/review_run.proto\"\xd1\x11\n" ++ "\x19store/issue_comment.proto\x12\x0ebytebase.store\x1a\x14store/approval.proto\x1a\x12store/common.proto\x1a\x11store/issue.proto\x1a\x10store/plan.proto\x1a\x17store/review_rule.proto\x1a\x16store/review_run.proto\"\xe7\x11\n" +"\x13IssueCommentPayload\x12\x18\n" +"\acomment\x18\x01 \x01(\tR\acomment\x12J\n" +"\bapproval\x18\x02 \x01(\v2,.bytebase.store.IssueCommentPayload.ApprovalH\x00R\bapproval\x12T\n" +@@ -808,7 +818,7 @@ const file_store_issue_comment_proto_rawDesc = "" +"PlanUpdate\x12>\n" +"\n" +"from_specs\x18\x01 \x03(\v2\x1f.bytebase.store.PlanConfig.SpecR\tfromSpecs\x12:\n" +- "\bto_specs\x18\x02 \x03(\v2\x1f.bytebase.store.PlanConfig.SpecR\atoSpecs\x1a\x95\x03\n" ++ "\bto_specs\x18\x02 \x03(\v2\x1f.bytebase.store.PlanConfig.SpecR\atoSpecs\x1a\xab\x03\n" +"\x0eReviewMetadata\x129\n" +"\brun_type\x18\x01 \x01(\x0e2\x1e.bytebase.store.ReviewRun.TypeR\arunType\x12;\n" +"\trule_type\x18\x02 \x01(\x0e2\x1e.bytebase.store.ReviewRuleTypeR\bruleType\x12W\n" +@@ -818,7 +828,8 @@ const file_store_issue_comment_proto_rawDesc = "" +"superseded\x18\x05 \x01(\bR\n" +"superseded\x12 \n" +"\vfingerprint\x18\x06 \x01(\tR\vfingerprint\x12\x18\n" +- "\aattempt\x18\a \x01(\x03R\aattempt\"<\n" ++ "\aattempt\x18\a \x01(\x03R\aattempt\x12\x14\n" ++ "\x05codes\x18\b \x03(\tR\x05codes\"<\n" +"\bPriority\x12\x18\n" +"\x14PRIORITY_UNSPECIFIED\x10\x00\x12\x06\n" +"\x02P0\x10\x01\x12\x06\n" +diff --git a/backend/generated-go/store/issue_comment_equal.pb.go b/backend/generated-go/store/issue_comment_equal.pb.goindex e583217e22..8a704b1ddd 100644--- a/backend/generated-go/store/issue_comment_equal.pb.go+++ b/backend/generated-go/store/issue_comment_equal.pb.go@@ -154,6 +154,14 @@ func (x *IssueCommentPayload_ReviewMetadata) Equal(y *IssueCommentPayload_Reviewif x.Attempt != y.Attempt {return false}+ if len(x.Codes) != len(y.Codes) {+ return false+ }+ for i := 0; i < len(x.Codes); i++ {+ if x.Codes[i] != y.Codes[i] {+ return false+ }+ }return true}diff --git a/backend/generated-go/v1/issue_service.pb.go b/backend/generated-go/v1/issue_service.pb.goindex 39966d21ea..1629df1b1b 100644--- a/backend/generated-go/v1/issue_service.pb.go+++ b/backend/generated-go/v1/issue_service.pb.go@@ -2481,7 +2481,11 @@ type IssueComment_ReviewMetadata struct {Superseded bool `protobuf:"varint,5,opt,name=superseded,proto3" json:"superseded,omitempty"`// The ReviewRunCompletion.attempt of the run that posted the result. A// result a later run reports again keeps its thread and its attempt.- Attempt int64 `protobuf:"varint,6,opt,name=attempt,proto3" json:"attempt,omitempty"`+ Attempt int64 `protobuf:"varint,6,opt,name=attempt,proto3" json:"attempt,omitempty"`+ // The conditions a RULE result reports, as finding codes such as+ // "WT101", one per reason. A code names the same condition on every+ // engine. Empty for other reviewers.+ Codes []string `protobuf:"bytes,7,rep,name=codes,proto3" json:"codes,omitempty"`unknownFields protoimpl.UnknownFieldssizeCache protoimpl.SizeCache}@@ -2558,6 +2562,13 @@ func (x *IssueComment_ReviewMetadata) GetAttempt() int64 {return 0}+func (x *IssueComment_ReviewMetadata) GetCodes() []string {+ if x != nil {+ return x.Codes+ }+ return nil+}+// Approval event information.type IssueComment_Approval struct {state protoimpl.MessageState `protogen:"open.v1"`@@ -3016,7 +3027,7 @@ const file_v1_issue_service_proto_rawDesc = "" +"\rissue_comment\x18\x02 \x01(\v2\x19.bytebase.v1.IssueCommentR\fissueComment\x12@\n" +"\vupdate_mask\x18\x03 \x01(\v2\x1a.google.protobuf.FieldMaskB\x03\xe0A\x02R\n" +"updateMask\x12#\n" +- "\rallow_missing\x18\x04 \x01(\bR\fallowMissing\"\xcc\x12\n" ++ "\rallow_missing\x18\x04 \x01(\bR\fallowMissing\"\xe2\x12\n" +"\fIssueComment\x12\x12\n" +"\x04name\x18\x01 \x01(\tR\x04name\x12#\n" +"\acomment\x18\x02 \x01(\tB\t\xbaH\x06r\x04\x18\x80\x80\x04R\acomment\x12\x18\n" +@@ -3035,7 +3046,7 @@ const file_v1_issue_service_proto_rawDesc = "" +"\vplan_update\x18\f \x01(\v2$.bytebase.v1.IssueComment.PlanUpdateH\x00R\n" +"planUpdate\x12Y\n" +"\x11review_submission\x18\r \x01(\v2*.bytebase.v1.IssueComment.ReviewSubmissionH\x00R\x10reviewSubmission\x12c\n" +- "\x15review_run_completion\x18\x12 \x01(\v2-.bytebase.v1.IssueComment.ReviewRunCompletionH\x00R\x13reviewRunCompletion\x1a\xe3\x02\n" ++ "\x15review_run_completion\x18\x12 \x01(\v2-.bytebase.v1.IssueComment.ReviewRunCompletionH\x00R\x13reviewRunCompletion\x1a\xf9\x02\n" +"\x0eReviewMetadata\x126\n" +"\brun_type\x18\x01 \x01(\x0e2\x1b.bytebase.v1.ReviewRun.TypeR\arunType\x128\n" +"\trule_type\x18\x02 \x01(\x0e2\x1b.bytebase.v1.ReviewRuleTypeR\bruleType\x12M\n" +@@ -3044,7 +3055,8 @@ const file_v1_issue_service_proto_rawDesc = "" +"\n" +"superseded\x18\x05 \x01(\bR\n" +"superseded\x12\x18\n" +- "\aattempt\x18\x06 \x01(\x03R\aattempt\"<\n" ++ "\aattempt\x18\x06 \x01(\x03R\aattempt\x12\x14\n" ++ "\x05codes\x18\a \x03(\tR\x05codes\"<\n" +"\bPriority\x12\x18\n" +"\x14PRIORITY_UNSPECIFIED\x10\x00\x12\x06\n" +"\x02P0\x10\x01\x12\x06\n" +diff --git a/backend/generated-go/v1/issue_service_equal.pb.go b/backend/generated-go/v1/issue_service_equal.pb.goindex f02e585d45..af3338285b 100644--- a/backend/generated-go/v1/issue_service_equal.pb.go+++ b/backend/generated-go/v1/issue_service_equal.pb.go@@ -523,6 +523,14 @@ func (x *IssueComment_ReviewMetadata) Equal(y *IssueComment_ReviewMetadata) boolif x.Attempt != y.Attempt {return false}+ if len(x.Codes) != len(y.Codes) {+ return false+ }+ for i := 0; i < len(x.Codes); i++ {+ if x.Codes[i] != y.Codes[i] {+ return false+ }+ }return true}diff --git a/backend/runner/reviewrun/rule_review.go b/backend/runner/reviewrun/rule_review.goindex f2ea89802a..556a99f29e 100644--- a/backend/runner/reviewrun/rule_review.go+++ b/backend/runner/reviewrun/rule_review.go@@ -124,8 +124,8 @@ func rulePriority(rule storepb.ReviewRuleType) storepb.IssueCommentPayload_Revie// reviewResultComments converts a unit's findings into the review result// comments to post: one OPEN root per finding, anchored to the finding's// range on the spec's sheet, naming the rule, its priority, every target the-// finding applies to, and its fingerprint. A finding for a rule this server-// does not know is dropped, as the contract says.+// finding applies to, its codes, and its fingerprint. A finding for a rule+// this server does not know is dropped, as the contract says.func reviewResultComments(projectID string, issueUID int64, unit *reviewUnit, sql string, result *review.Result) []*store.IssueCommentMessage {text := review.Index(sql)occurrences := make(map[string]int)@@ -143,9 +143,13 @@ func reviewResultComments(projectID string, issueUID int64, unit *reviewUnit, sqtargets = append(targets, unit.Targets[i].Check.Target)}slices.Sort(targets)+ codes := make([]string, 0, len(finding.Codes))+ for _, code := range finding.Codes {+ codes = append(codes, string(code))+ }// Identical statements give equal keys; their order tells them apart.body, at := findingPlace(sql, result, finding)- key := findingKey(unit, rule, finding.Codes, body, at, targets)+ key := findingKey(unit, rule, codes, body, at, targets)occurrences[key]++comments = append(comments, &store.IssueCommentMessage{ProjectID: projectID,@@ -159,6 +163,7 @@ func reviewResultComments(projectID string, issueUID int64, unit *reviewUnit, sqPriority: rulePriority(rule),Targets: targets,Fingerprint: fmt.Sprintf("%s/%d", key, occurrences[key]),+ Codes: codes,},},})@@ -169,13 +174,9 @@ func reviewResultComments(projectID string, issueUID int64, unit *reviewUnit, sq// findingKey identifies a finding by what was judged: the unit, the rule, the// codes of the conditions it reports, where it stands in its statement, and// its databases. The message is left out, so rewording it keeps the finding.-func findingKey(unit *reviewUnit, rule storepb.ReviewRuleType, codes []review.FindingCode, body, at string, targets []string) string {- names := make([]string, 0, len(codes))- for _, code := range codes {- names = append(names, string(code))- }+func findingKey(unit *reviewUnit, rule storepb.ReviewRuleType, codes []string, body, at string, targets []string) string {h := sha256.New()- for _, field := range append([]string{unit.SpecID, unit.Engine.String(), rule.String(), strings.Join(names, ","), body, at}, targets...) {+ for _, field := range append([]string{unit.SpecID, unit.Engine.String(), rule.String(), strings.Join(codes, ","), body, at}, targets...) {_, _ = h.Write(binary.BigEndian.AppendUint64(nil, uint64(len(field))))_, _ = h.Write([]byte(field))}diff --git a/backend/runner/reviewrun/rule_review_test.go b/backend/runner/reviewrun/rule_review_test.goindex c8d6fbbbad..afae815c60 100644--- a/backend/runner/reviewrun/rule_review_test.go+++ b/backend/runner/reviewrun/rule_review_test.go@@ -120,9 +120,9 @@ func TestReviewResultComments(t *testing.T) {result := &review.Result{Statements: []review.Range{{Start: 0, End: 19}, {Start: 20, End: 38}, {Start: 39, End: 47}},Findings: []review.Finding{- {Rule: review.RequireWhere, Statement: 0, Message: "UPDATE without WHERE", Targets: []int{0, 1}},+ {Rule: review.RequireWhere, Statement: 0, Message: "UPDATE without WHERE", Targets: []int{0, 1}, Codes: []review.FindingCode{review.MissingWhere}},{Rule: review.DisallowDropObject, Statement: 1, Range: review.Range{Start: 31, End: 37}, Message: "DROP TABLE 你好", Targets: []int{1}},- {Rule: review.PriorBackup, Statement: -1, Message: "backup database missing", Targets: []int{0}},+ {Rule: review.PriorBackup, Statement: -1, Message: "backup database missing", Targets: []int{0}, Codes: []review.FindingCode{review.BackupLocationMissing, review.ChangeTooLarge}},{Rule: "FUTURE_RULE", Statement: 2, Message: "dropped: unknown to this server", Targets: []int{0}},{Rule: review.Syntax, Statement: 2, Range: review.Range{Start: 40, End: 40}, Message: "empty range anchors the line", Targets: []int{0, 7}},},@@ -142,6 +142,7 @@ func TestReviewResultComments(t *testing.T) {require.Equal(t, storepb.ReviewRuleType_REQUIRE_WHERE, whole.Payload.ReviewMetadata.RuleType)require.Equal(t, storepb.IssueCommentPayload_ReviewMetadata_P1, whole.Payload.ReviewMetadata.Priority)require.Equal(t, []string{"instances/pg/databases/a", "instances/pg/databases/b"}, whole.Payload.ReviewMetadata.Targets, "targets sorted")+ require.Equal(t, []string{"WH101"}, whole.Payload.ReviewMetadata.Codes)require.Equal(t, &storepb.IssueCommentPayload_StatementAnchor{SpecId: "spec-1", SheetSha256: testSheet,StartPosition: &storepb.Position{Line: 1, Column: 1},@@ -156,6 +157,8 @@ func TestReviewResultComments(t *testing.T) {change := comments[2]require.Nil(t, change.Payload.StatementAnchor, "a whole-change finding has no anchor")require.Equal(t, storepb.IssueCommentPayload_ReviewMetadata_P0, change.Payload.ReviewMetadata.Priority)+ require.Equal(t, []string{"PB103", "PB102"}, change.Payload.ReviewMetadata.Codes, "a finding with several reasons keeps every code, in order")+ require.Empty(t, comments[1].Payload.ReviewMetadata.Codes)line := comments[3]require.Equal(t, []string{"instances/pg/databases/b"}, line.Payload.ReviewMetadata.Targets, "an out-of-range target index is dropped")diff --git a/backend/runner/reviewrun/standard_rule_catalog_test.go b/backend/runner/reviewrun/standard_rule_catalog_test.gonew file mode 100644index 0000000000..b6cfe5aa51--- /dev/null+++ b/backend/runner/reviewrun/standard_rule_catalog_test.go@@ -0,0 +1,144 @@+package reviewrun++import (+ "context"+ "encoding/json"+ "os"+ "slices"+ "testing"++ mariadbreview "github.com/bytebase/omni/mariadb/review"+ mssqlreview "github.com/bytebase/omni/mssql/review"+ mysqlreview "github.com/bytebase/omni/mysql/review"+ oceanbasereview "github.com/bytebase/omni/oceanbase/review"+ oraclereview "github.com/bytebase/omni/oracle/review"+ pgreview "github.com/bytebase/omni/pg/review"+ "github.com/bytebase/omni/review"+ snowflakereview "github.com/bytebase/omni/snowflake/review"+ tidbreview "github.com/bytebase/omni/tidb/review"+ "github.com/stretchr/testify/require"++ storepb "github.com/bytebase/bytebase/backend/generated-go/store"+)++// standardRuleCatalogPath is the catalog the SQL Review settings pages and+// the review result cards read the engines and finding codes from. The path+// is relative to this package directory, where `go test` runs.+const standardRuleCatalogPath = "../../../frontend/src/components/sql-review/standardRuleCatalog.json"++// To regenerate the catalog, set recordCatalog to true, run+// TestFrontendStandardRuleCatalogInSync, and set it back.+var recordCatalog = false++type standardRuleCatalog struct {+ // Engines the standard rule review covers, in enum order.+ Engines []string `json:"engines"`+ // By rule name.+ Rules map[string]catalogRule `json:"rules"`+}++type catalogRule struct {+ // Engines that check the rule, in enum order. An engine that only+ // reports that it lacks the rule's feature, such as online migration,+ // is left out.+ Engines []string `json:"engines"`+ Codes []catalogCode `json:"codes"`+}++type catalogCode struct {+ Code string `json:"code"`+ Title string `json:"title"`+}++// engineRules is each reviewed engine's own rule list.+var engineRules = map[storepb.Engine][]review.Rule{+ storepb.Engine_POSTGRES: pgreview.Rules,+ storepb.Engine_MYSQL: mysqlreview.Rules,+ storepb.Engine_OCEANBASE: oceanbasereview.Rules,+ storepb.Engine_MARIADB: mariadbreview.Rules,+ storepb.Engine_TIDB: tidbreview.Rules,+ storepb.Engine_MSSQL: mssqlreview.Rules,+ storepb.Engine_ORACLE: oraclereview.Rules,+ storepb.Engine_SNOWFLAKE: snowflakereview.Rules,+}++// TestFrontendStandardRuleCatalogInSync fails when the frontend catalog drifts+// from what omni and reviewFuncs define: the engines reviewed, which of them+// check each rule, and each rule's finding codes.+func TestFrontendStandardRuleCatalogInSync(t *testing.T) {+ t.Parallel()+ want := buildStandardRuleCatalog(t)+ if recordCatalog {+ data, err := json.MarshalIndent(want, "", " ")+ require.NoError(t, err)+ require.NoError(t, os.WriteFile(standardRuleCatalogPath, append(data, '\n'), 0o644))+ t.Fatal("recorded the catalog; set recordCatalog back to false")+ }+ data, err := os.ReadFile(standardRuleCatalogPath)+ require.NoError(t, err)+ var got standardRuleCatalog+ require.NoError(t, json.Unmarshal(data, &got))+ require.Equal(t, want, got, "set recordCatalog to true in this test and run it to regenerate %s", standardRuleCatalogPath)+}++func buildStandardRuleCatalog(t *testing.T) standardRuleCatalog {+ t.Helper()+ engines := make([]storepb.Engine, 0, len(reviewFuncs))+ for engine := range reviewFuncs {+ require.Contains(t, engineRules, engine, "engineRules is missing a reviewed engine")+ engines = append(engines, engine)+ }+ require.Len(t, engineRules, len(reviewFuncs), "engineRules lists an engine reviewFuncs does not review")+ slices.Sort(engines)++ catalog := standardRuleCatalog{Rules: make(map[string]catalogRule)}+ for _, engine := range engines {+ catalog.Engines = append(catalog.Engines, engine.String())+ lacking := lackingFeatureRules(t, engine)+ for _, rule := range engineRules[engine] {+ if lacking[rule] {+ continue+ }+ entry := catalog.Rules[string(rule)]+ entry.Engines = append(entry.Engines, engine.String())+ catalog.Rules[string(rule)] = entry+ }+ }+ for _, info := range review.Codes() {+ entry, ok := catalog.Rules[string(info.Rule)]+ if !ok {+ continue+ }+ entry.Codes = append(entry.Codes, catalogCode{Code: string(info.Code), Title: info.Title})+ catalog.Rules[string(info.Rule)] = entry+ }+ for rule := range catalog.Rules {+ require.NotEqual(t, storepb.ReviewRuleType_REVIEW_RULE_TYPE_UNSPECIFIED, storepb.ReviewRuleType(storepb.ReviewRuleType_value[rule]), "omni rule %s is unknown to this server", rule)+ }+ return catalog+}++// lackingFeatureRules reports the rules an engine lists only to say it lacks+// their feature: asked for online migration or prior backup, it reports+// OM101 or PB101 whatever the SQL.+func lackingFeatureRules(t *testing.T, engine storepb.Engine) map[review.Rule]bool {+ t.Helper()+ result, err := reviewFuncs[engine](context.Background(), "UPDATE t SET a = 1 WHERE id = 1;", review.Options{+ Rules: []review.Rule{review.OnlineMigration, review.PriorBackup},+ Change: review.Change{OnlineMigration: true, PriorBackup: true},+ }, []review.Target{{}})+ require.NoError(t, err, engine.String())+ lacking := make(map[review.Rule]bool)+ for _, finding := range result.Findings {+ for _, code := range finding.Codes {+ switch code {+ case review.OnlineMigrationUnsupported:+ lacking[review.OnlineMigration] = true+ case review.PriorBackupUnsupported:+ lacking[review.PriorBackup] = true+ default:+ }+ }+ }+ return lacking+}diff --git a/frontend/scripts/check-i18n.mjs b/frontend/scripts/check-i18n.mjsindex c10bbb5fb2..d6112e2254 100644--- a/frontend/scripts/check-i18n.mjs+++ b/frontend/scripts/check-i18n.mjs@@ -29,6 +29,9 @@ const DYNAMIC_PREFIXES = ["dynamic.settings.sensitive-data.semantic-types.template.","sql-review.category.","sql-review.engine.",+ // Finding code titles, rendered via t(findingCodeTitleKey(code)) over the+ // codes in components/sql-review/standardRuleCatalog.json.+ "sql-review.finding-code.","sql-review.level.","sql-review.rule.","sql-review.template.",diff --git a/frontend/src/components/sql-review/FindingCodeBadge.tsx b/frontend/src/components/sql-review/FindingCodeBadge.tsxnew file mode 100644index 0000000000..523acb5370--- /dev/null+++ b/frontend/src/components/sql-review/FindingCodeBadge.tsx@@ -0,0 +1,27 @@+import { useTranslation } from "react-i18next";+import { badgeVariants } from "@/components/ui/badge";+import { Tooltip } from "@/components/ui/tooltip";+import { cn } from "@/lib/utils";+import { findingCodeTitleKey } from "./standardRuleCatalog";++// A finding code, such as "WT101", with its title on hover when this build+// knows the code.+export function FindingCodeBadge({ code }: { code: string }) {+ const { t } = useTranslation();+ const titleKey = findingCodeTitleKey(code);+ const title = titleKey ? t(titleKey) : undefined;+ return (+ <Tooltip+ content={title}+ render={+ <span+ className={cn(badgeVariants(), "shrink-0 font-mono")}+ data-testid="review-code"+ tabIndex={title ? 0 : undefined}+ />+ }+ >+ {code}+ </Tooltip>+ );+}diff --git a/frontend/src/components/sql-review/StandardRuleSwitches.test.tsx b/frontend/src/components/sql-review/StandardRuleSwitches.test.tsxindex 564f06c2a6..aa0a1da38c 100644--- a/frontend/src/components/sql-review/StandardRuleSwitches.test.tsx+++ b/frontend/src/components/sql-review/StandardRuleSwitches.test.tsx@@ -6,6 +6,7 @@ import { StandardRuleSwitches } from "./StandardRuleSwitches";import { STANDARD_RULE_TYPES } from "./standardRules";vi.mock("react-i18next", () => ({+ initReactI18next: { type: "3rdParty", init: () => {} },useTranslation: () => ({ t: (key: string) => key }),}));@@ -34,7 +35,37 @@ function Stateful({);}+const rowOf = (rule: string) =>+ ruleSwitch(rule).closest("[class*='justify-between']") as HTMLElement;++const codesOf = (row: HTMLElement) =>+ Array.from(row.querySelectorAll("[data-testid='review-code']")).map(+ (node) => node.textContent+ );+describe("StandardRuleSwitches", () => {+ test("lists the engines reviewed, each rule's codes, and the engines of a rule fewer engines check", () => {+ render(+ <StandardRuleSwitches rules={STANDARD_RULE_TYPES} onChange={vi.fn()} />+ );++ expect(screen.getByTestId("standard-rule-engines").textContent).toBe(+ "sql-review.standard-rules.supported-engines"+ );+ const where = rowOf("require-where");+ expect(codesOf(where)).toEqual(["WH101"]);+ expect(+ where.querySelector("[data-testid='standard-rule-rule-engines']")+ ).toBeNull();++ const online = rowOf("online-migration");+ expect(codesOf(online)[0]).toBe("OM101");+ expect(+ online.querySelector("[data-testid='standard-rule-rule-engines']")+ ?.textContent+ ).toBe("MySQL, MariaDB, OceanBase (MySQL)");+ });+test("switches one rule and reports the list in display order", () => {const onChange = vi.fn();render(diff --git a/frontend/src/components/sql-review/StandardRuleSwitches.tsx b/frontend/src/components/sql-review/StandardRuleSwitches.tsxindex ed7ac6ab87..a850531d61 100644--- a/frontend/src/components/sql-review/StandardRuleSwitches.tsx+++ b/frontend/src/components/sql-review/StandardRuleSwitches.tsx@@ -2,7 +2,14 @@ import { useRef } from "react";import { useTranslation } from "react-i18next";import { cn } from "@/lib/utils";import { ReviewRuleType } from "@/types/proto-es/v1/review_rule_pb";+import { engineNameV1 } from "@/utils/v1/instance";+import { FindingCodeBadge } from "./FindingCodeBadge";import { SwitchRow } from "./SwitchRow";+import {+ RULE_REVIEW_ENGINES,+ standardRuleCodes,+ standardRuleEngines,+} from "./standardRuleCatalog";import {isStandardReviewOn,STANDARD_RULE_TYPES,@@ -76,6 +83,14 @@ export function StandardRuleSwitches({}): t("sql-review.standard-rules.syntax-off")}</div>+ <div+ className="border-b border-block-border px-4 py-2 text-xs text-control-light"+ data-testid="standard-rule-engines"+ >+ {t("sql-review.standard-rules.supported-engines", {+ engines: RULE_REVIEW_ENGINES.map(engineNameV1).join(", "),+ })}+ </div><div className="divide-y divide-block-border">{STANDARD_RULE_TYPES.map((rule) => {const text = standardRuleText(t, rule);@@ -85,6 +100,7 @@ export function StandardRuleSwitches({className="px-4 py-3"title={text.title}description={text.description}+ details={<StandardRuleFacts rule={rule} />}checked={rules.includes(rule)}onCheckedChange={(on) => toggle(rule, on)}disabled={@@ -98,3 +114,42 @@ export function StandardRuleSwitches({</div>);}++// A rule's finding codes, and its engines when not every reviewed engine+// checks it.+function StandardRuleFacts({ rule }: { rule: ReviewRuleType }) {+ const { t } = useTranslation();+ const codes = standardRuleCodes(rule);+ const engines = standardRuleEngines(rule);+ const partial = engines.length < RULE_REVIEW_ENGINES.length;+ if (codes.length === 0 && !partial) return null;+ return (+ <dl className="mt-1 flex flex-col gap-y-1 text-xs">+ {codes.length > 0 && (+ <div className="flex items-baseline gap-x-2">+ <dt className="shrink-0 text-control-light">+ {t("sql-review.standard-rules.codes")}+ </dt>+ <dd+ className="flex min-w-0 flex-wrap items-center gap-1"+ data-testid="standard-rule-codes"+ >+ {codes.map(({ code }) => (+ <FindingCodeBadge code={code} key={code} />+ ))}+ </dd>+ </div>+ )}+ {partial && (+ <div className="flex items-baseline gap-x-2">+ <dt className="shrink-0 text-control-light">+ {t("sql-review.standard-rules.engines")}+ </dt>+ <dd className="text-control" data-testid="standard-rule-rule-engines">+ {engines.map(engineNameV1).join(", ")}+ </dd>+ </div>+ )}+ </dl>+ );+}diff --git a/frontend/src/components/sql-review/SwitchRow.tsx b/frontend/src/components/sql-review/SwitchRow.tsxindex 62769eb8e7..6a62a01bb5 100644--- a/frontend/src/components/sql-review/SwitchRow.tsx+++ b/frontend/src/components/sql-review/SwitchRow.tsx@@ -6,6 +6,8 @@ import { cn } from "@/lib/utils";interface SwitchRowProps {title: string;description?: ReactNode;+ // Facts below the description, such as what the setting covers.+ details?: ReactNode;checked: boolean;onCheckedChange: (checked: boolean) => void;disabled?: boolean;@@ -18,6 +20,7 @@ interface SwitchRowProps {export function SwitchRow({title,description,+ details,checked,onCheckedChange,disabled = false,@@ -32,6 +35,7 @@ export function SwitchRow({{description !== undefined && (<div className="text-sm text-control-light">{description}</div>)}+ {details}</div>{readOnly ? (<spandiff --git a/frontend/src/components/sql-review/standardRuleCatalog.json b/frontend/src/components/sql-review/standardRuleCatalog.jsonnew file mode 100644index 0000000000..26dd5a4acb--- /dev/null+++ b/frontend/src/components/sql-review/standardRuleCatalog.json@@ -0,0 +1,309 @@+{+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "rules": {+ "DISALLOW_DROP_CONSTRAINT": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "DC101",+ "title": "Drops a constraint"+ }+ ]+ },+ "DISALLOW_DROP_OBJECT": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "DO101",+ "title": "Drops data"+ },+ {+ "code": "DO102",+ "title": "Drops a definition"+ },+ {+ "code": "DO103",+ "title": "Drops a user, role, or security object"+ }+ ]+ },+ "DISALLOW_RENAME": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "RN101",+ "title": "Renames a table, view, or column"+ }+ ]+ },+ "DISALLOW_TRUNCATE": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "TR101",+ "title": "Truncates data"+ }+ ]+ },+ "ONLINE_MIGRATION": {+ "engines": ["MYSQL", "MARIADB", "OCEANBASE"],+ "codes": [+ {+ "code": "OM101",+ "title": "Engine has no online migration"+ },+ {+ "code": "OM102",+ "title": "gh-ost directive is invalid"+ },+ {+ "code": "OM103",+ "title": "Change doesn't fit online migration"+ },+ {+ "code": "OM104",+ "title": "gh-ost can't rename the column"+ },+ {+ "code": "OM105",+ "title": "Backup database doesn't exist"+ },+ {+ "code": "OM106",+ "title": "Table doesn't meet gh-ost's requirements"+ }+ ]+ },+ "PRIOR_BACKUP": {+ "engines": ["MYSQL", "POSTGRES", "TIDB", "ORACLE", "MSSQL", "MARIADB"],+ "codes": [+ {+ "code": "PB101",+ "title": "Engine has no prior backup"+ },+ {+ "code": "PB102",+ "title": "Change exceeds the backup size limit"+ },+ {+ "code": "PB103",+ "title": "Backup database or schema doesn't exist"+ },+ {+ "code": "PB104",+ "title": "Change has nothing to back up"+ },+ {+ "code": "PB105",+ "title": "Statements can't share one backup"+ },+ {+ "code": "PB106",+ "title": "Backup may read another table"+ },+ {+ "code": "PB107",+ "title": "Table can't be backed up"+ },+ {+ "code": "PB108",+ "title": "Statement form can't be backed up"+ },+ {+ "code": "PB109",+ "title": "Backup reads what the change creates"+ }+ ]+ },+ "REQUIRE_IS_NULL": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "NU101",+ "title": "Comparison with NULL is never true"+ }+ ]+ },+ "REQUIRE_PRIMARY_KEY": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "PK101",+ "title": "Creates a table without a primary key"+ },+ {+ "code": "PK102",+ "title": "Removes a table's primary key"+ }+ ]+ },+ "REQUIRE_WHERE": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "WH101",+ "title": "UPDATE or DELETE has no WHERE clause"+ }+ ]+ },+ "SYNTAX": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "SNOWFLAKE",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "SY101",+ "title": "Statement doesn't parse"+ }+ ]+ },+ "WALK_THROUGH": {+ "engines": [+ "MYSQL",+ "POSTGRES",+ "TIDB",+ "ORACLE",+ "MSSQL",+ "MARIADB",+ "OCEANBASE"+ ],+ "codes": [+ {+ "code": "WT101",+ "title": "Object doesn't exist"+ },+ {+ "code": "WT201",+ "title": "Name is already taken"+ },+ {+ "code": "WT301",+ "title": "Object is of another kind"+ },+ {+ "code": "WT401",+ "title": "Statement uses one name twice"+ },+ {+ "code": "WT402",+ "title": "No database or schema selected"+ },+ {+ "code": "WT403",+ "title": "Name is too long"+ },+ {+ "code": "WT404",+ "title": "Name is reserved"+ },+ {+ "code": "WT405",+ "title": "Schema still holds objects"+ },+ {+ "code": "WT406",+ "title": "System column can't be changed"+ },+ {+ "code": "WT407",+ "title": "Name refers to another database"+ },+ {+ "code": "WT408",+ "title": "Engine rejects this form of statement"+ },+ {+ "code": "WT409",+ "title": "Statement must start its batch"+ },+ {+ "code": "WT410",+ "title": "Trigger and table are in different schemas"+ },+ {+ "code": "WT411",+ "title": "Index belongs to a constraint"+ }+ ]+ }+ }+}diff --git a/frontend/src/components/sql-review/standardRuleCatalog.test.ts b/frontend/src/components/sql-review/standardRuleCatalog.test.tsnew file mode 100644index 0000000000..61433221b6--- /dev/null+++ b/frontend/src/components/sql-review/standardRuleCatalog.test.ts@@ -0,0 +1,60 @@+import { describe, expect, test } from "vitest";+import enUS from "@/locales/sql-review/en-US.json";+import { Engine } from "@/types/proto-es/v1/common_pb";+import { ReviewRuleType } from "@/types/proto-es/v1/review_rule_pb";+import {+ findingCodeTitleKey,+ RULE_REVIEW_ENGINES,+ standardRuleCodes,+ standardRuleEngines,+} from "./standardRuleCatalog";+import { STANDARD_RULE_TYPES } from "./standardRules";++describe("standardRuleCatalog", () => {+ test("names every reviewed engine by a known enum value", () => {+ expect(RULE_REVIEW_ENGINES).toContain(Engine.POSTGRES);+ for (const engine of RULE_REVIEW_ENGINES) {+ expect(Engine[engine]).toBeDefined();+ }+ });++ test("gives every standard rule its engines and at least one code", () => {+ for (const rule of STANDARD_RULE_TYPES) {+ expect(standardRuleCodes(rule).length).toBeGreaterThan(0);+ const engines = standardRuleEngines(rule);+ expect(engines.length).toBeGreaterThan(0);+ expect(+ engines.every((engine) => RULE_REVIEW_ENGINES.includes(engine))+ ).toBe(true);+ }+ });++ test("leaves out an engine that only reports it lacks the rule's feature", () => {+ expect(standardRuleEngines(ReviewRuleType.ONLINE_MIGRATION)).not.toContain(+ Engine.POSTGRES+ );+ expect(standardRuleEngines(ReviewRuleType.REQUIRE_WHERE)).toContain(+ Engine.POSTGRES+ );+ });++ test("keys a known code's title and not an unknown one", () => {+ expect(findingCodeTitleKey("WT101")).toBe("sql-review.finding-code.wt101");+ expect(findingCodeTitleKey("ZZ999")).toBeUndefined();+ expect(+ standardRuleCodes(ReviewRuleType.REVIEW_RULE_TYPE_UNSPECIFIED)+ ).toEqual([]);+ });++ // A code omni adds or retitles reaches the catalog through the backend's+ // sync test, then fails here until en-US carries it; check-i18n holds the+ // other locales to en-US's keys.+ test("gives every code an en-US title equal to omni's", () => {+ const titles: Record<string, string | undefined> = enUS["finding-code"];+ for (const rule of STANDARD_RULE_TYPES) {+ for (const { code, title } of standardRuleCodes(rule)) {+ expect(titles[code.toLowerCase()], code).toBe(title);+ }+ }+ });+});diff --git a/frontend/src/components/sql-review/standardRuleCatalog.ts b/frontend/src/components/sql-review/standardRuleCatalog.tsnew file mode 100644index 0000000000..6e7516c6c1--- /dev/null+++ b/frontend/src/components/sql-review/standardRuleCatalog.ts@@ -0,0 +1,55 @@+import { Engine } from "@/types/proto-es/v1/common_pb";+import { ReviewRuleType } from "@/types/proto-es/v1/review_rule_pb";+import catalog from "./standardRuleCatalog.json";++// standardRuleCatalog.json is recorded from omni and the backend's reviewed+// engines; backend/runner/reviewrun/standard_rule_catalog_test.go fails when+// it drifts.++export interface FindingCodeInfo {+ // Such as "WT101".+ code: string;+ // omni's English title. The UI shows the sql-review.finding-code.<code>+ // locale entry, whose en-US text is this title.+ title: string;+}++interface CatalogRule {+ engines: string[];+ codes: FindingCodeInfo[];+}++const RULES: Readonly<Record<string, CatalogRule | undefined>> = catalog.rules;++const toEngines = (names: readonly string[]): Engine[] =>+ names.map((name) => Engine[name as keyof typeof Engine]);++// Engines the standard rule review covers. A target on any other engine is+// reviewed by the plan checks' review policy instead.+export const RULE_REVIEW_ENGINES: readonly Engine[] = toEngines(+ catalog.engines+);++// The engines that check a rule. An engine left out of a rule it lists, such+// as SQL Server for online migration, only reports that it has no such+// feature.+export const standardRuleEngines = (rule: ReviewRuleType): Engine[] =>+ toEngines(RULES[ReviewRuleType[rule]]?.engines ?? []);++// The finding codes a rule reports, in omni's order.+export const standardRuleCodes = (+ rule: ReviewRuleType+): readonly FindingCodeInfo[] => RULES[ReviewRuleType[rule]]?.codes ?? [];++const KNOWN_CODES: ReadonlySet<string> = new Set(+ Object.values(RULES).flatMap((rule) =>+ (rule?.codes ?? []).map(({ code }) => code)+ )+);++// The locale key of a finding code's title, or undefined for a code this+// build does not know.+export const findingCodeTitleKey = (code: string): string | undefined =>+ KNOWN_CODES.has(code)+ ? `sql-review.finding-code.${code.toLowerCase()}`+ : undefined;diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex 06e33b6e6b..8e385bc89e 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -2199,9 +2199,7 @@"n-replies-hidden_other": "{{count}} replies hidden","n-replies_one": "{{count}} reply","n-replies_other": "{{count}} replies",- "open": "Open","priority": {- "p0": "The SQL is wrong and must change.","p1": "Dangerous but legitimate. A person must accept it.","p2": "Advisory only."},@@ -2213,7 +2211,6 @@"resolve": "Resolve","resolve-thread": "Resolve thread","resolved": "Resolved",- "rule": "Rule","threads-on-line_one": "{{count}} thread on this line","threads-on-line_other": "{{count}} threads on this line","walker": {diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 64ebe06ebc..ac5065b376 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -2199,9 +2199,7 @@"n-replies-hidden_other": "{{count}} respuestas ocultas","n-replies_one": "{{count}} respuesta","n-replies_other": "{{count}} respuestas",- "open": "Abierto","priority": {- "p0": "El SQL es incorrecto y debe cambiar.","p1": "Peligroso pero legítimo. Una persona debe aceptarlo.","p2": "Solo informativo."},@@ -2213,7 +2211,6 @@"resolve": "Resolver","resolve-thread": "Resolver hilo","resolved": "Resuelto",- "rule": "Regla","threads-on-line_one": "{{count}} hilo en esta línea","threads-on-line_other": "{{count}} hilos en esta línea","walker": {diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 59f51fb07e..3961d7799b 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -2199,9 +2199,7 @@"n-replies-hidden_other": "{{count}} 件の返信が非表示","n-replies_one": "{{count}} 件の返信","n-replies_other": "{{count}} 件の返信",- "open": "未解決","priority": {- "p0": "SQL に誤りがあり、修正が必要です。","p1": "危険ですが正当な変更です。担当者による承認が必要です。","p2": "参考情報です。"},@@ -2213,7 +2211,6 @@"resolve": "解決","resolve-thread": "スレッドを解決","resolved": "解決済み",- "rule": "ルール","threads-on-line_one": "この行に {{count}} 件のスレッド","threads-on-line_other": "この行に {{count}} 件のスレッド","walker": {diff --git a/frontend/src/locales/sql-review/en-US.json b/frontend/src/locales/sql-review/en-US.jsonindex d86ae51fbb..703f9c95ad 100644--- a/frontend/src/locales/sql-review/en-US.json+++ b/frontend/src/locales/sql-review/en-US.json@@ -99,6 +99,48 @@"tidb": "TiDB","trino": "Trino"},+ "finding-code": {+ "dc101": "Drops a constraint",+ "do101": "Drops data",+ "do102": "Drops a definition",+ "do103": "Drops a user, role, or security object",+ "nu101": "Comparison with NULL is never true",+ "om101": "Engine has no online migration",+ "om102": "gh-ost directive is invalid",+ "om103": "Change doesn't fit online migration",+ "om104": "gh-ost can't rename the column",+ "om105": "Backup database doesn't exist",+ "om106": "Table doesn't meet gh-ost's requirements",+ "pb101": "Engine has no prior backup",+ "pb102": "Change exceeds the backup size limit",+ "pb103": "Backup database or schema doesn't exist",+ "pb104": "Change has nothing to back up",+ "pb105": "Statements can't share one backup",+ "pb106": "Backup may read another table",+ "pb107": "Table can't be backed up",+ "pb108": "Statement form can't be backed up",+ "pb109": "Backup reads what the change creates",+ "pk101": "Creates a table without a primary key",+ "pk102": "Removes a table's primary key",+ "rn101": "Renames a table, view, or column",+ "sy101": "Statement doesn't parse",+ "tr101": "Truncates data",+ "wh101": "UPDATE or DELETE has no WHERE clause",+ "wt101": "Object doesn't exist",+ "wt201": "Name is already taken",+ "wt301": "Object is of another kind",+ "wt401": "Statement uses one name twice",+ "wt402": "No database or schema selected",+ "wt403": "Name is too long",+ "wt404": "Name is reserved",+ "wt405": "Schema still holds objects",+ "wt406": "System column can't be changed",+ "wt407": "Name refers to another database",+ "wt408": "Engine rejects this form of statement",+ "wt409": "Statement must start its batch",+ "wt410": "Trigger and table are in different schemas",+ "wt411": "Index belongs to a constraint"+ },"input-then-press-enter": "Input the value then press enter to add","level": {"disabled": "Disabled",@@ -758,12 +800,14 @@"select-all": "Select all","select-review-rules": "Select SQL review rules","standard-rules": {+ "codes": "Codes","customize": {"description": "When disabled, this project follows the workspace standard rules.","self": "Customize for this project","view-workspace-rules": "View workspace rules"},"description": "Built-in rules that review the SQL of every issue. Projects that do not customize their rules follow these.",+ "engines": "Engines","load-failed": "The standard rules could not be loaded.","off": "Off","on": "On",@@ -817,6 +861,7 @@},"running": "{{on}} of {{total}} rules enabled","self": "Standard rules",+ "supported-engines": "Supported engines: {{engines}}","syntax-off": "Syntax checking is disabled, so none of the standard rules run. Turn it on to review changes.","workspace-rules-hidden": "You do not have permission to view the workspace rules this project follows."},diff --git a/frontend/src/locales/sql-review/es-ES.json b/frontend/src/locales/sql-review/es-ES.jsonindex 57506dca46..d84a471766 100644--- a/frontend/src/locales/sql-review/es-ES.json+++ b/frontend/src/locales/sql-review/es-ES.json@@ -99,6 +99,48 @@"tidb": "TiDB","trino": "Trino"},+ "finding-code": {+ "dc101": "Elimina una restricción",+ "do101": "Elimina datos",+ "do102": "Elimina una definición",+ "do103": "Elimina un usuario, un rol o un objeto de seguridad",+ "nu101": "La comparación con NULL nunca es verdadera",+ "om101": "El motor no admite la migración en línea",+ "om102": "La directiva de gh-ost no es válida",+ "om103": "El cambio no es apto para la migración en línea",+ "om104": "gh-ost no puede renombrar la columna",+ "om105": "La base de datos de copia de seguridad no existe",+ "om106": "La tabla no cumple los requisitos de gh-ost",+ "pb101": "El motor no admite la copia de seguridad previa",+ "pb102": "El cambio supera el límite de tamaño de la copia de seguridad",+ "pb103": "La base de datos o el esquema de la copia de seguridad no existe",+ "pb104": "El cambio no tiene nada que respaldar",+ "pb105": "Las sentencias no pueden compartir una copia de seguridad",+ "pb106": "La copia de seguridad podría leer otra tabla",+ "pb107": "La tabla no se puede respaldar",+ "pb108": "Esta forma de sentencia no se puede respaldar",+ "pb109": "La copia de seguridad lee lo que crea el cambio",+ "pk101": "Crea una tabla sin clave primaria",+ "pk102": "Quita la clave primaria de una tabla",+ "rn101": "Renombra una tabla, una vista o una columna",+ "sy101": "La sentencia no se puede analizar",+ "tr101": "Vacía datos",+ "wh101": "UPDATE o DELETE sin cláusula WHERE",+ "wt101": "El objeto no existe",+ "wt201": "El nombre ya está en uso",+ "wt301": "El objeto es de otro tipo",+ "wt401": "La sentencia usa un nombre dos veces",+ "wt402": "No hay ninguna base de datos ni esquema seleccionado",+ "wt403": "El nombre es demasiado largo",+ "wt404": "El nombre está reservado",+ "wt405": "El esquema aún contiene objetos",+ "wt406": "La columna del sistema no se puede modificar",+ "wt407": "El nombre hace referencia a otra base de datos",+ "wt408": "El motor rechaza esta forma de sentencia",+ "wt409": "La sentencia debe iniciar su lote",+ "wt410": "El disparador y la tabla están en esquemas distintos",+ "wt411": "El índice pertenece a una restricción"+ },"input-then-press-enter": "Ingrese el valor y luego presione enter para agregar","level": {"disabled": "Deshabilitado",@@ -758,12 +800,14 @@"select-all": "Seleccionar todo","select-review-rules": "Seleccionar reglas de revisión de SQL","standard-rules": {+ "codes": "Códigos","customize": {"description": "Cuando está desactivado, este proyecto sigue las reglas estándar del espacio de trabajo.","self": "Personalizar para este proyecto","view-workspace-rules": "Ver las reglas del espacio de trabajo"},"description": "Reglas integradas que revisan el SQL de cada issue. Los proyectos que no personalizan sus reglas siguen estas.",+ "engines": "Motores","load-failed": "No se pudieron cargar las reglas estándar.","off": "Desactivada","on": "Activada",@@ -817,6 +861,7 @@},"running": "{{on}} de {{total}} reglas habilitadas","self": "Reglas estándar",+ "supported-engines": "Motores compatibles: {{engines}}","syntax-off": "La comprobación de sintaxis está desactivada, por lo que no se ejecuta ninguna regla estándar. Actívela para revisar los cambios.","workspace-rules-hidden": "No tienes permiso para ver las reglas del espacio de trabajo que sigue este proyecto."},diff --git a/frontend/src/locales/sql-review/ja-JP.json b/frontend/src/locales/sql-review/ja-JP.jsonindex 46e55e7f1b..c559e3e22d 100644--- a/frontend/src/locales/sql-review/ja-JP.json+++ b/frontend/src/locales/sql-review/ja-JP.json@@ -99,6 +99,48 @@"tidb": "TiDB","trino": "Trino"},+ "finding-code": {+ "dc101": "制約を削除する",+ "do101": "データを削除する",+ "do102": "定義を削除する",+ "do103": "ユーザー、ロール、またはセキュリティオブジェクトを削除する",+ "nu101": "NULL との比較は常に真にならない",+ "om101": "エンジンがオンライン移行に対応していない",+ "om102": "gh-ost ディレクティブが無効",+ "om103": "変更がオンライン移行に適さない",+ "om104": "gh-ost で列名を変更できない",+ "om105": "バックアップデータベースが存在しない",+ "om106": "テーブルが gh-ost の要件を満たさない",+ "pb101": "エンジンが事前バックアップに対応していない",+ "pb102": "変更がバックアップのサイズ上限を超えている",+ "pb103": "バックアップ用のデータベースまたはスキーマが存在しない",+ "pb104": "バックアップする対象がない",+ "pb105": "複数のステートメントで 1 つのバックアップを共有できない",+ "pb106": "バックアップが別のテーブルを読み取る可能性がある",+ "pb107": "テーブルをバックアップできない",+ "pb108": "この形式のステートメントはバックアップできない",+ "pb109": "バックアップが変更で作成されるものを読み取る",+ "pk101": "主キーのないテーブルを作成する",+ "pk102": "テーブルの主キーを削除する",+ "rn101": "テーブル、ビュー、または列の名前を変更する",+ "sy101": "ステートメントを解析できない",+ "tr101": "データを切り捨てる",+ "wh101": "UPDATE または DELETE に WHERE 句がない",+ "wt101": "オブジェクトが存在しない",+ "wt201": "名前がすでに使われている",+ "wt301": "オブジェクトの種類が異なる",+ "wt401": "ステートメント内で同じ名前を 2 回使っている",+ "wt402": "データベースまたはスキーマが選択されていない",+ "wt403": "名前が長すぎる",+ "wt404": "名前が予約語",+ "wt405": "スキーマにオブジェクトが残っている",+ "wt406": "システム列は変更できない",+ "wt407": "名前が別のデータベースを参照している",+ "wt408": "エンジンがこの形式のステートメントを受け付けない",+ "wt409": "ステートメントはバッチの先頭に置く必要がある",+ "wt410": "トリガーとテーブルのスキーマが異なる",+ "wt411": "インデックスが制約に属している"+ },"input-then-press-enter": "入力後、Enterを押して追加します","level": {"disabled": "無効化",@@ -758,12 +800,14 @@"select-all": "すべて選択","select-review-rules": "SQL レビュールールを選択","standard-rules": {+ "codes": "コード","customize": {"description": "無効の場合、このプロジェクトはワークスペースの標準ルールに従います。","self": "このプロジェクト用にカスタマイズ","view-workspace-rules": "ワークスペースのルールを表示"},"description": "すべての Issue の SQL をレビューする組み込みルールです。ルールをカスタマイズしていないプロジェクトはこの設定に従います。",+ "engines": "エンジン","load-failed": "標準ルールを読み込めませんでした。","off": "オフ","on": "オン",@@ -817,6 +861,7 @@},"running": "{{total}} 件中 {{on}} 件のルールが有効","self": "標準ルール",+ "supported-engines": "対応エンジン:{{engines}}","syntax-off": "構文チェックが無効になっているため、標準ルールは実行されません。変更をレビューするには有効にしてください。","workspace-rules-hidden": "このプロジェクトが従うワークスペースのルールを表示する権限がありません。"},diff --git a/frontend/src/locales/sql-review/vi-VN.json b/frontend/src/locales/sql-review/vi-VN.jsonindex e5b85d8b6e..725480bcfd 100644--- a/frontend/src/locales/sql-review/vi-VN.json+++ b/frontend/src/locales/sql-review/vi-VN.json@@ -99,6 +99,48 @@"tidb": "TiDB","trino": "Trino"},+ "finding-code": {+ "dc101": "Xóa một ràng buộc",+ "do101": "Xóa dữ liệu",+ "do102": "Xóa một định nghĩa",+ "do103": "Xóa người dùng, vai trò hoặc đối tượng bảo mật",+ "nu101": "Phép so sánh với NULL không bao giờ đúng",+ "om101": "Engine không hỗ trợ di chuyển trực tuyến",+ "om102": "Chỉ thị gh-ost không hợp lệ",+ "om103": "Thay đổi không phù hợp với di chuyển trực tuyến",+ "om104": "gh-ost không thể đổi tên cột",+ "om105": "Cơ sở dữ liệu sao lưu không tồn tại",+ "om106": "Bảng không đáp ứng yêu cầu của gh-ost",+ "pb101": "Engine không hỗ trợ sao lưu trước",+ "pb102": "Thay đổi vượt quá giới hạn kích thước sao lưu",+ "pb103": "Cơ sở dữ liệu hoặc schema sao lưu không tồn tại",+ "pb104": "Thay đổi không có gì để sao lưu",+ "pb105": "Các câu lệnh không thể dùng chung một bản sao lưu",+ "pb106": "Bản sao lưu có thể đọc bảng khác",+ "pb107": "Không thể sao lưu bảng",+ "pb108": "Không thể sao lưu dạng câu lệnh này",+ "pb109": "Bản sao lưu đọc đối tượng do thay đổi tạo ra",+ "pk101": "Tạo bảng không có khóa chính",+ "pk102": "Gỡ khóa chính của bảng",+ "rn101": "Đổi tên bảng, view hoặc cột",+ "sy101": "Câu lệnh không phân tích được",+ "tr101": "Làm trống dữ liệu",+ "wh101": "UPDATE hoặc DELETE không có mệnh đề WHERE",+ "wt101": "Đối tượng không tồn tại",+ "wt201": "Tên đã được sử dụng",+ "wt301": "Đối tượng thuộc loại khác",+ "wt401": "Câu lệnh dùng một tên hai lần",+ "wt402": "Chưa chọn cơ sở dữ liệu hoặc schema",+ "wt403": "Tên quá dài",+ "wt404": "Tên là từ dành riêng",+ "wt405": "Schema vẫn còn đối tượng",+ "wt406": "Không thể thay đổi cột hệ thống",+ "wt407": "Tên tham chiếu đến cơ sở dữ liệu khác",+ "wt408": "Engine không chấp nhận dạng câu lệnh này",+ "wt409": "Câu lệnh phải đứng đầu lô",+ "wt410": "Trigger và bảng nằm ở các schema khác nhau",+ "wt411": "Chỉ mục thuộc về một ràng buộc"+ },"input-then-press-enter": "Nhập giá trị sau đó nhấn enter để thêm","level": {"disabled": "Đã tắt",@@ -758,12 +800,14 @@"select-all": "Chọn tất cả","select-review-rules": "Chọn quy tắc đánh giá SQL","standard-rules": {+ "codes": "Mã","customize": {"description": "Khi bị vô hiệu hóa, dự án này tuân theo các quy tắc tiêu chuẩn của không gian làm việc.","self": "Tùy chỉnh cho dự án này","view-workspace-rules": "Xem quy tắc của không gian làm việc"},"description": "Các quy tắc tích hợp sẵn dùng để đánh giá SQL của mọi issue. Các dự án không tùy chỉnh quy tắc sẽ tuân theo các quy tắc này.",+ "engines": "Engine","load-failed": "Không thể tải các quy tắc tiêu chuẩn.","off": "Tắt","on": "Bật",@@ -817,6 +861,7 @@},"running": "Đã bật {{on}} trên {{total}} quy tắc","self": "Quy tắc tiêu chuẩn",+ "supported-engines": "Engine được hỗ trợ: {{engines}}","syntax-off": "Tính năng kiểm tra cú pháp đang bị tắt nên không quy tắc tiêu chuẩn nào chạy. Hãy bật tính năng này để đánh giá các thay đổi.","workspace-rules-hidden": "Bạn không có quyền xem các quy tắc của không gian làm việc mà dự án này tuân theo."},diff --git a/frontend/src/locales/sql-review/zh-CN.json b/frontend/src/locales/sql-review/zh-CN.jsonindex 8c45e5a1da..4c5bc72af9 100644--- a/frontend/src/locales/sql-review/zh-CN.json+++ b/frontend/src/locales/sql-review/zh-CN.json@@ -99,6 +99,48 @@"tidb": "TiDB","trino": "Trino"},+ "finding-code": {+ "dc101": "删除约束",+ "do101": "删除数据",+ "do102": "删除定义",+ "do103": "删除用户、角色或安全对象",+ "nu101": "与 NULL 的比较永远不成立",+ "om101": "引擎不支持在线大表变更",+ "om102": "gh-ost 指令无效",+ "om103": "变更不适用于在线大表变更",+ "om104": "gh-ost 无法重命名该列",+ "om105": "备份数据库不存在",+ "om106": "表不满足 gh-ost 的要求",+ "pb101": "引擎不支持事先备份",+ "pb102": "变更超出备份大小上限",+ "pb103": "备份数据库或 Schema 不存在",+ "pb104": "变更没有需要备份的内容",+ "pb105": "多条语句无法共用一份备份",+ "pb106": "备份可能读取其他表",+ "pb107": "表无法备份",+ "pb108": "该语句形式无法备份",+ "pb109": "备份读取了变更新建的对象",+ "pk101": "创建无主键的表",+ "pk102": "移除表的主键",+ "rn101": "重命名表、视图或列",+ "sy101": "语句无法解析",+ "tr101": "清空数据",+ "wh101": "UPDATE 或 DELETE 缺少 WHERE 子句",+ "wt101": "对象不存在",+ "wt201": "名称已被占用",+ "wt301": "对象类型不符",+ "wt401": "语句中同一名称出现两次",+ "wt402": "未选择数据库或 Schema",+ "wt403": "名称过长",+ "wt404": "名称为保留字",+ "wt405": "Schema 中仍有对象",+ "wt406": "系统列无法修改",+ "wt407": "名称引用了其他数据库",+ "wt408": "引擎不支持该语句形式",+ "wt409": "语句必须位于批处理开头",+ "wt410": "触发器与表位于不同 Schema",+ "wt411": "索引属于某个约束"+ },"input-then-press-enter": "输入后按下回车来添加","level": {"disabled": "禁用",@@ -758,12 +800,14 @@"select-all": "选择全部","select-review-rules": "选择 SQL 审核规则","standard-rules": {+ "codes": "规则码","customize": {"description": "禁用后,此项目遵循工作空间的标准规则。","self": "为此项目自定义","view-workspace-rules": "查看工作空间规则"},"description": "内置规则,审核每个工单中的 SQL。未自定义规则的项目遵循这里的设置。",+ "engines": "引擎","load-failed": "标准规则加载失败。","off": "关","on": "开",@@ -817,6 +861,7 @@},"running": "{{total}} 条规则中 {{on}} 条已启用","self": "标准规则",+ "supported-engines": "支持的引擎:{{engines}}","syntax-off": "语法检查已禁用,因此不会运行任何标准规则。启用后即可审核变更。","workspace-rules-hidden": "你没有权限查看此项目所遵循的工作空间规则。"},diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex 8c09a7a33d..7948500b18 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -2199,9 +2199,7 @@"n-replies-hidden_other": "{{count}} phản hồi bị ẩn","n-replies_one": "{{count}} phản hồi","n-replies_other": "{{count}} phản hồi",- "open": "Đang mở","priority": {- "p0": "SQL sai và phải được sửa.","p1": "Nguy hiểm nhưng hợp lệ. Cần có người chấp nhận.","p2": "Chỉ mang tính tham khảo."},@@ -2213,7 +2211,6 @@"resolve": "Giải quyết","resolve-thread": "Giải quyết luồng","resolved": "Đã giải quyết",- "rule": "Quy tắc","threads-on-line_one": "{{count}} chủ đề trên dòng này","threads-on-line_other": "{{count}} chủ đề trên dòng này","walker": {diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex c7c38a04b6..5b19683514 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -2199,9 +2199,7 @@"n-replies-hidden_other": "已隐藏 {{count}} 条回复","n-replies_one": "{{count}} 条回复","n-replies_other": "{{count}} 条回复",- "open": "待处理","priority": {- "p0": "SQL 有误,必须修改。","p1": "有风险但合理,需要有人确认接受。","p2": "仅供参考。"},@@ -2213,7 +2211,6 @@"resolve": "解决","resolve-thread": "解决线程","resolved": "已解决",- "rule": "规则","threads-on-line_one": "此行有 {{count}} 个讨论","threads-on-line_other": "此行有 {{count}} 个讨论","walker": {diff --git a/frontend/src/routes/project/ProjectSQLReviewPage.test.tsx b/frontend/src/routes/project/ProjectSQLReviewPage.test.tsxindex 05af831986..4e0d1e5230 100644--- a/frontend/src/routes/project/ProjectSQLReviewPage.test.tsx+++ b/frontend/src/routes/project/ProjectSQLReviewPage.test.tsx@@ -38,6 +38,7 @@ const mocks = vi.hoisted(() => ({}));vi.mock("react-i18next", () => ({+ initReactI18next: { type: "3rdParty", init: () => {} },useTranslation: () => ({ t: (key: string) => key }),}));@@ -61,7 +62,8 @@ vi.mock("@/utils", () => ({}));vi.mock("@/stores", () => ({ pushNotification: mocks.pushNotification }));-vi.mock("@/stores/modules/v1/common", () => ({+vi.mock("@/stores/modules/v1/common", async (importOriginal) => ({+ ...(await importOriginal<typeof import("@/stores/modules/v1/common")>()),projectNamePrefix: "projects/",}));diff --git a/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.test.tsx b/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.test.tsxindex 8708b73d5d..0d461ffbd3 100644--- a/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.test.tsx+++ b/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.test.tsx@@ -168,24 +168,29 @@ describe("IssueDetailCommentList", () => {).toBe("chart");});- test("heads a review result with its reviewer, priority, and targets", () => {+ test("heads a review result with its reviewer, then its targets and priority", () => {mocks.comments = [comment("result", true)];render(<IssueDetailCommentList />);expect(screen.queryByTestId("comment-row")).toBeNull();const header = screen.getByTestId("row-header");expect(header.textContent).toContain("sql-review.ai-review.self");- expect(screen.getByTestId("review-priority").textContent).toBe("P1");+ expect(header.querySelector("[data-testid='review-priority']")).toBeNull();expect(screen.getByTestId("review-targets").textContent).toContain("instances/i/databases/d");+ expect(+ screen.getByTestId("review-heading").querySelector("[data-testid='review-priority']")+ ?.textContent+ ).toBe("P1");});- test("names the standard rule of a RULE result", () => {+ test("names the standard rule and codes of a RULE result", () => {const rule = comment("rule", true);if (rule.reviewMetadata) {rule.reviewMetadata.runType = ReviewRun_Type.RULE;rule.reviewMetadata.ruleType = ReviewRuleType.REQUIRE_WHERE;+ rule.reviewMetadata.codes = ["WH101"];}mocks.comments = [rule];render(<IssueDetailCommentList />);@@ -193,9 +198,13 @@ describe("IssueDetailCommentList", () => {expect(screen.getByTestId("row-header").textContent).toContain("sql-review.standard-rules.self");- expect(screen.getByTestId("review-rule").textContent).toContain(+ const heading = screen.getByTestId("review-heading");+ expect(heading.querySelector("[data-testid='review-rule']")?.textContent).toBe("sql-review.standard-rules.rule.require-where.title");+ expect(heading.querySelector("[data-testid='review-code']")?.textContent).toBe(+ "WH101"+ );});test("renders a member's comment with its images, as before", () => {diff --git a/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.tsx b/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.tsxindex 3996d9ef46..3364622bcf 100644--- a/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.tsx+++ b/frontend/src/routes/project/issue-detail/components/IssueDetailCommentList.tsx@@ -41,7 +41,6 @@ import {type IssueComment,type IssueComment_ReviewMetadata,IssueSchema,- ReviewRun_Type,UpdateIssueRequestSchema,} from "@/types/proto-es/v1/issue_service_pb";import type { Plan } from "@/types/proto-es/v1/plan_service_pb";@@ -50,8 +49,7 @@ import { hasProjectPermissionV2 } from "@/utils/iam/permission";import { PlanSpecChangeReference } from "../../plan-detail/components/PlanChangeReference";import {ReviewerIcon,- ReviewPriorityBadge,- ReviewRule,+ ReviewHeading,ReviewTargets,reviewerName,} from "../../plan-detail/components/threads/ReviewResult";@@ -598,9 +596,9 @@ function EditableMarkdownContent({);}-// A review result in an activity timeline. It is headed by its reviewer,-// priority, and targets, as on the plan page's thread card, since it has no-// creator to name.+// A review result in an activity timeline, laid out as on the plan page's+// thread card: headed by its reviewer, since it has no creator to name, then+// its targets, its priority and rule, and its text.function ReviewResultActivityRow({body,comment,@@ -628,10 +626,8 @@ function ReviewResultActivityRow({body={<div className="flex flex-col gap-y-2"><ReviewTargets spec={spec} targets={review.targets} />+ <ReviewHeading review={review} />{body}- {review.runType === ReviewRun_Type.RULE && (- <ReviewRule ruleType={review.ruleType} />- )}</div>}header={@@ -639,7 +635,6 @@ function ReviewResultActivityRow({<span className="font-medium text-main">{reviewerName(t, review.runType)}</span>- <ReviewPriorityBadge priority={review.priority} /><HumanizeTs className="text-xs text-control-light" tsMs={createdTs} />{createdTs !== updatedTs && (<span className="text-control-light text-xs">diff --git a/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx b/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsxindex e6bc7a8930..4923ceb141 100644--- a/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.test.tsx@@ -292,6 +292,7 @@ describe("CommentThreadCard", () => {expect(replies?.contains(comments[1])).toBe(true);expect(replies?.contains(comments[2])).toBe(true);expect(container.querySelector("[data-thread-state]")?.getAttribute("data-thread-state")).toBe("open");+ expect(container.querySelector("[data-testid='thread-state']")).toBeNull();expect(buttonByText("plan.review.thread.resolve")).toBeDefined();expect(buttonByText("plan.review.thread.reply-placeholder")).toBeDefined();});@@ -313,6 +314,29 @@ describe("CommentThreadCard", () => {).toHaveLength(2);expect(buttonByText("common.reopen")).toBeDefined();expect(buttonByText("plan.review.thread.resolve")).toBeUndefined();+ const states = container.querySelectorAll("[data-testid='thread-state']");+ expect(states).toHaveLength(1);+ expect(+ container.querySelector("[data-testid='thread-reply-footer']")?.contains(states[0])+ ).toBe(true);+ });++ test("a resolved thread says so in its footer when the reader can neither reply nor reopen", () => {+ mocks.hasPermission.mockReturnValue(false);+ const [thread] = groupThreads([comment("root", "Root", { resolved: true })]);+ render(+ <CommentThreadCard+ collapsible={false}+ issue={issue}+ project={project}+ thread={thread}+ />+ );+ const footer = container.querySelector("[data-testid='thread-reply-footer']");+ expect(footer?.querySelector("[data-testid='thread-state']")?.textContent).toBe(+ "plan.review.thread.resolved"+ );+ expect(footer?.querySelectorAll("button")).toHaveLength(0);});test("a resolved review result summarizes as its reviewer", () => {diff --git a/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.tsx b/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.tsxindex 9ee9724b20..f941f2a2c3 100644--- a/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/CommentThreadCard.tsx@@ -46,9 +46,10 @@ const FOLD_REPLIES_ABOVE = 4;// The same thread presentation for the statement editor and the Review// Activity timeline: root and replies in one card, Reply and Resolve or Reopen-// in the footer. The reply composer carries a checkbox that mirrors the thread-// state and, when toggled, settles the thread after the reply is posted.-// Resolved threads collapse to a summary row.+// in the footer, where a resolved thread also says so. The reply composer+// carries a checkbox that mirrors the thread state and, when toggled, settles+// the thread after the reply is posted. Resolved threads collapse to a+// summary row.export function CommentThreadCard({className,collapsible = true,@@ -250,15 +251,10 @@ export function CommentThreadCard({</>}comment={thread.root}+ label={label}onEdit={actions.edit}project={project}spec={spec}- status={- <>- {label}- <ThreadStateBadge resolved={thread.resolved} />- </>- }/>{(hiddenCount > 0 || visibleReplies.length > 0) && (<div@@ -291,7 +287,7 @@ export function CommentThreadCard({))}</div>)}- {(allowReply || allowSettle) && (+ {(allowReply || allowSettle || thread.resolved) && (<divclassName="flex flex-wrap items-center gap-2 border-t border-block-border bg-control-bg/50 px-2 py-2 sm:px-3"ref={replyFooterRef}@@ -372,6 +368,7 @@ export function CommentThreadCard({</>)}{!allowReply && <span className="flex-1" />}+ {thread.resolved && !replyOpen && <ThreadStateBadge />}{allowSettle && !replyOpen && (<Buttonappearance="outline"@@ -431,7 +428,7 @@ function ThreadSummary({className="hidden shrink-0 text-xs text-control-light sm:inline"tsMs={getTimeForPbTimestampProtoEs(thread.root.createTime)}/>- <ThreadStateBadge resolved />+ <ThreadStateBadge /><ChevronDown className="size-4 shrink-0 text-control-light" /></Button>);diff --git a/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.test.tsx b/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.test.tsxindex a7b0424fda..8fdce401c3 100644--- a/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.test.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.test.tsx@@ -1,7 +1,11 @@import { create } from "@bufbuild/protobuf";import { cleanup, fireEvent, render } from "@testing-library/react";import { afterEach, describe, expect, test, vi } from "vitest";-import { IssueComment_ReviewMetadata_Priority } from "@/types/proto-es/v1/issue_service_pb";+import {+ IssueComment_ReviewMetadata_Priority,+ IssueComment_ReviewMetadataSchema,+ ReviewRun_Type,+} from "@/types/proto-es/v1/issue_service_pb";import { ReviewRuleType } from "@/types/proto-es/v1/review_rule_pb";import {Plan_ChangeDatabaseConfigSchema,@@ -27,6 +31,7 @@ vi.mock("../PlanTargetDisplay", () => ({}));import {+ ReviewHeading,ReviewPriorityBadge,ReviewRule,ReviewTargets,@@ -58,10 +63,10 @@ const changeSpec = (describe("ReviewPriorityBadge", () => {test.each([- [IssueComment_ReviewMetadata_Priority.P0, "P0", "plan.review.thread.priority.p0"],+ [IssueComment_ReviewMetadata_Priority.P0, "P0", null],[IssueComment_ReviewMetadata_Priority.P1, "P1", "plan.review.thread.priority.p1"],[IssueComment_ReviewMetadata_Priority.P2, "P2", "plan.review.thread.priority.p2"],- ])("labels priority %s as %s and explains it", (priority, label, description) => {+ ])("labels priority %s as %s, explained by %s", (priority, label, description) => {const { getByTestId } = render(<ReviewPriorityBadge priority={priority} />);expect(getByTestId("review-priority").textContent).toBe(label);expect(getByTestId("review-priority").getAttribute("title")).toBe(description);@@ -82,9 +87,7 @@ describe("ReviewRule", () => {const { getByTestId } = render(<ReviewRule ruleType={ReviewRuleType.REQUIRE_WHERE} />);- const rule = getByTestId("review-rule");- expect(rule.firstElementChild?.textContent).toBe("plan.review.thread.rule");- expect(rule.lastElementChild?.textContent).toBe(+ expect(getByTestId("review-rule").textContent).toBe("sql-review.standard-rules.rule.require-where.title");});@@ -97,6 +100,60 @@ describe("ReviewRule", () => {});});+describe("ReviewHeading", () => {+ const codesOf = (container: HTMLElement) =>+ Array.from(container.querySelectorAll("[data-testid='review-code']")).map(+ (node) => node.textContent+ );++ test("puts a rule result's priority, rule, and codes on one line", () => {+ const { getByTestId } = render(+ <ReviewHeading+ review={create(IssueComment_ReviewMetadataSchema, {+ runType: ReviewRun_Type.RULE,+ ruleType: ReviewRuleType.PRIOR_BACKUP,+ priority: IssueComment_ReviewMetadata_Priority.P0,+ codes: ["PB103", "PB102"],+ })}+ />+ );+ const heading = getByTestId("review-heading");+ expect(+ Array.from(heading.children).map((node) => node.getAttribute("data-testid"))+ ).toEqual(["review-priority", "review-rule", "review-code", "review-code"]);+ expect(codesOf(heading)).toEqual(["PB103", "PB102"]);+ });++ test("shows a rule result without codes by its priority and rule", () => {+ const { container, getByTestId } = render(+ <ReviewHeading+ review={create(IssueComment_ReviewMetadataSchema, {+ runType: ReviewRun_Type.RULE,+ ruleType: ReviewRuleType.REQUIRE_WHERE,+ priority: IssueComment_ReviewMetadata_Priority.P1,+ })}+ />+ );+ expect(getByTestId("review-rule")).toBeInTheDocument();+ expect(codesOf(container)).toEqual([]);+ });++ test("shows an AI result by its priority alone", () => {+ const { container, getByTestId } = render(+ <ReviewHeading+ review={create(IssueComment_ReviewMetadataSchema, {+ runType: ReviewRun_Type.AI,+ priority: IssueComment_ReviewMetadata_Priority.P2,+ codes: ["WT101"],+ })}+ />+ );+ expect(getByTestId("review-priority").textContent).toBe("P2");+ expect(container.querySelector("[data-testid='review-rule']")).toBeNull();+ expect(codesOf(container)).toEqual([]);+ });+});+describe("ReviewTargets", () => {test("shows a short list whole", () => {const { container, queryByRole } = render(diff --git a/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.tsx b/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.tsxindex cec53cde3c..cfa6e906a0 100644--- a/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/ReviewResult.tsx@@ -2,6 +2,7 @@ import type { TFunction } from "i18next";import { Bot, ListChecks } from "lucide-react";import { type ReactNode, useState } from "react";import { useTranslation } from "react-i18next";+import { FindingCodeBadge } from "@/components/sql-review/FindingCodeBadge";import { standardRuleText } from "@/components/sql-review/standardRules";import { UserAvatar } from "@/components/UserAvatar";import { Badge, type BadgeProps, badgeVariants } from "@/components/ui/badge";@@ -12,6 +13,7 @@ import { cn } from "@/lib/utils";import { isValidDatabaseName, unknownUser } from "@/types";import {type IssueComment,+ type IssueComment_ReviewMetadata,IssueComment_ReviewMetadata_Priority,ReviewRun_Type,} from "@/types/proto-es/v1/issue_service_pb";@@ -97,16 +99,14 @@ export function ReviewPriorityBadge({);}+// A priority's badge color and, for P1 and P2, what it means.export function priorityStyle(t: TFunction,priority: IssueComment_ReviewMetadata_Priority-): { description: string; variant: BadgeProps["variant"] } | undefined {+): { description?: string; variant: BadgeProps["variant"] } | undefined {switch (priority) {case IssueComment_ReviewMetadata_Priority.P0:- return {- description: t("plan.review.thread.priority.p0"),- variant: "destructive",- };+ return { variant: "destructive" };case IssueComment_ReviewMetadata_Priority.P1:return {description: t("plan.review.thread.priority.p1"),@@ -122,27 +122,47 @@ export function priorityStyle(}}+// A review result's heading line: its priority, then for a rule review+// result the rule and the finding codes. An AI result names its rule in its+// text.+export function ReviewHeading({+ review,+}: {+ review: IssueComment_ReviewMetadata;+}) {+ const isRule = review.runType === ReviewRun_Type.RULE;+ return (+ <div+ className="flex min-w-0 flex-wrap items-center gap-x-2 gap-y-1"+ data-testid="review-heading"+ >+ <ReviewPriorityBadge priority={review.priority} />+ {isRule && <ReviewRule ruleType={review.ruleType} />}+ {isRule &&+ review.codes.map((code) => <FindingCodeBadge code={code} key={code} />)}+ </div>+ );+}+// The standard rule a rule review result reports, in the reader's language,-// with what the rule checks on hover. An AI result names its rule in its text.+// with what the rule checks on hover.export function ReviewRule({ ruleType }: { ruleType: ReviewRuleType }) {const { t } = useTranslation();if (ruleType === ReviewRuleType.REVIEW_RULE_TYPE_UNSPECIFIED) return null;const { title, description } = standardRuleText(t, ruleType);return (- <div- className="flex min-w-0 items-baseline gap-x-2 text-xs"- data-testid="review-rule"+ <Tooltip+ content={description}+ render={+ <span+ className="min-w-0 text-sm font-medium text-main"+ data-testid="review-rule"+ tabIndex={0}+ />+ }>- <span className="shrink-0 text-control-light">- {t("plan.review.thread.rule")}- </span>- <Tooltip- content={description}- render={<span className="min-w-0 text-control" tabIndex={0} />}- >- {title}- </Tooltip>- </div>+ {title}+ </Tooltip>);}@@ -165,7 +185,7 @@ export function ReviewTargets({const visible = folded ? targets.slice(0, VISIBLE_TARGETS) : targets;return (<div- className="flex min-w-0 items-baseline gap-x-2 text-xs"+ className="flex min-w-0 items-center gap-x-2 text-xs"data-testid="review-targets"><span className="shrink-0 text-control-light">diff --git a/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.test.tsx b/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.test.tsxindex cc9a9bd75e..647f2d8df8 100644--- a/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.test.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.test.tsx@@ -143,18 +143,26 @@ describe("ThreadComment", () => {label: "P1",},])(- "shows a $label review result as $reviewer with the databases it applies to",+ "shows a $label review result as $reviewer, then its databases, then its priority",({ runType, reviewer, priority, label }) => {const { container, getByTestId } = renderComment(reviewResult("Missing WHERE clause.", runType, priority));- const header = getByTestId("comment-content").firstElementChild as HTMLElement;+ const content = getByTestId("comment-content");+ const header = content.firstElementChild as HTMLElement;expect(within(header).getByTitle(reviewer).textContent).toBe(reviewer);expect(within(header).getByTestId("reviewer-avatar")).toBeDefined();- expect(within(header).getByTestId("review-priority").textContent).toBe(- label- );+ expect(within(header).queryByTestId("review-priority")).toBeNull();+ expect(+ Array.from(content.children)+ .slice(1, 3)+ .map((node) => node.getAttribute("data-testid"))+ ).toEqual(["review-targets", "review-heading"]);+ expect(+ within(getByTestId("review-heading")).getByTestId("review-priority")+ .textContent+ ).toBe(label);expect(Array.from(container.querySelectorAll("[data-testid='target']")).map((node) => node.textContent@@ -165,7 +173,7 @@ describe("ThreadComment", () => {});- test("names the standard rule of a RULE result, and no rule for an AI result", () => {+ test("names the standard rule and codes of a RULE result, and no rule for an AI result", () => {const rule = reviewResult("DELETE FROM employee has no WHERE clause",ReviewRun_Type.RULE,@@ -173,11 +181,14 @@ describe("ThreadComment", () => {);if (rule.reviewMetadata) {rule.reviewMetadata.ruleType = ReviewRuleType.REQUIRE_WHERE;+ rule.reviewMetadata.codes = ["WH101"];}const { getByTestId } = renderComment(rule);- expect(getByTestId("review-rule").textContent).toContain(+ const heading = getByTestId("review-heading");+ expect(within(heading).getByTestId("review-rule").textContent).toBe("sql-review.standard-rules.rule.require-where.title");+ expect(within(heading).getByTestId("review-code").textContent).toBe("WH101");cleanup();const { container } = renderComment(reviewResult("Missing WHERE clause."));diff --git a/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.tsx b/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.tsxindex 415e043504..94703c19d6 100644--- a/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/ThreadComment.tsx@@ -8,37 +8,33 @@ import { Button } from "@/components/ui/button";import { cn } from "@/lib/utils";import { getTimeForPbTimestampProtoEs } from "@/types";import type { IssueComment } from "@/types/proto-es/v1/issue_service_pb";-import { ReviewRun_Type } from "@/types/proto-es/v1/issue_service_pb";import type { Plan_Spec } from "@/types/proto-es/v1/plan_service_pb";import type { Project } from "@/types/proto-es/v1/project_service_pb";-import {- ReviewPriorityBadge,- ReviewRule,- ReviewTargets,- useCommentAuthor,-} from "./ReviewResult";+import { ReviewHeading, ReviewTargets, useCommentAuthor } from "./ReviewResult";// Roots and replies share one layout: author identity in the header, with// the body aligned to the comment region rather than indented below the name.+// A review result follows the header with its targets, then its priority and+// rule, then its text.export function ThreadComment({actions,className,comment,+ label,onEdit,project,spec,- status,}: {// Header actions after the edit button (thread collapse or close).actions?: ReactNode;className?: string;comment: IssueComment;+ // Extra header text after the timestamp (the anchored line range).+ label?: ReactNode;onEdit: (issueCommentName: string, comment: string) => Promise<unknown>;project: Project | undefined;// The plan spec the thread sits on, when the owner knows it.spec?: Plan_Spec;- // Thread status shown after the timestamp (resolved).- status?: ReactNode;}) {const { t } = useTranslation();const author = useCommentAuthor(comment);@@ -92,7 +88,6 @@ export function ThreadComment({{author.name}</span></div>- {review && <ReviewPriorityBadge priority={review.priority} />}<HumanizeTsclassName="hidden shrink-0 whitespace-nowrap text-xs text-control-light @2xs/comment:inline"tsMs={createdTs}@@ -102,7 +97,7 @@ export function ThreadComment({({t("common.edited")})</span>)}- {status}+ {label}</div><div className="flex shrink-0 items-center gap-x-1">{allowEdit && !isEditing && (@@ -122,14 +117,17 @@ export function ThreadComment({</div></div>{review && (- <ReviewTargets- spec={- spec && comment.statementAnchor?.spec === spec.id- ? spec- : undefined- }- targets={review.targets}- />+ <>+ <ReviewTargets+ spec={+ spec && comment.statementAnchor?.spec === spec.id+ ? spec+ : undefined+ }+ targets={review.targets}+ />+ <ReviewHeading review={review} />+ </>)}{isEditing ? (<div className="flex flex-col gap-y-2">@@ -172,9 +170,6 @@ export function ThreadComment({</div>))}- {review?.runType === ReviewRun_Type.RULE && (- <ReviewRule ruleType={review.ruleType} />- )}</div></div>);diff --git a/frontend/src/routes/project/plan-detail/components/threads/ThreadStack.tsx b/frontend/src/routes/project/plan-detail/components/threads/ThreadStack.tsxindex f4314f243a..591d526494 100644--- a/frontend/src/routes/project/plan-detail/components/threads/ThreadStack.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/ThreadStack.tsx@@ -214,7 +214,7 @@ function CollapsedThreadRow({className="hidden shrink-0 text-xs text-control-light @xl:inline"tsMs={getTimeForPbTimestampProtoEs(comment.createTime)}/>- {resolved && <ThreadStateBadge resolved />}+ {resolved && <ThreadStateBadge />}<ChevronDown className="size-4 shrink-0 text-control-light" /></Button>);diff --git a/frontend/src/routes/project/plan-detail/components/threads/ThreadStateBadge.tsx b/frontend/src/routes/project/plan-detail/components/threads/ThreadStateBadge.tsxindex 9fd640ea30..d90cdc2acb 100644--- a/frontend/src/routes/project/plan-detail/components/threads/ThreadStateBadge.tsx+++ b/frontend/src/routes/project/plan-detail/components/threads/ThreadStateBadge.tsx@@ -1,25 +1,17 @@import { CircleCheck } from "lucide-react";import { useTranslation } from "react-i18next";-import { Badge } from "@/components/ui/badge";-// An open thread needs someone, so it carries the colored badge; a resolved-// one is quiet gray text.-export function ThreadStateBadge({ resolved }: { resolved: boolean }) {+// Marks a resolved thread in quiet gray text. Open is a thread's default+// state and carries no mark.+export function ThreadStateBadge() {const { t } = useTranslation();- if (resolved) {- return (- <span- className="inline-flex shrink-0 items-center gap-x-1 text-xs text-control-light"- data-testid="thread-state"- >- <CircleCheck className="size-3" />- {t("plan.review.thread.resolved")}- </span>- );- }return (- <Badge className="shrink-0" data-testid="thread-state" variant="attention">- {t("plan.review.thread.open")}- </Badge>+ <span+ className="inline-flex shrink-0 items-center gap-x-1 text-xs text-control-light"+ data-testid="thread-state"+ >+ <CircleCheck className="size-3" />+ {t("plan.review.thread.resolved")}+ </span>);}diff --git a/frontend/src/routes/project/plan-detail/utils/reviewScope.ts b/frontend/src/routes/project/plan-detail/utils/reviewScope.tsindex 742c09baee..2541a23b20 100644--- a/frontend/src/routes/project/plan-detail/utils/reviewScope.ts+++ b/frontend/src/routes/project/plan-detail/utils/reviewScope.ts@@ -1,20 +1,11 @@+import { RULE_REVIEW_ENGINES } from "@/components/sql-review/standardRuleCatalog";import { isValidDatabaseGroupName } from "@/types/dbGroup";-import { Engine } from "@/types/proto-es/v1/common_pb";+import type { Engine } from "@/types/proto-es/v1/common_pb";import type { Plan } from "@/types/proto-es/v1/plan_service_pb";-// Engines the standard rule review covers. Mirrors reviewFuncs in-// backend/runner/reviewrun/review_funcs.go; a target on any other engine is-// reviewed by the plan checks' review policy instead.-const RULE_REVIEW_ENGINES: ReadonlySet<Engine> = new Set([- Engine.POSTGRES,- Engine.MYSQL,- Engine.OCEANBASE,- Engine.MARIADB,- Engine.TIDB,- Engine.MSSQL,- Engine.ORACLE,- Engine.SNOWFLAKE,-]);+const RULE_REVIEW_ENGINE_SET: ReadonlySet<Engine> = new Set(+ RULE_REVIEW_ENGINES+);export interface ReviewScope {// The databases the reviewer reviews, in plan order.@@ -56,7 +47,7 @@ export function reviewScope(options.reviewer === "rule"? targets.filter((database) => {const engine = options.engineOf(database);- return engine === undefined || RULE_REVIEW_ENGINES.has(engine);+ return engine === undefined || RULE_REVIEW_ENGINE_SET.has(engine);}): targets;for (const database of eligible) candidates.add(database);diff --git a/frontend/src/routes/workspace/SQLReviewStandardRulesSection.test.tsx b/frontend/src/routes/workspace/SQLReviewStandardRulesSection.test.tsxindex 487f92ae3b..fe98b295ac 100644--- a/frontend/src/routes/workspace/SQLReviewStandardRulesSection.test.tsx+++ b/frontend/src/routes/workspace/SQLReviewStandardRulesSection.test.tsx@@ -22,6 +22,7 @@ const mocks = vi.hoisted(() => ({}));vi.mock("react-i18next", () => ({+ initReactI18next: { type: "3rdParty", init: () => {} },useTranslation: () => ({ t: (key: string) => key }),}));diff --git a/frontend/src/types/proto-es/v1/issue_service_pb.d.ts b/frontend/src/types/proto-es/v1/issue_service_pb.d.tsindex 8cbe4d7dc6..6cc3022f25 100644--- a/frontend/src/types/proto-es/v1/issue_service_pb.d.ts+++ b/frontend/src/types/proto-es/v1/issue_service_pb.d.ts@@ -1117,6 +1117,15 @@ export declare type IssueComment_ReviewMetadata = Message<"bytebase.v1.IssueComm* @generated from field: int64 attempt = 6;*/attempt: bigint;++ /**+ * The conditions a RULE result reports, as finding codes such as+ * "WT101", one per reason. A code names the same condition on every+ * engine. Empty for other reviewers.+ *+ * @generated from field: repeated string codes = 7;+ */+ codes: string[];};/**diff --git a/frontend/src/types/proto-es/v1/issue_service_pb.js b/frontend/src/types/proto-es/v1/issue_service_pb.jsindex b8165ff89e..118db1215c 100644--- a/frontend/src/types/proto-es/v1/issue_service_pb.js+++ b/frontend/src/types/proto-es/v1/issue_service_pb.js@@ -19,7 +19,7 @@ import { file_v1_review_rule } from "./review_rule_pb";* Describes the file v1/issue_service.proto.*/export const file_v1_issue_service = /*@__PURE__*/- fileDesc("ChZ2MS9pc3N1ZV9zZXJ2aWNlLnByb3RvEgtieXRlYmFzZS52MSJKCg9HZXRJc3N1ZVJlcXVlc3QSKAoEbmFtZRgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSDQoFZm9yY2UYAiABKAgiagoSQ3JlYXRlSXNzdWVSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBImCgVpc3N1ZRgCIAEoCzISLmJ5dGViYXNlLnYxLklzc3VlQgPgQQIimQEKEUxpc3RJc3N1ZXNSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBIRCglwYWdlX3NpemUYAiABKAUSEgoKcGFnZV90b2tlbhgDIAEoCRIOCgZmaWx0ZXIYBCABKAkSDQoFcXVlcnkYBSABKAkSEAoIb3JkZXJfYnkYBiABKAkiUQoSTGlzdElzc3Vlc1Jlc3BvbnNlEiIKBmlzc3VlcxgBIAMoCzISLmJ5dGViYXNlLnYxLklzc3VlEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSKCAQoTU2VhcmNoSXNzdWVzUmVxdWVzdBITCgZwYXJlbnQYASABKAlCA+BBAhIRCglwYWdlX3NpemUYAiABKAUSEgoKcGFnZV90b2tlbhgDIAEoCRIOCgZmaWx0ZXIYBCABKAkSDQoFcXVlcnkYBSABKAkSEAoIb3JkZXJfYnkYBiABKAkiUwoUU2VhcmNoSXNzdWVzUmVzcG9uc2USIgoGaXNzdWVzGAEgAygLMhIuYnl0ZWJhc2UudjEuSXNzdWUSFwoPbmV4dF9wYWdlX3Rva2VuGAIgASgJIqABChJVcGRhdGVJc3N1ZVJlcXVlc3QSPQoFaXNzdWUYASABKAsyEi5ieXRlYmFzZS52MS5Jc3N1ZUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSNAoLdXBkYXRlX21hc2sYAiABKAsyGi5nb29nbGUucHJvdG9idWYuRmllbGRNYXNrQgPgQQISFQoNYWxsb3dfbWlzc2luZxgDIAEoCCKYAQoeQmF0Y2hVcGRhdGVJc3N1ZXNTdGF0dXNSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBIOCgZpc3N1ZXMYAiADKAkSKAoGc3RhdHVzGAMgASgOMhguYnl0ZWJhc2UudjEuSXNzdWVTdGF0dXMSDgoGcmVhc29uGAQgASgJIiEKH0JhdGNoVXBkYXRlSXNzdWVzU3RhdHVzUmVzcG9uc2UiUAoTQXBwcm92ZUlzc3VlUmVxdWVzdBIoCgRuYW1lGAEgASgJQhrgQQL6QRQKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIPCgdjb21tZW50GAIgASgJIk8KElJlamVjdElzc3VlUmVxdWVzdBIoCgRuYW1lGAEgASgJQhrgQQL6QRQKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIPCgdjb21tZW50GAIgASgJIlAKE1JlcXVlc3RJc3N1ZVJlcXVlc3QSKAoEbmFtZRgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSDwoHY29tbWVudBgCIAEoCSJFChlSZXRyeUlzc3VlQXBwcm92YWxSZXF1ZXN0EigKBG5hbWUYASABKAlCGuBBAvpBFAoSYnl0ZWJhc2UuY29tL0lzc3VlIs8HCgVJc3N1ZRIMCgRuYW1lGAEgASgJEhcKBXRpdGxlGAIgASgJQgi6SAVyAxjIARIdCgtkZXNjcmlwdGlvbhgDIAEoCUIIukgFcgMYkE4SJQoEdHlwZRgEIAEoDjIXLmJ5dGViYXNlLnYxLklzc3VlLlR5cGUSKAoGc3RhdHVzGAUgASgOMhguYnl0ZWJhc2UudjEuSXNzdWVTdGF0dXMSLgoJYXBwcm92ZXJzGAYgAygLMhsuYnl0ZWJhc2UudjEuSXNzdWUuQXBwcm92ZXISOAoRYXBwcm92YWxfdGVtcGxhdGUYByABKAsyHS5ieXRlYmFzZS52MS5BcHByb3ZhbFRlbXBsYXRlEhQKB2NyZWF0b3IYCCABKAlCA+BBAxI0CgtjcmVhdGVfdGltZRgJIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxI0Cgt1cGRhdGVfdGltZRgKIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxIMCgRwbGFuGAsgASgJEioKCnJvbGVfZ3JhbnQYDSABKAsyFi5ieXRlYmFzZS52MS5Sb2xlR3JhbnQSKgoKcmlza19sZXZlbBgPIAEoDjIWLmJ5dGViYXNlLnYxLlJpc2tMZXZlbBIOCgZsYWJlbHMYESADKAkSOQoPYXBwcm92YWxfc3RhdHVzGBIgASgOMhsuYnl0ZWJhc2UudjEuQXBwcm92YWxTdGF0dXNCA+BBAxI2CgxhY2Nlc3NfZ3JhbnQYEyABKAlCIOBBA/pBGgoYYnl0ZWJhc2UuY29tL0FjY2Vzc0dyYW50EhIKBWRyYWZ0GBQgASgIQgPgQQEanAEKCEFwcHJvdmVyEjIKBnN0YXR1cxgBIAEoDjIiLmJ5dGViYXNlLnYxLklzc3VlLkFwcHJvdmVyLlN0YXR1cxIRCglwcmluY2lwYWwYAiABKAkiSQoGU3RhdHVzEhYKElNUQVRVU19VTlNQRUNJRklFRBAAEgsKB1BFTkRJTkcQARIMCghBUFBST1ZFRBACEgwKCFJFSkVDVEVEEAMiWQoEVHlwZRIUChBUWVBFX1VOU1BFQ0lGSUVEEAASEwoPREFUQUJBU0VfQ0hBTkdFEAESDgoKUk9MRV9HUkFOVBACEhAKDEFDQ0VTU19HUkFOVBAEIgQIAxADOjrqQTcKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIhcHJvamVjdHMve3Byb2plY3R9L2lzc3Vlcy97aXNzdWV9SgQIDBANSgQIDhAPSgQIEBARInwKCVJvbGVHcmFudBIMCgRyb2xlGAEgASgJEgwKBHVzZXIYAiABKAkSJAoJY29uZGl0aW9uGAMgASgLMhEuZ29vZ2xlLnR5cGUuRXhwchItCgpleHBpcmF0aW9uGAQgASgLMhkuZ29vZ2xlLnByb3RvYnVmLkR1cmF0aW9uIl8KEEFwcHJvdmFsVGVtcGxhdGUSJwoEZmxvdxgBIAEoCzIZLmJ5dGViYXNlLnYxLkFwcHJvdmFsRmxvdxINCgV0aXRsZRgCIAEoCRITCgtkZXNjcmlwdGlvbhgDIAEoCSIdCgxBcHByb3ZhbEZsb3cSDQoFcm9sZXMYASADKAkifQoYTGlzdElzc3VlQ29tbWVudHNSZXF1ZXN0EioKBnBhcmVudBgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSEQoJcGFnZV9zaXplGAIgASgFEhIKCnBhZ2VfdG9rZW4YAyABKAkSDgoGZmlsdGVyGAQgASgJImcKGUxpc3RJc3N1ZUNvbW1lbnRzUmVzcG9uc2USMQoOaXNzdWVfY29tbWVudHMYASADKAsyGS5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQSFwoPbmV4dF9wYWdlX3Rva2VuGAIgASgJInkKGUNyZWF0ZUlzc3VlQ29tbWVudFJlcXVlc3QSKgoGcGFyZW50GAEgASgJQhrgQQL6QRQKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIwCg1pc3N1ZV9jb21tZW50GAIgASgLMhkuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50IsYBChlVcGRhdGVJc3N1ZUNvbW1lbnRSZXF1ZXN0EioKBnBhcmVudBgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSMAoNaXNzdWVfY29tbWVudBgCIAEoCzIZLmJ5dGViYXNlLnYxLklzc3VlQ29tbWVudBI0Cgt1cGRhdGVfbWFzaxgDIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2tCA+BBAhIVCg1hbGxvd19taXNzaW5nGAQgASgIIqMPCgxJc3N1ZUNvbW1lbnQSDAoEbmFtZRgBIAEoCRIaCgdjb21tZW50GAIgASgJQgm6SAZyBBiAgAQSDwoHcGF5bG9hZBgDIAEoCRI0CgtjcmVhdGVfdGltZRgEIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxI0Cgt1cGRhdGVfdGltZRgFIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxIUCgdjcmVhdG9yGAYgASgJQgPgQQMSFgoEcm9vdBgOIAEoCUID4EEFSAGIAQESQAoMdGhyZWFkX3N0YXRlGA8gASgOMiUuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LlRocmVhZFN0YXRlSAKIAQESOwoQc3RhdGVtZW50X2FuY2hvchgQIAEoCzIcLmJ5dGViYXNlLnYxLlN0YXRlbWVudEFuY2hvckID4EEFEkYKD3Jldmlld19tZXRhZGF0YRgRIAEoCzIoLmJ5dGViYXNlLnYxLklzc3VlQ29tbWVudC5SZXZpZXdNZXRhZGF0YUID4EEDEjYKCGFwcHJvdmFsGAcgASgLMiIuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LkFwcHJvdmFsSAASPQoMaXNzdWVfdXBkYXRlGAggASgLMiUuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50Lklzc3VlVXBkYXRlSAASOwoLcGxhbl91cGRhdGUYDCABKAsyJC5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQuUGxhblVwZGF0ZUgAEkcKEXJldmlld19zdWJtaXNzaW9uGA0gASgLMiouYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LlJldmlld1N1Ym1pc3Npb25IABJOChVyZXZpZXdfcnVuX2NvbXBsZXRpb24YEiABKAsyLS5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQuUmV2aWV3UnVuQ29tcGxldGlvbkgAGqgCCg5SZXZpZXdNZXRhZGF0YRItCghydW5fdHlwZRgBIAEoDjIbLmJ5dGViYXNlLnYxLlJldmlld1J1bi5UeXBlEi4KCXJ1bGVfdHlwZRgCIAEoDjIbLmJ5dGViYXNlLnYxLlJldmlld1J1bGVUeXBlEkMKCHByaW9yaXR5GAMgASgOMjEuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LlJldmlld01ldGFkYXRhLlByaW9yaXR5Eg8KB3RhcmdldHMYBCADKAkSEgoKc3VwZXJzZWRlZBgFIAEoCBIPCgdhdHRlbXB0GAYgASgDIjwKCFByaW9yaXR5EhgKFFBSSU9SSVRZX1VOU1BFQ0lGSUVEEAASBgoCUDAQARIGCgJQMRACEgYKAlAyEAMakAEKCEFwcHJvdmFsEjkKBnN0YXR1cxgBIAEoDjIpLmJ5dGViYXNlLnYxLklzc3VlQ29tbWVudC5BcHByb3ZhbC5TdGF0dXMiSQoGU3RhdHVzEhYKElNUQVRVU19VTlNQRUNJRklFRBAAEgsKB1BFTkRJTkcQARIMCghBUFBST1ZFRBACEgwKCFJFSkVDVEVEEAMa6QIKC0lzc3VlVXBkYXRlEhcKCmZyb21fdGl0bGUYASABKAlIAIgBARIVCgh0b190aXRsZRgCIAEoCUgBiAEBEh0KEGZyb21fZGVzY3JpcHRpb24YAyABKAlIAogBARIbCg50b19kZXNjcmlwdGlvbhgEIAEoCUgDiAEBEjIKC2Zyb21fc3RhdHVzGAUgASgOMhguYnl0ZWJhc2UudjEuSXNzdWVTdGF0dXNIBIgBARIwCgl0b19zdGF0dXMYBiABKA4yGC5ieXRlYmFzZS52MS5Jc3N1ZVN0YXR1c0gFiAEBEhMKC2Zyb21fbGFiZWxzGAcgAygJEhEKCXRvX2xhYmVscxgIIAMoCUINCgtfZnJvbV90aXRsZUILCglfdG9fdGl0bGVCEwoRX2Zyb21fZGVzY3JpcHRpb25CEQoPX3RvX2Rlc2NyaXB0aW9uQg4KDF9mcm9tX3N0YXR1c0IMCgpfdG9fc3RhdHVzGhIKEFJldmlld1N1Ym1pc3Npb24amQEKE1Jldmlld1J1bkNvbXBsZXRpb24SLQoIcnVuX3R5cGUYASABKA4yGy5ieXRlYmFzZS52MS5SZXZpZXdSdW4uVHlwZRIPCgdhdHRlbXB0GAIgASgDEhQKDHBvc3RlZF9jb3VudBgDIAEoBRISCgprZXB0X2NvdW50GAQgASgFEhgKEHN1cGVyc2VkZWRfY291bnQYBSABKAUaYgoKUGxhblVwZGF0ZRIqCgpmcm9tX3NwZWNzGAEgAygLMhYuYnl0ZWJhc2UudjEuUGxhbi5TcGVjEigKCHRvX3NwZWNzGAIgAygLMhYuYnl0ZWJhc2UudjEuUGxhbi5TcGVjIkMKC1RocmVhZFN0YXRlEhwKGFRIUkVBRF9TVEFURV9VTlNQRUNJRklFRBAAEggKBE9QRU4QARIMCghSRVNPTFZFRBACQgcKBWV2ZW50QgcKBV9yb290Qg8KDV90aHJlYWRfc3RhdGVKBAgJEAwikQEKD1N0YXRlbWVudEFuY2hvchIMCgRzcGVjGAEgASgJEhQKDHNoZWV0X3NoYTI1NhgCIAEoCRItCg5zdGFydF9wb3NpdGlvbhgDIAEoCzIVLmJ5dGViYXNlLnYxLlBvc2l0aW9uEisKDGVuZF9wb3NpdGlvbhgEIAEoCzIVLmJ5dGViYXNlLnYxLlBvc2l0aW9uIuwDCglSZXZpZXdSdW4SDAoEbmFtZRgBIAEoCRIuCgR0eXBlGAIgASgOMhsuYnl0ZWJhc2UudjEuUmV2aWV3UnVuLlR5cGVCA+BBAxIyCgZzdGF0dXMYAyABKA4yHS5ieXRlYmFzZS52MS5SZXZpZXdSdW4uU3RhdHVzQgPgQQMSNAoLY3JlYXRlX3RpbWUYBCABKAsyGi5nb29nbGUucHJvdG9idWYuVGltZXN0YW1wQgPgQQMSMQoIZW5kX3RpbWUYBSABKAsyGi5nb29nbGUucHJvdG9idWYuVGltZXN0YW1wQgPgQQMSEgoFZXJyb3IYBiABKAlCA+BBAxIVCghvdXRkYXRlZBgHIAEoCEID4EEDIi4KBFR5cGUSFAoQVFlQRV9VTlNQRUNJRklFRBAAEggKBFJVTEUQARIGCgJBSRACIlIKBlN0YXR1cxIWChJTVEFUVVNfVU5TUEVDSUZJRUQQABINCglBVkFJTEFCTEUQARILCgdSVU5OSU5HEAISCAoERE9ORRADEgoKBkZBSUxFRBAEOlXqQVIKFmJ5dGViYXNlLmNvbS9SZXZpZXdSdW4SOHByb2plY3RzL3twcm9qZWN0fS9pc3N1ZXMve2lzc3VlfS9yZXZpZXdSdW5zL3tyZXZpZXdSdW59IkMKE0dldFJldmlld1J1blJlcXVlc3QSLAoEbmFtZRgBIAEoCUIe4EEC+kEYChZieXRlYmFzZS5jb20vUmV2aWV3UnVuIkAKEFJ1blJldmlld1JlcXVlc3QSLAoEbmFtZRgBIAEoCUIe4EEC+kEYChZieXRlYmFzZS5jb20vUmV2aWV3UnVuMvQTCgxJc3N1ZVNlcnZpY2UShAEKCEdldElzc3VlEhwuYnl0ZWJhc2UudjEuR2V0SXNzdWVSZXF1ZXN0GhIuYnl0ZWJhc2UudjEuSXNzdWUiRtpBBG5hbWWK6jANYmIuaXNzdWVzLmdldJDqMAGg6jABgtPkkwIgEh4vdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKn0SoAEKC0NyZWF0ZUlzc3VlEh8uYnl0ZWJhc2UudjEuQ3JlYXRlSXNzdWVSZXF1ZXN0GhIuYnl0ZWJhc2UudjEuSXNzdWUiXNpBDHBhcmVudCxpc3N1ZYrqMBBiYi5pc3N1ZXMuY3JlYXRlkOowAZjqMAGg6jACgtPkkwInOgVpc3N1ZSIeL3YxL3twYXJlbnQ9cHJvamVjdHMvKn0vaXNzdWVzEpgBCgpMaXN0SXNzdWVzEh4uYnl0ZWJhc2UudjEuTGlzdElzc3Vlc1JlcXVlc3QaHy5ieXRlYmFzZS52MS5MaXN0SXNzdWVzUmVzcG9uc2UiSdpBBnBhcmVudIrqMA5iYi5pc3N1ZXMubGlzdJDqMAGg6jABgtPkkwIgEh4vdjEve3BhcmVudD1wcm9qZWN0cy8qfS9pc3N1ZXMSngEKDFNlYXJjaElzc3VlcxIgLmJ5dGViYXNlLnYxLlNlYXJjaElzc3Vlc1JlcXVlc3QaIS5ieXRlYmFzZS52MS5TZWFyY2hJc3N1ZXNSZXNwb25zZSJJiuowDWJiLmlzc3Vlcy5nZXSQ6jACoOowAYLT5JMCKjoBKiIlL3YxL3twYXJlbnQ9cHJvamVjdHMvKn0vaXNzdWVzOnNlYXJjaBKrAQoLVXBkYXRlSXNzdWUSHy5ieXRlYmFzZS52MS5VcGRhdGVJc3N1ZVJlcXVlc3QaEi5ieXRlYmFzZS52MS5Jc3N1ZSJn2kERaXNzdWUsdXBkYXRlX21hc2uK6jAQYmIuaXNzdWVzLnVwZGF0ZZDqMAGY6jABoOowAoLT5JMCLToFaXNzdWUyJC92MS97aXNzdWUubmFtZT1wcm9qZWN0cy8qL2lzc3Vlcy8qfRLEAQoRTGlzdElzc3VlQ29tbWVudHMSJS5ieXRlYmFzZS52MS5MaXN0SXNzdWVDb21tZW50c1JlcXVlc3QaJi5ieXRlYmFzZS52MS5MaXN0SXNzdWVDb21tZW50c1Jlc3BvbnNlImDaQQZwYXJlbnSK6jAVYmIuaXNzdWVDb21tZW50cy5saXN0kOowAaDqMAGC0+STAjASLi92MS97cGFyZW50PXByb2plY3RzLyovaXNzdWVzLyp9L2lzc3VlQ29tbWVudHMS1gEKEkNyZWF0ZUlzc3VlQ29tbWVudBImLmJ5dGViYXNlLnYxLkNyZWF0ZUlzc3VlQ29tbWVudFJlcXVlc3QaGS5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQifdpBFHBhcmVudCxpc3N1ZV9jb21tZW50iuowF2JiLmlzc3VlQ29tbWVudHMuY3JlYXRlkOowAZjqMAGg6jACgtPkkwI5Og1pc3N1ZV9jb21tZW50IigvdjEve3BhcmVudD1wcm9qZWN0cy8qL2lzc3Vlcy8qfTpjb21tZW50EuMBChJVcGRhdGVJc3N1ZUNvbW1lbnQSJi5ieXRlYmFzZS52MS5VcGRhdGVJc3N1ZUNvbW1lbnRSZXF1ZXN0GhkuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50IokB2kEgcGFyZW50LGlzc3VlX2NvbW1lbnQsdXBkYXRlX21hc2uK6jAXYmIuaXNzdWVDb21tZW50cy51cGRhdGWQ6jABmOowAaDqMAKC0+STAjk6DWlzc3VlX2NvbW1lbnQyKC92MS97cGFyZW50PXByb2plY3RzLyovaXNzdWVzLyp9OmNvbW1lbnQS0QEKF0JhdGNoVXBkYXRlSXNzdWVzU3RhdHVzEisuYnl0ZWJhc2UudjEuQmF0Y2hVcGRhdGVJc3N1ZXNTdGF0dXNSZXF1ZXN0GiwuYnl0ZWJhc2UudjEuQmF0Y2hVcGRhdGVJc3N1ZXNTdGF0dXNSZXNwb25zZSJbiuowEGJiLmlzc3Vlcy51cGRhdGWQ6jABmOowAaDqMAKC0+STAjU6ASoiMC92MS97cGFyZW50PXByb2plY3RzLyp9L2lzc3VlczpiYXRjaFVwZGF0ZVN0YXR1cxKDAQoMQXBwcm92ZUlzc3VlEiAuYnl0ZWJhc2UudjEuQXBwcm92ZUlzc3VlUmVxdWVzdBoSLmJ5dGViYXNlLnYxLklzc3VlIj2Q6jACmOowAaDqMAKC0+STAis6ASoiJi92MS97bmFtZT1wcm9qZWN0cy8qL2lzc3Vlcy8qfTphcHByb3ZlEoABCgtSZWplY3RJc3N1ZRIfLmJ5dGViYXNlLnYxLlJlamVjdElzc3VlUmVxdWVzdBoSLmJ5dGViYXNlLnYxLklzc3VlIjyQ6jACmOowAaDqMAKC0+STAio6ASoiJS92MS97bmFtZT1wcm9qZWN0cy8qL2lzc3Vlcy8qfTpyZWplY3QSgwEKDFJlcXVlc3RJc3N1ZRIgLmJ5dGViYXNlLnYxLlJlcXVlc3RJc3N1ZVJlcXVlc3QaEi5ieXRlYmFzZS52MS5Jc3N1ZSI9kOowApjqMAGg6jACgtPkkwIrOgEqIiYvdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKn06cmVxdWVzdBKZAQoSUmV0cnlJc3N1ZUFwcHJvdmFsEiYuYnl0ZWJhc2UudjEuUmV0cnlJc3N1ZUFwcHJvdmFsUmVxdWVzdBoSLmJ5dGViYXNlLnYxLklzc3VlIkeQ6jACmOowAaDqMAOo6jAIgtPkkwIxOgEqIiwvdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKn06cmV0cnlBcHByb3ZhbBKhAQoMR2V0UmV2aWV3UnVuEiAuYnl0ZWJhc2UudjEuR2V0UmV2aWV3UnVuUmVxdWVzdBoWLmJ5dGViYXNlLnYxLlJldmlld1J1biJX2kEEbmFtZYrqMBFiYi5yZXZpZXdSdW5zLmdldJDqMAGg6jABgtPkkwItEisvdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKi9yZXZpZXdSdW5zLyp9EqYBCglSdW5SZXZpZXcSHS5ieXRlYmFzZS52MS5SdW5SZXZpZXdSZXF1ZXN0GhYuYnl0ZWJhc2UudjEuUmV2aWV3UnVuImLaQQRuYW1liuowEWJiLnJldmlld1J1bnMucnVukOowAZjqMAGg6jACgtPkkwI0OgEqIi8vdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKi9yZXZpZXdSdW5zLyp9OnJ1bkKnAQoPY29tLmJ5dGViYXNlLnYxQhFJc3N1ZVNlcnZpY2VQcm90b1ABWjRnaXRodWIuY29tL2J5dGViYXNlL2J5dGViYXNlL2JhY2tlbmQvZ2VuZXJhdGVkLWdvL3YxogIDQlhYqgILQnl0ZWJhc2UuVjHKAgtCeXRlYmFzZVxWMeICF0J5dGViYXNlXFYxXEdQQk1ldGFkYXRh6gIMQnl0ZWJhc2U6OlYxYgZwcm90bzM", [file_buf_validate_validate, file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_duration, file_google_protobuf_field_mask, file_google_protobuf_timestamp, file_google_type_expr, file_v1_annotation, file_v1_common, file_v1_plan_service, file_v1_review_rule]);+ fileDesc("ChZ2MS9pc3N1ZV9zZXJ2aWNlLnByb3RvEgtieXRlYmFzZS52MSJKCg9HZXRJc3N1ZVJlcXVlc3QSKAoEbmFtZRgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSDQoFZm9yY2UYAiABKAgiagoSQ3JlYXRlSXNzdWVSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBImCgVpc3N1ZRgCIAEoCzISLmJ5dGViYXNlLnYxLklzc3VlQgPgQQIimQEKEUxpc3RJc3N1ZXNSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBIRCglwYWdlX3NpemUYAiABKAUSEgoKcGFnZV90b2tlbhgDIAEoCRIOCgZmaWx0ZXIYBCABKAkSDQoFcXVlcnkYBSABKAkSEAoIb3JkZXJfYnkYBiABKAkiUQoSTGlzdElzc3Vlc1Jlc3BvbnNlEiIKBmlzc3VlcxgBIAMoCzISLmJ5dGViYXNlLnYxLklzc3VlEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSKCAQoTU2VhcmNoSXNzdWVzUmVxdWVzdBITCgZwYXJlbnQYASABKAlCA+BBAhIRCglwYWdlX3NpemUYAiABKAUSEgoKcGFnZV90b2tlbhgDIAEoCRIOCgZmaWx0ZXIYBCABKAkSDQoFcXVlcnkYBSABKAkSEAoIb3JkZXJfYnkYBiABKAkiUwoUU2VhcmNoSXNzdWVzUmVzcG9uc2USIgoGaXNzdWVzGAEgAygLMhIuYnl0ZWJhc2UudjEuSXNzdWUSFwoPbmV4dF9wYWdlX3Rva2VuGAIgASgJIqABChJVcGRhdGVJc3N1ZVJlcXVlc3QSPQoFaXNzdWUYASABKAsyEi5ieXRlYmFzZS52MS5Jc3N1ZUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSNAoLdXBkYXRlX21hc2sYAiABKAsyGi5nb29nbGUucHJvdG9idWYuRmllbGRNYXNrQgPgQQISFQoNYWxsb3dfbWlzc2luZxgDIAEoCCKYAQoeQmF0Y2hVcGRhdGVJc3N1ZXNTdGF0dXNSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBIOCgZpc3N1ZXMYAiADKAkSKAoGc3RhdHVzGAMgASgOMhguYnl0ZWJhc2UudjEuSXNzdWVTdGF0dXMSDgoGcmVhc29uGAQgASgJIiEKH0JhdGNoVXBkYXRlSXNzdWVzU3RhdHVzUmVzcG9uc2UiUAoTQXBwcm92ZUlzc3VlUmVxdWVzdBIoCgRuYW1lGAEgASgJQhrgQQL6QRQKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIPCgdjb21tZW50GAIgASgJIk8KElJlamVjdElzc3VlUmVxdWVzdBIoCgRuYW1lGAEgASgJQhrgQQL6QRQKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIPCgdjb21tZW50GAIgASgJIlAKE1JlcXVlc3RJc3N1ZVJlcXVlc3QSKAoEbmFtZRgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSDwoHY29tbWVudBgCIAEoCSJFChlSZXRyeUlzc3VlQXBwcm92YWxSZXF1ZXN0EigKBG5hbWUYASABKAlCGuBBAvpBFAoSYnl0ZWJhc2UuY29tL0lzc3VlIs8HCgVJc3N1ZRIMCgRuYW1lGAEgASgJEhcKBXRpdGxlGAIgASgJQgi6SAVyAxjIARIdCgtkZXNjcmlwdGlvbhgDIAEoCUIIukgFcgMYkE4SJQoEdHlwZRgEIAEoDjIXLmJ5dGViYXNlLnYxLklzc3VlLlR5cGUSKAoGc3RhdHVzGAUgASgOMhguYnl0ZWJhc2UudjEuSXNzdWVTdGF0dXMSLgoJYXBwcm92ZXJzGAYgAygLMhsuYnl0ZWJhc2UudjEuSXNzdWUuQXBwcm92ZXISOAoRYXBwcm92YWxfdGVtcGxhdGUYByABKAsyHS5ieXRlYmFzZS52MS5BcHByb3ZhbFRlbXBsYXRlEhQKB2NyZWF0b3IYCCABKAlCA+BBAxI0CgtjcmVhdGVfdGltZRgJIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxI0Cgt1cGRhdGVfdGltZRgKIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxIMCgRwbGFuGAsgASgJEioKCnJvbGVfZ3JhbnQYDSABKAsyFi5ieXRlYmFzZS52MS5Sb2xlR3JhbnQSKgoKcmlza19sZXZlbBgPIAEoDjIWLmJ5dGViYXNlLnYxLlJpc2tMZXZlbBIOCgZsYWJlbHMYESADKAkSOQoPYXBwcm92YWxfc3RhdHVzGBIgASgOMhsuYnl0ZWJhc2UudjEuQXBwcm92YWxTdGF0dXNCA+BBAxI2CgxhY2Nlc3NfZ3JhbnQYEyABKAlCIOBBA/pBGgoYYnl0ZWJhc2UuY29tL0FjY2Vzc0dyYW50EhIKBWRyYWZ0GBQgASgIQgPgQQEanAEKCEFwcHJvdmVyEjIKBnN0YXR1cxgBIAEoDjIiLmJ5dGViYXNlLnYxLklzc3VlLkFwcHJvdmVyLlN0YXR1cxIRCglwcmluY2lwYWwYAiABKAkiSQoGU3RhdHVzEhYKElNUQVRVU19VTlNQRUNJRklFRBAAEgsKB1BFTkRJTkcQARIMCghBUFBST1ZFRBACEgwKCFJFSkVDVEVEEAMiWQoEVHlwZRIUChBUWVBFX1VOU1BFQ0lGSUVEEAASEwoPREFUQUJBU0VfQ0hBTkdFEAESDgoKUk9MRV9HUkFOVBACEhAKDEFDQ0VTU19HUkFOVBAEIgQIAxADOjrqQTcKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIhcHJvamVjdHMve3Byb2plY3R9L2lzc3Vlcy97aXNzdWV9SgQIDBANSgQIDhAPSgQIEBARInwKCVJvbGVHcmFudBIMCgRyb2xlGAEgASgJEgwKBHVzZXIYAiABKAkSJAoJY29uZGl0aW9uGAMgASgLMhEuZ29vZ2xlLnR5cGUuRXhwchItCgpleHBpcmF0aW9uGAQgASgLMhkuZ29vZ2xlLnByb3RvYnVmLkR1cmF0aW9uIl8KEEFwcHJvdmFsVGVtcGxhdGUSJwoEZmxvdxgBIAEoCzIZLmJ5dGViYXNlLnYxLkFwcHJvdmFsRmxvdxINCgV0aXRsZRgCIAEoCRITCgtkZXNjcmlwdGlvbhgDIAEoCSIdCgxBcHByb3ZhbEZsb3cSDQoFcm9sZXMYASADKAkifQoYTGlzdElzc3VlQ29tbWVudHNSZXF1ZXN0EioKBnBhcmVudBgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSEQoJcGFnZV9zaXplGAIgASgFEhIKCnBhZ2VfdG9rZW4YAyABKAkSDgoGZmlsdGVyGAQgASgJImcKGUxpc3RJc3N1ZUNvbW1lbnRzUmVzcG9uc2USMQoOaXNzdWVfY29tbWVudHMYASADKAsyGS5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQSFwoPbmV4dF9wYWdlX3Rva2VuGAIgASgJInkKGUNyZWF0ZUlzc3VlQ29tbWVudFJlcXVlc3QSKgoGcGFyZW50GAEgASgJQhrgQQL6QRQKEmJ5dGViYXNlLmNvbS9Jc3N1ZRIwCg1pc3N1ZV9jb21tZW50GAIgASgLMhkuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50IsYBChlVcGRhdGVJc3N1ZUNvbW1lbnRSZXF1ZXN0EioKBnBhcmVudBgBIAEoCUIa4EEC+kEUChJieXRlYmFzZS5jb20vSXNzdWUSMAoNaXNzdWVfY29tbWVudBgCIAEoCzIZLmJ5dGViYXNlLnYxLklzc3VlQ29tbWVudBI0Cgt1cGRhdGVfbWFzaxgDIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2tCA+BBAhIVCg1hbGxvd19taXNzaW5nGAQgASgIIrIPCgxJc3N1ZUNvbW1lbnQSDAoEbmFtZRgBIAEoCRIaCgdjb21tZW50GAIgASgJQgm6SAZyBBiAgAQSDwoHcGF5bG9hZBgDIAEoCRI0CgtjcmVhdGVfdGltZRgEIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxI0Cgt1cGRhdGVfdGltZRgFIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5UaW1lc3RhbXBCA+BBAxIUCgdjcmVhdG9yGAYgASgJQgPgQQMSFgoEcm9vdBgOIAEoCUID4EEFSAGIAQESQAoMdGhyZWFkX3N0YXRlGA8gASgOMiUuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LlRocmVhZFN0YXRlSAKIAQESOwoQc3RhdGVtZW50X2FuY2hvchgQIAEoCzIcLmJ5dGViYXNlLnYxLlN0YXRlbWVudEFuY2hvckID4EEFEkYKD3Jldmlld19tZXRhZGF0YRgRIAEoCzIoLmJ5dGViYXNlLnYxLklzc3VlQ29tbWVudC5SZXZpZXdNZXRhZGF0YUID4EEDEjYKCGFwcHJvdmFsGAcgASgLMiIuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LkFwcHJvdmFsSAASPQoMaXNzdWVfdXBkYXRlGAggASgLMiUuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50Lklzc3VlVXBkYXRlSAASOwoLcGxhbl91cGRhdGUYDCABKAsyJC5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQuUGxhblVwZGF0ZUgAEkcKEXJldmlld19zdWJtaXNzaW9uGA0gASgLMiouYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LlJldmlld1N1Ym1pc3Npb25IABJOChVyZXZpZXdfcnVuX2NvbXBsZXRpb24YEiABKAsyLS5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQuUmV2aWV3UnVuQ29tcGxldGlvbkgAGrcCCg5SZXZpZXdNZXRhZGF0YRItCghydW5fdHlwZRgBIAEoDjIbLmJ5dGViYXNlLnYxLlJldmlld1J1bi5UeXBlEi4KCXJ1bGVfdHlwZRgCIAEoDjIbLmJ5dGViYXNlLnYxLlJldmlld1J1bGVUeXBlEkMKCHByaW9yaXR5GAMgASgOMjEuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50LlJldmlld01ldGFkYXRhLlByaW9yaXR5Eg8KB3RhcmdldHMYBCADKAkSEgoKc3VwZXJzZWRlZBgFIAEoCBIPCgdhdHRlbXB0GAYgASgDEg0KBWNvZGVzGAcgAygJIjwKCFByaW9yaXR5EhgKFFBSSU9SSVRZX1VOU1BFQ0lGSUVEEAASBgoCUDAQARIGCgJQMRACEgYKAlAyEAMakAEKCEFwcHJvdmFsEjkKBnN0YXR1cxgBIAEoDjIpLmJ5dGViYXNlLnYxLklzc3VlQ29tbWVudC5BcHByb3ZhbC5TdGF0dXMiSQoGU3RhdHVzEhYKElNUQVRVU19VTlNQRUNJRklFRBAAEgsKB1BFTkRJTkcQARIMCghBUFBST1ZFRBACEgwKCFJFSkVDVEVEEAMa6QIKC0lzc3VlVXBkYXRlEhcKCmZyb21fdGl0bGUYASABKAlIAIgBARIVCgh0b190aXRsZRgCIAEoCUgBiAEBEh0KEGZyb21fZGVzY3JpcHRpb24YAyABKAlIAogBARIbCg50b19kZXNjcmlwdGlvbhgEIAEoCUgDiAEBEjIKC2Zyb21fc3RhdHVzGAUgASgOMhguYnl0ZWJhc2UudjEuSXNzdWVTdGF0dXNIBIgBARIwCgl0b19zdGF0dXMYBiABKA4yGC5ieXRlYmFzZS52MS5Jc3N1ZVN0YXR1c0gFiAEBEhMKC2Zyb21fbGFiZWxzGAcgAygJEhEKCXRvX2xhYmVscxgIIAMoCUINCgtfZnJvbV90aXRsZUILCglfdG9fdGl0bGVCEwoRX2Zyb21fZGVzY3JpcHRpb25CEQoPX3RvX2Rlc2NyaXB0aW9uQg4KDF9mcm9tX3N0YXR1c0IMCgpfdG9fc3RhdHVzGhIKEFJldmlld1N1Ym1pc3Npb24amQEKE1Jldmlld1J1bkNvbXBsZXRpb24SLQoIcnVuX3R5cGUYASABKA4yGy5ieXRlYmFzZS52MS5SZXZpZXdSdW4uVHlwZRIPCgdhdHRlbXB0GAIgASgDEhQKDHBvc3RlZF9jb3VudBgDIAEoBRISCgprZXB0X2NvdW50GAQgASgFEhgKEHN1cGVyc2VkZWRfY291bnQYBSABKAUaYgoKUGxhblVwZGF0ZRIqCgpmcm9tX3NwZWNzGAEgAygLMhYuYnl0ZWJhc2UudjEuUGxhbi5TcGVjEigKCHRvX3NwZWNzGAIgAygLMhYuYnl0ZWJhc2UudjEuUGxhbi5TcGVjIkMKC1RocmVhZFN0YXRlEhwKGFRIUkVBRF9TVEFURV9VTlNQRUNJRklFRBAAEggKBE9QRU4QARIMCghSRVNPTFZFRBACQgcKBWV2ZW50QgcKBV9yb290Qg8KDV90aHJlYWRfc3RhdGVKBAgJEAwikQEKD1N0YXRlbWVudEFuY2hvchIMCgRzcGVjGAEgASgJEhQKDHNoZWV0X3NoYTI1NhgCIAEoCRItCg5zdGFydF9wb3NpdGlvbhgDIAEoCzIVLmJ5dGViYXNlLnYxLlBvc2l0aW9uEisKDGVuZF9wb3NpdGlvbhgEIAEoCzIVLmJ5dGViYXNlLnYxLlBvc2l0aW9uIuwDCglSZXZpZXdSdW4SDAoEbmFtZRgBIAEoCRIuCgR0eXBlGAIgASgOMhsuYnl0ZWJhc2UudjEuUmV2aWV3UnVuLlR5cGVCA+BBAxIyCgZzdGF0dXMYAyABKA4yHS5ieXRlYmFzZS52MS5SZXZpZXdSdW4uU3RhdHVzQgPgQQMSNAoLY3JlYXRlX3RpbWUYBCABKAsyGi5nb29nbGUucHJvdG9idWYuVGltZXN0YW1wQgPgQQMSMQoIZW5kX3RpbWUYBSABKAsyGi5nb29nbGUucHJvdG9idWYuVGltZXN0YW1wQgPgQQMSEgoFZXJyb3IYBiABKAlCA+BBAxIVCghvdXRkYXRlZBgHIAEoCEID4EEDIi4KBFR5cGUSFAoQVFlQRV9VTlNQRUNJRklFRBAAEggKBFJVTEUQARIGCgJBSRACIlIKBlN0YXR1cxIWChJTVEFUVVNfVU5TUEVDSUZJRUQQABINCglBVkFJTEFCTEUQARILCgdSVU5OSU5HEAISCAoERE9ORRADEgoKBkZBSUxFRBAEOlXqQVIKFmJ5dGViYXNlLmNvbS9SZXZpZXdSdW4SOHByb2plY3RzL3twcm9qZWN0fS9pc3N1ZXMve2lzc3VlfS9yZXZpZXdSdW5zL3tyZXZpZXdSdW59IkMKE0dldFJldmlld1J1blJlcXVlc3QSLAoEbmFtZRgBIAEoCUIe4EEC+kEYChZieXRlYmFzZS5jb20vUmV2aWV3UnVuIkAKEFJ1blJldmlld1JlcXVlc3QSLAoEbmFtZRgBIAEoCUIe4EEC+kEYChZieXRlYmFzZS5jb20vUmV2aWV3UnVuMvQTCgxJc3N1ZVNlcnZpY2UShAEKCEdldElzc3VlEhwuYnl0ZWJhc2UudjEuR2V0SXNzdWVSZXF1ZXN0GhIuYnl0ZWJhc2UudjEuSXNzdWUiRtpBBG5hbWWK6jANYmIuaXNzdWVzLmdldJDqMAGg6jABgtPkkwIgEh4vdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKn0SoAEKC0NyZWF0ZUlzc3VlEh8uYnl0ZWJhc2UudjEuQ3JlYXRlSXNzdWVSZXF1ZXN0GhIuYnl0ZWJhc2UudjEuSXNzdWUiXNpBDHBhcmVudCxpc3N1ZYrqMBBiYi5pc3N1ZXMuY3JlYXRlkOowAZjqMAGg6jACgtPkkwInOgVpc3N1ZSIeL3YxL3twYXJlbnQ9cHJvamVjdHMvKn0vaXNzdWVzEpgBCgpMaXN0SXNzdWVzEh4uYnl0ZWJhc2UudjEuTGlzdElzc3Vlc1JlcXVlc3QaHy5ieXRlYmFzZS52MS5MaXN0SXNzdWVzUmVzcG9uc2UiSdpBBnBhcmVudIrqMA5iYi5pc3N1ZXMubGlzdJDqMAGg6jABgtPkkwIgEh4vdjEve3BhcmVudD1wcm9qZWN0cy8qfS9pc3N1ZXMSngEKDFNlYXJjaElzc3VlcxIgLmJ5dGViYXNlLnYxLlNlYXJjaElzc3Vlc1JlcXVlc3QaIS5ieXRlYmFzZS52MS5TZWFyY2hJc3N1ZXNSZXNwb25zZSJJiuowDWJiLmlzc3Vlcy5nZXSQ6jACoOowAYLT5JMCKjoBKiIlL3YxL3twYXJlbnQ9cHJvamVjdHMvKn0vaXNzdWVzOnNlYXJjaBKrAQoLVXBkYXRlSXNzdWUSHy5ieXRlYmFzZS52MS5VcGRhdGVJc3N1ZVJlcXVlc3QaEi5ieXRlYmFzZS52MS5Jc3N1ZSJn2kERaXNzdWUsdXBkYXRlX21hc2uK6jAQYmIuaXNzdWVzLnVwZGF0ZZDqMAGY6jABoOowAoLT5JMCLToFaXNzdWUyJC92MS97aXNzdWUubmFtZT1wcm9qZWN0cy8qL2lzc3Vlcy8qfRLEAQoRTGlzdElzc3VlQ29tbWVudHMSJS5ieXRlYmFzZS52MS5MaXN0SXNzdWVDb21tZW50c1JlcXVlc3QaJi5ieXRlYmFzZS52MS5MaXN0SXNzdWVDb21tZW50c1Jlc3BvbnNlImDaQQZwYXJlbnSK6jAVYmIuaXNzdWVDb21tZW50cy5saXN0kOowAaDqMAGC0+STAjASLi92MS97cGFyZW50PXByb2plY3RzLyovaXNzdWVzLyp9L2lzc3VlQ29tbWVudHMS1gEKEkNyZWF0ZUlzc3VlQ29tbWVudBImLmJ5dGViYXNlLnYxLkNyZWF0ZUlzc3VlQ29tbWVudFJlcXVlc3QaGS5ieXRlYmFzZS52MS5Jc3N1ZUNvbW1lbnQifdpBFHBhcmVudCxpc3N1ZV9jb21tZW50iuowF2JiLmlzc3VlQ29tbWVudHMuY3JlYXRlkOowAZjqMAGg6jACgtPkkwI5Og1pc3N1ZV9jb21tZW50IigvdjEve3BhcmVudD1wcm9qZWN0cy8qL2lzc3Vlcy8qfTpjb21tZW50EuMBChJVcGRhdGVJc3N1ZUNvbW1lbnQSJi5ieXRlYmFzZS52MS5VcGRhdGVJc3N1ZUNvbW1lbnRSZXF1ZXN0GhkuYnl0ZWJhc2UudjEuSXNzdWVDb21tZW50IokB2kEgcGFyZW50LGlzc3VlX2NvbW1lbnQsdXBkYXRlX21hc2uK6jAXYmIuaXNzdWVDb21tZW50cy51cGRhdGWQ6jABmOowAaDqMAKC0+STAjk6DWlzc3VlX2NvbW1lbnQyKC92MS97cGFyZW50PXByb2plY3RzLyovaXNzdWVzLyp9OmNvbW1lbnQS0QEKF0JhdGNoVXBkYXRlSXNzdWVzU3RhdHVzEisuYnl0ZWJhc2UudjEuQmF0Y2hVcGRhdGVJc3N1ZXNTdGF0dXNSZXF1ZXN0GiwuYnl0ZWJhc2UudjEuQmF0Y2hVcGRhdGVJc3N1ZXNTdGF0dXNSZXNwb25zZSJbiuowEGJiLmlzc3Vlcy51cGRhdGWQ6jABmOowAaDqMAKC0+STAjU6ASoiMC92MS97cGFyZW50PXByb2plY3RzLyp9L2lzc3VlczpiYXRjaFVwZGF0ZVN0YXR1cxKDAQoMQXBwcm92ZUlzc3VlEiAuYnl0ZWJhc2UudjEuQXBwcm92ZUlzc3VlUmVxdWVzdBoSLmJ5dGViYXNlLnYxLklzc3VlIj2Q6jACmOowAaDqMAKC0+STAis6ASoiJi92MS97bmFtZT1wcm9qZWN0cy8qL2lzc3Vlcy8qfTphcHByb3ZlEoABCgtSZWplY3RJc3N1ZRIfLmJ5dGViYXNlLnYxLlJlamVjdElzc3VlUmVxdWVzdBoSLmJ5dGViYXNlLnYxLklzc3VlIjyQ6jACmOowAaDqMAKC0+STAio6ASoiJS92MS97bmFtZT1wcm9qZWN0cy8qL2lzc3Vlcy8qfTpyZWplY3QSgwEKDFJlcXVlc3RJc3N1ZRIgLmJ5dGViYXNlLnYxLlJlcXVlc3RJc3N1ZVJlcXVlc3QaEi5ieXRlYmFzZS52MS5Jc3N1ZSI9kOowApjqMAGg6jACgtPkkwIrOgEqIiYvdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKn06cmVxdWVzdBKZAQoSUmV0cnlJc3N1ZUFwcHJvdmFsEiYuYnl0ZWJhc2UudjEuUmV0cnlJc3N1ZUFwcHJvdmFsUmVxdWVzdBoSLmJ5dGViYXNlLnYxLklzc3VlIkeQ6jACmOowAaDqMAOo6jAIgtPkkwIxOgEqIiwvdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKn06cmV0cnlBcHByb3ZhbBKhAQoMR2V0UmV2aWV3UnVuEiAuYnl0ZWJhc2UudjEuR2V0UmV2aWV3UnVuUmVxdWVzdBoWLmJ5dGViYXNlLnYxLlJldmlld1J1biJX2kEEbmFtZYrqMBFiYi5yZXZpZXdSdW5zLmdldJDqMAGg6jABgtPkkwItEisvdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKi9yZXZpZXdSdW5zLyp9EqYBCglSdW5SZXZpZXcSHS5ieXRlYmFzZS52MS5SdW5SZXZpZXdSZXF1ZXN0GhYuYnl0ZWJhc2UudjEuUmV2aWV3UnVuImLaQQRuYW1liuowEWJiLnJldmlld1J1bnMucnVukOowAZjqMAGg6jACgtPkkwI0OgEqIi8vdjEve25hbWU9cHJvamVjdHMvKi9pc3N1ZXMvKi9yZXZpZXdSdW5zLyp9OnJ1bkKnAQoPY29tLmJ5dGViYXNlLnYxQhFJc3N1ZVNlcnZpY2VQcm90b1ABWjRnaXRodWIuY29tL2J5dGViYXNlL2J5dGViYXNlL2JhY2tlbmQvZ2VuZXJhdGVkLWdvL3YxogIDQlhYqgILQnl0ZWJhc2UuVjHKAgtCeXRlYmFzZVxWMeICF0J5dGViYXNlXFYxXEdQQk1ldGFkYXRh6gIMQnl0ZWJhc2U6OlYxYgZwcm90bzM", [file_buf_validate_validate, file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_duration, file_google_protobuf_field_mask, file_google_protobuf_timestamp, file_google_type_expr, file_v1_annotation, file_v1_common, file_v1_plan_service, file_v1_review_rule]);/*** Describes the message bytebase.v1.GetIssueRequest.diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yamlindex 05b875e2eb..df22515e12 100644--- a/proto/gen/grpc-doc/openapi.yaml+++ b/proto/gen/grpc-doc/openapi.yaml@@ -22779,6 +22779,15 @@ components:description: |-The ReviewRunCompletion.attempt of the run that posted the result. Aresult a later run reports again keeps its thread and its attempt.+ codes:+ type: array+ items:+ type: string+ title: codes+ description: |-+ The conditions a RULE result reports, as finding codes such as+ "WT101", one per reason. A code names the same condition on every+ engine. Empty for other reviewers.title: ReviewMetadataadditionalProperties: falsedescription: What a review result carries beyond its text.diff --git a/proto/gen/grpc-doc/store/README.md b/proto/gen/grpc-doc/store/README.mdindex 950e19386b..2161ee84ff 100644--- a/proto/gen/grpc-doc/store/README.md+++ b/proto/gen/grpc-doc/store/README.md@@ -2320,6 +2320,7 @@ results.| superseded | [bool](#bool) | | A later run of the same reviewer has completed without reporting the result again, so the latest review does not hold it. Set by that run whatever the thread state, and never cleared. || fingerprint | [string](#string) | | Identifies the finding across runs: equal fingerprints are the same finding on the same SQL. Unique among the results of one run. Empty when the reviewer cannot tell findings apart across runs, and an empty fingerprint matches nothing. || attempt | [int64](#int64) | | The review_run.attempt of the run that posted the result. A result a later run reports again keeps its attempt. |+| codes | [string](#string) | repeated | The conditions a RULE result reports, as omni finding codes such as "WT101", one per reason. Empty for other reviewers. |diff --git a/proto/gen/grpc-doc/store/index.html b/proto/gen/grpc-doc/store/index.htmlindex f8d1515d75..24ebaaa59b 100644--- a/proto/gen/grpc-doc/store/index.html+++ b/proto/gen/grpc-doc/store/index.html@@ -6650,6 +6650,14 @@ fingerprint matches nothing. </p></td>a later run reports again keeps its attempt. </p></td></tr>+ <tr>+ <td>codes</td>+ <td><a href="#string">string</a></td>+ <td>repeated</td>+ <td><p>The conditions a RULE result reports, as omni finding codes such as+"WT101", one per reason. Empty for other reviewers. </p></td>+ </tr>+</tbody></table>diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.mdindex d7f2758611..f558acc203 100644--- a/proto/gen/grpc-doc/v1/README.md+++ b/proto/gen/grpc-doc/v1/README.md@@ -3714,6 +3714,7 @@ What a review result carries beyond its text.| targets | [string](#string) | repeated | Every database the result applies to, sorted. Format: instances/{instance}/databases/{database} || superseded | [bool](#bool) | | A later run of the same reviewer has completed without reporting the result again, whatever its thread state. || attempt | [int64](#int64) | | The ReviewRunCompletion.attempt of the run that posted the result. A result a later run reports again keeps its thread and its attempt. |+| codes | [string](#string) | repeated | The conditions a RULE result reports, as finding codes such as "WT101", one per reason. A code names the same condition on every engine. Empty for other reviewers. |diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.htmlindex ffea37dbe1..2bf923e9d3 100644--- a/proto/gen/grpc-doc/v1/index.html+++ b/proto/gen/grpc-doc/v1/index.html@@ -11316,6 +11316,15 @@ result again, whatever its thread state. </p></td>result a later run reports again keeps its thread and its attempt. </p></td></tr>+ <tr>+ <td>codes</td>+ <td><a href="#string">string</a></td>+ <td>repeated</td>+ <td><p>The conditions a RULE result reports, as finding codes such as+"WT101", one per reason. A code names the same condition on every+engine. Empty for other reviewers. </p></td>+ </tr>+</tbody></table>diff --git a/proto/store/store/issue_comment.proto b/proto/store/store/issue_comment.protoindex 6899aa720f..06edc8f8ba 100644--- a/proto/store/store/issue_comment.proto+++ b/proto/store/store/issue_comment.proto@@ -124,6 +124,9 @@ message IssueCommentPayload {// The review_run.attempt of the run that posted the result. A result// a later run reports again keeps its attempt.int64 attempt = 7;+ // The conditions a RULE result reports, as omni finding codes such as+ // "WT101", one per reason. Empty for other reviewers.+ repeated string codes = 8;}// StatementAnchor records the anchored statement revision and range.diff --git a/proto/v1/v1/issue_service.proto b/proto/v1/v1/issue_service.protoindex 8c4b35b9f2..8a86611294 100644--- a/proto/v1/v1/issue_service.proto+++ b/proto/v1/v1/issue_service.proto@@ -715,6 +715,10 @@ message IssueComment {// The ReviewRunCompletion.attempt of the run that posted the result. A// result a later run reports again keeps its thread and its attempt.int64 attempt = 6;+ // The conditions a RULE result reports, as finding codes such as+ // "WT101", one per reason. A code names the same condition on every+ // engine. Empty for other reviewers.+ repeated string codes = 7;}enum ThreadState {