Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: remove deprecated code, outdated comments, and optimize database queries (#18667)

Danny Xub263b851dbf1
diff --git a/backend/api/mcp/gen/openapi.yaml b/backend/api/mcp/gen/openapi.yaml
index f32531d7a0..405f2c3f72 100644
--- a/backend/api/mcp/gen/openapi.yaml
+++ b/backend/api/mcp/gen/openapi.yaml
@@ -15219,13 +15219,6 @@ components:
The name of the sheet resource.
Format: projects/{project}/sheets/{sheet}
The sheet ID is generated by the server on creation and cannot be changed.
- title:
- type: string
- title: title
- description: |-
- The title of the sheet.
- Deprecated: this field is deprecated and will be removed in a future version.
- deprecated: true
content:
type: string
title: content
diff --git a/backend/api/v1/rollout_service.go b/backend/api/v1/rollout_service.go
index 01fe36fb23..6d4481613f 100644
--- a/backend/api/v1/rollout_service.go
+++ b/backend/api/v1/rollout_service.go
@@ -120,17 +120,7 @@ func (s *RolloutService) ListRollouts(ctx context.Context, req *connect.Request[
}
limitPlusOne := offset.limit + 1
- // ListRollouts should list Plans that have tasks (rollouts).
- // We use ListPlans but we need to filter those with tasks.
- // Previously ListPipelines did this.
- // Let's us ListPlans with has_pipeline=true (which now means has tasks).
- // But `store.PipelineFind` is still used in code?
- // Let's assume ListPipelines now returns Plan-like PipelineMessages.
- // I need to convert them to PlanMessage.
-
- // BUT, `ListPipelines` returns `[]*PipelineMessage`.
- // I should probably switch to `ListPlans`.
-
+ // Filter plans to only those with rollouts (tasks).
hasRollout := true
findPlan := &store.FindPlanMessage{
ProjectID: &projectID,
diff --git a/backend/generated-go/v1/sheet_service.pb.go b/backend/generated-go/v1/sheet_service.pb.go
index 31001f184c..9b6781c39d 100644
--- a/backend/generated-go/v1/sheet_service.pb.go
+++ b/backend/generated-go/v1/sheet_service.pb.go
@@ -236,17 +236,12 @@ type Sheet struct {
// Format: projects/{project}/sheets/{sheet}
// The sheet ID is generated by the server on creation and cannot be changed.
Name string `protobuf:"bytes,1,opt,name=name,proto3" json:"name,omitempty"`
- // The title of the sheet.
- // Deprecated: this field is deprecated and will be removed in a future version.
- //
- // Deprecated: Marked as deprecated in v1/sheet_service.proto.
- Title string `protobuf:"bytes,2,opt,name=title,proto3" json:"title,omitempty"`
// The content of the sheet.
// By default, it will be cut off, if it doesn't match the `content_size`, you can
// set the `raw` to true in GetSheet request to retrieve the full content.
- Content []byte `protobuf:"bytes,5,opt,name=content,proto3" json:"content,omitempty"`
+ Content []byte `protobuf:"bytes,2,opt,name=content,proto3" json:"content,omitempty"`
// content_size is the full size of the content, may not match the size of the `content` field.
- ContentSize int64 `protobuf:"varint,6,opt,name=content_size,json=contentSize,proto3" json:"content_size,omitempty"`
+ ContentSize int64 `protobuf:"varint,3,opt,name=content_size,json=contentSize,proto3" json:"content_size,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -288,14 +283,6 @@ func (x *Sheet) GetName() string {
return ""
}
-// Deprecated: Marked as deprecated in v1/sheet_service.proto.
-func (x *Sheet) GetTitle() string {
- if x != nil {
- return x.Title
- }
- return ""
-}
-
func (x *Sheet) GetContent() []byte {
if x != nil {
return x.Content
@@ -328,13 +315,12 @@ const file_v1_sheet_service_proto_rawDesc = "" +
"\x0fGetSheetRequest\x12.\n" +
"\x04name\x18\x01 \x01(\tB\x1a\xe0A\x02\xfaA\x14\n" +
"\x12bytebase.com/SheetR\x04name\x12\x10\n" +
- "\x03raw\x18\x02 \x01(\bR\x03raw\"\xcc\x01\n" +
+ "\x03raw\x18\x02 \x01(\bR\x03raw\"\xa6\x01\n" +
"\x05Sheet\x12\x1a\n" +
- "\x04name\x18\x01 \x01(\tB\x06\xe0A\x02\xe0A\x05R\x04name\x12\x18\n" +
- "\x05title\x18\x02 \x01(\tB\x02\x18\x01R\x05title\x12\x1d\n" +
- "\acontent\x18\x05 \x01(\fB\x03\xe0A\x02R\acontent\x12&\n" +
- "\fcontent_size\x18\x06 \x01(\x03B\x03\xe0A\x03R\vcontentSize::\xeaA7\n" +
- "\x12bytebase.com/Sheet\x12!projects/{project}/sheets/{sheet}J\x04\b\x03\x10\x04J\x04\b\x04\x10\x052\xe0\x03\n" +
+ "\x04name\x18\x01 \x01(\tB\x06\xe0A\x02\xe0A\x05R\x04name\x12\x1d\n" +
+ "\acontent\x18\x02 \x01(\fB\x03\xe0A\x02R\acontent\x12&\n" +
+ "\fcontent_size\x18\x03 \x01(\x03B\x03\xe0A\x03R\vcontentSize::\xeaA7\n" +
+ "\x12bytebase.com/Sheet\x12!projects/{project}/sheets/{sheet}2\xe0\x03\n" +
"\fSheetService\x12\x98\x01\n" +
"\vCreateSheet\x12\x1f.bytebase.v1.CreateSheetRequest\x1a\x12.bytebase.v1.Sheet\"T\xdaA\fparent,sheet\x8a\xea0\x10bb.sheets.create\x90\xea0\x01\x82\xd3\xe4\x93\x02':\x05sheet\"\x1e/v1/{parent=projects/*}/sheets\x12\xb1\x01\n" +
"\x11BatchCreateSheets\x12%.bytebase.v1.BatchCreateSheetsRequest\x1a&.bytebase.v1.BatchCreateSheetsResponse\"M\x8a\xea0\x10bb.sheets.create\x90\xea0\x01\x82\xd3\xe4\x93\x02/:\x01*\"*/v1/{parent=projects/*}/sheets:batchCreate\x12\x80\x01\n" +
diff --git a/backend/generated-go/v1/sheet_service_equal.pb.go b/backend/generated-go/v1/sheet_service_equal.pb.go
index 3cefab9826..a66018e575 100644
--- a/backend/generated-go/v1/sheet_service_equal.pb.go
+++ b/backend/generated-go/v1/sheet_service_equal.pb.go
@@ -84,9 +84,6 @@ func (x *Sheet) Equal(y *Sheet) bool {
if x.Name != y.Name {
return false
}
- if x.Title != y.Title {
- return false
- }
if string(x.Content) != string(y.Content) {
return false
}
diff --git a/backend/migrator/migration/3.14/0012##plan_has_rollout_index.sql b/backend/migrator/migration/3.14/0012##plan_has_rollout_index.sql
new file mode 100644
index 0000000000..6899e41a64
--- /dev/null
+++ b/backend/migrator/migration/3.14/0012##plan_has_rollout_index.sql
@@ -0,0 +1 @@
+CREATE INDEX IF NOT EXISTS idx_plan_config_has_rollout ON plan ((config->>'hasRollout'));
diff --git a/backend/migrator/migration/LATEST.sql b/backend/migrator/migration/LATEST.sql
index 79bd07a86a..72eafde90b 100644
--- a/backend/migrator/migration/LATEST.sql
+++ b/backend/migrator/migration/LATEST.sql
@@ -206,6 +206,7 @@ CREATE TABLE plan (
);
CREATE INDEX idx_plan_project ON plan(project);
+CREATE INDEX idx_plan_config_has_rollout ON plan ((config->>'hasRollout'));
ALTER SEQUENCE plan_id_seq RESTART WITH 101;
diff --git a/backend/migrator/migrator_test.go b/backend/migrator/migrator_test.go
index 4dc4abacd0..3bf469a343 100644
--- a/backend/migrator/migrator_test.go
+++ b/backend/migrator/migrator_test.go
@@ -12,7 +12,8 @@ import (
func TestLatestVersion(t *testing.T) {
files, err := getSortedVersionedFiles()
require.NoError(t, err)
- require.Equal(t, semver.MustParse("3.14.11"), *files[len(files)-1].version)
+ require.Equal(t, semver.MustParse("3.14.12"), *files[len(files)-1].version)
+ require.Equal(t, "migration/3.14/0012##plan_has_rollout_index.sql", files[len(files)-1].path)
}
func TestVersionUnique(t *testing.T) {
@@ -29,9 +30,3 @@ func TestVersionUnique(t *testing.T) {
versions[file.version.String()] = struct{}{}
}
}
-
-func TestGetVersionFromPath(t *testing.T) {
- v, err := getVersionFromPath("migration/3.5/0000##vcs.sql")
- require.NoError(t, err)
- require.Equal(t, *v, semver.MustParse("3.5.0"))
-}
diff --git a/backend/runner/plancheck/executor.go b/backend/runner/plancheck/executor.go
index 919c9a4300..c94ad1b831 100644
--- a/backend/runner/plancheck/executor.go
+++ b/backend/runner/plancheck/executor.go
@@ -8,6 +8,6 @@ import (
// Executor is the plan check executor.
type Executor interface {
- // Run will be called periodically by the plan check scheduler
- Run(ctx context.Context, config *storepb.PlanCheckRunConfig) (results []*storepb.PlanCheckRunResult_Result, err error)
+ // RunForTarget will be called periodically by the plan check scheduler for each target
+ RunForTarget(ctx context.Context, target *storepb.PlanCheckRunConfig_CheckTarget) (results []*storepb.PlanCheckRunResult_Result, err error)
}
diff --git a/backend/runner/plancheck/executor_combined.go b/backend/runner/plancheck/executor_combined.go
index 637b78481b..91c175061f 100644
--- a/backend/runner/plancheck/executor_combined.go
+++ b/backend/runner/plancheck/executor_combined.go
@@ -30,32 +30,30 @@ func NewCombinedExecutor(
}
}
-// Run runs all checks for the given config.
-func (e *CombinedExecutor) Run(ctx context.Context, config *storepb.PlanCheckRunConfig) ([]*storepb.PlanCheckRunResult_Result, error) {
+// RunForTarget runs all checks for the given target.
+func (e *CombinedExecutor) RunForTarget(ctx context.Context, target *storepb.PlanCheckRunConfig_CheckTarget) ([]*storepb.PlanCheckRunResult_Result, error) {
var allResults []*storepb.PlanCheckRunResult_Result
- for _, target := range config.Targets {
- for _, checkType := range target.Types {
- results, err := e.runCheck(ctx, target, checkType)
- if err != nil {
- // Add error result for this target/type, continue to next
- allResults = append(allResults, &storepb.PlanCheckRunResult_Result{
- Status: storepb.Advice_ERROR,
- Target: target.Target,
- Type: checkType,
- Title: "Check failed",
- Content: err.Error(),
- Code: common.Internal.Int32(),
- })
- continue
- }
- // Tag results with target info
- for _, r := range results {
- r.Target = target.Target
- r.Type = checkType
- }
- allResults = append(allResults, results...)
+ for _, checkType := range target.Types {
+ results, err := e.runCheck(ctx, target, checkType)
+ if err != nil {
+ // Add error result for this target/type, continue to next
+ allResults = append(allResults, &storepb.PlanCheckRunResult_Result{
+ Status: storepb.Advice_ERROR,
+ Target: target.Target,
+ Type: checkType,
+ Title: "Check failed",
+ Content: err.Error(),
+ Code: common.Internal.Int32(),
+ })
+ continue
}
+ // Tag results with target info
+ for _, r := range results {
+ r.Target = target.Target
+ r.Type = checkType
+ }
+ allResults = append(allResults, results...)
}
return allResults, nil
diff --git a/backend/runner/plancheck/ghost_sync_executor.go b/backend/runner/plancheck/ghost_sync_executor.go
index 11c4ecce25..8c0636e9d8 100644
--- a/backend/runner/plancheck/ghost_sync_executor.go
+++ b/backend/runner/plancheck/ghost_sync_executor.go
@@ -200,13 +200,3 @@ func (e *GhostSyncExecutor) RunForTarget(ctx context.Context, target *storepb.Pl
},
}, nil
}
-
-// Run runs the gh-ost sync check executor.
-//
-// Deprecated: Use RunForTarget instead. This method is kept for backward compatibility.
-func (e *GhostSyncExecutor) Run(ctx context.Context, config *storepb.PlanCheckRunConfig) (results []*storepb.PlanCheckRunResult_Result, err error) {
- if len(config.Targets) == 0 {
- return nil, nil
- }
- return e.RunForTarget(ctx, config.Targets[0])
-}
diff --git a/backend/runner/plancheck/scheduler.go b/backend/runner/plancheck/scheduler.go
index f45597374d..815dbb7a59 100644
--- a/backend/runner/plancheck/scheduler.go
+++ b/backend/runner/plancheck/scheduler.go
@@ -97,7 +97,16 @@ func (s *Scheduler) runPlanCheckRun(ctx context.Context, planCheckRun *store.Pla
defer cancel()
s.stateCfg.RunningPlanCheckRunsCancelFunc.Store(planCheckRun.UID, cancel)
- results, err := s.executor.Run(ctxWithCancel, planCheckRun.Config)
+ var results []*storepb.PlanCheckRunResult_Result
+ var err error
+ for _, target := range planCheckRun.Config.Targets {
+ targetResults, targetErr := s.executor.RunForTarget(ctxWithCancel, target)
+ if targetErr != nil {
+ err = targetErr
+ break
+ }
+ results = append(results, targetResults...)
+ }
if err != nil {
if errors.Is(err, context.Canceled) {
s.markPlanCheckRunCanceled(ctx, planCheckRun, err.Error())
diff --git a/backend/runner/plancheck/statement_advise_executor.go b/backend/runner/plancheck/statement_advise_executor.go
index f5d625229d..5a880a2ce1 100644
--- a/backend/runner/plancheck/statement_advise_executor.go
+++ b/backend/runner/plancheck/statement_advise_executor.go
@@ -112,16 +112,6 @@ func (e *StatementAdviseExecutor) RunForTarget(ctx context.Context, target *stor
return results, nil
}
-// Run will run the plan check statement advise executor once, and run its sub-advisors one-by-one.
-//
-// Deprecated: Use RunForTarget instead. This method is kept for backward compatibility.
-func (e *StatementAdviseExecutor) Run(ctx context.Context, config *storepb.PlanCheckRunConfig) ([]*storepb.PlanCheckRunResult_Result, error) {
- if len(config.Targets) == 0 {
- return nil, nil
- }
- return e.RunForTarget(ctx, config.Targets[0])
-}
-
func (e *StatementAdviseExecutor) runReview(
ctx context.Context,
instance *store.InstanceMessage,
diff --git a/backend/runner/plancheck/statement_report_executor.go b/backend/runner/plancheck/statement_report_executor.go
index b39514706b..72385922d3 100644
--- a/backend/runner/plancheck/statement_report_executor.go
+++ b/backend/runner/plancheck/statement_report_executor.go
@@ -134,16 +134,6 @@ func (e *StatementReportExecutor) RunForTarget(ctx context.Context, target *stor
return []*storepb.PlanCheckRunResult_Result{planCheckRunResult}, nil
}
-// Run runs the statement report executor.
-//
-// Deprecated: Use RunForTarget instead. This method is kept for backward compatibility.
-func (e *StatementReportExecutor) Run(ctx context.Context, config *storepb.PlanCheckRunConfig) ([]*storepb.PlanCheckRunResult_Result, error) {
- if len(config.Targets) == 0 {
- return nil, nil
- }
- return e.RunForTarget(ctx, config.Targets[0])
-}
-
// GetSQLSummaryReport gets the SQL summary report for the given statement and database.
func GetSQLSummaryReport(ctx context.Context, stores *store.Store, sheetManager *sheet.Manager, dbFactory *dbfactory.DBFactory, database *store.DatabaseMessage, statement string) (*storepb.PlanCheckRunResult_Result_SqlSummaryReport, error) {
databaseSchema, err := stores.GetDBSchema(ctx, &store.FindDBSchemaMessage{
diff --git a/backend/store/issue.go b/backend/store/issue.go
index 935b5abaa6..92bd927681 100644
--- a/backend/store/issue.go
+++ b/backend/store/issue.go
@@ -59,13 +59,10 @@ type UpdateIssueMessage struct {
// FindIssueMessage is the message to find issues.
type FindIssueMessage struct {
- UID *int
- ProjectID *string
- ProjectIDs *[]string
- PlanUID *int64
- // PipelineID is deprecated, use PlanUID.
- // To support pagination, we add into creatorEmail.
- // Only principleID or one of the following three fields can be set.
+ UID *int
+ ProjectID *string
+ ProjectIDs *[]string
+ PlanUID *int64
CreatorID *string
CreatedAtBefore *time.Time
CreatedAtAfter *time.Time
diff --git a/frontend/src/components/Plan/logic/initialize/index.ts b/frontend/src/components/Plan/logic/initialize/index.ts
index 9b695bf6d5..9ea8531414 100644
--- a/frontend/src/components/Plan/logic/initialize/index.ts
+++ b/frontend/src/components/Plan/logic/initialize/index.ts
@@ -27,7 +27,7 @@ export * from "./util";
export function useInitializePlan(
projectId: MaybeRef<string>,
planId: MaybeRef<string | undefined>,
- issueId: MaybeRef<string | undefined>,
+ issueId?: MaybeRef<string | undefined>,
legacyRolloutId?: MaybeRef<string | undefined>
) {
const isCreating = computed(() => {
diff --git a/frontend/src/types/proto-es/v1/sheet_service_pb.d.ts b/frontend/src/types/proto-es/v1/sheet_service_pb.d.ts
index 8cca3d2a1d..39d2cc318e 100644
--- a/frontend/src/types/proto-es/v1/sheet_service_pb.d.ts
+++ b/frontend/src/types/proto-es/v1/sheet_service_pb.d.ts
@@ -115,28 +115,19 @@ export declare type Sheet = Message<"bytebase.v1.Sheet"> & {
*/
name: string;
- /**
- * The title of the sheet.
- * Deprecated: this field is deprecated and will be removed in a future version.
- *
- * @generated from field: string title = 2 [deprecated = true];
- * @deprecated
- */
- title: string;
-
/**
* The content of the sheet.
* By default, it will be cut off, if it doesn't match the `content_size`, you can
* set the `raw` to true in GetSheet request to retrieve the full content.
*
- * @generated from field: bytes content = 5;
+ * @generated from field: bytes content = 2;
*/
content: Uint8Array;
/**
* content_size is the full size of the content, may not match the size of the `content` field.
*
- * @generated from field: int64 content_size = 6;
+ * @generated from field: int64 content_size = 3;
*/
contentSize: bigint;
};
diff --git a/frontend/src/types/proto-es/v1/sheet_service_pb.js b/frontend/src/types/proto-es/v1/sheet_service_pb.js
index b832ce73c9..4574aebb3e 100644
--- a/frontend/src/types/proto-es/v1/sheet_service_pb.js
+++ b/frontend/src/types/proto-es/v1/sheet_service_pb.js
@@ -13,7 +13,7 @@ import { file_v1_annotation } from "./annotation_pb";
* Describes the file v1/sheet_service.proto.
*/
export const file_v1_sheet_service = /*@__PURE__*/
- fileDesc("ChZ2MS9zaGVldF9zZXJ2aWNlLnByb3RvEgtieXRlYmFzZS52MSJqChJDcmVhdGVTaGVldFJlcXVlc3QSLAoGcGFyZW50GAEgASgJQhzgQQL6QRYKFGJ5dGViYXNlLmNvbS9Qcm9qZWN0EiYKBXNoZWV0GAIgASgLMhIuYnl0ZWJhc2UudjEuU2hlZXRCA+BBAiKAAQoYQmF0Y2hDcmVhdGVTaGVldHNSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBI2CghyZXF1ZXN0cxgCIAMoCzIfLmJ5dGViYXNlLnYxLkNyZWF0ZVNoZWV0UmVxdWVzdEID4EECIj8KGUJhdGNoQ3JlYXRlU2hlZXRzUmVzcG9uc2USIgoGc2hlZXRzGAEgAygLMhIuYnl0ZWJhc2UudjEuU2hlZXQiSAoPR2V0U2hlZXRSZXF1ZXN0EigKBG5hbWUYASABKAlCGuBBAvpBFAoSYnl0ZWJhc2UuY29tL1NoZWV0EgsKA3JhdxgCIAEoCCKpAQoFU2hlZXQSFAoEbmFtZRgBIAEoCUIG4EEC4EEFEhEKBXRpdGxlGAIgASgJQgIYARIUCgdjb250ZW50GAUgASgMQgPgQQISGQoMY29udGVudF9zaXplGAYgASgDQgPgQQM6OupBNwoSYnl0ZWJhc2UuY29tL1NoZWV0EiFwcm9qZWN0cy97cHJvamVjdH0vc2hlZXRzL3tzaGVldH1KBAgDEARKBAgEEAUy4AMKDFNoZWV0U2VydmljZRKYAQoLQ3JlYXRlU2hlZXQSHy5ieXRlYmFzZS52MS5DcmVhdGVTaGVldFJlcXVlc3QaEi5ieXRlYmFzZS52MS5TaGVldCJU2kEMcGFyZW50LHNoZWV0iuowEGJiLnNoZWV0cy5jcmVhdGWQ6jABgtPkkwInOgVzaGVldCIeL3YxL3twYXJlbnQ9cHJvamVjdHMvKn0vc2hlZXRzErEBChFCYXRjaENyZWF0ZVNoZWV0cxIlLmJ5dGViYXNlLnYxLkJhdGNoQ3JlYXRlU2hlZXRzUmVxdWVzdBomLmJ5dGViYXNlLnYxLkJhdGNoQ3JlYXRlU2hlZXRzUmVzcG9uc2UiTYrqMBBiYi5zaGVldHMuY3JlYXRlkOowAYLT5JMCLzoBKiIqL3YxL3twYXJlbnQ9cHJvamVjdHMvKn0vc2hlZXRzOmJhdGNoQ3JlYXRlEoABCghHZXRTaGVldBIcLmJ5dGViYXNlLnYxLkdldFNoZWV0UmVxdWVzdBoSLmJ5dGViYXNlLnYxLlNoZWV0IkLaQQRuYW1liuowDWJiLnNoZWV0cy5nZXSQ6jABgtPkkwIgEh4vdjEve25hbWU9cHJvamVjdHMvKi9zaGVldHMvKn1CpwEKD2NvbS5ieXRlYmFzZS52MUIRU2hlZXRTZXJ2aWNlUHJvdG9QAVo0Z2l0aHViLmNvbS9ieXRlYmFzZS9ieXRlYmFzZS9iYWNrZW5kL2dlbmVyYXRlZC1nby92MaICA0JYWKoCC0J5dGViYXNlLlYxygILQnl0ZWJhc2VcVjHiAhdCeXRlYmFzZVxWMVxHUEJNZXRhZGF0YeoCDEJ5dGViYXNlOjpWMWIGcHJvdG8z", [file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_v1_annotation]);
+ fileDesc("ChZ2MS9zaGVldF9zZXJ2aWNlLnByb3RvEgtieXRlYmFzZS52MSJqChJDcmVhdGVTaGVldFJlcXVlc3QSLAoGcGFyZW50GAEgASgJQhzgQQL6QRYKFGJ5dGViYXNlLmNvbS9Qcm9qZWN0EiYKBXNoZWV0GAIgASgLMhIuYnl0ZWJhc2UudjEuU2hlZXRCA+BBAiKAAQoYQmF0Y2hDcmVhdGVTaGVldHNSZXF1ZXN0EiwKBnBhcmVudBgBIAEoCUIc4EEC+kEWChRieXRlYmFzZS5jb20vUHJvamVjdBI2CghyZXF1ZXN0cxgCIAMoCzIfLmJ5dGViYXNlLnYxLkNyZWF0ZVNoZWV0UmVxdWVzdEID4EECIj8KGUJhdGNoQ3JlYXRlU2hlZXRzUmVzcG9uc2USIgoGc2hlZXRzGAEgAygLMhIuYnl0ZWJhc2UudjEuU2hlZXQiSAoPR2V0U2hlZXRSZXF1ZXN0EigKBG5hbWUYASABKAlCGuBBAvpBFAoSYnl0ZWJhc2UuY29tL1NoZWV0EgsKA3JhdxgCIAEoCCKKAQoFU2hlZXQSFAoEbmFtZRgBIAEoCUIG4EEC4EEFEhQKB2NvbnRlbnQYAiABKAxCA+BBAhIZCgxjb250ZW50X3NpemUYAyABKANCA+BBAzo66kE3ChJieXRlYmFzZS5jb20vU2hlZXQSIXByb2plY3RzL3twcm9qZWN0fS9zaGVldHMve3NoZWV0fTLgAwoMU2hlZXRTZXJ2aWNlEpgBCgtDcmVhdGVTaGVldBIfLmJ5dGViYXNlLnYxLkNyZWF0ZVNoZWV0UmVxdWVzdBoSLmJ5dGViYXNlLnYxLlNoZWV0IlTaQQxwYXJlbnQsc2hlZXSK6jAQYmIuc2hlZXRzLmNyZWF0ZZDqMAGC0+STAic6BXNoZWV0Ih4vdjEve3BhcmVudD1wcm9qZWN0cy8qfS9zaGVldHMSsQEKEUJhdGNoQ3JlYXRlU2hlZXRzEiUuYnl0ZWJhc2UudjEuQmF0Y2hDcmVhdGVTaGVldHNSZXF1ZXN0GiYuYnl0ZWJhc2UudjEuQmF0Y2hDcmVhdGVTaGVldHNSZXNwb25zZSJNiuowEGJiLnNoZWV0cy5jcmVhdGWQ6jABgtPkkwIvOgEqIiovdjEve3BhcmVudD1wcm9qZWN0cy8qfS9zaGVldHM6YmF0Y2hDcmVhdGUSgAEKCEdldFNoZWV0EhwuYnl0ZWJhc2UudjEuR2V0U2hlZXRSZXF1ZXN0GhIuYnl0ZWJhc2UudjEuU2hlZXQiQtpBBG5hbWWK6jANYmIuc2hlZXRzLmdldJDqMAGC0+STAiASHi92MS97bmFtZT1wcm9qZWN0cy8qL3NoZWV0cy8qfUKnAQoPY29tLmJ5dGViYXNlLnYxQhFTaGVldFNlcnZpY2VQcm90b1ABWjRnaXRodWIuY29tL2J5dGViYXNlL2J5dGViYXNlL2JhY2tlbmQvZ2VuZXJhdGVkLWdvL3YxogIDQlhYqgILQnl0ZWJhc2UuVjHKAgtCeXRlYmFzZVxWMeICF0J5dGViYXNlXFYxXEdQQk1ldGFkYXRh6gIMQnl0ZWJhc2U6OlYxYgZwcm90bzM", [file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_v1_annotation]);
/**
* Describes the message bytebase.v1.CreateSheetRequest.
diff --git a/frontend/src/views/project/RolloutLayout.vue b/frontend/src/views/project/RolloutLayout.vue
index a66c751944..f4f5042d03 100644
--- a/frontend/src/views/project/RolloutLayout.vue
+++ b/frontend/src/views/project/RolloutLayout.vue
@@ -56,12 +56,7 @@ const {
rollout,
taskRuns,
isInitializing,
-} = useInitializePlan(
- toRef(props, "projectId"),
- toRef(props, "planId"), // planId
- undefined, // issueId - not used for rollout routes
- undefined // legacyRolloutId - deprecated, using planId
-);
+} = useInitializePlan(toRef(props, "projectId"), toRef(props, "planId"));
const planBaseContext = useBasePlanContext({
isCreating,
plan,
@@ -114,4 +109,3 @@ const documentTitle = computed(() => {
useTitle(documentTitle);
</script>
-```
diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yaml
index 8266814212..586b1cf34c 100644
--- a/proto/gen/grpc-doc/openapi.yaml
+++ b/proto/gen/grpc-doc/openapi.yaml
@@ -13693,11 +13693,6 @@ components:
The name of the sheet resource.
Format: projects/{project}/sheets/{sheet}
The sheet ID is generated by the server on creation and cannot be changed.
- title:
- type: string
- description: |-
- The title of the sheet.
- Deprecated: this field is deprecated and will be removed in a future version.
content:
type: string
description: |-
diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.md
index d2b38c22a6..11fb76394b 100644
--- a/proto/gen/grpc-doc/v1/README.md
+++ b/proto/gen/grpc-doc/v1/README.md
@@ -10289,7 +10289,6 @@ RolloutService manages the execution of deployment plans.
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| name | [string](#string) | | The name of the sheet resource. Format: projects/{project}/sheets/{sheet} The sheet ID is generated by the server on creation and cannot be changed. |
-| title | [string](#string) | | **Deprecated.** The title of the sheet. Deprecated: this field is deprecated and will be removed in a future version. |
| content | [bytes](#bytes) | | The content of the sheet. By default, it will be cut off, if it doesn&#39;t match the `content_size`, you can set the `raw` to true in GetSheet request to retrieve the full content. |
| content_size | [int64](#int64) | | content_size is the full size of the content, may not match the size of the `content` field. |
diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.html
index 33ed90cb31..7108729f78 100644
--- a/proto/gen/grpc-doc/v1/index.html
+++ b/proto/gen/grpc-doc/v1/index.html
@@ -28858,14 +28858,6 @@ Format: projects/{project}/sheets/{sheet}
The sheet ID is generated by the server on creation and cannot be changed. </p></td>
</tr>
- <tr>
- <td>title</td>
- <td><a href="#string">string</a></td>
- <td></td>
- <td><p><strong>Deprecated.</strong> The title of the sheet.
-Deprecated: this field is deprecated and will be removed in a future version. </p></td>
- </tr>
-
<tr>
<td>content</td>
<td><a href="#bytes">bytes</a></td>
@@ -28886,27 +28878,6 @@ set the `raw` to true in GetSheet request to retrieve the full content. </p></td
</table>
-
-
- <h4>Fields with deprecated option</h4>
- <table>
- <thead>
- <tr>
- <td>Name</td>
- <td>Option</td>
- </tr>
- </thead>
- <tbody>
-
- <tr>
- <td>title</td>
- <td><p>true</p></td>
- </tr>
-
- </tbody>
- </table>
-
-
diff --git a/proto/v1/v1/sheet_service.proto b/proto/v1/v1/sheet_service.proto
index 9637d54c6f..f7c479f803 100644
--- a/proto/v1/v1/sheet_service.proto
+++ b/proto/v1/v1/sheet_service.proto
@@ -98,17 +98,11 @@ message Sheet {
(google.api.field_behavior) = IMMUTABLE
];
- // The title of the sheet.
- // Deprecated: this field is deprecated and will be removed in a future version.
- string title = 2 [deprecated = true];
-
- reserved 3, 4;
-
// The content of the sheet.
// By default, it will be cut off, if it doesn't match the `content_size`, you can
// set the `raw` to true in GetSheet request to retrieve the full content.
- bytes content = 5 [(google.api.field_behavior) = REQUIRED];
+ bytes content = 2 [(google.api.field_behavior) = REQUIRED];
// content_size is the full size of the content, may not match the size of the `content` field.
- int64 content_size = 6 [(google.api.field_behavior) = OUTPUT_ONLY];
+ int64 content_size = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
}