Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(plan): simplify SQL editor layout to avoid checks overlap (#19997)

boojackb30447fd4ebf
diff --git a/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue b/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue
index 4c019747ab..f0b7b31928 100644
--- a/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue
+++ b/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue
@@ -4,9 +4,7 @@
<SpecTabs v-model:selected-spec-id="selectedSpecId">
<div v-if="selectedSpec" class="flex flex-col gap-2">
<TargetListSection />
- <div class="flex flex-col" :class="isReleaseView ? '' : 'h-72'">
- <StatementSection header-variant="section" />
- </div>
+ <StatementSection header-variant="section" />
<OptionsSection />
</div>
</SpecTabs>
@@ -38,13 +36,6 @@ const selectedSpec = computed(() => {
return plan.value.specs.find((spec) => spec.id === selectedSpecId.value);
});
-const isReleaseView = computed(() => {
- return (
- selectedSpec.value?.config?.case === "changeDatabaseConfig" &&
- !!selectedSpec.value.config.value.release
- );
-});
-
provideSelectedSpec(
computed(() => {
const spec = selectedSpec.value;
diff --git a/frontend/src/components/Plan/components/IssueReviewView/DatabaseExportView.vue b/frontend/src/components/Plan/components/IssueReviewView/DatabaseExportView.vue
index e33e689d9e..acb7189d85 100644
--- a/frontend/src/components/Plan/components/IssueReviewView/DatabaseExportView.vue
+++ b/frontend/src/components/Plan/components/IssueReviewView/DatabaseExportView.vue
@@ -10,9 +10,7 @@
<LimitsSection />
<OptionsSection />
- <div class="h-72 flex flex-col">
- <StatementSection header-variant="section" />
- </div>
+ <StatementSection header-variant="section" />
</div>
</template>
diff --git a/frontend/src/components/Plan/components/PlanCheckSection/PlanCheckSection.vue b/frontend/src/components/Plan/components/PlanCheckSection/PlanCheckSection.vue
index dbec72ab28..e03fe849e5 100644
--- a/frontend/src/components/Plan/components/PlanCheckSection/PlanCheckSection.vue
+++ b/frontend/src/components/Plan/components/PlanCheckSection/PlanCheckSection.vue
@@ -1,5 +1,5 @@
<template>
- <div v-if="shouldShow" class="flex flex-col gap-y-2 overflow-hidden">
+ <div v-if="shouldShow" class="flex flex-col gap-y-2">
<!-- Row 1: Title + Run button -->
<div class="flex items-center justify-between gap-2">
<div class="flex flex-row items-center gap-2">
diff --git a/frontend/src/components/Plan/components/SQLCheckV1Section/SQLCheckV1Section.vue b/frontend/src/components/Plan/components/SQLCheckV1Section/SQLCheckV1Section.vue
index 599a7ee544..cbe7a86414 100644
--- a/frontend/src/components/Plan/components/SQLCheckV1Section/SQLCheckV1Section.vue
+++ b/frontend/src/components/Plan/components/SQLCheckV1Section/SQLCheckV1Section.vue
@@ -1,5 +1,5 @@
<template>
- <div v-if="show" class="flex flex-col gap-y-2 overflow-hidden">
+ <div v-if="show" class="flex flex-col gap-y-2">
<!-- Row 1: Title + Run button -->
<div class="flex items-center justify-between gap-2">
<div class="flex flex-row items-center gap-2">
diff --git a/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue b/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue
index 84b1a70832..980e5c0e06 100644
--- a/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue
+++ b/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue
@@ -5,9 +5,7 @@
<TargetListSection />
<!-- Statement -->
- <div :class="[plan.hasRollout ? 'h-[192px]' : 'h-[256px]', 'flex flex-col']">
- <StatementSection />
- </div>
+ <StatementSection />
<!-- Checks + Configuration -->
<template v-if="!specHasRelease">
diff --git a/frontend/src/components/Plan/components/StatementSection/EditorView/EditorView.vue b/frontend/src/components/Plan/components/StatementSection/EditorView/EditorView.vue
index ef55ae0e0a..f71377b8c2 100644
--- a/frontend/src/components/Plan/components/StatementSection/EditorView/EditorView.vue
+++ b/frontend/src/components/Plan/components/StatementSection/EditorView/EditorView.vue
@@ -1,5 +1,5 @@
<template>
- <div class="h-full flex flex-col gap-y-1">
+ <div class="flex flex-col gap-y-1">
<div class="flex items-center justify-between">
<div class="flex items-center gap-x-1">
<span
@@ -110,7 +110,7 @@
</template>
</BBAttention>
- <div class="relative flex-1">
+ <div class="relative h-64">
<MonacoEditor
class="w-full h-full border rounded-sm overflow-hidden"
:filename="filename"
diff --git a/frontend/src/components/Plan/components/StatementSection/ReleaseView/ReleaseView.vue b/frontend/src/components/Plan/components/StatementSection/ReleaseView/ReleaseView.vue
index fdbcb7f438..b7f1931dae 100644
--- a/frontend/src/components/Plan/components/StatementSection/ReleaseView/ReleaseView.vue
+++ b/frontend/src/components/Plan/components/StatementSection/ReleaseView/ReleaseView.vue
@@ -1,5 +1,5 @@
<template>
- <div class="h-full flex flex-col gap-y-2">
+ <div class="flex flex-col gap-y-2">
<NAlert type="info" :bordered="false">
<template #icon>
<heroicons-outline:information-circle class="w-5 h-5" />
diff --git a/frontend/src/components/Plan/components/StatementSection/StatementSection.vue b/frontend/src/components/Plan/components/StatementSection/StatementSection.vue
index 1163d7e1d2..ba0b29f914 100644
--- a/frontend/src/components/Plan/components/StatementSection/StatementSection.vue
+++ b/frontend/src/components/Plan/components/StatementSection/StatementSection.vue
@@ -1,7 +1,9 @@
<template>
- <div v-if="viewMode === 'EDITOR'" class="flex-1">
- <EditorView :key="editorViewKey" :header-variant="headerVariant" />
- </div>
+ <EditorView
+ v-if="viewMode === 'EDITOR'"
+ :key="editorViewKey"
+ :header-variant="headerVariant"
+ />
<ReleaseView v-else-if="viewMode === 'RELEASE'" />
</template>