Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: vault tls config (#18852)
ecmadaob6b430404c12
diff --git a/backend/component/secret/vault.go b/backend/component/secret/vault.goindex b5893796b1..4cfcba7739 100644--- a/backend/component/secret/vault.go+++ b/backend/component/secret/vault.go@@ -2,6 +2,9 @@ package secretimport ("context"+ "crypto/tls"+ "crypto/x509"+ "net/http""github.com/pkg/errors"@@ -15,26 +18,34 @@ func getVaultClient(ctx context.Context, externalSecret *storepb.DataSourceExterconfig := vault.DefaultConfig()config.Address = externalSecret.Url- // Configure TLS based on Vault-specific TLS settings- tlsConfig := &vault.TLSConfig{- // Use skip_vault_tls_verification from ExternalSecret- // Default is false (verification enabled) for security- Insecure: externalSecret.SkipVaultTlsVerification,+ // Build TLS config manually to use certificate content instead of file paths+ tlsConfig := &tls.Config{+ InsecureSkipVerify: externalSecret.SkipVaultTlsVerification,}- // If custom CA certificate is provided for Vault, use it+ // Add CA certificate from bytesif externalSecret.VaultSslCa != "" {- tlsConfig.CACertBytes = []byte(externalSecret.VaultSslCa)+ caCertPool := x509.NewCertPool()+ if !caCertPool.AppendCertsFromPEM([]byte(externalSecret.VaultSslCa)) {+ return nil, errors.Errorf("failed to parse CA certificate")+ }+ tlsConfig.RootCAs = caCertPool}- // Configure client certificate for Vault if provided+ // Add client certificate from bytesif externalSecret.VaultSslCert != "" && externalSecret.VaultSslKey != "" {- tlsConfig.ClientCert = externalSecret.VaultSslCert- tlsConfig.ClientKey = externalSecret.VaultSslKey+ cert, err := tls.X509KeyPair([]byte(externalSecret.VaultSslCert), []byte(externalSecret.VaultSslKey))+ if err != nil {+ return nil, errors.Wrapf(err, "failed to load client certificate")+ }+ tlsConfig.Certificates = []tls.Certificate{cert}}- if err := config.ConfigureTLS(tlsConfig); err != nil {- return nil, errors.Wrapf(err, "failed to configure TLS")+ // Create HTTP client with custom TLS transport+ config.HttpClient = &http.Client{+ Transport: &http.Transport{+ TLSClientConfig: tlsConfig,+ },}client, err := vault.NewClient(config)