Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
perf(mssql): remove redundant TSQL parsing from unit tests (#18623)
p0nybd3b53bf44d0
diff --git a/backend/plugin/schema/mssql/generate_migration_test.go b/backend/plugin/schema/mssql/generate_migration_test.goindex 99650d1516..b02b276527 100644--- a/backend/plugin/schema/mssql/generate_migration_test.go+++ b/backend/plugin/schema/mssql/generate_migration_test.go@@ -10,7 +10,6 @@ import ("gopkg.in/yaml.v3"storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/parser/tsql""github.com/bytebase/bytebase/backend/plugin/schema""github.com/bytebase/bytebase/backend/store/model")@@ -89,12 +88,6 @@ func runMigrationTest(t *testing.T, file string) {migration, err := generateMigration(diff)require.NoErrorf(t, err, "Failed to generate migration for test case [%02d]: %s", i+1, test.Description)- // Parse the generated migration to ensure it's valid SQL- if migration != "" {- _, err := tsql.ParseTSQL(migration)- require.NoErrorf(t, err, "Failed to parse generated SQL for test case [%02d]: %s\nSQL: %s", i+1, test.Description, migration)- }-require.Equalf(t, test.Expected, migration, "Test case [%02d] failed: %s", i+1, test.Description)})}diff --git a/backend/plugin/schema/mssql/get_database_definition_test.go b/backend/plugin/schema/mssql/get_database_definition_test.goindex 0de63c63b0..fdc5b4b87c 100644--- a/backend/plugin/schema/mssql/get_database_definition_test.go+++ b/backend/plugin/schema/mssql/get_database_definition_test.go@@ -10,7 +10,6 @@ import ("github.com/bytebase/bytebase/backend/common"storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/parser/tsql""github.com/bytebase/bytebase/backend/plugin/schema")@@ -45,13 +44,6 @@ func TestGetDatabaseDefinition(t *testing.T) {result, err := GetDatabaseDefinition(schema.GetDefinitionContext{}, &metadata)a.NoError(err)- // Parse the output to ensure it's valid TSQL- _, err = tsql.ParseTSQL(result)- if err != nil {- t.Logf("Test case %d SQL:\n%s", i, result)- }- a.NoError(err, "Test case %d: Failed to parse generated SQL", i)-if record {tests[i].Output = result} else {