Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat: validate access grant query is read-only on creation (#19356)
rebelicebe84a6a1448b
diff --git a/backend/api/v1/access_grant_service.go b/backend/api/v1/access_grant_service.goindex 7eeaf9b389..85e4f66f9e 100644--- a/backend/api/v1/access_grant_service.go+++ b/backend/api/v1/access_grant_service.go@@ -17,6 +17,7 @@ import (storepb "github.com/bytebase/bytebase/backend/generated-go/store"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1""github.com/bytebase/bytebase/backend/generated-go/v1/v1connect"+ parserbase "github.com/bytebase/bytebase/backend/plugin/parser/base""github.com/bytebase/bytebase/backend/store")@@ -145,6 +146,24 @@ func (s *AccessGrantService) CreateAccessGrant(ctx context.Context, request *conreturn nil, connect.NewError(connect.CodeInvalidArgument, errors.New("query is required"))}+ // Validate the query is a read-only statement (SELECT).+ instanceID, _, err := common.GetInstanceDatabaseID(ag.Targets[0])+ if err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "invalid target %q", ag.Targets[0]))+ }+ instance, err := s.store.GetInstance(ctx, &store.FindInstanceMessage{ResourceID: &instanceID})+ if err != nil {+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get instance %q", instanceID))+ }+ if instance == nil {+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("instance %q not found", instanceID))+ }+ if ok, _, err := parserbase.ValidateSQLForEditor(instance.Metadata.GetEngine(), ag.Query); err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "invalid query"))+ } else if !ok {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("only read-only statements are allowed in access grants"))+ }+creatorEmail, err := common.GetUserEmail(ag.Creator)if err != nil {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "invalid creator"))