Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: check sync_interval feature gate after processing activation in UpdateInstance (#19187)
Vincent Huangbf54dd42fd57
diff --git a/backend/api/v1/instance_service.go b/backend/api/v1/instance_service.goindex 13a6844eb1..7b87221f68 100644--- a/backend/api/v1/instance_service.go+++ b/backend/api/v1/instance_service.go@@ -337,6 +337,7 @@ func (s *InstanceService) UpdateInstance(ctx context.Context, req *connect.RequeMetadata: metadata,}updateActivation := false+ updateSyncInterval := falsefor _, path := range req.Msg.UpdateMask.Paths {switch path {case "title":@@ -377,9 +378,7 @@ func (s *InstanceService) UpdateInstance(ctx context.Context, req *connect.Reque}patch.Metadata.Activation = req.Msg.Instance.Activationcase "sync_interval":- if err := s.licenseService.IsFeatureEnabledForInstance(v1pb.PlanFeature_FEATURE_CUSTOM_INSTANCE_SYNC_TIME, instance); err != nil {- return nil, connect.NewError(connect.CodePermissionDenied, err)- }+ updateSyncInterval = truepatch.Metadata.SyncInterval = req.Msg.Instance.SyncIntervalcase "sync_databases":patch.Metadata.SyncDatabases = req.Msg.Instance.SyncDatabases@@ -393,6 +392,16 @@ func (s *InstanceService) UpdateInstance(ctx context.Context, req *connect.Reque}}+ // Check feature gates after all fields are processed so that activation+ // changes in the same request are visible to the license check.+ if updateSyncInterval {+ patchedInstance := *instance+ patchedInstance.Metadata = patch.Metadata+ if err := s.licenseService.IsFeatureEnabledForInstance(v1pb.PlanFeature_FEATURE_CUSTOM_INSTANCE_SYNC_TIME, &patchedInstance); err != nil {+ return nil, connect.NewError(connect.CodePermissionDenied, err)+ }+ }+activatedInstanceLimit := s.licenseService.GetActivatedInstanceLimit(ctx)if updateActivation {count, err := s.store.GetActivatedInstanceCount(ctx)