Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat(frontend): show hint when failed checks block auto-rollout creation (#19450)
boojackc2502c3f9e3a
diff --git a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vueindex 90bf68d4e8..fda9c0eecc 100644--- a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue+++ b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/Sidebar.vue@@ -3,13 +3,21 @@<!-- 1. Stages - Progress indicator --><StagesSection v-if="isDatabaseChangePlan" />- <!-- 2. Checks - Health status -->+ <!-- 2. Checks rollout hint -->+ <NAlert v-if="showChecksBlockRolloutHint" type="error">+ {{ $t("issue.checks-block-rollout-hint") }}+ </NAlert>+ <NAlert v-else-if="showForceRolloutHint" type="warning">+ {{ $t("issue.force-rollout-hint") }}+ </NAlert>++ <!-- 3. Checks - Health status --><ChecksSection v-if="isDatabaseChangePlan" />- <!-- 3. Approval Flow - Reviewers -->+ <!-- 4. Approval Flow - Reviewers --><ApprovalFlowSection :issue="issue" />- <!-- 4. Labels - Metadata -->+ <!-- 5. Labels - Metadata --><IssueLabels:project="project":value="issue.labels || []"@@ -21,17 +29,21 @@<script setup lang="ts">import { create } from "@bufbuild/protobuf";+import { NAlert } from "naive-ui";import { computed } from "vue";import { useI18n } from "vue-i18n";import IssueLabels from "@/components/IssueV1/components/Sidebar/IssueLabels.vue";import { useResourcePoller } from "@/components/Plan/logic/poller";import { issueServiceClientConnect } from "@/connect";import { pushNotification, useCurrentProjectV1 } from "@/store";+import { State } from "@/types/proto-es/v1/common_pb";import {+ Issue_ApprovalStatus,IssueStatus,UpdateIssueRequestSchema,} from "@/types/proto-es/v1/issue_service_pb";import { hasProjectPermissionV2 } from "@/utils";+import { usePlanCheckStatus } from "../../../logic";import { usePlanContextWithIssue } from "../../../logic/context";import ApprovalFlowSection from "./ApprovalFlowSection/ApprovalFlowSection.vue";import ChecksSection from "./ChecksSection.vue";@@ -39,12 +51,45 @@ import StagesSection from "./StagesSection.vue";const { t } = useI18n();const { plan, issue } = usePlanContextWithIssue();+const { project } = useCurrentProjectV1();+const { refreshResources } = useResourcePoller();+const { hasErrors: checksHaveErrors, hasRunning: checksRunning } =+ usePlanCheckStatus(plan);const isDatabaseChangePlan = computed(() =>plan.value.specs.some((spec) => spec.config?.case === "changeDatabaseConfig"));-const { project } = useCurrentProjectV1();-const { refreshResources } = useResourcePoller();++const isApproved = computed(() => {+ const status = issue.value.approvalStatus;+ if (status === Issue_ApprovalStatus.CHECKING) return false;+ const roles = issue.value.approvalTemplate?.flow?.roles ?? [];+ return (+ status === Issue_ApprovalStatus.APPROVED ||+ status === Issue_ApprovalStatus.SKIPPED ||+ roles.length === 0+ );+});++const showChecksHint = computed(() => {+ return (+ issue.value.status === IssueStatus.OPEN &&+ plan.value.state === State.ACTIVE &&+ isDatabaseChangePlan.value &&+ isApproved.value &&+ checksHaveErrors.value &&+ !checksRunning.value &&+ !plan.value.hasRollout+ );+});++const showChecksBlockRolloutHint = computed(() => {+ return showChecksHint.value && project.value.requirePlanCheckNoError;+});++const showForceRolloutHint = computed(() => {+ return showChecksHint.value && !project.value.requirePlanCheckNoError;+});const allowChange = computed(() => {if (issue.value.status !== IssueStatus.OPEN) {diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex 6286b0b22a..6f182a7152 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -1072,6 +1072,8 @@"approval-flow": {"self": "Approval flow"},+ "force-rollout-hint": "Proceed with manual rollout to override failed checks.",+ "checks-block-rollout-hint": "Failed checks are preventing rollout creation. Fix the errors to proceed.","risk-level": {"self": "Risk level","low": "Low",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 07bacc6aeb..edef9521f2 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -1072,6 +1072,8 @@"approval-flow": {"self": "Flujo de aprobación"},+ "force-rollout-hint": "Proceda con el despliegue manual para anular las verificaciones fallidas.",+ "checks-block-rollout-hint": "Las verificaciones fallidas impiden la creación del despliegue. Corrija los errores para continuar.","risk-level": {"self": "Nivel de riesgo","low": "Bajo",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 4654862ce9..187baa7245 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -1072,6 +1072,8 @@"approval-flow": {"self": "承認の流れ"},+ "force-rollout-hint": "手動でロールアウトを作成して、失敗したチェックをオーバーライドしてください。",+ "checks-block-rollout-hint": "チェックの失敗によりロールアウトを作成できません。エラーを修正してから続行してください。","risk-level": {"self": "リスクレベル","low": "低い",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex 7db0a7b16a..97cab63da6 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -1072,6 +1072,8 @@"approval-flow": {"self": "Quy trình phê duyệt"},+ "force-rollout-hint": "Tiến hành triển khai thủ công để bỏ qua các kiểm tra thất bại.",+ "checks-block-rollout-hint": "Kiểm tra thất bại đang ngăn việc tạo triển khai. Hãy sửa lỗi để tiếp tục.","risk-level": {"self": "Mức độ rủi ro","low": "Thấp",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex ef679af2e2..5a77afff3f 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -1072,6 +1072,8 @@"approval-flow": {"self": "审批流"},+ "force-rollout-hint": "手动创建发布以跳过失败的 SQL 检查。",+ "checks-block-rollout-hint": "SQL 检查失败导致无法创建发布。请修复错误后再继续。","risk-level": {"self": "风险等级","low": "低风险",