Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

feat(frontend): skip issue creation when applying release to databases (#18739)

Danny Xuc27c6abed7aa
diff --git a/frontend/src/components/Release/ReleaseDetail/NavBar/ApplyToDatabasePanel.vue b/frontend/src/components/Release/ReleaseDetail/NavBar/ApplyToDatabasePanel.vue
index fb2583a6f7..a21aecd08f 100644
--- a/frontend/src/components/Release/ReleaseDetail/NavBar/ApplyToDatabasePanel.vue
+++ b/frontend/src/components/Release/ReleaseDetail/NavBar/ApplyToDatabasePanel.vue
@@ -59,20 +59,20 @@ import DatabaseAndGroupSelector, {
type DatabaseSelectState,
} from "@/components/DatabaseAndGroupSelector/";
import { Drawer, DrawerContent, ErrorTipsButton } from "@/components/v2";
-import { planServiceClientConnect } from "@/grpcweb";
-import { PROJECT_V1_ROUTE_ISSUE_DETAIL } from "@/router/dashboard/projectV1";
-import { useDatabaseV1Store, useDBGroupStore } from "@/store";
+import {
+ planServiceClientConnect,
+ rolloutServiceClientConnect,
+} from "@/grpcweb";
+import { PROJECT_V1_ROUTE_PLAN_ROLLOUT } from "@/router/dashboard/projectV1";
import { getProjectNameReleaseId } from "@/store/modules/v1/common";
import { DatabaseChangeType } from "@/types/proto-es/v1/common_pb";
-import { DatabaseGroupSchema } from "@/types/proto-es/v1/database_group_service_pb";
import {
CreatePlanRequestSchema,
Plan_ChangeDatabaseConfigSchema,
PlanSchema,
} from "@/types/proto-es/v1/plan_service_pb";
-import { generateIssueTitle, issueV1Slug } from "@/utils";
+import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";
import { useReleaseDetailContext } from "../context";
-import { createIssueFromPlan } from "./utils";
const emit = defineEmits<{
(event: "close"): void;
@@ -83,8 +83,6 @@ type LocalState = {
};
const router = useRouter();
-const databaseStore = useDatabaseV1Store();
-const dbGroupStore = useDBGroupStore();
const { release, project } = useReleaseDetailContext();
const state = reactive<LocalState>({});
@@ -108,16 +106,6 @@ const handleCreate = async () => {
return;
}
- const databaseList = state.targetSelectState.selectedDatabaseNameList.map(
- (name) => databaseStore.getDatabaseByName(name)
- );
- const databaseGroup = create(
- DatabaseGroupSchema,
- dbGroupStore.getDBGroupByName(
- state.targetSelectState.selectedDatabaseGroup || ""
- )
- );
-
// Determine enableGhost from release files
const firstFile = release.value.files?.[0];
const enableGhost = firstFile?.enableGhost ?? false;
@@ -143,27 +131,29 @@ const handleCreate = async () => {
},
],
});
- const request = create(CreatePlanRequestSchema, {
+
+ // Create plan
+ const planRequest = create(CreatePlanRequestSchema, {
parent: project.value.name,
plan: newPlan,
});
- const response = await planServiceClientConnect.createPlan(request);
- const createdIssue = await createIssueFromPlan(project.value.name, {
- ...response,
- // Override title and description.
- title: generateIssueTitle(
- "bb.issue.database.update",
- state.targetSelectState.changeSource === "DATABASE"
- ? databaseList.map((db) => db.databaseName)
- : [databaseGroup?.title]
- ),
- description: `Apply release "${release.value.title}"`,
+ const createdPlan = await planServiceClientConnect.createPlan(planRequest);
+
+ // Create rollout directly without creating an issue
+ const rolloutRequest = create(CreateRolloutRequestSchema, {
+ parent: createdPlan.name,
});
+ await rolloutServiceClientConnect.createRollout(rolloutRequest);
+
+ // Extract planId from plan name (format: projects/{project}/plans/{planId})
+ const planId = createdPlan.name.split("/").pop();
+
+ // Redirect to rollout view
router.push({
- name: PROJECT_V1_ROUTE_ISSUE_DETAIL,
+ name: PROJECT_V1_ROUTE_PLAN_ROLLOUT,
params: {
projectId: getProjectNameReleaseId(release.value.name)[0],
- issueSlug: issueV1Slug(createdIssue.name, createdIssue.title),
+ planId,
},
});
};
diff --git a/frontend/src/components/Release/ReleaseDetail/NavBar/utils.ts b/frontend/src/components/Release/ReleaseDetail/NavBar/utils.ts
deleted file mode 100644
index 0d4d6ff18e..0000000000
--- a/frontend/src/components/Release/ReleaseDetail/NavBar/utils.ts
+++ /dev/null
@@ -1,44 +0,0 @@
-import { create } from "@bufbuild/protobuf";
-import {
- issueServiceClientConnect,
- rolloutServiceClientConnect,
-} from "@/grpcweb";
-import { useCurrentUserV1 } from "@/store";
-import { type ComposedIssue, emptyIssue } from "@/types";
-import {
- CreateIssueRequestSchema,
- Issue_Type,
- IssueSchema,
- IssueStatus,
-} from "@/types/proto-es/v1/issue_service_pb";
-import type { Plan } from "@/types/proto-es/v1/plan_service_pb";
-import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";
-
-export const createIssueFromPlan = async (project: string, plan: Plan) => {
- const me = useCurrentUserV1();
- const issue = create(IssueSchema, {
- plan: plan.name,
- creator: `users/${me.value.email}`,
- title: plan.title,
- description: plan.description,
- status: IssueStatus.OPEN,
- type: Issue_Type.DATABASE_CHANGE,
- });
- const request = create(CreateIssueRequestSchema, {
- parent: project,
- issue: issue,
- });
- const createdIssue = await issueServiceClientConnect.createIssue(request);
- const rolloutRequest = create(CreateRolloutRequestSchema, {
- parent: plan.name,
- });
- const createdRollout =
- await rolloutServiceClientConnect.createRollout(rolloutRequest);
- const composedIssue: ComposedIssue = {
- ...emptyIssue(),
- ...createdIssue,
- planEntity: plan,
- rolloutEntity: createdRollout,
- };
- return composedIssue;
-};