Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor: request role (#18831)

ecmadaoc4bd4164c99d
diff --git a/frontend/src/components/GrantRequestPanel/GrantRequestPanel.vue b/frontend/src/components/GrantRequestPanel/GrantRequestPanel.vue
index 1f4ccecc27..4c171a4eed 100644
--- a/frontend/src/components/GrantRequestPanel/GrantRequestPanel.vue
+++ b/frontend/src/components/GrantRequestPanel/GrantRequestPanel.vue
@@ -25,9 +25,9 @@
</div>
<template #footer>
<div class="flex items-center justify-end gap-x-2">
- <NButton quaternary @click="$emit('close')">{{
- $t("common.cancel")
- }}</NButton>
+ <NButton quaternary @click="$emit('close')">
+ {{ $t("common.cancel") }}
+ </NButton>
<NButton
type="primary"
:disabled="!allowCreate"
diff --git a/frontend/src/components/misc/NoPermissionPlaceholder.vue b/frontend/src/components/Permission/NoPermissionPlaceholder.vue
similarity index 100%
rename from frontend/src/components/misc/NoPermissionPlaceholder.vue
rename to frontend/src/components/Permission/NoPermissionPlaceholder.vue
diff --git a/frontend/src/components/Permission/RoutePermissionGuard.vue b/frontend/src/components/Permission/RoutePermissionGuard.vue
index 24a74227f8..2d3f74e883 100644
--- a/frontend/src/components/Permission/RoutePermissionGuard.vue
+++ b/frontend/src/components/Permission/RoutePermissionGuard.vue
@@ -6,16 +6,40 @@
:path="requestPath"
:resources="project ? [project.name] : []"
:permissions="missedPermissions"
+ >
+ <template #action>
+ <div v-if="allowRequestRole" class="mt-2">
+ <NButton
+ type="primary"
+ @click="showRequestRolePanel = true"
+ >
+ <template #icon>
+ <heroicons-outline:user-add class="w-4 h-4" />
+ </template>
+ {{ $t("issue.title.request-role") }}
+ </NButton>
+ </div>
+ </template>
+ </NoPermissionPlaceholder>
+
+ <GrantRequestPanel
+ v-if="showRequestRolePanel && project"
+ :project-name="project.name"
+ @close="showRequestRolePanel = false"
/>
</template>
<script lang="tsx" setup>
-import { computed } from "vue";
+import { NButton } from "naive-ui";
+import { computed, ref } from "vue";
import type { RouteRecordRaw } from "vue-router";
import { useRouter } from "vue-router";
-import NoPermissionPlaceholder from "@/components/misc/NoPermissionPlaceholder.vue";
+import GrantRequestPanel from "@/components/GrantRequestPanel";
+import NoPermissionPlaceholder from "@/components/Permission/NoPermissionPlaceholder.vue";
import { getFlattenRoutes } from "@/components/v2/Sidebar/utils.ts";
+import { hasFeature } from "@/store";
import type { Project } from "@/types/proto-es/v1/project_service_pb";
+import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
import { hasProjectPermissionV2, hasWorkspacePermissionV2 } from "@/utils";
const props = defineProps<{
@@ -23,7 +47,16 @@ const props = defineProps<{
routes: RouteRecordRaw[];
}>();
+const showRequestRolePanel = ref(false);
const router = useRouter();
+const allowRequestRole = computed(() => {
+ return (
+ props.project?.allowRequestRole &&
+ hasFeature(PlanFeature.FEATURE_REQUEST_ROLE_WORKFLOW) &&
+ hasProjectPermissionV2(props.project, "bb.issues.create") &&
+ hasWorkspacePermissionV2("bb.roles.list")
+ );
+});
const flattenRoutes = computed(() => {
return getFlattenRoutes(props.routes);
diff --git a/frontend/src/components/Plan/components/IssueReviewView/GrantRequestView/RequestDetailsSection.vue b/frontend/src/components/Plan/components/IssueReviewView/GrantRequestView/RequestDetailsSection.vue
index d7386e9d18..f012e0d56e 100644
--- a/frontend/src/components/Plan/components/IssueReviewView/GrantRequestView/RequestDetailsSection.vue
+++ b/frontend/src/components/Plan/components/IssueReviewView/GrantRequestView/RequestDetailsSection.vue
@@ -6,15 +6,30 @@
<div class="p-4 border rounded-sm flex flex-col gap-y-4">
<!-- Requested Role -->
- <div v-if="requestRole" class="flex flex-col gap-y-2">
+ <div v-if="requestRoleName" class="flex flex-col gap-y-2">
<span class="text-sm text-control-light">
{{ $t("role.self") }}
</span>
<div class="text-base">
- {{ displayRoleTitle(requestRole) }}
+ {{ displayRoleTitle(requestRoleName) }}
</div>
</div>
+ <div v-if="requestRole" class="flex flex-col gap-y-2">
+ <span class="text-sm text-control-light">
+ {{ $t("common.permissions") }}
+ </span>
+ <div class="max-h-[10em] overflow-auto border rounded-sm p-2">
+ <p
+ v-for="permission in requestRole.permissions"
+ :key="permission"
+ class="text-sm leading-5"
+ >
+ {{ permission }}
+ </p>
+ </div>
+ </div>
+
<!-- Database Resources -->
<div v-if="condition?.databaseResources" class="flex flex-col gap-y-2">
<span class="text-sm text-control-light">
@@ -54,16 +69,22 @@ import { computedAsync } from "@vueuse/core";
import dayjs from "dayjs";
import { computed } from "vue";
import { DatabaseResourceTable } from "@/components/IssueV1/components";
+import { useRoleStore } from "@/store";
import { displayRoleTitle } from "@/utils";
import { convertFromCELString } from "@/utils/issue/cel";
import { usePlanContextWithIssue } from "../../../logic";
const { issue } = usePlanContextWithIssue();
+const roleStore = useRoleStore();
-const requestRole = computed(() => {
+const requestRoleName = computed(() => {
return issue.value.grantRequest?.role;
});
+const requestRole = computed(() =>
+ roleStore.getRoleByName(requestRoleName?.value ?? "")
+);
+
const condition = computedAsync(
async () => {
try {
diff --git a/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue b/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue
index 73ddf2aebb..95ec7a8b20 100644
--- a/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue
+++ b/frontend/src/components/Plan/components/SpecDetailView/SpecDetailView.vue
@@ -5,11 +5,11 @@
class="w-full flex-1 flex flex-col lg:flex-row px-4 gap-4 overflow-hidden"
>
<!-- Left: Targets + Statement -->
- <div class="flex-1 flex flex-col min-w-0 overflow-y-auto py-3">
+ <div class="flex-1 flex flex-col min-w-0 overflow-y-auto gap-y-3 py-3">
<TargetListSection />
<DataExportOptionsSection v-if="isDataExportPlan" />
<FailedTaskRunsSection v-if="!isCreating && rollout" />
- <div class="flex-1 py-3 flex flex-col">
+ <div class="flex-1 flex flex-col">
<StatementSection />
</div>
</div>
diff --git a/frontend/src/components/ProjectMember/AddProjectMember/AddProjectMemberForm.vue b/frontend/src/components/ProjectMember/AddProjectMember/AddProjectMemberForm.vue
index 83c3960e0b..b5a6930582 100644
--- a/frontend/src/components/ProjectMember/AddProjectMember/AddProjectMemberForm.vue
+++ b/frontend/src/components/ProjectMember/AddProjectMember/AddProjectMemberForm.vue
@@ -29,6 +29,20 @@
:filter="filterRole"
/>
</div>
+ <div v-if="selectedRole" class="w-full flex flex-col gap-y-2">
+ <div class="flex items-center gap-x-1">
+ <span>{{ $t("common.permissions") }}</span>
+ </div>
+ <div class="max-h-[10em] overflow-auto border rounded-sm p-2">
+ <p
+ v-for="permission in selectedRole.permissions"
+ :key="permission"
+ class="text-sm leading-5"
+ >
+ {{ permission }}
+ </p>
+ </div>
+ </div>
<div class="w-full flex flex-col gap-y-2">
<div class="flex items-center gap-x-1">
<span>{{ $t("common.reason") }}</span>
@@ -85,6 +99,7 @@ import QuerierDatabaseResourceForm from "@/components/GrantRequestPanel/Database
import MembersBindingSelect from "@/components/Member/MembersBindingSelect.vue";
import RequiredStar from "@/components/RequiredStar.vue";
import { RoleSelect } from "@/components/v2/Select";
+import { useRoleStore } from "@/store";
import { type DatabaseResource, PresetRoleType } from "@/types";
import { type Binding, BindingSchema } from "@/types/proto-es/v1/iam_policy_pb";
import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
@@ -141,6 +156,9 @@ const state = reactive<LocalState>(getInitialState());
const expirationSelectorRef = ref<InstanceType<typeof ExpirationSelector>>();
const databaseResourceFormRef =
ref<InstanceType<typeof QuerierDatabaseResourceForm>>();
+const roleStore = useRoleStore();
+
+const selectedRole = computed(() => roleStore.getRoleByName(state.role));
defineExpose({
reason: computed(() => state.reason),
diff --git a/frontend/src/components/ProjectMember/ProjectMemberPanel.vue b/frontend/src/components/ProjectMember/ProjectMemberPanel.vue
index 348050c931..ee7b1f8961 100644
--- a/frontend/src/components/ProjectMember/ProjectMemberPanel.vue
+++ b/frontend/src/components/ProjectMember/ProjectMemberPanel.vue
@@ -42,10 +42,12 @@
<NButton
v-if="shouldShowRequestRoleButton"
type="primary"
+ :disabled="!hasRequestRoleFeature"
@click="state.showRequestRolePanel = true"
>
<template #icon>
- <heroicons-outline:user-add class="w-4 h-4" />
+ <ShieldUserIcon v-if="hasRequestRoleFeature" class="w-4 h-4" />
+ <FeatureBadge v-else :clickable="false" :feature="PlanFeature.FEATURE_REQUEST_ROLE_WORKFLOW" />
</template>
{{ $t("issue.title.request-role") }}
</NButton>
@@ -111,9 +113,11 @@
<script lang="ts" setup>
import { cloneDeep } from "lodash-es";
+import { ShieldUserIcon } from "lucide-vue-next";
import { NButton, NTabPane, NTabs, useDialog } from "naive-ui";
import { computed, reactive } from "vue";
import { useI18n } from "vue-i18n";
+import { FeatureBadge } from "@/components/FeatureGuard";
import LearnMoreLink from "@/components/LearnMoreLink.vue";
import MemberDataTable from "@/components/Member/MemberDataTable/index.vue";
import MemberDataTableByRole from "@/components/Member/MemberDataTableByRole.vue";
@@ -137,7 +141,11 @@ import {
} from "@/types";
import type { Project } from "@/types/proto-es/v1/project_service_pb";
import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
-import { hasProjectPermissionV2, isBindingPolicyExpired } from "@/utils";
+import {
+ hasProjectPermissionV2,
+ hasWorkspacePermissionV2,
+ isBindingPolicyExpired,
+} from "@/utils";
import GrantRequestPanel from "../GrantRequestPanel";
import { SearchBox } from "../v2";
import AddProjectMembersPanel from "./AddProjectMember/AddProjectMembersPanel.vue";
@@ -188,16 +196,16 @@ const allowEdit = computed(() => {
return hasProjectPermissionV2(props.project, "bb.projects.setIamPolicy");
});
-const shouldShowRequestRoleButton = computed(() => {
- // Check if grant request feature is available (Enterprise plan only)
- const hasRequestRoleFeature = subscriptionStore.hasFeature(
- PlanFeature.FEATURE_REQUEST_ROLE_WORKFLOW
- );
+const hasRequestRoleFeature = computed(() =>
+ subscriptionStore.hasFeature(PlanFeature.FEATURE_REQUEST_ROLE_WORKFLOW)
+);
+const shouldShowRequestRoleButton = computed(() => {
return (
- hasRequestRoleFeature &&
!isProjectOwner.value &&
- hasProjectPermissionV2(props.project, "bb.issues.create")
+ props.project.allowSelfApproval &&
+ hasProjectPermissionV2(props.project, "bb.issues.create") &&
+ hasWorkspacePermissionV2("bb.roles.list")
);
});
diff --git a/frontend/src/components/SQLReview/components/SQLReviewForResource.vue b/frontend/src/components/SQLReview/components/SQLReviewForResource.vue
index 877663d6fd..d911a12f29 100644
--- a/frontend/src/components/SQLReview/components/SQLReviewForResource.vue
+++ b/frontend/src/components/SQLReview/components/SQLReviewForResource.vue
@@ -1,5 +1,5 @@
<template>
- <div class="flex flex-col gap-y-2">
+ <div v-if="allowGetSQLReviewPolicy" class="flex flex-col gap-y-2">
<div class="flex items-center gap-x-2">
<label class="font-medium">
{{ $t("sql-review.title") }}
@@ -117,6 +117,10 @@ const resetState = () => {
watchEffect(resetState);
+const allowGetSQLReviewPolicy = computed(() => {
+ return props.allowEdit && hasWorkspacePermissionV2("bb.reviewConfigs.get");
+});
+
const allowEditSQLReviewPolicy = computed(() => {
return props.allowEdit && hasWorkspacePermissionV2("bb.reviewConfigs.update");
});
diff --git a/frontend/src/components/User/Settings/CreateUserDrawer.vue b/frontend/src/components/User/Settings/CreateUserDrawer.vue
index 1c9d8c4b6e..102a8280fa 100644
--- a/frontend/src/components/User/Settings/CreateUserDrawer.vue
+++ b/frontend/src/components/User/Settings/CreateUserDrawer.vue
@@ -349,6 +349,7 @@ import {
useWorkspaceV1Store,
} from "@/store";
import { emptyUser } from "@/types";
+import { PresetRoleType } from "@/types/iam";
import type { User } from "@/types/proto-es/v1/user_service_pb";
import {
UserSchema,
@@ -393,7 +394,7 @@ const userPasswordRef = ref<InstanceType<typeof UserPassword>>();
const state = reactive<LocalState>({
isRequesting: false,
user: emptyUser(),
- roles: [],
+ roles: [PresetRoleType.WORKSPACE_MEMBER],
passwordConfirm: "",
wif: {
emailPrefix: "",
diff --git a/frontend/src/components/v2/Select/RoleSelect.vue b/frontend/src/components/v2/Select/RoleSelect.vue
index 80a80cdab4..eefc09d71b 100644
--- a/frontend/src/components/v2/Select/RoleSelect.vue
+++ b/frontend/src/components/v2/Select/RoleSelect.vue
@@ -9,6 +9,7 @@
:max-tag-count="'responsive'"
:filterable="true"
:render-label="renderLabel"
+ :render-tag="renderTag"
:placeholder="$t('settings.members.select-role', multiple ? 2 : 1)"
to="body"
@update:value="onValueUpdate"
@@ -23,7 +24,8 @@
<script setup lang="tsx">
import type { SelectGroupOption, SelectOption } from "naive-ui";
import { NSelect } from "naive-ui";
-import { computed, h, ref } from "vue";
+import type { SelectBaseOption } from "naive-ui/lib/select/src/interface";
+import { computed, ref } from "vue";
import FeatureBadge from "@/components/FeatureGuard/FeatureBadge.vue";
import FeatureModal from "@/components/FeatureGuard/FeatureModal.vue";
import { t } from "@/plugins/i18n";
@@ -33,8 +35,13 @@ import {
PRESET_ROLES,
PRESET_WORKSPACE_ROLES,
} from "@/types";
+import type { Role } from "@/types/proto-es/v1/role_service_pb";
import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
-import { displayRoleTitle } from "@/utils";
+import { displayRoleDescription, displayRoleTitle } from "@/utils";
+
+type RoleSelectOption = SelectOption & {
+ role: Role;
+};
const props = withDefaults(
defineProps<{
@@ -72,7 +79,7 @@ const filterRole = (role: string) => {
};
const availableRoleOptions = computed(
- (): (SelectOption | SelectGroupOption)[] => {
+ (): (RoleSelectOption | SelectGroupOption)[] => {
const roleGroups: SelectGroupOption[] = [];
if (props.includeWorkspaceRoles) {
@@ -80,10 +87,13 @@ const availableRoleOptions = computed(
type: "group",
key: "workspace-roles",
label: t("role.workspace-roles.self"),
- children: PRESET_WORKSPACE_ROLES.filter(filterRole).map((role) => ({
- label: displayRoleTitle(role),
- value: role,
- })),
+ children: PRESET_WORKSPACE_ROLES.map(roleStore.getRoleByName)
+ .filter((role) => role && filterRole(role.name))
+ .map<RoleSelectOption>((role) => ({
+ label: displayRoleTitle(role!.name),
+ value: role!.name,
+ role: role!,
+ })),
});
}
@@ -91,23 +101,27 @@ const availableRoleOptions = computed(
type: "group",
key: "project-roles",
label: t("role.project-roles.self") + props.suffix,
- children: PRESET_PROJECT_ROLES.filter(filterRole).map((role) => ({
- label: displayRoleTitle(role),
- value: role,
- })),
+ children: PRESET_PROJECT_ROLES.map(roleStore.getRoleByName)
+ .filter((role) => role && filterRole(role.name))
+ .map<RoleSelectOption>((role) => ({
+ label: displayRoleTitle(role!.name),
+ value: role!.name,
+ role: role!,
+ })),
});
- const customRoles = roleStore.roleList
- .map((role) => role.name)
- .filter((role) => !PRESET_ROLES.includes(role) && filterRole(role));
+ const customRoles = roleStore.roleList.filter(
+ (role) => !PRESET_ROLES.includes(role.name) && filterRole(role.name)
+ );
if (customRoles.length > 0) {
roleGroups.push({
type: "group",
key: "custom-roles",
label: t("role.custom-roles.self") + props.suffix,
- children: customRoles.map((role) => ({
- label: displayRoleTitle(role),
- value: role,
+ children: customRoles.map<RoleSelectOption>((role) => ({
+ label: displayRoleTitle(role.name),
+ value: role.name,
+ role,
})),
});
}
@@ -116,25 +130,32 @@ const availableRoleOptions = computed(
}
);
-const renderLabel = (option: SelectOption) => {
- const label = h("span", {}, option.label as string);
- if (hasCustomRoleFeature.value || !option.value) {
- return label;
- }
- if (PRESET_ROLES.includes(option.value as string)) {
- return label;
+const renderTag = ({ option }: { option: SelectBaseOption }) => {
+ return option.label as string;
+};
+
+const renderLabel = (option: SelectBaseOption & SelectGroupOption) => {
+ if (option.type === "group") {
+ return option.label as string;
}
- const icon = h(FeatureBadge, {
- feature: PlanFeature.FEATURE_CUSTOM_ROLES,
- clickable: false,
- });
- return h(
- "div",
- {
- class: "flex items-center gap-1",
- },
- [label, icon]
+ const { role, label } = option as SelectBaseOption as RoleSelectOption;
+ const isCustomRole = !PRESET_ROLES.includes(role.name);
+ const description = displayRoleDescription(role.name);
+
+ return (
+ <div class="py-1">
+ <div class="flex items-center gap-x-1">
+ {label}
+ {!hasCustomRoleFeature.value && isCustomRole ? (
+ <FeatureBadge
+ feature={PlanFeature.FEATURE_CUSTOM_ROLES}
+ clickable={false}
+ />
+ ) : null}
+ </div>
+ {description && <div class="textinfolabel text-xs!">{description}</div>}
+ </div>
);
};
diff --git a/frontend/src/router/dashboard/projectV1.ts b/frontend/src/router/dashboard/projectV1.ts
index 8b13140f44..bce2ebce1e 100644
--- a/frontend/src/router/dashboard/projectV1.ts
+++ b/frontend/src/router/dashboard/projectV1.ts
@@ -343,11 +343,7 @@ const projectV1Routes: RouteRecordRaw[] = [
name: PROJECT_V1_ROUTE_MEMBERS,
meta: {
title: () => t("common.members"),
- requiredPermissionList: () => [
- "bb.projects.getIamPolicy",
- "bb.users.list",
- "bb.groups.list",
- ],
+ requiredPermissionList: () => ["bb.projects.getIamPolicy"],
},
component: () => import("@/views/project/ProjectMemberDashboard.vue"),
props: true,
@@ -357,6 +353,7 @@ const projectV1Routes: RouteRecordRaw[] = [
name: PROJECT_V1_ROUTE_SETTINGS,
meta: {
title: () => t("common.settings"),
+ requiredPermissionList: () => ["bb.policies.get"],
},
component: () => import("@/views/project/ProjectSettingPanel.vue"),
props: true,
diff --git a/frontend/src/store/modules/sqlReview.ts b/frontend/src/store/modules/sqlReview.ts
index ffc617ea6f..87b15e5646 100644
--- a/frontend/src/store/modules/sqlReview.ts
+++ b/frontend/src/store/modules/sqlReview.ts
@@ -250,7 +250,7 @@ export const useSQLReviewStore = defineStore("sqlReview", {
}
return reviewPolicy;
},
- async getOrFetchReviewPolicyByName(name: string) {
+ async getOrFetchReviewPolicyByName(name: string, silent: boolean) {
const policy = this.getReviewPolicyByName(name);
if (policy) {
return policy;
@@ -258,11 +258,13 @@ export const useSQLReviewStore = defineStore("sqlReview", {
const reviewPolicy = await this.fetchReviewPolicyByName({
name,
+ silent,
});
return reviewPolicy;
},
async getOrFetchReviewPolicyByResource(
- resourcePath: string
+ resourcePath: string,
+ silent: boolean
): Promise<SQLReviewPolicy | undefined> {
const cached = this.getReviewPolicyByResouce(resourcePath);
if (cached) {
@@ -285,7 +287,7 @@ export const useSQLReviewStore = defineStore("sqlReview", {
return;
}
- return this.getOrFetchReviewPolicyByName(sqlReviewName);
+ return this.getOrFetchReviewPolicyByName(sqlReviewName, silent);
},
},
});
@@ -306,7 +308,10 @@ export const useReviewPolicyByResource = (
const store = useSQLReviewStore();
watchEffect(() => {
if (!unref(resourcePath)) return;
- store.getOrFetchReviewPolicyByResource(unref(resourcePath)!);
+ store.getOrFetchReviewPolicyByResource(
+ unref(resourcePath)!,
+ true /* silent */
+ );
});
return computed(() => {
@@ -324,7 +329,8 @@ export const useReviewPolicyForDatabase = (
if (!unref(database)) return;
const reviewForProject = await store.getOrFetchReviewPolicyByResource(
- unref(database)!.project
+ unref(database)!.project,
+ true /* silent */
);
if (reviewForProject) {
return;
@@ -332,7 +338,10 @@ export const useReviewPolicyForDatabase = (
const { effectiveEnvironment } = unref(database)!;
if (effectiveEnvironment) {
- await store.getOrFetchReviewPolicyByResource(effectiveEnvironment);
+ await store.getOrFetchReviewPolicyByResource(
+ effectiveEnvironment,
+ true /* silent */
+ );
}
});
diff --git a/frontend/src/views/Page403.vue b/frontend/src/views/Page403.vue
index fa266f0803..5b7e702a63 100644
--- a/frontend/src/views/Page403.vue
+++ b/frontend/src/views/Page403.vue
@@ -22,7 +22,7 @@ import { ChevronLeftIcon } from "lucide-vue-next";
import { NButton } from "naive-ui";
import { computed } from "vue";
import { useRoute, useRouter } from "vue-router";
-import NoPermissionPlaceholder from "@/components/misc/NoPermissionPlaceholder.vue";
+import NoPermissionPlaceholder from "@/components/Permission/NoPermissionPlaceholder.vue";
import { WORKSPACE_ROOT_MODULE } from "@/router/dashboard/workspaceRoutes";
import type { Permission } from "@/types";
diff --git a/frontend/src/views/ProfileDashboard.vue b/frontend/src/views/ProfileDashboard.vue
index 2083e3b131..cce6988aa8 100644
--- a/frontend/src/views/ProfileDashboard.vue
+++ b/frontend/src/views/ProfileDashboard.vue
@@ -227,8 +227,8 @@ import EmailInput from "@/components/EmailInput.vue";
import { FeatureModal } from "@/components/FeatureGuard";
import FeatureBadge from "@/components/FeatureGuard/FeatureBadge.vue";
import LearnMoreLink from "@/components/LearnMoreLink.vue";
-import NoPermissionPlaceholder from "@/components/misc/NoPermissionPlaceholder.vue";
import ServiceAccountTag from "@/components/misc/ServiceAccountTag.vue";
+import NoPermissionPlaceholder from "@/components/Permission/NoPermissionPlaceholder.vue";
import RegenerateRecoveryCodesView from "@/components/RegenerateRecoveryCodesView.vue";
import { ActionConfirmModal } from "@/components/SchemaEditorLite";
import UserPassword from "@/components/User/Settings/UserPassword.vue";
@@ -431,6 +431,11 @@ const saveEdit = async () => {
regenerateTempMfaSecret: false,
})
);
+ pushNotification({
+ module: "bytebase",
+ style: "SUCCESS",
+ title: t("common.updated"),
+ });
}
} catch (error) {
pushNotification({
diff --git a/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue b/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue
index 022119d39d..49ef988d22 100644
--- a/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue
+++ b/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue
@@ -226,7 +226,10 @@ const sqlReviewName = computed(() =>
);
watchEffect(async () => {
- await store.getOrFetchReviewPolicyByName(sqlReviewName.value);
+ await store.getOrFetchReviewPolicyByName(
+ sqlReviewName.value,
+ false /* not silent */
+ );
});
onMounted(() => {
diff --git a/frontend/src/views/sql-editor/EditorCommon/ResultView/RequestQueryButton.vue b/frontend/src/views/sql-editor/EditorCommon/ResultView/RequestQueryButton.vue
index 6e662a98b1..74c62752cc 100644
--- a/frontend/src/views/sql-editor/EditorCommon/ResultView/RequestQueryButton.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/ResultView/RequestQueryButton.vue
@@ -56,9 +56,9 @@ const available = computed(() => {
return false;
}
- return hasProjectPermissionV2(
- database.value.projectEntity,
- "bb.issues.create"
+ return (
+ database.value.projectEntity.allowRequestRole &&
+ hasProjectPermissionV2(database.value.projectEntity, "bb.issues.create")
);
});
diff --git a/frontend/src/views/sql-editor/EditorPanel/EditorPanel.vue b/frontend/src/views/sql-editor/EditorPanel/EditorPanel.vue
index 7533828d2d..1b611d5385 100644
--- a/frontend/src/views/sql-editor/EditorPanel/EditorPanel.vue
+++ b/frontend/src/views/sql-editor/EditorPanel/EditorPanel.vue
@@ -24,7 +24,7 @@
<script setup lang="ts">
import { storeToRefs } from "pinia";
-import NoPermissionPlaceholder from "@/components/misc/NoPermissionPlaceholder.vue";
+import NoPermissionPlaceholder from "@/components/Permission/NoPermissionPlaceholder.vue";
import { useSQLEditorTabStore } from "@/store";
import Panels from "./Panels";
import StandardPanel from "./StandardPanel";
diff --git a/frontend/src/views/sql-editor/EditorPanel/ReadonlyModeNotSupported.vue b/frontend/src/views/sql-editor/EditorPanel/ReadonlyModeNotSupported.vue
index 35793869d7..a9ccde4b86 100644
--- a/frontend/src/views/sql-editor/EditorPanel/ReadonlyModeNotSupported.vue
+++ b/frontend/src/views/sql-editor/EditorPanel/ReadonlyModeNotSupported.vue
@@ -15,7 +15,7 @@
</template>
<script lang="ts" setup>
-import NoPermissionPlaceholder from "@/components/misc/NoPermissionPlaceholder.vue";
+import NoPermissionPlaceholder from "@/components/Permission/NoPermissionPlaceholder.vue";
import { InstanceV1Name } from "@/components/v2";
import { useConnectionOfCurrentSQLEditorTab } from "@/store";
import AdminModeButton from "../EditorCommon/AdminModeButton.vue";