Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor: remove issueByPipelineCache from store (#18519)

Danny Xuc7745801fc72
diff --git a/backend/store/issue.go b/backend/store/issue.go
index 26734dbf4e..1fb8651b2c 100644
--- a/backend/store/issue.go
+++ b/backend/store/issue.go
@@ -104,11 +104,6 @@ func (s *Store) GetIssue(ctx context.Context, find *FindIssueMessage) (*IssueMes
return v, nil
}
}
- if find.PipelineID != nil {
- if v, ok := s.issueByPipelineCache.Get(*find.PipelineID); ok && s.enableCache {
- return v, nil
- }
- }
issues, err := s.ListIssues(ctx, find)
if err != nil {
@@ -123,9 +118,6 @@ func (s *Store) GetIssue(ctx context.Context, find *FindIssueMessage) (*IssueMes
issue := issues[0]
s.issueCache.Add(issue.UID, issue)
- if issue.PipelineUID != nil {
- s.issueByPipelineCache.Add(*issue.PipelineUID, issue)
- }
return issue, nil
}
@@ -253,9 +245,6 @@ func (s *Store) UpdateIssue(ctx context.Context, uid int, patch *UpdateIssueMess
// Invalid the cache and read the value again.
s.issueCache.Remove(uid)
- if oldIssue.PipelineUID != nil {
- s.issueByPipelineCache.Remove(*oldIssue.PipelineUID)
- }
return s.GetIssue(ctx, &FindIssueMessage{UID: &uid})
}
@@ -467,9 +456,6 @@ func (s *Store) ListIssues(ctx context.Context, find *FindIssueMessage) ([]*Issu
issue.Project = project
s.issueCache.Add(issue.UID, issue)
- if issue.PipelineUID != nil {
- s.issueByPipelineCache.Add(*issue.PipelineUID, issue)
- }
}
return issues, nil
@@ -535,9 +521,6 @@ func (s *Store) BatchUpdateIssueStatuses(ctx context.Context, issueUIDs []int, s
// Invalidate caches
for _, info := range infos {
s.issueCache.Remove(info.id)
- if info.pipelineUID != nil {
- s.issueByPipelineCache.Remove(*info.pipelineUID)
- }
}
return nil
diff --git a/backend/store/principal.go b/backend/store/principal.go
index 0cc43d2609..597c7dbf7e 100644
--- a/backend/store/principal.go
+++ b/backend/store/principal.go
@@ -901,9 +901,6 @@ func (s *Store) UpdateUserEmail(ctx context.Context, user *UserMessage, newEmail
// Invalidate issue caches
for _, issue := range issuesToInvalidate {
s.issueCache.Remove(issue.id)
- if issue.pipelineUID != nil {
- s.issueByPipelineCache.Remove(*issue.pipelineUID)
- }
}
// Invalidate policy cache for updated policies
diff --git a/backend/store/store.go b/backend/store/store.go
index b57c02b005..6edcfe5684 100644
--- a/backend/store/store.go
+++ b/backend/store/store.go
@@ -18,19 +18,18 @@ type Store struct {
enableCache bool
// Cache.
- Secret string
- userEmailCache *lru.Cache[string, *UserMessage]
- instanceCache *lru.Cache[string, *InstanceMessage]
- databaseCache *lru.Cache[string, *DatabaseMessage]
- projectCache *lru.Cache[string, *ProjectMessage]
- policyCache *lru.Cache[string, *PolicyMessage]
- issueCache *lru.Cache[int, *IssueMessage]
- issueByPipelineCache *lru.Cache[int, *IssueMessage]
- pipelineCache *lru.Cache[int, *PipelineMessage]
- settingCache *lru.Cache[storepb.SettingName, *SettingMessage]
- rolesCache *lru.Cache[string, *RoleMessage]
- groupCache *lru.Cache[string, *GroupMessage]
- sheetMetadataCache *lru.Cache[int, *SheetMessage]
+ Secret string
+ userEmailCache *lru.Cache[string, *UserMessage]
+ instanceCache *lru.Cache[string, *InstanceMessage]
+ databaseCache *lru.Cache[string, *DatabaseMessage]
+ projectCache *lru.Cache[string, *ProjectMessage]
+ policyCache *lru.Cache[string, *PolicyMessage]
+ issueCache *lru.Cache[int, *IssueMessage]
+ pipelineCache *lru.Cache[int, *PipelineMessage]
+ settingCache *lru.Cache[storepb.SettingName, *SettingMessage]
+ rolesCache *lru.Cache[string, *RoleMessage]
+ groupCache *lru.Cache[string, *GroupMessage]
+ sheetMetadataCache *lru.Cache[int, *SheetMessage]
// Large objects.
sheetFullCache *lru.Cache[int, *SheetMessage]
@@ -64,10 +63,6 @@ func New(ctx context.Context, pgURL string, enableCache bool) (*Store, error) {
if err != nil {
return nil, err
}
- issueByPipelineCache, err := lru.New[int, *IssueMessage](256)
- if err != nil {
- return nil, err
- }
pipelineCache, err := lru.New[int, *PipelineMessage](256)
if err != nil {
return nil, err
@@ -108,20 +103,19 @@ func New(ctx context.Context, pgURL string, enableCache bool) (*Store, error) {
enableCache: enableCache,
// Cache.
- userEmailCache: userEmailCache,
- instanceCache: instanceCache,
- databaseCache: databaseCache,
- projectCache: projectCache,
- policyCache: policyCache,
- issueCache: issueCache,
- issueByPipelineCache: issueByPipelineCache,
- pipelineCache: pipelineCache,
- settingCache: settingCache,
- rolesCache: rolesCache,
- sheetMetadataCache: sheetMetadataCache,
- sheetFullCache: sheetFullCache,
- dbMetadataCache: dbMetadataCache,
- groupCache: groupCache,
+ userEmailCache: userEmailCache,
+ instanceCache: instanceCache,
+ databaseCache: databaseCache,
+ projectCache: projectCache,
+ policyCache: policyCache,
+ issueCache: issueCache,
+ pipelineCache: pipelineCache,
+ settingCache: settingCache,
+ rolesCache: rolesCache,
+ sheetMetadataCache: sheetMetadataCache,
+ sheetFullCache: sheetFullCache,
+ dbMetadataCache: dbMetadataCache,
+ groupCache: groupCache,
}
return s, nil