Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(frontend): migrate SQL Review pages to React (#19852)
Danny Xuca9786032855
diff --git a/frontend/eslint.config.mjs b/frontend/eslint.config.mjsindex 4a38f86840..ce505507b9 100644--- a/frontend/eslint.config.mjs+++ b/frontend/eslint.config.mjs@@ -40,6 +40,13 @@ export default ["project.batch.archive.success","project.batch.delete.title","project.batch.delete.success",+ "sql-review.select-review-rules",+ "sql-review.select-all",+ "sql-review.attach-resource.label-environment",+ "sql-review.attach-resource.label-project",+ "sql-review.attach-resource.override-warning",+ "sql-review.create.basic-info.display-name-placeholder",+ "sql-review.create.basic-info.choose-template",],enableFix: true,},diff --git a/frontend/src/components/SQLReview/SQLReviewConfig.vue b/frontend/src/components/SQLReview/SQLReviewConfig.vuedeleted file mode 100644index 3822ae4b24..0000000000--- a/frontend/src/components/SQLReview/SQLReviewConfig.vue+++ /dev/null@@ -1,75 +0,0 @@-<template>- <div v-if="ruleMapByEngine.size > 0">- <div class="flex justify-end">- <NButton type="primary" @click="showRuleSelectPanel = true">- {{ $t("sql-review.add-or-remove-rules") }}- </NButton>- </div>- <SQLReviewTabsByEngine :rule-map-by-engine="ruleMapByEngine">- <template- #default="{- ruleList: ruleListFilteredByEngine,- engine,- }: {- ruleList: RuleTemplateV2[];- engine: Engine;- }"- >- <SQLRuleTableWithFilter- :engine="engine"- :rule-list="ruleListFilteredByEngine"- :editable="true"- @rule-upsert="onRuleChange"- @rule-remove="$emit('rule-remove', $event)"- />- </template>- </SQLReviewTabsByEngine>- </div>- <NEmpty v-else class="py-12 border rounded-sm">- <template #extra>- <NButton type="primary" @click="showRuleSelectPanel = true">- {{ $t("sql-review.add-rules") }}- </NButton>- </template>- </NEmpty>- <SQLReviewRulesSelectPanel- :show="showRuleSelectPanel"- :selected-rule-map="ruleMapByEngine"- @close="showRuleSelectPanel = false"- @rule-select="$emit('rule-upsert', $event, {})"- @rule-remove="$emit('rule-remove', $event)"- />-</template>--<script lang="ts" setup>-import { NButton, NEmpty } from "naive-ui";-import { ref } from "vue";-import type { Engine } from "@/types/proto-es/v1/common_pb";-import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";-import type { RuleTemplateV2 } from "@/types/sqlReview";-import SQLReviewRulesSelectPanel from "./components/SQLReviewRulesSelectPanel.vue";-import SQLReviewTabsByEngine from "./components/SQLReviewTabsByEngine.vue";-import SQLRuleTableWithFilter from "./components/SQLRuleTableWithFilter.vue";--defineProps<{- ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;-}>();--const emit = defineEmits<{- (- event: "rule-upsert",- rule: RuleTemplateV2,- update: Partial<RuleTemplateV2>- ): void;- (event: "rule-remove", rule: RuleTemplateV2): void;-}>();--const onRuleChange = (- rule: RuleTemplateV2,- overrides: Partial<RuleTemplateV2>-) => {- emit("rule-upsert", rule, overrides);-};--const showRuleSelectPanel = ref<boolean>(false);-</script>diff --git a/frontend/src/components/SQLReview/SQLReviewCreation.vue b/frontend/src/components/SQLReview/SQLReviewCreation.vuedeleted file mode 100644index acf5c93450..0000000000--- a/frontend/src/components/SQLReview/SQLReviewCreation.vue+++ /dev/null@@ -1,314 +0,0 @@-<template>- <div class="w-full h-full flex flex-col">- <StepTab- :sticky="true"- :current-index="state.currentStep"- :step-list="STEP_LIST"- :allow-next="allowNext"- :finish-title="finishTitle"- class="flex-1 overflow-hidden flex flex-col"- pane-class="flex-1 overflow-y-auto"- @update:current-index="changeStepIndex"- @cancel="onCancel"- @finish="tryFinishSetup"- >- <template #0>- <SQLReviewInfo- :name="state.name"- :resource-id="state.resourceId"- :selected-template-id="- state.pendingApplyTemplate?.id ?? state.selectedTemplateId- "- :is-edit="!!policy"- :is-create="!isUpdate"- :allow-change-attached-resource="false"- @select-template="tryApplyTemplate"- @name-change="(val: string) => (state.name = val)"- @resource-id-change="(val: string) => (state.resourceId = val)"- @attached-resources-change="- (val: string[]) => (state.attachedResources = val)- "- />- </template>- <template #1>- <SQLReviewConfig- :rule-map-by-engine="state.selectedRuleMapByEngine"- @rule-upsert="upsertRule"- @rule-remove="removeRole"- />- </template>- </StepTab>- </div>-</template>--<script lang="ts" setup>-import { Code, ConnectError } from "@connectrpc/connect";-import { isEqual } from "lodash-es";-import { useDialog } from "naive-ui";-import { computed, reactive } from "vue";-import { useI18n } from "vue-i18n";-import { useRouter } from "vue-router";-import { StepTab } from "@/components/v2";-import {- WORKSPACE_ROUTE_SQL_REVIEW,- WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,-} from "@/router/dashboard/workspaceRoutes";-import { pushNotification, useSQLReviewStore } from "@/store";-import {- getReviewConfigId,- reviewConfigNamePrefix,-} from "@/store/modules/v1/common";-import type {- RuleTemplateV2,- SQLReviewPolicy,- SQLReviewPolicyTemplateV2,-} from "@/types";-import {- TEMPLATE_LIST_V2 as builtInTemplateList,- convertRuleMapToPolicyRuleList,- getRuleMapByEngine,- isBuiltinRule,- withBuiltinRules,-} from "@/types";-import { Engine } from "@/types/proto-es/v1/common_pb";-import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";-import { hasWorkspacePermissionV2, sqlReviewPolicySlug } from "@/utils";-import { getTemplateId } from "./components";-import SQLReviewConfig from "./SQLReviewConfig.vue";-import SQLReviewInfo from "./SQLReviewInfo.vue";--interface LocalState {- currentStep: number;- name: string;- resourceId: string;- attachedResources: string[];- selectedRuleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;- selectedTemplateId: string | undefined;- ruleUpdated: boolean;- pendingApplyTemplate: SQLReviewPolicyTemplateV2 | undefined;-}--const props = withDefaults(- defineProps<{- policy?: SQLReviewPolicy;- name?: string;- selectedResources?: string[];- selectedRuleList?: RuleTemplateV2[];- }>(),- {- policy: undefined,- name: "",- selectedResources: () => [],- selectedRuleList: () => [],- }-);--const emit = defineEmits(["cancel"]);--const dialog = useDialog();-const { t } = useI18n();-const router = useRouter();-const store = useSQLReviewStore();--const finishTitle = computed(() => {- if (props.policy) {- return t("common.confirm-and-update");- }- return t("common.confirm-and-add");-});--const BASIC_INFO_STEP = 0;-const CONFIGURE_RULE_STEP = 1;-const PREVIEW_STEP = 2;--const STEP_LIST = [- { title: t("sql-review.create.basic-info.name") },- { title: t("sql-review.create.configure-rule.name") },-];--const state = reactive<LocalState>({- currentStep: BASIC_INFO_STEP,- name: props.name || t("sql-review.create.basic-info.display-name-default"),- resourceId: props.policy ? getReviewConfigId(props.policy.id) : "",- attachedResources: props.selectedResources,- selectedRuleMapByEngine: withBuiltinRules(- getRuleMapByEngine(props.selectedRuleList)- ),- selectedTemplateId: props.policy- ? getTemplateId(props.policy)- : builtInTemplateList[0]?.id,- ruleUpdated: false,- pendingApplyTemplate: undefined,-});--const isUpdate = computed(() => !!props.policy);--const onTemplateApply = (template: SQLReviewPolicyTemplateV2 | undefined) => {- if (!template) {- return;- }- state.selectedTemplateId = template.id;- state.pendingApplyTemplate = undefined;-- state.selectedRuleMapByEngine = withBuiltinRules(- getRuleMapByEngine(template.ruleList)- );-};--const onCancel = (newPolicy: SQLReviewPolicy | undefined = undefined) => {- if (props.policy) {- emit("cancel");- } else {- if (newPolicy) {- router.push({- name: WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,- params: {- sqlReviewPolicySlug: sqlReviewPolicySlug(newPolicy),- },- query: {- attachResourcePanel: newPolicy.resources.length === 0 ? 1 : undefined,- },- });- } else {- router.push({- name: WORKSPACE_ROUTE_SQL_REVIEW,- });- }- }-};--const allowNext = computed((): boolean => {- switch (state.currentStep) {- case BASIC_INFO_STEP:- return !!state.name && !!state.resourceId;- case CONFIGURE_RULE_STEP:- return state.selectedRuleMapByEngine.size > 0;- case PREVIEW_STEP:- return true;- }- return false;-});--const changeStepIndex = (nextIndex: number) => {- if (state.currentStep === 0 && nextIndex === 1) {- if (state.pendingApplyTemplate) {- dialog.warning({- title: t("sql-review.create.configure-rule.confirm-override-title"),- content: t(- "sql-review.create.configure-rule.confirm-override-description"- ),- positiveText: t("common.confirm"),- onPositiveClick: (_: MouseEvent) => {- onTemplateApply(state.pendingApplyTemplate);- state.currentStep = nextIndex;- },- });- return;- }- }- state.currentStep = nextIndex;-};--const tryFinishSetup = async () => {- if (- !hasWorkspacePermissionV2(- isUpdate.value ? "bb.reviewConfigs.update" : "bb.reviewConfigs.create"- )- ) {- pushNotification({- module: "bytebase",- style: "CRITICAL",- title: t("sql-review.no-permission"),- });- }-- try {- const policy = await store.upsertReviewPolicy({- title: state.name,- ruleList: convertRuleMapToPolicyRuleList(state.selectedRuleMapByEngine),- resources: isEqual(props.selectedResources, state.attachedResources)- ? undefined- : state.attachedResources,- id: `${reviewConfigNamePrefix}${state.resourceId}`,- enforce: isUpdate.value ? undefined : true,- });- pushNotification({- module: "bytebase",- style: "SUCCESS",- title: isUpdate.value- ? t("sql-review.policy-updated")- : t("sql-review.policy-created"),- });- onCancel(policy);- } catch (error) {- if (error instanceof ConnectError && error.code === Code.AlreadyExists) {- pushNotification({- module: "bytebase",- style: "CRITICAL",- title: error.message,- });- } else {- pushNotification({- module: "bytebase",- style: "CRITICAL",- title: isUpdate.value- ? t("sql-review.policy-update-failed")- : t("sql-review.policy-create-failed"),- });- }- }-};--const tryApplyTemplate = (template: SQLReviewPolicyTemplateV2) => {- if (state.ruleUpdated || props.policy) {- if (template.id === state.selectedTemplateId) {- state.pendingApplyTemplate = undefined;- return;- }- state.pendingApplyTemplate = template;- return;- }- onTemplateApply(template);-};--const removeRole = (rule: RuleTemplateV2) => {- if (isBuiltinRule(rule)) {- return;- }- state.selectedRuleMapByEngine.get(rule.engine)?.delete(rule.type);- if (state.selectedRuleMapByEngine.get(rule.engine)?.size === 0) {- state.selectedRuleMapByEngine.delete(rule.engine);- }-};--const upsertRule = (- rule: RuleTemplateV2,- overrides: Partial<RuleTemplateV2>-) => {- if (!state.selectedRuleMapByEngine.has(rule.engine)) {- state.selectedRuleMapByEngine.set(- rule.engine,- new Map<SQLReviewRule_Type, RuleTemplateV2>()- );- }-- const selectedRule = state.selectedRuleMapByEngine- .get(rule.engine)- ?.get(rule.type);- if (!selectedRule) {- // Adding a new rule - use the rule's level from the template- state.selectedRuleMapByEngine.get(rule.engine)?.set(rule.type, {- ...rule,- ...overrides,- });- state.ruleUpdated = true;- return;- }- // Updating existing rule with overrides- state.selectedRuleMapByEngine- .get(rule.engine)- ?.set(rule.type, Object.assign(selectedRule, overrides));-- state.ruleUpdated = true;-};-</script>diff --git a/frontend/src/components/SQLReview/SQLReviewInfo.vue b/frontend/src/components/SQLReview/SQLReviewInfo.vuedeleted file mode 100644index 5c60206deb..0000000000--- a/frontend/src/components/SQLReview/SQLReviewInfo.vue+++ /dev/null@@ -1,180 +0,0 @@-<template>- <div class="flex flex-col gap-y-6">- <div v-if="attachedResources.length > 0">- <label class="textlabel">- {{ $t("sql-review.attach-resource.self") }}- <span style="color: red">*</span>- </label>- <p class="mt-1 textinfolabel">- {{ $t("sql-review.attach-resource.label") }}- </p>- <NRadioGroup- v-model:value="resourceType"- :disabled="!allowChangeAttachedResource"- class="flex gap-x-2 mt-2"- >- <NRadio value="environment">{{ $t("common.environment") }}</NRadio>- <NRadio value="project">{{ $t("common.project") }}</NRadio>- </NRadioGroup>- <BBAttention type="info" class="my-2">- {{ $t(`sql-review.attach-resource.label-${resourceType}`) }}- </BBAttention>- <EnvironmentSelect- v-if="resourceType === 'environment'"- class="mt-2"- required- name="environment"- :value="attachedResources[0]"- :disabled="!allowChangeAttachedResource"- :filter="- (env: Environment) =>- filterResource(formatEnvironmentName(env.id))- "- @update:value="- (val) => {- const name = val as string- if (!name) {- $emit('attached-resources-change', []);- } else {- $emit('attached-resources-change', [name]);- }- }- "- />- <ProjectSelect- v-if="resourceType === 'project'"- class="mt-2"- style="width: 100%"- required- :value="attachedResources[0]"- :disabled="!allowChangeAttachedResource"- :filter="(proj) => filterResource(proj.name)"- @update:value="- (val) => {- const name = val as string- if (!val) {- $emit('attached-resources-change', []);- } else {- $emit('attached-resources-change', [name]);- }- }- "- />- <DatabaseSelect- v-if="resourceType === 'database'"- class="mt-2"- style="width: 100%"- required- :value="attachedResources[0]"- :disabled="!allowChangeAttachedResource"- :filter="(db: Database) => filterResource(db.name)"- @update:value="(val) => {- const name = val as string- if (!name) {- $emit('attached-resources-change', []);- } else {- $emit('attached-resources-change', [name]);- }- }"- />- </div>- <div>- <label class="textlabel">- {{ $t("sql-review.create.basic-info.display-name") }}- <span style="color: red">*</span>- </label>- <p class="mt-1 textinfolabel">- {{ $t("sql-review.create.basic-info.display-name-label") }}- </p>- <BBTextField- class="mt-2 w-full"- :placeholder="- $t('sql-review.create.basic-info.display-name-placeholder')- "- :value="name"- @update:value="emit('name-change', $event)"- />- <ResourceIdField- class="mt-1"- editing-class="mt-6"- resource-type="review-config"- :value="resourceId"- :readonly="!isCreate"- :resource-title="name"- :suffix="true"- :fetch-resource="- (id) =>- sqlReviewStore.fetchReviewPolicyByName({- name: `${reviewConfigNamePrefix}${id}`,- silent: true,- })- "- @update:value="emit('resource-id-change', $event)"- />- </div>- <div>- <SQLReviewTemplateSelector- :required="true"- :selected-template-id="selectedTemplateId"- @select-template="$emit('select-template', $event)"- />- </div>- </div>-</template>--<script lang="ts" setup>-import { NRadio, NRadioGroup } from "naive-ui";-import { computed, watch } from "vue";-import { BBAttention, BBTextField } from "@/bbkit";-import ResourceIdField from "@/components/v2/Form/ResourceIdField.vue";-import { useResourceByName } from "@/components/v2/ResourceOccupiedModal/useResourceByName";-import { useSQLReviewStore } from "@/store";-import { reviewConfigNamePrefix } from "@/store/modules/v1/common";-import type { SQLReviewPolicyTemplateV2 } from "@/types";-import type { Database } from "@/types/proto-es/v1/database_service_pb";-import {- type Environment,- formatEnvironmentName,-} from "@/types/v1/environment";-import { DatabaseSelect, EnvironmentSelect, ProjectSelect } from "../v2";-import { SQLReviewTemplateSelector } from "./components";--const props = withDefaults(- defineProps<{- name: string;- resourceId: string;- attachedResources?: string[];- isCreate: boolean;- selectedTemplateId?: string;- isEdit: boolean;- allowChangeAttachedResource: boolean;- }>(),- {- attachedResources: () => [],- }-);--const emit = defineEmits<{- (event: "name-change", name: string): void;- (event: "resource-id-change", resourceId: string): void;- (event: "attached-resources-change", resourceId: string[]): void;- (event: "select-template", template: SQLReviewPolicyTemplateV2): void;-}>();--const sqlReviewStore = useSQLReviewStore();-const { resourceType } = useResourceByName({- resource: computed(() => props.attachedResources[0] ?? ""),-});--watch(- () => resourceType.value,- () => emit("attached-resources-change", [])-);--const filterResource = (name: string): boolean => {- if (!props.allowChangeAttachedResource) {- return true;- }- return !sqlReviewStore.getReviewPolicyByResouce(name);-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewAttachResourcesPanel.vue b/frontend/src/components/SQLReview/components/SQLReviewAttachResourcesPanel.vuedeleted file mode 100644index 3da64b143f..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewAttachResourcesPanel.vue+++ /dev/null@@ -1,209 +0,0 @@-<template>- <Drawer :show="show" @close="$emit('close')">- <DrawerContent- :title="$t('sql-review.attach-resource.self')"- class="w-[40rem] max-w-[100vw] relative"- >- <template #default>- <div class="flex flex-col gap-y-6">- <p class="textinfolabel">- {{ $t("sql-review.attach-resource.label") }}- </p>- <div>- <div class="textlabel mb-1">- {{ $t("common.environment") }}- </div>- <p class="textinfolabel">- {{ $t("sql-review.attach-resource.label-environment") }}- </p>- <EnvironmentSelect- class="mt-3"- required- :value="environmentNames"- :multiple="true"- :render-suffix="getResourceAttachedConfigName"- @update:value="- onResourcesChange($event as string[], projectNames)- "- />- </div>- <div class="flex items-center gap-x-2">- <div class="textlabel w-10 capitalize">{{ $t("common.or") }}</div>- <NDivider />- </div>- <div>- <div class="textlabel mb-1">- {{ $t("common.project") }}- </div>- <p class="textinfolabel">- {{ $t("sql-review.attach-resource.label-project") }}- </p>- <ProjectSelect- class="mt-3"- style="width: 100%"- required- :value="projectNames"- :multiple="true"- :render-suffix="getResourceAttachedConfigName"- @update:value="- onResourcesChange($event as string[], environmentNames)- "- />- </div>- </div>- </template>- <template #footer>- <div class="flex items-center justify-end gap-x-3">- <NButton @click="$emit('close')">- {{ $t("common.cancel") }}- </NButton>- <NButton :disabled="!hasPermission" type="primary" @click="onConfirm">- {{ $t("common.confirm") }}- </NButton>- </div>- </template>- </DrawerContent>- </Drawer>-- <ResourceOccupiedModal- ref="resourceOccupiedModalRef"- :target="review.name"- :description="- $t('sql-review.attach-resource.override-warning', {- button: t('common.continue-anyway'),- })- "- :resources="resourcesOccupied"- :show-positive-button="true"- @on-submit="onSubmit"- />-</template>--<script setup lang="tsx">-import { cloneDeep } from "lodash-es";-import { NButton, NDivider } from "naive-ui";-import { computed, ref, watch } from "vue";-import { useI18n } from "vue-i18n";-import {- Drawer,- DrawerContent,- EnvironmentSelect,- ProjectSelect,-} from "@/components/v2";-import ResourceOccupiedModal from "@/components/v2/ResourceOccupiedModal/ResourceOccupiedModal.vue";-import { pushNotification, useSQLReviewStore } from "@/store";-import {- environmentNamePrefix,- projectNamePrefix,-} from "@/store/modules/v1/common";-import type { SQLReviewPolicy } from "@/types";-import { hasWorkspacePermissionV2 } from "@/utils";--const props = defineProps<{- show: boolean;- review: SQLReviewPolicy;-}>();--const emit = defineEmits<{- (event: "close"): void;-}>();--const resources = ref<string[]>([]);-const sqlReviewStore = useSQLReviewStore();-const { t } = useI18n();-const resourceOccupiedModalRef =- ref<InstanceType<typeof ResourceOccupiedModal>>();--watch(- () => props.review.resources,- () => {- resources.value = [...props.review.resources];- },- { immediate: true, deep: true }-);--const hasPermission = computed(() => {- return hasWorkspacePermissionV2("bb.policies.update");-});--const environmentNames = computed(() =>- resources.value.filter((resource) =>- resource.startsWith(environmentNamePrefix)- )-);--const projectNames = computed(() =>- resources.value.filter((resource) => resource.startsWith(projectNamePrefix))-);--const onResourcesChange = (- newResources: string[],- otherResources: string[]-) => {- resources.value = [...newResources, ...otherResources];-};--const resourcesBindingWithOtherPolicy = computed(() => {- const map = new Map<string, string[]>();- for (const resource of resources.value) {- const config = sqlReviewStore.getReviewPolicyByResouce(resource);- if (config && config.id !== props.review.id) {- if (!map.has(config.id)) {- map.set(config.id, []);- }- map.get(config.id)?.push(resource);- }- }- return map;-});--const resourcesOccupied = computed(() =>- [...resourcesBindingWithOtherPolicy.value.values()].reduce(- (list, resources) => {- list.push(...resources);- return list;- },- []- )-);--const onConfirm = async () => {- if (resourcesOccupied.value.length === 0) {- await upsertReviewResource();- } else {- resourceOccupiedModalRef.value?.open();- }-};--const onSubmit = () => {- const map = cloneDeep(resourcesBindingWithOtherPolicy.value);- upsertReviewResource().then(() => {- sqlReviewStore.removeResourceForReview(map);- });-};--const upsertReviewResource = async () => {- await sqlReviewStore.upsertReviewConfigTag({- oldResources: props.review.resources,- newResources: resources.value,- review: props.review.id,- });- pushNotification({- module: "bytebase",- style: "SUCCESS",- title: t("sql-review.policy-updated"),- });- emit("close");-};--const getResourceAttachedConfigName = ({- name: resource,-}: {- name: string;-}) => {- const config = sqlReviewStore.getReviewPolicyByResouce(resource)?.name;- return config ? (- <span class="opacity-60 textinfolabel">{`(${config})`}</span>- ) : null;-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewCategoryTabFilter.vue b/frontend/src/components/SQLReview/components/SQLReviewCategoryTabFilter.vuedeleted file mode 100644index 88f0cd65b9..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewCategoryTabFilter.vue+++ /dev/null@@ -1,75 +0,0 @@-<template>- <NTabs- :value="value"- :size="'small'"- :type="tabType"- @update:value="$emit('update:value', $event)"- >- <NTabPane v-for="data in tabItemList" :key="data.value" :name="data.value">- <template #tab>- {{ data.label }}- </template>- <template #default>- <slot- :rule-list="data.value === 'all' ? tabItemList.slice(1) : [data]"- />- </template>- </NTabPane>- </NTabs>-</template>--<script lang="ts" setup>-import { useWindowSize } from "@vueuse/core";-import { NTabPane, NTabs } from "naive-ui";-import { computed } from "vue";-import { useI18n } from "vue-i18n";-import type { RuleTemplateV2 } from "@/types";-import { convertToCategoryMap } from "@/types";--export interface RuleListWithCategory {- value: string;- label: string;- ruleList: RuleTemplateV2[];-}--const props = defineProps<{- value: string;- ruleList: RuleTemplateV2[];-}>();--defineEmits<{- (event: "update:value", value: string): void;-}>();--const { t } = useI18n();--const { width: winWidth } = useWindowSize();--const tabType = computed(() => {- if (winWidth.value >= 1000) {- return "segment";- }- return "line";-});--const tabItemList = computed(() => {- const list: RuleListWithCategory[] = [- {- value: "all",- label: t("common.all"),- ruleList: [],- },- ];-- for (const [category, ruleList] of convertToCategoryMap(- props.ruleList- ).entries()) {- list.push({- value: category,- label: t(`sql-review.category.${category.toLowerCase()}`),- ruleList: ruleList,- });- }- return list;-});-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewLevelFilter.vue b/frontend/src/components/SQLReview/components/SQLReviewLevelFilter.vuedeleted file mode 100644index 6b2b5874dd..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewLevelFilter.vue+++ /dev/null@@ -1,80 +0,0 @@-<template>- <div- class="flex flex-col items-start 2xl:flex-row 2xl:items-center gap-y-5 gap-x-5"- >- <div class="flex items-center gap-x-5">- <label- v-for="[level, count] in errorLevelList.entries()"- :key="level"- class="flex items-center gap-x-2 text-sm text-gray-600"- >- <NCheckbox- :id="sqlReviewRuleLevelToString(level)"- :checked="isCheckedLevel(level)"- @update:checked="- (checked) => $emit('toggle-checked-level', level, checked)- "- >- <SQLRuleLevelBadge :level="level" :suffix="`(${count})`" />- </NCheckbox>- </label>- </div>- </div>-</template>--<script lang="ts" setup>-import { NCheckbox } from "naive-ui";-import { computed } from "vue";-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";-import type { RuleListWithCategory } from "./SQLReviewCategoryTabFilter.vue";-import SQLRuleLevelBadge from "./SQLRuleLevelBadge.vue";--const LEVEL_LIST = [SQLReviewRule_Level.ERROR, SQLReviewRule_Level.WARNING];--const props = withDefaults(- defineProps<{- ruleList: RuleListWithCategory[];- isCheckedLevel?: (level: SQLReviewRule_Level) => boolean;- }>(),- {- isCheckedLevel: () => false,- }-);--defineEmits<{- (- event: "toggle-checked-level",- level: SQLReviewRule_Level,- on: boolean- ): void;-}>();--const errorLevelList = computed(() => {- const map = LEVEL_LIST.reduce((m, level) => {- m.set(level, 0);- return m;- }, new Map<SQLReviewRule_Level, number>());-- for (const ruleWithCategory of props.ruleList) {- for (const rule of ruleWithCategory.ruleList) {- const count = map.get(rule.level) ?? 0;- map.set(rule.level, count + 1);- }- }- return map;-});--// Helper function to convert SQLReviewRule_Level to string-const sqlReviewRuleLevelToString = (level: SQLReviewRule_Level): string => {- switch (level) {- case SQLReviewRule_Level.LEVEL_UNSPECIFIED:- return "LEVEL_UNSPECIFIED";- case SQLReviewRule_Level.ERROR:- return "ERROR";- case SQLReviewRule_Level.WARNING:- return "WARNING";- default:- return "UNKNOWN";- }-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewPolicyTable.vue b/frontend/src/components/SQLReview/components/SQLReviewPolicyTable.vuedeleted file mode 100644index ffee847c2d..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewPolicyTable.vue+++ /dev/null@@ -1,113 +0,0 @@-<template>- <div>- <div class="hidden lg:grid">- <SQLReviewPolicyDataTable- :review-list="reviewList"- :filter="filter"- :allow-edit="true"- @edit="handleClickEdit"- @delete="handleClickDelete"- />- </div>-- <div- class="flex flex-col lg:hidden border px-2 divide-y divide-block-border"- >- <div- v-for="(review, i) in reviewList"- :key="`${i}-${review.id}`"- class="py-4"- >- <div class="text-md">- {{ review.name }}- </div>- <div class="flex flex-wrap mt-2 gap-2">- <NTag- v-for="resource in review.resources"- size="small"- type="primary"- :key="resource"- >- <Resource :show-prefix="true" :resource="resource" />- </NTag>- <NTag- v-if="!review.enforce"- type="warning"- >- {{ $t('common.disable') }}- </NTag>- </div>- <div class="flex items-center gap-x-2 mt-4">- <NButton size="small" @click.prevent="handleClickEdit(review)">- {{- hasUpdatePolicyPermission ? $t("common.edit") : $t("common.view")- }}- </NButton>-- <BBButtonConfirm- v-if="hasDeletePolicyPermission"- :text="false"- :disabled="!hasUpdatePolicyPermission"- :type="'DELETE'"- size="small"- :hide-icon="true"- :button-text="$t('common.delete')"- :ok-text="$t('common.delete')"- :confirm-title="$t('common.delete') + ` '${review.name}'?`"- :require-confirm="true"- @confirm="handleClickDelete(review)"- />- </div>- </div>- </div>- </div>-</template>--<script setup lang="tsx">-import { NButton, NTag } from "naive-ui";-import { computed } from "vue";-import { useI18n } from "vue-i18n";-import { useRouter } from "vue-router";-import { BBButtonConfirm } from "@/bbkit";-import Resource from "@/components/v2/ResourceOccupiedModal/Resource.vue";-import { WORKSPACE_ROUTE_SQL_REVIEW_DETAIL } from "@/router/dashboard/workspaceRoutes";-import { pushNotification, useSQLReviewStore } from "@/store";-import type { SQLReviewPolicy } from "@/types";-import { hasWorkspacePermissionV2, sqlReviewPolicySlug } from "@/utils";-import SQLReviewPolicyDataTable from "./SQLReviewPolicyDataTable.vue";--defineProps<{- reviewList: SQLReviewPolicy[];- filter: string;-}>();--const { t } = useI18n();-const router = useRouter();-const sqlReviewStore = useSQLReviewStore();--const hasUpdatePolicyPermission = computed(() => {- return hasWorkspacePermissionV2("bb.reviewConfigs.update");-});--const hasDeletePolicyPermission = computed(() => {- return hasWorkspacePermissionV2("bb.reviewConfigs.delete");-});--const handleClickEdit = (review: SQLReviewPolicy) => {- router.push({- name: WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,- params: {- sqlReviewPolicySlug: sqlReviewPolicySlug(review),- },- });-};--const handleClickDelete = async (review: SQLReviewPolicy) => {- await sqlReviewStore.removeReviewPolicy(review.id);- pushNotification({- module: "bytebase",- style: "SUCCESS",- title: t("sql-review.policy-removed"),- });-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vue b/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vuedeleted file mode 100644index b8020ffd59..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vue+++ /dev/null@@ -1,112 +0,0 @@-<template>- <Drawer :show="show" @close="$emit('close')">- <DrawerContent- :title="$t('sql-review.select-review-rules')"- class="w-280 max-w-[100vw] relative"- >- <template #default>- <SQLReviewTabsByEngine :rule-map-by-engine="ruleTemplateMapV2">- <template- #default="{- ruleList: ruleListFilteredByEngine,- engine,- }: {- ruleList: RuleTemplateV2[];- engine: Engine;- }"- >- <SQLRuleTableWithFilter- :engine="engine"- :rule-list="ruleListFilteredByEngine"- :editable="false"- :hide-level="true"- :support-select="true"- :size="'small'"- :selected-rule-keys="getSelectedRuleKeys(engine)"- @update:selected-rule-keys="- (keys: string[]) =>- onSelectedRuleKeysUpdateForEngine(engine, keys)- "- />- </template>- </SQLReviewTabsByEngine>- </template>- <template #footer>- <div class="flex items-center justify-end gap-x-3">- <NButton @click="$emit('close')">- {{ $t("common.close") }}- </NButton>- </div>- </template>- </DrawerContent>- </Drawer>-</template>--<script setup lang="ts">-import { NButton } from "naive-ui";-import { Drawer, DrawerContent } from "@/components/v2";-import { type Engine } from "@/types/proto-es/v1/common_pb";-import type { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";-import type { RuleTemplateV2 } from "@/types/sqlReview";-import { isBuiltinRule, ruleTemplateMapV2 } from "@/types/sqlReview";-import SQLReviewTabsByEngine from "./SQLReviewTabsByEngine.vue";-import SQLRuleTableWithFilter from "./SQLRuleTableWithFilter.vue";-import { getRuleKey } from "./utils";--const props = defineProps<{- show: boolean;- selectedRuleMap: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;-}>();--const emit = defineEmits<{- (event: "close"): void;- (event: "rule-select", rule: RuleTemplateV2): void;- (event: "rule-remove", rule: RuleTemplateV2): void;-}>();--const getSelectedRuleKeys = (engine: Engine) => {- const keys: string[] = [];- const map = props.selectedRuleMap.get(engine);- if (!map) {- return keys;- }- for (const rule of map.values()) {- keys.push(getRuleKey(rule));- }- return keys;-};--const onSelectedRuleKeysUpdateForEngine = (engine: Engine, keys: string[]) => {- const oldSelectedKeys = new Set(getSelectedRuleKeys(engine));- const newSelectedKeys = new Set(keys);-- for (const key of newSelectedKeys) {- if (oldSelectedKeys.has(key)) {- oldSelectedKeys.delete(key);- continue;- }- const [engineStr, ruleKey] = key.split(":");- const engineNum = parseInt(engineStr) as Engine;- const ruleType = parseInt(ruleKey) as SQLReviewRule_Type;- const rule = ruleTemplateMapV2.get(engineNum)?.get(ruleType);- if (rule) {- emit("rule-select", rule);- }- }-- // keys remained in the oldSelectedKeys is not selected.- for (const oldKey of oldSelectedKeys) {- const [engineStr, ruleKey] = oldKey.split(":");- const engineNum = parseInt(engineStr) as Engine;- const ruleType = parseInt(ruleKey) as SQLReviewRule_Type;- const template = ruleTemplateMapV2.get(engineNum)?.get(ruleType);- if (template && isBuiltinRule(template)) {- continue;- }- const rule = props.selectedRuleMap.get(engineNum)?.get(ruleType);- if (rule) {- emit("rule-remove", rule);- }- }-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vue b/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vuedeleted file mode 100644index e38bb8cbdc..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vue+++ /dev/null@@ -1,67 +0,0 @@-<template>- <NTabs v-model:value="selectedEngine" :type="'line'" :size="'large'">- <NTabPane- v-for="[engine, ruleMap] in sortedData"- :key="engine"- :name="engine"- >- <template #tab>- <div class="flex items-center gap-x-2">- <RichEngineName- :engine="engine"- tag="p"- class="text-center text-sm text-main!"- />- <span- class="items-center text-xs px-1 py-0.5 rounded-full bg-gray-200 text-gray-800"- >- {{ ruleMap.size }}- </span>- </div>- </template>- <template #default>- <slot :rule-list="[...ruleMap.values()]" :engine="selectedEngine" />- </template>- </NTabPane>- </NTabs>-</template>--<script setup lang="ts">-import { NTabPane, NTabs } from "naive-ui";-import { computed, ref, watch } from "vue";-import { RichEngineName } from "@/components/v2";-import type { RuleTemplateV2 } from "@/types";-import { Engine } from "@/types/proto-es/v1/common_pb";-import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";-import { supportedEngineV1List } from "@/utils";--const selectedEngine = ref<Engine>(0); // UNSPECIFIED--const props = defineProps<{- ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;-}>();--watch(- () => [...props.ruleMapByEngine.keys()][0] ?? 0, // UNSPECIFIED- (engine) => (selectedEngine.value = engine),- { immediate: true }-);--const engineWithOrderRank = computed(() => {- return supportedEngineV1List().reduce((map, engine, index) => {- map.set(engine, index);- return map;- }, new Map<Engine, number>());-});--const sortedData = computed(- (): [Engine, Map<SQLReviewRule_Type, RuleTemplateV2>][] => {- return [...props.ruleMapByEngine.entries()].sort(([e1], [e2]) => {- return (- (engineWithOrderRank.value.get(e1) ?? 0) -- (engineWithOrderRank.value.get(e2) ?? 0)- );- });- }-);-</script>diff --git a/frontend/src/components/SQLReview/components/SQLReviewTemplateSelector.vue b/frontend/src/components/SQLReview/components/SQLReviewTemplateSelector.vuedeleted file mode 100644index 1f04a74674..0000000000--- a/frontend/src/components/SQLReview/components/SQLReviewTemplateSelector.vue+++ /dev/null@@ -1,132 +0,0 @@-<template>- <div class="flex flex-col gap-y-2">- <p class="textlabel">- {{ $t("sql-review.create.basic-info.choose-template") }}- <span v-if="required" style="color: red">*</span>- </p>-- <div- class="flex flex-col sm:flex-row sm:flex-wrap justify-start items-stretch gap-x-4 gap-y-4"- >- <div- v-for="template in reviewPolicyTemplateList"- :key="template.id"- class="relative border border-gray-300 hover:bg-gray-100 rounded-lg px-6 py-4 transition-all w-full h-full sm:max-w-xs"- :class="- isSelectedTemplate(template)- ? 'bg-gray-100'- : 'bg-transparent cursor-pointer'- "- @click="$emit('select-template', template)"- >- <div class="text-left flex flex-col gap-y-2">- <span class="text-base font-medium">- {{ template.review.name }}- </span>- <div class="flex flex-wrap gap-2">- <NTag- v-for="resource in template.review.resources"- :key="resource"- type="primary"- >- <Resource :resource="resource" :show-prefix="true" />- </NTag>- </div>- <p class="text-sm">- <span class="mr-2">{{ $t("sql-review.enabled-rules") }}:</span>- <span>{{ enabledRuleCount(template) }}</span>- </p>- </div>- <heroicons-solid:check-circle- v-if="isSelectedTemplate(template)"- class="w-7 h-7 text-accent absolute top-3 right-3"- />- </div>- </div>-- <NDivider v-if="reviewPolicyTemplateList.length > 0" />-- <div- class="flex flex-col sm:flex-row sm:flex-wrap justify-start items-stretch gap-x-4 gap-y-4"- >- <div- v-for="template in builtInTemplateList"- :key="template.id"- class="relative border border-gray-300 hover:bg-gray-100 rounded-lg px-6 py-4 transition-all flex flex-col justify-center items-center w-full sm:max-w-xs"- :class="- isSelectedTemplate(template)- ? 'bg-gray-100'- : 'bg-transparent cursor-pointer'- "- @click="$emit('select-template', template)"- >- <div class="flex justify-center items-center gap-x-1">- <div class="text-left">- <span class="text-base font-medium">- {{- $t(`sql-review.template.${template.id.split(".").join("-")}`)- }}- </span>- <p class="mt-1 text-sm text-gray-500">- {{- $t(- `sql-review.template.${template.id.split(".").join("-")}-desc`- )- }}- </p>-- <p class="mt-1 text-xs">- <span class="mr-2">{{ $t("sql-review.enabled-rules") }}:</span>- <span>{{ enabledRuleCount(template) }}</span>- </p>- </div>- </div>- <heroicons-solid:check-circle- v-if="isSelectedTemplate(template)"- class="w-7 h-7 text-accent absolute top-3 right-3"- />- </div>- </div>- </div>-</template>--<script lang="ts" setup>-import { NDivider, NTag } from "naive-ui";-import { computed } from "vue";-import Resource from "@/components/v2/ResourceOccupiedModal/Resource.vue";-import { useSQLReviewPolicyList } from "@/store";-import type { SQLReviewPolicyTemplateV2 } from "@/types";-import { TEMPLATE_LIST_V2 as builtInTemplateList } from "@/types";-import { rulesToTemplate } from "./utils";--const props = withDefaults(- defineProps<{- title?: string;- required?: boolean;- selectedTemplateId?: string | undefined;- }>(),- {- title: "",- required: true,- selectedTemplateId: undefined,- }-);--defineEmits<{- (event: "select-template", template: SQLReviewPolicyTemplateV2): void;-}>();--const reviewPolicyList = useSQLReviewPolicyList();--const reviewPolicyTemplateList = computed(() => {- return reviewPolicyList.value.map((r) => rulesToTemplate(r));-});--const isSelectedTemplate = (template: SQLReviewPolicyTemplateV2) => {- return template.id === props.selectedTemplateId;-};--const enabledRuleCount = (template: SQLReviewPolicyTemplateV2) => {- return template.ruleList.length;-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLRuleFilter.vue b/frontend/src/components/SQLReview/components/SQLRuleFilter.vuedeleted file mode 100644index 47a602ecde..0000000000--- a/frontend/src/components/SQLReview/components/SQLRuleFilter.vue+++ /dev/null@@ -1,122 +0,0 @@-<template>- <div class="gap-y-3">- <SQLReviewCategoryTabFilter- :value="params.selectedCategory"- :rule-list="ruleList"- @update:value="$emit('change-category', $event)"- >- <template- #default="{- ruleList: ruleListFilteredByCategory,- }: {- ruleList: RuleListWithCategory[];- }"- >- <div- class="mt-2 flex flex-col justify-start items-start md:flex-row md:items-center md:justify-between"- >- <SQLReviewLevelFilter- v-if="!hideLevelFilter"- :rule-list="ruleListFilteredByCategory"- :is-checked-level="(level) => params.checkedLevel.has(level)"- @toggle-checked-level="$emit('toggle-checked-level', $event)"- />- <div v-if="supportSelect" class="flex items-center gap-x-2">- <NCheckbox- :checked="selectedRuleCount === ruleList.length"- :indeterminate="- selectedRuleCount > 0 && selectedRuleCount !== ruleList.length- "- @update:checked="$emit('toggle-select-all', $event)"- />- <span class="text-xl text-main font-medium">- {{ $t("sql-review.select-all") }}- </span>- </div>- <SearchBox- ref="searchField"- class="ml-auto mt-2 md:mt-0 md:max-w-72!"- style="max-width: 100%"- :value="params.searchText"- :placeholder="$t('common.filter-by-name')"- @update:value="$emit('change-search-text', $event)"- />- </div>- <NDivider />- <slot :rule-list="filterRuleList(ruleListFilteredByCategory)" />- </template>- </SQLReviewCategoryTabFilter>- </div>-</template>--<script lang="ts" setup>-import { NCheckbox, NDivider } from "naive-ui";-import { SearchBox } from "@/components/v2";-import type { RuleTemplateV2 } from "@/types";-import { getRuleLocalization, ruleTypeToString } from "@/types";-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";-import type { RuleListWithCategory } from "./SQLReviewCategoryTabFilter.vue";-import SQLReviewCategoryTabFilter from "./SQLReviewCategoryTabFilter.vue";-import SQLReviewLevelFilter from "./SQLReviewLevelFilter.vue";-import type { SQLRuleFilterParams } from "./useSQLRuleFilter";--const props = withDefaults(- defineProps<{- ruleList: RuleTemplateV2[];- params: SQLRuleFilterParams;- hideLevelFilter?: boolean;- supportSelect?: boolean;- selectedRuleCount?: number;- }>(),- {- hideLevelFilter: false,- supportSelect: false,- selectedRuleCount: 0,- }-);--defineEmits<{- (event: "toggle-checked-level", level: SQLReviewRule_Level): void;- (event: "toggle-select-all", select: boolean): void;- (event: "change-category", category: string): void;- (event: "change-search-text", keyword: string): void;-}>();--const filterRuleList = (- list: RuleListWithCategory[]-): RuleListWithCategory[] => {- if (props.params.checkedLevel.size === 0 && !props.params.searchText) {- return list;- }- return list- .map((item) => {- return {- ...item,- ruleList: item.ruleList.filter(filterRule),- };- })- .filter((item) => item.ruleList.length > 0);-};--const filterRule = (rule: RuleTemplateV2) => {- if (props.params.checkedLevel.size > 0) {- if (!props.params.checkedLevel.has(rule.level)) {- return false;- }- }- return filterRuleByKeyword(rule, props.params.searchText);-};--const filterRuleByKeyword = (rule: RuleTemplateV2, searchText: string) => {- const keyword = searchText.trim().toLowerCase();- if (!keyword) return true;- if (ruleTypeToString(rule.type).toLowerCase().includes(keyword)) return true;- const localization = getRuleLocalization(- ruleTypeToString(rule.type),- rule.engine- );- if (localization.title.toLowerCase().includes(keyword)) return true;- if (localization.description.toLowerCase().includes(keyword)) return true;- return false;-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLRuleLevelBadge.vue b/frontend/src/components/SQLReview/components/SQLRuleLevelBadge.vuedeleted file mode 100644index 5a92b2d366..0000000000--- a/frontend/src/components/SQLReview/components/SQLRuleLevelBadge.vue+++ /dev/null@@ -1,63 +0,0 @@-<template>- <NTag- :type="style"- :size="'small'"- >- {{ text }}- </NTag>-</template>--<script lang="ts" setup>-import { NTag } from "naive-ui";-import { computed } from "vue";-import { useI18n } from "vue-i18n";-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";--const props = withDefaults(- defineProps<{- level: SQLReviewRule_Level;- suffix?: string;- }>(),- {- suffix: "",- }-);--const { t } = useI18n();--const style = computed(() => {- switch (props.level) {- case SQLReviewRule_Level.ERROR:- return "error";- case SQLReviewRule_Level.WARNING:- return "warning";- default:- return "default";- }-});--// Helper function to convert SQLReviewRule_Level to string-const sqlReviewRuleLevelToString = (level: SQLReviewRule_Level): string => {- switch (level) {- case SQLReviewRule_Level.LEVEL_UNSPECIFIED:- return "LEVEL_UNSPECIFIED";- case SQLReviewRule_Level.ERROR:- return "ERROR";- case SQLReviewRule_Level.WARNING:- return "WARNING";- default:- return "UNKNOWN";- }-};--const text = computed(() => {- const { level, suffix } = props;- const parts = [- t(`sql-review.level.${sqlReviewRuleLevelToString(level).toLowerCase()}`),- ];- if (suffix) {- parts.push(suffix);- }- return parts.join(" ");-});-</script>diff --git a/frontend/src/components/SQLReview/components/SQLRuleTable.vue b/frontend/src/components/SQLReview/components/SQLRuleTable.vuedeleted file mode 100644index d67448c1c0..0000000000--- a/frontend/src/components/SQLReview/components/SQLRuleTable.vue+++ /dev/null@@ -1,308 +0,0 @@-<template>- <div>- <template v-for="category in ruleList" :key="category.value">- <div class="flex my-3 items-center">- <span class="text-xl text-main font-semibold">- {{ category.label }}- </span>- <span class="text-control-light text-md ml-1">- ({{ category.ruleList.length }})- </span>- </div>- <div class="hidden lg:block">- <NDataTable- key="sql-review-rule-table"- :size="size"- :striped="true"- :columns="columns"- :data="category.ruleList"- :row-key="getRuleKey"- :max-height="'100%'"- :virtual-scroll="true"- :bordered="true"- :default-expand-all="true"- :row-props="rowProps"- :checked-row-keys="selectedRuleKeys"- @update:checked-row-keys="- (val) => $emit('update:selectedRuleKeys', val as string[])- "- />- </div>- <div- class="flex flex-col lg:hidden border px-2 pb-4 divide-y divide-block-border"- >- <div- v-for="rule in category.ruleList"- :key="rule.type"- class="pt-4 flex flex-col gap-y-3"- >- <div class="flex justify-between items-center gap-x-2">- <div class="flex items-center gap-x-1">- <span>- {{ getRuleLocalization(ruleTypeToString(rule.type), rule.engine).title }}- <a- :href="`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`"- target="_blank"- class="inline-block"- >- <ExternalLinkIcon class="w-4 h-4" />- </a>- </span>- </div>- <NCheckbox- v-if="supportSelect"- :checked="selectedRuleKeys.includes(getRuleKey(rule))"- @update:checked="(_) => toggleRule(rule)"- />- <div v-else class="flex items-center gap-x-2">- <PencilIcon- v-if="editable"- class="w-4 h-4 cursor-pointer hover:text-accent"- @click="setActiveRule(rule)"- />- <NButton- v-if="editable && !isBuiltinRule(rule)"- secondary- type="error"- size="small"- @click="$emit('rule-remove', rule)"- >- {{ $t("common.delete") }}- </NButton>- </div>- </div>- <RuleLevelSwitch- v-if="!hideLevel"- class="text-xs"- :level="rule.level"- :disabled="!editable"- @level-change="updateLevel(rule, $event)"- />- <p class="textinfolabel">- {{ getRuleLocalization(ruleTypeToString(rule.type), rule.engine).description }}- </p>- </div>- </div>- </template>-- <SQLRuleEditDialog- v-if="state.activeRule"- :rule="state.activeRule"- :disabled="!editable"- @cancel="state.activeRule = undefined"- @update:rule="onRuleChanged"- />- </div>-</template>--<script lang="tsx" setup>-import { ExternalLinkIcon, PencilIcon } from "lucide-vue-next";-import type { DataTableColumn } from "naive-ui";-import { NButton, NCheckbox, NDataTable, NDivider } from "naive-ui";-import { computed, reactive } from "vue";-import { useI18n } from "vue-i18n";-import type { RuleTemplateV2 } from "@/types";-import { getRuleLocalization, isBuiltinRule, ruleTypeToString } from "@/types";-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";-import RuleConfig from "./RuleConfigComponents/RuleConfig.vue";-import RuleLevelSwitch from "./RuleLevelSwitch.vue";-import type { RuleListWithCategory } from "./SQLReviewCategoryTabFilter.vue";-import SQLRuleEditDialog from "./SQLRuleEditDialog.vue";-import { getRuleKey } from "./utils";--type LocalState = {- activeRule: RuleTemplateV2 | undefined;-};--const props = withDefaults(- defineProps<{- ruleList?: RuleListWithCategory[];- editable: boolean;- supportSelect?: boolean;- hideLevel?: boolean;- selectedRuleKeys?: string[];- size?: "small" | "medium";- }>(),- {- ruleList: () => [],- editable: true,- supportSelect: false,- hideLevel: false,- selectedRuleKeys: () => [],- size: "medium",- }-);--const emit = defineEmits<{- (- event: "rule-upsert",- rule: RuleTemplateV2,- update: Partial<RuleTemplateV2>- ): void;- (event: "rule-remove", rule: RuleTemplateV2): void;- (event: "update:selectedRuleKeys", keys: string[]): void;-}>();--const { t } = useI18n();-const state = reactive<LocalState>({- activeRule: undefined,-});--const columns = computed(() => {- const columns: (DataTableColumn<RuleTemplateV2> & { hide?: boolean })[] = [- {- type: "selection",- cellProps: () => {- return {- onClick: (e: MouseEvent) => {- e.stopPropagation();- },- };- },- hide: !props.supportSelect,- },- {- type: "expand",- expandable: (rule: RuleTemplateV2) => {- return !!(- getRuleLocalization(ruleTypeToString(rule.type), rule.engine)- .description || rule.componentList.length > 0- );- },- renderExpand: (rule: RuleTemplateV2) => {- const comment = getRuleLocalization(- ruleTypeToString(rule.type),- rule.engine- ).description;- return (- <div class="px-10">- <p class="w-full text-left text-gray-500">{comment}</p>- {rule.componentList.length > 0 && !!comment && (- <NDivider class={"my-4!"} />- )}- {rule.componentList.length > 0 && (- <RuleConfig- disabled={true}- rule={rule}- size={"small"}- class={"mb-3"}- />- )}- </div>- );- },- cellProps: () => {- return {- onClick: (e: MouseEvent) => {- e.stopPropagation();- },- };- },- },- {- title: t("common.name"),- resizable: true,- key: "name",- render: (rule: RuleTemplateV2) => {- return (- <div class="flex items-center gap-x-2">- <span>- {- getRuleLocalization(ruleTypeToString(rule.type), rule.engine)- .title- }- </span>- <a- href={`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`}- target="_blank"- class="flex flex-row gap-x-2 items-center text-base text-gray-500 hover:text-gray-900"- >- <ExternalLinkIcon class="w-4 h-4" />- </a>- </div>- );- },- },- {- title: t("sql-review.level.name"),- hide: props.hideLevel,- key: "level",- render: (rule: RuleTemplateV2) => {- return (- <RuleLevelSwitch- level={rule.level}- disabled={!props.editable}- onLevel-change={(on) => updateLevel(rule, on)}- />- );- },- },- {- title: t("common.operations"),- hide: props.supportSelect,- key: "operations",- width: "12rem",- render: (rule: RuleTemplateV2) => {- return (- <div class="flex items-center gap-x-2">- <NButton onClick={() => setActiveRule(rule)}>- {props.editable ? t("common.edit") : t("common.view")}- </NButton>- {props.editable && !isBuiltinRule(rule) && (- <NButton- secondary- type="error"- onClick={() => emit("rule-remove", rule)}- >- {t("common.delete")}- </NButton>- )}- </div>- );- },- },- ];-- return columns.filter((item) => !item.hide);-});--const rowProps = (rule: RuleTemplateV2) => {- return {- style: props.supportSelect ? "cursor: pointer;" : "",- onClick: () => {- if (props.supportSelect) {- toggleRule(rule);- return;- }- },- };-};--const toggleRule = (rule: RuleTemplateV2) => {- const key = getRuleKey(rule);- const index = props.selectedRuleKeys.findIndex((k) => k === key);- if (index < 0) {- emit("update:selectedRuleKeys", [...props.selectedRuleKeys, key]);- } else {- emit("update:selectedRuleKeys", [- ...props.selectedRuleKeys.slice(0, index),- ...props.selectedRuleKeys.slice(index + 1),- ]);- }-};--const setActiveRule = (rule: RuleTemplateV2) => {- state.activeRule = rule;-};--const onRuleChanged = (update: Partial<RuleTemplateV2>) => {- if (!state.activeRule) {- return;- }- emit("rule-upsert", state.activeRule, update);-};--const updateLevel = (rule: RuleTemplateV2, level: SQLReviewRule_Level) => {- emit("rule-upsert", rule, { level });-};-</script>diff --git a/frontend/src/components/SQLReview/components/SQLRuleTableWithFilter.vue b/frontend/src/components/SQLReview/components/SQLRuleTableWithFilter.vuedeleted file mode 100644index 61bc132ed9..0000000000--- a/frontend/src/components/SQLReview/components/SQLRuleTableWithFilter.vue+++ /dev/null@@ -1,97 +0,0 @@-<template>- <SQLRuleFilter- :rule-list="ruleList"- :selected-rule-count="selectedRuleKeys.length"- :params="filterParams"- :hide-level-filter="hideLevel"- :support-select="supportSelect"- @toggle-select-all="toggleSelectAll"- v-on="filterEvents"- >- <template- #default="{- ruleList: filteredRuleList,- }: {- ruleList: RuleListWithCategory[];- }"- >- <SQLRuleTable- v-if="filteredRuleList.length > 0"- :rule-list="filteredRuleList"- :editable="editable"- :hide-level="hideLevel"- :support-select="supportSelect"- :selected-rule-keys="selectedRuleKeys"- :size="size"- @rule-upsert="onRuleChange"- @rule-remove="$emit('rule-remove', $event)"- @update:selected-rule-keys="$emit('update:selectedRuleKeys', $event)"- />- <NEmpty v-else class="py-12 border rounded-sm" />- </template>- </SQLRuleFilter>-</template>--<script setup lang="ts">-import { NEmpty } from "naive-ui";-import { watch } from "vue";-import {- SQLRuleFilter,- SQLRuleTable,- useSQLRuleFilter,-} from "@/components/SQLReview/components";-import type { RuleTemplateV2 } from "@/types";-import type { Engine } from "@/types/proto-es/v1/common_pb";-import type { RuleListWithCategory } from "./SQLReviewCategoryTabFilter.vue";-import { getRuleKey } from "./utils";--const props = withDefaults(- defineProps<{- engine: Engine;- ruleList: RuleTemplateV2[];- editable: boolean;- hideLevel?: boolean;- supportSelect?: boolean;- selectedRuleKeys?: string[];- size?: "small" | "medium";- }>(),- {- supportSelect: false,- hideLevel: false,- selectedRuleKeys: () => [],- size: "medium",- }-);--const emit = defineEmits<{- (- event: "rule-upsert",- rule: RuleTemplateV2,- update: Partial<RuleTemplateV2>- ): void;- (event: "rule-remove", rule: RuleTemplateV2): void;- (event: "update:selectedRuleKeys", keys: string[]): void;-}>();--const { params: filterParams, events: filterEvents } = useSQLRuleFilter();--watch(- () => props.engine,- () => filterEvents.reset()-);--const toggleSelectAll = (select: boolean) => {- if (!select) {- emit("update:selectedRuleKeys", []);- } else {- emit("update:selectedRuleKeys", props.ruleList.map(getRuleKey));- }-};--const onRuleChange = (- rule: RuleTemplateV2,- update: Partial<RuleTemplateV2>-) => {- emit("rule-upsert", rule, update);-};-</script>diff --git a/frontend/src/components/SQLReview/components/index.ts b/frontend/src/components/SQLReview/components/index.tsindex 2456de9b66..9f685194e1 100644--- a/frontend/src/components/SQLReview/components/index.ts+++ b/frontend/src/components/SQLReview/components/index.ts@@ -1,15 +1,5 @@import SQLReviewForResource from "./SQLReviewForResource.vue";-import SQLReviewTemplateSelector from "./SQLReviewTemplateSelector.vue";import SQLRuleEditDialog from "./SQLRuleEditDialog.vue";-import SQLRuleFilter from "./SQLRuleFilter.vue";-import SQLRuleTable from "./SQLRuleTable.vue";-export {- SQLReviewTemplateSelector,- SQLRuleTable,- SQLRuleFilter,- SQLRuleEditDialog,- SQLReviewForResource,-};-export * from "./useSQLRuleFilter";+export { SQLRuleEditDialog, SQLReviewForResource };export * from "./utils";diff --git a/frontend/src/components/SQLReview/components/useSQLRuleFilter.ts b/frontend/src/components/SQLReview/components/useSQLRuleFilter.tsdeleted file mode 100644index fd9324a1a6..0000000000--- a/frontend/src/components/SQLReview/components/useSQLRuleFilter.ts+++ /dev/null@@ -1,40 +0,0 @@-import { reactive } from "vue";-import { useRoute } from "vue-router";-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";--export type SQLRuleFilterParams = {- checkedLevel: Set<SQLReviewRule_Level>;- selectedCategory: string;- searchText: string;-};--export const useSQLRuleFilter = () => {- const route = useRoute();- const params = reactive<SQLRuleFilterParams>({- checkedLevel: new Set([]),- selectedCategory: route.query.category- ? (route.query.category as string)- : "all",- searchText: "",- });- const events = {- toggleCheckedLevel(level: SQLReviewRule_Level) {- if (params.checkedLevel.has(level)) {- params.checkedLevel.delete(level);- } else {- params.checkedLevel.add(level);- }- },- changeCategory(category: string) {- params.selectedCategory = category;- },- changeSearchText(keyword: string) {- params.searchText = keyword;- },- reset() {- this.changeCategory("all");- params.checkedLevel = new Set([]);- },- };- return { params, events };-};diff --git a/frontend/src/components/SQLReview/index.ts b/frontend/src/components/SQLReview/index.tsindex 3b0284475c..40b494c5f8 100644--- a/frontend/src/components/SQLReview/index.ts+++ b/frontend/src/components/SQLReview/index.ts@@ -1,7 +1 @@-import SQLReviewConfig from "./SQLReviewConfig.vue";-import SQLReviewCreation from "./SQLReviewCreation.vue";-import SQLReviewInfo from "./SQLReviewInfo.vue";--export { SQLReviewConfig, SQLReviewInfo, SQLReviewCreation };-export * from "./components";diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex 90bf54d6a1..f113656422 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -2525,7 +2525,6 @@"configure-rule": {"name": "Configure rule","change-template": "Change the template",- "confirm-override-title": "Confirm change","confirm-override-description": "Your rules will be overridden"}},diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex ee7bba4d68..71f60ca248 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -2525,7 +2525,6 @@"configure-rule": {"name": "Configurar regla","change-template": "Cambiar plantilla",- "confirm-override-title": "Confirmar cambio","confirm-override-description": "Sus reglas serán anuladas"}},diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex e0b0a04596..caff9d6cc0 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -2525,7 +2525,6 @@"configure-rule": {"name": "ルールを設定する","change-template": "テンプレートの変更",- "confirm-override-title": "ルール変更","confirm-override-description": "以前のルールは上書きされます"}},diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex 707c79d7cc..634083b0f6 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -2525,7 +2525,6 @@"configure-rule": {"name": "Định cấu hình quy tắc","change-template": "Thay đổi mẫu",- "confirm-override-title": "Xác nhận thay đổi","confirm-override-description": "Quy tắc của bạn sẽ bị ghi đè"}},diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex 356118c57c..cc77e155d8 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -2510,7 +2510,7 @@"label": "审核策略需要绑定到环境资源或项目资源上,并影响对应资源下所有数据库。若一个数据库同时受到项目级别与环境级别策略影响,则只有项目级别策略生效。","label-environment": "SQL 审查策略将影响属于所选环境的所有数据库。","label-project": "SQL 审核策略将影响所选项目下的所有数据库。数据库所属环境的 SQL 审核策略将被忽略。",- "override-warning": "以下资源已与其他 SQL 审核策略绑定。点击“{button}”将覆盖配置。"+ "override-warning": "以下资源已与其他 SQL 审核策略绑定。点击\"{button}\"将覆盖配置。"},"create": {"breadcrumb": "创建审核策略",@@ -2525,7 +2525,6 @@"configure-rule": {"name": "配置规则","change-template": "更改模板",- "confirm-override-title": "规则变更","confirm-override-description": "之前的规则将会被覆盖"}},diff --git a/frontend/src/react/SQLReviewDetailPageMount.vue b/frontend/src/react/SQLReviewDetailPageMount.vuenew file mode 100644index 0000000000..fde86ce020--- /dev/null+++ b/frontend/src/react/SQLReviewDetailPageMount.vue@@ -0,0 +1,49 @@+<template>+ <div ref="container" class="h-full" />+</template>++<script lang="ts" setup>+import { onMounted, onUnmounted, ref, watch } from "vue";+import { useI18n } from "vue-i18n";++const props = defineProps<{+ sqlReviewPolicySlug: string;+}>();++const { locale } = useI18n();+const container = ref<HTMLElement>();+// biome-ignore lint/suspicious/noExplicitAny: React Root type from dynamic import+let root: any = null; // eslint-disable-line @typescript-eslint/no-explicit-any++async function render() {+ if (!container.value) return;+ const [{ mountReactPage, updateReactPage }, i18nModule] = await Promise.all([+ import("./mount"),+ import("./i18n"),+ ]);+ if (i18nModule.default.language !== locale.value) {+ await i18nModule.default.changeLanguage(locale.value);+ }+ const pageProps = { sqlReviewPolicySlug: props.sqlReviewPolicySlug };+ if (!root) {+ root = await mountReactPage(+ container.value,+ "SQLReviewDetailPage",+ pageProps+ );+ } else {+ await updateReactPage(root, "SQLReviewDetailPage", pageProps);+ }+}++onMounted(() => render());+watch(locale, () => render());+watch(+ () => props.sqlReviewPolicySlug,+ () => render()+);+onUnmounted(() => {+ root?.unmount();+ root = null;+});+</script>diff --git a/frontend/src/react/components/sql-review/Panels.tsx b/frontend/src/react/components/sql-review/Panels.tsxnew file mode 100644index 0000000000..908d33065c--- /dev/null+++ b/frontend/src/react/components/sql-review/Panels.tsx@@ -0,0 +1,385 @@+import { X } from "lucide-react";+import { useCallback, useEffect, useMemo, useState } from "react";+import { getRuleKey } from "@/components/SQLReview/components/utils";+import { t as vueT } from "@/plugins/i18n";+import { Alert, AlertDescription } from "@/react/components/ui/alert";+import { Button } from "@/react/components/ui/button";+import { useEscapeKey } from "@/react/hooks/useEscapeKey";+import { useVueState } from "@/react/hooks/useVueState";+import {+ pushNotification,+ useEnvironmentV1Store,+ useProjectV1Store,+ useSQLReviewStore,+} from "@/store";+import {+ environmentNamePrefix,+ projectNamePrefix,+} from "@/store/modules/v1/common";+import type { SQLReviewPolicy } from "@/types";+import type { Engine } from "@/types/proto-es/v1/common_pb";+import type { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";+import type { RuleTemplateV2 } from "@/types/sqlReview";+import { isBuiltinRule, ruleTemplateMapV2 } from "@/types/sqlReview";+import { hasWorkspacePermissionV2 } from "@/utils";+import { RuleTableWithFilter } from "./RuleTable";+import { TabsByEngine } from "./TabsByEngine";++// ---------------------------------------------------------------------------+// RulesSelectPanel+// ---------------------------------------------------------------------------++interface RulesSelectPanelProps {+ show: boolean;+ selectedRuleMap: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;+ onClose: () => void;+ onRuleSelect: (rule: RuleTemplateV2) => void;+ onRuleRemove: (rule: RuleTemplateV2) => void;+}++export function RulesSelectPanel({+ show,+ selectedRuleMap,+ onClose,+ onRuleSelect,+ onRuleRemove,+}: RulesSelectPanelProps) {+ useEscapeKey(show, onClose);++ const getSelectedRuleKeys = useCallback(+ (engine: Engine): string[] => {+ const map = selectedRuleMap.get(engine);+ if (!map) return [];+ const keys: string[] = [];+ for (const rule of map.values()) {+ keys.push(getRuleKey(rule));+ }+ return keys;+ },+ [selectedRuleMap]+ );++ const onSelectedRuleKeysUpdate = useCallback(+ (engine: Engine, keys: string[]) => {+ const oldKeys = new Set(getSelectedRuleKeys(engine));+ const newKeys = new Set(keys);++ for (const key of newKeys) {+ if (oldKeys.has(key)) {+ oldKeys.delete(key);+ continue;+ }+ const [engineStr, ruleKey] = key.split(":");+ const engineNum = parseInt(engineStr) as Engine;+ const ruleType = parseInt(ruleKey) as SQLReviewRule_Type;+ const rule = ruleTemplateMapV2.get(engineNum)?.get(ruleType);+ if (rule) {+ onRuleSelect(rule);+ }+ }++ // Remaining old keys were deselected+ for (const oldKey of oldKeys) {+ const [engineStr, ruleKey] = oldKey.split(":");+ const engineNum = parseInt(engineStr) as Engine;+ const ruleType = parseInt(ruleKey) as SQLReviewRule_Type;+ const template = ruleTemplateMapV2.get(engineNum)?.get(ruleType);+ if (template && isBuiltinRule(template)) {+ continue;+ }+ const rule = selectedRuleMap.get(engineNum)?.get(ruleType);+ if (rule) {+ onRuleRemove(rule);+ }+ }+ },+ [getSelectedRuleKeys, selectedRuleMap, onRuleSelect, onRuleRemove]+ );++ if (!show) return null;++ return (+ <div className="fixed inset-0 z-50 flex">+ <div className="fixed inset-0 bg-black/50" onClick={onClose} />+ <div className="ml-auto relative bg-white w-[70rem] max-w-[100vw] h-full shadow-lg flex flex-col">+ <div className="px-4 py-3 border-b flex items-center justify-between">+ <h2 className="text-lg font-medium">+ {vueT("sql-review.select-review-rules")}+ </h2>+ <Button variant="ghost" size="icon" onClick={onClose}>+ <X className="w-4 h-4" />+ </Button>+ </div>+ <div className="flex-1 overflow-y-auto p-4">+ <TabsByEngine ruleMapByEngine={ruleTemplateMapV2}>+ {(ruleList, engine) => (+ <RuleTableWithFilter+ engine={engine}+ ruleList={ruleList}+ editable={false}+ hideLevel+ supportSelect+ size="small"+ selectedRuleKeys={getSelectedRuleKeys(engine)}+ onSelectedRuleKeysChange={(keys) =>+ onSelectedRuleKeysUpdate(engine, keys)+ }+ />+ )}+ </TabsByEngine>+ </div>+ <div className="px-4 py-3 border-t flex justify-end gap-x-3">+ <Button variant="outline" onClick={onClose}>+ {vueT("common.close")}+ </Button>+ </div>+ </div>+ </div>+ );+}++// ---------------------------------------------------------------------------+// AttachResourcesPanel+// ---------------------------------------------------------------------------++interface AttachResourcesPanelProps {+ show: boolean;+ review: SQLReviewPolicy;+ onClose: () => void;+}++export function AttachResourcesPanel({+ show,+ review,+ onClose,+}: AttachResourcesPanelProps) {+ const sqlReviewStore = useSQLReviewStore();+ const envStore = useEnvironmentV1Store();+ const projStore = useProjectV1Store();++ const environments = useVueState(() => envStore.environmentList ?? []);+ const projects = useVueState(() => [...(projStore.getProjectList() ?? [])]);++ const [resources, setResources] = useState<string[]>([]);++ // Fetch projects on mount so the checkbox list is populated+ useEffect(() => {+ projStore.fetchProjectList({});+ }, [projStore]);++ useEffect(() => {+ setResources([...review.resources]);+ }, [review.resources]);++ useEscapeKey(show, onClose);++ const hasPermission = hasWorkspacePermissionV2("bb.policies.update");++ const environmentNames = useMemo(+ () => resources.filter((r) => r.startsWith(environmentNamePrefix)),+ [resources]+ );++ const projectNames = useMemo(+ () => resources.filter((r) => r.startsWith(projectNamePrefix)),+ [resources]+ );++ const toggleResource = (name: string) => {+ setResources((prev) =>+ prev.includes(name) ? prev.filter((r) => r !== name) : [...prev, name]+ );+ };++ const getResourceAttachedConfigName = (resource: string): string | null => {+ const config = sqlReviewStore.getReviewPolicyByResouce(resource);+ if (config && config.id !== review.id) {+ return config.name;+ }+ return null;+ };++ // Track resources that are bound to other policies (for cache cleanup)+ const resourcesBindingWithOtherPolicy = useMemo(() => {+ const map = new Map<string, string[]>();+ for (const resource of resources) {+ const config = sqlReviewStore.getReviewPolicyByResouce(resource);+ if (config && config.id !== review.id) {+ if (!map.has(config.id)) {+ map.set(config.id, []);+ }+ map.get(config.id)!.push(resource);+ }+ }+ return map;+ }, [resources, sqlReviewStore, review.id]);++ const conflictingResources = useMemo(() => {+ return [...resourcesBindingWithOtherPolicy.values()].flat();+ }, [resourcesBindingWithOtherPolicy]);++ const [showOverrideConfirm, setShowOverrideConfirm] = useState(false);++ const onConfirm = () => {+ if (conflictingResources.length > 0) {+ setShowOverrideConfirm(true);+ } else {+ doSave();+ }+ };++ const doSave = async () => {+ const conflictMap = new Map(resourcesBindingWithOtherPolicy);+ await sqlReviewStore.upsertReviewConfigTag({+ oldResources: review.resources,+ newResources: resources,+ review: review.id,+ });+ if (conflictMap.size > 0) {+ sqlReviewStore.removeResourceForReview(conflictMap);+ }+ setShowOverrideConfirm(false);+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: vueT("sql-review.policy-updated"),+ });+ onClose();+ };++ if (!show) return null;++ return (+ <div className="fixed inset-0 z-50 flex">+ <div className="fixed inset-0 bg-black/50" onClick={onClose} />+ <div className="ml-auto relative bg-white w-[40rem] max-w-[100vw] h-full shadow-lg flex flex-col">+ <div className="px-4 py-3 border-b flex items-center justify-between">+ <h2 className="text-lg font-medium">+ {vueT("sql-review.attach-resource.self")}+ </h2>+ <Button variant="ghost" size="icon" onClick={onClose}>+ <X className="w-4 h-4" />+ </Button>+ </div>++ <div className="flex-1 overflow-y-auto p-4">+ <div className="flex flex-col gap-y-6">+ <p className="textinfolabel">+ {vueT("sql-review.attach-resource.label")}+ </p>++ {/* Environment section */}+ <div>+ <div className="textlabel mb-1">{vueT("common.environment")}</div>+ <p className="textinfolabel">+ {vueT("sql-review.attach-resource.label-environment")}+ </p>+ <div className="mt-3 flex flex-col gap-y-2">+ {environments.map((env) => {+ const name = env.name;+ const checked = environmentNames.includes(name);+ const attachedConfig = getResourceAttachedConfigName(name);+ return (+ <label+ key={name}+ className="flex items-center gap-x-2 cursor-pointer"+ >+ <input+ type="checkbox"+ checked={checked}+ onChange={() => toggleResource(name)}+ className="accent-accent"+ />+ <span>{env.title || name}</span>+ {attachedConfig && (+ <span className="opacity-60 textinfolabel">+ ({attachedConfig})+ </span>+ )}+ </label>+ );+ })}+ </div>+ </div>++ {/* OR divider */}+ <div className="flex items-center gap-x-2">+ <div className="textlabel w-10 capitalize">+ {vueT("common.or")}+ </div>+ <hr className="flex-1 border-gray-200" />+ </div>++ {/* Project section */}+ <div>+ <div className="textlabel mb-1">{vueT("common.project")}</div>+ <p className="textinfolabel">+ {vueT("sql-review.attach-resource.label-project")}+ </p>+ <div className="mt-3 flex flex-col gap-y-2 max-h-60 overflow-y-auto">+ {projects.map((proj) => {+ const name = proj.name;+ const checked = projectNames.includes(name);+ const attachedConfig = getResourceAttachedConfigName(name);+ return (+ <label+ key={name}+ className="flex items-center gap-x-2 cursor-pointer"+ >+ <input+ type="checkbox"+ checked={checked}+ onChange={() => toggleResource(name)}+ className="accent-accent"+ />+ <span>{proj.title || name}</span>+ {attachedConfig && (+ <span className="opacity-60 textinfolabel">+ ({attachedConfig})+ </span>+ )}+ </label>+ );+ })}+ </div>+ </div>+ </div>+ </div>++ {showOverrideConfirm && conflictingResources.length > 0 && (+ <div className="px-4 py-3 border-t">+ <Alert variant="warning">+ <AlertDescription>+ <p className="mb-2">+ {vueT("sql-review.attach-resource.override-warning", {+ button: vueT("common.confirm"),+ })}+ </p>+ <ul className="list-disc list-inside text-sm">+ {conflictingResources.map((r) => (+ <li key={r}>{r}</li>+ ))}+ </ul>+ </AlertDescription>+ </Alert>+ </div>+ )}++ <div className="px-4 py-3 border-t flex justify-end gap-x-2">+ <Button variant="outline" onClick={onClose}>+ {vueT("common.cancel")}+ </Button>+ {showOverrideConfirm ? (+ <Button variant="destructive" onClick={doSave}>+ {vueT("common.confirm")}+ </Button>+ ) : (+ <Button disabled={!hasPermission} onClick={onConfirm}>+ {vueT("common.confirm")}+ </Button>+ )}+ </div>+ </div>+ </div>+ );+}diff --git a/frontend/src/react/components/sql-review/ResourceLink.tsx b/frontend/src/react/components/sql-review/ResourceLink.tsxnew file mode 100644index 0000000000..54d509a8a3--- /dev/null+++ b/frontend/src/react/components/sql-review/ResourceLink.tsx@@ -0,0 +1,69 @@+import { useEffect } from "react";+import { useTranslation } from "react-i18next";+import { EnvironmentLabel } from "@/react/components/EnvironmentLabel";+import { useVueState } from "@/react/hooks/useVueState";+import { router } from "@/router";+import { useProjectV1Store } from "@/store";+import {+ environmentNamePrefix,+ projectNamePrefix,+} from "@/store/modules/v1/common";+import { hasWorkspacePermissionV2 } from "@/utils";++export function ResourceLink({ resource }: { resource: string }) {+ if (resource.startsWith(environmentNamePrefix)) {+ return <EnvironmentResourceLink resource={resource} />;+ }+ if (resource.startsWith(projectNamePrefix)) {+ return <ProjectResourceLink resource={resource} />;+ }+ return <span>{resource}</span>;+}++function EnvironmentResourceLink({ resource }: { resource: string }) {+ const { t } = useTranslation();+ return (+ <a+ href={`/${resource}`}+ className="inline-flex items-center gap-x-1"+ onClick={(e) => {+ e.preventDefault();+ router.push({ path: `/${resource}` });+ }}+ >+ <span className="text-control-light text-xs mr-0.5">+ {t("common.environment")}:+ </span>+ <EnvironmentLabel environmentName={resource} />+ </a>+ );+}++function ProjectResourceLink({ resource }: { resource: string }) {+ const { t } = useTranslation();+ const projectStore = useProjectV1Store();++ useEffect(() => {+ if (hasWorkspacePermissionV2("bb.projects.get")) {+ projectStore.getOrFetchProjectByName(resource, true);+ }+ }, [projectStore, resource]);++ const project = useVueState(() => projectStore.getProjectByName(resource));++ return (+ <a+ href={`/${resource}`}+ className="inline-flex items-center gap-x-1 normal-link"+ onClick={(e) => {+ e.preventDefault();+ router.push({ path: `/${resource}` });+ }}+ >+ <span className="text-control-light text-xs mr-0.5">+ {t("common.project")}:+ </span>+ <span>{project?.title || resource}</span>+ </a>+ );+}diff --git a/frontend/src/react/components/sql-review/ReviewCreation.tsx b/frontend/src/react/components/sql-review/ReviewCreation.tsxnew file mode 100644index 0000000000..b46e383d9c--- /dev/null+++ b/frontend/src/react/components/sql-review/ReviewCreation.tsx@@ -0,0 +1,434 @@+import { Code, ConnectError } from "@connectrpc/connect";+import { isEqual } from "lodash-es";+import { Plus } from "lucide-react";+import { useCallback, useState } from "react";+import { useTranslation } from "react-i18next";+import { getTemplateId } from "@/components/SQLReview/components/utils";+import { ResourceIdField } from "@/react/components/ResourceIdField";+import { Button } from "@/react/components/ui/button";+import { Input } from "@/react/components/ui/input";+import { router } from "@/router";+import {+ WORKSPACE_ROUTE_SQL_REVIEW,+ WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,+} from "@/router/dashboard/workspaceRoutes";+import { pushNotification, useSQLReviewStore } from "@/store";+import {+ getReviewConfigId,+ reviewConfigNamePrefix,+} from "@/store/modules/v1/common";+import type {+ RuleTemplateV2,+ SQLReviewPolicy,+ SQLReviewPolicyTemplateV2,+} from "@/types";+import {+ TEMPLATE_LIST_V2 as builtInTemplateList,+ convertRuleMapToPolicyRuleList,+ getRuleMapByEngine,+ isBuiltinRule,+ withBuiltinRules,+} from "@/types";+import type { Engine } from "@/types/proto-es/v1/common_pb";+import type { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";+import { hasWorkspacePermissionV2, sqlReviewPolicySlug } from "@/utils";+import { RulesSelectPanel } from "./Panels";+import { RuleTableWithFilter } from "./RuleTable";+import { TabsByEngine } from "./TabsByEngine";+import { TemplateSelector } from "./TemplateSelector";++interface ReviewCreationProps {+ policy?: SQLReviewPolicy;+ name?: string;+ selectedResources?: string[];+ selectedRuleList?: RuleTemplateV2[];+ onCancel?: () => void;+}++const STEP_BASIC_INFO = 0;+const STEP_CONFIGURE_RULES = 1;++export function ReviewCreation({+ policy,+ name: initialName,+ selectedResources = [],+ selectedRuleList = [],+ onCancel,+}: ReviewCreationProps) {+ const { t } = useTranslation();+ const store = useSQLReviewStore();++ const [currentStep, setCurrentStep] = useState(STEP_BASIC_INFO);+ const [policyName, setPolicyName] = useState(+ initialName || t("sql-review.create.basic-info.display-name-default")+ );+ const [resourceId, setResourceId] = useState(+ policy ? getReviewConfigId(policy.id) : ""+ );+ const [attachedResources, _setAttachedResources] =+ useState<string[]>(selectedResources);+ const [ruleMapByEngine, setRuleMapByEngine] = useState(+ () =>+ withBuiltinRules(getRuleMapByEngine(selectedRuleList)) as Map<+ Engine,+ Map<SQLReviewRule_Type, RuleTemplateV2>+ >+ );+ const [selectedTemplateId, setSelectedTemplateId] = useState<+ string | undefined+ >(policy ? getTemplateId(policy) : builtInTemplateList[0]?.id);+ const [ruleUpdated, setRuleUpdated] = useState(false);+ const [pendingApplyTemplate, setPendingApplyTemplate] = useState<+ SQLReviewPolicyTemplateV2 | undefined+ >();+ const [showRuleSelectPanel, setShowRuleSelectPanel] = useState(false);++ const isUpdate = !!policy;++ const finishTitle = isUpdate+ ? t("common.confirm-and-update")+ : t("common.confirm-and-add");++ const allowNext =+ currentStep === STEP_BASIC_INFO+ ? !!policyName && !!resourceId+ : ruleMapByEngine.size > 0;++ // --- Template logic ---++ const applyTemplate = useCallback((template: SQLReviewPolicyTemplateV2) => {+ setSelectedTemplateId(template.id);+ setPendingApplyTemplate(undefined);+ setRuleMapByEngine(+ withBuiltinRules(getRuleMapByEngine(template.ruleList)) as Map<+ Engine,+ Map<SQLReviewRule_Type, RuleTemplateV2>+ >+ );+ }, []);++ const tryApplyTemplate = useCallback(+ (template: SQLReviewPolicyTemplateV2) => {+ if (ruleUpdated || policy) {+ if (template.id === selectedTemplateId) {+ setPendingApplyTemplate(undefined);+ return;+ }+ setPendingApplyTemplate(template);+ return;+ }+ applyTemplate(template);+ },+ [ruleUpdated, policy, selectedTemplateId, applyTemplate]+ );++ // --- Rule upsert / remove ---++ const upsertRule = useCallback(+ (rule: RuleTemplateV2, overrides: Partial<RuleTemplateV2>) => {+ setRuleMapByEngine((prev) => {+ const newMap = new Map(prev);+ if (!newMap.has(rule.engine)) {+ newMap.set(+ rule.engine,+ new Map<SQLReviewRule_Type, RuleTemplateV2>()+ );+ }+ const engineMap = new Map(newMap.get(rule.engine)!);+ engineMap.set(rule.type, {+ ...(engineMap.get(rule.type) || rule),+ ...overrides,+ });+ newMap.set(rule.engine, engineMap);+ return newMap;+ });+ setRuleUpdated(true);+ },+ []+ );++ const removeRule = useCallback((rule: RuleTemplateV2) => {+ if (isBuiltinRule(rule)) return;+ setRuleMapByEngine((prev) => {+ const newMap = new Map(prev);+ const engineMap = new Map(newMap.get(rule.engine) || new Map());+ engineMap.delete(rule.type);+ if (engineMap.size === 0) {+ newMap.delete(rule.engine);+ } else {+ newMap.set(rule.engine, engineMap);+ }+ return newMap;+ });+ setRuleUpdated(true);+ }, []);++ // --- Step navigation ---++ const changeStep = (nextIndex: number) => {+ if (currentStep === STEP_BASIC_INFO && nextIndex === STEP_CONFIGURE_RULES) {+ if (pendingApplyTemplate) {+ if (+ window.confirm(+ t("sql-review.create.configure-rule.confirm-override-description")+ )+ ) {+ applyTemplate(pendingApplyTemplate);+ } else {+ return; // Stay on basic info step when override is canceled+ }+ }+ }+ setCurrentStep(nextIndex);+ };++ const handleCancel = (newPolicy?: SQLReviewPolicy) => {+ if (onCancel) {+ onCancel();+ } else if (newPolicy) {+ router.push({+ name: WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,+ params: {+ sqlReviewPolicySlug: sqlReviewPolicySlug(newPolicy),+ },+ query:+ newPolicy.resources.length === 0+ ? { attachResourcePanel: 1 }+ : undefined,+ });+ } else {+ router.push({ name: WORKSPACE_ROUTE_SQL_REVIEW });+ }+ };++ // --- Finish ---++ const tryFinishSetup = async () => {+ if (+ !hasWorkspacePermissionV2(+ isUpdate ? "bb.reviewConfigs.update" : "bb.reviewConfigs.create"+ )+ ) {+ pushNotification({+ module: "bytebase",+ style: "CRITICAL",+ title: t("sql-review.no-permission"),+ });+ return;+ }++ try {+ const result = await store.upsertReviewPolicy({+ title: policyName,+ ruleList: convertRuleMapToPolicyRuleList(ruleMapByEngine),+ resources: isEqual(selectedResources, attachedResources)+ ? undefined+ : attachedResources,+ id: `${reviewConfigNamePrefix}${resourceId}`,+ enforce: isUpdate ? undefined : true,+ });+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: isUpdate+ ? t("sql-review.policy-updated")+ : t("sql-review.policy-created"),+ });+ handleCancel(result);+ } catch (error) {+ if (error instanceof ConnectError && error.code === Code.AlreadyExists) {+ pushNotification({+ module: "bytebase",+ style: "CRITICAL",+ title: error.message,+ });+ } else {+ pushNotification({+ module: "bytebase",+ style: "CRITICAL",+ title: isUpdate+ ? t("sql-review.policy-update-failed")+ : t("sql-review.policy-create-failed"),+ });+ }+ }+ };++ // --- Validate resource ID ---++ const validateResourceId = useCallback(+ async (id: string) => {+ try {+ await store.getOrFetchReviewPolicyByName(+ `${reviewConfigNamePrefix}${id}`,+ true+ );+ return [+ {+ type: "error" as const,+ message: t("resource-id.validation.duplicated", {+ resource: t("sql-review.review-policy"),+ }),+ },+ ];+ } catch {+ return [];+ }+ },+ [store, t]+ );++ // --- Step indicators ---++ const steps = [+ { label: t("sql-review.create.basic-info.name") },+ { label: t("sql-review.create.configure-rule.name") },+ ];++ return (+ <div className="w-full h-full flex flex-col">+ {/* Step bar */}+ <div className="sticky top-0 z-10 bg-white border-b px-6 py-4">+ <div className="flex items-center gap-x-2">+ {steps.map((step, index) => (+ <div key={index} className="flex items-center gap-x-2">+ {index > 0 && <div className="w-8 h-px bg-gray-300" />}+ <div+ className={`flex items-center gap-x-2 px-3 py-1.5 rounded-full text-sm font-medium ${+ index === currentStep+ ? "bg-accent text-white"+ : index < currentStep+ ? "bg-green-100 text-green-800"+ : "bg-gray-100 text-gray-500"+ }`}+ >+ <span className="inline-flex items-center justify-center w-5 h-5 rounded-full text-xs bg-white/20">+ {index + 1}+ </span>+ {step.label}+ </div>+ </div>+ ))}+ </div>+ </div>++ {/* Step content */}+ <div className="flex-1 overflow-y-auto p-6">+ {currentStep === STEP_BASIC_INFO && (+ <div className="flex flex-col gap-y-6 max-w-2xl">+ {/* Display name */}+ <div>+ <label className="textlabel">+ {t("sql-review.create.basic-info.display-name")}+ <span className="text-red-500 ml-0.5">*</span>+ </label>+ <p className="mt-1 textinfolabel">+ {t("sql-review.create.basic-info.display-name-label")}+ </p>+ <Input+ className="mt-2"+ value={policyName}+ onChange={(e) => setPolicyName(e.target.value)}+ />+ </div>++ {/* Resource ID */}+ <ResourceIdField+ value={resourceId}+ resourceType="review-config"+ resourceName={t("sql-review.review-policy")}+ resourceTitle={policyName}+ suffix+ readonly={!!policy}+ onChange={setResourceId}+ validate={validateResourceId}+ />++ {/* Template selector */}+ <TemplateSelector+ selectedTemplateId={+ pendingApplyTemplate?.id ?? selectedTemplateId+ }+ onSelectTemplate={tryApplyTemplate}+ />+ </div>+ )}++ {currentStep === STEP_CONFIGURE_RULES && (+ <div>+ {ruleMapByEngine.size > 0 ? (+ <>+ <div className="flex justify-end mb-4">+ <Button onClick={() => setShowRuleSelectPanel(true)}>+ {t("sql-review.add-or-remove-rules")}+ </Button>+ </div>+ <TabsByEngine ruleMapByEngine={ruleMapByEngine}>+ {(ruleList, engine) => (+ <RuleTableWithFilter+ engine={engine}+ ruleList={ruleList}+ editable+ onRuleUpsert={upsertRule}+ onRuleRemove={removeRule}+ />+ )}+ </TabsByEngine>+ </>+ ) : (+ <div className="py-12 border rounded-sm flex flex-col items-center gap-y-4 text-gray-500">+ <p>{t("common.no-data")}</p>+ <Button onClick={() => setShowRuleSelectPanel(true)}>+ <Plus className="w-4 h-4 mr-1" />+ {t("sql-review.add-rules")}+ </Button>+ </div>+ )}++ <RulesSelectPanel+ show={showRuleSelectPanel}+ selectedRuleMap={ruleMapByEngine}+ onClose={() => setShowRuleSelectPanel(false)}+ onRuleSelect={(rule) => upsertRule(rule, {})}+ onRuleRemove={removeRule}+ />+ </div>+ )}+ </div>++ {/* Footer navigation */}+ <div className="border-t px-6 py-4 flex justify-between">+ <div>+ {currentStep === STEP_BASIC_INFO && (+ <Button variant="outline" onClick={() => handleCancel()}>+ {t("common.cancel")}+ </Button>+ )}+ {currentStep > STEP_BASIC_INFO && (+ <Button+ variant="outline"+ onClick={() => changeStep(currentStep - 1)}+ >+ {t("common.previous")}+ </Button>+ )}+ </div>+ <div className="flex gap-x-2">+ {currentStep < STEP_CONFIGURE_RULES && (+ <Button+ disabled={!allowNext}+ onClick={() => changeStep(currentStep + 1)}+ >+ {t("common.next")}+ </Button>+ )}+ {currentStep === STEP_CONFIGURE_RULES && (+ <Button disabled={!allowNext} onClick={tryFinishSetup}>+ {finishTitle}+ </Button>+ )}+ </div>+ </div>+ </div>+ );+}diff --git a/frontend/src/react/components/sql-review/RuleComponents.tsx b/frontend/src/react/components/sql-review/RuleComponents.tsxnew file mode 100644index 0000000000..989f17d80f--- /dev/null+++ b/frontend/src/react/components/sql-review/RuleComponents.tsx@@ -0,0 +1,484 @@+import { CircleHelpIcon, XIcon } from "lucide-react";+import { useEffect, useMemo, useRef, useState } from "react";+import { useTranslation } from "react-i18next";+import type { PayloadValueType } from "@/components/SQLReview/components/RuleConfigComponents/types";+import { getRulePayload } from "@/components/SQLReview/components/RuleConfigComponents/utils";+import { payloadValueListToComponentList } from "@/components/SQLReview/components/utils";+import { t as vueT, te as vueTe } from "@/plugins/i18n";+import { Badge } from "@/react/components/ui/badge";+import { Button } from "@/react/components/ui/button";+import {+ Dialog,+ DialogContent,+ DialogTitle,+} from "@/react/components/ui/dialog";+import { Input } from "@/react/components/ui/input";+import { Tooltip } from "@/react/components/ui/tooltip";+import { Engine } from "@/types/proto-es/v1/common_pb";+import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";+import type {+ RuleConfigComponent,+ RuleTemplateV2,+ TemplatePayload,+} from "@/types/sqlReview";+import {+ getRuleLocalization,+ getRuleLocalizationKey,+ ruleTypeToString,+} from "@/types/sqlReview";++// ---- Types ----++export interface RuleListWithCategory {+ value: string;+ label: string;+ ruleList: RuleTemplateV2[];+}++// ---- RuleLevelSwitch ----++interface RuleLevelSwitchProps {+ level: SQLReviewRule_Level;+ disabled?: boolean;+ editable?: boolean;+ onLevelChange: (level: SQLReviewRule_Level) => void;+}++export function RuleLevelSwitch({+ level,+ disabled,+ editable = true,+ onLevelChange,+}: RuleLevelSwitchProps) {+ const levelOptions = [+ { level: SQLReviewRule_Level.ERROR, label: vueT("sql-review.level.error") },+ {+ level: SQLReviewRule_Level.WARNING,+ label: vueT("sql-review.level.warning"),+ },+ ];++ const base =+ "py-1 w-[4.5rem] whitespace-nowrap border border-control-border text-control font-medium text-sm";++ const activeClass = (opt: SQLReviewRule_Level) => {+ if (opt === SQLReviewRule_Level.ERROR) {+ return "bg-red-100 text-red-800 border-red-800";+ }+ return "bg-yellow-100 text-yellow-800 border-yellow-800";+ };++ const filtered = editable+ ? levelOptions+ : levelOptions.filter((o) => o.level === level);++ return (+ <div className="inline-flex">+ {filtered.map((opt, i) => (+ <button+ key={opt.level}+ type="button"+ disabled={disabled}+ className={`${base} ${i === 0 ? "rounded-l" : "-ml-px"} ${i === filtered.length - 1 ? "rounded-r" : ""} ${+ level === opt.level ? activeClass(opt.level) : ""+ } ${disabled ? "cursor-not-allowed opacity-50" : "cursor-pointer"}`}+ onClick={() => onLevelChange(opt.level)}+ >+ {opt.label}+ </button>+ ))}+ </div>+ );+}++// ---- RuleLevelBadge ----++interface RuleLevelBadgeProps {+ level: SQLReviewRule_Level;+ suffix?: string;+}++export function RuleLevelBadge({ level, suffix }: RuleLevelBadgeProps) {+ const variant =+ level === SQLReviewRule_Level.ERROR ? "destructive" : "warning";+ const label =+ level === SQLReviewRule_Level.ERROR+ ? vueT("sql-review.level.error")+ : vueT("sql-review.level.warning");++ return (+ <Badge variant={variant}>+ {label}+ {suffix && ` ${suffix}`}+ </Badge>+ );+}++// ---- RuleConfig ----++interface RuleConfigProps {+ rule: RuleTemplateV2;+ disabled: boolean;+ size: "small" | "medium";+ payloadRef?: React.MutableRefObject<PayloadValueType[]>;+}++function configTitle(+ rule: RuleTemplateV2,+ config: RuleConfigComponent+): string {+ const key = `sql-review.rule.${getRuleLocalizationKey(ruleTypeToString(rule.type))}.component.${config.key}.title`;+ return vueT(key);+}++function configTooltip(+ rule: RuleTemplateV2,+ config: RuleConfigComponent+): string {+ const key = `sql-review.rule.${getRuleLocalizationKey(ruleTypeToString(rule.type))}.component.${config.key}.tooltip`;+ return vueTe(key) ? vueT(key) : "";+}++export function RuleConfig({+ rule,+ disabled,+ size,+ payloadRef,+}: RuleConfigProps) {+ const [payload, setPayload] = useState<PayloadValueType[]>(() =>+ getRulePayload(rule)+ );++ useEffect(() => {+ setPayload(getRulePayload(rule));+ }, [rule.componentList]);++ // Expose payload to parent via ref+ useEffect(() => {+ if (payloadRef) {+ payloadRef.current = payload;+ }+ }, [payload, payloadRef]);++ const updatePayload = (index: number, value: PayloadValueType) => {+ setPayload((prev) => {+ const next = [...prev];+ next[index] = value;+ return next;+ });+ };++ return (+ <div className="flex flex-col gap-y-4">+ {rule.componentList.map((config, index) => (+ <div key={index} className="flex flex-col gap-y-1">+ {config.payload.type !== "BOOLEAN" && (+ <div className="flex items-center gap-x-1">+ <p+ className={`font-medium ${size !== "small" ? "text-lg text-control mb-2" : ""}`}+ >+ {configTitle(rule, config)}+ </p>+ {configTooltip(rule, config) && (+ <Tooltip content={configTooltip(rule, config)}>+ <CircleHelpIcon className="w-4 h-4" />+ </Tooltip>+ )}+ </div>+ )}++ {config.payload.type === "STRING" && (+ <Input+ value={(payload[index] as string) ?? ""}+ disabled={disabled}+ placeholder={`${config.payload.default}`}+ onChange={(e) => updatePayload(index, e.target.value)}+ />+ )}++ {config.payload.type === "NUMBER" && (+ <input+ type="number"+ className="flex h-9 w-full rounded-xs border border-control-border bg-transparent px-3 py-1 text-sm text-main placeholder:text-control-placeholder focus:outline-hidden focus:ring-2 focus:ring-accent focus:border-accent disabled:cursor-not-allowed disabled:bg-control-bg disabled:opacity-50"+ value={(payload[index] as number) ?? 0}+ disabled={disabled}+ placeholder={`${config.payload.default}`}+ onChange={(e) => updatePayload(index, Number(e.target.value))}+ />+ )}++ {config.payload.type === "BOOLEAN" && (+ <label className="flex items-center gap-x-2">+ <input+ type="checkbox"+ checked={(payload[index] as boolean) ?? false}+ disabled={disabled}+ onChange={(e) => updatePayload(index, e.target.checked)}+ />+ <span>{configTitle(rule, config)}</span>+ {configTooltip(rule, config) && (+ <Tooltip content={configTooltip(rule, config)}>+ <CircleHelpIcon className="w-4 h-4" />+ </Tooltip>+ )}+ </label>+ )}++ {config.payload.type === "STRING_ARRAY" &&+ Array.isArray(payload[index]) && (+ <StringArrayInput+ value={payload[index] as string[]}+ disabled={disabled}+ onChange={(val) => updatePayload(index, val)}+ />+ )}++ {config.payload.type === "TEMPLATE" && (+ <TemplateSelect+ ruleType={ruleTypeToString(rule.type)}+ config={config}+ value={(payload[index] as string) ?? ""}+ disabled={disabled}+ onChange={(val) => updatePayload(index, val)}+ />+ )}+ </div>+ ))}+ </div>+ );+}++// ---- StringArrayInput (internal) ----++function StringArrayInput({+ value,+ disabled,+ onChange,+}: {+ value: string[];+ disabled: boolean;+ onChange: (value: string[]) => void;+}) {+ const [inputValue, setInputValue] = useState("");++ const handleKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {+ if (e.key === "Enter") {+ e.preventDefault();+ const trimmed = inputValue.trim();+ if (trimmed) {+ onChange([...value, trimmed]);+ setInputValue("");+ }+ }+ };++ const removeTag = (index: number) => {+ onChange(value.filter((_, i) => i !== index));+ };++ return (+ <div>+ {!disabled && (+ <p className="text-sm text-control-placeholder mb-1">+ {vueT("sql-review.input-then-press-enter")}+ </p>+ )}+ <div className="flex flex-wrap items-center gap-1">+ {value.map((tag, i) => (+ <span+ key={i}+ className="inline-flex items-center gap-1 rounded bg-control-bg px-2 py-0.5 text-sm"+ >+ {tag}+ {!disabled && (+ <button+ type="button"+ className="cursor-pointer hover:text-error"+ onClick={() => removeTag(i)}+ >+ <XIcon className="w-3 h-3" />+ </button>+ )}+ </span>+ ))}+ {!disabled && (+ <input+ className="min-w-[20rem] flex-1 border border-control-border rounded-xs px-2 py-1 text-sm focus:outline-hidden focus:ring-2 focus:ring-accent"+ value={inputValue}+ onChange={(e) => setInputValue(e.target.value)}+ onKeyDown={handleKeyDown}+ />+ )}+ </div>+ </div>+ );+}++// ---- TemplateSelect (internal) ----++function TemplateSelect({+ ruleType,+ config,+ value,+ disabled,+ onChange,+}: {+ ruleType: string;+ config: RuleConfigComponent;+ value: string;+ disabled: boolean;+ onChange: (value: string) => void;+}) {+ const payload = config.payload as TemplatePayload;+ const options = payload.templateList.map((id) => ({+ id,+ description: vueT(+ `sql-review.rule.${getRuleLocalizationKey(ruleType)}.component.${config.key}.template.${id}`+ ),+ }));++ return (+ <select+ className="flex h-9 w-full rounded-xs border border-control-border bg-transparent px-3 py-1 text-sm text-main focus:outline-hidden focus:ring-2 focus:ring-accent disabled:cursor-not-allowed disabled:bg-control-bg disabled:opacity-50"+ value={value}+ disabled={disabled}+ onChange={(e) => onChange(e.target.value)}+ >+ {options.map((opt) => (+ <option key={opt.id} value={opt.id}>+ {opt.description}+ </option>+ ))}+ </select>+ );+}++// ---- RuleEditDialog ----++interface RuleEditDialogProps {+ rule: RuleTemplateV2;+ disabled: boolean;+ onUpdateRule: (update: Partial<RuleTemplateV2>) => void;+ onCancel: () => void;+}++export function RuleEditDialog({+ rule,+ disabled,+ onUpdateRule,+ onCancel,+}: RuleEditDialogProps) {+ const { t } = useTranslation();+ const [level, setLevel] = useState(rule.level);+ const payloadRef = useRef<PayloadValueType[]>(getRulePayload(rule));+ const localization = useMemo(+ () => getRuleLocalization(ruleTypeToString(rule.type), rule.engine),+ [rule.type, rule.engine]+ );++ const handleConfirm = () => {+ const componentList = payloadValueListToComponentList(+ rule,+ payloadRef.current+ );+ onUpdateRule({ level, componentList });+ onCancel();+ };++ return (+ <Dialog open onOpenChange={(open) => !open && onCancel()}>+ <DialogContent>+ <div className="p-6 flex flex-col gap-y-4">+ <div className="flex items-center justify-between">+ <DialogTitle>{localization.title}</DialogTitle>+ <span className="text-sm text-control-placeholder">+ {Engine[rule.engine]}+ </span>+ </div>++ <RuleLevelSwitch+ level={level}+ disabled={disabled}+ editable={!disabled}+ onLevelChange={setLevel}+ />++ {localization.description && (+ <p className="text-sm text-control-placeholder">+ {localization.description}+ </p>+ )}++ {rule.componentList.length > 0 && (+ <RuleConfig+ rule={rule}+ disabled={disabled}+ size="medium"+ payloadRef={payloadRef}+ />+ )}++ <div className="flex justify-end gap-x-2">+ <Button variant="outline" onClick={onCancel}>+ {t("common.cancel")}+ </Button>+ <Button disabled={disabled} onClick={handleConfirm}>+ {t("common.confirm")}+ </Button>+ </div>+ </div>+ </DialogContent>+ </Dialog>+ );+}++// ---- RuleLevelFilter ----++interface RuleLevelFilterProps {+ ruleList: RuleListWithCategory[];+ isCheckedLevel: (level: SQLReviewRule_Level) => boolean;+ onToggleCheckedLevel: (level: SQLReviewRule_Level) => void;+}++export function RuleLevelFilter({+ ruleList,+ isCheckedLevel,+ onToggleCheckedLevel,+}: RuleLevelFilterProps) {+ const countByLevel = useMemo(() => {+ const counts = new Map<SQLReviewRule_Level, number>();+ for (const category of ruleList) {+ for (const rule of category.ruleList) {+ counts.set(rule.level, (counts.get(rule.level) ?? 0) + 1);+ }+ }+ return counts;+ }, [ruleList]);++ const levels = [+ SQLReviewRule_Level.ERROR,+ SQLReviewRule_Level.WARNING,+ ] as const;++ return (+ <div className="flex items-center gap-x-4">+ {levels.map((level) => {+ const count = countByLevel.get(level) ?? 0;+ if (count === 0) return null;+ return (+ <label+ key={level}+ className="flex items-center gap-x-2 cursor-pointer"+ >+ <input+ type="checkbox"+ checked={isCheckedLevel(level)}+ onChange={() => onToggleCheckedLevel(level)}+ />+ <RuleLevelBadge level={level} suffix={`(${count})`} />+ </label>+ );+ })}+ </div>+ );+}diff --git a/frontend/src/react/components/sql-review/RuleTable.tsx b/frontend/src/react/components/sql-review/RuleTable.tsxnew file mode 100644index 0000000000..25c8386087--- /dev/null+++ b/frontend/src/react/components/sql-review/RuleTable.tsx@@ -0,0 +1,676 @@+import {+ ChevronDown,+ ChevronRight,+ ExternalLink,+ Pencil,+ Search,+} from "lucide-react";+import { useCallback, useEffect, useMemo, useState } from "react";+import { useTranslation } from "react-i18next";+import { getRuleKey } from "@/components/SQLReview/components/utils";+import { t as vueT } from "@/plugins/i18n";+import { Button } from "@/react/components/ui/button";+import { Tabs, TabsList, TabsTrigger } from "@/react/components/ui/tabs";+import type { Engine } from "@/types/proto-es/v1/common_pb";+import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";+import type { RuleTemplateV2 } from "@/types/sqlReview";+import {+ convertToCategoryMap,+ getRuleLocalization,+ isBuiltinRule,+ ruleTypeToString,+} from "@/types/sqlReview";+import {+ RuleConfig,+ RuleEditDialog,+ RuleLevelFilter,+ RuleLevelSwitch,+ type RuleListWithCategory,+} from "./RuleComponents";++// ---- Types ----++export interface SQLRuleFilterParams {+ checkedLevel: Set<SQLReviewRule_Level>;+ selectedCategory: string;+ searchText: string;+}++// ---- useSQLRuleFilter hook ----++export function useSQLRuleFilter() {+ const [checkedLevel, setCheckedLevel] = useState<Set<SQLReviewRule_Level>>(+ () => new Set()+ );+ const [selectedCategory, setSelectedCategory] = useState("all");+ const [searchText, setSearchText] = useState("");++ const params: SQLRuleFilterParams = {+ checkedLevel,+ selectedCategory,+ searchText,+ };++ const events = useMemo(+ () => ({+ toggleCheckedLevel(level: SQLReviewRule_Level) {+ setCheckedLevel((prev) => {+ const next = new Set(prev);+ if (next.has(level)) {+ next.delete(level);+ } else {+ next.add(level);+ }+ return next;+ });+ },+ changeCategory(category: string) {+ setSelectedCategory(category);+ },+ changeSearchText(keyword: string) {+ setSearchText(keyword);+ },+ reset() {+ setSelectedCategory("all");+ setCheckedLevel(new Set());+ setSearchText("");+ },+ }),+ []+ );++ return { params, events };+}++// ---- Filtering helpers ----++function filterRuleByKeyword(rule: RuleTemplateV2, searchText: string) {+ const keyword = searchText.trim().toLowerCase();+ if (!keyword) return true;+ if (ruleTypeToString(rule.type).toLowerCase().includes(keyword)) return true;+ const localization = getRuleLocalization(+ ruleTypeToString(rule.type),+ rule.engine+ );+ if (localization.title.toLowerCase().includes(keyword)) return true;+ if (localization.description.toLowerCase().includes(keyword)) return true;+ return false;+}++function filterRuleList(+ list: RuleListWithCategory[],+ params: SQLRuleFilterParams+): RuleListWithCategory[] {+ if (params.checkedLevel.size === 0 && !params.searchText) {+ return list;+ }+ return list+ .map((item) => ({+ ...item,+ ruleList: item.ruleList.filter((rule) => {+ if (+ params.checkedLevel.size > 0 &&+ !params.checkedLevel.has(rule.level)+ ) {+ return false;+ }+ return filterRuleByKeyword(rule, params.searchText);+ }),+ }))+ .filter((item) => item.ruleList.length > 0);+}++// ---- RuleFilter ----++interface RuleFilterProps {+ ruleList: RuleTemplateV2[];+ params: SQLRuleFilterParams;+ hideLevelFilter?: boolean;+ supportSelect?: boolean;+ selectedRuleCount?: number;+ onToggleSelectAll?: (select: boolean) => void;+ onToggleCheckedLevel: (level: SQLReviewRule_Level) => void;+ onChangeCategory: (category: string) => void;+ onChangeSearchText: (keyword: string) => void;+ children: (filteredRuleList: RuleListWithCategory[]) => React.ReactNode;+}++export function RuleFilter({+ ruleList,+ params,+ hideLevelFilter = false,+ supportSelect = false,+ selectedRuleCount = 0,+ onToggleSelectAll,+ onToggleCheckedLevel,+ onChangeCategory,+ onChangeSearchText,+ children,+}: RuleFilterProps) {+ const { t } = useTranslation();++ const tabItemList = useMemo(() => {+ const list: RuleListWithCategory[] = [+ { value: "all", label: vueT("common.all"), ruleList: [] },+ ];+ for (const [category, rules] of convertToCategoryMap(ruleList).entries()) {+ list.push({+ value: category,+ label: vueT(`sql-review.category.${category.toLowerCase()}`),+ ruleList: rules,+ });+ }+ return list;+ }, [ruleList]);++ const currentRuleListByCategory = useMemo(() => {+ if (params.selectedCategory === "all") {+ return tabItemList.slice(1);+ }+ const found = tabItemList.find(+ (item) => item.value === params.selectedCategory+ );+ return found ? [found] : [];+ }, [tabItemList, params.selectedCategory]);++ const filteredRuleList = useMemo(+ () => filterRuleList(currentRuleListByCategory, params),+ [currentRuleListByCategory, params]+ );++ return (+ <div className="gap-y-3">+ <Tabs+ value={params.selectedCategory}+ onValueChange={(val) => onChangeCategory(val as string)}+ >+ <TabsList className="flex-wrap">+ {tabItemList.map((item) => (+ <TabsTrigger key={item.value} value={item.value}>+ {item.label}+ </TabsTrigger>+ ))}+ </TabsList>++ <div className="mt-2 flex flex-col justify-start items-start md:flex-row md:items-center md:justify-between">+ {!hideLevelFilter && (+ <RuleLevelFilter+ ruleList={currentRuleListByCategory}+ isCheckedLevel={(level) => params.checkedLevel.has(level)}+ onToggleCheckedLevel={onToggleCheckedLevel}+ />+ )}+ {supportSelect && (+ <div className="flex items-center gap-x-2">+ <input+ type="checkbox"+ checked={+ selectedRuleCount === ruleList.length && ruleList.length > 0+ }+ ref={(el) => {+ if (el) {+ el.indeterminate =+ selectedRuleCount > 0 &&+ selectedRuleCount !== ruleList.length;+ }+ }}+ onChange={(e) => onToggleSelectAll?.(e.target.checked)}+ />+ <span className="text-xl text-main font-medium">+ {vueT("sql-review.select-all")}+ </span>+ </div>+ )}+ <div className="relative ml-auto mt-2 md:mt-0 md:max-w-72 w-full md:w-auto">+ <Search className="absolute left-2 top-1/2 -translate-y-1/2 w-4 h-4 text-control-placeholder" />+ <input+ className="w-full rounded-xs border border-control-border bg-transparent py-1.5 pl-8 pr-3 text-sm text-main placeholder:text-control-placeholder focus:outline-hidden focus:ring-2 focus:ring-accent"+ placeholder={t("common.filter-by-name")}+ value={params.searchText}+ onChange={(e) => onChangeSearchText(e.target.value)}+ />+ </div>+ </div>++ {/* We render the content outside TabsPanel since we control filtering ourselves */}+ <hr className="my-3 border-control-border" />+ {children(filteredRuleList)}+ </Tabs>+ </div>+ );+}++// ---- RuleTable ----++interface RuleTableProps {+ ruleList: RuleListWithCategory[];+ editable: boolean;+ supportSelect?: boolean;+ hideLevel?: boolean;+ selectedRuleKeys?: string[];+ size?: "small" | "medium";+ onRuleUpsert?: (+ rule: RuleTemplateV2,+ update: Partial<RuleTemplateV2>+ ) => void;+ onRuleRemove?: (rule: RuleTemplateV2) => void;+ onSelectedRuleKeysChange?: (keys: string[]) => void;+}++export function RuleTable({+ ruleList,+ editable,+ supportSelect = false,+ hideLevel = false,+ selectedRuleKeys = [],+ size: _size = "medium",+ onRuleUpsert,+ onRuleRemove,+ onSelectedRuleKeysChange,+}: RuleTableProps) {+ const { t } = useTranslation();+ const [expandedRows, setExpandedRows] = useState<Set<string>>(+ () => new Set()+ );+ const [activeRule, setActiveRule] = useState<RuleTemplateV2 | undefined>();++ const toggleExpand = (key: string) => {+ setExpandedRows((prev) => {+ const next = new Set(prev);+ if (next.has(key)) {+ next.delete(key);+ } else {+ next.add(key);+ }+ return next;+ });+ };++ const toggleRule = (rule: RuleTemplateV2) => {+ const key = getRuleKey(rule);+ const index = selectedRuleKeys.indexOf(key);+ if (index < 0) {+ onSelectedRuleKeysChange?.([...selectedRuleKeys, key]);+ } else {+ onSelectedRuleKeysChange?.([+ ...selectedRuleKeys.slice(0, index),+ ...selectedRuleKeys.slice(index + 1),+ ]);+ }+ };++ const updateLevel = (rule: RuleTemplateV2, level: SQLReviewRule_Level) => {+ onRuleUpsert?.(rule, { level });+ };++ const onRuleChanged = (update: Partial<RuleTemplateV2>) => {+ if (activeRule) {+ onRuleUpsert?.(activeRule, update);+ }+ };++ const isExpandable = (rule: RuleTemplateV2) => {+ const loc = getRuleLocalization(ruleTypeToString(rule.type), rule.engine);+ return !!(loc.description || rule.componentList.length > 0);+ };++ return (+ <div>+ {ruleList.map((category) => (+ <div key={category.value}>+ <div className="flex my-3 items-center">+ <span className="text-xl text-main font-semibold">+ {category.label}+ </span>+ <span className="text-control-light text-md ml-1">+ ({category.ruleList.length})+ </span>+ </div>++ {/* Desktop table */}+ <div className="hidden lg:block border rounded-sm overflow-hidden">+ <table className="w-full text-sm">+ <thead>+ <tr className="border-b bg-control-bg">+ <th className="w-8 px-3 py-2" />+ {supportSelect && <th className="w-8 px-3 py-2" />}+ <th className="text-left px-4 py-2 font-medium whitespace-nowrap">+ {t("common.name")}+ </th>+ {!hideLevel && (+ <th className="text-left px-4 py-2 font-medium whitespace-nowrap w-[12rem]">+ {vueT("sql-review.level.name")}+ </th>+ )}+ {!supportSelect && (+ <th className="text-right px-4 py-2 font-medium whitespace-nowrap w-48">+ {t("common.operations")}+ </th>+ )}+ </tr>+ </thead>+ <tbody>+ {category.ruleList.map((rule, idx) => {+ const key = getRuleKey(rule);+ const loc = getRuleLocalization(+ ruleTypeToString(rule.type),+ rule.engine+ );+ const expanded = expandedRows.has(key);+ const expandable = isExpandable(rule);++ return (+ <RuleTableRow+ key={key}+ rule={rule}+ loc={loc}+ expanded={expanded}+ expandable={expandable}+ striped={idx % 2 === 1}+ supportSelect={supportSelect}+ hideLevel={hideLevel}+ editable={editable}+ isSelected={selectedRuleKeys.includes(key)}+ onToggleExpand={() => toggleExpand(key)}+ onToggleRule={() => toggleRule(rule)}+ onEdit={() => setActiveRule(rule)}+ onRemove={() => onRuleRemove?.(rule)}+ onLevelChange={(level) => updateLevel(rule, level)}+ />+ );+ })}+ </tbody>+ </table>+ </div>++ {/* Mobile cards */}+ <div className="flex flex-col lg:hidden border px-2 pb-4 divide-y divide-block-border">+ {category.ruleList.map((rule) => {+ const loc = getRuleLocalization(+ ruleTypeToString(rule.type),+ rule.engine+ );+ return (+ <div+ key={getRuleKey(rule)}+ className="pt-4 flex flex-col gap-y-3"+ >+ <div className="flex justify-between items-center gap-x-2">+ <div className="flex items-center gap-x-1">+ <span>+ {loc.title}+ <a+ href={`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`}+ target="_blank"+ rel="noopener noreferrer"+ className="inline-block ml-1"+ >+ <ExternalLink className="w-4 h-4" />+ </a>+ </span>+ </div>+ {supportSelect ? (+ <input+ type="checkbox"+ checked={selectedRuleKeys.includes(getRuleKey(rule))}+ onChange={() => toggleRule(rule)}+ />+ ) : (+ <div className="flex items-center gap-x-2">+ {editable && (+ <Pencil+ className="w-4 h-4 cursor-pointer hover:text-accent"+ onClick={() => setActiveRule(rule)}+ />+ )}+ {editable && !isBuiltinRule(rule) && (+ <Button+ variant="destructive"+ size="sm"+ onClick={() => onRuleRemove?.(rule)}+ >+ {t("common.delete")}+ </Button>+ )}+ </div>+ )}+ </div>+ {!hideLevel && (+ <RuleLevelSwitch+ level={rule.level}+ disabled={!editable}+ onLevelChange={(level) => updateLevel(rule, level)}+ />+ )}+ <p className="text-sm text-control-placeholder">+ {loc.description}+ </p>+ </div>+ );+ })}+ </div>+ </div>+ ))}++ {activeRule && (+ <RuleEditDialog+ key={getRuleKey(activeRule)}+ rule={activeRule}+ disabled={!editable}+ onCancel={() => setActiveRule(undefined)}+ onUpdateRule={onRuleChanged}+ />+ )}+ </div>+ );+}++// ---- RuleTableRow (desktop, internal) ----++interface RuleTableRowProps {+ rule: RuleTemplateV2;+ loc: { title: string; description: string };+ expanded: boolean;+ expandable: boolean;+ striped: boolean;+ supportSelect: boolean;+ hideLevel: boolean;+ editable: boolean;+ isSelected: boolean;+ onToggleExpand: () => void;+ onToggleRule: () => void;+ onEdit: () => void;+ onRemove: () => void;+ onLevelChange: (level: SQLReviewRule_Level) => void;+}++function RuleTableRow({+ rule,+ loc,+ expanded,+ expandable,+ striped,+ supportSelect,+ hideLevel,+ editable,+ isSelected,+ onToggleExpand,+ onToggleRule,+ onEdit,+ onRemove,+ onLevelChange,+}: RuleTableRowProps) {+ const { t } = useTranslation();++ const colSpan =+ 2 + (supportSelect ? 1 : 0) + (hideLevel ? 0 : 1) + (supportSelect ? 0 : 1);++ return (+ <>+ <tr+ className={`border-b last:border-b-0 ${striped ? "bg-gray-50" : ""} ${supportSelect ? "cursor-pointer hover:bg-gray-50" : ""}`}+ onClick={supportSelect ? onToggleRule : undefined}+ >+ <td className="px-3 py-2 w-8" onClick={(e) => e.stopPropagation()}>+ {expandable && (+ <button+ type="button"+ className="cursor-pointer p-0.5 text-control-light hover:text-control"+ onClick={onToggleExpand}+ >+ {expanded ? (+ <ChevronDown className="w-4 h-4" />+ ) : (+ <ChevronRight className="w-4 h-4" />+ )}+ </button>+ )}+ </td>+ {supportSelect && (+ <td className="px-3 py-2 w-8" onClick={(e) => e.stopPropagation()}>+ <input+ type="checkbox"+ checked={isSelected}+ onChange={onToggleRule}+ className="h-4 w-4 rounded border-control-border accent-accent"+ />+ </td>+ )}+ <td className="px-4 py-2">+ <div className="flex items-center gap-x-2">+ <span>{loc.title}</span>+ <a+ href={`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`}+ target="_blank"+ rel="noopener noreferrer"+ className="flex items-center text-control-light hover:text-control"+ >+ <ExternalLink className="w-4 h-4" />+ </a>+ </div>+ </td>+ {!hideLevel && (+ <td className="px-4 py-2" onClick={(e) => e.stopPropagation()}>+ <RuleLevelSwitch+ level={rule.level}+ disabled={!editable}+ onLevelChange={onLevelChange}+ />+ </td>+ )}+ {!supportSelect && (+ <td className="px-4 py-2" onClick={(e) => e.stopPropagation()}>+ <div className="flex items-center justify-end gap-x-2">+ <Button variant="outline" size="sm" onClick={onEdit}>+ {editable ? t("common.edit") : t("common.view")}+ </Button>+ {editable && !isBuiltinRule(rule) && (+ <Button variant="destructive" size="sm" onClick={onRemove}>+ {t("common.delete")}+ </Button>+ )}+ </div>+ </td>+ )}+ </tr>+ {expanded && (+ <tr className="border-b last:border-b-0">+ <td colSpan={colSpan} className="px-10 py-3 bg-gray-50/50">+ {loc.description && (+ <p className="text-gray-500">{loc.description}</p>+ )}+ {rule.componentList.length > 0 && loc.description && (+ <hr className="my-4 border-control-border" />+ )}+ {rule.componentList.length > 0 && (+ <RuleConfig rule={rule} disabled size="small" />+ )}+ </td>+ </tr>+ )}+ </>+ );+}++// ---- RuleTableWithFilter ----++interface RuleTableWithFilterProps {+ engine: Engine;+ ruleList: RuleTemplateV2[];+ editable: boolean;+ hideLevel?: boolean;+ supportSelect?: boolean;+ selectedRuleKeys?: string[];+ size?: "small" | "medium";+ onRuleUpsert?: (+ rule: RuleTemplateV2,+ update: Partial<RuleTemplateV2>+ ) => void;+ onRuleRemove?: (rule: RuleTemplateV2) => void;+ onSelectedRuleKeysChange?: (keys: string[]) => void;+}++export function RuleTableWithFilter({+ engine,+ ruleList,+ editable,+ hideLevel = false,+ supportSelect = false,+ selectedRuleKeys = [],+ size = "medium",+ onRuleUpsert,+ onRuleRemove,+ onSelectedRuleKeysChange,+}: RuleTableWithFilterProps) {+ const { t } = useTranslation();+ const { params, events } = useSQLRuleFilter();++ useEffect(() => {+ events.reset();+ }, [engine, events]);++ const toggleSelectAll = useCallback(+ (select: boolean) => {+ if (!select) {+ onSelectedRuleKeysChange?.([]);+ } else {+ onSelectedRuleKeysChange?.(ruleList.map(getRuleKey));+ }+ },+ [ruleList, onSelectedRuleKeysChange]+ );++ return (+ <RuleFilter+ ruleList={ruleList}+ params={params}+ hideLevelFilter={hideLevel}+ supportSelect={supportSelect}+ selectedRuleCount={selectedRuleKeys.length}+ onToggleSelectAll={toggleSelectAll}+ onToggleCheckedLevel={events.toggleCheckedLevel}+ onChangeCategory={events.changeCategory}+ onChangeSearchText={events.changeSearchText}+ >+ {(filteredRuleList) =>+ filteredRuleList.length > 0 ? (+ <RuleTable+ ruleList={filteredRuleList}+ editable={editable}+ hideLevel={hideLevel}+ supportSelect={supportSelect}+ selectedRuleKeys={selectedRuleKeys}+ size={size}+ onRuleUpsert={onRuleUpsert}+ onRuleRemove={onRuleRemove}+ onSelectedRuleKeysChange={onSelectedRuleKeysChange}+ />+ ) : (+ <div className="py-12 border rounded-sm text-center text-control-placeholder">+ {t("common.no-data")}+ </div>+ )+ }+ </RuleFilter>+ );+}diff --git a/frontend/src/react/components/sql-review/TabsByEngine.tsx b/frontend/src/react/components/sql-review/TabsByEngine.tsxnew file mode 100644index 0000000000..a0911d1e85--- /dev/null+++ b/frontend/src/react/components/sql-review/TabsByEngine.tsx@@ -0,0 +1,97 @@+import { useEffect, useMemo, useState } from "react";+import { EngineIconPath } from "@/components/InstanceForm/constants";+import {+ Tabs,+ TabsList,+ TabsPanel,+ TabsTrigger,+} from "@/react/components/ui/tabs";+import { Engine } from "@/types/proto-es/v1/common_pb";+import type { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";+import type { RuleTemplateV2 } from "@/types/sqlReview";+import { engineNameV1, supportedEngineV1List } from "@/utils";++interface TabsByEngineProps {+ ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;+ children: (ruleList: RuleTemplateV2[], engine: Engine) => React.ReactNode;+}++export function TabsByEngine({ ruleMapByEngine, children }: TabsByEngineProps) {+ const [selectedEngine, setSelectedEngine] = useState<Engine>(+ Engine.ENGINE_UNSPECIFIED+ );++ // Only reset to first engine on initial load or when the selected engine disappears+ useEffect(() => {+ if (+ selectedEngine === Engine.ENGINE_UNSPECIFIED ||+ !ruleMapByEngine.has(selectedEngine)+ ) {+ const firstEngine =+ [...ruleMapByEngine.keys()][0] ?? Engine.ENGINE_UNSPECIFIED;+ setSelectedEngine(firstEngine);+ }+ }, [ruleMapByEngine, selectedEngine]);++ const sortedData = useMemo(() => {+ const orderRank = new Map<Engine, number>();+ supportedEngineV1List().forEach((engine, index) => {+ orderRank.set(engine, index);+ });++ return [...ruleMapByEngine.entries()].sort(([e1], [e2]) => {+ return (orderRank.get(e1) ?? 0) - (orderRank.get(e2) ?? 0);+ });+ }, [ruleMapByEngine]);++ const RE_SUBTITLE = /\(.+?\)/;++ const engineParts = (engine: Engine): { title: string; subtitle: string } => {+ const name = engineNameV1(engine);+ const match = name.match(RE_SUBTITLE);+ if (!match) return { title: name, subtitle: "" };+ return {+ title: name.replace(match[0], "").trim(),+ subtitle: match[0],+ };+ };++ if (sortedData.length === 0) {+ return null;+ }++ return (+ <Tabs+ value={String(selectedEngine)}+ onValueChange={(val) => setSelectedEngine(Number(val) as Engine)}+ >+ <TabsList className="gap-x-4">+ {sortedData.map(([engine, ruleMap]) => (+ <TabsTrigger key={engine} value={String(engine)}>+ <div className="flex items-center gap-x-1">+ <img+ src={EngineIconPath[engine]}+ alt=""+ className="h-4 w-auto object-contain"+ />+ <span className="text-sm">{engineParts(engine).title}</span>+ {engineParts(engine).subtitle && (+ <span className="text-xs text-control-light">+ {engineParts(engine).subtitle}+ </span>+ )}+ <span className="text-xs px-1 py-0.5 rounded-full bg-gray-200 text-gray-800 ml-1">+ {ruleMap.size}+ </span>+ </div>+ </TabsTrigger>+ ))}+ </TabsList>+ {sortedData.map(([engine, ruleMap]) => (+ <TabsPanel key={engine} value={String(engine)}>+ {children([...ruleMap.values()], engine)}+ </TabsPanel>+ ))}+ </Tabs>+ );+}diff --git a/frontend/src/react/components/sql-review/TemplateSelector.tsx b/frontend/src/react/components/sql-review/TemplateSelector.tsxnew file mode 100644index 0000000000..d21033341f--- /dev/null+++ b/frontend/src/react/components/sql-review/TemplateSelector.tsx@@ -0,0 +1,170 @@+import { CheckCircle } from "lucide-react";+import { useEffect, useMemo } from "react";+import { useTranslation } from "react-i18next";+import { rulesToTemplate } from "@/components/SQLReview/components/utils";+import { t as vueT } from "@/plugins/i18n";+import { EnvironmentLabel } from "@/react/components/EnvironmentLabel";+import { Badge } from "@/react/components/ui/badge";+import { useVueState } from "@/react/hooks/useVueState";+import { useProjectV1Store, useSQLReviewStore } from "@/store";+import {+ environmentNamePrefix,+ projectNamePrefix,+} from "@/store/modules/v1/common";+import type { SQLReviewPolicyTemplateV2 } from "@/types";+import { TEMPLATE_LIST_V2 as builtInTemplateList } from "@/types";++interface PolicyTemplate extends SQLReviewPolicyTemplateV2 {+ review?: {+ name: string;+ resources: string[];+ };+}++interface TemplateSelectorProps {+ required?: boolean;+ selectedTemplateId?: string;+ onSelectTemplate: (template: SQLReviewPolicyTemplateV2) => void;+}++function ResourceBadge({ resource }: { resource: string }) {+ const { t } = useTranslation();+ const projectStore = useProjectV1Store();++ useEffect(() => {+ if (resource.startsWith(projectNamePrefix)) {+ projectStore.getOrFetchProjectByName(resource, true);+ }+ }, [projectStore, resource]);++ const projectTitle = useVueState(() =>+ resource.startsWith(projectNamePrefix)+ ? projectStore.getProjectByName(resource)?.title+ : undefined+ );++ if (resource.startsWith(environmentNamePrefix)) {+ return (+ <Badge variant="default" className="gap-x-1">+ <span className="text-control-light text-xs">+ {t("common.environment")}:+ </span>+ <EnvironmentLabel environmentName={resource} />+ </Badge>+ );+ }++ if (resource.startsWith(projectNamePrefix)) {+ return (+ <Badge variant="default" className="gap-x-1">+ <span className="text-control-light text-xs">+ {t("common.project")}:+ </span>+ <span>{projectTitle || resource}</span>+ </Badge>+ );+ }++ return <Badge variant="default">{resource}</Badge>;+}++export function TemplateSelector({+ required,+ selectedTemplateId,+ onSelectTemplate,+}: TemplateSelectorProps) {+ const sqlReviewStore = useSQLReviewStore();+ const policyList = useVueState(() => [...sqlReviewStore.reviewPolicyList]);++ useEffect(() => {+ sqlReviewStore.fetchReviewPolicyList();+ }, []);++ const reviewPolicyTemplateList = useMemo<PolicyTemplate[]>(() => {+ return policyList.map((r) => rulesToTemplate(r));+ }, [policyList]);++ const isSelected = (template: SQLReviewPolicyTemplateV2) =>+ template.id === selectedTemplateId;++ return (+ <div className="flex flex-col gap-y-2">+ <p className="textlabel">+ {vueT("sql-review.create.basic-info.choose-template")}+ {required && <span className="text-red-500"> *</span>}+ </p>++ {reviewPolicyTemplateList.length > 0 && (+ <>+ <div className="flex flex-wrap gap-4">+ {reviewPolicyTemplateList.map((template) => (+ <div+ key={template.id}+ className={`relative border border-gray-300 hover:bg-gray-100 rounded-lg px-6 py-4 transition-all cursor-pointer w-full sm:max-w-xs ${+ isSelected(template) ? "bg-gray-100" : "bg-transparent"+ }`}+ onClick={() => onSelectTemplate(template)}+ >+ <div className="text-left flex flex-col gap-y-2">+ <span className="text-base font-medium">+ {template.review?.name}+ </span>+ <div className="flex flex-wrap gap-2">+ {template.review?.resources.map((resource) => (+ <ResourceBadge key={resource} resource={resource} />+ ))}+ </div>+ <p className="text-sm">+ <span className="mr-2">+ {vueT("sql-review.enabled-rules")}:+ </span>+ <span>{template.ruleList.length}</span>+ </p>+ </div>+ {isSelected(template) && (+ <CheckCircle className="w-7 h-7 text-accent absolute top-3 right-3" />+ )}+ </div>+ ))}+ </div>++ <hr className="border-gray-200 my-2" />+ </>+ )}++ <div className="flex flex-wrap gap-4">+ {builtInTemplateList.map((template) => (+ <div+ key={template.id}+ className={`relative border border-gray-300 hover:bg-gray-100 rounded-lg px-6 py-4 transition-all cursor-pointer w-full sm:max-w-xs ${+ isSelected(template) ? "bg-gray-100" : "bg-transparent"+ }`}+ onClick={() => onSelectTemplate(template)}+ >+ <div className="text-left flex flex-col gap-y-2">+ <span className="text-base font-medium">+ {vueT(+ `sql-review.template.${template.id.split(".").join("-")}`+ )}+ </span>+ <p className="text-sm text-gray-500">+ {vueT(+ `sql-review.template.${template.id.split(".").join("-")}-desc`+ )}+ </p>+ <p className="text-sm">+ <span className="mr-2">+ {vueT("sql-review.enabled-rules")}:+ </span>+ <span>{template.ruleList.length}</span>+ </p>+ </div>+ {isSelected(template) && (+ <CheckCircle className="w-7 h-7 text-accent absolute top-3 right-3" />+ )}+ </div>+ ))}+ </div>+ </div>+ );+}diff --git a/frontend/src/react/locales/en-US.json b/frontend/src/react/locales/en-US.jsonindex 502ed67ac0..5ff913d0f8 100644--- a/frontend/src/react/locales/en-US.json+++ b/frontend/src/react/locales/en-US.json@@ -75,6 +75,7 @@"configure": "Configure","configure-now": "Configure now","confirm": "Confirm",+ "confirm-and-add": "Confirm and add","confirm-and-update": "Confirm and update","copied": "Copied","copy": "Copy",@@ -86,9 +87,12 @@"delete-resource": "Delete {{type}}","deleted": "Deleted","description": "Description",+ "disable": "Disable","discard-changes": "Discard changes","edit": "Edit","email": "Email",+ "enable": "Enable",+ "enabled": "Enabled","environment": "Environment","environment-name": "Environment Name","export": "Export",@@ -120,9 +124,11 @@"ok": "OK","operations": "Operations","permissions": "Permissions",+ "previous": "Previous","project": "Project","release": "Release","reorder": "Reorder",+ "resource": "Resource","required-permission": "Required permissions","required-workspace-permission": "Following permissions are required to initialize the workspace UX","restore": "Restore",@@ -916,7 +922,40 @@"self": "SQL Editor"},"sql-review": {+ "add-or-remove-rules": "Add or remove rules",+ "add-rules": "Add rules",+ "attach-resource": {+ "change-resources": "Change attached resources",+ "label": "You can apply the SQL review policy to environments or projects. The database will use the project-level policy if it exists, or fallback to the environment-level policy.",+ "no-linked-resources": "No attached resources",+ "self": "Attach to resources"+ },"configure-policy": "Configure policy",+ "create": {+ "basic-info": {+ "display-name": "Display name",+ "display-name-default": "SQL review policy",+ "display-name-label": "A display name to help identifying among different review policies.",+ "name": "Basic info"+ },+ "configure-rule": {+ "change-template": "Change the template",+ "confirm-override-description": "Your rules will be overridden",+ "name": "Configure rule"+ }+ },+ "create-policy": "Create SQL review",+ "delete": "Delete SQL review policy",+ "description": "SQL review policy can define different set of SQL lint rules for the respective environments. It helps teams to adopt SQL best practice and enforce schema consistency across different databases. Whenever you attempt a DDL/DML change or use SQL Editor to query data, the query will be checked against the configured SQL review policy.",+ "disabled": "SQL review is disabled",+ "enabled-rules": "Enabled rules",+ "no-permission": "Only DBA or Admin has permission to create or update review policy.",+ "policy-create-failed": "Failed to create the review policy.",+ "policy-created": "Successfully created the review policy.",+ "policy-removed": "Successfully removed the review policy.",+ "policy-update-failed": "Failed to update the review policy.",+ "policy-updated": "Successfully updated the review policy.",+ "review-policy": "Review policy","title": "SQL Review"},"subscription": {diff --git a/frontend/src/react/locales/es-ES.json b/frontend/src/react/locales/es-ES.jsonindex 2abc5a3d8a..311c7d39d6 100644--- a/frontend/src/react/locales/es-ES.json+++ b/frontend/src/react/locales/es-ES.json@@ -75,6 +75,7 @@"configure": "Configurar","configure-now": "Configurar ahora","confirm": "Confirmar",+ "confirm-and-add": "Confirm and add","confirm-and-update": "Confirmar y actualizar","copied": "Copiado","copy": "Copiar",@@ -86,9 +87,12 @@"delete-resource": "Delete {{type}}","deleted": "Eliminado","description": "Descripción",+ "disable": "Disable","discard-changes": "Descartar cambios","edit": "Editar","email": "Correo electrónico",+ "enable": "Enable",+ "enabled": "Enabled","environment": "Entorno","environment-name": "Nombre del entorno","export": "Exportar",@@ -120,9 +124,11 @@"ok": "OK","operations": "Operaciones","permissions": "Permisos",+ "previous": "Previous","project": "Proyecto","release": "Versión","reorder": "Reordenar",+ "resource": "Resource","required-permission": "Permisos necesarios","required-workspace-permission": "Se requieren los siguientes permisos para inicializar el espacio de trabajo UX","restore": "Restaurar",@@ -916,8 +922,41 @@"self": "Editor de SQL"},"sql-review": {- "configure-policy": "Configurar política",- "title": "Revisión de SQL"+ "add-or-remove-rules": "Add or remove rules",+ "add-rules": "Add rules",+ "attach-resource": {+ "change-resources": "Change attached resources",+ "label": "You can apply the SQL review policy to environments or projects. The database will use the project-level policy if it exists, or fallback to the environment-level policy.",+ "no-linked-resources": "No attached resources",+ "self": "Attach to resources"+ },+ "configure-policy": "Configure policy",+ "create": {+ "basic-info": {+ "display-name": "Display name",+ "display-name-default": "SQL review policy",+ "display-name-label": "A display name to help identifying among different review policies.",+ "name": "Basic info"+ },+ "configure-rule": {+ "change-template": "Change the template",+ "confirm-override-description": "Your rules will be overridden",+ "name": "Configure rule"+ }+ },+ "create-policy": "Create SQL review",+ "delete": "Delete SQL review policy",+ "description": "SQL review policy can define different set of SQL lint rules for the respective environments. It helps teams to adopt SQL best practice and enforce schema consistency across different databases. Whenever you attempt a DDL/DML change or use SQL Editor to query data, the query will be checked against the configured SQL review policy.",+ "disabled": "SQL review is disabled",+ "enabled-rules": "Enabled rules",+ "no-permission": "Only DBA or Admin has permission to create or update review policy.",+ "policy-create-failed": "Failed to create the review policy.",+ "policy-created": "Successfully created the review policy.",+ "policy-removed": "Successfully removed the review policy.",+ "policy-update-failed": "Failed to update the review policy.",+ "policy-updated": "Successfully updated the review policy.",+ "review-policy": "Review policy",+ "title": "SQL Review"},"subscription": {"contact-us": "Contáctenos",diff --git a/frontend/src/react/locales/ja-JP.json b/frontend/src/react/locales/ja-JP.jsonindex fc96742c65..47f7642cfa 100644--- a/frontend/src/react/locales/ja-JP.json+++ b/frontend/src/react/locales/ja-JP.json@@ -75,6 +75,7 @@"configure": "設定","configure-now": "今すぐ設定する","confirm": "確認する",+ "confirm-and-add": "Confirm and add","confirm-and-update": "確認して更新する","copied": "コピーされました","copy": "コピー",@@ -86,9 +87,12 @@"delete-resource": "Delete {{type}}","deleted": "削除されました","description": "説明",+ "disable": "Disable","discard-changes": "変更をキャンセルする","edit": "編集","email": "メールアドレス",+ "enable": "Enable",+ "enabled": "Enabled","environment": "環境","environment-name": "環境名","export": "エクスポート",@@ -120,9 +124,11 @@"ok": "わかりました","operations": "操作","permissions": "権限",+ "previous": "Previous","project": "プロジェクト","release": "リリース","reorder": "並び替え",+ "resource": "Resource","required-permission": "必要な権限","required-workspace-permission": "ワークスペース UX の初期化には以下の権限が必要です","restore": "復元する",@@ -916,8 +922,41 @@"self": "SQLエディタ"},"sql-review": {- "configure-policy": "SQL レビューポリシーを設定する",- "title": "SQL レビューポリシー"+ "add-or-remove-rules": "Add or remove rules",+ "add-rules": "Add rules",+ "attach-resource": {+ "change-resources": "Change attached resources",+ "label": "You can apply the SQL review policy to environments or projects. The database will use the project-level policy if it exists, or fallback to the environment-level policy.",+ "no-linked-resources": "No attached resources",+ "self": "Attach to resources"+ },+ "configure-policy": "Configure policy",+ "create": {+ "basic-info": {+ "display-name": "Display name",+ "display-name-default": "SQL review policy",+ "display-name-label": "A display name to help identifying among different review policies.",+ "name": "Basic info"+ },+ "configure-rule": {+ "change-template": "Change the template",+ "confirm-override-description": "Your rules will be overridden",+ "name": "Configure rule"+ }+ },+ "create-policy": "Create SQL review",+ "delete": "Delete SQL review policy",+ "description": "SQL review policy can define different set of SQL lint rules for the respective environments. It helps teams to adopt SQL best practice and enforce schema consistency across different databases. Whenever you attempt a DDL/DML change or use SQL Editor to query data, the query will be checked against the configured SQL review policy.",+ "disabled": "SQL review is disabled",+ "enabled-rules": "Enabled rules",+ "no-permission": "Only DBA or Admin has permission to create or update review policy.",+ "policy-create-failed": "Failed to create the review policy.",+ "policy-created": "Successfully created the review policy.",+ "policy-removed": "Successfully removed the review policy.",+ "policy-update-failed": "Failed to update the review policy.",+ "policy-updated": "Successfully updated the review policy.",+ "review-policy": "Review policy",+ "title": "SQL Review"},"subscription": {"contact-us": "お問い合わせ",diff --git a/frontend/src/react/locales/vi-VN.json b/frontend/src/react/locales/vi-VN.jsonindex 487b0b9682..ec0e200c1f 100644--- a/frontend/src/react/locales/vi-VN.json+++ b/frontend/src/react/locales/vi-VN.json@@ -75,6 +75,7 @@"configure": "Cấu hình","configure-now": "Cấu hình ngay","confirm": "Xác nhận",+ "confirm-and-add": "Confirm and add","confirm-and-update": "Xác nhận và Cập nhật","copied": "Đã sao chép","copy": "Sao chép",@@ -86,9 +87,12 @@"delete-resource": "Delete {{type}}","deleted": "Đã xóa","description": "Mô tả",+ "disable": "Disable","discard-changes": "Hủy thay đổi","edit": "Chỉnh sửa","email": "Email",+ "enable": "Enable",+ "enabled": "Enabled","environment": "Môi trường","environment-name": "Tên môi trường","export": "Xuất",@@ -120,9 +124,11 @@"ok": "OK","operations": "Các thao tác","permissions": "Quyền",+ "previous": "Previous","project": "Dự án","release": "Phiên bản","reorder": "Sắp xếp lại",+ "resource": "Resource","required-permission": "Quyền hạn cần thiết","required-workspace-permission": "Các quyền sau đây cần thiết để khởi tạo không gian làm việc UX","restore": "Khôi phục",@@ -916,8 +922,41 @@"self": "Trình soạn thảo SQL"},"sql-review": {- "configure-policy": "Định cấu hình chính sách",- "title": "Đánh giá SQL"+ "add-or-remove-rules": "Add or remove rules",+ "add-rules": "Add rules",+ "attach-resource": {+ "change-resources": "Change attached resources",+ "label": "You can apply the SQL review policy to environments or projects. The database will use the project-level policy if it exists, or fallback to the environment-level policy.",+ "no-linked-resources": "No attached resources",+ "self": "Attach to resources"+ },+ "configure-policy": "Configure policy",+ "create": {+ "basic-info": {+ "display-name": "Display name",+ "display-name-default": "SQL review policy",+ "display-name-label": "A display name to help identifying among different review policies.",+ "name": "Basic info"+ },+ "configure-rule": {+ "change-template": "Change the template",+ "confirm-override-description": "Your rules will be overridden",+ "name": "Configure rule"+ }+ },+ "create-policy": "Create SQL review",+ "delete": "Delete SQL review policy",+ "description": "SQL review policy can define different set of SQL lint rules for the respective environments. It helps teams to adopt SQL best practice and enforce schema consistency across different databases. Whenever you attempt a DDL/DML change or use SQL Editor to query data, the query will be checked against the configured SQL review policy.",+ "disabled": "SQL review is disabled",+ "enabled-rules": "Enabled rules",+ "no-permission": "Only DBA or Admin has permission to create or update review policy.",+ "policy-create-failed": "Failed to create the review policy.",+ "policy-created": "Successfully created the review policy.",+ "policy-removed": "Successfully removed the review policy.",+ "policy-update-failed": "Failed to update the review policy.",+ "policy-updated": "Successfully updated the review policy.",+ "review-policy": "Review policy",+ "title": "SQL Review"},"subscription": {"contact-us": "Liên hệ chúng tôi",diff --git a/frontend/src/react/locales/zh-CN.json b/frontend/src/react/locales/zh-CN.jsonindex 5798421d94..64b169b224 100644--- a/frontend/src/react/locales/zh-CN.json+++ b/frontend/src/react/locales/zh-CN.json@@ -75,6 +75,7 @@"configure": "配置","configure-now": "现在配置","confirm": "确认",+ "confirm-and-add": "确认并添加","confirm-and-update": "确认并更新","copied": "已拷贝","copy": "拷贝",@@ -86,9 +87,12 @@"delete-resource": "删除{{type}}","deleted": "已删除","description": "描述",+ "disable": "禁用","discard-changes": "取消修改","edit": "编辑","email": "邮箱",+ "enable": "Enable",+ "enabled": "开启","environment": "环境","environment-name": "环境名","export": "导出",@@ -120,9 +124,11 @@"ok": "OK","operations": "操作","permissions": "权限",+ "previous": "上一步","project": "项目","release": "版本","reorder": "排序",+ "resource": "资源","required-permission": "所需权限","required-workspace-permission": "初始化工作空间 UX 需要以下权限","restore": "恢复",@@ -916,7 +922,40 @@"self": "SQL 编辑器"},"sql-review": {+ "add-or-remove-rules": "添加或删除规则",+ "add-rules": "添加规则",+ "attach-resource": {+ "change-resources": "更改绑定的资源",+ "label": "审核策略需要绑定到环境资源或项目资源上,并影响对应资源下所有数据库。若一个数据库同时受到项目级别与环境级别策略影响,则只有项目级别策略生效。",+ "no-linked-resources": "没有绑定的资源",+ "self": "绑定到资源"+ },"configure-policy": "配置审核策略",+ "create": {+ "basic-info": {+ "display-name": "名称",+ "display-name-default": "SQL 审核策略",+ "display-name-label": "用以区分不同审核策略的名称。",+ "name": "基本信息"+ },+ "configure-rule": {+ "change-template": "更改模板",+ "confirm-override-description": "之前的规则将会被覆盖",+ "name": "配置规则"+ }+ },+ "create-policy": "创建审核策略",+ "delete": "删除审核策略",+ "description": "SQL 审核策略可以为不同的环境定义不同的 SQL lint 规则集. 它可以帮助团队采用 SQL 最佳使用实践,并在不同的数据库上约束 schema 的一致性。每当您尝试做一个 DDL/DML 变更或者使用 SQL 编辑器来查询数据时, 配置的 SQL 审核规则就会检查相应的执行语句。",+ "disabled": "SQL 审核策略已禁用",+ "enabled-rules": "开启的规则数",+ "no-permission": "仅管理员或 DBA 有权限创建或更新审核策略。",+ "policy-create-failed": "审核策略创建失败",+ "policy-created": "审核策略已创建",+ "policy-removed": "审核策略已删除",+ "policy-update-failed": "审核策略更新失败",+ "policy-updated": "审核策略已更新",+ "review-policy": "审核策略","title": "SQL 审核策略"},"subscription": {diff --git a/frontend/src/react/pages/settings/SQLReviewCreatePage.tsx b/frontend/src/react/pages/settings/SQLReviewCreatePage.tsxnew file mode 100644index 0000000000..5f26be6a65--- /dev/null+++ b/frontend/src/react/pages/settings/SQLReviewCreatePage.tsx@@ -0,0 +1,26 @@+import { useEffect, useState } from "react";+import { useSQLReviewStore } from "@/store";+import { ReviewCreation } from "../../components/sql-review/ReviewCreation";++export function SQLReviewCreatePage() {+ const sqlReviewStore = useSQLReviewStore();++ useEffect(() => {+ sqlReviewStore.fetchReviewPolicyList();+ }, [sqlReviewStore]);++ const [selectedResources] = useState(() => {+ const url = new URL(window.location.href);+ const resource = url.searchParams.get("attachedResource") ?? "";+ return resource ? [resource] : [];+ });++ return (+ <div className="px-4 py-4 gap-y-4 h-full flex flex-col">+ <ReviewCreation+ selectedRuleList={[]}+ selectedResources={selectedResources}+ />+ </div>+ );+}diff --git a/frontend/src/react/pages/settings/SQLReviewDetailPage.tsx b/frontend/src/react/pages/settings/SQLReviewDetailPage.tsxnew file mode 100644index 0000000000..cc5658fb90--- /dev/null+++ b/frontend/src/react/pages/settings/SQLReviewDetailPage.tsx@@ -0,0 +1,428 @@+import { Trash2 } from "lucide-react";+import { useCallback, useEffect, useMemo, useState } from "react";+import { useTranslation } from "react-i18next";+import { rulesToTemplate } from "@/components/SQLReview/components/utils";+import { AttachResourcesPanel } from "@/react/components/sql-review/Panels";+import { ResourceLink } from "@/react/components/sql-review/ResourceLink";+import { ReviewCreation } from "@/react/components/sql-review/ReviewCreation";+import { RuleTableWithFilter } from "@/react/components/sql-review/RuleTable";+import { TabsByEngine } from "@/react/components/sql-review/TabsByEngine";+import { Alert, AlertDescription } from "@/react/components/ui/alert";+import { Badge } from "@/react/components/ui/badge";+import { Button } from "@/react/components/ui/button";+import {+ Dialog,+ DialogContent,+ DialogTitle,+} from "@/react/components/ui/dialog";+import { Input } from "@/react/components/ui/input";+import { useVueState } from "@/react/hooks/useVueState";+import { router } from "@/router";+import { WORKSPACE_ROUTE_SQL_REVIEW } from "@/router/dashboard/workspaceRoutes";+import { pushNotification, useSQLReviewStore } from "@/store";+import type { RuleTemplateV2 } from "@/types";+import {+ convertRuleMapToPolicyRuleList,+ getRuleMapByEngine,+ isBuiltinRule,+ UNKNOWN_ID,+ withBuiltinRules,+} from "@/types";+import type { Engine } from "@/types/proto-es/v1/common_pb";+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";+import {+ hasWorkspacePermissionV2,+ setDocumentTitle,+ sqlReviewNameFromSlug,+} from "@/utils";++// ============================================================+// SQLReviewDetailPage+// ============================================================++export function SQLReviewDetailPage({+ sqlReviewPolicySlug,+}: {+ sqlReviewPolicySlug: string;+}) {+ const { t } = useTranslation();+ const store = useSQLReviewStore();++ const sqlReviewName = useMemo(+ () => sqlReviewNameFromSlug(sqlReviewPolicySlug),+ [sqlReviewPolicySlug]+ );++ // Fetch policy+ useEffect(() => {+ store.getOrFetchReviewPolicyByName(sqlReviewName, false);+ }, [store, sqlReviewName]);++ const reviewPolicy = useVueState(+ () =>+ store.getReviewPolicyByName(sqlReviewName) ?? {+ id: `${UNKNOWN_ID}`,+ enforce: false,+ name: "",+ ruleList: [],+ resources: [],+ }+ );++ // Set document title+ useEffect(() => {+ if (reviewPolicy.name) {+ setDocumentTitle(reviewPolicy.name);+ }+ }, [reviewPolicy.name]);++ const ruleListOfPolicy = useMemo((): RuleTemplateV2[] => {+ if (reviewPolicy.id === `${UNKNOWN_ID}`) return [];+ return rulesToTemplate(reviewPolicy).ruleList;+ }, [reviewPolicy]);++ // State+ const [editMode, setEditMode] = useState(false);+ const [editingTitle, setEditingTitle] = useState(false);+ const [showDisableModal, setShowDisableModal] = useState(false);+ const [showEnableModal, setShowEnableModal] = useState(false);+ const [showResourcePanel, setShowResourcePanel] = useState(false);+ const [showDeleteConfirm, setShowDeleteConfirm] = useState(false);+ const [rulesUpdated, setRulesUpdated] = useState(false);+ const [ruleMapByEngine, setRuleMapByEngine] = useState<+ Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>+ >(new Map());++ // Sync rule map when policy changes+ useEffect(() => {+ setRuleMapByEngine(withBuiltinRules(getRuleMapByEngine(ruleListOfPolicy)));+ setRulesUpdated(false);+ }, [ruleListOfPolicy]);++ // Check if attachResourcePanel query param is set+ useEffect(() => {+ const url = new URL(window.location.href);+ if (+ url.searchParams.get("attachResourcePanel") &&+ hasWorkspacePermissionV2("bb.policies.update")+ ) {+ setShowResourcePanel(true);+ }+ }, []);++ const hasUpdatePermission = hasWorkspacePermissionV2(+ "bb.reviewConfigs.update"+ );+ const hasDeletePermission = hasWorkspacePermissionV2(+ "bb.reviewConfigs.delete"+ );++ const pushUpdatedNotify = useCallback(() => {+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: t("sql-review.policy-updated"),+ });+ }, [t]);++ const changeName = useCallback(+ async (title: string) => {+ setEditingTitle(false);+ if (title === reviewPolicy.name || !title.trim()) return;+ await store.upsertReviewPolicy({ id: reviewPolicy.id, title });+ pushUpdatedNotify();+ },+ [store, reviewPolicy.id, reviewPolicy.name, pushUpdatedNotify]+ );++ const markChange = useCallback(+ (rule: RuleTemplateV2, overrides: Partial<RuleTemplateV2>) => {+ setRuleMapByEngine((prev) => {+ const newMap = new Map(prev);+ const engineMap = new Map(newMap.get(rule.engine) || new Map());+ const existing = engineMap.get(rule.type);+ if (!existing) return prev;+ engineMap.set(rule.type, { ...existing, ...overrides });+ newMap.set(rule.engine, engineMap);+ return newMap;+ });+ setRulesUpdated(true);+ },+ []+ );++ const removeRule = useCallback((rule: RuleTemplateV2) => {+ if (isBuiltinRule(rule)) return;+ setRuleMapByEngine((prev) => {+ const newMap = new Map(prev);+ const engineMap = new Map(newMap.get(rule.engine) || new Map());+ engineMap.delete(rule.type);+ if (engineMap.size === 0) newMap.delete(rule.engine);+ else newMap.set(rule.engine, engineMap);+ return newMap;+ });+ setRulesUpdated(true);+ }, []);++ const onCancelChanges = useCallback(() => {+ setRuleMapByEngine(withBuiltinRules(getRuleMapByEngine(ruleListOfPolicy)));+ setRulesUpdated(false);+ }, [ruleListOfPolicy]);++ const onApplyChanges = useCallback(async () => {+ await store.upsertReviewPolicy({+ id: reviewPolicy.id,+ title: reviewPolicy.name,+ ruleList: convertRuleMapToPolicyRuleList(ruleMapByEngine),+ });+ setRulesUpdated(false);+ pushUpdatedNotify();+ }, [+ store,+ reviewPolicy.id,+ reviewPolicy.name,+ ruleMapByEngine,+ pushUpdatedNotify,+ ]);++ const onArchive = useCallback(async () => {+ await store.upsertReviewPolicy({ id: reviewPolicy.id, enforce: false });+ setShowDisableModal(false);+ pushUpdatedNotify();+ }, [store, reviewPolicy.id, pushUpdatedNotify]);++ const onRestore = useCallback(async () => {+ await store.upsertReviewPolicy({ id: reviewPolicy.id, enforce: true });+ setShowEnableModal(false);+ pushUpdatedNotify();+ }, [store, reviewPolicy.id, pushUpdatedNotify]);++ const onRemove = useCallback(async () => {+ await store.removeReviewPolicy(reviewPolicy.id);+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: t("sql-review.policy-removed"),+ });+ router.replace({ name: WORKSPACE_ROUTE_SQL_REVIEW });+ }, [store, reviewPolicy.id, t]);++ // Edit mode: show the wizard+ if (editMode) {+ return (+ <div className="px-4 py-4">+ <ReviewCreation+ policy={reviewPolicy}+ name={reviewPolicy.name}+ selectedRuleList={ruleListOfPolicy}+ selectedResources={reviewPolicy.resources}+ onCancel={() => setEditMode(false)}+ />+ </div>+ );+ }++ return (+ <div className="px-4 py-4">+ {/* Disabled warning */}+ {!reviewPolicy.enforce && (+ <Alert variant="warning" className="mb-4">+ <AlertDescription>{t("sql-review.disabled")}</AlertDescription>+ </Alert>+ )}++ {/* Header: title + actions */}+ <div className="flex flex-col gap-y-2 items-start md:items-center gap-x-2 justify-center md:flex-row">+ {editingTitle ? (+ <Input+ className="flex-1 text-xl font-bold"+ defaultValue={reviewPolicy.name}+ autoFocus+ onBlur={(e) => changeName(e.target.value)}+ onKeyDown={(e) => {+ if (e.key === "Enter")+ changeName((e.target as HTMLInputElement).value);+ }}+ />+ ) : (+ <h1+ className="flex-1 text-xl font-bold truncate cursor-text px-0.5"+ onClick={() => {+ if (hasUpdatePermission) {+ setEditingTitle(true);+ }+ }}+ >+ {reviewPolicy.name}+ </h1>+ )}+ <div className="flex gap-x-2">+ {reviewPolicy.enforce ? (+ <Button+ variant="outline"+ disabled={!hasUpdatePermission}+ onClick={() => setShowDisableModal(true)}+ >+ {t("common.disable")}+ </Button>+ ) : (+ <Button+ variant="outline"+ disabled={!hasUpdatePermission}+ onClick={() => setShowEnableModal(true)}+ >+ {t("common.enable")}+ </Button>+ )}+ <Button+ variant="outline"+ disabled={!hasWorkspacePermissionV2("bb.policies.update")}+ onClick={() => setShowResourcePanel(true)}+ >+ {t("sql-review.attach-resource.change-resources")}+ </Button>+ <Button+ disabled={!hasUpdatePermission}+ onClick={() => setEditMode(true)}+ >+ {t("sql-review.create.configure-rule.change-template")}+ </Button>+ </div>+ </div>++ {/* Attached resources */}+ <div className="mt-4 flex flex-col gap-y-4">+ {reviewPolicy.resources.length === 0 && (+ <Alert variant="warning">+ <AlertDescription>+ <div className="flex items-center justify-between">+ <div>+ <p className="font-medium">+ {t("sql-review.attach-resource.no-linked-resources")}+ </p>+ <p className="text-sm mt-1">+ {t("sql-review.attach-resource.label")}+ </p>+ </div>+ <Button+ variant="outline"+ size="sm"+ onClick={() => setShowResourcePanel(true)}+ >+ {t("sql-review.attach-resource.self")}+ </Button>+ </div>+ </AlertDescription>+ </Alert>+ )}+ <div className="flex flex-wrap gap-y-2 gap-x-2">+ {reviewPolicy.resources.map((resource) => (+ <Badge key={resource} variant="default">+ <ResourceLink resource={resource} />+ </Badge>+ ))}+ </div>+ </div>++ {/* Rules by engine */}+ <div className="mt-5">+ <TabsByEngine ruleMapByEngine={ruleMapByEngine}>+ {(ruleList, engine) => (+ <RuleTableWithFilter+ engine={engine}+ ruleList={ruleList}+ editable={hasUpdatePermission}+ onRuleUpsert={markChange}+ onRuleRemove={removeRule}+ />+ )}+ </TabsByEngine>+ </div>++ {/* Delete button */}+ <hr className="my-6" />+ <Button+ variant="destructive"+ disabled={!hasDeletePermission}+ onClick={() => setShowDeleteConfirm(true)}+ >+ <Trash2 className="w-4 h-4 mr-1" />+ {t("sql-review.delete")}+ </Button>++ {/* Sticky save bar when rules changed */}+ {rulesUpdated && (+ <div className="w-full mt-4 py-2 border-t border-control-border flex justify-between bg-white sticky bottom-0 z-10">+ <Button variant="outline" onClick={onCancelChanges}>+ {t("common.cancel")}+ </Button>+ <Button onClick={onApplyChanges}>+ {t("common.confirm-and-update")}+ </Button>+ </div>+ )}++ {/* Disable confirmation dialog */}+ <Dialog open={showDisableModal} onOpenChange={setShowDisableModal}>+ <DialogContent>+ <DialogTitle>+ {t("common.disable")} '{reviewPolicy.name}'?+ </DialogTitle>+ <div className="flex justify-end gap-x-2 mt-4">+ <Button+ variant="outline"+ onClick={() => setShowDisableModal(false)}+ >+ {t("common.cancel")}+ </Button>+ <Button variant="destructive" onClick={onArchive}>+ {t("common.disable")}+ </Button>+ </div>+ </DialogContent>+ </Dialog>++ {/* Enable confirmation dialog */}+ <Dialog open={showEnableModal} onOpenChange={setShowEnableModal}>+ <DialogContent>+ <DialogTitle>+ {t("common.enable")} '{reviewPolicy.name}'?+ </DialogTitle>+ <div className="flex justify-end gap-x-2 mt-4">+ <Button variant="outline" onClick={() => setShowEnableModal(false)}>+ {t("common.cancel")}+ </Button>+ <Button onClick={onRestore}>{t("common.enable")}</Button>+ </div>+ </DialogContent>+ </Dialog>++ {/* Delete confirmation dialog */}+ <Dialog open={showDeleteConfirm} onOpenChange={setShowDeleteConfirm}>+ <DialogContent>+ <DialogTitle>+ {t("common.delete")} '{reviewPolicy.name}'?+ </DialogTitle>+ <div className="flex justify-end gap-x-2 mt-4">+ <Button+ variant="outline"+ onClick={() => setShowDeleteConfirm(false)}+ >+ {t("common.cancel")}+ </Button>+ <Button variant="destructive" onClick={onRemove}>+ {t("common.delete")}+ </Button>+ </div>+ </DialogContent>+ </Dialog>++ {/* Attach resources panel */}+ <AttachResourcesPanel+ show={showResourcePanel}+ review={reviewPolicy}+ onClose={() => setShowResourcePanel(false)}+ />+ </div>+ );+}diff --git a/frontend/src/react/pages/settings/SQLReviewPage.tsx b/frontend/src/react/pages/settings/SQLReviewPage.tsxnew file mode 100644index 0000000000..0cad81863c--- /dev/null+++ b/frontend/src/react/pages/settings/SQLReviewPage.tsx@@ -0,0 +1,353 @@+import {+ Check,+ ExternalLink,+ Pencil,+ Plus,+ Search,+ Trash2,+ X,+} from "lucide-react";+import { useCallback, useEffect, useMemo, useState } from "react";+import { useTranslation } from "react-i18next";+import { ResourceLink } from "@/react/components/sql-review/ResourceLink";+import { Badge } from "@/react/components/ui/badge";+import { Button } from "@/react/components/ui/button";+import { Input } from "@/react/components/ui/input";+import { Tooltip } from "@/react/components/ui/tooltip";+import { useVueState } from "@/react/hooks/useVueState";+import { router } from "@/router";+import {+ WORKSPACE_ROUTE_SQL_REVIEW_CREATE,+ WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,+} from "@/router/dashboard/workspaceRoutes";+import { pushNotification, useSQLReviewStore } from "@/store";+import type { SQLReviewPolicy } from "@/types";+import { hasWorkspacePermissionV2, sqlReviewPolicySlug } from "@/utils";++// ============================================================+// PolicyTable+// ============================================================++function PolicyTable({+ policies,+ searchText,+ onDelete,+}: {+ policies: SQLReviewPolicy[];+ searchText: string;+ onDelete: (policy: SQLReviewPolicy) => void;+}) {+ const { t } = useTranslation();+ const sqlReviewStore = useSQLReviewStore();++ const hasUpdatePermission = hasWorkspacePermissionV2(+ "bb.reviewConfigs.update"+ );+ const hasDeletePermission = hasWorkspacePermissionV2(+ "bb.reviewConfigs.delete"+ );++ const navigateToDetail = useCallback((policy: SQLReviewPolicy) => {+ router.push({+ name: WORKSPACE_ROUTE_SQL_REVIEW_DETAIL,+ params: { sqlReviewPolicySlug: sqlReviewPolicySlug(policy) },+ });+ }, []);++ const toggleEnabled = useCallback(+ async (policy: SQLReviewPolicy, enabled: boolean) => {+ await sqlReviewStore.upsertReviewPolicy({+ id: policy.id,+ enforce: enabled,+ });+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: t("common.updated"),+ });+ },+ [sqlReviewStore, t]+ );++ const highlight = useCallback(+ (text: string) => {+ if (!searchText) return text;+ const regex = new RegExp(+ `(${searchText.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")})`,+ "gi"+ );+ const parts = text.split(regex);+ return parts.map((part, i) =>+ regex.test(part) ? (+ <mark key={i} className="bg-yellow-100">+ {part}+ </mark>+ ) : (+ part+ )+ );+ },+ [searchText]+ );++ const [confirmingDelete, setConfirmingDelete] = useState<string | null>(null);++ return (+ <>+ {/* Desktop table */}+ <div className="hidden lg:block border rounded-sm overflow-hidden">+ <table className="w-full text-sm">+ <thead>+ <tr className="border-b bg-control-bg">+ <th className="px-4 py-2 text-left font-medium whitespace-nowrap w-[200px]">+ {t("common.name")}+ </th>+ <th className="px-4 py-2 text-left font-medium whitespace-nowrap w-[250px]">+ {t("common.resource")}+ </th>+ <th className="px-4 py-2 text-left font-medium whitespace-nowrap">+ {t("sql-review.enabled-rules")}+ </th>+ <th className="px-4 py-2 text-left font-medium whitespace-nowrap capitalize w-[7rem]">+ {t("common.enabled")}+ </th>+ <th className="px-4 py-2 text-left font-medium whitespace-nowrap w-[10rem]">+ {t("common.operations")}+ </th>+ </tr>+ </thead>+ <tbody>+ {policies.map((policy, i) => (+ <tr+ key={policy.id}+ className={`border-b last:border-b-0 ${i % 2 === 1 ? "bg-gray-50" : ""}`}+ >+ <td className="px-4 py-2">{highlight(policy.name)}</td>+ <td className="px-4 py-2">+ <div className="flex flex-wrap gap-2">+ {policy.resources.length === 0 && <span>-</span>}+ {policy.resources.map((resource) => (+ <Badge key={resource} variant="default">+ <ResourceLink resource={resource} />+ </Badge>+ ))}+ </div>+ </td>+ <td className="px-4 py-2">{policy.ruleList.length}</td>+ <td className="px-4 py-2">+ {hasUpdatePermission ? (+ <input+ type="checkbox"+ checked={policy.enforce}+ onChange={(e) => toggleEnabled(policy, e.target.checked)}+ className="h-4 w-4 rounded border-control-border accent-accent"+ />+ ) : policy.enforce ? (+ <Check className="w-4 h-4 text-control-light" />+ ) : (+ <X className="w-4 h-4 text-control-light" />+ )}+ </td>+ <td className="px-4 py-2">+ <div className="flex items-center gap-x-2">+ {hasDeletePermission &&+ (confirmingDelete === policy.id ? (+ <div className="flex items-center gap-x-1 text-xs">+ <span>+ {t("common.delete")} '{policy.name}'?+ </span>+ <Button+ variant="destructive"+ size="sm"+ onClick={() => {+ onDelete(policy);+ setConfirmingDelete(null);+ }}+ >+ {t("common.delete")}+ </Button>+ <Button+ variant="outline"+ size="sm"+ onClick={() => setConfirmingDelete(null)}+ >+ {t("common.cancel")}+ </Button>+ </div>+ ) : (+ <Tooltip content={t("common.delete")}>+ <Button+ variant="ghost"+ size="icon"+ className="h-7 w-7 text-error hover:text-error"+ onClick={() => setConfirmingDelete(policy.id)}+ >+ <Trash2 className="w-4 h-4" />+ </Button>+ </Tooltip>+ ))}+ <Tooltip+ content={+ hasUpdatePermission+ ? t("common.edit")+ : t("common.view")+ }+ >+ <Button+ variant="ghost"+ size="icon"+ className="h-7 w-7"+ onClick={() => navigateToDetail(policy)}+ >+ <Pencil className="w-4 h-4" />+ </Button>+ </Tooltip>+ </div>+ </td>+ </tr>+ ))}+ </tbody>+ </table>+ </div>++ {/* Mobile card layout */}+ <div className="flex flex-col lg:hidden border px-2 divide-y divide-block-border">+ {policies.map((policy) => (+ <div key={policy.id} className="py-4">+ <div className="text-md">{policy.name}</div>+ <div className="flex flex-wrap mt-2 gap-2">+ {policy.resources.map((resource) => (+ <Badge key={resource} variant="default" className="text-xs">+ <ResourceLink resource={resource} />+ </Badge>+ ))}+ {!policy.enforce && (+ <Badge variant="warning">{t("common.disable")}</Badge>+ )}+ </div>+ <div className="flex items-center gap-x-2 mt-4">+ <Button+ variant="outline"+ size="sm"+ onClick={() => navigateToDetail(policy)}+ >+ {hasUpdatePermission ? t("common.edit") : t("common.view")}+ </Button>+ {hasDeletePermission && (+ <Button+ variant="destructive"+ size="sm"+ onClick={() => {+ if (+ window.confirm(`${t("common.delete")} '${policy.name}'?`)+ ) {+ onDelete(policy);+ }+ }}+ >+ {t("common.delete")}+ </Button>+ )}+ </div>+ </div>+ ))}+ </div>+ </>+ );+}++// ============================================================+// SQLReviewPage (exported)+// ============================================================++export function SQLReviewPage() {+ const { t } = useTranslation();+ const sqlReviewStore = useSQLReviewStore();+ const [searchText, setSearchText] = useState("");++ useEffect(() => {+ sqlReviewStore.fetchReviewPolicyList();+ }, [sqlReviewStore]);++ const policyList = useVueState(() => [...sqlReviewStore.reviewPolicyList]);++ const filteredList = useMemo(() => {+ if (!searchText) return policyList;+ const lower = searchText.toLowerCase();+ return policyList.filter((p) => p.name.toLowerCase().includes(lower));+ }, [policyList, searchText]);++ const hasCreatePermission = hasWorkspacePermissionV2(+ "bb.reviewConfigs.create"+ );++ const navigateToCreate = useCallback(() => {+ router.push({ name: WORKSPACE_ROUTE_SQL_REVIEW_CREATE });+ }, []);++ const handleDelete = useCallback(+ async (policy: SQLReviewPolicy) => {+ await sqlReviewStore.removeReviewPolicy(policy.id);+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: t("sql-review.policy-removed"),+ });+ },+ [sqlReviewStore, t]+ );++ return (+ <div className="px-4 py-4 mx-auto flex flex-col gap-y-4">+ <div className="textinfolabel">+ {t("sql-review.description")}{" "}+ <a+ href="https://docs.bytebase.com/sql-review/review-rules?source=console"+ target="_blank"+ rel="noopener noreferrer"+ className="normal-link inline-flex items-center gap-x-1"+ >+ {t("common.learn-more")}+ <ExternalLink className="w-4 h-4" />+ </a>+ </div>++ <div className="flex justify-end items-center gap-x-2">+ <div className="relative max-w-full">+ <Search className="absolute left-2.5 top-1/2 -translate-y-1/2 w-4 h-4 text-control-light pointer-events-none" />+ <Input+ value={searchText}+ onChange={(e) => setSearchText(e.target.value)}+ placeholder={t("common.filter-by-name")}+ className="pl-8"+ autoFocus+ />+ </div>+ {hasCreatePermission && (+ <Button onClick={navigateToCreate}>+ <Plus className="w-4 h-4 mr-1" />+ {t("sql-review.create-policy")}+ </Button>+ )}+ </div>++ {policyList.length > 0 ? (+ <PolicyTable+ policies={filteredList}+ searchText={searchText}+ onDelete={handleDelete}+ />+ ) : (+ <div className="py-12 border rounded-sm flex flex-col items-center justify-center gap-y-3 text-control-light">+ <span>{t("common.no-data")}</span>+ {hasCreatePermission && (+ <Button size="sm" onClick={navigateToCreate}>+ <Plus className="w-4 h-4 mr-1" />+ {t("sql-review.create-policy")}+ </Button>+ )}+ </div>+ )}+ </div>+ );+}diff --git a/frontend/src/router/dashboard/workspace.ts b/frontend/src/router/dashboard/workspace.tsindex b070fd2295..7b0002d6b5 100644--- a/frontend/src/router/dashboard/workspace.ts+++ b/frontend/src/router/dashboard/workspace.ts@@ -180,8 +180,8 @@ const workspaceRoutes: RouteRecordRaw[] = ["bb.policies.get",],},- component: () => import("@/views/SettingWorkspaceSQLReview.vue"),- props: true,+ component: () => import("@/react/ReactPageMount.vue"),+ props: () => ({ page: "SQLReviewPage" }),},{path: "new",@@ -190,8 +190,8 @@ const workspaceRoutes: RouteRecordRaw[] = [title: () => t("sql-review.create.breadcrumb"),requiredPermissionList: () => ["bb.reviewConfigs.create"],},- component: () => import("@/views/SettingWorkspaceSQLReviewCreate.vue"),- props: true,+ component: () => import("@/react/ReactPageMount.vue"),+ props: () => ({ page: "SQLReviewCreatePage" }),},{path: ":sqlReviewPolicySlug",@@ -203,7 +203,7 @@ const workspaceRoutes: RouteRecordRaw[] = ["bb.policies.get",],},- component: () => import("@/views/SettingWorkspaceSQLReviewDetail.vue"),+ component: () => import("@/react/SQLReviewDetailPageMount.vue"),props: true,},],diff --git a/frontend/src/views/SettingWorkspaceSQLReview.vue b/frontend/src/views/SettingWorkspaceSQLReview.vuedeleted file mode 100644index e1ea4d8b45..0000000000--- a/frontend/src/views/SettingWorkspaceSQLReview.vue+++ /dev/null@@ -1,90 +0,0 @@-<template>- <div class="px-4 py-4 mx-auto flex flex-col gap-y-4">- <div class="textinfolabel">- {{ $t("sql-review.description") }}- <LearnMoreLink- url="https://docs.bytebase.com/sql-review/review-rules?source=console"- />- </div>-- <div class="flex justify-end items-center gap-x-2">- <SearchBox- v-model:value="searchText"- style="max-width: 100%"- :autofocus="true"- :placeholder="$t('common.filter-by-name')"- />- <NButton- v-if="hasCreatePolicyPermission"- type="primary"- @click="createSQLReview"- >- <template #icon>- <PlusIcon class="h-4 w-4" />- </template>- {{ $t("sql-review.create-policy") }}- </NButton>- </div>-- <SQLReviewPolicyTable- v-if="sqlReviewStore.reviewPolicyList.length > 0"- :review-list="filteredReviewConfigList"- :filter="searchText"- />- <NEmpty v-else class="py-12 border rounded-sm">- <template #extra>- <NButton- v-if="hasCreatePolicyPermission"- :size="'small'"- type="primary"- @click="createSQLReview"- >- <template #icon>- <PlusIcon class="h-4 w-4" />- </template>- {{ $t("sql-review.create-policy") }}- </NButton>- </template>- </NEmpty>- </div>-</template>--<script lang="ts" setup>-import { PlusIcon } from "lucide-vue-next";-import { NButton, NEmpty } from "naive-ui";-import { computed, ref, watchEffect } from "vue";-import { useRouter } from "vue-router";-import LearnMoreLink from "@/components/LearnMoreLink.vue";-import SQLReviewPolicyTable from "@/components/SQLReview/components/SQLReviewPolicyTable.vue";-import { SearchBox } from "@/components/v2";-import { WORKSPACE_ROUTE_SQL_REVIEW_CREATE } from "@/router/dashboard/workspaceRoutes";-import { useSQLReviewStore } from "@/store";-import { hasWorkspacePermissionV2 } from "@/utils";--const router = useRouter();-const sqlReviewStore = useSQLReviewStore();-const searchText = ref("");--watchEffect(() => {- sqlReviewStore.fetchReviewPolicyList();-});--const hasCreatePolicyPermission = computed(() => {- return hasWorkspacePermissionV2("bb.reviewConfigs.create");-});--const createSQLReview = () => {- router.push({- name: WORKSPACE_ROUTE_SQL_REVIEW_CREATE,- });-};--const filteredReviewConfigList = computed(() => {- if (!searchText.value) {- return sqlReviewStore.reviewPolicyList;- }- return sqlReviewStore.reviewPolicyList.filter((config) => {- return config.name.toLowerCase().includes(searchText.value.toLowerCase());- });-});-</script>diff --git a/frontend/src/views/SettingWorkspaceSQLReviewCreate.vue b/frontend/src/views/SettingWorkspaceSQLReviewCreate.vuedeleted file mode 100644index 576d4ffbde..0000000000--- a/frontend/src/views/SettingWorkspaceSQLReviewCreate.vue+++ /dev/null@@ -1,29 +0,0 @@-<template>- <div class="px-4 py-4 gap-y-4 h-full flex flex-col">- <SQLReviewCreation- class="flex-1"- :selected-rule-list="[]"- :selected-resources="attachedResources"- />- </div>-</template>--<script lang="ts" setup>-import { computed, watchEffect } from "vue";-import { SQLReviewCreation } from "@/components/SQLReview";-import { useSQLReviewStore } from "@/store";--const attachedResources = computed(() => {- const url = new URL(window.location.href);- const params = new URLSearchParams(url.search);- const resource = params.get("attachedResource") ?? "";- if (resource) {- return [resource];- }- return [];-});--watchEffect(async () => {- await useSQLReviewStore().fetchReviewPolicyList();-});-</script>diff --git a/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue b/frontend/src/views/SettingWorkspaceSQLReviewDetail.vuedeleted file mode 100644index 5e46dccdf1..0000000000--- a/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue+++ /dev/null@@ -1,421 +0,0 @@-<template>- <div class="px-4 py-4">- <SQLReviewCreation- v-if="state.editMode"- key="sql-review-creation"- class="mt-1"- :policy="reviewPolicy"- :name="reviewPolicy.name"- :selected-rule-list="ruleListOfPolicy"- :selected-resources="reviewPolicy.resources"- @cancel="state.editMode = false"- />- <div v-else>- <BBAttention v-if="!reviewPolicy.enforce" type="warning" class="mb-4">- {{ $t("sql-review.disabled") }}- </BBAttention>- <div- class="flex flex-col gap-y-2 items-start md:items-center gap-x-2 justify-center md:flex-row"- >- <BBTextField- class="flex-1 text-xl! pl-0! px-0.5 font-bold truncate sql-review-title"- :disabled="!hasUpdateReviwConfigPermission"- :required="true"- :focus-on-mount="false"- :ends-on-enter="true"- :bordered="state.editingTitle"- :value="reviewPolicy.name"- @on-focus="state.editingTitle = true"- @end-editing="changeName"- />- <div class="flex gap-x-2">- <PermissionGuardWrapper- v-slot="slotProps"- :permissions="[- 'bb.reviewConfigs.update'- ]"- >- <NButton- v-if="reviewPolicy.enforce"- :disabled="slotProps.disabled"- @click.prevent="state.showDisableModal = true"- >- {{ $t("common.disable") }}- </NButton>- <NButton- v-else- :disabled="slotProps.disabled"- @click.prevent="state.showEnableModal = true"- >- {{ $t("common.enable") }}- </NButton>- </PermissionGuardWrapper>- <PermissionGuardWrapper- v-slot="slotProps"- :permissions="[- 'bb.policies.update'- ]"- >- <NButton- :disabled="slotProps.disabled"- @click.prevent="state.showResourcePanel = true"- >- {{ $t("sql-review.attach-resource.change-resources") }}- </NButton>- </PermissionGuardWrapper>- <PermissionGuardWrapper- v-slot="slotProps"- :permissions="[- 'bb.reviewConfigs.update'- ]"- >- <NButton type="primary" :disabled="slotProps.disabled" @click="onEdit">- {{ $t("sql-review.create.configure-rule.change-template") }}- </NButton>- </PermissionGuardWrapper>- </div>- </div>- <div class="mt-4 flex flex-col gap-y-4">- <BBAttention- v-if="reviewPolicy.resources.length === 0"- type="warning"- :title="$t('sql-review.attach-resource.no-linked-resources')"- :description="$t('sql-review.attach-resource.label')"- :action-text="$t('sql-review.attach-resource.self')"- @click="state.showResourcePanel = true"- />- <div class="flex flex-wrap gap-y-2 gap-x-2">- <NTag- v-for="resource in reviewPolicy.resources"- :key="resource"- type="primary"- >- <Resource :resource="resource" :show-prefix="true" />- </NTag>- </div>- </div>-- <SQLReviewTabsByEngine- class="mt-5"- :rule-map-by-engine="state.ruleMapByEngine"- >- <template- #default="{ ruleList: ruleListFilteredByEngine, engine }: { ruleList: RuleTemplateV2[]; engine: Engine; }"- >- <SQLRuleTableWithFilter- :engine="engine"- :rule-list="ruleListFilteredByEngine"- :editable="hasUpdateReviwConfigPermission"- @rule-upsert="markChange"- @rule-remove="removeRule"- />- </template>- </SQLReviewTabsByEngine>--- <NDivider />- <BBButtonConfirm- :disabled="!hasDeleteReviwConfigPermission"- :type="'DELETE'"- :button-text="$t('sql-review.delete')"- :ok-text="$t('common.delete')"- :confirm-title="$t('common.delete') + ` '${reviewPolicy.name}'?`"- :require-confirm="true"- @confirm="onRemove"- />- <div- v-if="state.rulesUpdated"- class="w-full mt-4 py-2 border-t border-block-border flex justify-between bg-white sticky bottom-0 z-10"- >- <NButton @click.prevent="onCancelChanges">- <span> {{ $t("common.cancel") }}</span>- </NButton>- <NButton type="primary" @click.prevent="onApplyChanges">- {{ $t("common.confirm-and-update") }}- </NButton>- </div>- </div>- <BBAlert- v-model:show="state.showDisableModal"- type="warning"- :ok-text="$t('common.disable')"- :title="$t('common.disable') + ` '${reviewPolicy.name}'?`"- description=""- @ok="- () => {- state.showDisableModal = false;- onArchive();- }- "- @cancel="state.showDisableModal = false"- />- <BBAlert- v-model:show="state.showEnableModal"- type="info"- :ok-text="$t('common.enable')"- :title="$t('common.enable') + ` '${reviewPolicy.name}'?`"- description=""- @ok="- () => {- state.showEnableModal = false;- onRestore();- }- "- @cancel="state.showEnableModal = false"- />-- <SQLReviewAttachResourcesPanel- :show="state.showResourcePanel"- :review="reviewPolicy"- @close="state.showResourcePanel = false"- />- </div>-</template>--<script lang="tsx" setup>-import { NButton, NDivider, NTag } from "naive-ui";-import {- computed,- nextTick,- onMounted,- reactive,- watch,- watchEffect,-} from "vue";-import { useI18n } from "vue-i18n";-import { useRoute, useRouter } from "vue-router";-import { BBAlert, BBAttention, BBButtonConfirm, BBTextField } from "@/bbkit";-import PermissionGuardWrapper from "@/components/Permission/PermissionGuardWrapper.vue";-import { SQLReviewCreation } from "@/components/SQLReview";-import SQLReviewAttachResourcesPanel from "@/components/SQLReview/components/SQLReviewAttachResourcesPanel.vue";-import SQLReviewTabsByEngine from "@/components/SQLReview/components/SQLReviewTabsByEngine.vue";-import SQLRuleTableWithFilter from "@/components/SQLReview/components/SQLRuleTableWithFilter.vue";-import { rulesToTemplate } from "@/components/SQLReview/components/utils";-import Resource from "@/components/v2/ResourceOccupiedModal/Resource.vue";-import { WORKSPACE_ROUTE_SQL_REVIEW } from "@/router/dashboard/workspaceRoutes";-import { pushNotification, useSQLReviewStore } from "@/store";-import type { RuleTemplateV2 } from "@/types";-import {- convertRuleMapToPolicyRuleList,- getRuleMapByEngine,- isBuiltinRule,- UNKNOWN_ID,- withBuiltinRules,-} from "@/types";-import type { Engine } from "@/types/proto-es/v1/common_pb";-import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";-import {- hasWorkspacePermissionV2,- setDocumentTitle,- sqlReviewNameFromSlug,-} from "@/utils";--const props = defineProps<{- sqlReviewPolicySlug: string;-}>();--interface LocalState {- showDisableModal: boolean;- showEnableModal: boolean;- selectedCategory?: string;- editMode: boolean;- ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;- rulesUpdated: boolean;- updating: boolean;- editingTitle: boolean;- showResourcePanel: boolean;-}--const { t } = useI18n();-const store = useSQLReviewStore();-const router = useRouter();-const route = useRoute();--const state = reactive<LocalState>({- showDisableModal: false,- showEnableModal: false,- editMode: false,- ruleMapByEngine: new Map(),- rulesUpdated: false,- updating: false,- editingTitle: false,- showResourcePanel: false,-});--const hasUpdateReviwConfigPermission = computed(() => {- return hasWorkspacePermissionV2("bb.reviewConfigs.update");-});--const hasDeleteReviwConfigPermission = computed(() => {- return hasWorkspacePermissionV2("bb.reviewConfigs.delete");-});--const hasTagPolicyPermission = computed(() => {- return hasWorkspacePermissionV2("bb.policies.update");-});--const sqlReviewName = computed(() =>- sqlReviewNameFromSlug(props.sqlReviewPolicySlug)-);--watchEffect(async () => {- await store.getOrFetchReviewPolicyByName(- sqlReviewName.value,- false /* not silent */- );-});--onMounted(() => {- if (route.query.attachResourcePanel && hasTagPolicyPermission.value) {- nextTick(() => {- state.showResourcePanel = true;- });- }-});--const reviewPolicy = computed(() => {- return (- store.getReviewPolicyByName(sqlReviewName.value) ?? {- id: `${UNKNOWN_ID}`,- enforce: false,- name: "",- ruleList: [],- resources: [],- }- );-});--const ruleListOfPolicy = computed((): RuleTemplateV2[] => {- if (reviewPolicy.value.id === `${UNKNOWN_ID}`) {- return [];- }- return rulesToTemplate(reviewPolicy.value).ruleList;-});--watch(- ruleListOfPolicy,- (ruleList) => {- state.ruleMapByEngine = withBuiltinRules(getRuleMapByEngine(ruleList));- },- { immediate: true }-);--const pushUpdatedNotify = () => {- pushNotification({- module: "bytebase",- style: "SUCCESS",- title: t("sql-review.policy-updated"),- });-};--const changeName = async (title: string) => {- state.editingTitle = false;- const policy = reviewPolicy.value;- if (title === policy.name) {- return;- }-- await store.upsertReviewPolicy({- id: policy.id,- title,- });- pushUpdatedNotify();-};--const markChange = (- rule: RuleTemplateV2,- overrides: Partial<RuleTemplateV2>-) => {- const selectedRule = state.ruleMapByEngine.get(rule.engine)?.get(rule.type);- if (!selectedRule) {- return;- }- state.ruleMapByEngine- .get(rule.engine)- ?.set(rule.type, Object.assign(selectedRule, overrides));-- state.rulesUpdated = true;-};--const removeRule = (rule: RuleTemplateV2) => {- if (isBuiltinRule(rule)) {- return;- }- state.ruleMapByEngine.get(rule.engine)?.delete(rule.type);- if (state.ruleMapByEngine.get(rule.engine)?.size === 0) {- state.ruleMapByEngine.delete(rule.engine);- }- state.rulesUpdated = true;-};--const onCancelChanges = () => {- state.ruleMapByEngine = withBuiltinRules(- getRuleMapByEngine(ruleListOfPolicy.value)- );- state.rulesUpdated = false;-};--const onApplyChanges = async () => {- const policy = reviewPolicy.value;-- state.updating = true;- try {- await store.upsertReviewPolicy({- id: policy.id,- title: policy.name,- ruleList: convertRuleMapToPolicyRuleList(state.ruleMapByEngine),- });- state.rulesUpdated = false;- pushUpdatedNotify();- } finally {- state.updating = false;- }-};--const onEdit = () => {- state.editMode = true;-};--const onArchive = async () => {- await store.upsertReviewPolicy({- id: reviewPolicy.value.id,- enforce: false,- });- pushUpdatedNotify();-};--const onRestore = async () => {- await store.upsertReviewPolicy({- id: reviewPolicy.value.id,- enforce: true,- });- pushUpdatedNotify();-};--const onRemove = () => {- store.removeReviewPolicy(reviewPolicy.value.id).then(() => {- pushNotification({- module: "bytebase",- style: "SUCCESS",- title: t("sql-review.policy-removed"),- });- });- router.replace({- name: WORKSPACE_ROUTE_SQL_REVIEW,- });-};--watch(- () => reviewPolicy.value.name,- (name) => {- setDocumentTitle(name);- },- { immediate: true }-);-</script>--<style lang="postcss" scoped>-.sql-review-title :deep(.n-input-wrapper) {- padding-left: 0.3rem !important;-}-</style>