Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(rollout): simplify task links and remove task type labels (#19907)
boojackd1357ba0c8a7
diff --git a/frontend/src/components/Plan/components/common/DatabaseDisplay.vue b/frontend/src/components/Plan/components/common/DatabaseDisplay.vueindex 0abcdf9536..df2a05f555 100644--- a/frontend/src/components/Plan/components/common/DatabaseDisplay.vue+++ b/frontend/src/components/Plan/components/common/DatabaseDisplay.vue@@ -20,6 +20,7 @@{{ databaseDisplayName }}</span><router-link+ v-if="props.showExternalLink"class="pl-1 opacity-60 hover:opacity-100":to="`/${database}`"target="_blank"@@ -45,11 +46,17 @@ import {extractInstanceResourceName,} from "@/utils";-const props = defineProps<{- database: string;- showEnvironment?: boolean;- size?: "small" | "medium" | "large";-}>();+const props = withDefaults(+ defineProps<{+ database: string;+ showEnvironment?: boolean;+ showExternalLink?: boolean;+ size?: "small" | "medium" | "large";+ }>(),+ {+ showExternalLink: true,+ }+);const environmentStore = useEnvironmentV1Store();const instanceStore = useInstanceV1Store();diff --git a/frontend/src/components/RolloutV1/components/Task/TaskItem.vue b/frontend/src/components/RolloutV1/components/Task/TaskItem.vueindex bd624ddb44..f69373bf83 100644--- a/frontend/src/components/RolloutV1/components/Task/TaskItem.vue+++ b/frontend/src/components/RolloutV1/components/Task/TaskItem.vue@@ -19,26 +19,38 @@@update:checked="emit('toggle-select')"/><TaskStatus :status="task.status" :size="isExpanded ? 'large' : 'small'" />- <RouterLink- v-if="!readonly"- :to="taskDetailRoute"- active-class=""- exact-active-class=""- class="shrink-0 hover:opacity-80 transition-opacity"- >+ <div class="flex items-center gap-x-2 min-w-0">+ <RouterLink+ v-if="!readonly"+ :to="taskDetailRoute"+ active-class=""+ exact-active-class=""+ class="min-w-0 hover:opacity-80 transition-opacity"+ >+ <DatabaseDisplay+ :database="task.target"+ :size="isExpanded ? 'large' : 'medium'"+ :show-external-link="false"+ />+ </RouterLink><DatabaseDisplay+ v-else:database="task.target":size="isExpanded ? 'large' : 'medium'"- :link="false"+ :show-external-link="false"+ class="shrink-0"/>- </RouterLink>- <DatabaseDisplay- v-else- :database="task.target"- :size="isExpanded ? 'large' : 'medium'"- :link="false"- class="shrink-0"- />+ <RouterLink+ v-if="!readonly && isExpanded"+ :to="taskDetailRoute"+ active-class=""+ exact-active-class=""+ class="shrink-0 flex items-center gap-x-1 text-xs text-info hover:opacity-80 transition-opacity"+ >+ <ArrowUpRightIcon class="w-4 h-4" />+ <span>{{ t("common.view-details") }}</span>+ </RouterLink>+ </div><!-- Collapsed view: contextual info + type --><div v-if="!isExpanded" class="flex items-center gap-x-1.5 ml-auto shrink-0 text-xs text-gray-500"><!-- Status-contextual info first -->@@ -47,23 +59,16 @@:time="scheduledTime":title="t('task.scheduled-time')"/>- <span class="text-gray-300">·</span></template><template v-else-if="timingType === 'running'"><span class="flex items-center gap-x-1 text-blue-600"><LoaderCircleIcon class="w-3 h-3 animate-spin" />{{ timingDisplay }}</span>- <span class="text-gray-300">·</span></template><template v-else-if="collapsedContextInfo"><span>{{ collapsedContextInfo }}</span>- <span class="text-gray-300">·</span></template>- <!-- Task type last -->- <NTag round size="tiny" class="opacity-80">- {{ taskTypeDisplay }}- </NTag></div></div>@@ -100,10 +105,11 @@<div v-if="isExpanded" class="space-y-3"><!-- Task information line with quick actions --><div class="flex items-center justify-between gap-x-2">- <div class="flex flex-wrap items-center gap-x-2 gap-y-1 text-xs text-gray-600">- <span>{{ t("common.type") }}: {{ taskTypeDisplay }}</span>- <template v-if="timingType === 'scheduled'">- <span class="text-gray-400">·</span>+ <div+ v-if="timingType === 'scheduled'"+ class="flex flex-wrap items-center gap-x-2 gap-y-1 text-xs text-gray-600"+ >+ <template><ScheduledTimeIndicator:time="scheduledTime":label="t('task.scheduled-time')"@@ -150,19 +156,6 @@<div v-if="!isReleaseTask"><div class="flex items-center justify-between mb-1"><span class="text-sm font-medium text-gray-700">{{ t("common.statement") }}</span>- <RouterLink- v-if="!readonly"- :to="taskDetailRoute"- active-class=""- exact-active-class=""- >- <NButton text icon-placement="right" size="tiny" type="info">- <template #icon>- <ArrowUpRightIcon />- </template>- {{ t("rollout.task.view-full-details") }}- </NButton>- </RouterLink></div><BBSpin v-if="loading" />@@ -338,15 +331,11 @@ const affectedRowsDisplay = computed(() => {});// Task display formatting (type, executor, messages, collapsed view info)-const {- taskTypeDisplay,- executorEmail,- collapsedContextInfo,- collapsedStatusText,-} = useTaskDisplay(- () => props.task,- () => latestTaskRun.value,- () => timingDisplay.value,- () => affectedRowsDisplay.value-);+const { executorEmail, collapsedContextInfo, collapsedStatusText } =+ useTaskDisplay(+ () => props.task,+ () => latestTaskRun.value,+ () => timingDisplay.value,+ () => affectedRowsDisplay.value+ );</script>diff --git a/frontend/src/components/RolloutV1/components/Task/useTaskDisplay.ts b/frontend/src/components/RolloutV1/components/Task/useTaskDisplay.tsindex 202523f645..56d1749c64 100644--- a/frontend/src/components/RolloutV1/components/Task/useTaskDisplay.ts+++ b/frontend/src/components/RolloutV1/components/Task/useTaskDisplay.ts@@ -1,11 +1,9 @@import type { ComputedRef } from "vue";import { computed } from "vue";-import { useI18n } from "vue-i18n";import type { Task, TaskRun } from "@/types/proto-es/v1/rollout_service_pb";-import { Task_Status, Task_Type } from "@/types/proto-es/v1/rollout_service_pb";+import { Task_Status } from "@/types/proto-es/v1/rollout_service_pb";export interface UseTaskDisplayReturn {- taskTypeDisplay: ComputedRef<string>;executorEmail: ComputedRef<string>;collapsedContextInfo: ComputedRef<string>;collapsedStatusText: ComputedRef<string>;@@ -21,23 +19,6 @@ export const useTaskDisplay = (timingDisplay: () => string,affectedRowsDisplay: () => string): UseTaskDisplayReturn => {- const { t } = useI18n();-- const taskTypeDisplay = computed(() => {- switch (task().type) {- case Task_Type.DATABASE_CREATE:- return t("task.type.database-create");- case Task_Type.DATABASE_MIGRATE:- return t("task.type.migrate");- case Task_Type.DATABASE_EXPORT:- return t("task.type.database-export");- case Task_Type.GENERAL:- return t("task.type.general");- default:- return "";- }- });-const executorEmail = computed(() => {const creator = latestTaskRun()?.creator || "";const match = creator.match(/users\/([^/]+)/);@@ -73,7 +54,6 @@ export const useTaskDisplay = (});return {- taskTypeDisplay,executorEmail,collapsedContextInfo,collapsedStatusText,diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex 7d18c80958..2aca417549 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -1857,8 +1857,7 @@"no-statement": "No SQL statement","no-tasks": "No tasks in this stage","selected-count": "{count} task selected | {count} tasks selected",- "statement-truncated-hint": "Statement truncated due to large size.",- "view-full-details": "View Details"+ "statement-truncated-hint": "Statement truncated due to large size."},"task-execution-errors": "Task execution errors"},diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 69bce365be..9ee4113efd 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -1857,8 +1857,7 @@"no-statement": "Declaración sin SQL","no-tasks": "No hay tareas en esta etapa","selected-count": "{count} tarea seleccionada | {count} tareas seleccionadas",- "statement-truncated-hint": "Declaración truncada debido al gran tamaño.",- "view-full-details": "Ver detalles"+ "statement-truncated-hint": "Declaración truncada debido al gran tamaño."},"task-execution-errors": "Errores de ejecución de tareas"},diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 411f66d1d2..2b7bec8b9b 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -1857,8 +1857,7 @@"no-statement": "SQL文なし","no-tasks": "このステージにはタスクはありません","selected-count": "{count} 個のタスクが選択されました | {count} 個のタスクが選択されました",- "statement-truncated-hint": "サイズが大きいため、ステートメントは切り捨てられました。",- "view-full-details": "詳細を表示"+ "statement-truncated-hint": "サイズが大きいため、ステートメントは切り捨てられました。"},"task-execution-errors": "タスク実行エラー"},diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex fddcb8e456..e3188a66f3 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -1857,8 +1857,7 @@"no-statement": "Không có câu lệnh SQL","no-tasks": "Không có nhiệm vụ nào ở giai đoạn này","selected-count": "{count} nhiệm vụ đã chọn | {count} nhiệm vụ đã chọn",- "statement-truncated-hint": "Câu lệnh bị cắt bớt do kích thước lớn.",- "view-full-details": "Xem chi tiết đầy đủ"+ "statement-truncated-hint": "Câu lệnh bị cắt bớt do kích thước lớn."},"task-execution-errors": "Lỗi thực hiện tác vụ"},diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex fb7e287be3..3b036c0d8b 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -1857,8 +1857,7 @@"no-statement": "没有 SQL 语句","no-tasks": "此阶段没有任务","selected-count": "已选择 {count} 个任务",- "statement-truncated-hint": "由于语句过长,已被截断。",- "view-full-details": "查看详情"+ "statement-truncated-hint": "由于语句过长,已被截断。"},"task-execution-errors": "任务执行错误"},