Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor: optimize sheet metadata retrieval and cleanup revision service (#18555)
Danny Xud24fa45ae457
diff --git a/backend/api/mcp/gen/openapi.yaml b/backend/api/mcp/gen/openapi.yamlindex 8b9dda5306..44344fe0d1 100644--- a/backend/api/mcp/gen/openapi.yaml+++ b/backend/api/mcp/gen/openapi.yaml@@ -4379,44 +4379,6 @@ paths:application/json:schema:$ref: '#/components/schemas/bytebase.v1.BatchCreateRevisionsResponse'- /bytebase.v1.RevisionService/CreateRevision:- post:- tags:- - bytebase.v1.RevisionService- summary: 'Creates a new schema revision. Permissions required: bb.revisions.create'- description: |-- Creates a new schema revision.- Permissions required: bb.revisions.create- operationId: bytebase.v1.RevisionService.CreateRevision- parameters:- - name: Connect-Protocol-Version- in: header- required: true- schema:- $ref: '#/components/schemas/connect-protocol-version'- - name: Connect-Timeout-Ms- in: header- schema:- $ref: '#/components/schemas/connect-timeout-header'- requestBody:- content:- application/json:- schema:- $ref: '#/components/schemas/bytebase.v1.CreateRevisionRequest'- required: true- responses:- default:- description: Error- content:- application/json:- schema:- $ref: '#/components/schemas/connect.error'- "200":- description: Success- content:- application/json:- schema:- $ref: '#/components/schemas/bytebase.v1.Revision'/bytebase.v1.RevisionService/DeleteRevision:post:tags:diff --git a/backend/api/v1/plan_service.go b/backend/api/v1/plan_service.goindex 82e1281b13..631b4aaaec 100644--- a/backend/api/v1/plan_service.go+++ b/backend/api/v1/plan_service.go@@ -244,6 +244,11 @@ func (s *PlanService) CreatePlan(ctx context.Context, request *connect.Request[vreturn nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to validate plan specs, error: %v", err))}+ // Batch check sheets existence+ if err := checkPlanSpecsSheetsExistence(ctx, s.store, req.Plan.Specs); err != nil {+ return nil, err+ }+planMessage := &store.PlanMessage{ProjectID: projectID,PipelineUID: nil,@@ -474,6 +479,11 @@ func (s *PlanService) UpdatePlan(ctx context.Context, request *connect.Request[vupdatedByID[spec.Id] = spec}+ // Batch check sheets existence+ if err := checkPlanSpecsSheetsExistence(ctx, s.store, updated); err != nil {+ return nil, err+ }+// Handle task updates for specstasksMap := map[int]*store.TaskMessage{}var taskPatchList []*store.TaskPatch@@ -608,13 +618,6 @@ func (s *PlanService) UpdatePlan(ctx context.Context, request *connect.Request[vreturn nil}- sheet, err := s.store.GetSheetMetadata(ctx, newSheetSha256)- if err != nil {- return connect.NewError(connect.CodeInternal, errors.Errorf("failed to get sheet %q: %v", oldSheetName, err))- }- if sheet == nil {- return connect.NewError(connect.CodeNotFound, errors.Errorf("sheet %q not found", oldSheetName))- }doUpdate = truetaskPatch.SheetSha256 = &newSheetSha256@@ -1322,3 +1325,32 @@ func getTaskTypeFromSpec(spec *v1pb.Plan_Spec) (storepb.Task_Type, error) {return storepb.Task_TASK_TYPE_UNSPECIFIED, errors.Errorf("unknown spec config type")}}++func checkPlanSpecsSheetsExistence(ctx context.Context, s *store.Store, specs []*v1pb.Plan_Spec) error {+ var sheetSha256s []string+ for _, spec := range specs {+ if config := spec.GetChangeDatabaseConfig(); config != nil {+ if config.Sheet != "" {+ _, sha, err := common.GetProjectResourceIDSheetSha256(config.Sheet)+ if err == nil {+ sheetSha256s = append(sheetSha256s, sha)+ }+ }+ } else if config := spec.GetExportDataConfig(); config != nil {+ if config.Sheet != "" {+ _, sha, err := common.GetProjectResourceIDSheetSha256(config.Sheet)+ if err == nil {+ sheetSha256s = append(sheetSha256s, sha)+ }+ }+ }+ }+ exist, err := s.HasSheets(ctx, sheetSha256s...)+ if err != nil {+ return connect.NewError(connect.CodeInternal, errors.Errorf("failed to check sheets: %v", err))+ }+ if !exist {+ return connect.NewError(connect.CodeNotFound, errors.Errorf("some sheets are not found"))+ }+ return nil+}diff --git a/backend/api/v1/plan_service_plan_check.go b/backend/api/v1/plan_service_plan_check.goindex 1b50162576..c737a69e9b 100644--- a/backend/api/v1/plan_service_plan_check.go+++ b/backend/api/v1/plan_service_plan_check.go@@ -172,16 +172,8 @@ func getPlanCheckRunsFromChangeDatabaseConfigForDatabase(ctx context.Context, sif instance == nil {return nil, errors.Errorf("instance %q not found", database.InstanceID)}- sheet, err := s.GetSheetMetadata(ctx, sheetSha256)- if err != nil {- return nil, errors.Wrapf(err, "failed to get sheet %s", sheetSha256)- }- if sheet == nil {- return nil, errors.Errorf("sheet %s not found", sheetSha256)- }enableSDL := config.Type == storepb.PlanConfig_ChangeDatabaseConfig_SDL-var planCheckRuns []*store.PlanCheckRunMessageplanCheckRuns = append(planCheckRuns, &store.PlanCheckRunMessage{PlanUID: plan.UID,diff --git a/backend/api/v1/release_service.go b/backend/api/v1/release_service.goindex b74c77662b..c2c84a6f82 100644--- a/backend/api/v1/release_service.go+++ b/backend/api/v1/release_service.go@@ -115,23 +115,27 @@ func (s *ReleaseService) CreateRelease(ctx context.Context, req *connect.Request},}+ var sheetSha256s []stringfor _, f := range sanitizedFiles {_, sheetSha256, err := common.GetProjectResourceIDSheetSha256(f.Sheet)if err != nil {return nil, errors.Wrapf(err, "failed to get sheetSha256 from %q", f.Sheet)}- sheet, err := s.store.GetSheetMetadata(ctx, sheetSha256)- if err != nil {- return nil, errors.Wrapf(err, "failed to get sheet %q", f.Sheet)- }- if sheet == nil {- return nil, errors.Errorf("sheet %q not found", f.Sheet)- }+ sheetSha256s = append(sheetSha256s, sheetSha256)+ }+ exist, err := s.store.HasSheets(ctx, sheetSha256s...)+ if err != nil {+ return nil, errors.Wrapf(err, "failed to check sheets")+ }+ if !exist {+ return nil, errors.Errorf("some sheets are not found")+ }+ for i, f := range sanitizedFiles {releaseMessage.Payload.Files = append(releaseMessage.Payload.Files, &storepb.ReleasePayload_File{Id: f.Id,Path: f.Path,- SheetSha256: sheetSha256,+ SheetSha256: sheetSha256s[i],Type: storepb.SchemaChangeType(f.Type),Version: f.Version,EnableGhost: f.EnableGhost,@@ -435,7 +439,7 @@ func convertToRelease(ctx context.Context, s *store.Store, release *store.Releasfor _, f := range release.Payload.Files {sheet, err := s.GetSheetMetadata(ctx, f.SheetSha256)if err != nil {- return nil, errors.Wrapf(err, "failed to get sheet with sha256 %q", f.SheetSha256)+ return nil, errors.Wrapf(err, "failed to get sheet %q", f.SheetSha256)}if sheet == nil {return nil, errors.Errorf("sheet %q not found", f.SheetSha256)diff --git a/backend/api/v1/revision_service.go b/backend/api/v1/revision_service.goindex f82e02eb81..aac7a5e4ea 100644--- a/backend/api/v1/revision_service.go+++ b/backend/api/v1/revision_service.go@@ -108,18 +108,11 @@ func (s *RevisionService) GetRevision(return connect.NewResponse(converted), nil}-func (s *RevisionService) CreateRevision(+func (s *RevisionService) BatchCreateRevisions(ctx context.Context,- req *connect.Request[v1pb.CreateRevisionRequest],-) (*connect.Response[v1pb.Revision], error) {+ req *connect.Request[v1pb.BatchCreateRevisionsRequest],+) (*connect.Response[v1pb.BatchCreateRevisionsResponse], error) {request := req.Msg- if request.Revision == nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("request.Revision is not set"))- }- // Validate the version format.- if _, err := model.NewVersion(request.Revision.Version); err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to parse version %q", request.Revision.Version))- }database, err := getDatabaseMessage(ctx, s.store, request.Parent)if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to found database %v", request.Parent))@@ -127,117 +120,129 @@ func (s *RevisionService) CreateRevision(if database == nil || database.Deleted {return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("database %v not found", request.Parent))}- _, sheetSha256, err := common.GetProjectResourceIDSheetSha256(request.Revision.Sheet)- if err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get sheet from %v", request.Revision.Sheet))- }- sheet, err := s.store.GetSheetMetadata(ctx, sheetSha256)- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get sheet"))- }- if request.Revision.TaskRun != "" {- projectID, rolloutID, stageID, taskID, taskRunID, err := common.GetProjectIDRolloutIDStageIDTaskIDTaskRunID(request.Revision.TaskRun)- if err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get taskRun from %q", request.Revision.TaskRun))- }- taskRun, err := s.store.GetTaskRunByUID(ctx, taskRunID)- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get taskRun"))- }- if taskRun == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("taskRun %q not found", request.Revision.TaskRun))- }- if taskRun.ProjectID != projectID ||- taskRun.PipelineUID != rolloutID ||- taskRun.Environment != formatEnvironmentFromStageID(stageID) ||- taskRun.TaskUID != taskID {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("taskRun %q not found", request.Revision.TaskRun))+ var revisions []*v1pb.Revision+ for _, r := range request.Requests {+ // Validate parent matches+ if r.Parent != request.Parent {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("request parent %q does not match batch parent %q", r.Parent, request.Parent))}+ revisions = append(revisions, r.Revision)}- if request.Revision.Type == v1pb.Revision_TYPE_UNSPECIFIED {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("revision.type cannot be TYPE_UNSPECIFIED"))+ createdRevisions, err := s.createRevisions(ctx, request.Parent, revisions, database)+ if err != nil {+ return nil, err}- if (request.Revision.Release == "") != (request.Revision.File == "") {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("revision.release and revision.file must be set or unset"))- }- if request.Revision.Release != "" && request.Revision.File != "" {- if !strings.HasPrefix(request.Revision.File, request.Revision.Release) {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("file %q is not in release %q", request.Revision.File, request.Revision.Release))+ return connect.NewResponse(&v1pb.BatchCreateRevisionsResponse{+ Revisions: createdRevisions,+ }), nil+}++func (s *RevisionService) createRevisions(+ ctx context.Context,+ parent string,+ revisions []*v1pb.Revision,+ database *store.DatabaseMessage,+) ([]*v1pb.Revision, error) {+ var sheetSha256s []string+ for _, revisionReq := range revisions {+ if revisionReq == nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("request.Revision is not set"))}- _, releaseUID, fileID, err := common.GetProjectReleaseUIDFile(request.Revision.File)- if err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get release and file from %q", request.Revision.File))+ // Validate the version format.+ if _, err := model.NewVersion(revisionReq.Version); err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to parse version %q", revisionReq.Version))}- release, err := s.store.GetReleaseByUID(ctx, releaseUID)++ _, sha, err := common.GetProjectResourceIDSheetSha256(revisionReq.Sheet)if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get release"))- }- if release == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("release %q not found", request.Revision.Release))- }- foundFile := false- for _, f := range release.Payload.Files {- if f.Id == fileID {- foundFile = true- fileSheet := common.FormatSheet(release.ProjectID, f.SheetSha256)- if fileSheet != request.Revision.Sheet {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("The sheet in file %q is %q which is different from revision.sheet %q", fileID, fileSheet, request.Revision.Sheet))- }- break- }- }- if !foundFile {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("file %q not found in release %q", fileID, request.Revision.Release))+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get sheet from %v", revisionReq.Sheet))}+ sheetSha256s = append(sheetSha256s, sha)}- revisionCreate := convertRevision(request.Revision, database, sheet)- revisionM, err := s.store.CreateRevision(ctx, revisionCreate)+ exist, err := s.store.HasSheets(ctx, sheetSha256s...)if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create revision"))+ return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check sheets: %v", err))}- converted, err := convertToRevision(ctx, s.store, request.Parent, revisionM)- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to revision"))+ if !exist {+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("some sheets are not found"))}- return connect.NewResponse(converted), nil-}+ var createdRevisions []*v1pb.Revision+ for i, revision := range revisions {+ if revision.TaskRun != "" {+ projectID, rolloutID, stageID, taskID, taskRunID, err := common.GetProjectIDRolloutIDStageIDTaskIDTaskRunID(revision.TaskRun)+ if err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get taskRun from %q", revision.TaskRun))+ }+ taskRun, err := s.store.GetTaskRunByUID(ctx, taskRunID)+ if err != nil {+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get taskRun"))+ }+ if taskRun == nil {+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("taskRun %q not found", revision.TaskRun))+ }+ if taskRun.ProjectID != projectID ||+ taskRun.PipelineUID != rolloutID ||+ taskRun.Environment != formatEnvironmentFromStageID(stageID) ||+ taskRun.TaskUID != taskID {+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("taskRun %q not found", revision.TaskRun))+ }+ }-func (s *RevisionService) BatchCreateRevisions(- ctx context.Context,- req *connect.Request[v1pb.BatchCreateRevisionsRequest],-) (*connect.Response[v1pb.BatchCreateRevisionsResponse], error) {- request := req.Msg- database, err := getDatabaseMessage(ctx, s.store, request.Parent)- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to found database %v", request.Parent))- }- if database == nil || database.Deleted {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("database %v not found", request.Parent))- }+ if revision.Type == v1pb.Revision_TYPE_UNSPECIFIED {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("revision.type cannot be TYPE_UNSPECIFIED"))+ }- var revisions []*v1pb.Revision- for _, req := range request.Requests {- // Validate parent matches- if req.Parent != request.Parent {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("request parent %q does not match batch parent %q", req.Parent, request.Parent))+ if (revision.Release == "") != (revision.File == "") {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("revision.release and revision.file must be set or unset"))+ }+ if revision.Release != "" && revision.File != "" {+ if !strings.HasPrefix(revision.File, revision.Release) {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("file %q is not in release %q", revision.File, revision.Release))+ }+ _, releaseUID, fileID, err := common.GetProjectReleaseUIDFile(revision.File)+ if err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get release and file from %q", revision.File))+ }+ release, err := s.store.GetReleaseByUID(ctx, releaseUID)+ if err != nil {+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get release"))+ }+ if release == nil {+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("release %q not found", revision.Release))+ }+ foundFile := false+ for _, f := range release.Payload.Files {+ if f.Id == fileID {+ foundFile = true+ fileSheet := common.FormatSheet(release.ProjectID, f.SheetSha256)+ if fileSheet != revision.Sheet {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("The sheet in file %q is %q which is different from revision.sheet %q", fileID, fileSheet, revision.Sheet))+ }+ break+ }+ }+ if !foundFile {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("file %q not found in release %q", fileID, revision.Release))+ }}- // Reuse the CreateRevision logic by calling it directly- revisionResp, err := s.CreateRevision(ctx, connect.NewRequest(req))+ revisionCreate := convertRevision(revision, database, sheetSha256s[i])+ revisionM, err := s.store.CreateRevision(ctx, revisionCreate)+ if err != nil {+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create revision"))+ }+ converted, err := convertToRevision(ctx, s.store, parent, revisionM)if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create revision for request"))+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to revision"))}- revisions = append(revisions, revisionResp.Msg)+ createdRevisions = append(createdRevisions, converted)}-- return connect.NewResponse(&v1pb.BatchCreateRevisionsResponse{- Revisions: revisions,- }), nil+ return createdRevisions, nil}func (s *RevisionService) DeleteRevision(@@ -331,7 +336,7 @@ func convertToRevisionType(t storepb.SchemaChangeType) v1pb.Revision_Type {}}-func convertRevision(revision *v1pb.Revision, database *store.DatabaseMessage, sheet *store.SheetMessage) *store.RevisionMessage {+func convertRevision(revision *v1pb.Revision, database *store.DatabaseMessage, sheetSha256 string) *store.RevisionMessage {r := &store.RevisionMessage{InstanceID: database.InstanceID,DatabaseName: database.DatabaseName,@@ -339,7 +344,7 @@ func convertRevision(revision *v1pb.Revision, database *store.DatabaseMessage, sPayload: &storepb.RevisionPayload{Release: revision.Release,File: revision.File,- SheetSha256: sheet.Sha256,+ SheetSha256: sheetSha256,TaskRun: revision.TaskRun,Type: convertRevisionType(revision.Type),},diff --git a/backend/generated-go/v1/revision_service.pb.go b/backend/generated-go/v1/revision_service.pb.goindex 720b855b32..54fdcc8632 100644--- a/backend/generated-go/v1/revision_service.pb.go+++ b/backend/generated-go/v1/revision_service.pb.go@@ -672,11 +672,10 @@ const file_v1_revision_service_proto_rawDesc = "" +"\x10TYPE_UNSPECIFIED\x10\x00\x12\r\n" +"\tVERSIONED\x10\x01\x12\x0f\n" +"\vDECLARATIVE\x10\x02:Z\xeaAW\n" +- "\x15bytebase.com/Revision\x12>instances/{instance}/databases/{database}/revisions/{revision}2\x87\a\n" ++ "\x15bytebase.com/Revision\x12>instances/{instance}/databases/{database}/revisions/{revision}2\xdc\x05\n" +"\x0fRevisionService\x12\xb0\x01\n" +"\rListRevisions\x12!.bytebase.v1.ListRevisionsRequest\x1a\".bytebase.v1.ListRevisionsResponse\"X\xdaA\x06parent\x8a\xea0\x11bb.revisions.list\x90\xea0\x01\x82\xd3\xe4\x93\x020\x12./v1/{parent=instances/*/databases/*}/revisions\x12\x9c\x01\n" +- "\vGetRevision\x12\x1f.bytebase.v1.GetRevisionRequest\x1a\x15.bytebase.v1.Revision\"U\xdaA\x04name\x8a\xea0\x10bb.revisions.get\x90\xea0\x01\x82\xd3\xe4\x93\x020\x12./v1/{name=instances/*/databases/*/revisions/*}\x12\xa8\x01\n" +- "\x0eCreateRevision\x12\".bytebase.v1.CreateRevisionRequest\x1a\x15.bytebase.v1.Revision\"[\x8a\xea0\x13bb.revisions.create\x90\xea0\x01\x82\xd3\xe4\x93\x02::\brevision\"./v1/{parent=instances/*/databases/*}/revisions\x12\xcd\x01\n" ++ "\vGetRevision\x12\x1f.bytebase.v1.GetRevisionRequest\x1a\x15.bytebase.v1.Revision\"U\xdaA\x04name\x8a\xea0\x10bb.revisions.get\x90\xea0\x01\x82\xd3\xe4\x93\x020\x12./v1/{name=instances/*/databases/*/revisions/*}\x12\xcd\x01\n" +"\x14BatchCreateRevisions\x12(.bytebase.v1.BatchCreateRevisionsRequest\x1a).bytebase.v1.BatchCreateRevisionsResponse\"`\x8a\xea0\x13bb.revisions.create\x90\xea0\x01\x82\xd3\xe4\x93\x02?:\x01*\":/v1/{parent=instances/*/databases/*}/revisions:batchCreate\x12\xa6\x01\n" +"\x0eDeleteRevision\x12\".bytebase.v1.DeleteRevisionRequest\x1a\x16.google.protobuf.Empty\"X\xdaA\x04name\x8a\xea0\x13bb.revisions.delete\x90\xea0\x01\x82\xd3\xe4\x93\x020*./v1/{name=instances/*/databases/*/revisions/*}B\xaa\x01\n" +"\x0fcom.bytebase.v1B\x14RevisionServiceProtoP\x01Z4github.com/bytebase/bytebase/backend/generated-go/v1\xa2\x02\x03BXX\xaa\x02\vBytebase.V1\xca\x02\vBytebase\\V1\xe2\x02\x17Bytebase\\V1\\GPBMetadata\xea\x02\fBytebase::V1b\x06proto3"@@ -718,16 +717,14 @@ var file_v1_revision_service_proto_depIdxs = []int32{0, // 6: bytebase.v1.Revision.type:type_name -> bytebase.v1.Revision.Type1, // 7: bytebase.v1.RevisionService.ListRevisions:input_type -> bytebase.v1.ListRevisionsRequest6, // 8: bytebase.v1.RevisionService.GetRevision:input_type -> bytebase.v1.GetRevisionRequest- 3, // 9: bytebase.v1.RevisionService.CreateRevision:input_type -> bytebase.v1.CreateRevisionRequest- 4, // 10: bytebase.v1.RevisionService.BatchCreateRevisions:input_type -> bytebase.v1.BatchCreateRevisionsRequest- 7, // 11: bytebase.v1.RevisionService.DeleteRevision:input_type -> bytebase.v1.DeleteRevisionRequest- 2, // 12: bytebase.v1.RevisionService.ListRevisions:output_type -> bytebase.v1.ListRevisionsResponse- 8, // 13: bytebase.v1.RevisionService.GetRevision:output_type -> bytebase.v1.Revision- 8, // 14: bytebase.v1.RevisionService.CreateRevision:output_type -> bytebase.v1.Revision- 5, // 15: bytebase.v1.RevisionService.BatchCreateRevisions:output_type -> bytebase.v1.BatchCreateRevisionsResponse- 10, // 16: bytebase.v1.RevisionService.DeleteRevision:output_type -> google.protobuf.Empty- 12, // [12:17] is the sub-list for method output_type- 7, // [7:12] is the sub-list for method input_type+ 4, // 9: bytebase.v1.RevisionService.BatchCreateRevisions:input_type -> bytebase.v1.BatchCreateRevisionsRequest+ 7, // 10: bytebase.v1.RevisionService.DeleteRevision:input_type -> bytebase.v1.DeleteRevisionRequest+ 2, // 11: bytebase.v1.RevisionService.ListRevisions:output_type -> bytebase.v1.ListRevisionsResponse+ 8, // 12: bytebase.v1.RevisionService.GetRevision:output_type -> bytebase.v1.Revision+ 5, // 13: bytebase.v1.RevisionService.BatchCreateRevisions:output_type -> bytebase.v1.BatchCreateRevisionsResponse+ 10, // 14: bytebase.v1.RevisionService.DeleteRevision:output_type -> google.protobuf.Empty+ 11, // [11:15] is the sub-list for method output_type+ 7, // [7:11] is the sub-list for method input_type7, // [7:7] is the sub-list for extension type_name7, // [7:7] is the sub-list for extension extendee0, // [0:7] is the sub-list for field type_namediff --git a/backend/generated-go/v1/revision_service.pb.gw.go b/backend/generated-go/v1/revision_service.pb.gw.goindex 73203c44d2..c20445e5e8 100644--- a/backend/generated-go/v1/revision_service.pb.gw.go+++ b/backend/generated-go/v1/revision_service.pb.gw.go@@ -127,51 +127,6 @@ func local_request_RevisionService_GetRevision_0(ctx context.Context, marshalerreturn msg, metadata, err}-func request_RevisionService_CreateRevision_0(ctx context.Context, marshaler runtime.Marshaler, client RevisionServiceClient, req *http.Request, pathParams map[string]string) (proto.Message, runtime.ServerMetadata, error) {- var (- protoReq CreateRevisionRequest- metadata runtime.ServerMetadata- err error- )- if err := marshaler.NewDecoder(req.Body).Decode(&protoReq.Revision); err != nil && !errors.Is(err, io.EOF) {- return nil, metadata, status.Errorf(codes.InvalidArgument, "%v", err)- }- if req.Body != nil {- _, _ = io.Copy(io.Discard, req.Body)- }- val, ok := pathParams["parent"]- if !ok {- return nil, metadata, status.Errorf(codes.InvalidArgument, "missing parameter %s", "parent")- }- protoReq.Parent, err = runtime.String(val)- if err != nil {- return nil, metadata, status.Errorf(codes.InvalidArgument, "type mismatch, parameter: %s, error: %v", "parent", err)- }- msg, err := client.CreateRevision(ctx, &protoReq, grpc.Header(&metadata.HeaderMD), grpc.Trailer(&metadata.TrailerMD))- return msg, metadata, err-}--func local_request_RevisionService_CreateRevision_0(ctx context.Context, marshaler runtime.Marshaler, server RevisionServiceServer, req *http.Request, pathParams map[string]string) (proto.Message, runtime.ServerMetadata, error) {- var (- protoReq CreateRevisionRequest- metadata runtime.ServerMetadata- err error- )- if err := marshaler.NewDecoder(req.Body).Decode(&protoReq.Revision); err != nil && !errors.Is(err, io.EOF) {- return nil, metadata, status.Errorf(codes.InvalidArgument, "%v", err)- }- val, ok := pathParams["parent"]- if !ok {- return nil, metadata, status.Errorf(codes.InvalidArgument, "missing parameter %s", "parent")- }- protoReq.Parent, err = runtime.String(val)- if err != nil {- return nil, metadata, status.Errorf(codes.InvalidArgument, "type mismatch, parameter: %s, error: %v", "parent", err)- }- msg, err := server.CreateRevision(ctx, &protoReq)- return msg, metadata, err-}-func request_RevisionService_BatchCreateRevisions_0(ctx context.Context, marshaler runtime.Marshaler, client RevisionServiceClient, req *http.Request, pathParams map[string]string) (proto.Message, runtime.ServerMetadata, error) {var (protoReq BatchCreateRevisionsRequest@@ -302,26 +257,6 @@ func RegisterRevisionServiceHandlerServer(ctx context.Context, mux *runtime.Serv}forward_RevisionService_GetRevision_0(annotatedContext, mux, outboundMarshaler, w, req, resp, mux.GetForwardResponseOptions()...)})- mux.Handle(http.MethodPost, pattern_RevisionService_CreateRevision_0, func(w http.ResponseWriter, req *http.Request, pathParams map[string]string) {- ctx, cancel := context.WithCancel(req.Context())- defer cancel()- var stream runtime.ServerTransportStream- ctx = grpc.NewContextWithServerTransportStream(ctx, &stream)- inboundMarshaler, outboundMarshaler := runtime.MarshalerForRequest(mux, req)- annotatedContext, err := runtime.AnnotateIncomingContext(ctx, mux, req, "/bytebase.v1.RevisionService/CreateRevision", runtime.WithHTTPPathPattern("/v1/{parent=instances/*/databases/*}/revisions"))- if err != nil {- runtime.HTTPError(ctx, mux, outboundMarshaler, w, req, err)- return- }- resp, md, err := local_request_RevisionService_CreateRevision_0(annotatedContext, inboundMarshaler, server, req, pathParams)- md.HeaderMD, md.TrailerMD = metadata.Join(md.HeaderMD, stream.Header()), metadata.Join(md.TrailerMD, stream.Trailer())- annotatedContext = runtime.NewServerMetadataContext(annotatedContext, md)- if err != nil {- runtime.HTTPError(annotatedContext, mux, outboundMarshaler, w, req, err)- return- }- forward_RevisionService_CreateRevision_0(annotatedContext, mux, outboundMarshaler, w, req, resp, mux.GetForwardResponseOptions()...)- })mux.Handle(http.MethodPost, pattern_RevisionService_BatchCreateRevisions_0, func(w http.ResponseWriter, req *http.Request, pathParams map[string]string) {ctx, cancel := context.WithCancel(req.Context())defer cancel()@@ -436,23 +371,6 @@ func RegisterRevisionServiceHandlerClient(ctx context.Context, mux *runtime.Serv}forward_RevisionService_GetRevision_0(annotatedContext, mux, outboundMarshaler, w, req, resp, mux.GetForwardResponseOptions()...)})- mux.Handle(http.MethodPost, pattern_RevisionService_CreateRevision_0, func(w http.ResponseWriter, req *http.Request, pathParams map[string]string) {- ctx, cancel := context.WithCancel(req.Context())- defer cancel()- inboundMarshaler, outboundMarshaler := runtime.MarshalerForRequest(mux, req)- annotatedContext, err := runtime.AnnotateContext(ctx, mux, req, "/bytebase.v1.RevisionService/CreateRevision", runtime.WithHTTPPathPattern("/v1/{parent=instances/*/databases/*}/revisions"))- if err != nil {- runtime.HTTPError(ctx, mux, outboundMarshaler, w, req, err)- return- }- resp, md, err := request_RevisionService_CreateRevision_0(annotatedContext, inboundMarshaler, client, req, pathParams)- annotatedContext = runtime.NewServerMetadataContext(annotatedContext, md)- if err != nil {- runtime.HTTPError(annotatedContext, mux, outboundMarshaler, w, req, err)- return- }- forward_RevisionService_CreateRevision_0(annotatedContext, mux, outboundMarshaler, w, req, resp, mux.GetForwardResponseOptions()...)- })mux.Handle(http.MethodPost, pattern_RevisionService_BatchCreateRevisions_0, func(w http.ResponseWriter, req *http.Request, pathParams map[string]string) {ctx, cancel := context.WithCancel(req.Context())defer cancel()@@ -493,7 +411,6 @@ func RegisterRevisionServiceHandlerClient(ctx context.Context, mux *runtime.Servvar (pattern_RevisionService_ListRevisions_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 1, 0, 2, 2, 1, 0, 4, 4, 5, 3, 2, 4}, []string{"v1", "instances", "databases", "parent", "revisions"}, ""))pattern_RevisionService_GetRevision_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 1, 0, 2, 2, 1, 0, 2, 3, 1, 0, 4, 6, 5, 4}, []string{"v1", "instances", "databases", "revisions", "name"}, ""))- pattern_RevisionService_CreateRevision_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 1, 0, 2, 2, 1, 0, 4, 4, 5, 3, 2, 4}, []string{"v1", "instances", "databases", "parent", "revisions"}, ""))pattern_RevisionService_BatchCreateRevisions_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 1, 0, 2, 2, 1, 0, 4, 4, 5, 3, 2, 4}, []string{"v1", "instances", "databases", "parent", "revisions"}, "batchCreate"))pattern_RevisionService_DeleteRevision_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 1, 0, 2, 2, 1, 0, 2, 3, 1, 0, 4, 6, 5, 4}, []string{"v1", "instances", "databases", "revisions", "name"}, "")))@@ -501,7 +418,6 @@ var (var (forward_RevisionService_ListRevisions_0 = runtime.ForwardResponseMessageforward_RevisionService_GetRevision_0 = runtime.ForwardResponseMessage- forward_RevisionService_CreateRevision_0 = runtime.ForwardResponseMessageforward_RevisionService_BatchCreateRevisions_0 = runtime.ForwardResponseMessageforward_RevisionService_DeleteRevision_0 = runtime.ForwardResponseMessage)diff --git a/backend/generated-go/v1/revision_service_grpc.pb.go b/backend/generated-go/v1/revision_service_grpc.pb.goindex 28d09a17e2..eaec8ff215 100644--- a/backend/generated-go/v1/revision_service_grpc.pb.go+++ b/backend/generated-go/v1/revision_service_grpc.pb.go@@ -22,7 +22,6 @@ const _ = grpc.SupportPackageIsVersion9const (RevisionService_ListRevisions_FullMethodName = "/bytebase.v1.RevisionService/ListRevisions"RevisionService_GetRevision_FullMethodName = "/bytebase.v1.RevisionService/GetRevision"- RevisionService_CreateRevision_FullMethodName = "/bytebase.v1.RevisionService/CreateRevision"RevisionService_BatchCreateRevisions_FullMethodName = "/bytebase.v1.RevisionService/BatchCreateRevisions"RevisionService_DeleteRevision_FullMethodName = "/bytebase.v1.RevisionService/DeleteRevision")@@ -39,9 +38,6 @@ type RevisionServiceClient interface {// Retrieves a schema revision by name.// Permissions required: bb.revisions.getGetRevision(ctx context.Context, in *GetRevisionRequest, opts ...grpc.CallOption) (*Revision, error)- // Creates a new schema revision.- // Permissions required: bb.revisions.create- CreateRevision(ctx context.Context, in *CreateRevisionRequest, opts ...grpc.CallOption) (*Revision, error)// Creates multiple schema revisions in a single operation.// Permissions required: bb.revisions.createBatchCreateRevisions(ctx context.Context, in *BatchCreateRevisionsRequest, opts ...grpc.CallOption) (*BatchCreateRevisionsResponse, error)@@ -78,16 +74,6 @@ func (c *revisionServiceClient) GetRevision(ctx context.Context, in *GetRevisionreturn out, nil}-func (c *revisionServiceClient) CreateRevision(ctx context.Context, in *CreateRevisionRequest, opts ...grpc.CallOption) (*Revision, error) {- cOpts := append([]grpc.CallOption{grpc.StaticMethod()}, opts...)- out := new(Revision)- err := c.cc.Invoke(ctx, RevisionService_CreateRevision_FullMethodName, in, out, cOpts...)- if err != nil {- return nil, err- }- return out, nil-}-func (c *revisionServiceClient) BatchCreateRevisions(ctx context.Context, in *BatchCreateRevisionsRequest, opts ...grpc.CallOption) (*BatchCreateRevisionsResponse, error) {cOpts := append([]grpc.CallOption{grpc.StaticMethod()}, opts...)out := new(BatchCreateRevisionsResponse)@@ -120,9 +106,6 @@ type RevisionServiceServer interface {// Retrieves a schema revision by name.// Permissions required: bb.revisions.getGetRevision(context.Context, *GetRevisionRequest) (*Revision, error)- // Creates a new schema revision.- // Permissions required: bb.revisions.create- CreateRevision(context.Context, *CreateRevisionRequest) (*Revision, error)// Creates multiple schema revisions in a single operation.// Permissions required: bb.revisions.createBatchCreateRevisions(context.Context, *BatchCreateRevisionsRequest) (*BatchCreateRevisionsResponse, error)@@ -145,9 +128,6 @@ func (UnimplementedRevisionServiceServer) ListRevisions(context.Context, *ListRefunc (UnimplementedRevisionServiceServer) GetRevision(context.Context, *GetRevisionRequest) (*Revision, error) {return nil, status.Error(codes.Unimplemented, "method GetRevision not implemented")}-func (UnimplementedRevisionServiceServer) CreateRevision(context.Context, *CreateRevisionRequest) (*Revision, error) {- return nil, status.Error(codes.Unimplemented, "method CreateRevision not implemented")-}func (UnimplementedRevisionServiceServer) BatchCreateRevisions(context.Context, *BatchCreateRevisionsRequest) (*BatchCreateRevisionsResponse, error) {return nil, status.Error(codes.Unimplemented, "method BatchCreateRevisions not implemented")}@@ -211,24 +191,6 @@ func _RevisionService_GetRevision_Handler(srv interface{}, ctx context.Context,return interceptor(ctx, in, info, handler)}-func _RevisionService_CreateRevision_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) {- in := new(CreateRevisionRequest)- if err := dec(in); err != nil {- return nil, err- }- if interceptor == nil {- return srv.(RevisionServiceServer).CreateRevision(ctx, in)- }- info := &grpc.UnaryServerInfo{- Server: srv,- FullMethod: RevisionService_CreateRevision_FullMethodName,- }- handler := func(ctx context.Context, req interface{}) (interface{}, error) {- return srv.(RevisionServiceServer).CreateRevision(ctx, req.(*CreateRevisionRequest))- }- return interceptor(ctx, in, info, handler)-}-func _RevisionService_BatchCreateRevisions_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) {in := new(BatchCreateRevisionsRequest)if err := dec(in); err != nil {@@ -280,10 +242,6 @@ var RevisionService_ServiceDesc = grpc.ServiceDesc{MethodName: "GetRevision",Handler: _RevisionService_GetRevision_Handler,},- {- MethodName: "CreateRevision",- Handler: _RevisionService_CreateRevision_Handler,- },{MethodName: "BatchCreateRevisions",Handler: _RevisionService_BatchCreateRevisions_Handler,diff --git a/backend/generated-go/v1/v1connect/revision_service.connect.go b/backend/generated-go/v1/v1connect/revision_service.connect.goindex b0a6916e29..548c670ffb 100644--- a/backend/generated-go/v1/v1connect/revision_service.connect.go+++ b/backend/generated-go/v1/v1connect/revision_service.connect.go@@ -40,9 +40,6 @@ const (// RevisionServiceGetRevisionProcedure is the fully-qualified name of the RevisionService's// GetRevision RPC.RevisionServiceGetRevisionProcedure = "/bytebase.v1.RevisionService/GetRevision"- // RevisionServiceCreateRevisionProcedure is the fully-qualified name of the RevisionService's- // CreateRevision RPC.- RevisionServiceCreateRevisionProcedure = "/bytebase.v1.RevisionService/CreateRevision"// RevisionServiceBatchCreateRevisionsProcedure is the fully-qualified name of the RevisionService's// BatchCreateRevisions RPC.RevisionServiceBatchCreateRevisionsProcedure = "/bytebase.v1.RevisionService/BatchCreateRevisions"@@ -59,9 +56,6 @@ type RevisionServiceClient interface {// Retrieves a schema revision by name.// Permissions required: bb.revisions.getGetRevision(context.Context, *connect.Request[v1.GetRevisionRequest]) (*connect.Response[v1.Revision], error)- // Creates a new schema revision.- // Permissions required: bb.revisions.create- CreateRevision(context.Context, *connect.Request[v1.CreateRevisionRequest]) (*connect.Response[v1.Revision], error)// Creates multiple schema revisions in a single operation.// Permissions required: bb.revisions.createBatchCreateRevisions(context.Context, *connect.Request[v1.BatchCreateRevisionsRequest]) (*connect.Response[v1.BatchCreateRevisionsResponse], error)@@ -93,12 +87,6 @@ func NewRevisionServiceClient(httpClient connect.HTTPClient, baseURL string, optconnect.WithSchema(revisionServiceMethods.ByName("GetRevision")),connect.WithClientOptions(opts...),),- createRevision: connect.NewClient[v1.CreateRevisionRequest, v1.Revision](- httpClient,- baseURL+RevisionServiceCreateRevisionProcedure,- connect.WithSchema(revisionServiceMethods.ByName("CreateRevision")),- connect.WithClientOptions(opts...),- ),batchCreateRevisions: connect.NewClient[v1.BatchCreateRevisionsRequest, v1.BatchCreateRevisionsResponse](httpClient,baseURL+RevisionServiceBatchCreateRevisionsProcedure,@@ -118,7 +106,6 @@ func NewRevisionServiceClient(httpClient connect.HTTPClient, baseURL string, opttype revisionServiceClient struct {listRevisions *connect.Client[v1.ListRevisionsRequest, v1.ListRevisionsResponse]getRevision *connect.Client[v1.GetRevisionRequest, v1.Revision]- createRevision *connect.Client[v1.CreateRevisionRequest, v1.Revision]batchCreateRevisions *connect.Client[v1.BatchCreateRevisionsRequest, v1.BatchCreateRevisionsResponse]deleteRevision *connect.Client[v1.DeleteRevisionRequest, emptypb.Empty]}@@ -133,11 +120,6 @@ func (c *revisionServiceClient) GetRevision(ctx context.Context, req *connect.Rereturn c.getRevision.CallUnary(ctx, req)}-// CreateRevision calls bytebase.v1.RevisionService.CreateRevision.-func (c *revisionServiceClient) CreateRevision(ctx context.Context, req *connect.Request[v1.CreateRevisionRequest]) (*connect.Response[v1.Revision], error) {- return c.createRevision.CallUnary(ctx, req)-}-// BatchCreateRevisions calls bytebase.v1.RevisionService.BatchCreateRevisions.func (c *revisionServiceClient) BatchCreateRevisions(ctx context.Context, req *connect.Request[v1.BatchCreateRevisionsRequest]) (*connect.Response[v1.BatchCreateRevisionsResponse], error) {return c.batchCreateRevisions.CallUnary(ctx, req)@@ -156,9 +138,6 @@ type RevisionServiceHandler interface {// Retrieves a schema revision by name.// Permissions required: bb.revisions.getGetRevision(context.Context, *connect.Request[v1.GetRevisionRequest]) (*connect.Response[v1.Revision], error)- // Creates a new schema revision.- // Permissions required: bb.revisions.create- CreateRevision(context.Context, *connect.Request[v1.CreateRevisionRequest]) (*connect.Response[v1.Revision], error)// Creates multiple schema revisions in a single operation.// Permissions required: bb.revisions.createBatchCreateRevisions(context.Context, *connect.Request[v1.BatchCreateRevisionsRequest]) (*connect.Response[v1.BatchCreateRevisionsResponse], error)@@ -186,12 +165,6 @@ func NewRevisionServiceHandler(svc RevisionServiceHandler, opts ...connect.Handlconnect.WithSchema(revisionServiceMethods.ByName("GetRevision")),connect.WithHandlerOptions(opts...),)- revisionServiceCreateRevisionHandler := connect.NewUnaryHandler(- RevisionServiceCreateRevisionProcedure,- svc.CreateRevision,- connect.WithSchema(revisionServiceMethods.ByName("CreateRevision")),- connect.WithHandlerOptions(opts...),- )revisionServiceBatchCreateRevisionsHandler := connect.NewUnaryHandler(RevisionServiceBatchCreateRevisionsProcedure,svc.BatchCreateRevisions,@@ -210,8 +183,6 @@ func NewRevisionServiceHandler(svc RevisionServiceHandler, opts ...connect.HandlrevisionServiceListRevisionsHandler.ServeHTTP(w, r)case RevisionServiceGetRevisionProcedure:revisionServiceGetRevisionHandler.ServeHTTP(w, r)- case RevisionServiceCreateRevisionProcedure:- revisionServiceCreateRevisionHandler.ServeHTTP(w, r)case RevisionServiceBatchCreateRevisionsProcedure:revisionServiceBatchCreateRevisionsHandler.ServeHTTP(w, r)case RevisionServiceDeleteRevisionProcedure:@@ -233,10 +204,6 @@ func (UnimplementedRevisionServiceHandler) GetRevision(context.Context, *connectreturn nil, connect.NewError(connect.CodeUnimplemented, errors.New("bytebase.v1.RevisionService.GetRevision is not implemented"))}-func (UnimplementedRevisionServiceHandler) CreateRevision(context.Context, *connect.Request[v1.CreateRevisionRequest]) (*connect.Response[v1.Revision], error) {- return nil, connect.NewError(connect.CodeUnimplemented, errors.New("bytebase.v1.RevisionService.CreateRevision is not implemented"))-}-func (UnimplementedRevisionServiceHandler) BatchCreateRevisions(context.Context, *connect.Request[v1.BatchCreateRevisionsRequest]) (*connect.Response[v1.BatchCreateRevisionsResponse], error) {return nil, connect.NewError(connect.CodeUnimplemented, errors.New("bytebase.v1.RevisionService.BatchCreateRevisions is not implemented"))}diff --git a/backend/store/sheet.go b/backend/store/sheet.goindex f4e393b354..5c3893612f 100644--- a/backend/store/sheet.go+++ b/backend/store/sheet.go@@ -6,6 +6,7 @@ import ("database/sql""encoding/hex""fmt"+ "slices""github.com/pkg/errors"@@ -157,3 +158,32 @@ func (s *Store) CreateSheets(ctx context.Context, creates ...*SheetMessage) ([]*return creates, nil}++// HasSheets checks if all sheets exist by SHA256 hashes.+func (s *Store) HasSheets(ctx context.Context, sha256Hexes ...string) (bool, error) {+ if len(sha256Hexes) == 0 {+ return true, nil+ }++ // Remove duplicates+ slices.Sort(sha256Hexes)+ sha256Hexes = slices.Compact(sha256Hexes)++ q := qb.Q().Space(`+ SELECT COUNT(*)+ FROM sheet_blob+ WHERE sha256 IN (SELECT decode(unnest(CAST(? AS TEXT[])), 'hex'))`,+ sha256Hexes)++ query, args, err := q.ToSQL()+ if err != nil {+ return false, errors.Wrapf(err, "failed to build sql")+ }++ var count int+ if err := s.GetDB().QueryRowContext(ctx, query, args...).Scan(&count); err != nil {+ return false, err+ }++ return count == len(sha256Hexes), nil+}diff --git a/frontend/src/types/proto-es/v1/revision_service_pb.d.ts b/frontend/src/types/proto-es/v1/revision_service_pb.d.tsindex ce9d13f35d..f3d7387c14 100644--- a/frontend/src/types/proto-es/v1/revision_service_pb.d.ts+++ b/frontend/src/types/proto-es/v1/revision_service_pb.d.ts@@ -359,17 +359,6 @@ export declare const RevisionService: GenService<{input: typeof GetRevisionRequestSchema;output: typeof RevisionSchema;},- /**- * Creates a new schema revision.- * Permissions required: bb.revisions.create- *- * @generated from rpc bytebase.v1.RevisionService.CreateRevision- */- createRevision: {- methodKind: "unary";- input: typeof CreateRevisionRequestSchema;- output: typeof RevisionSchema;- },/*** Creates multiple schema revisions in a single operation.* Permissions required: bb.revisions.creatediff --git a/frontend/src/types/proto-es/v1/revision_service_pb.js b/frontend/src/types/proto-es/v1/revision_service_pb.jsindex 4233f3f8c0..9ee7f549c2 100644--- a/frontend/src/types/proto-es/v1/revision_service_pb.js+++ b/frontend/src/types/proto-es/v1/revision_service_pb.js@@ -14,7 +14,7 @@ import { file_v1_annotation } from "./annotation_pb";* Describes the file v1/revision_service.proto.*/export const file_v1_revision_service = /*@__PURE__*/- fileDesc("Chl2MS9yZXZpc2lvbl9zZXJ2aWNlLnByb3RvEgtieXRlYmFzZS52MSKCAQoUTGlzdFJldmlzaW9uc1JlcXVlc3QSLQoGcGFyZW50GAEgASgJQh3gQQL6QRcKFWJ5dGViYXNlLmNvbS9EYXRhYmFzZRIRCglwYWdlX3NpemUYAiABKAUSEgoKcGFnZV90b2tlbhgDIAEoCRIUCgxzaG93X2RlbGV0ZWQYBCABKAgiWgoVTGlzdFJldmlzaW9uc1Jlc3BvbnNlEigKCXJldmlzaW9ucxgBIAMoCzIVLmJ5dGViYXNlLnYxLlJldmlzaW9uEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSJ0ChVDcmVhdGVSZXZpc2lvblJlcXVlc3QSLQoGcGFyZW50GAEgASgJQh3gQQL6QRcKFWJ5dGViYXNlLmNvbS9EYXRhYmFzZRIsCghyZXZpc2lvbhgCIAEoCzIVLmJ5dGViYXNlLnYxLlJldmlzaW9uQgPgQQIihwEKG0JhdGNoQ3JlYXRlUmV2aXNpb25zUmVxdWVzdBItCgZwYXJlbnQYASABKAlCHeBBAvpBFwoVYnl0ZWJhc2UuY29tL0RhdGFiYXNlEjkKCHJlcXVlc3RzGAIgAygLMiIuYnl0ZWJhc2UudjEuQ3JlYXRlUmV2aXNpb25SZXF1ZXN0QgPgQQIiSAocQmF0Y2hDcmVhdGVSZXZpc2lvbnNSZXNwb25zZRIoCglyZXZpc2lvbnMYASADKAsyFS5ieXRlYmFzZS52MS5SZXZpc2lvbiJBChJHZXRSZXZpc2lvblJlcXVlc3QSKwoEbmFtZRgBIAEoCUId4EEC+kEXChVieXRlYmFzZS5jb20vUmV2aXNpb24iRAoVRGVsZXRlUmV2aXNpb25SZXF1ZXN0EisKBG5hbWUYASABKAlCHeBBAvpBFwoVYnl0ZWJhc2UuY29tL1JldmlzaW9uIs4ECghSZXZpc2lvbhIMCgRuYW1lGAEgASgJEioKB3JlbGVhc2UYAiABKAlCGfpBFgoUYnl0ZWJhc2UuY29tL1JlbGVhc2USNAoLY3JlYXRlX3RpbWUYAyABKAsyGi5nb29nbGUucHJvdG9idWYuVGltZXN0YW1wQgPgQQMSFAoHZGVsZXRlchgEIAEoCUID4EEDEjQKC2RlbGV0ZV90aW1lGAUgASgLMhouZ29vZ2xlLnByb3RvYnVmLlRpbWVzdGFtcEID4EEDEgwKBGZpbGUYBiABKAkSDwoHdmVyc2lvbhgHIAEoCRImCgVzaGVldBgIIAEoCUIX+kEUChJieXRlYmFzZS5jb20vU2hlZXQSGQoMc2hlZXRfc2hhMjU2GAkgASgJQgPgQQMSFgoJc3RhdGVtZW50GAogASgJQgPgQQMSGwoOc3RhdGVtZW50X3NpemUYCyABKANCA+BBAxIrCgh0YXNrX3J1bhgNIAEoCUIZ+kEWChRieXRlYmFzZS5jb20vVGFza1J1bhIoCgR0eXBlGA4gASgOMhouYnl0ZWJhc2UudjEuUmV2aXNpb24uVHlwZSI8CgRUeXBlEhQKEFRZUEVfVU5TUEVDSUZJRUQQABINCglWRVJTSU9ORUQQARIPCgtERUNMQVJBVElWRRACOlrqQVcKFWJ5dGViYXNlLmNvbS9SZXZpc2lvbhI+aW5zdGFuY2VzL3tpbnN0YW5jZX0vZGF0YWJhc2VzL3tkYXRhYmFzZX0vcmV2aXNpb25zL3tyZXZpc2lvbn0yhwcKD1JldmlzaW9uU2VydmljZRKwAQoNTGlzdFJldmlzaW9ucxIhLmJ5dGViYXNlLnYxLkxpc3RSZXZpc2lvbnNSZXF1ZXN0GiIuYnl0ZWJhc2UudjEuTGlzdFJldmlzaW9uc1Jlc3BvbnNlIljaQQZwYXJlbnSK6jARYmIucmV2aXNpb25zLmxpc3SQ6jABgtPkkwIwEi4vdjEve3BhcmVudD1pbnN0YW5jZXMvKi9kYXRhYmFzZXMvKn0vcmV2aXNpb25zEpwBCgtHZXRSZXZpc2lvbhIfLmJ5dGViYXNlLnYxLkdldFJldmlzaW9uUmVxdWVzdBoVLmJ5dGViYXNlLnYxLlJldmlzaW9uIlXaQQRuYW1liuowEGJiLnJldmlzaW9ucy5nZXSQ6jABgtPkkwIwEi4vdjEve25hbWU9aW5zdGFuY2VzLyovZGF0YWJhc2VzLyovcmV2aXNpb25zLyp9EqgBCg5DcmVhdGVSZXZpc2lvbhIiLmJ5dGViYXNlLnYxLkNyZWF0ZVJldmlzaW9uUmVxdWVzdBoVLmJ5dGViYXNlLnYxLlJldmlzaW9uIluK6jATYmIucmV2aXNpb25zLmNyZWF0ZZDqMAGC0+STAjo6CHJldmlzaW9uIi4vdjEve3BhcmVudD1pbnN0YW5jZXMvKi9kYXRhYmFzZXMvKn0vcmV2aXNpb25zEs0BChRCYXRjaENyZWF0ZVJldmlzaW9ucxIoLmJ5dGViYXNlLnYxLkJhdGNoQ3JlYXRlUmV2aXNpb25zUmVxdWVzdBopLmJ5dGViYXNlLnYxLkJhdGNoQ3JlYXRlUmV2aXNpb25zUmVzcG9uc2UiYIrqMBNiYi5yZXZpc2lvbnMuY3JlYXRlkOowAYLT5JMCPzoBKiI6L3YxL3twYXJlbnQ9aW5zdGFuY2VzLyovZGF0YWJhc2VzLyp9L3JldmlzaW9uczpiYXRjaENyZWF0ZRKmAQoORGVsZXRlUmV2aXNpb24SIi5ieXRlYmFzZS52MS5EZWxldGVSZXZpc2lvblJlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiWNpBBG5hbWWK6jATYmIucmV2aXNpb25zLmRlbGV0ZZDqMAGC0+STAjAqLi92MS97bmFtZT1pbnN0YW5jZXMvKi9kYXRhYmFzZXMvKi9yZXZpc2lvbnMvKn1CqgEKD2NvbS5ieXRlYmFzZS52MUIUUmV2aXNpb25TZXJ2aWNlUHJvdG9QAVo0Z2l0aHViLmNvbS9ieXRlYmFzZS9ieXRlYmFzZS9iYWNrZW5kL2dlbmVyYXRlZC1nby92MaICA0JYWKoCC0J5dGViYXNlLlYxygILQnl0ZWJhc2VcVjHiAhdCeXRlYmFzZVxWMVxHUEJNZXRhZGF0YeoCDEJ5dGViYXNlOjpWMWIGcHJvdG8z", [file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_timestamp, file_v1_annotation]);+ fileDesc("Chl2MS9yZXZpc2lvbl9zZXJ2aWNlLnByb3RvEgtieXRlYmFzZS52MSKCAQoUTGlzdFJldmlzaW9uc1JlcXVlc3QSLQoGcGFyZW50GAEgASgJQh3gQQL6QRcKFWJ5dGViYXNlLmNvbS9EYXRhYmFzZRIRCglwYWdlX3NpemUYAiABKAUSEgoKcGFnZV90b2tlbhgDIAEoCRIUCgxzaG93X2RlbGV0ZWQYBCABKAgiWgoVTGlzdFJldmlzaW9uc1Jlc3BvbnNlEigKCXJldmlzaW9ucxgBIAMoCzIVLmJ5dGViYXNlLnYxLlJldmlzaW9uEhcKD25leHRfcGFnZV90b2tlbhgCIAEoCSJ0ChVDcmVhdGVSZXZpc2lvblJlcXVlc3QSLQoGcGFyZW50GAEgASgJQh3gQQL6QRcKFWJ5dGViYXNlLmNvbS9EYXRhYmFzZRIsCghyZXZpc2lvbhgCIAEoCzIVLmJ5dGViYXNlLnYxLlJldmlzaW9uQgPgQQIihwEKG0JhdGNoQ3JlYXRlUmV2aXNpb25zUmVxdWVzdBItCgZwYXJlbnQYASABKAlCHeBBAvpBFwoVYnl0ZWJhc2UuY29tL0RhdGFiYXNlEjkKCHJlcXVlc3RzGAIgAygLMiIuYnl0ZWJhc2UudjEuQ3JlYXRlUmV2aXNpb25SZXF1ZXN0QgPgQQIiSAocQmF0Y2hDcmVhdGVSZXZpc2lvbnNSZXNwb25zZRIoCglyZXZpc2lvbnMYASADKAsyFS5ieXRlYmFzZS52MS5SZXZpc2lvbiJBChJHZXRSZXZpc2lvblJlcXVlc3QSKwoEbmFtZRgBIAEoCUId4EEC+kEXChVieXRlYmFzZS5jb20vUmV2aXNpb24iRAoVRGVsZXRlUmV2aXNpb25SZXF1ZXN0EisKBG5hbWUYASABKAlCHeBBAvpBFwoVYnl0ZWJhc2UuY29tL1JldmlzaW9uIs4ECghSZXZpc2lvbhIMCgRuYW1lGAEgASgJEioKB3JlbGVhc2UYAiABKAlCGfpBFgoUYnl0ZWJhc2UuY29tL1JlbGVhc2USNAoLY3JlYXRlX3RpbWUYAyABKAsyGi5nb29nbGUucHJvdG9idWYuVGltZXN0YW1wQgPgQQMSFAoHZGVsZXRlchgEIAEoCUID4EEDEjQKC2RlbGV0ZV90aW1lGAUgASgLMhouZ29vZ2xlLnByb3RvYnVmLlRpbWVzdGFtcEID4EEDEgwKBGZpbGUYBiABKAkSDwoHdmVyc2lvbhgHIAEoCRImCgVzaGVldBgIIAEoCUIX+kEUChJieXRlYmFzZS5jb20vU2hlZXQSGQoMc2hlZXRfc2hhMjU2GAkgASgJQgPgQQMSFgoJc3RhdGVtZW50GAogASgJQgPgQQMSGwoOc3RhdGVtZW50X3NpemUYCyABKANCA+BBAxIrCgh0YXNrX3J1bhgNIAEoCUIZ+kEWChRieXRlYmFzZS5jb20vVGFza1J1bhIoCgR0eXBlGA4gASgOMhouYnl0ZWJhc2UudjEuUmV2aXNpb24uVHlwZSI8CgRUeXBlEhQKEFRZUEVfVU5TUEVDSUZJRUQQABINCglWRVJTSU9ORUQQARIPCgtERUNMQVJBVElWRRACOlrqQVcKFWJ5dGViYXNlLmNvbS9SZXZpc2lvbhI+aW5zdGFuY2VzL3tpbnN0YW5jZX0vZGF0YWJhc2VzL3tkYXRhYmFzZX0vcmV2aXNpb25zL3tyZXZpc2lvbn0y3AUKD1JldmlzaW9uU2VydmljZRKwAQoNTGlzdFJldmlzaW9ucxIhLmJ5dGViYXNlLnYxLkxpc3RSZXZpc2lvbnNSZXF1ZXN0GiIuYnl0ZWJhc2UudjEuTGlzdFJldmlzaW9uc1Jlc3BvbnNlIljaQQZwYXJlbnSK6jARYmIucmV2aXNpb25zLmxpc3SQ6jABgtPkkwIwEi4vdjEve3BhcmVudD1pbnN0YW5jZXMvKi9kYXRhYmFzZXMvKn0vcmV2aXNpb25zEpwBCgtHZXRSZXZpc2lvbhIfLmJ5dGViYXNlLnYxLkdldFJldmlzaW9uUmVxdWVzdBoVLmJ5dGViYXNlLnYxLlJldmlzaW9uIlXaQQRuYW1liuowEGJiLnJldmlzaW9ucy5nZXSQ6jABgtPkkwIwEi4vdjEve25hbWU9aW5zdGFuY2VzLyovZGF0YWJhc2VzLyovcmV2aXNpb25zLyp9Es0BChRCYXRjaENyZWF0ZVJldmlzaW9ucxIoLmJ5dGViYXNlLnYxLkJhdGNoQ3JlYXRlUmV2aXNpb25zUmVxdWVzdBopLmJ5dGViYXNlLnYxLkJhdGNoQ3JlYXRlUmV2aXNpb25zUmVzcG9uc2UiYIrqMBNiYi5yZXZpc2lvbnMuY3JlYXRlkOowAYLT5JMCPzoBKiI6L3YxL3twYXJlbnQ9aW5zdGFuY2VzLyovZGF0YWJhc2VzLyp9L3JldmlzaW9uczpiYXRjaENyZWF0ZRKmAQoORGVsZXRlUmV2aXNpb24SIi5ieXRlYmFzZS52MS5EZWxldGVSZXZpc2lvblJlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiWNpBBG5hbWWK6jATYmIucmV2aXNpb25zLmRlbGV0ZZDqMAGC0+STAjAqLi92MS97bmFtZT1pbnN0YW5jZXMvKi9kYXRhYmFzZXMvKi9yZXZpc2lvbnMvKn1CqgEKD2NvbS5ieXRlYmFzZS52MUIUUmV2aXNpb25TZXJ2aWNlUHJvdG9QAVo0Z2l0aHViLmNvbS9ieXRlYmFzZS9ieXRlYmFzZS9iYWNrZW5kL2dlbmVyYXRlZC1nby92MaICA0JYWKoCC0J5dGViYXNlLlYxygILQnl0ZWJhc2VcVjHiAhdCeXRlYmFzZVxWMVxHUEJNZXRhZGF0YeoCDEJ5dGViYXNlOjpWMWIGcHJvdG8z", [file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_timestamp, file_v1_annotation]);/*** Describes the message bytebase.v1.ListRevisionsRequest.diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yamlindex 78f8c3add2..7eec47373a 100644--- a/proto/gen/grpc-doc/openapi.yaml+++ b/proto/gen/grpc-doc/openapi.yaml@@ -1987,45 +1987,6 @@ paths:application/json:schema:$ref: '#/components/schemas/Status'- post:- tags:- - RevisionService- description: |-- Creates a new schema revision.- Permissions required: bb.revisions.create- operationId: RevisionService_CreateRevision- parameters:- - name: instance- in: path- description: The instance id.- required: true- schema:- type: string- - name: database- in: path- description: The database id.- required: true- schema:- type: string- requestBody:- content:- application/json:- schema:- $ref: '#/components/schemas/Revision'- required: true- responses:- "200":- description: OK- content:- application/json:- schema:- $ref: '#/components/schemas/Revision'- default:- description: Default error response- content:- application/json:- schema:- $ref: '#/components/schemas/Status'/v1/instances/{instance}/databases/{database}/revisions/{revision}:get:tags:diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.mdindex f29b7d6045..d136e4e660 100644--- a/proto/gen/grpc-doc/v1/README.md+++ b/proto/gen/grpc-doc/v1/README.md@@ -9314,7 +9314,6 @@ RevisionService manages schema revision history.| ----------- | ------------ | ------------- | ------------|| ListRevisions | [ListRevisionsRequest](#bytebase-v1-ListRevisionsRequest) | [ListRevisionsResponse](#bytebase-v1-ListRevisionsResponse) | Lists schema revisions for a database. Permissions required: bb.revisions.list || GetRevision | [GetRevisionRequest](#bytebase-v1-GetRevisionRequest) | [Revision](#bytebase-v1-Revision) | Retrieves a schema revision by name. Permissions required: bb.revisions.get |-| CreateRevision | [CreateRevisionRequest](#bytebase-v1-CreateRevisionRequest) | [Revision](#bytebase-v1-Revision) | Creates a new schema revision. Permissions required: bb.revisions.create || BatchCreateRevisions | [BatchCreateRevisionsRequest](#bytebase-v1-BatchCreateRevisionsRequest) | [BatchCreateRevisionsResponse](#bytebase-v1-BatchCreateRevisionsResponse) | Creates multiple schema revisions in a single operation. Permissions required: bb.revisions.create || DeleteRevision | [DeleteRevisionRequest](#bytebase-v1-DeleteRevisionRequest) | [.google.protobuf.Empty](#google-protobuf-Empty) | Deletes a schema revision. Permissions required: bb.revisions.delete |diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.htmlindex c4a9be76aa..99087d5713 100644--- a/proto/gen/grpc-doc/v1/index.html+++ b/proto/gen/grpc-doc/v1/index.html@@ -26383,14 +26383,6 @@ Permissions required: bb.revisions.list</p></td>Permissions required: bb.revisions.get</p></td></tr>- <tr>- <td>CreateRevision</td>- <td><a href="#bytebase.v1.CreateRevisionRequest">CreateRevisionRequest</a></td>- <td><a href="#bytebase.v1.Revision">Revision</a></td>- <td><p>Creates a new schema revision.-Permissions required: bb.revisions.create</p></td>- </tr>-<tr><td>BatchCreateRevisions</td><td><a href="#bytebase.v1.BatchCreateRevisionsRequest">BatchCreateRevisionsRequest</a></td>@@ -26447,16 +26439,6 @@ Permissions required: bb.revisions.delete</p></td>- <tr>- <td>CreateRevision</td>- <td>POST</td>- <td>/v1/{parent=instances/*/databases/*}/revisions</td>- <td>revision</td>- </tr>----<tr><td>BatchCreateRevisions</td><td>POST</td>diff --git a/proto/v1/v1/revision_service.proto b/proto/v1/v1/revision_service.protoindex 39976cf512..be2dd93502 100644--- a/proto/v1/v1/revision_service.proto+++ b/proto/v1/v1/revision_service.proto@@ -32,17 +32,6 @@ service RevisionService {option (bytebase.v1.auth_method) = IAM;}- // Creates a new schema revision.- // Permissions required: bb.revisions.create- rpc CreateRevision(CreateRevisionRequest) returns (Revision) {- option (google.api.http) = {- post: "/v1/{parent=instances/*/databases/*}/revisions"- body: "revision"- };- option (bytebase.v1.permission) = "bb.revisions.create";- option (bytebase.v1.auth_method) = IAM;- }-// Creates multiple schema revisions in a single operation.// Permissions required: bb.revisions.createrpc BatchCreateRevisions(BatchCreateRevisionsRequest) returns (BatchCreateRevisionsResponse) {