Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
docs(proto): REQUIRE_PRIMARY_KEY judges the change, not the existing schema
rebeliced72baa7416c1
diff --git a/backend/generated-go/v1/review_rule.pb.go b/backend/generated-go/v1/review_rule.pb.goindex 70ff6b22b9..44eb285906 100644--- a/backend/generated-go/v1/review_rule.pb.go+++ b/backend/generated-go/v1/review_rule.pb.go@@ -47,7 +47,9 @@ const (ReviewRule_DISALLOW_DROP_CONSTRAINT ReviewRule_Type = 9// P1: renaming a table or column.ReviewRule_DISALLOW_RENAME ReviewRule_Type = 10- // P1: a table still has no primary key at the end of the change.+ // P1: the change creates a table without a primary key, or drops a+ // primary key without adding one back. A table that already lacked a+ // primary key before the change is not reported.ReviewRule_REQUIRE_PRIMARY_KEY ReviewRule_Type = 11)diff --git a/frontend/src/types/proto-es/v1/review_rule_pb.d.ts b/frontend/src/types/proto-es/v1/review_rule_pb.d.tsindex 09015877bf..4b5da61b6a 100644--- a/frontend/src/types/proto-es/v1/review_rule_pb.d.ts+++ b/frontend/src/types/proto-es/v1/review_rule_pb.d.ts@@ -116,7 +116,9 @@ export enum ReviewRule_Type {DISALLOW_RENAME = 10,/**- * P1: a table still has no primary key at the end of the change.+ * P1: the change creates a table without a primary key, or drops a+ * primary key without adding one back. A table that already lacked a+ * primary key before the change is not reported.** @generated from enum value: REQUIRE_PRIMARY_KEY = 11;*/diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.mdindex 39e7df9ef5..e885382f26 100644--- a/proto/gen/grpc-doc/v1/README.md+++ b/proto/gen/grpc-doc/v1/README.md@@ -3400,7 +3400,7 @@ top-level TRUNCATE and RENAME values.| DISALLOW_TRUNCATE | 8 | P1: TRUNCATE. || DISALLOW_DROP_CONSTRAINT | 9 | P1: dropping a PRIMARY KEY, FOREIGN KEY, UNIQUE, or CHECK constraint. || DISALLOW_RENAME | 10 | P1: renaming a table or column. |-| REQUIRE_PRIMARY_KEY | 11 | P1: a table still has no primary key at the end of the change. |+| REQUIRE_PRIMARY_KEY | 11 | P1: the change creates a table without a primary key, or drops a primary key without adding one back. A table that already lacked a primary key before the change is not reported. |diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.htmlindex 619da33273..3b465dce7a 100644--- a/proto/gen/grpc-doc/v1/index.html+++ b/proto/gen/grpc-doc/v1/index.html@@ -10420,7 +10420,9 @@ NULL with IS NULL or IS NOT NULL.</p></td><tr><td>REQUIRE_PRIMARY_KEY</td><td>11</td>- <td><p>P1: a table still has no primary key at the end of the change.</p></td>+ <td><p>P1: the change creates a table without a primary key, or drops a+primary key without adding one back. A table that already lacked a+primary key before the change is not reported.</p></td></tr></tbody>diff --git a/proto/v1/v1/review_rule.proto b/proto/v1/v1/review_rule.protoindex 2ab99ee36e..0ec4fa3c51 100644--- a/proto/v1/v1/review_rule.proto+++ b/proto/v1/v1/review_rule.proto@@ -42,7 +42,9 @@ message ReviewRule {DISALLOW_DROP_CONSTRAINT = 9;// P1: renaming a table or column.DISALLOW_RENAME = 10;- // P1: a table still has no primary key at the end of the change.+ // P1: the change creates a table without a primary key, or drops a+ // primary key without adding one back. A table that already lacked a+ // primary key before the change is not reported.REQUIRE_PRIMARY_KEY = 11;}}