Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: database permission check for query (#18187)

ecmadaodb074db6af4e
diff --git a/backend/api/v1/sql_service.go b/backend/api/v1/sql_service.go
index 0347a4e773..bc1427f78f 100644
--- a/backend/api/v1/sql_service.go
+++ b/backend/api/v1/sql_service.go
@@ -1440,6 +1440,7 @@ func BuildListDatabaseNamesFunc(storeInstance *store.Store) parserbase.ListDatab
}
}
+// accessCheck check the access for the database. Do not support cross-project resources.
func (s *SQLService) accessCheck(
ctx context.Context,
instance *store.InstanceMessage,
@@ -1456,6 +1457,35 @@ func (s *SQLService) accessCheck(
return connect.NewError(connect.CodeInvalidArgument, errors.Errorf("project %q not found", database.ProjectID))
}
+ workspacePolicy, err := s.store.GetWorkspaceIamPolicy(ctx)
+ if err != nil {
+ return connect.NewError(connect.CodeInternal, errors.Errorf("failed to get workspace iam policy, error: %v", err))
+ }
+
+ projectPolicy, err := s.store.GetProjectIamPolicy(ctx, project.ResourceID)
+ if err != nil {
+ return connect.NewError(connect.CodeInternal, errors.New(err.Error()))
+ }
+
+ checkDatabaseAccess := func() error {
+ databaseFullName := common.FormatDatabase(instance.ResourceID, database.DatabaseName)
+ ok, err := s.hasDatabaseAccessRights(ctx, user, []*storepb.IamPolicy{workspacePolicy.Policy, projectPolicy.Policy}, map[string]any{
+ common.CELAttributeRequestTime: time.Now(),
+ common.CELAttributeResourceDatabase: databaseFullName,
+ })
+ if err != nil {
+ return connect.NewError(connect.CodeInternal, errors.Errorf("failed to check access control for database: %q, error %v", databaseFullName, err))
+ }
+ if !ok {
+ return connect.NewError(connect.CodePermissionDenied, errors.Errorf("user %q does not have permission for database %q", user.Email, databaseFullName))
+ }
+ return nil
+ }
+
+ if len(spans) == 0 {
+ return checkDatabaseAccess()
+ }
+
for _, span := range spans {
// New query ACL experience.
if common.EngineSupportQueryNewACL(instance.Metadata.GetEngine()) {
@@ -1494,6 +1524,12 @@ func (s *SQLService) accessCheck(
}
}
if span.Type == parserbase.Select {
+ if len(span.SourceColumns) == 0 {
+ if err := checkDatabaseAccess(); err != nil {
+ return err
+ }
+ }
+
var deniedResources []string
for column := range span.SourceColumns {
attributes := map[string]any{
@@ -1502,36 +1538,6 @@ func (s *SQLService) accessCheck(
common.CELAttributeResourceSchemaName: column.Schema,
common.CELAttributeResourceTableName: column.Table,
}
-
- databaseMessage, err := s.store.GetDatabaseV2(ctx, &store.FindDatabaseMessage{
- InstanceID: &instance.ResourceID,
- DatabaseName: &column.Database,
- IsCaseSensitive: store.IsObjectCaseSensitive(instance),
- })
- if err != nil {
- return err
- }
- if databaseMessage == nil {
- return connect.NewError(connect.CodeInvalidArgument, errors.Errorf("database %q not found", column.Database))
- }
- project, err := s.store.GetProjectV2(ctx, &store.FindProjectMessage{ResourceID: &databaseMessage.ProjectID})
- if err != nil {
- return err
- }
- if project == nil {
- return connect.NewError(connect.CodeInvalidArgument, errors.Errorf("project %q not found", databaseMessage.ProjectID))
- }
-
- workspacePolicy, err := s.store.GetWorkspaceIamPolicy(ctx)
- if err != nil {
- return connect.NewError(connect.CodeInternal, errors.Errorf("failed to get workspace iam policy, error: %v", err))
- }
- // Allow query databases across different projects.
- projectPolicy, err := s.store.GetProjectIamPolicy(ctx, project.ResourceID)
- if err != nil {
- return connect.NewError(connect.CodeInternal, errors.New(err.Error()))
- }
-
ok, err := s.hasDatabaseAccessRights(ctx, user, []*storepb.IamPolicy{workspacePolicy.Policy, projectPolicy.Policy}, attributes)
if err != nil {
return connect.NewError(connect.CodeInternal, errors.Errorf("failed to check access control for database: %q, error %v", column.Database, err))
diff --git a/backend/runner/taskrun/data_export_executor.go b/backend/runner/taskrun/data_export_executor.go
index 675b86b225..73404827b5 100644
--- a/backend/runner/taskrun/data_export_executor.go
+++ b/backend/runner/taskrun/data_export_executor.go
@@ -74,7 +74,7 @@ func (exec *DataExportExecutor) RunOnce(ctx context.Context, _ context.Context,
Format: v1pb.ExportFormat(task.Payload.GetFormat()),
Password: "", /* do not pass the password, we will encrypt the files will password when users download them */
}
- bytes, _, exportErr := apiv1.DoExport(ctx, exec.store, exec.dbFactory, exec.license, exportRequest, issue.Creator /* user */, instance, database, nil, exec.schemaSyncer, dataSource)
+ bytes, _, exportErr := apiv1.DoExport(ctx, exec.store, exec.dbFactory, exec.license, exportRequest, issue.Creator /* user */, instance, database, nil /* access check */, exec.schemaSyncer, dataSource)
if exportErr != nil {
return true, nil, errors.Wrap(exportErr, "failed to export data")
}
diff --git a/frontend/src/components/ProjectMember/ProjectMemberRolePanel/index.vue b/frontend/src/components/ProjectMember/ProjectMemberRolePanel/index.vue
index e24d96fef8..c8b088c666 100644
--- a/frontend/src/components/ProjectMember/ProjectMemberRolePanel/index.vue
+++ b/frontend/src/components/ProjectMember/ProjectMemberRolePanel/index.vue
@@ -52,7 +52,7 @@
<div v-for="role in roleList" :key="role.role" class="mb-4">
<template v-if="role.singleBindingList.length > 0">
<div
- class="w-full px-2 py-2 flex flex-row justify-start items-center"
+ class="w-full px-2 py-2 flex flex-row justify-start items-center gap-x-1"
>
<span class="textlabel">{{ displayRoleTitle(role.role) }}</span>
<NTooltip
@@ -62,15 +62,13 @@
"
>
<template #trigger>
- <NButton
- tag="div"
- text
- class="cursor-pointer opacity-60 hover:opacity-100"
+ <MiniActionButton
+ type="error"
:disabled="!allowRemoveRole(role.role)"
- @click="handleDeleteRole(role.role)"
+ @click.prevent="handleDeleteRole(role.role)"
>
- <heroicons-outline:trash class="w-4 h-4 ml-1" />
- </NButton>
+ <TrashIcon class="w-4 h-4" />
+ </MiniActionButton>
</template>
<div>
{{ $t("project.members.cannot-remove-last-owner") }}
@@ -146,7 +144,12 @@ import { BBButtonConfirm } from "@/bbkit";
import type { MemberBinding } from "@/components/Member/types";
import GroupMemberNameCell from "@/components/User/Settings/UserDataTableByGroup/cells/GroupMemberNameCell.vue";
import GroupNameCell from "@/components/User/Settings/UserDataTableByGroup/cells/GroupNameCell.vue";
-import { Drawer, DrawerContent, InstanceV1Name } from "@/components/v2";
+import {
+ Drawer,
+ DrawerContent,
+ InstanceV1Name,
+ MiniActionButton,
+} from "@/components/v2";
import {
batchGetOrFetchDatabases,
extractGroupEmail,
@@ -319,9 +322,8 @@ const getDataTableColumns = (
key: "operations",
width: 32,
render: (singleBinding) => (
- <div class="flex justify-end pr-2 gap-x-2">
- <NButton
- text
+ <div class="flex justify-end pr-2 gap-x-1">
+ <MiniActionButton
onClick={() => {
editingBinding.value = create(BindingSchema, {
role: role,
@@ -332,16 +334,15 @@ const getDataTableColumns = (
}}
>
<PencilIcon class="w-4 h-4" />
- </NButton>
+ </MiniActionButton>
{(roleList.value.find((r) => r.role === role)?.singleBindingList
?.length ?? 0) > 1 && (
<NTooltip
disabled={allowDeleteCondition(singleBinding)}
v-slots={{
trigger: () => (
- <NButton
- text
- class="cursor-pointer opacity-60 hover:opacity-100"
+ <MiniActionButton
+ type="error"
disabled={!allowDeleteCondition(singleBinding)}
onClick={() => {
const item = roleList.value.find((r) => r.role === role);
@@ -355,7 +356,7 @@ const getDataTableColumns = (
}}
>
<TrashIcon class="w-4 h-4" />
- </NButton>
+ </MiniActionButton>
),
default: () => t("project.members.cannot-remove-last-owner"),
}}
diff --git a/frontend/src/store/modules/v1/projectIamPolicy.ts b/frontend/src/store/modules/v1/projectIamPolicy.ts
index 5bac86e69d..88c23fb318 100644
--- a/frontend/src/store/modules/v1/projectIamPolicy.ts
+++ b/frontend/src/store/modules/v1/projectIamPolicy.ts
@@ -249,9 +249,8 @@ export const checkQuerierPermission = (
}
}
return false;
- } else {
- return true;
}
+ return true;
}
);
};
diff --git a/frontend/src/views/sql-editor/ConnectionPanel/ConnectionPane/tree.ts b/frontend/src/views/sql-editor/ConnectionPanel/ConnectionPane/tree.ts
index 1a5ec55b84..9c1222af35 100644
--- a/frontend/src/views/sql-editor/ConnectionPanel/ConnectionPane/tree.ts
+++ b/frontend/src/views/sql-editor/ConnectionPanel/ConnectionPane/tree.ts
@@ -54,6 +54,8 @@ export const useSQLEditorTreeByEnvironment = (
const currentUser = useCurrentUserV1();
const environmentStore = useEnvironmentV1Store();
+ const tree = ref<TreeNode[]>([]);
+ const showMissingQueryDatabases = ref<boolean>(false);
const databaseList = ref<ComposedDatabase[]>([]);
const fetchDataState = ref<{
loading: boolean;
@@ -82,11 +84,19 @@ export const useSQLEditorTreeByEnvironment = (
{ deep: true }
);
- const fetchDatabases = useDebounceFn(async (filter?: DatabaseFilter) => {
- fetchDataState.value.loading = true;
- const pageToken = fetchDataState.value.nextPageToken;
+ // fetchMultiPageDatabases will fetch databases with multi-pages (maximum 5).
+ // The filteredDatabaseList will filter databases by the permission,
+ // so we may need to fetch database for multi-pages to avoid empty databases in the UI.
+ const fetchMultiPageDatabases = async (filter?: DatabaseFilter) => {
+ let pageToken = fetchDataState.value.nextPageToken;
+ const response: ComposedDatabase[] = [];
+
+ // Try to fetch 5 pages.
+ // TODO: support list databases with specific permissions via the API.
+ let i = 5;
+ while (i > 0) {
+ i--;
- try {
const { databases, nextPageToken } = await databaseStore.fetchDatabases({
parent: project.value,
pageToken,
@@ -96,7 +106,30 @@ export const useSQLEditorTreeByEnvironment = (
environment,
},
});
+ response.push(...databases);
+ pageToken = nextPageToken;
+
+ if (showMissingQueryDatabases.value) {
+ break;
+ }
+ if (databases.some((db) => isDatabaseV1Queryable(db))) {
+ break;
+ }
+ }
+ return {
+ nextPageToken: pageToken,
+ databases: response,
+ };
+ };
+
+ const fetchDatabases = useDebounceFn(async (filter?: DatabaseFilter) => {
+ fetchDataState.value.loading = true;
+ const pageToken = fetchDataState.value.nextPageToken;
+
+ try {
+ const { databases, nextPageToken } =
+ await fetchMultiPageDatabases(filter);
if (pageToken) {
databaseList.value.push(...databases);
} else {
@@ -126,9 +159,6 @@ export const useSQLEditorTreeByEnvironment = (
return databaseList.value;
});
- const tree = ref<TreeNode[]>([]);
- const showMissingQueryDatabases = ref<boolean>(false);
-
const buildTree = () => {
tree.value = buildTreeImpl(filteredDatabaseList.value, [
defaultEnvironmentFactor.factor,
diff --git a/frontend/src/views/sql-editor/EditorCommon/EditorAction.vue b/frontend/src/views/sql-editor/EditorCommon/EditorAction.vue
index 721c8ad21f..c9c0adcf7f 100644
--- a/frontend/src/views/sql-editor/EditorCommon/EditorAction.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/EditorAction.vue
@@ -168,7 +168,11 @@ import {
} from "@/types";
import { Engine } from "@/types/proto-es/v1/common_pb";
import { PlanFeature } from "@/types/proto-es/v1/subscription_service_pb";
-import { isWorksheetWritableV1, keyboardShortcutStr } from "@/utils";
+import {
+ isDatabaseV1Queryable,
+ isWorksheetWritableV1,
+ keyboardShortcutStr,
+} from "@/utils";
import { useSQLEditorContext } from "../context";
import AdminModeButton from "./AdminModeButton.vue";
import ContainerChooser from "./ContainerChooser.vue";
@@ -206,7 +210,7 @@ const isEmptyStatement = computed(() => {
}
return tab.statement === "";
});
-const { instance } = useConnectionOfCurrentSQLEditorTab();
+const { instance, database } = useConnectionOfCurrentSQLEditorTab();
const { t } = useI18n();
const showSheetsFeature = computed(() => {
@@ -231,7 +235,8 @@ const allowQuery = computed(() => {
if (instance.value.engine === Engine.COSMOSDB) {
return !!currentTab.value?.connection.table;
}
- return true;
+
+ return isDatabaseV1Queryable(database.value);
});
const canWriteSheet = computed(() => {