Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(tsql): honor instance case sensitivity when matching CTE targets

rebelicedcedbb4fc9ee
diff --git a/backend/plugin/parser/tsql/backup.go b/backend/plugin/parser/tsql/backup.go
index 2cc2ac77b7..b64d014a21 100644
--- a/backend/plugin/parser/tsql/backup.go
+++ b/backend/plugin/parser/tsql/backup.go
@@ -51,8 +51,8 @@ type statementInfo struct {
endPosition *storepb.Position
}
-func TransformDMLToSelect(_ context.Context, _ base.TransformContext, statement string, sourceDatabase string, targetDatabase string, tablePrefix string) ([]base.BackupStatement, error) {
- statementInfoList, err := prepareTransformation(sourceDatabase, statement)
+func TransformDMLToSelect(_ context.Context, tCtx base.TransformContext, statement string, sourceDatabase string, targetDatabase string, tablePrefix string) ([]base.BackupStatement, error) {
+ statementInfoList, err := prepareTransformation(sourceDatabase, statement, tCtx.IsCaseSensitive)
if err != nil {
return nil, errors.Wrap(err, "failed to prepare transformation")
}
@@ -221,13 +221,18 @@ func dmlWithClause(node ast.Node) *ast.WithClause {
// isCTETarget reports whether an unqualified DML target names a CTE declared
// by the statement's own WITH clause. Such a DML writes through the CTE to a
// base table the backup cannot resolve, so the caller rejects it rather than
-// letting the migration run without backup data.
-func isCTETarget(ref *ast.TableRef, withClause *ast.WithClause) bool {
+// letting the migration run without backup data. Name comparison follows the
+// instance collation: a case-sensitive collation keeps c and C distinct.
+func isCTETarget(ref *ast.TableRef, withClause *ast.WithClause, caseSensitive bool) bool {
if ref == nil || withClause == nil || withClause.CTEs == nil || ref.Database != "" || ref.Schema != "" {
return false
}
for _, cteNode := range withClause.CTEs.Items {
- if cte, ok := cteNode.(*ast.CommonTableExpr); ok && strings.EqualFold(cte.Name, ref.Object) {
+ cte, ok := cteNode.(*ast.CommonTableExpr)
+ if !ok {
+ continue
+ }
+ if cte.Name == ref.Object || (!caseSensitive && strings.EqualFold(cte.Name, ref.Object)) {
return true
}
}
@@ -253,7 +258,7 @@ func extractSuffixSelectStatement(node ast.Node, source string) (string, string,
}
}
-func prepareTransformation(databaseName, statement string) ([]statementInfo, error) {
+func prepareTransformation(databaseName, statement string, caseSensitive bool) ([]statementInfo, error) {
parsedStatements, err := parseTSQLStatements(statement)
if err != nil {
return nil, errors.Wrap(err, "failed to parse statement")
@@ -293,7 +298,7 @@ func prepareTransformation(databaseName, statement string) ([]statementInfo, err
"statementType", statementType)
continue
}
- if isCTETarget(targetRef, dmlWithClause(node)) {
+ if isCTETarget(targetRef, dmlWithClause(node), caseSensitive) {
return nil, errors.Errorf("prior backup does not support DML targeting CTE %q, target the base table directly", table.Table)
}
table.StatementType = statementType
diff --git a/backend/plugin/parser/tsql/backup_test.go b/backend/plugin/parser/tsql/backup_test.go
index a812063384..05e5314985 100644
--- a/backend/plugin/parser/tsql/backup_test.go
+++ b/backend/plugin/parser/tsql/backup_test.go
@@ -215,6 +215,21 @@ func TestBackupRejectsCTETarget(t *testing.T) {
require.Len(t, result, 1)
require.Equal(t, "c", result[0].SourceTableName)
require.True(t, strings.HasPrefix(result[0].Statement, "WITH c AS (SELECT id FROM src)\n"), result[0].Statement)
+
+ // Under a case-sensitive collation, c and C are different identifiers.
+ caseSensitive := base.TransformContext{IsCaseSensitive: true}
+ result, err = TransformDMLToSelect(context.Background(), caseSensitive, "WITH C AS (SELECT id FROM src) UPDATE c SET c1 = 1 WHERE id IN (SELECT id FROM C);", "db", "backupDB", "rollback")
+ require.NoError(t, err)
+ require.Len(t, result, 1)
+ require.Equal(t, "c", result[0].SourceTableName)
+ require.Equal(t, strings.Join([]string{
+ "WITH C AS (SELECT id FROM src)",
+ "SELECT * INTO [backupDB].[dbo].[rollback_c_db] FROM (",
+ " SELECT [db].[dbo].[c].* FROM c WHERE id IN (SELECT id FROM C)) AS backup_table;",
+ }, "\n"), result[0].Statement)
+ _, err = TransformDMLToSelect(context.Background(), caseSensitive, "WITH c AS (SELECT id, c1 FROM test) UPDATE c SET c1 = 1 WHERE id = 1;", "db", "backupDB", "rollback")
+ require.Error(t, err)
+ require.Contains(t, err.Error(), `does not support DML targeting CTE "c"`)
}
func TestBackup(t *testing.T) {