Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
test(e2e): restore variable-height issue fixtures and enforce them
zchpetere403a263494a
diff --git a/frontend/tests/e2e/framework/api-client.ts b/frontend/tests/e2e/framework/api-client.tsindex 9fa3377d2b..b76804e690 100644--- a/frontend/tests/e2e/framework/api-client.ts+++ b/frontend/tests/e2e/framework/api-client.ts@@ -657,6 +657,15 @@ export class BytebaseApiClient {// so the HTTP body is the IssueComment payload directly. Used by the// markdown-link spec (BYT-9664) to seed a comment with links via the API// rather than driving the review popover.+ // Set an issue's description (AIP-134 PATCH with an explicit update_mask —+ // the backend rejects unnamed paths since T15/#21279).+ async updateIssueDescription(issueName: string, description: string): Promise<void> {+ await this.request(+ "PATCH", `/v1/${issueName}?updateMask=description`,+ { name: issueName, description },+ );+ }+async createIssueComment(issueName: string, comment: string): Promise<{ name: string }> {return this.request<{ name: string }>("POST", `/v1/${issueName}:comment`, {comment,diff --git a/frontend/tests/e2e/scroll-restoration/dashboard-scroll-restoration.spec.ts b/frontend/tests/e2e/scroll-restoration/dashboard-scroll-restoration.spec.tsindex e995850d85..4a7bd19b2d 100644--- a/frontend/tests/e2e/scroll-restoration/dashboard-scroll-restoration.spec.ts+++ b/frontend/tests/e2e/scroll-restoration/dashboard-scroll-restoration.spec.ts@@ -77,6 +77,15 @@ async function expectBackRestored({const rows = page.getByTestId(rowTestId);await expect(rows.first()).toBeVisible({ timeout: 20_000 });await loadAllRows(rows, rowCount);+ // The fixtures are variable-height BY CONTRACT:each issue carries (i % 4) + 1+ // description lines matching the search, and IssueTable auto-expands matching+ // rows. Assert the expansion is really rendered so a silently failed+ // description write (or a future fixture "simplification") cannot flatten the+ // list back into uniformly collapsed rows and quietly weaken what these+ // restoration tests cover.+ await expect(rows.first()).toContainText("variable-height content", {+ timeout: 10_000,+ });// Mimic a real user dwelling on the loaded list before drilling into a row.// The app persists its paged-data snapshot in a passive effect that runs after@@ -160,7 +169,7 @@ test.beforeAll(async ({ browser }) => {// the real create + submit workflow and stays correct if it changes again.await page.setViewportSize({ width: 1280, height: 900 }); // the create page needs roomfor (let i = 0; i < ISSUE_COUNT; i++) {- await createDatabaseChangePlanViaUI(page, {+ const { planId } = await createDatabaseChangePlanViaUI(page, {baseURL: env.baseURL,projectId,database: env.database,@@ -168,6 +177,21 @@ test.beforeAll(async ({ browser }) => {sql: "SELECT 1;",});await submitDraftForReviewViaUI(page);+ // Variable-height rows: IssueTable auto-expands a row whose DESCRIPTION+ // matches the search query, so give each issue (i % 4) + 1 matching lines+ // — the restore must reproduce a list of unevenly sized expanded rows, not+ // uniformly collapsed ones. The description is fixture data, not the+ // workflow under test, so it is set through the API on the UI-created+ // issue (resolved from Plan.issue).+ const plan = await env.api.getPlan(`${env.project}/plans/${planId}`);+ if (!plan.issue) throw new Error(`plan ${planId} has no review issue`);+ await env.api.updateIssueDescription(+ plan.issue,+ Array.from(+ { length: (i % 4) + 1 },+ () => `${searchToken} variable-height content`,+ ).join("\n"),+ );}await page.setViewportSize({ width: 600, height: 720 });});