Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(frontend): migrate project database detail routes to react (#19904)
p0nyeb88d65828f5
diff --git a/docs/superpowers/specs/2026-04-08-project-database-detail-react-migration-design.md b/docs/superpowers/specs/2026-04-08-project-database-detail-react-migration-design.mdnew file mode 100644index 0000000000..72af956f65--- /dev/null+++ b/docs/superpowers/specs/2026-04-08-project-database-detail-react-migration-design.md@@ -0,0 +1,231 @@+# Project Database Detail React Migration++## Summary++Migrate the project-scoped database changelog detail route from Vue to React, remove the Vue-only `ProjectDatabaseLayout.vue` parent route, and introduce a shared React database-detail bootstrap layer that both changelog detail and revision detail use.++This does **not** migrate the main database detail page in the same change. That page remains Vue temporarily, but it must stop depending on the removed parent layout.++## Motivation++The current project database-detail route tree has an awkward boundary:++- `frontend/src/views/project/ProjectDatabaseLayout.vue` is a Vue parent route that only exists to:+ - pass route params through `<router-view>`+ - provide `DatabaseDetailContext`+ - prefetch schema metadata+- `frontend/src/views/DatabaseDetail/ChangelogDetail.vue` is a Vue route shell around `frontend/src/components/Changelog/ChangelogDetail.vue`+- `frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx` is already React, but it reimplements database fetch and breadcrumb bootstrapping on its own++That split causes three problems:++1. **React migration is blocked by a Vue parent route.** As long as `ProjectDatabaseLayout.vue` owns the route subtree, any child page migration is incomplete.+2. **Database-detail bootstrap logic is fragmented.** Database fetch, schema warmup, project normalization, and derived flags are spread across Vue layout code, Vue injection context, and individual pages.+3. **Future migration cost stays high.** The later React migration of the main database detail page would either duplicate this logic again or inherit a temporary architecture.++## Goals++- Remove `frontend/src/views/project/ProjectDatabaseLayout.vue` from active routing.+- Migrate the changelog detail route to React.+- Refactor revision detail to use the same React database-detail bootstrap path.+- Move database-detail bootstrap concerns into a reusable React unit:+ - canonical resource naming+ - database fetch+ - schema metadata warmup+ - derived detail flags+ - project-route normalization+- Keep the existing main database detail page working while it remains Vue.++## Non-Goals++- Do not migrate `frontend/src/views/DatabaseDetail/DatabaseDetail.vue` to React in this change.+- Do not redesign database detail UX.+- Do not attempt cross-framework context sharing between React and Vue.+- Do not migrate unrelated database panels.++## Design++### Route Structure++Replace the nested database-detail route subtree in `frontend/src/router/dashboard/projectV1.ts` with explicit leaf routes:++| Route | Target |+|-------|--------|+| `/projects/:projectId/instances/:instanceId/databases/:databaseName` | existing Vue database detail page |+| `/projects/:projectId/instances/:instanceId/databases/:databaseName/changelogs/:changelogId` | new React changelog detail page |+| `/projects/:projectId/instances/:instanceId/databases/:databaseName/revisions/:revisionId` | existing React revision detail page, refactored onto shared hook |++The current Vue parent route entry that points at `ProjectDatabaseLayout.vue` is removed. Each leaf route becomes directly responsible for its own page component and props.++### Shared React Database-Detail Layer++Add a focused React-only unit for project-scoped database-detail bootstrapping. A hook is preferred over a global provider:++`useProjectDatabaseDetail({ projectId, instanceId, databaseName })`++Responsibilities:++- Build canonical resource names for:+ - project: `projects/${projectId}`+ - instance: `instances/${instanceId}`+ - database: `instances/${instanceId}/databases/${databaseName}`+- Fetch the database record from the v1 database store.+- Warm database metadata via the schema store, matching the current layout behavior.+- Ignore schema metadata permission failures so pages can still render.+- Derive:+ - `database`+ - `project`+ - `allowAlterSchema`+ - `isDefaultProject`+ - `loading`+ - `ready`+- Normalize the route when the fetched database belongs to a different project than the URL.++This hook replaces the responsibilities currently split between:++- `frontend/src/views/project/ProjectDatabaseLayout.vue`+- `frontend/src/components/Database/context.ts`+- ad hoc fetch logic in `frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx`++### Route Normalization++The shared React layer owns project-route correction for React pages.++Behavior:++- If the fetched database belongs to a project different from `projectId` in the URL, redirect to the canonical route that matches `database.project`.+- Preserve the current leaf intent:+ - database detail stays database detail+ - changelog detail stays changelog detail+ - revision detail stays revision detail+- Preserve relevant route state:+ - hash for database detail+ - query for database detail+ - dynamic IDs like `changelogId` and `revisionId`++This matches the existing correction behavior in `frontend/src/views/DatabaseDetail/DatabaseDetail.vue`, but moves the responsibility into the new React bootstrap path for React pages.++### React Changelog Detail Page++Add a React page parallel to `DatabaseRevisionDetailPage.tsx`:++- `frontend/src/react/pages/project/DatabaseChangelogDetailPage.tsx`++The page owns:++- breadcrumb rendering+- loading shell+- changelog fetch+- previous changelog fetch for diff source+- rollback button routing+- readonly schema snapshot rendering+- task run log rendering++The page must preserve the current Vue behavior in `frontend/src/views/DatabaseDetail/ChangelogDetail.vue` and `frontend/src/components/Changelog/ChangelogDetail.vue`:++- show changelog title when present+- show status and created time+- show task run logs for `DONE` and `FAILED` changelogs+- link to the full task route when `taskRun` is present+- show schema snapshot+- show diff by default using the previous changelog schema as the original content+- allow rollback only when:+ - project is not default+ - user has alter-schema capability+ - database engine supports schema rollback+ - changelog status is `DONE`++This is a functional port, not a redesign.++### Revision Detail Refactor++Refactor `frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx` to consume `useProjectDatabaseDetail(...)` instead of directly fetching the database itself.++What changes:++- Database fetch and metadata warmup come from the shared hook.+- Route normalization comes from the shared hook.+- Breadcrumb props continue to be derived from the same route params.++What does not change:++- The revision detail page remains a React leaf page.+- The revision detail panel implementation and user-visible behavior stay the same.++### Vue Database Detail Coexistence++The main database detail page remains Vue in this PR, but it can no longer depend on `ProjectDatabaseLayout.vue`.++Coexistence rule:++- React pages use the new React bootstrap layer.+- Vue database detail becomes self-bootstrapping for its own needs.++Concretely:++- Route the database detail leaf directly to the existing Vue component.+- Move the minimum required bootstrap logic into the Vue database detail path so it still has:+ - access to database detail context+ - metadata warmup+ - current project normalization++The temporary duplication is acceptable because it is isolated to the still-Vue page and disappears when that page migrates.++### File Structure++Expected new or modified files:++- Create: `frontend/src/react/pages/project/DatabaseChangelogDetailPage.tsx`+- Create: `frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.ts`+- Modify: `frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx`+- Modify: `frontend/src/router/dashboard/projectV1.ts`+- Modify: `frontend/src/views/DatabaseDetail/DatabaseDetail.vue`+- Delete or stop routing to: `frontend/src/views/project/ProjectDatabaseLayout.vue`++### Testing Strategy++For frontend verification in this repo, run:++- `pnpm --dir frontend fix`+- `pnpm --dir frontend check`+- `pnpm --dir frontend type-check`+- targeted frontend tests for any new React logic with meaningful pure or component-level coverage++Recommended test focus:++- shared hook handles successful bootstrap+- shared hook tolerates metadata permission failure+- shared hook computes canonical redirect correctly+- changelog detail diff uses previous changelog schema+- revision detail still renders correctly through the shared hook++## Alternatives Considered++### Keep the Vue parent layout and migrate only the changelog leaf++Rejected because it leaves `ProjectDatabaseLayout.vue` in the critical path and preserves the Vue injection boundary that future React work needs to remove anyway.++### Wrap the existing Vue changelog component in a React shell++Rejected because it creates a temporary mixed-framework composition for a page that must become fully React later. It saves little and leaves the hard boundary unresolved.++### Migrate the entire database-detail subtree now++Rejected for scope. The main database detail page is much larger and touches more workflows than the routes targeted here.++## Risks++- Flattening the route tree can accidentally change route props or navigation behavior.+- Moving bootstrap logic out of `ProjectDatabaseLayout.vue` can break the still-Vue database detail page if its replacement bootstrap path is incomplete.+- Redirect behavior must preserve hashes, queries, and dynamic IDs carefully to avoid subtle UX regressions.+- The changelog detail port includes Monaco/diff/log rendering, so visual parity needs attention.++## Rollout++Land this as one focused migration PR:++1. Introduce shared React database-detail hook.+2. Migrate changelog detail page to React.+3. Refactor revision detail onto the shared hook.+4. Flatten the routes and remove the Vue parent layout from active routing.+5. Make the Vue database detail page self-sufficient until its later migration.diff --git a/frontend/src/components/Changelog/ChangelogDetail.vue b/frontend/src/components/Changelog/ChangelogDetail.vuedeleted file mode 100644index 84fe927a58..0000000000--- a/frontend/src/components/Changelog/ChangelogDetail.vue+++ /dev/null@@ -1,317 +0,0 @@-<template>- <div class="focus:outline-hidden" tabindex="0" v-bind="$attrs">- <div- v-if="state.loading"- class="flex items-center justify-center py-2 text-gray-400 text-sm"- >- <BBSpin />- </div>- <main v-else-if="changelog" class="flex flex-col relative gap-y-6">- <!-- Highlight Panel -->- <div class="flex flex-col gap-y-4">- <!-- Plan Title -->- <h2 v-if="changelog.planTitle" class="text-2xl font-semibold text-main">- {{ changelog.planTitle }}- </h2>-- <!-- Metadata Row -->- <div class="flex items-center gap-x-3 text-sm text-control-light">- <div class="flex items-center gap-x-2">- <ChangelogStatusIcon :status="changelog.status" />- </div>- <span v-if="formattedCreateTime">•</span>- <span v-if="formattedCreateTime">- {{ formattedCreateTime }}- </span>- </div>- </div>-- <div class="flex flex-col gap-y-6">- <!-- Task Run Logs Section -->- <div v-if="changelog.taskRun" class="flex flex-col gap-y-2">- <div class="flex items-center justify-between">- <p class="text-lg text-main">- {{ $t("issue.task-run.logs") }}- </p>- <router-link- v-if="taskFullLink"- :to="taskFullLink"- class="flex items-center gap-x-1 text-sm text-control-light hover:text-accent transition-colors"- >- {{ $t("common.show-more") }}- <ArrowUpRightIcon class="w-4 h-4" />- </router-link>- </div>- <TaskRunLogViewer- v-if="changelog?.taskRun && showTaskRunLogs"- :task-run-name="changelog.taskRun"- />- <div v-else class="text-sm text-control-light">- {{ $t("common.no-data") }}- </div>- </div>-- <!-- Schema Snapshot Section -->- <div v-if="showSchemaSnapshot" class="flex flex-col gap-y-2">- <p class="flex items-center text-lg text-main capitalize gap-x-2">- Schema {{ $t("common.snapshot") }}- <span v-if="formattedSchemaSize" class="text-sm font-normal text-control-light">- ({{ formattedSchemaSize }})- </span>- <CopyButton size="small" :content="changelogSchema" />- </p>- <div class="flex flex-row items-center justify-between gap-x-2">- <div class="flex items-center gap-x-2">- <div v-if="allowShowDiff" class="flex gap-x-1 items-center">- <NSwitch- :value="state.showDiff"- size="small"- data-label="bb-changelog-diff-switch"- @update:value="state.showDiff = $event"- />- <span class="text-sm font-semibold">- {{ $t("changelog.show-diff") }}- </span>- </div>- <div class="textinfolabel">- {{ $t("changelog.schema-snapshot-after-change") }}- </div>- <div v-if="!allowShowDiff" class="text-sm font-normal text-accent">- ({{ $t("changelog.no-schema-change") }})- </div>- </div>- <NButton- v-if="allowRollback"- size="small"- @click="handleRollback"- >- {{ $t("common.rollback") }}- </NButton>- </div>-- <DiffEditor- v-if="state.showDiff"- class="h-auto max-h-[600px] min-h-[120px] border rounded-md text-sm overflow-clip"- :original="previousSchema"- :modified="changelog.schema"- :readonly="true"- :auto-height="{ min: 120, max: 600 }"- />- <MonacoEditor- v-else-if="changelog.schema"- class="h-auto max-h-[600px] min-h-[120px] border rounded-md text-sm overflow-clip relative"- :content="changelogSchema"- :readonly="true"- :auto-height="{ min: 120, max: 600 }"- />- <div v-else>- {{ $t("changelog.current-schema-empty") }}- </div>- </div>- </div>- </main>- </div>-</template>--<script lang="ts" setup>-import { ArrowUpRightIcon } from "lucide-vue-next";-import { NButton, NSwitch } from "naive-ui";-import { computed, reactive, unref, watch } from "vue";-import { useRouter } from "vue-router";-import { BBSpin } from "@/bbkit";-import { useDatabaseDetailContext } from "@/components/Database/context";-import { DiffEditor, MonacoEditor } from "@/components/MonacoEditor";-import { TaskRunLogViewer } from "@/components/RolloutV1/components/TaskRun/TaskRunLogViewer";-import { CopyButton } from "@/components/v2";-import { PROJECT_V1_ROUTE_SYNC_SCHEMA } from "@/router/dashboard/projectV1";-import {- useChangelogStore,- useDatabaseV1ByName,- useDBSchemaV1Store,-} from "@/store";-import { getTimeForPbTimestampProtoEs } from "@/types";-import type { Changelog } from "@/types/proto-es/v1/database_service_pb";-import {- Changelog_Status,- ChangelogView,-} from "@/types/proto-es/v1/database_service_pb";-import {- bytesToString,- extractProjectResourceName,- formatAbsoluteDateTime,- getInstanceResource,- wrapRefAsPromise,-} from "@/utils";-import { instanceV1SupportsSchemaRollback } from "@/utils/v1/instance";-import ChangelogStatusIcon from "./ChangelogStatusIcon.vue";--interface LocalState {- loading: boolean;- showDiff: boolean;- previousChangelog?: Changelog;-}--const props = defineProps<{- instance: string;- database: string;- changelogId: string;-}>();--const router = useRouter();-const dbSchemaStore = useDBSchemaV1Store();-const changelogStore = useChangelogStore();-const state = reactive<LocalState>({- loading: false,- showDiff: false,- previousChangelog: undefined,-});--const { database, ready } = useDatabaseV1ByName(props.database);-const { allowAlterSchema, isDefaultProject } = useDatabaseDetailContext();--const changelogName = computed(() => {- return `${props.database}/changelogs/${props.changelogId}`;-});--const changelog = computed((): Changelog | undefined => {- return changelogStore.getChangelogByName(changelogName.value);-});--const taskFullLink = computed(() => {- if (!changelog.value?.taskRun) {- return "";- }- const parts = changelog.value.taskRun.split("/taskRuns/");- if (parts.length !== 2) {- return "";- }- return `/${parts[0]}`;-});--const formattedCreateTime = computed(() => {- if (!changelog.value) {- return "";- }- return formatAbsoluteDateTime(- getTimeForPbTimestampProtoEs(changelog.value.createTime)- );-});--const changelogSchema = computed(() => {- if (!changelog.value) {- return "";- }- return changelog.value.schema;-});--const formattedSchemaSize = computed(() => {- if (!changelog.value || !changelog.value.schemaSize) {- return "";- }- return bytesToString(Number(changelog.value.schemaSize));-});--const showSchemaSnapshot = computed(() => {- return true;-});--// "Show diff" feature is enabled when current migration has changed the schema.-const allowShowDiff = computed((): boolean => {- if (!changelog.value) {- return false;- }- return true;-});--// Get the previous changelog's schema as the "before" state for diff-const previousSchema = computed((): string => {- if (!state.previousChangelog) {- return "";- }- return state.previousChangelog.schema;-});--// Allow rollback for completed MIGRATE changelogs when user has alter schema permission-// and the database engine supports schema diff rollback-const allowRollback = computed((): boolean => {- if (isDefaultProject.value) {- return false;- }- if (!changelog.value || !allowAlterSchema.value || !database.value) {- return false;- }- // Check if engine supports schema diff rollback (GenerateMigration in backend)- if (- !instanceV1SupportsSchemaRollback(- getInstanceResource(database.value).engine- )- ) {- return false;- }- return changelog.value.status === Changelog_Status.DONE;-});--// Only show task run logs for completed or failed changelogs-const showTaskRunLogs = computed(() => {- if (!changelog.value?.taskRun) return false;- return (- changelog.value.status === Changelog_Status.DONE ||- changelog.value.status === Changelog_Status.FAILED- );-});--const handleRollback = () => {- if (!changelog.value || !database.value) {- return;- }-- router.push({- name: PROJECT_V1_ROUTE_SYNC_SCHEMA,- params: {- projectId: extractProjectResourceName(database.value.project),- },- query: {- changelog: changelog.value.name,- target: database.value.name,- rollback: "true",- },- });-};--watch(- [database.value.name, changelogName],- async () => {- await wrapRefAsPromise(ready, true);- state.loading = true;- await Promise.all([- dbSchemaStore.getOrFetchDatabaseMetadata({- database: database.value.name,- skipCache: false,- }),- changelogStore.getOrFetchChangelogByName(- unref(changelogName),- ChangelogView.FULL- ),- ]);-- // Fetch the previous changelog to get the "before" schema for diff- if (changelog.value) {- try {- const prevChangelog = await changelogStore.fetchPreviousChangelog(- unref(changelogName)- );- state.previousChangelog = prevChangelog;- } catch (error) {- console.error("Failed to fetch previous changelog:", error);- state.previousChangelog = undefined;- }-- // Show diff by default for all changelogs- state.showDiff = true;- }-- state.loading = false;- },- { immediate: true }-);-</script>diff --git a/frontend/src/components/Changelog/index.ts b/frontend/src/components/Changelog/index.tsindex e35be7d5a0..d6b6618549 100644--- a/frontend/src/components/Changelog/index.ts+++ b/frontend/src/components/Changelog/index.ts@@ -1,5 +1,4 @@import ChangelogDataTable from "./ChangelogDataTable.vue";-import ChangelogDetail from "./ChangelogDetail.vue";import ChangelogStatusIcon from "./ChangelogStatusIcon.vue";-export { ChangelogDetail, ChangelogStatusIcon, ChangelogDataTable };+export { ChangelogStatusIcon, ChangelogDataTable };diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex d1f39a16b6..7d18c80958 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -193,7 +193,6 @@},"changelog": {"current-schema-empty": "Current schema is empty",- "no-schema-change": "this migration has no schema change","schema-snapshot-after-change": "The schema snapshot recorded after applying this change","select": "Schema version is recorded each time a schema change is applied via Bytebase","self": "Changelog",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 03bb99b2d8..69bce365be 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -193,7 +193,6 @@},"changelog": {"current-schema-empty": "El esquema actual está vacío",- "no-schema-change": "esta migración no tiene cambios de esquema","schema-snapshot-after-change": "La instantánea de esquema registrada después de aplicar este cambio","select": "La versión del esquema se registra cada vez que se aplica un cambio de esquema a través de Bytebase","self": "Historial de cambios",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 690571e291..411f66d1d2 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -193,7 +193,6 @@},"changelog": {"current-schema-empty": "現在のスキーマは空です",- "no-schema-change": "この変更ではスキーマの変更はありません","schema-snapshot-after-change": "この変更を完了した後のスキーマのスナップショット","select": "スキーマのバージョンは、Bytebase を通じてスキーマの変更が実行されるたびに記録されます。","self": "変更履歴",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex c9decbe118..fddcb8e456 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -193,7 +193,6 @@},"changelog": {"current-schema-empty": "Lược đồ hiện tại trống",- "no-schema-change": "di chuyển này không có thay đổi lược đồ","schema-snapshot-after-change": "Ảnh chụp nhanh lược đồ được ghi lại sau khi áp dụng thay đổi này","select": "Phiên bản lược đồ được ghi lại mỗi khi thay đổi lược đồ được áp dụng qua Bytebase","self": "Nhật ký thay đổi",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex 3c12c8b533..fb7e287be3 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -193,7 +193,6 @@},"changelog": {"current-schema-empty": "当前 schema 为空",- "no-schema-change": "本次变更没有任何 Schema 的改动","schema-snapshot-after-change": "完成这次变更后的 schema 快照","select": "Schema 版本是在每次通过 Bytebase 执行 Schema 变更后被记录下来的","self": "变更历史",diff --git a/frontend/src/react/locales/en-US.json b/frontend/src/react/locales/en-US.jsonindex 5f7c519cfd..2ea38a1b09 100644--- a/frontend/src/react/locales/en-US.json+++ b/frontend/src/react/locales/en-US.json@@ -117,8 +117,11 @@}},"changelog": {+ "current-schema-empty": "Current schema is empty",+ "schema-snapshot-after-change": "The schema snapshot recorded after applying this change","select": "Schema version is recorded each time a schema change is applied via Bytebase",- "self": "Changelog"+ "self": "Changelog",+ "show-diff": "Show diff"},"common": {"activated": "Activated",@@ -257,6 +260,7 @@"role": {"self": "Role"},+ "rollback": "Rollback","rows-per-page": "Rows per page","save": "Save","schema": "Schema",@@ -270,6 +274,7 @@"setting": "Setting","settings": "Settings","skipped": "Skipped",+ "snapshot": "Snapshot","sql": "SQL","state": "State","statement": "Statement",diff --git a/frontend/src/react/locales/es-ES.json b/frontend/src/react/locales/es-ES.jsonindex 3cfe02c792..cf76ab21f3 100644--- a/frontend/src/react/locales/es-ES.json+++ b/frontend/src/react/locales/es-ES.json@@ -117,8 +117,11 @@}},"changelog": {+ "current-schema-empty": "El esquema actual está vacío",+ "schema-snapshot-after-change": "La instantánea de esquema registrada después de aplicar este cambio","select": "Schema version is recorded each time a schema change is applied via Bytebase",- "self": "Changelog"+ "self": "Changelog",+ "show-diff": "Mostrar diferencias"},"common": {"activated": "Activado",@@ -257,6 +260,7 @@"role": {"self": "Rol"},+ "rollback": "Retroceder","rows-per-page": "Filas por página","save": "Guardar","schema": "Esquema",@@ -270,6 +274,7 @@"setting": "Configuración","settings": "Configuraciones","skipped": "Omitido",+ "snapshot": "Instantánea","sql": "SQL","state": "Estado","statement": "Declaración",diff --git a/frontend/src/react/locales/ja-JP.json b/frontend/src/react/locales/ja-JP.jsonindex 98aecf9305..d0570eef13 100644--- a/frontend/src/react/locales/ja-JP.json+++ b/frontend/src/react/locales/ja-JP.json@@ -117,8 +117,11 @@}},"changelog": {+ "current-schema-empty": "現在のスキーマは空です",+ "schema-snapshot-after-change": "この変更を完了した後のスキーマのスナップショット","select": "Schema version is recorded each time a schema change is applied via Bytebase",- "self": "Changelog"+ "self": "Changelog",+ "show-diff": "違いを表示"},"common": {"activated": "有効化しました",@@ -257,6 +260,7 @@"role": {"self": "ロール"},+ "rollback": "ロールバック","rows-per-page": "ページあたりの行数","save": "保存","schema": "スキーマ",@@ -270,6 +274,7 @@"setting": "設定","settings": "設定","skipped": "スキップ",+ "snapshot": "スナップショット","sql": "SQL","state": "ステート","statement": "ステートメント",diff --git a/frontend/src/react/locales/vi-VN.json b/frontend/src/react/locales/vi-VN.jsonindex 2f498f3981..a355426777 100644--- a/frontend/src/react/locales/vi-VN.json+++ b/frontend/src/react/locales/vi-VN.json@@ -117,8 +117,11 @@}},"changelog": {+ "current-schema-empty": "Lược đồ hiện tại trống",+ "schema-snapshot-after-change": "Ảnh chụp nhanh lược đồ được ghi lại sau khi áp dụng thay đổi này","select": "Schema version is recorded each time a schema change is applied via Bytebase",- "self": "Changelog"+ "self": "Changelog",+ "show-diff": "Hiển thị khác biệt"},"common": {"activated": "Đã kích hoạt",@@ -257,6 +260,7 @@"role": {"self": "Vai trò"},+ "rollback": "Hoàn tác","rows-per-page": "Số dòng mỗi trang","save": "Lưu","schema": "Schema",@@ -270,6 +274,7 @@"setting": "Cài đặt","settings": "Cài đặt","skipped": "Đã bỏ qua",+ "snapshot": "Ảnh chụp nhanh","sql": "SQL","state": "Trạng thái","statement": "Câu lệnh",diff --git a/frontend/src/react/locales/zh-CN.json b/frontend/src/react/locales/zh-CN.jsonindex b29b76c280..dcaba824ab 100644--- a/frontend/src/react/locales/zh-CN.json+++ b/frontend/src/react/locales/zh-CN.json@@ -117,8 +117,11 @@}},"changelog": {+ "current-schema-empty": "当前 schema 为空",+ "schema-snapshot-after-change": "完成这次变更后的 schema 快照","select": "Schema 版本是在每次通过 Bytebase 执行 Schema 变更后被记录下来的",- "self": "变更历史"+ "self": "变更历史",+ "show-diff": "显示差异"},"common": {"activated": "已激活",@@ -257,6 +260,7 @@"role": {"self": "角色"},+ "rollback": "回滚","rows-per-page": "每页行数","save": "保存","schema": "模式",@@ -270,6 +274,7 @@"setting": "设置","settings": "设置","skipped": "已跳过",+ "snapshot": "快照","sql": "SQL","state": "状态","statement": "语句",diff --git a/frontend/src/react/pages/project/DatabaseChangelogDetailPage.test.tsx b/frontend/src/react/pages/project/DatabaseChangelogDetailPage.test.tsxnew file mode 100644index 0000000000..b7c006263c--- /dev/null+++ b/frontend/src/react/pages/project/DatabaseChangelogDetailPage.test.tsx@@ -0,0 +1,672 @@+import { act, createElement } from "react";+import { createRoot } from "react-dom/client";+import { beforeEach, describe, expect, test, vi } from "vitest";++(+ globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }+).IS_REACT_ACT_ENVIRONMENT = true;++const mocks = vi.hoisted(() => {+ const localStorage = {+ clear: vi.fn(),+ getItem: vi.fn(() => null),+ removeItem: vi.fn(),+ setItem: vi.fn(),+ };+ const clipboardWriteText = vi.fn();+ vi.stubGlobal("localStorage", localStorage);++ const currentChangelog = {+ name: "instances/inst1/databases/db1/changelogs/7",+ status: 2,+ taskRun: "projects/proj1/plans/plan1/tasks/task1/taskRuns/run1",+ planTitle: "Add index",+ schemaSize: BigInt(31),+ createTime: { seconds: BigInt(1710000000), nanos: 0 },+ schema: "current schema",+ };+ const previousChangelog = {+ name: "instances/inst1/databases/db1/changelogs/6",+ status: 2,+ schema: "previous schema",+ };++ return {+ currentChangelog,+ previousChangelog,+ localStorage,+ routerPush: vi.fn(),+ useProjectDatabaseDetail: vi.fn(),+ getOrFetchChangelogByName: vi.fn(),+ fetchPreviousChangelog: vi.fn(),+ getChangelogByName: vi.fn(),+ useChangelogStore: vi.fn(),+ useVueState: vi.fn((getter: () => unknown) => getter()),+ clipboardWriteText,+ pushNotification: vi.fn(),+ ReadonlyMonaco: vi.fn(+ ({ content, className }: { content: string; className?: string }) => {+ return (+ <div data-testid="readonly-monaco" className={className}>+ {content}+ </div>+ );+ }+ ),+ TaskRunLogViewer: vi.fn(({ taskRunName }: { taskRunName: string }) => {+ return <div data-testid="task-run-log">{taskRunName}</div>;+ }),+ Switch: vi.fn(+ ({+ checked,+ onCheckedChange,+ }: {+ checked: boolean;+ onCheckedChange: (checked: boolean) => void;+ }) => {+ return (+ <button+ type="button"+ data-testid="diff-switch"+ aria-pressed={checked}+ onClick={() => onCheckedChange(!checked)}+ >+ {checked ? "on" : "off"}+ </button>+ );+ }+ ),+ LoaderCircle: vi.fn(() => <div data-testid="spinner" />),+ ArrowUpRight: vi.fn(() => <div data-testid="arrow-up-right" />),+ CheckCircle2: vi.fn(() => <div data-testid="check-circle-2" />),+ CircleAlert: vi.fn(() => <div data-testid="circle-alert" />),+ CircleDot: vi.fn(() => <div data-testid="circle-dot" />),+ Copy: vi.fn(() => <div data-testid="copy-icon" />),+ useTranslation: vi.fn(() => ({+ t: (key: string) => key,+ })),+ getTimeForPbTimestampProtoEs: vi.fn(() => 0),+ projectRouteNames: {+ databases: "workspace.project.databases",+ databaseDetail: "workspace.project.database.detail",+ databaseChangelogDetail: "workspace.project.database.changelog.detail",+ syncSchema: "workspace.project.sync-schema",+ },+ };+});++type DatabaseChangelogDetailPageComponent =+ typeof import("./DatabaseChangelogDetailPage").DatabaseChangelogDetailPage;++let DatabaseChangelogDetailPage: DatabaseChangelogDetailPageComponent;++vi.mock("lucide-react", () => ({+ LoaderCircle: mocks.LoaderCircle,+ ArrowUpRight: mocks.ArrowUpRight,+ CheckCircle2: mocks.CheckCircle2,+ CircleAlert: mocks.CircleAlert,+ CircleDot: mocks.CircleDot,+ Copy: mocks.Copy,+}));++vi.mock("react-i18next", () => ({+ useTranslation: mocks.useTranslation,+}));++vi.mock("@/router", () => ({+ router: {+ push: mocks.routerPush,+ },+}));++vi.mock("@/router/dashboard/projectV1", () => ({+ PROJECT_V1_ROUTE_DATABASES: mocks.projectRouteNames.databases,+ PROJECT_V1_ROUTE_DATABASE_DETAIL: mocks.projectRouteNames.databaseDetail,+ PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL:+ mocks.projectRouteNames.databaseChangelogDetail,+ PROJECT_V1_ROUTE_SYNC_SCHEMA: mocks.projectRouteNames.syncSchema,+}));++vi.mock("@/react/components/ui/button", () => ({+ Button: (props: React.ButtonHTMLAttributes<HTMLButtonElement>) => (+ <button {...props} />+ ),+}));++vi.mock("@/react/components/ui/switch", () => ({+ Switch: mocks.Switch,+}));++vi.mock("@/react/components/monaco", () => ({+ ReadonlyMonaco: mocks.ReadonlyMonaco,+}));++vi.mock("@/react/components/task-run-log", () => ({+ TaskRunLogViewer: mocks.TaskRunLogViewer,+}));++vi.mock("@/react/hooks/useVueState", () => ({+ useVueState: mocks.useVueState,+}));++vi.mock("@/store", () => ({+ pushNotification: mocks.pushNotification,+ useChangelogStore: mocks.useChangelogStore,+}));++vi.mock("./database-detail/useProjectDatabaseDetail", () => ({+ useProjectDatabaseDetail: mocks.useProjectDatabaseDetail,+}));++vi.mock("@/types", () => ({+ getTimeForPbTimestampProtoEs: mocks.getTimeForPbTimestampProtoEs,+}));++vi.mock("@/utils/v1/database", () => ({+ extractDatabaseResourceName: (name: string) => ({+ instance: "instances/inst1",+ instanceName: "inst1",+ database: name,+ databaseName: name.split("/databases/").at(-1) ?? "",+ }),+}));++vi.mock("@/utils/v1/instance", () => ({+ extractInstanceResourceName: (name: string) => name.split("/").at(-1) ?? "",+ instanceV1SupportsSchemaRollback: () => true,+}));++vi.mock("@/utils/v1/project", () => ({+ extractProjectResourceName: (name: string) => name.split("/").at(-1) ?? "",+}));++vi.mock("@/utils", () => ({+ bytesToString: (size: number) => `${size} B`,+ formatAbsoluteDateTime: () => "formatted time",+ extractDatabaseResourceName: (name: string) => ({+ instance: "instances/inst1",+ instanceName: "inst1",+ database: name,+ databaseName: name.split("/databases/").at(-1) ?? "",+ }),+ getInstanceResource: (database: { instanceResource?: { engine?: string } }) =>+ database.instanceResource ?? { engine: "MYSQL" },+}));++const renderIntoContainer = (element: ReturnType<typeof createElement>) => {+ const container = document.createElement("div");+ const root = createRoot(container);++ return {+ container,+ render: (nextElement = element) => {+ act(() => {+ root.render(nextElement);+ });+ },+ unmount: () =>+ act(() => {+ root.unmount();+ }),+ };+};++beforeEach(() => {+ mocks.localStorage.getItem.mockReset();+ mocks.localStorage.getItem.mockReturnValue(null);+ mocks.localStorage.setItem.mockReset();+ mocks.localStorage.removeItem.mockReset();+ mocks.localStorage.clear.mockReset();+ mocks.routerPush.mockReset();+ mocks.useProjectDatabaseDetail.mockReset();+ mocks.getOrFetchChangelogByName.mockReset();+ mocks.fetchPreviousChangelog.mockReset();+ mocks.getChangelogByName.mockReset();+ mocks.useChangelogStore.mockReset();+ mocks.pushNotification.mockReset();+ mocks.useVueState.mockImplementation((getter: () => unknown) => getter());+ mocks.ReadonlyMonaco.mockClear();+ mocks.TaskRunLogViewer.mockClear();+ mocks.Switch.mockClear();+ mocks.LoaderCircle.mockClear();+ mocks.ArrowUpRight.mockClear();+ mocks.CheckCircle2.mockClear();+ mocks.CircleAlert.mockClear();+ mocks.CircleDot.mockClear();+ mocks.Copy.mockClear();+ mocks.clipboardWriteText.mockReset();+ Object.defineProperty(globalThis.navigator, "clipboard", {+ configurable: true,+ value: {+ writeText: mocks.clipboardWriteText,+ },+ });++ let currentChangelog = undefined as typeof mocks.currentChangelog | undefined;+ let previousChangelog = undefined as+ | typeof mocks.previousChangelog+ | undefined;++ mocks.getOrFetchChangelogByName.mockImplementation(async (name: string) => {+ if (name === mocks.currentChangelog.name) {+ currentChangelog = mocks.currentChangelog;+ return currentChangelog;+ }+ if (name === mocks.previousChangelog.name) {+ previousChangelog = mocks.previousChangelog;+ return previousChangelog;+ }+ return undefined;+ });+ mocks.fetchPreviousChangelog.mockImplementation(async () => {+ previousChangelog = mocks.previousChangelog;+ return previousChangelog;+ });+ mocks.getChangelogByName.mockImplementation((name: string) => {+ if (name === mocks.currentChangelog.name) {+ return currentChangelog;+ }+ if (name === mocks.previousChangelog.name) {+ return previousChangelog;+ }+ return undefined;+ });+ mocks.useChangelogStore.mockReturnValue({+ getOrFetchChangelogByName: mocks.getOrFetchChangelogByName,+ fetchPreviousChangelog: mocks.fetchPreviousChangelog,+ getChangelogByName: mocks.getChangelogByName,+ });+});++beforeEach(async () => {+ vi.resetModules();+ ({ DatabaseChangelogDetailPage } = await import(+ "./DatabaseChangelogDetailPage"+ ));+});++describe("DatabaseChangelogDetailPage", () => {+ test("shows a spinner while the shared database hook is loading", () => {+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: undefined,+ databaseName: "instances/inst1/databases/db1",+ loading: true,+ ready: false,+ allowAlterSchema: false,+ isDefaultProject: false,+ });++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();+ expect(container.querySelector('[data-testid="spinner"]')).not.toBeNull();+ expect(container.textContent).not.toContain("current schema");++ unmount();+ });++ test("shows a spinner while the changelog fetch is pending after detail is ready", async () => {+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/db1",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });++ const pendingChangelog = new Promise<typeof mocks.currentChangelog>(() => {+ // Intentionally left pending to cover the loading state.+ });+ const pendingPreviousChangelog = new Promise<+ typeof mocks.previousChangelog+ >(() => {+ // Intentionally left pending to cover the loading state.+ });+ mocks.getOrFetchChangelogByName.mockReturnValue(pendingChangelog);+ mocks.fetchPreviousChangelog.mockReturnValue(pendingPreviousChangelog);++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ });++ expect(container.querySelector('[data-testid="spinner"]')).not.toBeNull();+ expect(container.textContent).not.toContain("current schema");+ expect(mocks.getOrFetchChangelogByName).toHaveBeenCalledWith(+ "instances/inst1/databases/db1/changelogs/7",+ expect.anything()+ );+ expect(mocks.fetchPreviousChangelog).toHaveBeenCalledWith(+ "instances/inst1/databases/db1/changelogs/7"+ );++ unmount();+ });++ test("fetches the changelog using the detail database name", async () => {+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/detail-db",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/detail-db",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });++ const { unmount, render } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/from-prop",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(mocks.getOrFetchChangelogByName).toHaveBeenCalledWith(+ "instances/inst1/databases/detail-db/changelogs/7",+ expect.anything()+ );+ expect(mocks.getOrFetchChangelogByName).not.toHaveBeenCalledWith(+ "instances/inst1/databases/from-prop/changelogs/7",+ expect.anything()+ );++ unmount();+ });++ test("renders changelog metadata and copies the schema", async () => {+ const changelog = {+ ...mocks.currentChangelog,+ createTime: { seconds: BigInt(1710000000), nanos: 0 },+ schema: "current schema",+ };+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/db1",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });+ mocks.getOrFetchChangelogByName.mockResolvedValue(changelog);+ mocks.fetchPreviousChangelog.mockResolvedValue(mocks.previousChangelog);+ mocks.getChangelogByName.mockReturnValue(undefined);++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(container.textContent).toContain("Add index");+ expect(container.textContent).toContain("formatted time");+ expect(container.textContent).toContain("common.schema");+ expect(container.textContent).toContain("common.snapshot");+ expect(container.textContent).toContain("31 B");+ const copyButton = container.querySelector(+ '[aria-label="common.copy"]'+ ) as HTMLButtonElement | null;+ expect(copyButton).not.toBeNull();++ await act(async () => {+ copyButton?.click();+ await Promise.resolve();+ });++ expect(mocks.clipboardWriteText).toHaveBeenCalledWith("current schema");+ expect(mocks.pushNotification).toHaveBeenCalledWith({+ module: "bytebase",+ style: "SUCCESS",+ title: "common.copied",+ });++ unmount();+ });++ test("renders the empty-schema fallback outside diff mode", async () => {+ const changelog = {+ ...mocks.currentChangelog,+ schema: "",+ };+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/db1",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });+ mocks.getOrFetchChangelogByName.mockResolvedValue(changelog);+ mocks.fetchPreviousChangelog.mockResolvedValue(mocks.previousChangelog);+ mocks.getChangelogByName.mockReturnValue(undefined);++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ const switchButton = container.querySelector(+ '[data-testid="diff-switch"]'+ ) as HTMLButtonElement | null;+ expect(switchButton).not.toBeNull();++ await act(async () => {+ switchButton?.click();+ });++ expect(container.textContent).toContain("changelog.current-schema-empty");+ expect(+ container.querySelectorAll('[data-testid="readonly-monaco"]').length+ ).toBe(0);++ unmount();+ });++ test("hides rollback when alter-schema permission is disabled", async () => {+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/db1",+ loading: false,+ ready: true,+ allowAlterSchema: false,+ isDefaultProject: false,+ });++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(+ Array.from(container.querySelectorAll("button")).some(+ (button) => button.textContent === "common.rollback"+ )+ ).toBe(false);+ expect(container.textContent).not.toContain("common.rollback");++ unmount();+ });++ test("hides rollback when the changelog is not DONE", async () => {+ const changelog = {+ ...mocks.currentChangelog,+ status: 1,+ };+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/db1",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });+ mocks.getOrFetchChangelogByName.mockResolvedValue(changelog);+ mocks.fetchPreviousChangelog.mockResolvedValue(mocks.previousChangelog);+ mocks.getChangelogByName.mockReturnValue(undefined);++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(+ Array.from(container.querySelectorAll("button")).some(+ (button) => button.textContent === "common.rollback"+ )+ ).toBe(false);++ unmount();+ });++ test("clears stale changelog content when a later fetch fails", async () => {+ const consoleError = vi+ .spyOn(console, "error")+ .mockImplementation(() => {});+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ instanceResource: { engine: "MYSQL" },+ },+ databaseName: "instances/inst1/databases/db1",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });++ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(container.textContent).toContain("Add index");++ mocks.getOrFetchChangelogByName.mockRejectedValueOnce(+ new Error("fetch failed")+ );++ render(+ createElement(DatabaseChangelogDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db1",+ changelogId: "8",+ })+ );++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(container.textContent).not.toContain("Add index");+ expect(container.textContent).not.toContain("current schema");++ consoleError.mockRestore();+ unmount();+ });+});diff --git a/frontend/src/react/pages/project/DatabaseChangelogDetailPage.tsx b/frontend/src/react/pages/project/DatabaseChangelogDetailPage.tsxnew file mode 100644index 0000000000..e8bd41c15e--- /dev/null+++ b/frontend/src/react/pages/project/DatabaseChangelogDetailPage.tsx@@ -0,0 +1,491 @@+import {+ ArrowUpRight,+ CheckCircle2,+ CircleAlert,+ CircleDot,+ Copy,+ LoaderCircle,+} from "lucide-react";+import { useCallback, useEffect, useMemo, useState } from "react";+import { useTranslation } from "react-i18next";+import { ReadonlyMonaco } from "@/react/components/monaco";+import { TaskRunLogViewer } from "@/react/components/task-run-log";+import { Button } from "@/react/components/ui/button";+import { Switch } from "@/react/components/ui/switch";+import { useVueState } from "@/react/hooks/useVueState";+import { router } from "@/router";+import {+ PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL,+ PROJECT_V1_ROUTE_DATABASE_DETAIL,+ PROJECT_V1_ROUTE_DATABASES,+ PROJECT_V1_ROUTE_SYNC_SCHEMA,+} from "@/router/dashboard/projectV1";+import { pushNotification, useChangelogStore } from "@/store";+import { getTimeForPbTimestampProtoEs } from "@/types";+import type { Changelog } from "@/types/proto-es/v1/database_service_pb";+import {+ Changelog_Status,+ ChangelogView,+} from "@/types/proto-es/v1/database_service_pb";+import {+ bytesToString,+ extractDatabaseResourceName,+ formatAbsoluteDateTime,+ getInstanceResource,+} from "@/utils";+import {+ extractInstanceResourceName,+ instanceV1SupportsSchemaRollback,+} from "@/utils/v1/instance";+import { extractProjectResourceName } from "@/utils/v1/project";+import { extractTaskLink } from "@/utils/v1/revision";+import { useProjectDatabaseDetail } from "./database-detail/useProjectDatabaseDetail";++export interface DatabaseChangelogDetailPageProps {+ project: string;+ instance: string;+ database: string;+ changelogId: string;+}++function execCommandCopy(text: string): boolean {+ const textarea = document.createElement("textarea");+ textarea.value = text;+ textarea.style.position = "fixed";+ textarea.style.opacity = "0";+ document.body.appendChild(textarea);+ textarea.select();+ try {+ return document.execCommand("copy");+ } catch {+ return false;+ } finally {+ document.body.removeChild(textarea);+ }+}++async function copyToClipboard(text: string): Promise<boolean> {+ if (navigator.clipboard?.writeText) {+ try {+ await navigator.clipboard.writeText(text);+ return true;+ } catch {+ // Fall through to execCommand fallback.+ }+ }+ return execCommandCopy(text);+}++function ChangelogStatusIndicator({ status }: { status: Changelog_Status }) {+ const { t } = useTranslation();++ switch (status) {+ case Changelog_Status.PENDING:+ return (+ <span+ aria-label={t("common.status")}+ className="flex h-5 w-5 items-center justify-center rounded-full border-2 border-info bg-white text-info"+ >+ <CircleDot className="h-3 w-3" />+ </span>+ );+ case Changelog_Status.DONE:+ return (+ <span+ aria-label={t("common.status")}+ className="flex h-5 w-5 items-center justify-center rounded-full bg-success text-white"+ >+ <CheckCircle2 className="h-4 w-4" />+ </span>+ );+ case Changelog_Status.FAILED:+ return (+ <span+ aria-label={t("common.status")}+ className="flex h-5 w-5 items-center justify-center rounded-full bg-error text-white"+ >+ <CircleAlert className="h-4 w-4" />+ </span>+ );+ default:+ return null;+ }+}++function CopyButton({ content }: { content: string }) {+ const { t } = useTranslation();++ const handleCopy = useCallback(async () => {+ if (!content) {+ return;+ }++ if (await copyToClipboard(content)) {+ pushNotification({+ module: "bytebase",+ style: "SUCCESS",+ title: t("common.copied"),+ });+ return;+ }++ pushNotification({+ module: "bytebase",+ style: "CRITICAL",+ title: t("common.copy-failed"),+ });+ }, [content, t]);++ return (+ <Button+ variant="ghost"+ size="icon"+ aria-label={t("common.copy")}+ title={t("common.copy")}+ disabled={!content}+ onClick={handleCopy}+ >+ <Copy className="h-4 w-4" />+ </Button>+ );+}++export function DatabaseChangelogDetailPage({+ project,+ instance,+ database,+ changelogId,+}: DatabaseChangelogDetailPageProps) {+ const { t } = useTranslation();+ const changelogStore = useChangelogStore();+ const [loading, setLoading] = useState(true);+ const [showDiff, setShowDiff] = useState(true);+ const [resolvedChangelog, setResolvedChangelog] = useState<Changelog>();+ const [previousChangelog, setPreviousChangelog] = useState<Changelog>();++ const projectId = extractProjectResourceName(project);+ const instanceId = extractInstanceResourceName(instance);+ const databaseName = extractDatabaseResourceName(database).databaseName;++ const detail = useProjectDatabaseDetail({+ projectId,+ instanceId,+ databaseName,+ routeName: PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL,+ changelogId,+ });+ const changelogName = `${detail.databaseName}/changelogs/${changelogId}`;++ const changelog = useVueState(() =>+ changelogStore.getChangelogByName(changelogName, ChangelogView.FULL)+ );++ useEffect(() => {+ setResolvedChangelog(changelog);+ }, [changelog]);++ useEffect(() => {+ let cancelled = false;++ if (!detail.ready) {+ setLoading(true);+ return () => {+ cancelled = true;+ };+ }++ setLoading(true);+ setShowDiff(true);+ setResolvedChangelog(undefined);+ setPreviousChangelog(undefined);++ void Promise.all([+ changelogStore.getOrFetchChangelogByName(+ changelogName,+ ChangelogView.FULL+ ),+ changelogStore.fetchPreviousChangelog(changelogName),+ ])+ .then(([current, previous]) => {+ if (cancelled) {+ return;+ }+ setResolvedChangelog(current);+ setPreviousChangelog(previous);+ })+ .catch((error) => {+ console.error("Failed to fetch changelog details", error);+ })+ .finally(() => {+ if (!cancelled) {+ setLoading(false);+ }+ });++ return () => {+ cancelled = true;+ };+ }, [changelogName, changelogStore, detail.ready]);++ const taskFullLink = useMemo(() => {+ if (!resolvedChangelog?.taskRun) {+ return "";+ }+ return extractTaskLink(resolvedChangelog.taskRun);+ }, [resolvedChangelog?.taskRun]);++ const showTaskRunLogs = useMemo(() => {+ if (!resolvedChangelog?.taskRun) {+ return false;+ }+ return (+ resolvedChangelog.status === Changelog_Status.DONE ||+ resolvedChangelog.status === Changelog_Status.FAILED+ );+ }, [resolvedChangelog]);++ const allowRollback = useMemo(() => {+ if (+ !detail.database ||+ detail.isDefaultProject ||+ !detail.allowAlterSchema+ ) {+ return false;+ }+ if (+ !resolvedChangelog ||+ resolvedChangelog.status !== Changelog_Status.DONE+ ) {+ return false;+ }+ return instanceV1SupportsSchemaRollback(+ getInstanceResource(detail.database).engine+ );+ }, [+ detail.allowAlterSchema,+ detail.database,+ detail.isDefaultProject,+ resolvedChangelog,+ ]);++ const databaseDisplayName =+ extractDatabaseResourceName(detail.database?.name ?? database)+ .databaseName || databaseName;+ const formattedCreateTime = useMemo(() => {+ if (!resolvedChangelog?.createTime) {+ return "";+ }+ return formatAbsoluteDateTime(+ getTimeForPbTimestampProtoEs(resolvedChangelog.createTime)+ );+ }, [resolvedChangelog?.createTime]);+ const formattedSchemaSize = useMemo(() => {+ if (!resolvedChangelog?.schemaSize) {+ return "";+ }+ return bytesToString(Number(resolvedChangelog.schemaSize));+ }, [resolvedChangelog?.schemaSize]);++ const handleProjectBreadcrumbClick = () => {+ router.push({+ name: PROJECT_V1_ROUTE_DATABASES,+ params: { projectId },+ });+ };++ const handleDatabaseBreadcrumbClick = () => {+ router.push({+ name: PROJECT_V1_ROUTE_DATABASE_DETAIL,+ params: {+ projectId,+ instanceId,+ databaseName,+ },+ });+ };++ const handleChangelogBreadcrumbClick = () => {+ router.push({+ name: PROJECT_V1_ROUTE_DATABASE_DETAIL,+ params: {+ projectId,+ instanceId,+ databaseName,+ },+ hash: "#changelog",+ });+ };++ const handleRollback = () => {+ if (!resolvedChangelog || !detail.database) {+ return;+ }++ router.push({+ name: PROJECT_V1_ROUTE_SYNC_SCHEMA,+ params: {+ projectId,+ },+ query: {+ changelog: resolvedChangelog.name,+ target: detail.database.name,+ rollback: "true",+ },+ });+ };++ if (detail.loading || loading) {+ return (+ <div className="flex items-center justify-center py-10">+ <LoaderCircle className="h-4 w-4 animate-spin text-control-light" />+ </div>+ );+ }++ if (!detail.ready || !resolvedChangelog) {+ return null;+ }++ return (+ <div className="flex min-h-full flex-col gap-y-4 p-4">+ <nav aria-label="Breadcrumb" className="mb-4">+ <ol className="flex flex-wrap items-center gap-x-2 text-sm text-control-light">+ <li>+ <button+ type="button"+ className="transition-colors hover:text-accent"+ onClick={handleProjectBreadcrumbClick}+ >+ {t("common.databases")}+ </button>+ </li>+ <li aria-hidden="true">/</li>+ <li>+ <button+ type="button"+ className="transition-colors hover:text-accent"+ onClick={handleDatabaseBreadcrumbClick}+ >+ {databaseDisplayName}+ </button>+ </li>+ <li aria-hidden="true">/</li>+ <li>+ <button+ type="button"+ className="transition-colors hover:text-accent"+ onClick={handleChangelogBreadcrumbClick}+ >+ {t("changelog.self")}+ </button>+ </li>+ <li aria-hidden="true">/</li>+ <li className="text-main">{changelogId}</li>+ </ol>+ </nav>++ <div className="flex flex-col gap-y-6">+ <div className="flex flex-col gap-y-4">+ {resolvedChangelog.planTitle ? (+ <h2 className="text-2xl font-semibold text-main">+ {resolvedChangelog.planTitle}+ </h2>+ ) : null}+ <div className="flex items-center gap-x-3 text-sm text-control-light">+ <ChangelogStatusIndicator status={resolvedChangelog.status} />+ {formattedCreateTime ? (+ <>+ <span aria-hidden="true">•</span>+ <span>{formattedCreateTime}</span>+ </>+ ) : null}+ </div>+ </div>++ {resolvedChangelog.taskRun ? (+ <div className="flex flex-col gap-y-2">+ <div className="flex items-center justify-between">+ <p className="text-lg text-main">{t("issue.task-run.logs")}</p>+ {taskFullLink ? (+ <a+ href={taskFullLink}+ className="flex items-center gap-x-1 text-sm text-control-light transition-colors hover:text-accent"+ onClick={(event) => {+ event.preventDefault();+ router.push({ path: taskFullLink });+ }}+ >+ {t("common.show-more")}+ <ArrowUpRight className="h-4 w-4" />+ </a>+ ) : null}+ </div>+ {showTaskRunLogs ? (+ <TaskRunLogViewer taskRunName={resolvedChangelog.taskRun} />+ ) : (+ <div className="text-sm text-control-light">+ {t("common.no-data")}+ </div>+ )}+ </div>+ ) : null}++ <div className="flex flex-col gap-y-2">+ <div className="flex items-center justify-between gap-x-2">+ <div className="flex items-center gap-x-2">+ <Switch checked={showDiff} onCheckedChange={setShowDiff} />+ <span className="text-sm font-semibold">+ {t("changelog.show-diff")}+ </span>+ </div>+ {allowRollback ? (+ <Button size="sm" onClick={handleRollback}>+ {t("common.rollback")}+ </Button>+ ) : null}+ </div>++ <div className="textinfolabel">+ {t("changelog.schema-snapshot-after-change")}+ </div>++ <p className="flex items-center gap-x-2 text-lg text-main">+ <span>+ {t("common.schema")} {t("common.snapshot")}+ </span>+ {formattedSchemaSize ? (+ <span className="text-sm font-normal text-control-light">+ ({formattedSchemaSize})+ </span>+ ) : null}+ <CopyButton content={resolvedChangelog.schema} />+ </p>++ {showDiff ? (+ <div className="grid gap-4 lg:grid-cols-2">+ <ReadonlyMonaco+ content={previousChangelog?.schema ?? ""}+ className="relative h-auto max-h-[600px] min-h-[120px]"+ />+ <ReadonlyMonaco+ content={resolvedChangelog.schema}+ className="relative h-auto max-h-[600px] min-h-[120px]"+ />+ </div>+ ) : resolvedChangelog.schema ? (+ <ReadonlyMonaco+ content={resolvedChangelog.schema}+ className="relative h-auto min-h-[120px] max-h-[600px]"+ />+ ) : (+ <div className="text-sm text-control-light">+ {t("changelog.current-schema-empty")}+ </div>+ )}+ </div>+ </div>+ </div>+ );+}++export default DatabaseChangelogDetailPage;diff --git a/frontend/src/react/pages/project/DatabaseRevisionDetailPage.test.tsx b/frontend/src/react/pages/project/DatabaseRevisionDetailPage.test.tsxnew file mode 100644index 0000000000..c104ac5d8a--- /dev/null+++ b/frontend/src/react/pages/project/DatabaseRevisionDetailPage.test.tsx@@ -0,0 +1,276 @@+import { act, createElement } from "react";+import { createRoot } from "react-dom/client";+import { beforeEach, describe, expect, test, vi } from "vitest";++(+ globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }+).IS_REACT_ACT_ENVIRONMENT = true;++const mocks = vi.hoisted(() => {+ const localStorage = {+ clear: vi.fn(),+ getItem: vi.fn(() => null),+ removeItem: vi.fn(),+ setItem: vi.fn(),+ };+ vi.stubGlobal("localStorage", localStorage);++ return {+ localStorage,+ routerPush: vi.fn(),+ useProjectDatabaseDetail: vi.fn(),+ extractDatabaseResourceName: vi.fn((name: string) => ({+ instance: "instances/inst1",+ instanceName: "inst1",+ database: name,+ databaseName: name.split("/databases/").at(-1) ?? "",+ })),+ extractInstanceResourceName: vi.fn(+ (name: string) => name.split("/").at(-1) ?? ""+ ),+ extractProjectResourceName: vi.fn(+ (name: string) => name.split("/").at(-1) ?? ""+ ),+ useTranslation: vi.fn(() => ({+ t: (key: string) => key,+ })),+ LoaderCircle: vi.fn(() => <div data-testid="spinner" />),+ RevisionDetailPanel: vi.fn(({ revisionName }: { revisionName: string }) => (+ <div data-testid="revision-detail-panel">{revisionName}</div>+ )),+ routeNames: {+ databases: "workspace.project.databases",+ databaseDetail: "workspace.project.database.detail",+ databaseRevisionDetail: "workspace.project.database.revision.detail",+ },+ };+});++type DatabaseRevisionDetailPageComponent =+ typeof import("./DatabaseRevisionDetailPage").DatabaseRevisionDetailPage;+let DatabaseRevisionDetailPage: DatabaseRevisionDetailPageComponent;++vi.mock("lucide-react", () => ({+ LoaderCircle: mocks.LoaderCircle,+}));++vi.mock("react-i18next", () => ({+ useTranslation: mocks.useTranslation,+}));++vi.mock("@/react/components/revision", () => ({+ RevisionDetailPanel: mocks.RevisionDetailPanel,+}));++vi.mock("@/router", () => ({+ router: {+ push: mocks.routerPush,+ },+}));++vi.mock("@/router/dashboard/projectV1", () => ({+ PROJECT_V1_ROUTE_DATABASES: mocks.routeNames.databases,+ PROJECT_V1_ROUTE_DATABASE_DETAIL: mocks.routeNames.databaseDetail,+ PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL:+ mocks.routeNames.databaseRevisionDetail,+}));++vi.mock("./database-detail/useProjectDatabaseDetail", () => ({+ useProjectDatabaseDetail: mocks.useProjectDatabaseDetail,+}));++vi.mock("@/utils/v1/database", () => ({+ extractDatabaseResourceName: mocks.extractDatabaseResourceName,+}));++vi.mock("@/utils/v1/instance", () => ({+ extractInstanceResourceName: mocks.extractInstanceResourceName,+}));++vi.mock("@/utils/v1/project", () => ({+ extractProjectResourceName: mocks.extractProjectResourceName,+}));++const renderIntoContainer = (element: ReturnType<typeof createElement>) => {+ const container = document.createElement("div");+ const root = createRoot(container);++ return {+ container,+ render: (nextElement = element) => {+ act(() => {+ root.render(nextElement);+ });+ },+ unmount: () =>+ act(() => {+ root.unmount();+ }),+ };+};++beforeEach(() => {+ mocks.localStorage.getItem.mockReset();+ mocks.localStorage.getItem.mockReturnValue(null);+ mocks.localStorage.setItem.mockReset();+ mocks.localStorage.removeItem.mockReset();+ mocks.localStorage.clear.mockReset();+ mocks.routerPush.mockReset();+ mocks.useProjectDatabaseDetail.mockReset();+ mocks.extractDatabaseResourceName.mockReset();+ mocks.extractDatabaseResourceName.mockImplementation((name: string) => ({+ instance: "instances/inst1",+ instanceName: "inst1",+ database: name,+ databaseName: name.split("/databases/").at(-1) ?? "",+ }));+ mocks.extractInstanceResourceName.mockReset();+ mocks.extractInstanceResourceName.mockImplementation(+ (name: string) => name.split("/").at(-1) ?? ""+ );+ mocks.extractProjectResourceName.mockReset();+ mocks.extractProjectResourceName.mockImplementation(+ (name: string) => name.split("/").at(-1) ?? ""+ );+ mocks.useTranslation.mockReset();+ mocks.useTranslation.mockReturnValue({+ t: (key: string) => key,+ });+ mocks.LoaderCircle.mockClear();+ mocks.RevisionDetailPanel.mockClear();+});++beforeEach(async () => {+ vi.resetModules();+ ({ DatabaseRevisionDetailPage } = await import(+ "./DatabaseRevisionDetailPage"+ ));+});++describe("DatabaseRevisionDetailPage", () => {+ test("shows a spinner while the shared database hook is loading", async () => {+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db-from-hook",+ project: "projects/proj1",+ },+ databaseName: "instances/inst1/databases/db-from-hook",+ loading: true,+ ready: false,+ allowAlterSchema: true,+ isDefaultProject: false,+ });+ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseRevisionDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db-from-prop",+ revisionId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(container.querySelector('[data-testid="spinner"]')).not.toBeNull();+ expect(mocks.RevisionDetailPanel).not.toHaveBeenCalled();++ unmount();+ });++ test("builds the revision name from the resolved database detail", async () => {+ mocks.useProjectDatabaseDetail.mockReturnValue({+ database: {+ name: "instances/inst1/databases/db-from-hook",+ project: "projects/proj1",+ },+ databaseName: "instances/inst1/databases/db-from-hook",+ loading: false,+ ready: true,+ allowAlterSchema: true,+ isDefaultProject: false,+ });+ const { container, render, unmount } = renderIntoContainer(+ createElement(DatabaseRevisionDetailPage, {+ project: "projects/proj1",+ instance: "instances/inst1",+ database: "instances/inst1/databases/db-from-prop",+ revisionId: "7",+ })+ );++ render();++ await act(async () => {+ await Promise.resolve();+ await Promise.resolve();+ });++ expect(mocks.useProjectDatabaseDetail).toHaveBeenCalledWith({+ projectId: "proj1",+ instanceId: "inst1",+ databaseName: "db-from-prop",+ routeName: mocks.routeNames.databaseRevisionDetail,+ revisionId: "7",+ });+ expect(mocks.RevisionDetailPanel).toHaveBeenCalled();+ expect(mocks.RevisionDetailPanel.mock.calls[0]?.[0]).toEqual({+ revisionName: "instances/inst1/databases/db-from-hook/revisions/7",+ });++ expect(container.textContent).toContain(+ "instances/inst1/databases/db-from-hook/revisions/7"+ );++ const clickButton = async (label: string) => {+ const button = Array.from(container.querySelectorAll("button")).find(+ (candidate) => candidate.textContent === label+ );++ await act(async () => {+ button?.dispatchEvent(new MouseEvent("click", { bubbles: true }));+ });+ };++ await clickButton("common.databases");+ expect(mocks.routerPush).toHaveBeenCalledWith({+ name: mocks.routeNames.databases,+ params: {+ projectId: "proj1",+ },+ });++ await clickButton("db-from-prop");+ expect(mocks.routerPush).toHaveBeenCalledWith({+ name: mocks.routeNames.databaseDetail,+ params: {+ projectId: "proj1",+ instanceId: "inst1",+ databaseName: "db-from-prop",+ },+ });++ await clickButton("database.revision.self");+ expect(mocks.routerPush).toHaveBeenCalledWith({+ name: mocks.routeNames.databaseDetail,+ params: {+ projectId: "proj1",+ instanceId: "inst1",+ databaseName: "db-from-prop",+ },+ hash: "#revision",+ });++ const databaseBreadcrumb = Array.from(+ container.querySelectorAll("button")+ ).find((button) => button.textContent === "db-from-prop");++ expect(databaseBreadcrumb).not.toBeNull();++ unmount();+ });+});diff --git a/frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx b/frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsxindex 42089c155a..5c2b9a5e38 100644--- a/frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx+++ b/frontend/src/react/pages/project/DatabaseRevisionDetailPage.tsx@@ -1,16 +1,16 @@import { LoaderCircle } from "lucide-react";-import { useEffect, useState } from "react";import { useTranslation } from "react-i18next";import { RevisionDetailPanel } from "@/react/components/revision";import { router } from "@/router";import {PROJECT_V1_ROUTE_DATABASE_DETAIL,+ PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL,PROJECT_V1_ROUTE_DATABASES,} from "@/router/dashboard/projectV1";-import { useDatabaseV1Store } from "@/store";import { extractDatabaseResourceName } from "@/utils/v1/database";import { extractInstanceResourceName } from "@/utils/v1/instance";import { extractProjectResourceName } from "@/utils/v1/project";+import { useProjectDatabaseDetail } from "./database-detail/useProjectDatabaseDetail";export function DatabaseRevisionDetailPage({project,@@ -24,33 +24,17 @@ export function DatabaseRevisionDetailPage({revisionId: string;}) {const { t } = useTranslation();- const databaseStore = useDatabaseV1Store();- const [loading, setLoading] = useState(true);const projectId = extractProjectResourceName(project);- const databaseFullName = database;const { databaseName } = extractDatabaseResourceName(database);const instanceId = extractInstanceResourceName(instance);- const revisionName = `${databaseFullName}/revisions/${revisionId}`;-- useEffect(() => {- let cancelled = false;-- setLoading(true);- void databaseStore- .getOrFetchDatabaseByName(databaseFullName)- .catch((error) => {- console.error("Failed to fetch database details", error);- })- .finally(() => {- if (!cancelled) {- setLoading(false);- }- });-- return () => {- cancelled = true;- };- }, [databaseFullName, databaseStore]);+ const detail = useProjectDatabaseDetail({+ projectId,+ instanceId,+ databaseName,+ routeName: PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL,+ revisionId,+ });+ const revisionName = `${detail.databaseName}/revisions/${revisionId}`;const handleProjectBreadcrumbClick = () => {router.push({@@ -120,7 +104,7 @@ export function DatabaseRevisionDetailPage({</ol></nav>- {loading ? (+ {detail.loading ? (<div className="flex items-center justify-center py-10"><LoaderCircle className="h-4 w-4 animate-spin text-control-light" /></div>diff --git a/frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.test.tsx b/frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.test.tsxnew file mode 100644index 0000000000..d3b25dc9a9--- /dev/null+++ b/frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.test.tsx@@ -0,0 +1,285 @@+import { act, createElement } from "react";+import { createRoot } from "react-dom/client";+import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";+import type { UseProjectDatabaseDetailOptions } from "./useProjectDatabaseDetail";+import { useProjectDatabaseDetail } from "./useProjectDatabaseDetail";++(+ globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }+).IS_REACT_ACT_ENVIRONMENT = true;++const originalConsoleError = console.error;++const mocks = vi.hoisted(() => {+ const localStorage = {+ clear: vi.fn(),+ getItem: vi.fn(() => null),+ removeItem: vi.fn(),+ setItem: vi.fn(),+ };+ vi.stubGlobal("localStorage", localStorage);++ return {+ localStorage,+ replace: vi.fn(),+ getOrFetchDatabaseByName: vi.fn(),+ getOrFetchDatabaseMetadata: vi.fn(),+ getDatabaseByName: vi.fn(),+ getInstanceResource: vi.fn((database: { instanceResource?: unknown }) => {+ return database.instanceResource ?? {};+ }),+ instanceV1HasAlterSchema: vi.fn(() => true),+ extractProjectResourceName: vi.fn((name: string) => {+ return name.split("/").at(-1) ?? "";+ }),+ isDefaultProject: vi.fn(() => false),+ routeNames: {+ databaseDetail: "workspace.project.database.detail",+ databaseChangelogDetail: "workspace.project.database.changelog.detail",+ databaseRevisionDetail: "workspace.project.database.revision.detail",+ },+ };+});++vi.mock("@/router", () => ({+ router: { replace: mocks.replace },+}));++vi.mock("@/router/dashboard/projectV1", () => ({+ PROJECT_V1_ROUTE_DATABASE_DETAIL: mocks.routeNames.databaseDetail,+ PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL:+ mocks.routeNames.databaseChangelogDetail,+ PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL:+ mocks.routeNames.databaseRevisionDetail,+}));++vi.mock("@/store", () => ({+ useDatabaseV1Store: () => ({+ getOrFetchDatabaseByName: mocks.getOrFetchDatabaseByName,+ getDatabaseByName: mocks.getDatabaseByName,+ }),+ useDBSchemaV1Store: () => ({+ getOrFetchDatabaseMetadata: mocks.getOrFetchDatabaseMetadata,+ }),+}));++vi.mock("@/utils", () => ({+ getInstanceResource: mocks.getInstanceResource,+ instanceV1HasAlterSchema: mocks.instanceV1HasAlterSchema,+}));++vi.mock("@/utils/v1/project", () => ({+ extractProjectResourceName: mocks.extractProjectResourceName,+}));++vi.mock("@/types/v1/project", () => {+ const UNKNOWN_PROJECT_NAME = "projects/-";+ return {+ UNKNOWN_PROJECT_NAME,+ isDefaultProject: mocks.isDefaultProject,+ unknownProject: () => ({+ name: UNKNOWN_PROJECT_NAME,+ title: "",+ }),+ defaultProject: (name: string) => ({+ name,+ title: "Default project",+ }),+ isValidProjectName: (name: string | undefined) =>+ !!name && name.startsWith("projects/") && name !== UNKNOWN_PROJECT_NAME,+ };+});++function HookProbe(+ props: UseProjectDatabaseDetailOptions & {+ onValue: (value: ReturnType<typeof useProjectDatabaseDetail>) => void;+ }+) {+ props.onValue(useProjectDatabaseDetail(props));+ return null;+}++const waitFor = async (condition: () => boolean, timeoutMs = 1000) => {+ const start = Date.now();+ while (!condition()) {+ if (Date.now() - start >= timeoutMs) {+ throw new Error("Timed out waiting for condition");+ }+ await Promise.resolve();+ await new Promise<void>((resolve) => {+ setTimeout(resolve, 0);+ });+ }+};++const renderIntoContainer = (element: ReturnType<typeof createElement>) => {+ const container = document.createElement("div");+ const root = createRoot(container);++ return {+ render: () => {+ root.render(element);+ },+ unmount: () =>+ act(() => {+ root.unmount();+ }),+ };+};++beforeEach(() => {+ vi.spyOn(console, "error").mockImplementation((message, ...args) => {+ const text = String(message);+ if (text.includes("not wrapped in act")) {+ return;+ }+ originalConsoleError(message, ...args);+ });+ mocks.localStorage.getItem.mockReset();+ mocks.localStorage.getItem.mockReturnValue(null);+ mocks.localStorage.setItem.mockReset();+ mocks.localStorage.removeItem.mockReset();+ mocks.localStorage.clear.mockReset();+ mocks.replace.mockReset();+ mocks.getOrFetchDatabaseByName.mockReset();+ mocks.getOrFetchDatabaseMetadata.mockReset();+ mocks.getDatabaseByName.mockReset();+ mocks.getInstanceResource.mockReset();+ mocks.getInstanceResource.mockImplementation(+ (database: { instanceResource?: unknown }) =>+ database.instanceResource ?? {}+ );+ mocks.instanceV1HasAlterSchema.mockReset();+ mocks.instanceV1HasAlterSchema.mockReturnValue(true);+ mocks.extractProjectResourceName.mockReset();+ mocks.extractProjectResourceName.mockImplementation(+ (name: string) => name.split("/").at(-1) ?? ""+ );+ mocks.isDefaultProject.mockReset();+ mocks.isDefaultProject.mockReturnValue(false);+});++afterEach(() => {+ vi.restoreAllMocks();+});++describe("useProjectDatabaseDetail", () => {+ test("loads the database and warms metadata", async () => {+ const database = {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ };+ mocks.getDatabaseByName.mockReturnValue(database);+ mocks.getOrFetchDatabaseByName.mockResolvedValue(database);+ mocks.getOrFetchDatabaseMetadata.mockResolvedValue({});++ let latest: ReturnType<typeof useProjectDatabaseDetail> | undefined;++ const { render, unmount } = renderIntoContainer(+ createElement(HookProbe, {+ projectId: "proj1",+ instanceId: "inst1",+ databaseName: "db1",+ onValue: (value) => {+ latest = value;+ },+ })+ );++ act(() => {+ render();+ });+ await waitFor(() => latest?.ready === true);++ expect(mocks.getOrFetchDatabaseByName).toHaveBeenCalledWith(+ "instances/inst1/databases/db1"+ );+ expect(mocks.getOrFetchDatabaseMetadata).toHaveBeenCalledWith({+ database: "instances/inst1/databases/db1",+ silent: true,+ });+ expect(latest?.databaseName).toBe("instances/inst1/databases/db1");+ expect(latest?.ready).toBe(true);+ expect(latest?.allowAlterSchema).toBe(true);+ expect(latest?.isDefaultProject).toBe(false);++ unmount();+ });++ test("ignores metadata permission failures", async () => {+ const database = {+ name: "instances/inst1/databases/db1",+ project: "projects/proj1",+ };+ mocks.getDatabaseByName.mockReturnValue(database);+ mocks.getOrFetchDatabaseByName.mockResolvedValue(database);+ mocks.getOrFetchDatabaseMetadata.mockRejectedValue(+ new Error("permission denied")+ );++ let latest: ReturnType<typeof useProjectDatabaseDetail> | undefined;++ const { render, unmount } = renderIntoContainer(+ createElement(HookProbe, {+ projectId: "proj1",+ instanceId: "inst1",+ databaseName: "db1",+ onValue: (value) => {+ latest = value;+ },+ })+ );++ act(() => {+ render();+ });+ await waitFor(() => latest?.loading === false);++ expect(latest?.databaseName).toBe("instances/inst1/databases/db1");+ expect(mocks.replace).not.toHaveBeenCalled();++ unmount();+ });++ test("redirects to the canonical project route", async () => {+ const database = {+ name: "instances/inst1/databases/db1",+ project: "projects/proj2",+ };+ mocks.getDatabaseByName.mockReturnValue(database);+ mocks.getOrFetchDatabaseByName.mockResolvedValue(database);+ mocks.getOrFetchDatabaseMetadata.mockResolvedValue({});++ const { render, unmount } = renderIntoContainer(+ createElement(HookProbe, {+ projectId: "proj1",+ instanceId: "inst1",+ databaseName: "db1",+ routeName: mocks.routeNames.databaseRevisionDetail,+ revisionId: "123",+ hash: "#revision",+ query: { foo: "bar" },+ onValue: () => {},+ })+ );++ act(() => {+ render();+ });+ await waitFor(() => mocks.replace.mock.calls.length > 0);++ expect(mocks.replace).toHaveBeenCalledWith({+ name: mocks.routeNames.databaseRevisionDetail,+ params: {+ projectId: "proj2",+ instanceId: "inst1",+ databaseName: "db1",+ revisionId: "123",+ },+ hash: "#revision",+ query: { foo: "bar" },+ });++ unmount();+ });+});diff --git a/frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.ts b/frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.tsnew file mode 100644index 0000000000..884da31709--- /dev/null+++ b/frontend/src/react/pages/project/database-detail/useProjectDatabaseDetail.ts@@ -0,0 +1,121 @@+import { useEffect, useMemo, useState } from "react";+import type { LocationQueryRaw } from "vue-router";+import { useVueState } from "@/react/hooks/useVueState";+import { router } from "@/router";+import {+ PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL,+ PROJECT_V1_ROUTE_DATABASE_DETAIL,+ PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL,+} from "@/router/dashboard/projectV1";+import { useDatabaseV1Store, useDBSchemaV1Store } from "@/store";+import { isDefaultProject } from "@/types/v1/project";+import { getInstanceResource, instanceV1HasAlterSchema } from "@/utils";+import { extractProjectResourceName } from "@/utils/v1/project";++export interface UseProjectDatabaseDetailOptions {+ projectId: string;+ instanceId: string;+ databaseName: string;+ routeName?: string;+ hash?: string;+ query?: LocationQueryRaw;+ changelogId?: string;+ revisionId?: string;+}++export function useProjectDatabaseDetail({+ projectId,+ instanceId,+ databaseName,+ routeName,+ hash,+ query,+ changelogId,+ revisionId,+}: UseProjectDatabaseDetailOptions) {+ const databaseStore = useDatabaseV1Store();+ const dbSchemaStore = useDBSchemaV1Store();+ const fullDatabaseName = `instances/${instanceId}/databases/${databaseName}`;+ const database = useVueState(() =>+ databaseStore.getDatabaseByName(fullDatabaseName)+ );+ const [loading, setLoading] = useState(true);++ useEffect(() => {+ let cancelled = false;++ setLoading(true);+ void databaseStore+ .getOrFetchDatabaseByName(fullDatabaseName)+ .then(async (db) => {+ try {+ await dbSchemaStore.getOrFetchDatabaseMetadata({+ database: db.name,+ silent: true,+ });+ } catch {+ // Permission errors should not block page rendering.+ }++ const canonicalProjectId = extractProjectResourceName(db.project);+ if (canonicalProjectId !== projectId) {+ const name =+ routeName === PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL+ ? PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL+ : routeName === PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL+ ? PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL+ : PROJECT_V1_ROUTE_DATABASE_DETAIL;+ void router.replace({+ name,+ params: {+ projectId: canonicalProjectId,+ instanceId,+ databaseName,+ ...(changelogId ? { changelogId } : {}),+ ...(revisionId ? { revisionId } : {}),+ },+ hash,+ query,+ });+ }+ })+ .finally(() => {+ if (!cancelled) {+ setLoading(false);+ }+ });++ return () => {+ cancelled = true;+ };+ }, [+ changelogId,+ databaseName,+ databaseStore,+ dbSchemaStore,+ fullDatabaseName,+ hash,+ instanceId,+ projectId,+ query,+ revisionId,+ routeName,+ ]);++ const allowAlterSchema = useMemo(() => {+ return database+ ? instanceV1HasAlterSchema(getInstanceResource(database))+ : false;+ }, [database]);++ return {+ projectName: `projects/${projectId}`,+ instanceName: `instances/${instanceId}`,+ databaseName: fullDatabaseName,+ database,+ loading,+ ready: !!database && !loading,+ allowAlterSchema,+ isDefaultProject: database ? isDefaultProject(database.project) : false,+ };+}diff --git a/frontend/src/router/dashboard/projectV1.ts b/frontend/src/router/dashboard/projectV1.tsindex 3b511185bb..03af8278a3 100644--- a/frontend/src/router/dashboard/projectV1.ts+++ b/frontend/src/router/dashboard/projectV1.ts@@ -417,55 +417,50 @@ const projectV1Routes: RouteRecordRaw[] = [},{path: "instances/:instanceId/databases/:databaseName",+ name: PROJECT_V1_ROUTE_DATABASE_DETAIL,meta: {title: () => t("common.database"),requiredPermissionList: () => ["bb.databases.get"],},- component: () => import("@/views/project/ProjectDatabaseLayout.vue"),- props: { content: true, leftSidebar: true },- children: [- {- path: "",- name: PROJECT_V1_ROUTE_DATABASE_DETAIL,- component: () => import("@/views/DatabaseDetail"),- props: true,- },- {- path: "changelogs/:changelogId",- name: PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL,- meta: {- requiredPermissionList: () => [- "bb.databases.get",- "bb.changelogs.get",- ],- },- component: () =>- import("@/views/DatabaseDetail/ChangelogDetail.vue"),- props: (route) => ({- ...route.params,- project: `projects/${route.params.projectId}`,- instance: `instances/${route.params.instanceId}`,- database: `instances/${route.params.instanceId}/databases/${route.params.databaseName}`,- changelogId: route.params.changelogId,- }),- },- {- path: "revisions/:revisionId",- name: PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL,- meta: {- requiredPermissionList: () => ["bb.databases.get"],- },- component: () => import("@/react/ReactPageMount.vue"),- props: (route: RouteLocationNormalized) => ({- page: "DatabaseRevisionDetailPage",- ...route.params,- project: `projects/${route.params.projectId}`,- instance: `instances/${route.params.instanceId}`,- database: `instances/${route.params.instanceId}/databases/${route.params.databaseName}`,- revisionId: route.params.revisionId,- }),- },- ],+ component: () => import("@/views/DatabaseDetail"),+ props: true,+ },+ {+ path: "instances/:instanceId/databases/:databaseName/changelogs/:changelogId",+ name: PROJECT_V1_ROUTE_DATABASE_CHANGELOG_DETAIL,+ meta: {+ title: () => t("common.database"),+ requiredPermissionList: () => [+ "bb.databases.get",+ "bb.changelogs.get",+ ],+ },+ component: () => import("@/react/ReactPageMount.vue"),+ props: (route: RouteLocationNormalized) => ({+ page: "DatabaseChangelogDetailPage",+ ...route.params,+ project: `projects/${route.params.projectId}`,+ instance: `instances/${route.params.instanceId}`,+ database: `instances/${route.params.instanceId}/databases/${route.params.databaseName}`,+ changelogId: route.params.changelogId,+ }),+ },+ {+ path: "instances/:instanceId/databases/:databaseName/revisions/:revisionId",+ name: PROJECT_V1_ROUTE_DATABASE_REVISION_DETAIL,+ meta: {+ title: () => t("common.database"),+ requiredPermissionList: () => ["bb.databases.get"],+ },+ component: () => import("@/react/ReactPageMount.vue"),+ props: (route: RouteLocationNormalized) => ({+ page: "DatabaseRevisionDetailPage",+ ...route.params,+ project: `projects/${route.params.projectId}`,+ instance: `instances/${route.params.instanceId}`,+ database: `instances/${route.params.instanceId}/databases/${route.params.databaseName}`,+ revisionId: route.params.revisionId,+ }),},{path: "data-export",diff --git a/frontend/src/views/DatabaseDetail/ChangelogDetail.vue b/frontend/src/views/DatabaseDetail/ChangelogDetail.vuedeleted file mode 100644index 1b93ba3aca..0000000000--- a/frontend/src/views/DatabaseDetail/ChangelogDetail.vue+++ /dev/null@@ -1,49 +0,0 @@-<template>- <div>- <NBreadcrumb class="mb-4">- <NBreadcrumbItem @click="router.push(`/${props.project}/databases`)">- {{ $t("common.databases") }}- </NBreadcrumbItem>- <NBreadcrumbItem @click="router.push(databaseV1Url(database))">- {{ extractDatabaseResourceName(database.name).databaseName }}- </NBreadcrumbItem>- <NBreadcrumbItem- @click="router.push(`${databaseV1Url(database)}#changelog`)"- >- {{ $t("changelog.self") }}- </NBreadcrumbItem>- <NBreadcrumbItem :clickable="false">- {{ changelogId }}- </NBreadcrumbItem>- </NBreadcrumb>- <ChangelogDetailView- v-if="ready"- :instance="instance"- :database="database.name"- :changelog-id="changelogId"- />- <div v-else class="flex justify-center items-center py-10">- <BBSpin />- </div>- </div>-</template>--<script lang="ts" setup>-import { NBreadcrumb, NBreadcrumbItem } from "naive-ui";-import { useRouter } from "vue-router";-import { BBSpin } from "@/bbkit";-import { ChangelogDetail as ChangelogDetailView } from "@/components/Changelog";-import { useDatabaseV1ByName } from "@/store";-import { databaseV1Url, extractDatabaseResourceName } from "@/utils";--const props = defineProps<{- project: string;- instance: string;- database: string;- changelogId: string;-}>();--const router = useRouter();--const { database, ready } = useDatabaseV1ByName(props.database);-</script>diff --git a/frontend/src/views/DatabaseDetail/DatabaseDetail.vue b/frontend/src/views/DatabaseDetail/DatabaseDetail.vueindex 53360f78e2..9e4842f933 100644--- a/frontend/src/views/DatabaseDetail/DatabaseDetail.vue+++ b/frontend/src/views/DatabaseDetail/DatabaseDetail.vue@@ -219,10 +219,10 @@<script lang="ts" setup>import { ArrowRightLeftIcon } from "lucide-vue-next";import { NButton, NTabPane, NTabs } from "naive-ui";-import { computed, reactive, watch, watchEffect } from "vue";+import { computed, onMounted, reactive, watch, watchEffect } from "vue";import { useRoute, useRouter } from "vue-router";import { BBAttention, BBModal } from "@/bbkit";-import { useDatabaseDetailContext } from "@/components/Database/context";+import { provideDatabaseDetailContext } from "@/components/Database/context";import DatabaseChangelogPanel from "@/components/Database/DatabaseChangelogPanel.vue";import DatabaseOverviewPanel from "@/components/Database/DatabaseOverviewPanel.vue";import DatabaseRevisionPanel from "@/components/Database/DatabaseRevisionPanel.vue";@@ -247,7 +247,11 @@ import {ProductionEnvironmentV1Icon,} from "@/components/v2";import { PROJECT_V1_ROUTE_DATABASE_DETAIL } from "@/router/dashboard/projectV1";-import { useDatabaseV1ByName } from "@/store";+import {+ useDatabaseV1ByName,+ useDatabaseV1Store,+ useDBSchemaV1Store,+} from "@/store";import {databaseNamePrefix,instanceNamePrefix,@@ -289,6 +293,8 @@ const props = defineProps<{}>();const router = useRouter();+const databaseStore = useDatabaseV1Store();+const dbSchemaStore = useDBSchemaV1Store();const state = reactive<LocalState>({showTransferDatabaseModal: false,@@ -297,7 +303,24 @@ const state = reactive<LocalState>({selectedTab: "overview",});const route = useRoute();-const { isDefaultProject } = useDatabaseDetailContext();+const { isDefaultProject } = provideDatabaseDetailContext(+ computed(() => props.instanceId),+ computed(() => props.databaseName)+);++onMounted(async () => {+ const database = await databaseStore.getOrFetchDatabaseByName(+ `${instanceNamePrefix}${props.instanceId}/${databaseNamePrefix}${props.databaseName}`+ );+ try {+ await dbSchemaStore.getOrFetchDatabaseMetadata({+ database: database.name,+ silent: true,+ });+ } catch {+ // Silently ignore permission errors.+ }+});watch(() => route.hash,diff --git a/frontend/src/views/DatabaseDetail/index.ts b/frontend/src/views/DatabaseDetail/index.tsindex 58945fcda1..c02f84cf43 100644--- a/frontend/src/views/DatabaseDetail/index.ts+++ b/frontend/src/views/DatabaseDetail/index.ts@@ -1,6 +1,3 @@-import ChangelogDetail from "./ChangelogDetail.vue";import DatabaseDetail from "./DatabaseDetail.vue";-export { ChangelogDetail };-export default DatabaseDetail;diff --git a/frontend/src/views/project/ProjectDatabaseLayout.vue b/frontend/src/views/project/ProjectDatabaseLayout.vuedeleted file mode 100644index b4667d8ad8..0000000000--- a/frontend/src/views/project/ProjectDatabaseLayout.vue+++ /dev/null@@ -1,46 +0,0 @@-<template>- <router-view- class="p-4"- :project-id="projectId"- :instance-id="instanceId"- :database-name="databaseName"- />-</template>--<script lang="ts" setup>-import { computed, onMounted } from "vue";-import { provideDatabaseDetailContext } from "@/components/Database/context";-import { useDatabaseV1Store, useDBSchemaV1Store } from "@/store";-import {- databaseNamePrefix,- instanceNamePrefix,-} from "@/store/modules/v1/common";--const props = defineProps<{- projectId: string;- instanceId: string;- databaseName: string;-}>();--const databaseStore = useDatabaseV1Store();-const dbSchemaStore = useDBSchemaV1Store();-provideDatabaseDetailContext(- computed(() => props.instanceId),- computed(() => props.databaseName)-);--onMounted(async () => {- const database = await databaseStore.getOrFetchDatabaseByName(- `${instanceNamePrefix}${props.instanceId}/${databaseNamePrefix}${props.databaseName}`- );- try {- await dbSchemaStore.getOrFetchDatabaseMetadata({- database: database.name,- silent: true,- });- } catch {- // Silently ignore permission errors — the page can still render- // without schema metadata.- }-});-</script>