Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: inherit expiration time on web refresh token rotation (#18753)
p0nyec80e762b08a
diff --git a/backend/api/v1/auth_service.go b/backend/api/v1/auth_service.goindex 9517d55493..a5707f452d 100644--- a/backend/api/v1/auth_service.go+++ b/backend/api/v1/auth_service.go@@ -216,16 +216,16 @@ func (s *AuthService) Refresh(ctx context.Context, req *connect.Request[v1pb.Refreturn nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to generate access token"))}- refreshTokenDuration := auth.GetRefreshTokenDuration(ctx, s.store, s.licenseService)newRefreshToken, err := auth.GenerateOpaqueToken()if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to generate refresh token"))}+ // Inherit expiration from the original token (absolute session lifetime)if err := s.store.CreateWebRefreshToken(ctx, &store.WebRefreshTokenMessage{TokenHash: auth.HashToken(newRefreshToken),UserEmail: user.Email,- ExpiresAt: time.Now().Add(refreshTokenDuration),+ ExpiresAt: stored.ExpiresAt,}); err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to create refresh token"))}@@ -234,7 +234,7 @@ func (s *AuthService) Refresh(ctx context.Context, req *connect.Request[v1pb.Refresp := connect.NewResponse(&v1pb.RefreshResponse{})origin := req.Header().Get("Origin")resp.Header().Add("Set-Cookie", auth.GetTokenCookie(ctx, s.store, s.licenseService, origin, accessToken).String())- resp.Header().Add("Set-Cookie", auth.GetRefreshTokenCookie(origin, newRefreshToken, refreshTokenDuration).String())+ resp.Header().Add("Set-Cookie", auth.GetRefreshTokenCookie(origin, newRefreshToken, time.Until(stored.ExpiresAt)).String())return resp, nil}