Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: update review template (#18543)

ecmadaoeeff481ac8b8
diff --git a/frontend/src/components/SQLReview/SQLReviewCreation.vue b/frontend/src/components/SQLReview/SQLReviewCreation.vue
index 2d47e7de1d..a1b1479266 100644
--- a/frontend/src/components/SQLReview/SQLReviewCreation.vue
+++ b/frontend/src/components/SQLReview/SQLReviewCreation.vue
@@ -5,7 +5,7 @@
:current-index="state.currentStep"
:step-list="STEP_LIST"
:allow-next="allowNext"
- :finish-title="$t(`common.confirm-and-${policy ? 'update' : 'add'}`)"
+ :finish-title="finishTitle"
class="flex-1 overflow-hidden flex flex-col"
pane-class="flex-1 overflow-y-auto"
@update:current-index="changeStepIndex"
@@ -107,6 +107,13 @@ const { t } = useI18n();
const router = useRouter();
const store = useSQLReviewStore();
+const finishTitle = computed(() => {
+ if (props.policy) {
+ return t("common.confirm-and-update");
+ }
+ return t("common.confirm-and-add");
+});
+
const BASIC_INFO_STEP = 0;
const CONFIGURE_RULE_STEP = 1;
const PREVIEW_STEP = 2;
diff --git a/frontend/src/components/SQLReview/components/RuleConfigComponents/StringArrayComponent.vue b/frontend/src/components/SQLReview/components/RuleConfigComponents/StringArrayComponent.vue
index b919c26c77..ec98992fce 100644
--- a/frontend/src/components/SQLReview/components/RuleConfigComponents/StringArrayComponent.vue
+++ b/frontend/src/components/SQLReview/components/RuleConfigComponents/StringArrayComponent.vue
@@ -1,6 +1,16 @@
<template>
<div>
- <div class="flex flex-wrap gap-4 mb-4">
+ <div v-if="!disabled" class="textinfolabel mb-1">
+ {{ $t('sql-review.input-then-press-enter') }}
+ </div>
+ <BBTextField
+ v-model:value="inputValue"
+ pattern="[a-z]+"
+ :disabled="disabled"
+ :placeholder="$t('sql-review.input-then-press-enter')"
+ @keyup.enter="push($event)"
+ />
+ <div v-if="value.length > 0" class="flex flex-wrap gap-4 mt-4">
<BBBadge
v-for="(val, i) in value"
:key="i"
@@ -9,13 +19,6 @@
@remove="remove(val)"
/>
</div>
- <BBTextField
- v-if="!disabled"
- v-model:value="inputValue"
- pattern="[a-z]+"
- :placeholder="$t('sql-review.input-then-press-enter')"
- @keyup.enter="push($event)"
- />
</div>
</template>
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index 926c77b99b..82b259a651 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -93,6 +93,7 @@
"new": "New",
"add": "Add",
"confirm-and-update": "Confirm and update",
+ "confirm-and-add": "Confirm and add",
"query": "Query",
"transfer": "Transfer",
"schema": "Schema",
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index ff4a855d7b..6782283e81 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -93,6 +93,7 @@
"new": "Nuevo",
"add": "Agregar",
"confirm-and-update": "Confirmar y actualizar",
+ "confirm-and-add": "Confirmar y agregar",
"query": "Consulta",
"transfer": "Transferir",
"schema": "Esquema",
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index a42df71ae5..84b4f242b5 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -93,6 +93,7 @@
"new": "作成する",
"add": "追加",
"confirm-and-update": "確認して更新する",
+ "confirm-and-add": "確認して追加する",
"query": "お問い合わせ",
"transfer": "移行",
"schema": "スキーマ",
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index 0938cfe552..29c3574ca6 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -93,6 +93,7 @@
"new": "Mới",
"add": "Thêm",
"confirm-and-update": "Xác nhận và Cập nhật",
+ "confirm-and-add": "Xác nhận và Thêm",
"query": "Truy vấn",
"transfer": "Chuyển",
"schema": "Lược đồ",
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index 951d71f930..71387ee810 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -93,6 +93,7 @@
"new": "创建",
"add": "添加",
"confirm-and-update": "确认并更新",
+ "confirm-and-add": "确认并添加",
"query": "查询",
"transfer": "转移",
"schema": "Schema",
diff --git a/frontend/src/types/sql-review.prod.yaml b/frontend/src/types/sql-review.prod.yaml
index 32eda8365c..1be424e681 100644
--- a/frontend/src/types/sql-review.prod.yaml
+++ b/frontend/src/types/sql-review.prod.yaml
@@ -154,18 +154,6 @@ ruleList:
- type: TABLE_DISALLOW_SET_CHARSET
level: WARNING
engine: MYSQL
- - type: TABLE_DISALLOW_DDL
- level: WARNING
- engine: MSSQL
- - type: TABLE_DISALLOW_DDL
- level: WARNING
- engine: MYSQL
- - type: TABLE_DISALLOW_DML
- level: WARNING
- engine: MSSQL
- - type: TABLE_DISALLOW_DML
- level: WARNING
- engine: MYSQL
- type: TABLE_LIMIT_SIZE
level: WARNING
payload: