Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
chore: cleanup unused code and nolint comments (#18164)
h3n4lfaae9b8b0a63
diff --git a/backend/api/v1/auth_service.go b/backend/api/v1/auth_service.goindex 03c0cc2979..9ae6e1dfb5 100644--- a/backend/api/v1/auth_service.go+++ b/backend/api/v1/auth_service.go@@ -44,8 +44,8 @@ const (// Login rate limiting configuration.// Password phase: 10 failed attempts within 10 minutes.- passwordMaxFailedAttempts = 10 //nolint:unused // Will be used for password rate limiting- passwordLockoutWindow = 10 * time.Minute //nolint:unused // Will be used for password rate limiting+ passwordMaxFailedAttempts = 10 // Will be used for password rate limiting+ passwordLockoutWindow = 10 * time.Minute // Will be used for password rate limiting// MFA phase: 5 failed attempts within 5 minutes.mfaMaxFailedAttempts = 5@@ -56,7 +56,7 @@ const (errMsgInvalidCredentials = "invalid email or password"errMsgInvalidMFACode = "invalid MFA code"errMsgInvalidRecoveryCode = "invalid recovery code"- errMsgTooManyPassword = "too many failed login attempts, please try again later" //nolint:unused // Will be used for password rate limiting+ errMsgTooManyPassword = "too many failed login attempts, please try again later" // Will be used for password rate limitingerrMsgTooManyMFA = "too many failed MFA attempts, please try again later")diff --git a/backend/api/v1/masking_evaluator.go b/backend/api/v1/masking_evaluator.goindex 309cf63e20..64adee0db6 100644--- a/backend/api/v1/masking_evaluator.go+++ b/backend/api/v1/masking_evaluator.go@@ -313,7 +313,6 @@ func evaluateMaskingRulePolicyCondition(expression string, attributes map[stringreturn boolVar, nil}-// nolint:unusedfunc evaluateQueryExportPolicyCondition(expression string, attributes map[string]any) (bool, error) {if expression == "" {return true, nildiff --git a/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go b/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.goindex c8991f638c..5e60153f48 100644--- a/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go+++ b/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go@@ -76,14 +76,6 @@ type namingUKConventionRule struct {originalMetadata *model.DatabaseMetadata}-//nolint:unused-type indexMetaData struct {- indexName string- tableName string- line int- metaData map[string]string-}-func (*namingUKConventionRule) Name() string {return "naming-unique-key-convention"}diff --git a/backend/plugin/parser/pg/pg.go b/backend/plugin/parser/pg/pg.goindex bc2c16d7be..84d0217e75 100644--- a/backend/plugin/parser/pg/pg.go+++ b/backend/plugin/parser/pg/pg.go@@ -127,7 +127,6 @@ func ParsePostgreSQLPLBlock(plBlock string) (*ParseResult, error) {return result, nil}-// nolint:unusedfunc normalizePostgreSQLTableAlias(ctx parser.ITable_aliasContext) string {if ctx == nil {return ""@@ -142,7 +141,6 @@ func normalizePostgreSQLTableAlias(ctx parser.ITable_aliasContext) string {}}-// nolint:unusedfunc normalizePostgreSQLNameList(ctx parser.IName_listContext) []string {if ctx == nil {return nil@@ -199,7 +197,6 @@ func NormalizePostgreSQLQualifiedName(ctx parser.IQualified_nameContext) []strinreturn res}-// nolint:unusedfunc normalizePostgreSQLSetTarget(ctx parser.ISet_targetContext) []string {if ctx == nil {return []string{}@@ -211,7 +208,6 @@ func normalizePostgreSQLSetTarget(ctx parser.ISet_targetContext) []string {return res}-// nolint:unusedfunc normalizePostgreSQLOptIndirection(ctx parser.IOpt_indirectionContext) []string {var res []stringfor _, child := range ctx.AllIndirection_el() {@@ -274,7 +270,6 @@ func NormalizePostgreSQLColid(ctx parser.IColidContext) string {return strings.ToLower(ctx.GetText())}-// nolint:unusedfunc normalizePostgreSQLAnyIdentifier(ctx parser.IAny_identifierContext) string {if ctx == nil {return ""diff --git a/backend/plugin/schema/pg/get_database_definition.go b/backend/plugin/schema/pg/get_database_definition.goindex 190dfa09ec..33881c4051 100644--- a/backend/plugin/schema/pg/get_database_definition.go+++ b/backend/plugin/schema/pg/get_database_definition.go@@ -3794,6 +3794,32 @@ func buildTableSequencesMap(metadata *storepb.DatabaseSchemaMetadata) map[stringreturn tableSequencesMap}+func writeMaterializedViewCommentSDL(out io.Writer, schemaName string, view *storepb.MaterializedViewMetadata) error {+ if _, err := io.WriteString(out, `COMMENT ON MATERIALIZED VIEW "`); err != nil {+ return err+ }+ if _, err := io.WriteString(out, schemaName); err != nil {+ return err+ }+ if _, err := io.WriteString(out, `"."`); err != nil {+ return err+ }+ if _, err := io.WriteString(out, view.Name); err != nil {+ return err+ }+ if _, err := io.WriteString(out, `" IS '`); err != nil {+ return err+ }+ if _, err := io.WriteString(out, escapeSingleQuote(view.Comment)); err != nil {+ return err+ }+ if _, err := io.WriteString(out, `';`); err != nil {+ return err+ }+ _, err := io.WriteString(out, "\n\n")+ return err+}+// SDL Comment Functionsfunc writeSchemaCommentSDL(out io.Writer, schema *storepb.SchemaMetadata) error {@@ -3900,33 +3926,6 @@ func writeViewCommentSDL(out io.Writer, schemaName string, view *storepb.ViewMetreturn err}-// nolint:unused-func writeMaterializedViewCommentSDL(out io.Writer, schemaName string, view *storepb.MaterializedViewMetadata) error {- if _, err := io.WriteString(out, `COMMENT ON MATERIALIZED VIEW "`); err != nil {- return err- }- if _, err := io.WriteString(out, schemaName); err != nil {- return err- }- if _, err := io.WriteString(out, `"."`); err != nil {- return err- }- if _, err := io.WriteString(out, view.Name); err != nil {- return err- }- if _, err := io.WriteString(out, `" IS '`); err != nil {- return err- }- if _, err := io.WriteString(out, escapeSingleQuote(view.Comment)); err != nil {- return err- }- if _, err := io.WriteString(out, `';`); err != nil {- return err- }- _, err := io.WriteString(out, "\n\n")- return err-}-func writeFunctionCommentSDL(out io.Writer, schemaName string, function *storepb.FunctionMetadata) error {// Determine if this is a PROCEDURE or FUNCTION by checking the definitionobjectType := "FUNCTION"diff --git a/backend/plugin/schema/pg/get_database_metadata.go b/backend/plugin/schema/pg/get_database_metadata.goindex 757cda2f55..fe0f22c7c3 100644--- a/backend/plugin/schema/pg/get_database_metadata.go+++ b/backend/plugin/schema/pg/get_database_metadata.go@@ -2570,57 +2570,6 @@ func (*metadataExtractor) generateConstraintIndexDefinition(index *storepb.Index}parts = append(parts, fmt.Sprintf("(%s)", strings.Join(columnList, ", ")))}-- // End with semicolon- return strings.Join(parts, " ") + ";"-}--// generateForeignKeyDefinition generates the ALTER TABLE ADD CONSTRAINT definition for foreign keys-// nolint:unused-func (*metadataExtractor) generateForeignKeyDefinition(fk *storepb.ForeignKeyMetadata, tableName, schemaName string) string {- var parts []string-- // Start with ALTER TABLE- parts = append(parts, "ALTER TABLE ONLY")- if schemaName != "" && schemaName != "public" {- parts = append(parts, fmt.Sprintf("%s.%s", schemaName, tableName))- } else {- parts = append(parts, fmt.Sprintf("public.%s", tableName))- }-- // Add ADD CONSTRAINT- parts = append(parts, "ADD CONSTRAINT")- parts = append(parts, fk.Name)-- // Add FOREIGN KEY- if len(fk.Columns) > 0 {- parts = append(parts, fmt.Sprintf("FOREIGN KEY (%s)", strings.Join(fk.Columns, ", ")))- }-- // Add REFERENCES- if fk.ReferencedTable != "" {- var referencedTable string- if fk.ReferencedSchema != "" && fk.ReferencedSchema != "public" {- referencedTable = fmt.Sprintf("%s.%s", fk.ReferencedSchema, fk.ReferencedTable)- } else {- referencedTable = fmt.Sprintf("public.%s", fk.ReferencedTable)- }-- if len(fk.ReferencedColumns) > 0 {- parts = append(parts, fmt.Sprintf("REFERENCES %s(%s)", referencedTable, strings.Join(fk.ReferencedColumns, ", ")))- } else {- parts = append(parts, fmt.Sprintf("REFERENCES %s", referencedTable))- }- }-- // Add ON DELETE/UPDATE actions- if fk.OnDelete != "" && fk.OnDelete != "NO ACTION" {- parts = append(parts, fmt.Sprintf("ON DELETE %s", fk.OnDelete))- }- if fk.OnUpdate != "" && fk.OnUpdate != "NO ACTION" {- parts = append(parts, fmt.Sprintf("ON UPDATE %s", fk.OnUpdate))- }-// End with semicolonreturn strings.Join(parts, " ") + ";"}diff --git a/backend/plugin/schema/tidb/get_database_metadata.go b/backend/plugin/schema/tidb/get_database_metadata.goindex 25f4a20f8e..e029b2b3b1 100644--- a/backend/plugin/schema/tidb/get_database_metadata.go+++ b/backend/plugin/schema/tidb/get_database_metadata.go@@ -42,10 +42,9 @@ func GetDatabaseMetadata(schemaText string) (*storepb.DatabaseSchemaMetadata, er}extractor := &metadataExtractor{- schemas: make(map[string]*storepb.SchemaMetadata),- tables: make(map[tableKey]*storepb.TableMetadata),- views: make(map[viewKey]*storepb.ViewMetadata),- functions: make(map[functionKey]*storepb.FunctionMetadata),+ schemas: make(map[string]*storepb.SchemaMetadata),+ tables: make(map[tableKey]*storepb.TableMetadata),+ views: make(map[viewKey]*storepb.ViewMetadata),result: &storepb.DatabaseSchemaMetadata{Name: "",},@@ -84,16 +83,6 @@ func GetDatabaseMetadata(schemaText string) (*storepb.DatabaseSchemaMetadata, er})defaultSchema.Views = views- // Add functions to schema- var functions []*storepb.FunctionMetadata- for _, function := range extractor.functions {- functions = append(functions, function)- }- slices.SortFunc(functions, func(a, b *storepb.FunctionMetadata) int {- return strings.Compare(a.Name, b.Name)- })- defaultSchema.Functions = functions-extractor.result.Schemas = []*storepb.SchemaMetadata{defaultSchema}return extractor.result, nil@@ -109,16 +98,10 @@ type viewKey struct {name string}-type functionKey struct {- schema string // nolint:unused- name string // nolint:unused-}-type metadataExtractor struct {- schemas map[string]*storepb.SchemaMetadata- tables map[tableKey]*storepb.TableMetadata- views map[viewKey]*storepb.ViewMetadata- functions map[functionKey]*storepb.FunctionMetadata+ schemas map[string]*storepb.SchemaMetadata+ tables map[tableKey]*storepb.TableMetadata+ views map[viewKey]*storepb.ViewMetadataresult *storepb.DatabaseSchemaMetadata}