Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor(plan): show issue labels in two-step creation flow (#18586)

boojackfbe49368493f
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue
index 5110ca24a6..37e3fcd84e 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue
@@ -1,14 +1,31 @@
<template>
<CreateButton v-if="isCreating" />
<template v-else>
- <!-- Show unified actions for all plan states -->
- <UnifiedActionGroup
- :primary-action="primaryAction"
- :secondary-actions="secondaryActions"
- :disabled="actionsDisabled"
- :disabled-tooltip="disabledTooltip"
- @perform-action="handlePerformAction"
- />
+ <!-- Show CreateIssueButton when ISSUE_CREATE is the primary action -->
+ <template v-if="showCreateIssueButton">
+ <div class="flex items-center gap-x-2">
+ <CreateIssueButton />
+ <!-- Secondary actions dropdown -->
+ <UnifiedActionGroup
+ v-if="secondaryActions.length > 0"
+ :secondary-actions="secondaryActions"
+ :disabled="actionsDisabled"
+ :disabled-tooltip="disabledTooltip"
+ @perform-action="handlePerformAction"
+ />
+ </div>
+ </template>
+
+ <!-- Show unified actions for other plan states -->
+ <template v-else>
+ <UnifiedActionGroup
+ :primary-action="primaryAction"
+ :secondary-actions="secondaryActions"
+ :disabled="actionsDisabled"
+ :disabled-tooltip="disabledTooltip"
+ @perform-action="handlePerformAction"
+ />
+ </template>
<!-- Panels -->
<template v-if="issue">
@@ -42,47 +59,19 @@
</template>
<script setup lang="ts">
-import { create } from "@bufbuild/protobuf";
import { useDialog } from "naive-ui";
-import { computed, nextTick, ref } from "vue";
+import { computed, ref } from "vue";
import { useI18n } from "vue-i18n";
-import { useRouter } from "vue-router";
-import { useSpecsValidation } from "@/components/Plan/components/common";
-import { usePlanCheckStatus, usePlanContext } from "@/components/Plan/logic";
+import { usePlanContext } from "@/components/Plan/logic";
import { useResourcePoller } from "@/components/Plan/logic/poller";
import { useEditorState } from "@/components/Plan/logic/useEditorState";
-import {
- issueServiceClientConnect,
- rolloutServiceClientConnect,
-} from "@/grpcweb";
-import { PROJECT_V1_ROUTE_ISSUE_DETAIL_V1 } from "@/router/dashboard/projectV1";
-import {
- pushNotification,
- useCurrentProjectV1,
- useCurrentUserV1,
-} from "@/store";
+import { pushNotification } from "@/store";
import { usePlanStore } from "@/store/modules/v1/plan";
import { State } from "@/types/proto-es/v1/common_pb";
-import {
- CreateIssueRequestSchema,
- Issue_Type,
- IssueSchema,
- IssueStatus,
-} from "@/types/proto-es/v1/issue_service_pb";
-import type { Plan, Plan_Spec } from "@/types/proto-es/v1/plan_service_pb";
-import {
- CreateRolloutRequestSchema,
- Task_Type,
-} from "@/types/proto-es/v1/rollout_service_pb";
-import { Advice_Level } from "@/types/proto-es/v1/sql_service_pb";
-import {
- extractIssueUID,
- extractProjectResourceName,
- isValidIssueName,
- isValidPlanName,
-} from "@/utils";
+import { Task_Type } from "@/types/proto-es/v1/rollout_service_pb";
+import { isValidIssueName, isValidPlanName } from "@/utils";
import TaskRolloutActionPanel from "../../RolloutView/TaskRolloutActionPanel.vue";
-import { CreateButton } from "./create";
+import { CreateButton, CreateIssueButton } from "./create";
import { IssueReviewActionPanel, IssueStatusActionPanel } from "./panels";
import {
type ActionConfig,
@@ -92,32 +81,17 @@ import {
type RolloutAction,
type UnifiedAction,
UnifiedActionGroup,
+ usePlanAction,
} from "./unified";
-import { usePlanAction } from "./unified/action";
const { t } = useI18n();
-const router = useRouter();
const dialog = useDialog();
const resourcePoller = useResourcePoller();
-const { isCreating, plan, issueLabels, issue, rollout, events } =
- usePlanContext();
-const currentUser = useCurrentUserV1();
-const { project } = useCurrentProjectV1();
+const { isCreating, plan, issue, rollout, events } = usePlanContext();
const planStore = usePlanStore();
const editorState = useEditorState();
const { availableActions } = usePlanAction();
-// Use the validation hook for all specs
-const { isSpecEmpty } = useSpecsValidation(computed(() => plan.value.specs));
-
-// Use plan check status for issue creation validation
-const {
- getOverallStatus: planCheckSummaryStatus,
- hasRunning: hasRunningPlanChecks,
-} = usePlanCheckStatus(plan);
-
-// Policy for restricting issue creation when plan checks fail
-
// Computed property for actions disabled state.
const actionsDisabled = computed(() => {
return editorState.isEditing.value;
@@ -136,9 +110,6 @@ const pendingReviewAction = ref<IssueReviewAction | undefined>(undefined);
const pendingStatusAction = ref<IssueStatusAction | undefined>(undefined);
const pendingRolloutAction = ref<RolloutAction | undefined>(undefined);
-// Loading state for issue creation to prevent race conditions
-const isCreatingIssue = ref(false);
-
// Get the stage that contains database creation or export tasks
const rolloutStage = computed(() => {
if (!rollout.value) return undefined;
@@ -153,54 +124,24 @@ const rolloutStage = computed(() => {
);
});
-const primaryAction = computed((): ActionConfig | undefined => {
- const actions = availableActions.value;
- const isIssueOnly =
- !isValidPlanName(plan.value.name) && isValidIssueName(issue.value?.name);
-
- // Skip plan-specific actions for issue-only cases
- if (isIssueOnly) {
- // Skip ISSUE_CREATE, PLAN_REOPEN checks and go directly to issue actions
- }
- // ISSUE_CREATE is the highest priority when no issue exists
- else if (actions.includes("ISSUE_CREATE")) {
- // Check if all specs have valid statements (not empty)
- const hasValidSpecs = !plan.value.specs.some((spec) => isSpecEmpty(spec));
-
- // Check plan check status and policy restrictions
- const planChecksFailed =
- planCheckSummaryStatus.value === Advice_Level.ERROR;
- const isRestrictedByPolicy =
- planChecksFailed && (project.value.enforceSqlReview || false);
- const hasRunningChecks = hasRunningPlanChecks.value;
+// Issue-only mode: when viewing an issue without a valid plan (legacy issues)
+const isIssueOnly = computed(() => {
+ return (
+ !isValidPlanName(plan.value.name) && isValidIssueName(issue.value?.name)
+ );
+});
- const errors: string[] = [];
- if (!hasValidSpecs) {
- errors.push("Missing statement");
- }
- if (hasRunningChecks) {
- errors.push("Plan checks are running");
- }
- if (isRestrictedByPolicy) {
- errors.push(
- t(
- "custom-approval.issue-review.disallow-approve-reason.some-task-checks-didnt-pass"
- )
- );
- }
- if (project.value.forceIssueLabels && issueLabels.value.length === 0) {
- errors.push("Missing issue labels");
- }
+// Check if we should show CreateIssueButton instead of UnifiedActionGroup
+const showCreateIssueButton = computed(() => {
+ // Show CreateIssueButton when ISSUE_CREATE is available and not issue-only
+ return !isIssueOnly.value && availableActions.value.includes("ISSUE_CREATE");
+});
- return {
- action: "ISSUE_CREATE",
- disabled: errors.length > 0,
- description: errors.length > 0 ? errors.join(", ") : undefined,
- };
- }
+const primaryAction = computed((): ActionConfig | undefined => {
+ const actions = availableActions.value;
// PLAN_REOPEN is primary when plan is deleted (skip for issue-only)
- if (!isIssueOnly && actions.includes("PLAN_REOPEN")) {
+ if (!isIssueOnly.value && actions.includes("PLAN_REOPEN")) {
return { action: "PLAN_REOPEN" };
}
@@ -232,8 +173,6 @@ const primaryAction = computed((): ActionConfig | undefined => {
const secondaryActions = computed((): ActionConfig[] => {
const actions = availableActions.value;
- const isIssueOnly =
- !isValidPlanName(plan.value.name) && isValidIssueName(issue.value?.name);
const secondary: ActionConfig[] = [];
if (actions.includes("ISSUE_REVIEW_REJECT")) {
@@ -246,7 +185,7 @@ const secondaryActions = computed((): ActionConfig[] => {
secondary.push({ action: "ISSUE_STATUS_CLOSE" });
}
// Skip PLAN_CLOSE for issue-only cases
- if (!isIssueOnly && actions.includes("PLAN_CLOSE")) {
+ if (!isIssueOnly.value && actions.includes("PLAN_CLOSE")) {
secondary.push({ action: "PLAN_CLOSE" });
}
@@ -265,9 +204,6 @@ const handlePerformAction = async (action: UnifiedAction) => {
case "ISSUE_STATUS_RESOLVE":
pendingStatusAction.value = action as IssueStatusAction;
break;
- case "ISSUE_CREATE":
- await handleIssueCreate();
- break;
case "PLAN_CLOSE":
await handlePlanStateChange("PLAN_CLOSE");
break;
@@ -281,86 +217,6 @@ const handlePerformAction = async (action: UnifiedAction) => {
}
};
-const handleIssueCreate = async () => {
- if (!plan?.value) return;
-
- // Prevent race condition: check if already creating issue
- if (isCreatingIssue.value) {
- return;
- }
- isCreatingIssue.value = true;
-
- try {
- await doCreateIssue();
- } catch (error) {
- console.error("Failed to create issue:", error);
- pushNotification({
- module: "bytebase",
- style: "CRITICAL",
- title: "Failed to create issue",
- description: String(error),
- });
- } finally {
- isCreatingIssue.value = false;
- }
-};
-
-// Helper function to determine issue type from plan specs
-const getIssueTypeFromPlan = (planValue: Plan): Issue_Type => {
- // Check if any spec is for data export
- const hasExportDataSpec = planValue.specs.some(
- (spec: Plan_Spec) => spec.config?.case === "exportDataConfig"
- );
-
- if (hasExportDataSpec) {
- return Issue_Type.DATABASE_EXPORT;
- }
-
- // For both database creation and changes, use DATABASE_CHANGE
- return Issue_Type.DATABASE_CHANGE;
-};
-
-const doCreateIssue = async () => {
- const createIssueRequest = create(CreateIssueRequestSchema, {
- parent: project.value.name,
- issue: create(IssueSchema, {
- creator: `users/${currentUser.value.email}`,
- labels: [], // No labels for direct creation
- plan: plan.value.name,
- status: IssueStatus.OPEN,
- type: getIssueTypeFromPlan(plan.value),
- rollout: "",
- }),
- });
-
- // Create issue first
- const createdIssue =
- await issueServiceClientConnect.createIssue(createIssueRequest);
-
- const createRolloutRequest = create(CreateRolloutRequestSchema, {
- parent: project.value.name,
- rollout: {
- plan: plan.value.name,
- },
- });
-
- // Then create rollout
- await rolloutServiceClientConnect.createRollout(createRolloutRequest);
-
- // Emit status changed to refresh the UI
- events.emit("status-changed", { eager: true });
-
- nextTick(() => {
- router.push({
- name: PROJECT_V1_ROUTE_ISSUE_DETAIL_V1,
- params: {
- projectId: extractProjectResourceName(plan.value.name),
- issueId: extractIssueUID(createdIssue.name),
- },
- });
- });
-};
-
const handlePlanStateChange = async (action: PlanAction) => {
if (!plan?.value) return;
@@ -369,16 +225,12 @@ const handlePlanStateChange = async (action: PlanAction) => {
const content = isClosing
? t("plan.state.close-confirm")
: t("plan.state.reopen-confirm");
- const positiveText = title;
const newState = isClosing ? State.DELETED : State.ACTIVE;
- const errorMessage = isClosing
- ? "Failed to close plan:"
- : "Failed to reopen plan:";
const d = dialog.warning({
title,
content,
- positiveText,
+ positiveText: title,
negativeText: t("common.cancel"),
onPositiveClick: async () => {
d.loading = true;
@@ -389,11 +241,10 @@ const handlePlanStateChange = async (action: PlanAction) => {
// The plan context should automatically refresh and redirect or update the UI.
await resourcePoller.refreshResources();
} catch (error) {
- console.error(errorMessage, error);
pushNotification({
module: "bytebase",
style: "CRITICAL",
- title: "Failed to update plan",
+ title: t("common.failed"),
description: String(error),
});
}
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vue
new file mode 100644
index 0000000000..5822a9c396
--- /dev/null
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/CreateIssueButton.vue
@@ -0,0 +1,238 @@
+<template>
+ <NPopover
+ trigger="click"
+ placement="bottom"
+ :show="showPopover"
+ @update:show="showPopover = $event"
+ >
+ <template #trigger>
+ <NTooltip :disabled="errors.length === 0" placement="top">
+ <template #trigger>
+ <NButton
+ type="primary"
+ size="medium"
+ tag="div"
+ :disabled="errors.length > 0 || loading"
+ :loading="loading"
+ >
+ {{ $t("plan.ready-for-review") }}
+ </NButton>
+ </template>
+ <template #default>
+ <ErrorList :errors="errors" />
+ </template>
+ </NTooltip>
+ </template>
+
+ <template #default>
+ <div class="w-72 flex flex-col gap-y-3 p-1">
+ <div class="flex flex-col gap-y-1">
+ <div class="font-medium text-control flex items-center gap-x-1">
+ {{ $t("issue.labels") }}
+ <RequiredStar v-if="project.forceIssueLabels" />
+ </div>
+ <IssueLabelSelector
+ :disabled="loading"
+ :selected="selectedLabels"
+ :project="project"
+ :size="'medium'"
+ @update:selected="selectedLabels = $event"
+ />
+ </div>
+ <div class="flex justify-end gap-x-2">
+ <NButton size="small" quaternary @click="showPopover = false">
+ {{ $t("common.cancel") }}
+ </NButton>
+ <NTooltip :disabled="confirmErrors.length === 0" placement="top">
+ <template #trigger>
+ <NButton
+ type="primary"
+ size="small"
+ :disabled="confirmErrors.length > 0 || loading"
+ :loading="loading"
+ @click="doCreateIssue"
+ >
+ {{ $t("common.confirm") }}
+ </NButton>
+ </template>
+ <template #default>
+ <ErrorList :errors="confirmErrors" />
+ </template>
+ </NTooltip>
+ </div>
+ </div>
+ </template>
+ </NPopover>
+</template>
+
+<script setup lang="ts">
+import { create } from "@bufbuild/protobuf";
+import { NButton, NPopover, NTooltip } from "naive-ui";
+import { computed, nextTick, ref, watch } from "vue";
+import { useI18n } from "vue-i18n";
+import { useRouter } from "vue-router";
+import IssueLabelSelector from "@/components/IssueV1/components/IssueLabelSelector.vue";
+import {
+ ErrorList,
+ useSpecsValidation,
+} from "@/components/Plan/components/common";
+import { usePlanCheckStatus, usePlanContext } from "@/components/Plan/logic";
+import RequiredStar from "@/components/RequiredStar.vue";
+import {
+ issueServiceClientConnect,
+ rolloutServiceClientConnect,
+} from "@/grpcweb";
+import { PROJECT_V1_ROUTE_ISSUE_DETAIL_V1 } from "@/router/dashboard/projectV1";
+import {
+ pushNotification,
+ useCurrentProjectV1,
+ useCurrentUserV1,
+} from "@/store";
+import {
+ CreateIssueRequestSchema,
+ Issue_Type,
+ IssueSchema,
+ IssueStatus,
+} from "@/types/proto-es/v1/issue_service_pb";
+import type { Plan, Plan_Spec } from "@/types/proto-es/v1/plan_service_pb";
+import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";
+import { Advice_Level } from "@/types/proto-es/v1/sql_service_pb";
+import { extractIssueUID, extractProjectResourceName } from "@/utils";
+
+const { t } = useI18n();
+const router = useRouter();
+const { project } = useCurrentProjectV1();
+const { plan, events } = usePlanContext();
+const currentUser = useCurrentUserV1();
+
+const loading = ref(false);
+const showPopover = ref(false);
+const selectedLabels = ref<string[]>([]);
+
+// Use the validation hook for all specs
+const { isSpecEmpty } = useSpecsValidation(computed(() => plan.value.specs));
+
+// Use plan check status for issue creation validation
+const {
+ getOverallStatus: planCheckSummaryStatus,
+ hasRunning: hasRunningPlanChecks,
+} = usePlanCheckStatus(plan);
+
+// Reset labels when popover opens
+watch(showPopover, (show) => {
+ if (show) {
+ selectedLabels.value = [];
+ }
+});
+
+// Errors that disable the main button
+const errors = computed(() => {
+ const list: string[] = [];
+
+ // Check if all specs have valid statements
+ if (plan.value.specs.some((spec) => isSpecEmpty(spec))) {
+ list.push(t("plan.navigator.statement-empty"));
+ }
+
+ // Check if plan checks are running
+ if (hasRunningPlanChecks.value) {
+ list.push(
+ t(
+ "custom-approval.issue-review.disallow-approve-reason.some-task-checks-are-still-running"
+ )
+ );
+ }
+
+ // Check if plan checks failed and policy restricts
+ const planChecksFailed = planCheckSummaryStatus.value === Advice_Level.ERROR;
+ if (planChecksFailed && project.value.enforceSqlReview) {
+ list.push(
+ t(
+ "custom-approval.issue-review.disallow-approve-reason.some-task-checks-didnt-pass"
+ )
+ );
+ }
+
+ return list;
+});
+
+// Errors that disable the confirm button in popover
+const confirmErrors = computed(() => {
+ const list: string[] = [];
+
+ if (project.value.forceIssueLabels && selectedLabels.value.length === 0) {
+ list.push(t("plan.labels-required-for-review"));
+ }
+
+ return list;
+});
+
+// Helper function to determine issue type from plan specs
+const getIssueTypeFromPlan = (planValue: Plan): Issue_Type => {
+ const hasExportDataSpec = planValue.specs.some(
+ (spec: Plan_Spec) => spec.config?.case === "exportDataConfig"
+ );
+
+ if (hasExportDataSpec) {
+ return Issue_Type.DATABASE_EXPORT;
+ }
+
+ return Issue_Type.DATABASE_CHANGE;
+};
+
+const doCreateIssue = async () => {
+ if (loading.value) return;
+ if (confirmErrors.value.length > 0) return;
+
+ loading.value = true;
+
+ try {
+ const createIssueRequest = create(CreateIssueRequestSchema, {
+ parent: project.value.name,
+ issue: create(IssueSchema, {
+ creator: `users/${currentUser.value.email}`,
+ labels: selectedLabels.value,
+ plan: plan.value.name,
+ status: IssueStatus.OPEN,
+ type: getIssueTypeFromPlan(plan.value),
+ rollout: "",
+ }),
+ });
+
+ const createdIssue =
+ await issueServiceClientConnect.createIssue(createIssueRequest);
+
+ const createRolloutRequest = create(CreateRolloutRequestSchema, {
+ parent: project.value.name,
+ rollout: {
+ plan: plan.value.name,
+ },
+ });
+
+ await rolloutServiceClientConnect.createRollout(createRolloutRequest);
+
+ events.emit("status-changed", { eager: true });
+
+ showPopover.value = false;
+
+ nextTick(() => {
+ router.push({
+ name: PROJECT_V1_ROUTE_ISSUE_DETAIL_V1,
+ params: {
+ projectId: extractProjectResourceName(plan.value.name),
+ issueId: extractIssueUID(createdIssue.name),
+ },
+ });
+ });
+ } catch (error) {
+ pushNotification({
+ module: "bytebase",
+ style: "CRITICAL",
+ title: t("common.failed"),
+ description: String(error),
+ });
+ } finally {
+ loading.value = false;
+ }
+};
+</script>
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts
index b30ba24e7e..14255371a7 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts
@@ -1,3 +1,4 @@
import CreateButton from "./CreateButton.vue";
+import CreateIssueButton from "./CreateIssueButton.vue";
-export { CreateButton };
+export { CreateButton, CreateIssueButton };
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/index.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/index.ts
index 1096337f66..944b49c168 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/index.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/index.ts
@@ -1,3 +1,4 @@
+export { usePlanAction } from "./action";
export { default as UnifiedActionButton } from "./UnifiedActionButton.vue";
export { default as UnifiedActionGroup } from "./UnifiedActionGroup.vue";
export * from "./types";
diff --git a/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue b/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue
index 2dda4902d0..b4c914b396 100644
--- a/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue
+++ b/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue
@@ -23,13 +23,6 @@
</div>
</div>
<DescriptionSection v-if="showDescriptionSection" />
- <div class=" max-w-120 my-4">
- <IssueLabels
- v-if="availableActions.includes('ISSUE_CREATE')"
- :project="project"
- v-model:value="issueLabels"
- />
- </div>
</div>
</template>
@@ -38,21 +31,16 @@ import { CircleDotDashedIcon, MenuIcon } from "lucide-vue-next";
import { NButton, NTag } from "naive-ui";
import { computed } from "vue";
import { useRoute } from "vue-router";
-import IssueLabels from "@/components/IssueV1/components/Sidebar/IssueLabels.vue";
import { PROJECT_V1_ROUTE_ISSUE_DETAIL_V1 } from "@/router/dashboard/projectV1";
-import { useCurrentProjectV1 } from "@/store";
import { isValidPlanName } from "@/utils";
import { usePlanContext } from "../../logic";
import { useSidebarContext } from "../../logic/sidebar";
import Actions from "./Actions";
-import { usePlanAction } from "./Actions/unified/action";
import DescriptionSection from "./DescriptionSection.vue";
import TitleInput from "./TitleInput.vue";
const route = useRoute();
-const { isCreating, plan, issueLabels } = usePlanContext();
-const { project } = useCurrentProjectV1();
-const { availableActions } = usePlanAction();
+const { isCreating, plan } = usePlanContext();
const hasSidebar = computed(() => {
// Check if we're in a layout with sidebar (Issue overview tab only)
diff --git a/frontend/src/components/Plan/logic/context.ts b/frontend/src/components/Plan/logic/context.ts
index 5aaa349df1..14bb182200 100644
--- a/frontend/src/components/Plan/logic/context.ts
+++ b/frontend/src/components/Plan/logic/context.ts
@@ -30,7 +30,6 @@ export type PlanContext = {
issue: Ref<Issue | undefined>;
rollout: Ref<Rollout | undefined>;
taskRuns: Ref<TaskRun[]>;
- issueLabels: Ref<string[]>;
readonly: ComputedRef<boolean>;
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index d6be4ab1d6..940188febf 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -1167,6 +1167,7 @@
"add-spec": "Add Change",
"select-targets": "Select Targets",
"ready-for-review": "Ready for Review",
+ "labels-required-for-review": "Labels are required before requesting review",
"overview": {
"no-checks": "No checks"
},
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index 6bcc247549..726502c476 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -1167,6 +1167,7 @@
"add-spec": "Agregar especificación",
"select-targets": "Seleccionar objetivos",
"ready-for-review": "Listo para revisión",
+ "labels-required-for-review": "Se requieren etiquetas antes de solicitar revisión",
"overview": {
"no-checks": "Sin controles"
},
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index 3904fb2d30..21b2d1015b 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -1167,6 +1167,7 @@
"add-spec": "仕様を追加",
"select-targets": "ターゲットを選択",
"ready-for-review": "レビュー準備完了",
+ "labels-required-for-review": "レビューをリクエストする前にラベルが必要です",
"overview": {
"no-checks": "チェックなし"
},
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index b0a366f790..9a9a64d86f 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -1167,6 +1167,7 @@
"add-spec": "Thêm thông số kỹ thuật",
"select-targets": "Chọn mục tiêu",
"ready-for-review": "Sẵn sàng để xem xét",
+ "labels-required-for-review": "Cần có nhãn trước khi yêu cầu xem xét",
"overview": {
"no-checks": "Không kiểm tra"
},
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index d3eab02331..4b81e2e106 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -1167,6 +1167,7 @@
"add-spec": "添加变更项",
"select-targets": "选择目标库",
"ready-for-review": "提交审批",
+ "labels-required-for-review": "提交审批前需要选择标签",
"overview": {
"no-checks": "没有检查"
},
diff --git a/frontend/src/views/project/CICDLayout.vue b/frontend/src/views/project/CICDLayout.vue
index ed91ac9c35..e6d16821be 100644
--- a/frontend/src/views/project/CICDLayout.vue
+++ b/frontend/src/views/project/CICDLayout.vue
@@ -131,7 +131,6 @@ providePlanContext({
issue,
rollout,
taskRuns,
- issueLabels: ref<string[]>(issue.value?.labels ?? []),
...planBaseContext,
});