Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(fe): preserve BigInt precision in SQL Editor display (#18886)

Vincent Huangfd3bf875a351
diff --git a/frontend/package.json b/frontend/package.json
index 918aadedeb..8b34f3afba 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -47,6 +47,7 @@
"js-yaml": "4.1.1",
"jszip": "^3.10.1",
"lodash-es": "4.17.21",
+ "lossless-json": "^4.3.0",
"lucide-static": "^0.555.0",
"lucide-vue-next": "^0.555.0",
"markdown-it": "^14.1.0",
diff --git a/frontend/pnpm-lock.yaml b/frontend/pnpm-lock.yaml
index 5a158e4995..0f59038871 100644
--- a/frontend/pnpm-lock.yaml
+++ b/frontend/pnpm-lock.yaml
@@ -100,6 +100,9 @@ importers:
lodash-es:
specifier: 4.17.21
version: 4.17.21
+ lossless-json:
+ specifier: ^4.3.0
+ version: 4.3.0
lucide-static:
specifier: ^0.555.0
version: 0.555.0
@@ -4122,6 +4125,9 @@ packages:
resolution: {integrity: sha512-9Ri+o0JYgehTaVBBDoMqIl8GXtbWg711O3srftcHhZ0dqnETqLaoIK0x17fUw9rFSlK/0NlsKe0Ahhyl5pXE2g==}
+ resolution: {integrity: sha512-ToxOC+SsduRmdSuoLZLYAr5zy1Qu7l5XhmPWM3zefCZ5IcrzW/h108qbJUKfOlDlhvhjUK84+8PSVX0kxnit0g==}
+
resolution: {integrity: sha512-JNAzZcXrCt42VGLuYz0zfAzDfAvJWW6AfYlDBQyDV5DClI2m5sAmK+OIO7s59XfsRsWHp02jAJrRadPRGTt6SQ==}
@@ -10212,6 +10218,8 @@ snapshots:
+
diff --git a/frontend/src/composables/utils.ts b/frontend/src/composables/utils.ts
index 6de5350e7c..925f695b73 100644
--- a/frontend/src/composables/utils.ts
+++ b/frontend/src/composables/utils.ts
@@ -1,6 +1,11 @@
import { create as createProto } from "@bufbuild/protobuf";
import { NullValue } from "@bufbuild/protobuf/wkt";
import { orderBy } from "lodash-es";
+import {
+ isLosslessNumber,
+ type LosslessNumber,
+ parse as losslessParse,
+} from "lossless-json";
import { stringify } from "uuid";
import type { SQLResultSetV1 } from "@/types";
import type { QueryRow, RowValue } from "@/types/proto-es/v1/sql_service_pb";
@@ -14,6 +19,15 @@ type NoSQLRowData = {
value: unknown;
};
+// Reviver for lossless-json that converts LosslessNumber to string
+// to preserve precision for large integers (> 2^53-1)
+export const losslessReviver = (value: unknown): unknown => {
+ if (isLosslessNumber(value)) {
+ return (value as LosslessNumber).toString();
+ }
+ return value;
+};
+
const base64ToArrayBuffer = (base64: string): ArrayBuffer => {
const binaryString = atob(base64);
const bytes = new Uint8Array(binaryString.length);
@@ -57,7 +71,8 @@ const flattenNoSQLColumn = (value: unknown): unknown => {
}
return new Date(parseInt(dateObj["$numberLong"] as string));
case "$numberLong":
- return parseInt(dict[key] as string);
+ // Return as string to preserve precision for large integers (> 2^53-1)
+ return dict[key] as string;
case "$numberDouble":
return parseFloat(dict[key] as string);
case "$numberInt":
@@ -247,7 +262,12 @@ export const flattenNoSQLResult = (resultSet: SQLResultSetV1) => {
) {
continue;
}
- const data = JSON.parse(row.values[0].kind.value);
+ // Use lossless-json to preserve precision for large integers (> 2^53-1)
+ const data = losslessParse(
+ row.values[0].kind.value,
+ null,
+ losslessReviver
+ ) as Record<string, unknown>;
const values: RowValue[] = Array.from({ length: columns.length }).map(
(_) =>
createProto(RowValueSchema, {
@@ -325,7 +345,12 @@ const getNoSQLRows = (row: QueryRow): NoSQLRowData[] | undefined => {
if (row.values.length !== 1 || row.values[0].kind.case !== "stringValue") {
return;
}
- const parsedRow = JSON.parse(row.values[0].kind.value) as {
+ // Use lossless-json to preserve precision for large integers (> 2^53-1)
+ const parsedRow = losslessParse(
+ row.values[0].kind.value,
+ null,
+ losslessReviver
+ ) as {
[key: string]: Record<string, unknown>;
};
const results: NoSQLRowData[] = [];
diff --git a/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/DetailPanel.vue b/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/DetailPanel.vue
index f048d164de..dc13a8b489 100644
--- a/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/DetailPanel.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/DetailPanel.vue
@@ -145,6 +145,10 @@
<script setup lang="ts">
import { onKeyStroke, useLocalStorage } from "@vueuse/core";
+import {
+ parse as losslessParse,
+ stringify as losslessStringify,
+} from "lossless-json";
import {
BracesIcon,
ChevronDownIcon,
@@ -248,11 +252,12 @@ const contentClass = computed(() => {
const copyContent = computed(() => {
const raw = content.value ?? "";
- // For JSON content
+ // For JSON content, use lossless-json to preserve precision for large integers (> 2^53-1)
+ // No reviver needed: losslessStringify correctly outputs LosslessNumber as numeric literals
if (guessedIsJSON.value && format.value) {
try {
- const obj = JSON.parse(raw);
- return JSON.stringify(obj, null, " ");
+ const obj = losslessParse(raw);
+ return losslessStringify(obj, null, " ") ?? raw;
} catch {
console.warn(
"[DetailPanel]",
diff --git a/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/PrettyJSON.vue b/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/PrettyJSON.vue
index 74dc95a116..ab41049688 100644
--- a/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/PrettyJSON.vue
+++ b/frontend/src/views/sql-editor/EditorCommon/ResultView/DetailPanel/PrettyJSON.vue
@@ -33,8 +33,11 @@ watch(
try {
const { prettyPrintJson } = await import("pretty-print-json");
+ const { parse } = await import("lossless-json");
+ const { losslessReviver } = await import("@/composables/utils");
await import("./pretty-print-json.css");
- const obj = JSON.parse(content);
+ // Use lossless-json to preserve precision for large integers (> 2^53-1)
+ const obj = parse(content, null, losslessReviver);
const html = prettyPrintJson.toHtml(obj, {
quoteKeys: true,
trailingCommas: false,