Skip to content

Scheduling infrastructure for absolutely everyone.

refactor: move a constant to a dedicated file in App store package (#23671)

Benny Joo086bae03d363
diff --git a/packages/app-store/constants.ts b/packages/app-store/constants.ts
index ab3cd2d5fb4..7a20c9e8fa6 100644
--- a/packages/app-store/constants.ts
+++ b/packages/app-store/constants.ts
@@ -1,3 +1,5 @@
export const MeetLocationType = "integrations:google:meet";
export const MSTeamsLocationType = "integrations:office365_video";
+
+export const DailyLocationType = "integrations:daily";
diff --git a/packages/app-store/locations.ts b/packages/app-store/locations.ts
index 7e646b7d7c1..3be5e783f22 100644
--- a/packages/app-store/locations.ts
+++ b/packages/app-store/locations.ts
@@ -13,10 +13,12 @@ import type { EventLocationTypeFromAppMeta } from "../types/App";
import {
MeetLocationType as importedMeetLocationType,
MSTeamsLocationType as importedMSTeamsLocationType,
+ DailyLocationType as importedDailyLocationType,
} from "./constants";
export const MeetLocationType = importedMeetLocationType;
export const MSTeamsLocationType = importedMSTeamsLocationType;
+export const DailyLocationType = importedDailyLocationType;
export type DefaultEventLocationType = {
default: true;
@@ -69,7 +71,6 @@ export type EventLocationTypeFromApp = Ensure<
export type EventLocationType = DefaultEventLocationType | EventLocationTypeFromApp;
-export const DailyLocationType = "integrations:daily";
export const CalVideoLocationType = DailyLocationType;
/**
diff --git a/packages/features/bookings/lib/handleCancelBooking.ts b/packages/features/bookings/lib/handleCancelBooking.ts
index 047a15a1080..cac3852e373 100644
--- a/packages/features/bookings/lib/handleCancelBooking.ts
+++ b/packages/features/bookings/lib/handleCancelBooking.ts
@@ -1,8 +1,8 @@
import type { Prisma, WorkflowReminder } from "@prisma/client";
import type { z } from "zod";
+import { DailyLocationType } from "@calcom/app-store/constants";
import { FAKE_DAILY_CREDENTIAL } from "@calcom/app-store/dailyvideo/lib/VideoApiAdapter";
-import { DailyLocationType } from "@calcom/app-store/locations";
import dayjs from "@calcom/dayjs";
import { sendCancelledEmailsAndSMS } from "@calcom/emails";
import { getCalEventResponses } from "@calcom/features/bookings/lib/getCalEventResponses";
diff --git a/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.integration-test.ts b/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.integration-test.ts
index 5a1c3cfa999..e7aea358961 100644
--- a/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.integration-test.ts
+++ b/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.integration-test.ts
@@ -1,7 +1,7 @@
import type { Booking, User, Webhook } from "@prisma/client";
import { afterAll, beforeAll, describe, expect, test, vi } from "vitest";
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import { getMeetingSessionsFromRoomName } from "@calcom/features/tasker/tasks/triggerNoShow/getMeetingSessionsFromRoomName";
import { triggerHostNoShow } from "@calcom/features/tasker/tasks/triggerNoShow/triggerHostNoShow";
import { sendGenericWebhookPayload } from "@calcom/features/webhooks/lib/sendPayload";
diff --git a/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts b/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts
index c85452202fb..3765521d975 100644
--- a/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts
+++ b/packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts
@@ -1,4 +1,4 @@
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import dayjs from "@calcom/dayjs";
import tasker from "@calcom/features/tasker";
import getWebhooks from "@calcom/features/webhooks/lib/getWebhooks";
diff --git a/packages/lib/defaultEvents.ts b/packages/lib/defaultEvents.ts
index c79383abedc..8ccd6463b02 100644
--- a/packages/lib/defaultEvents.ts
+++ b/packages/lib/defaultEvents.ts
@@ -1,6 +1,6 @@
import type { Prisma, SelectedCalendar } from "@prisma/client";
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import slugify from "@calcom/lib/slugify";
import { PeriodType, SchedulingType } from "@calcom/prisma/enums";
import type { userSelect } from "@calcom/prisma/selects";
diff --git a/packages/lib/server/getDefaultLocations.ts b/packages/lib/server/getDefaultLocations.ts
index 275647a6ff2..4c41d408482 100644
--- a/packages/lib/server/getDefaultLocations.ts
+++ b/packages/lib/server/getDefaultLocations.ts
@@ -1,5 +1,5 @@
import getAppKeysFromSlug from "@calcom/app-store/_utils/getAppKeysFromSlug";
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import getApps from "@calcom/app-store/utils";
import { getUsersCredentialsIncludeServiceAccountKey } from "@calcom/lib/server/getUsersCredentials";
import { userMetadata as userMetadataSchema } from "@calcom/prisma/zod-utils";
diff --git a/packages/lib/videoClient.ts b/packages/lib/videoClient.ts
index 4025e0d0a9c..473718e127f 100644
--- a/packages/lib/videoClient.ts
+++ b/packages/lib/videoClient.ts
@@ -1,8 +1,8 @@
import short from "short-uuid";
import { v5 as uuidv5 } from "uuid";
+import { DailyLocationType } from "@calcom/app-store/constants";
import { getDailyAppKeys } from "@calcom/app-store/dailyvideo/lib/getDailyAppKeys";
-import { DailyLocationType } from "@calcom/app-store/locations";
import { VideoApiAdapterMap } from "@calcom/app-store/video.adapters.generated";
import { sendBrokenIntegrationEmail } from "@calcom/emails";
import { getUid } from "@calcom/lib/CalEventParser";
diff --git a/packages/trpc/server/routers/viewer/bookings/editLocation.schema.ts b/packages/trpc/server/routers/viewer/bookings/editLocation.schema.ts
index 2fbf0e8a4e5..1849b3f5970 100644
--- a/packages/trpc/server/routers/viewer/bookings/editLocation.schema.ts
+++ b/packages/trpc/server/routers/viewer/bookings/editLocation.schema.ts
@@ -1,6 +1,6 @@
import { z } from "zod";
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import { commonBookingSchema } from "./types";
diff --git a/packages/trpc/server/routers/viewer/eventTypes/heavy/create.handler.ts b/packages/trpc/server/routers/viewer/eventTypes/heavy/create.handler.ts
index 75cae763a52..e20710a5c4c 100644
--- a/packages/trpc/server/routers/viewer/eventTypes/heavy/create.handler.ts
+++ b/packages/trpc/server/routers/viewer/eventTypes/heavy/create.handler.ts
@@ -1,6 +1,6 @@
import { Prisma } from "@prisma/client";
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import { getDefaultLocations } from "@calcom/lib/server/getDefaultLocations";
import { EventTypeRepository } from "@calcom/lib/server/repository/eventTypeRepository";
import type { PrismaClient } from "@calcom/prisma";
diff --git a/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts b/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts
index cc511959f64..8e215a28633 100644
--- a/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts
+++ b/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts
@@ -2,7 +2,7 @@ import { Prisma } from "@prisma/client";
import type { NextApiResponse, GetServerSidePropsContext } from "next";
import type { appDataSchemas } from "@calcom/app-store/apps.schemas.generated";
-import { DailyLocationType } from "@calcom/app-store/locations";
+import { DailyLocationType } from "@calcom/app-store/constants";
import updateChildrenEventTypes from "@calcom/features/ee/managed-event-types/lib/handleChildrenEventTypes";
import {
allowDisablingAttendeeConfirmationEmails,